[clang] 7fde4e2 - Add some helpers to better check Scope's kind. NFC

Author: Jun Zhang Date: 2022-04-16T11:31:40+08:00 New Revision: 7fde4e221300dbdefe9cdd70ff59f22f1dc9aee9 URL: https://github.com/llvm/llvm-project/commit/7fde4e221300dbdefe9cdd70ff59f22f1dc9aee9 DIFF: https://github.com/llvm/llvm-project/commit/7fde4e221300dbdefe9cdd70ff59f22f1dc9aee9.diff

[clang] 468c7b6 - [test] Test -Werror=foo -Wfoo & -Werror -Wno-error=foo -Wfoo

Author: Fangrui Song Date: 2022-04-15T20:14:07-07:00 New Revision: 468c7b65e578dd8decc3d7a2f9dce88410503fd1 URL: https://github.com/llvm/llvm-project/commit/468c7b65e578dd8decc3d7a2f9dce88410503fd1 DIFF: https://github.com/llvm/llvm-project/commit/468c7b65e578dd8decc3d7a2f9dce88410503fd1.diff

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

LegalizeAdulthood added a comment. This is an initial pass. While I believe the code handles other scenarios, I still need to add some more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123889/new/ https://reviews.llvm.org/D123889

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, klimek. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. LegalizeAdulthood requested review of this revision. When a

[PATCH] D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str.

python3kgae abandoned this revision. python3kgae added a comment. Thanks. Close this RP then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123887/new/ https://reviews.llvm.org/D123887 ___ cfe-commits

[PATCH] D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str.

beanz added a comment. I already merged a fix to resolve the test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123887/new/ https://reviews.llvm.org/D123887 ___ cfe-commits mailing list

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae added a comment. Created new patch to fix the test fail at https://reviews.llvm.org/D123887 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 ___

[PATCH] D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str.

python3kgae created this revision. python3kgae added a reviewer: wolfgangp. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123887

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 423198. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files:

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8760b51ee0f: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective` (authored by tianshilei1992). Repository: rG LLVM Github Monorepo

[clang] e8760b5 - [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

Author: Shilei Tian Date: 2022-04-15T21:34:28-04:00 New Revision: e8760b51ee0f972587cb0af922a3f828ab6926d6 URL: https://github.com/llvm/llvm-project/commit/e8760b51ee0f972587cb0af922a3f828ab6926d6 DIFF: https://github.com/llvm/llvm-project/commit/e8760b51ee0f972587cb0af922a3f828ab6926d6.diff

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

cishida added a comment. > we might not always want to transform an absolute path because the resulting > relative include name might get remapped in a headermap, for example in test > known_files_only_hmap.c. But how does it work with modules where we need > relative includes? Is the setup in

[clang] 33b604d - [OpenMP] Fix linting diagnostics in the linker wrapper

Author: Joseph Huber Date: 2022-04-15T21:19:29-04:00 New Revision: 33b604d1c3017a6d09e47384566353efe7bbfe57 URL: https://github.com/llvm/llvm-project/commit/33b604d1c3017a6d09e47384566353efe7bbfe57 DIFF: https://github.com/llvm/llvm-project/commit/33b604d1c3017a6d09e47384566353efe7bbfe57.diff

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

beanz added a comment. @wolfgangp I can't reproduce the failure locally, but I have a guess what's going wrong. I _think_ the issue is that the SmallStrings aren't null terminated and the cleared allocations aren't zero'd. I pushed a speculative fix in rG329abac134a3

[clang] 329abac - Blind stab in the dark to fix a bot failure

Author: Chris Bieneman Date: 2022-04-15T20:12:59-05:00 New Revision: 329abac134a35acc81bfab30a87130a3c208be2a URL: https://github.com/llvm/llvm-project/commit/329abac134a35acc81bfab30a87130a3c208be2a DIFF:

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

wolfgangp added a comment. Hi, there seems to be a unit test failure, for example here . /home/buildbot/as-worker-91/clang-with-lto-ubuntu/build/stage1/tools/clang/unittests/Driver/./ClangDriverTests

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG984a0dc38655: [OpenMP] Use new offloading binary when embedding offloading images (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] 984a0dc - [OpenMP] Use new offloading binary when embedding offloading images

Author: Joseph Huber Date: 2022-04-15T20:35:26-04:00 New Revision: 984a0dc386553f28068716a087d65ccf8a92889b URL: https://github.com/llvm/llvm-project/commit/984a0dc386553f28068716a087d65ccf8a92889b DIFF: https://github.com/llvm/llvm-project/commit/984a0dc386553f28068716a087d65ccf8a92889b.diff

[clang] cac8116 - [OpenMP] Don't manually strip sections in the linker wrapper

Author: Joseph Huber Date: 2022-04-15T20:35:25-04:00 New Revision: cac81161ed1386b32443e13ab513c6a3d081d6a7 URL: https://github.com/llvm/llvm-project/commit/cac81161ed1386b32443e13ab513c6a3d081d6a7 DIFF: https://github.com/llvm/llvm-project/commit/cac81161ed1386b32443e13ab513c6a3d081d6a7.diff

[PATCH] D123885: Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'"""

cjdb created this revision. cjdb added reviewers: rsmith, aaron.ballman. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber:

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 423190. python3kgae added a comment. Fix format in Options.td. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files:

[clang] fc30901 - Extend support for std::move etc to also cover std::as_const and

Author: Richard Smith Date: 2022-04-15T16:31:39-07:00 New Revision: fc3090109643af8d2da9822d0f99c84742b9c877 URL: https://github.com/llvm/llvm-project/commit/fc3090109643af8d2da9822d0f99c84742b9c877 DIFF: https://github.com/llvm/llvm-project/commit/fc3090109643af8d2da9822d0f99c84742b9c877.diff

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:6701 + class DXCJoinedOrSeparate : Option<["/", "-"], name, delete Comment at: clang/include/clang/Driver/Options.td:6715 + Group, Flags<[DXCOption,

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 423189. python3kgae edited reviewers, added: steven_wu, JonChesterfield, sscalpone, rnk, bogner, MaskRay, dexonsmith, nikic; removed: jdoerfert, sstefan1, baziotis. python3kgae edited subscribers, added: beanz; removed: mgorny, arphaman, kuter,

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae created this revision. python3kgae added a project: clang. Herald added subscribers: ormris, dexonsmith, okura, jdoerfert, kuter, arphaman, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 423176. jhuber6 added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOptions.h

[clang] 2a404cd - [randstruct] Force errors for all platforms

Author: Bill Wendling Date: 2022-04-15T15:17:07-07:00 New Revision: 2a404cdfd8bc75de593ce0e15fff0a7a0a18ec1c URL: https://github.com/llvm/llvm-project/commit/2a404cdfd8bc75de593ce0e15fff0a7a0a18ec1c DIFF: https://github.com/llvm/llvm-project/commit/2a404cdfd8bc75de593ce0e15fff0a7a0a18ec1c.diff

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

cor3ntin abandoned this revision. cor3ntin added a comment. Herald added a project: All. Richard committed a better approach so this is no longer needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99893/new/ https://reviews.llvm.org/D99893

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jdoerfert added inline comments. Comment at: clang/test/Frontend/embed-object.ll:6 +; CHECK: @[[OBJECT:.+]] = private constant [120 x i8] c"\10\FF\10\AD{{.*}}\00", section ".llvm.offloading", align 8 +; CHECK: @llvm.compiler.used = appending global [2 x i8*] [i8* @x, i8*

[clang] a571f82 - Update test to handle opaque pointers flag flip.

Author: Richard Smith Date: 2022-04-15T14:51:30-07:00 New Revision: a571f82a50416b767fd3cce0fb5027bb5dfec58c URL: https://github.com/llvm/llvm-project/commit/a571f82a50416b767fd3cce0fb5027bb5dfec58c DIFF: https://github.com/llvm/llvm-project/commit/a571f82a50416b767fd3cce0fb5027bb5dfec58c.diff

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. section : increase in bytes for clang built with full debuginfo : %% of total binary size .debug_loclists 317782 0.0250% .debug_abbrev 88590 0.0070% .debug_info 100708340.7929% .debug_rnglists

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3454354 , @dblaikie wrote: > This seems like it would significantly introduce debug info size for at least > some kinds of code - have you done any size measurements of this change? With

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423169. royjacobson marked an inline comment as done. royjacobson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files:

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

glandium added a comment. The updates in `clang/test/Preprocessor` kind of suggest this was an expected change, though... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

glandium added a comment. In D109239#3454084 , @zahiraam wrote: > In D109239#3453770 , @glandium > wrote: > >> Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by >> default after this

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64c045e25b84: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins. (authored by rsmith). Changed prior to commit:

[clang] 64c045e - Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

Author: Richard Smith Date: 2022-04-15T14:09:45-07:00 New Revision: 64c045e25b8471bbb572bd29159c294a82a86a25 URL: https://github.com/llvm/llvm-project/commit/64c045e25b8471bbb572bd29159c294a82a86a25 DIFF: https://github.com/llvm/llvm-project/commit/64c045e25b8471bbb572bd29159c294a82a86a25.diff

[PATCH] D123874: [Clang][IA] support -generate-unused-section-symbols={yes|no}

MaskRay added a comment. > Add support to clang (-Wa,-generate-unused-section-symbols={yes|no}) and > llvm-mc. > This feature might be used by the Linux kernel. > https://lore.kernel.org/linux-toolchains/ylluqpk4cwzeh...@hirez.programming.kicks-ass.net/ > This has been supported by GNU

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6577-6578 +// FIXME: This should also be in -Wc++23-compat once we have it. +def warn_use_of_unaddressable_function : Warning< + "taking address of non-addressable standard library

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith updated this revision to Diff 423164. rsmith marked 3 inline comments as done. rsmith added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://reviews.llvm.org/D123345 Files:

[PATCH] D123300: [Clang] Enable opaque pointers by default

aeubanks added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123300/new/ https://reviews.llvm.org/D123300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

rsmith added a comment. In D123642#3450129 , @xbolva00 wrote: > Do you have any comments related to this issue by gcc devs that this is a > "known" bug? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87237#c1, from someone in the GCC MAINTAINERS file,

[PATCH] D123874: [Clang][IA] support -generate-unused-section-symbols={yes|no}

MaskRay added a comment. I wish we don't do this. https://sourceware.org/pipermail/binutils/2022-March/119940.html (`RFC: GAS: Add option to generate unused section symbols`): > This problem was fixed in the kernel (and backported by distros to their kernels if binutils was updated); it's

[PATCH] D123300: [Clang] Enable opaque pointers by default

fhahn added a comment. In D123300#3454215 , @aeubanks wrote: > $ cat /tmp/a.ll > target triple = "thumbv8-unknown-linux-gnueabihf" > > define void @zot() { > bb: > br label %bb1 > > bb1: ;

[PATCH] D123874: [Clang][IA] support -generate-unused-section-symbols={yes|no}

nickdesaulniers created this revision. nickdesaulniers added a reviewer: MaskRay. Herald added subscribers: StephenFan, dexonsmith, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3454632 , @rsmith wrote: > In D122983#3454508 , @aaron.ballman > wrote: > >> In D122983#3454494 , @jyknight >> wrote: >> >>>

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

rsmith added a comment. In D122983#3454508 , @aaron.ballman wrote: > In D122983#3454494 , @jyknight > wrote: > >> In D122983#3454406 , >> @aaron.ballman wrote: >> >>>

[PATCH] D123682: [clang-tblgen] Automatically document options values

serge-sans-paille added a comment. @aaron.ballman Any thoughs on the above suggestion? I'd be happy to adopt any of those :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123682/new/ https://reviews.llvm.org/D123682

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann added a comment. > This might've caused a regression? > (https://github.com/llvm/llvm-project/issues/54892) @dblaikie, it most definitely did. Note that I'm the author of the patch that introduced the regression, the reporter of the regression, and the assignee for fixing the

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

dblaikie added a comment. In D123345#3453037 , @rnk wrote: > Generally speaking, this sounds like a good idea to me. One time in 2019 I > used -ftime-trace+ClangBuildAnalyzer and it told me that std::unique_ptr was > the most expensive template >

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

dblaikie added a comment. This might've caused a regression? (https://github.com/llvm/llvm-project/issues/54892) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121959/new/ https://reviews.llvm.org/D121959

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaed923b1246a: [randstruct] Enforce using a designated init for a randomized struct (authored by void). Changed prior to commit:

[clang] aed923b - [randstruct] Enforce using a designated init for a randomized struct

Author: Bill Wendling Date: 2022-04-15T12:29:32-07:00 New Revision: aed923b1246ac38335b222b89594516fcf0d6385 URL: https://github.com/llvm/llvm-project/commit/aed923b1246ac38335b222b89594516fcf0d6385 DIFF: https://github.com/llvm/llvm-project/commit/aed923b1246ac38335b222b89594516fcf0d6385.diff

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG721651be246e: [HLSL][clang][Driver] Support target profile command line option. (authored by python3kgae, committed by beanz). Changed prior to

[clang] 721651b - [HLSL][clang][Driver] Support target profile command line option.

Author: Xiang Li Date: 2022-04-15T14:18:18-05:00 New Revision: 721651be246e26efd767c3ec55c8f06c7b5a9a3d URL: https://github.com/llvm/llvm-project/commit/721651be246e26efd767c3ec55c8f06c7b5a9a3d DIFF: https://github.com/llvm/llvm-project/commit/721651be246e26efd767c3ec55c8f06c7b5a9a3d.diff

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3454494 , @jyknight wrote: > In D122983#3454406 , @aaron.ballman > wrote: > >> In D122983#3452994 , @rsmith wrote: >> >>> I

[PATCH] D123826: Fix size of flexible array initializers, and re-enable assertions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4802edd1ac7a: Fix size of flexible array initializers, and re-enable assertions. (authored by efriedma). Changed prior to commit:

[clang] 4802edd - Fix size of flexible array initializers, and re-enable assertions.

Author: Eli Friedman Date: 2022-04-15T12:09:57-07:00 New Revision: 4802edd1ac7a5aea8c8488b5baec221d722cbdde URL: https://github.com/llvm/llvm-project/commit/4802edd1ac7a5aea8c8488b5baec221d722cbdde DIFF: https://github.com/llvm/llvm-project/commit/4802edd1ac7a5aea8c8488b5baec221d722cbdde.diff

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

jyknight added a comment. In D122983#3454406 , @aaron.ballman wrote: > In D122983#3452994 , @rsmith wrote: > >> I think we should just make this an error by default in C99 onwards; > > Out of curiosity -- do you

[PATCH] D123649: Allow flexible array initialization in C++.

efriedma added a comment. 6cf0b1b3 was a temporary fix to stop the crash. D123826 is the full fix to make the assertion actually work correctly. Repository: rG LLVM Github Monorepo

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

MaskRay accepted this revision. MaskRay added a comment. LGTM, too. It may be worthwhile adding a file-level comment at the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123763/new/ https://reviews.llvm.org/D123763

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

jyknight added a comment. In D123642#3450110 , @efriedma wrote: >> I disagree with this on principle -- IMO, it is basically a historical bug >> in GCC that it ignores the type alignment, and we should NOT try to match >> that -- it's dangerous. > >

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for adding some guard rails for this new feature! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123763/new/

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

void updated this revision to Diff 423139. void added a comment. Add tests for empty and single element structs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123763/new/ https://reviews.llvm.org/D123763 Files:

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123862/new/ https://reviews.llvm.org/D123862

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3452994 , @rsmith wrote: > I think we should just make this an error by default in C99 onwards; Out of curiosity -- do you think we should remove the `DefaultIgnore` in C89 mode so that we warn by default there

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

tianshilei1992 added a comment. In D123862#3454380 , @ABataev wrote: > What about ASTStmtWriter? It's using accessor function `isXLHSInRHSPart()` and so on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8fd3b5d - Fix an edge case in determining is a function has a prototype

Author: Aaron Ballman Date: 2022-04-15T14:04:07-04:00 New Revision: 8fd3b5de3f96300189a2841278e6c7b6654bffc5 URL: https://github.com/llvm/llvm-project/commit/8fd3b5de3f96300189a2841278e6c7b6654bffc5 DIFF: https://github.com/llvm/llvm-project/commit/8fd3b5de3f96300189a2841278e6c7b6654bffc5.diff

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

ABataev added a comment. What about ASTStmtWriter? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123862/new/ https://reviews.llvm.org/D123862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

dblaikie added a comment. This seems like it would significantly introduce debug info size for at least some kinds of code - have you done any size measurements of this change? What does the resulting DWARF look like? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

aaron.ballman added inline comments. Comment at: clang/test/Sema/init-randomized-struct.c:30 +} __attribute__((randomize_layout)); + +struct other_test t5 = { .a = foo, .b[0] = foo }; // Okay MaskRay wrote: > Perhaps test an empty struct with randomize_layout

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2835-2847 bool IsXLHSInRHSPart = false; /// Used for 'atomic update' or 'atomic capture' constructs. They may /// have atomic

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 423132. tianshilei1992 added a comment. Herald added a project: All. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files:

[PATCH] D123649: Allow flexible array initialization in C++.

nickdesaulniers added a comment. For posterity, posting the link to the failure this caused in Linaro's TCWG's CI of kernel builds w/ clang: https://lore.kernel.org/llvm/906914372.14298.1650022522881@jenkins.jenkins/. I'm guessing D123826 fixes this?

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

tianshilei1992 created this revision. tianshilei1992 added reviewers: ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

efriedma added a comment. > Have we verified that this is the rule that GCC uses? Is it true even if e.g. > the pointer expression is the address of a variable with a known alignment, > or if the pointer has an explicitly-aligned type (e.g. with an aligned > typedef)? As far as I can tell, if

[PATCH] D123300: [Clang] Enable opaque pointers by default

aeubanks added a comment. $ cat /tmp/a.ll target triple = "thumbv8-unknown-linux-gnueabihf" define void @zot() { bb: br label %bb1 bb1: ; preds = %bb1, %bb %tmp = phi ptr [ null, %bb ], [ %tmp2, %bb1 ] store ptr %tmp, ptr

[PATCH] D123856: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion()

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. Shadowing of `FE` almost tripped me up there  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123856/new/ https://reviews.llvm.org/D123856

[PATCH] D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry

bnbarham accepted this revision. bnbarham added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/HeaderSearch.cpp:584 // If it is known and in some other directory, fail. - if (CacheEntry.Directory && CacheEntry.Directory !=

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

aaron.ballman accepted this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. In D121984#3453976 , @kito-cheng wrote: >> Thank you for the explanation. I still don't think this is

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

bnbarham accepted this revision. bnbarham added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/HeaderSearch.cpp:1583 +::getTopFrameworkDir(FileMgr, FrameworkName, SubmodulePath); +assert(TopFrameworkDir && "Could not find

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm happy with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson marked 2 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9829 + bool CanCompareConstraints = false; + if (Cand1.Function && Cand2.Function && Cand1.Function->hasPrototype() && +

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423120. royjacobson added a comment. Split the 'can compare constraints' code into a static function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files:

[PATCH] D123826: Fix size of flexible array initializers, and re-enable assertions.

erichkeane added inline comments. Comment at: clang/lib/AST/Decl.cpp:2735 + const Expr *FlexibleInit = List->getInit(List->getNumInits() - 1); + auto InitTy = Ctx.getAsConstantArrayType(FlexibleInit->getType()); + if (!InitTy) efriedma wrote: > erichkeane

[PATCH] D123826: Fix size of flexible array initializers, and re-enable assertions.

efriedma added inline comments. Comment at: clang/lib/AST/Decl.cpp:2735 + const Expr *FlexibleInit = List->getInit(List->getNumInits() - 1); + auto InitTy = Ctx.getAsConstantArrayType(FlexibleInit->getType()); + if (!InitTy) erichkeane wrote: > Same here You

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

aaron.ballman added a comment. In D123627#3452491 , @efriedma wrote: >> The reason you get the weird behavior with the note pointing to the same >> line as the declaration is because rintf() is a predefined builtin: >> https://godbolt.org/z/j3W759M7a

[clang] c7d4a05 - Properly identify builtins in a diagnostic note

Author: Aaron Ballman Date: 2022-04-15T11:46:13-04:00 New Revision: c7d4a05228090cb6b1b7f6e5d300f197897ac756 URL: https://github.com/llvm/llvm-project/commit/c7d4a05228090cb6b1b7f6e5d300f197897ac756 DIFF: https://github.com/llvm/llvm-project/commit/c7d4a05228090cb6b1b7f6e5d300f197897ac756.diff

[clang] 52e6a27 - Clean up `OMPAtomicDirective::Create`

Author: Shilei Tian Date: 2022-04-15T11:41:26-04:00 New Revision: 52e6a27690ca8e5f07cc646716c3736475b7746b URL: https://github.com/llvm/llvm-project/commit/52e6a27690ca8e5f07cc646716c3736475b7746b DIFF: https://github.com/llvm/llvm-project/commit/52e6a27690ca8e5f07cc646716c3736475b7746b.diff

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:2967 + "parameters!"); + for (FunctionProtoType::param_type_iterator + O = OldType->param_type_begin(), royjacobson wrote: > erichkeane wrote: > > Thanks for the

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:2967 + "parameters!"); + for (FunctionProtoType::param_type_iterator + O = OldType->param_type_begin(), erichkeane wrote: > Thanks for the clarification on

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423116. royjacobson marked an inline comment as not done. royjacobson added a comment. Update for look inside FunctionParamTypesAreEqual to be index based and simpler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Ensure that the expressions associated with terminators are

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04000c2f928a: [clang] Implement Change scope of lambda trailing-return-type (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES

[clang] 04000c2 - [clang] Implement Change scope of lambda trailing-return-type

Author: Corentin Jabot Date: 2022-04-15T16:50:52+02:00 New Revision: 04000c2f928a7adc32138a664d167f01b642bef3 URL: https://github.com/llvm/llvm-project/commit/04000c2f928a7adc32138a664d167f01b642bef3 DIFF:

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3453770 , @glandium wrote: > Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by > default after this change? @glandium would you mind giving a reproducer. We might have missed a flow path where

[clang] 26b0ecb - [clang][deps] NFC: Update documentation

Author: Jan Svoboda Date: 2022-04-15T16:24:41+02:00 New Revision: 26b0ecb8985b7e76a5ca0965d3d464611eda14f0 URL: https://github.com/llvm/llvm-project/commit/26b0ecb8985b7e76a5ca0965d3d464611eda14f0 DIFF: https://github.com/llvm/llvm-project/commit/26b0ecb8985b7e76a5ca0965d3d464611eda14f0.diff

[clang] 7ed01ba - [clang][deps] NFC: Inline function with single caller

Author: Jan Svoboda Date: 2022-04-15T16:24:40+02:00 New Revision: 7ed01ba88d67a0eb79663547f9ec21d106f7b281 URL: https://github.com/llvm/llvm-project/commit/7ed01ba88d67a0eb79663547f9ec21d106f7b281 DIFF: https://github.com/llvm/llvm-project/commit/7ed01ba88d67a0eb79663547f9ec21d106f7b281.diff

[PATCH] D123856: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion()

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes uses of the deprecated

  1   2   >