[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 423818. LegalizeAdulthood added a comment. Delete debugging aids CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124066/new/ https://reviews.llvm.org/D124066 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp

[PATCH] D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/unittests/Format/FormatTest.cpp:13397 + + verifyFormat("//\n" + "#define a \\\n" aeubanks wrote: > not sure if

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 423815. LegalizeAdulthood added a comment. Add comments describing test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124066/new/ https://reviews.llvm.org/D124066 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, alexfh. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. LegalizeAdulthood requested review of this revision.

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov updated this revision to Diff 423813. ASDenysPetrov added a comment. Loaded with comment updateds according to the remarks. @martong thank you for your time for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files:

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

MaskRay created this revision. MaskRay added reviewers: aeubanks, nikic. Herald added a reviewer: deadalnix. Herald added subscribers: ormris, StephenFan, kbarton, hiraditya, nemanjai. Herald added a reviewer: bollu. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 added a comment. I added three functions __mulqi3: int8 multiplication __mulhi3: int16 multiplication _exit : golobal terminator All of them are contained in libgcc and are necessary. Some key points, 1. The functions are written in the minimal avrtiny instruction set, so

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

This revision was automatically updated to reflect the committed changes. LegalizeAdulthood marked 2 inline comments as done. Closed by commit rG08881c2de66b: [clang-tidy] Improve macro handling in modernize-macro-to-enum (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 08881c2 - [clang-tidy] Improve macro handling in modernize-macro-to-enum

Author: Richard Date: 2022-04-19T21:28:17-06:00 New Revision: 08881c2de66b267446f01b908ea2e7297bdf3083 URL: https://github.com/llvm/llvm-project/commit/08881c2de66b267446f01b908ea2e7297bdf3083 DIFF: https://github.com/llvm/llvm-project/commit/08881c2de66b267446f01b908ea2e7297bdf3083.diff LOG:

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan accepted this revision. owenpan added a comment. LGTM as I defer to @MyDeveloperDay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 ___ cfe-commits

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 updated this revision to Diff 423805. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123200/new/ https://reviews.llvm.org/D123200 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/base-config-ix.cmake compiler-rt/cmake/builtin-config-ix.cmake

[PATCH] D124062: [RISCV][Clang][NFC] Update vid intrinsic tests.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, arcbbb, monkchiang, eopXD. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei,

[PATCH] D123372: [PowerPC] add XLC compat builtin __abs

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123372/new/ https://reviews.llvm.org/D123372

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Darwin.h:495 + Optional getTargetVariantTriple() const override { +return TargetVariantTriple; + }

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, power-llvm-team. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. Herald added a project: All. amyk requested review of this revision. Herald added a subscriber: cfe-commits. This patch

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/Module.h:550-553 if (isModulePartition()) { auto pos = Name.find(':'); return StringRef(Name.data(), pos); } iains wrote: > if we find this is repeated too many times,

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu updated this revision to Diff 423797. ChuanqiXu added a comment. Address comments: - Add tests for GMF - Avoid to compare string if M is private module fragment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123837/new/ https://reviews.llvm.org/D123837 Files:

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 423796. jhuber6 added a comment. Addings tests for wrapper codegen and fatbinary usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 Files:

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

jhuber6 updated this revision to Diff 423793. jhuber6 added a comment. Herald added a subscriber: mattd. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123810/new/ https://reviews.llvm.org/D123810 Files:

[PATCH] D124053: [CMake][Fuchsia] Include find-all-symbols in the distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf21445ea870: [CMake][Fuchsia] Include find-all-symbols in the distribution (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124053/new/

[clang] af21445 - [CMake][Fuchsia] Include find-all-symbols in the distribution

Author: Petr Hosek Date: 2022-04-19T19:27:46-07:00 New Revision: af21445ea87021a1bb0a870a2d63cee27f57b43e URL: https://github.com/llvm/llvm-project/commit/af21445ea87021a1bb0a870a2d63cee27f57b43e DIFF: https://github.com/llvm/llvm-project/commit/af21445ea87021a1bb0a870a2d63cee27f57b43e.diff

[PATCH] D86351: WIP: llvm-buildozer

arsenm added inline comments. Comment at: llvm/lib/Analysis/MemorySSA.cpp:89 #ifdef EXPENSIVE_CHECKS -bool llvm::VerifyMemorySSA = true; +LLVM_THREAD_LOCAL bool llvm::VerifyMemorySSA = true; #else Do command line flags like this really need to be thread local?

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

efriedma added a comment. The fix doesn't look right. A CompoundLiteralExpr is itself an lvalue; we should catch any issues when we visit it, not a VarDecl that contains a pointer to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/

[PATCH] D124058: [msan] Update Use-after-destruction documentation

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124058 Files: clang/docs/MemorySanitizer.rst

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka created this revision. vitalybuka added reviewers: eugenis, kda. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. By default -fsanitize=address

[PATCH] D123372: [PowerPC] add XLC compat builtin __abs

shchenz added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123372/new/ https://reviews.llvm.org/D123372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

Jake-Egan added a comment. Hi, unfortunately there's a build failure on AIX: https://lab.llvm.org/buildbot/#/builders/214/builds/779/steps/9/logs/stdio. Could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/

[clang] a57d16b - [CodeGen] Fix -Wswitch after D116462

Author: Fangrui Song Date: 2022-04-19T17:33:15-07:00 New Revision: a57d16bf80db1bdb785df6b7bca96cb4daff5ea7 URL: https://github.com/llvm/llvm-project/commit/a57d16bf80db1bdb785df6b7bca96cb4daff5ea7 DIFF: https://github.com/llvm/llvm-project/commit/a57d16bf80db1bdb785df6b7bca96cb4daff5ea7.diff

[PATCH] D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic.

delcypher created this revision. delcypher added reviewers: rapidsna, fcloutier, aaron.ballman. Herald added a project: All. delcypher requested review of this revision. Herald added a project: clang. The previous code unneccessarily duplicated the creation of a diagnostic where the only

[clang] 8b0e7f2 - [CodeGen] Fix -Wswitch after D116462

Author: Fangrui Song Date: 2022-04-19T17:28:54-07:00 New Revision: 8b0e7f2293b39a11d83ff9889f5250947de80c53 URL: https://github.com/llvm/llvm-project/commit/8b0e7f2293b39a11d83ff9889f5250947de80c53 DIFF: https://github.com/llvm/llvm-project/commit/8b0e7f2293b39a11d83ff9889f5250947de80c53.diff

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira updated this revision to Diff 423775. This revision is now accepted and ready to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118052/new/ https://reviews.llvm.org/D118052 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CodeGen/X86/x86-cf-protection.c

[clang] 0d0a99c - [msan] Advance before destroying entry

Author: Vitaly Buka Date: 2022-04-19T16:42:04-07:00 New Revision: 0d0a99cb96183027af8212d0b8545356b65be0d3 URL: https://github.com/llvm/llvm-project/commit/0d0a99cb96183027af8212d0b8545356b65be0d3 DIFF: https://github.com/llvm/llvm-project/commit/0d0a99cb96183027af8212d0b8545356b65be0d3.diff

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/test/Frontend/stack-usage-safestack.c:3 + +// RUN: %clang_cc1 %s -fwarn-stack-size=48 -S -o - -triple=i386-apple-darwin 2>&1 | FileCheck --check-prefix=REGULAR %s +// RUN: %clang_cc1 %s

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk added inline comments. Comment at: clang/docs/ReleaseNotes.rst:240 + GCC. This breaks binary compatibility with code compiled with earlier versions + of clang; use the `-fclang-abi-compat=14` option to get the old mangling. This is incorrect rst

[PATCH] D124053: [CMake][Fuchsia] Include find-all-symbols in the distribution

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is needed to use clang-include-fixer.

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

jyknight accepted this revision. jyknight added a comment. Looks good to me, whichever way you go regarding rsmith's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 ___ cfe-commits mailing

[clang] 20c873c - [PS5] Avoid a driver crash

Author: Paul Robinson Date: 2022-04-19T15:55:32-07:00 New Revision: 20c873c12fa5563bbfb07c880db51fa68db571cc URL: https://github.com/llvm/llvm-project/commit/20c873c12fa5563bbfb07c880db51fa68db571cc DIFF: https://github.com/llvm/llvm-project/commit/20c873c12fa5563bbfb07c880db51fa68db571cc.diff

[clang] 8c64928 - [OpenMP] Add necessary registered targets for linker wrapper test

Author: Joseph Huber Date: 2022-04-19T18:48:58-04:00 New Revision: 8c64928887997a176c8f78b26c0edf00d6b2f59d URL: https://github.com/llvm/llvm-project/commit/8c64928887997a176c8f78b26c0edf00d6b2f59d DIFF: https://github.com/llvm/llvm-project/commit/8c64928887997a176c8f78b26c0edf00d6b2f59d.diff

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng added a comment. Thanks for reviewing the patch, @rnk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 ___ cfe-commits mailing list

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng updated this revision to Diff 423754. pzheng added a comment. Address comments from @mstorsjo. Thanks for catching the missing test, @mstorsjo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032

[clang] dbb10f7 - [OpenMP] Fix deleted move constructor failing on some compiles

Author: Joseph Huber Date: 2022-04-19T18:40:15-04:00 New Revision: dbb10f7097dd357557b7b1976ff0b47c5627141b URL: https://github.com/llvm/llvm-project/commit/dbb10f7097dd357557b7b1976ff0b47c5627141b DIFF: https://github.com/llvm/llvm-project/commit/dbb10f7097dd357557b7b1976ff0b47c5627141b.diff

[clang] 260c5df - [OpenMP] Add better testing for the linker wrapper

Author: Joseph Huber Date: 2022-04-19T18:37:09-04:00 New Revision: 260c5df2d52b67751f9ed33fde1b453c53f44f88 URL: https://github.com/llvm/llvm-project/commit/260c5df2d52b67751f9ed33fde1b453c53f44f88 DIFF: https://github.com/llvm/llvm-project/commit/260c5df2d52b67751f9ed33fde1b453c53f44f88.diff

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG260c5df2d52b: [OpenMP] Add better testing for the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3457740 , @nickdesaulniers wrote: > Please add a test where calls to `@llvm.kcfi.check` produce `KCFI_CHECK` > during instruction selection. (You can use `-stop-before=finalize-isel` to > dump the IR prior to

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 423748. samitolvanen marked 12 inline comments as done. samitolvanen added a comment. Addressed Nick's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/ https://reviews.llvm.org/D119296

[clang] e3cf153 - [Driver][test] Remove unneeded clang from -cc1 CHECK lines

Author: Fangrui Song Date: 2022-04-19T14:58:48-07:00 New Revision: e3cf1535220128ed9e7c3ba77cc074318461302d URL: https://github.com/llvm/llvm-project/commit/e3cf1535220128ed9e7c3ba77cc074318461302d DIFF: https://github.com/llvm/llvm-project/commit/e3cf1535220128ed9e7c3ba77cc074318461302d.diff

[clang] 63814be - [modules] Merge variable template specializations.

Author: Richard Smith Date: 2022-04-19T14:48:42-07:00 New Revision: 63814be4fa23ef9b36cf2d14388c7f6ba591d3b6 URL: https://github.com/llvm/llvm-project/commit/63814be4fa23ef9b36cf2d14388c7f6ba591d3b6 DIFF: https://github.com/llvm/llvm-project/commit/63814be4fa23ef9b36cf2d14388c7f6ba591d3b6.diff

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 updated this revision to Diff 423743. jhuber6 added a comment. Fix test on Windows failing because of ".exe" at the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039 Files:

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice! I like the strategy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. Ah, thanks. I've had to try to re-land this so many times, I wanted to be sure the pre-submit was looking OK after rebasing. or at least be sure it didn't look like it was failing from any of my changes. w.r.t. `clamp`, keeping it compatible was my intent.

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tejohnson added a comment. lgtm if you are waiting for a re-review. As noted in my previous comment, you have added a little bit of unnecessary checking at the lower end with your new clamp function, since it is an unsigned value and can never go below 0. But it isn't a big deal if you prefer

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

kees added a comment. I tested this (with D123958 ), and it appears to be working as intended. These two fptrs are the first and second listed, and are happily randomized: [0.00] LSM: offsetof(struct security_hook_heads, ptrace_access_check): 816

[PATCH] D123961: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb2131bdbad3: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable… (authored by ymandel). Repository: rG LLVM Github

[clang] eb2131b - [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

Author: Yitzhak Mandelbaum Date: 2022-04-19T20:52:29Z New Revision: eb2131bdbad3f74be2fcf236b4d6921612af47a9 URL: https://github.com/llvm/llvm-project/commit/eb2131bdbad3f74be2fcf236b4d6921612af47a9 DIFF: https://github.com/llvm/llvm-project/commit/eb2131bdbad3f74be2fcf236b4d6921612af47a9.diff

[PATCH] D124040: Basic Support for otherwise clause

abidmalikwaterloo created this revision. Herald added a project: All. abidmalikwaterloo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. The patch provides otherwise support

[PATCH] D123961: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

ymandel updated this revision to Diff 423724. ymandel added a comment. extended comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123961/new/ https://reviews.llvm.org/D123961 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: yaxunl, JonChesterfield, jdoerfert, tianshilei1992. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D123957: Update the developer policy to mention release notes

lattner accepted this revision. lattner added a comment. Nice, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a non-const compound statement is used to

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

mstorsjo added a comment. Should there be tests for the LLVM side of this too, not only on the clang side? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 ___

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

bulbazord closed this revision. bulbazord added a comment. Gah, forgot to add the phabricator link to the commit message. I added the commit object to this diff, hopefully people can track it down the review if needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122691/new/

[clang] c57f034 - [clang][Sema] Add flag to LookupName to force C/ObjC codepath

Author: Alex Langford Date: 2022-04-19T12:57:14-07:00 New Revision: c57f03415f9668f942802ff7108410d57c2b10da URL: https://github.com/llvm/llvm-project/commit/c57f03415f9668f942802ff7108410d57c2b10da DIFF: https://github.com/llvm/llvm-project/commit/c57f03415f9668f942802ff7108410d57c2b10da.diff

[PATCH] D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

aeubanks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13397 + + verifyFormat("//\n" + "#define a \\\n" not sure if you'd like a better test, this was the reduced test case I got that still caused a crash Repository:

[PATCH] D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes a crash introduced in D123737 where LastNonComment would be null. Repository:

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 423713. erichkeane added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. Fixed the issue that Corentin's test came up with, added a number of others. The problem is that we didn't properly 'collect' the parameters in cases

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM; two non-blocking comments and a question. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:420-422 +def ext_implicit_function_decl_c99 : ExtWarn< +

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added a comment. This is ready for review, please take a look  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commits mailing list

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 ___

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

rsmith accepted this revision. rsmith added a comment. LGTM. Some comments for potential improvements, but I'd be OK with this landing as-is if you don't find any of them sufficiently motivating :) Comment at: clang/lib/Parse/ParseDecl.cpp:6664- +// OpenCL disallows

[PATCH] D123957: Update the developer policy to mention release notes

tschuett added a comment. LGTM and thanks. Feel free to ignore my comment. Maybe sort entries by importance. I have problems reading longish texts and documents. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe37726beb22a: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions… (authored by ASDenysPetrov). Changed prior to

[clang] e37726b - [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

Author: Denys Petrov Date: 2022-04-19T22:34:03+03:00 New Revision: e37726beb22a8e3865e1f6fcdbb5cd4262786903 URL: https://github.com/llvm/llvm-project/commit/e37726beb22a8e3865e1f6fcdbb5cd4262786903 DIFF: https://github.com/llvm/llvm-project/commit/e37726beb22a8e3865e1f6fcdbb5cd4262786903.diff

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. FWIW, I am about 95% sure I have a hold on this, plus a bunch of other cases I came up with. I likely won't get a patch up for review today (in the next hour!) unless something miraculous happens, but hopefully I'll have something tomorrow for folks to take another

[PATCH] D123957: Update the developer policy to mention release notes

xbolva00 added a comment. Can you please add link to RFC to commit message? Otherwise looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ cfe-commits mailing list

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. This is to clarify that the macro __FLT_EVAL_METHOD__ it is not pre-defined like other preprocessor macros. It will

[PATCH] D123957: Update the developer policy to mention release notes

nikic accepted this revision. nikic added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/DeveloperPolicy.rst:195 +* Adding, removing, or regrouping a diagnostic. +* Fixing a bug (please link to the issue fixed in the bug database). +*

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

Mordante added a comment. In D123182#3458712 , @royjacobson wrote: > So, it seems like this broke one of `basic_arg_format`'s private > constructors.. Sorry for that. > > This is now ambiguous when calling `basic_format_arg(char)` because the >

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng created this revision. pzheng added reviewers: rnk, mstorsjo, efriedma. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pzheng requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall added 1 blocking reviewer(s): ldionne. sammccall added a comment. The changes to runtimes/ are mostly mechanical, but Herald says I'm supposed to get a review :-) @ldionne, @phosek, looks like this touches the same bits from D121276 , WDYT?

[PATCH] D123976: [CUDA][HIP] Fix delete operator for -fopenmp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG800f26386cd9: [CUDA][HIP] Fix delete operator for -fopenmp (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github

[clang] 800f263 - [CUDA][HIP] Fix delete operator for -fopenmp

Author: Yaxun (Sam) Liu Date: 2022-04-19T14:28:03-04:00 New Revision: 800f26386cd9054ceed68e481612908f635b9718 URL: https://github.com/llvm/llvm-project/commit/800f26386cd9054ceed68e481612908f635b9718 DIFF:

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

zahiraam added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer.reserve(4080); +

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel added a comment. Thanks for the review! Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:110 +// FIXME: The flow condition must be an r-value, so `SkipPast::None` should +// suffice. xazax.hun wrote: > I am still

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel updated this revision to Diff 423693. ymandel marked 2 inline comments as done. ymandel added a comment. added fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123858/new/ https://reviews.llvm.org/D123858 Files:

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. In D119136#3457027 , @rtrieu wrote: > This seems to be acting weird in template instantations. Here's an example > where the lambda only errors inside a template. Thanks for notifying me of that. I will land a fix shortly

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ASTImporter.cpp:9189 +TemplateName UnderlyingTN = QTN->getUnderlyingTemplate(); +if (UsingShadowDecl *USD =

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel updated this revision to Diff 423690. ymandel added a comment. add comments to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123858/new/ https://reviews.llvm.org/D123858 Files:

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

alanphipps added a comment. We've also been seeing failures in our downstream Arm compiler when running the Perennial C++14 compliance tests related to this change. Specifically, the tests expect a diagnostic to be issued when the lambda capture variable is outside of the lambda's {} scope.

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

hokein added inline comments. Comment at: clang/include/clang/AST/PropertiesBase.td:666 } - def : Property<"declaration", TemplateDeclRef> { + def : Property<"templateDecl", TemplateDeclRef> { let Read = [{ qtn->getTemplateDecl() }]; sammccall wrote: >

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

hokein updated this revision to Diff 423687. hokein added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123775/new/ https://reviews.llvm.org/D123775 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait a bit before landing so other reviewers have time to weigh in (should be fine to land tomorrow sometime if you don't hear back). Comment

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

dblaikie added a comment. Could you include some static_asserts(+alignof) in the test case to demonstrate these are the alignments that the language is computing too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124006/new/

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

tra added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11760-11763 + auto Cutoff = [](unsigned V) { return V > 1 ? V : 1; }; + if (CUDANameMangleCtx.MangleDeviceNameInHostCompilation) +return Cutoff(Res >> 16); + return Cutoff(Res & 0x);

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1876 +get_property(gather_names GLOBAL PROPERTY LLVM_LIT_UMBRELLAS) +set_property(GLOBAL APPEND PROPERTY LLVM_LIT_UMBRELLAS ${name}) +foreach(name ${gather_names}) hokein

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

hokein updated this revision to Diff 423686. hokein marked 6 inline comments as done. hokein added a comment. expose underlying template name, removed the getUsingShadowDecl; address comments; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 423685. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/Cuda.h

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:110 +// FIXME: The flow condition must be an r-value, so `SkipPast::None` should

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:123-136 + } else if (auto *CondVal = cast_or_null( + Env.getValue(Cond, SkipPast::None))) { +

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer.reserve(4080); +

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman updated this revision to Diff 423683. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. - Made it more clear that adding a release note is discretionary rather than mandatory - Clarified that bug fix release notes

  1   2   3   >