[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

cha5on added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:374-375 return false; + if (Changes[i].Tok->is(tok::l_brace) && + Changes[i].Tok->is(BK_BracedInit)) +return true; curdeius wrote: >

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

cha5on updated this revision to Diff 429138. cha5on marked 4 inline comments as done. cha5on added a comment. Update for review. - Further simplify testcases. - Update issue URL in comment to use llvm.org alias. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

rsundahl marked 8 inline comments as done. rsundahl added a comment. The update completes the suggested changes. The generated code is slightly different around initialization of the array cookie due to choosing one implementation over another when I "folded" ARMCXXABI::InitializeArrayCookie()

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

rsundahl updated this revision to Diff 429135. rsundahl added a comment. - Refactor InitializeArrayCookie and readArrayCookieImpl. This update to the differential implements the final suggestions for refactoring ItaniumCXXABI to remove duplicated code in the function InitializeArrayCookie() and

[PATCH] D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11244 +def err_coroutine_unusable_new : Error< + "'operator new' provided by %0 is not usable with the function signature of %1" +>; The error message here following

[PATCH] D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type

ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, cor3ntin, clang-language-wg. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. According to

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng created this revision. pzheng added reviewers: rnk, mstorsjo, thakis, hans. Herald added a project: All. pzheng requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Map /Zc:wchar_t- to the cc1 flag -fno-wchar which is already

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 429121. hctim added a comment. Herald added a subscriber: ormris. update patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 Files:

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3509667 , @rnk wrote: > That's fine, a Windows machine shouldn't be necessary. This patch has to > change the AsmPrinter for DWARF, so it makes sense that it should do the same > for CodeView. I think it should be

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

TiehuZhang updated this revision to Diff 429110. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122126/new/ https://reviews.llvm.org/D122126 Files: llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h

[PATCH] D125510: [clang-format][NFC] Format unit tests with insert/remove braces

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is

[clang] 8a0fb96 - [LinkerWrapper] Group static libraries in their own buffer

Author: Joseph Huber Date: 2022-05-12T20:45:49-04:00 New Revision: 8a0fb965f6992078bb3d8bd68d3995e1150fe442 URL: https://github.com/llvm/llvm-project/commit/8a0fb965f6992078bb3d8bd68d3995e1150fe442 DIFF: https://github.com/llvm/llvm-project/commit/8a0fb965f6992078bb3d8bd68d3995e1150fe442.diff

[clang] 1bfa88d - [LinkerWrapper] Remove stripping features from the linker wrapper

Author: Joseph Huber Date: 2022-05-12T20:45:49-04:00 New Revision: 1bfa88d0c5ad9e5ef06b770e8ca4d6d3a3aaca2d URL: https://github.com/llvm/llvm-project/commit/1bfa88d0c5ad9e5ef06b770e8ca4d6d3a3aaca2d DIFF: https://github.com/llvm/llvm-project/commit/1bfa88d0c5ad9e5ef06b770e8ca4d6d3a3aaca2d.diff

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

pavel.v.chupin added a comment. We faced some similar problem in downstream project (https://github.com/intel/llvm/issues/6142) due to this change. +1 for revert if fix takes longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124613/new/

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2156 Prefixes.push_back("/opt/rh/devtoolset-10/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-9/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-8/root/usr"); The

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

phosek accepted this revision. phosek added a comment. LGTM Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) +set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

akyrtzi added a comment. In D125488#3510329 , @dexonsmith wrote: > Seems unfortunate to have a temporary regression in the commit stack, since > then you can't push incrementally (or bisect). Can the prior patch leave > behind the feature in the

[PATCH] D125451: [clang-format] Handle comments below r_brace in RemoveBracesLLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cd9633c1da5: [clang-format] Handle comments below r_brace in RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] 6cd9633 - [clang-format] Handle comments below r_brace in RemoveBracesLLVM

Author: owenca Date: 2022-05-12T16:51:18-07:00 New Revision: 6cd9633c1da5d2867306217af59bcc4b589bab02 URL: https://github.com/llvm/llvm-project/commit/6cd9633c1da5d2867306217af59bcc4b589bab02 DIFF: https://github.com/llvm/llvm-project/commit/6cd9633c1da5d2867306217af59bcc4b589bab02.diff LOG:

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2154 Prefixes.push_back("/opt/rh/gcc-toolset-10/root/usr"); +Prefixes.push_back("/opt/rh/devtoolset-11/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-10/root/usr");

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel marked 8 inline comments as done. ymandel added a comment. I'm having trouble with arcanist -- `arc diff` is crashing, but wanted to respond in the meantime to your questions. I hope I'll be able to actually upload the new diff soon... Comment at:

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125499/new/ https://reviews.llvm.org/D125499

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

dexonsmith added a comment. In D125488#3510320 , @akyrtzi wrote: > In D125488#3510297 , @dexonsmith > wrote: > >> [To be clear, my question was because I don't see this patch deleting the >> code path that

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

akyrtzi added a comment. In D125488#3510297 , @dexonsmith wrote: > [To be clear, my question was because I don't see this patch deleting the > code path that minimizes / saves-minimized sources. Can/should we delete the > "minimize sources" code

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

dexonsmith added a comment. In D125488#3510265 , @akyrtzi wrote: > In D125488#3510214 , @dexonsmith > wrote: > >> Is there code in DepFS that can/should be deleted as part of this patch, or >> in a follow-up,

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk created this revision. amyk added reviewers: PowerPC, power-llvm-team, nemanjai, lei. amyk added a project: LLVM. Herald added subscribers: shchenz, hiraditya. Herald added a project: All. amyk requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

dexonsmith added inline comments. Comment at: clang/test/Sema/warn-strict-prototypes.m:20 + // know it's a block when diagnosing. + void (^block2)(void) = ^void() { // expected-warning {{a function declaration without a prototype is deprecated in all versions of C}} };

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

akyrtzi added a comment. In D125488#3510214 , @dexonsmith wrote: > Is there code in DepFS that can/should be deleted as part of this patch, or > in a follow-up, or is it still around as an option? After these changes, with DepFS we are using its

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

efriedma added inline comments. Comment at: clang/test/Sema/warn-strict-prototypes.m:20 + // know it's a block when diagnosing. + void (^block2)(void) = ^void() { // expected-warning {{a function declaration without a prototype is deprecated in all versions of C}} };

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

dexonsmith added a comment. Awesome to see this! Looking forward to the next step (using this in normal preprocessing!). > after this change, we don't minimize sources and pass them in place of the > real sources Is there code in DepFS that can/should be deleted as part of this patch, or in

[PATCH] D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens

akyrtzi marked an inline comment as done. akyrtzi added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:120 +clEnumValN(ScanningMode::DependencyDirectivesScan, + "preprocess-directives-scan", + "The set of

[PATCH] D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens

akyrtzi updated this revision to Diff 429087. akyrtzi added a comment. Rename the `clang-scan-deps` flag from "-preprocess-directives-scan" to "-preprocess-dependency-directives" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125484/new/

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

dexonsmith added a comment. In D124974#3504986 , @porglezomp wrote: > Ah, so it'd be a test that passes pretty trivially on any bot that doesn't > have a custom version of `CLANG_DEFAULT_STD_C` and `CLANG_DEFAULT_STD_CXX` > like the default config,

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

dexonsmith added a comment. For additional context to my questions above, even though open source clang hasn't been using `-Wstrict-prototypes`, Xcode has had it on-by-default in new projects since sometime in 2017, with project modernizations to turn it on for old projects. Warning on block

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

MatzeB added inline comments. Herald added a project: All. Comment at: clang/docs/ReleaseNotes.rst:239-243 +- GCC doesn't pack non-POD members in packed structs unless the packed + attribute is also specified on the member. Clang historically did perform + such packing. Clang

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

dexonsmith added inline comments. Comment at: clang/test/Sema/warn-strict-prototypes.m:20 + // know it's a block when diagnosing. + void (^block2)(void) = ^void() { // expected-warning {{a function declaration without a prototype is deprecated in all versions of C}} };

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

dexonsmith added subscribers: steven_wu, rjmccall, rnk, dexonsmith. dexonsmith added inline comments. Comment at: clang/test/Sema/warn-strict-prototypes.m:20 + // know it's a block when diagnosing. + void (^block2)(void) = ^void() { // expected-warning {{a function

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 429068. MosheBerman added a comment. Update tests to use %clang_analyze_cc1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123352/new/ https://reviews.llvm.org/D123352 Files:

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne updated this revision to Diff 429069. ldionne marked 2 inline comments as done. ldionne added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 Files:

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman added inline comments. Comment at: clang/test/Analysis/nullability-fixits.mm:5-10 +// RUN: %clang_cc1 -analyze \ + +// RUN: -Wno-nonnull \ +// RUN: -analyzer-checker=core,nullability.NullableReturnedFromNonnull,nullability.NullReturnedFromNonnull \ +// RUN:

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 429065. MosheBerman added a comment. Incorporated feedback: - Removed confusing comment about NS-prefixed classes - Use StringRef instead of str - Fixed case where `isa` was more appropriate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman marked 3 inline comments as done. MosheBerman added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:592-602 + // If we're inside of an NS_ASSUME, then the sourceRange will end before the + // asterisk. + const auto

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

kamaub created this revision. kamaub added reviewers: phosek, tstellar, nemanjai, lei. Herald added a project: All. kamaub requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch allows systems to build the llvm-project with the

[PATCH] D125491: [RISCV] Add extra space into error message about unsupported extension version.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG232c00ba5bd1: [RISCV] Add extra space into error message about unsupported extension version. (authored by craig.topper). Changed prior to commit:

[clang] 232c00b - [RISCV] Add extra space into error message about unsupported extension version.

Author: Craig Topper Date: 2022-05-12T12:56:29-07:00 New Revision: 232c00ba5bd1dc6ba69598170f57cba7b20d2635 URL: https://github.com/llvm/llvm-project/commit/232c00ba5bd1dc6ba69598170f57cba7b20d2635 DIFF: https://github.com/llvm/llvm-project/commit/232c00ba5bd1dc6ba69598170f57cba7b20d2635.diff

[PATCH] D125473: Comment parsing: Treat properties as zero-argument inline commands

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125473/new/ https://reviews.llvm.org/D125473

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mstorsjo added inline comments. Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) +set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use.

[PATCH] D125491: [RISCV] Add extra space into error message about unsupported extension version.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/riscv-arch.c:428 // RV32-EXPERIMENTAL-BADVERS: error: invalid arch name 'rv32izbt0p1' // RV32-EXPERIMENTAL-BADVERS: unsupported version

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne marked 5 inline comments as done. ldionne added inline comments. Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) +set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE

[libunwind] f8da28f - [runtimes] [cmake] Fix -Werror detection in common build configs

Author: Martin Storsjö Date: 2022-05-12T22:22:15+03:00 New Revision: f8da28f5228857e905eedb248ac82c939777f9df URL: https://github.com/llvm/llvm-project/commit/f8da28f5228857e905eedb248ac82c939777f9df DIFF:

[PATCH] D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125323/new/ https://reviews.llvm.org/D125323

[PATCH] D125491: [RISCV] Add extra space into error message about unsupported extension version.

craig.topper created this revision. craig.topper added reviewers: kito-cheng, khchen, arcbbb, asb, luismarques, jrtc27. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

pcc added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1843 + + auto *FTRTTIProxy = new llvm::GlobalVariable( + TheModule, Addr->getType(), ychen wrote: > pcc wrote: > > Are these proxy variables necessary? I think that now that we have

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

akyrtzi updated this revision to Diff 429033. akyrtzi added a comment. Added #include "clang/Basic/FileEntry.h" in `PreprocessorOptions.h` to accommodate the modules build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125488/new/

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1843 + + auto *FTRTTIProxy = new llvm::GlobalVariable( + TheModule, Addr->getType(), pcc wrote: > Are these proxy variables necessary? I think that now that we have custom > code

[PATCH] D125486: [Tooling/DependencyScanning] Remove `ExcludedPreprocessorDirectiveSkipMapping` and related functionality

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125486/new/ https://reviews.llvm.org/D125486

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

efriedma added a comment. Updated messed up formatting? Otherwise, I guess this is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/ https://reviews.llvm.org/D124038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! Thanks for splitting this out. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:120 +clEnumValN(ScanningMode::DependencyDirectivesScan, +

[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi added a comment. I've split this in smaller patches: https://reviews.llvm.org/D125484 - NFC rename refactorings https://reviews.llvm.org/D125486 - Remove `ExcludedPreprocessorDirectiveSkipMapping` https://reviews.llvm.org/D125487 - Change to producing pre-lexed directive tokens instead

[PATCH] D125254: [clang] Allow all string types for all attribute(format) styles

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91ed7e194181: [clang] Allow all string types for all attribute(format) styles (authored by fcloutier). Changed prior to commit:

[clang] 91ed7e1 - [clang] Allow all string types for all attribute(format) styles

Author: Félix Cloutier Date: 2022-05-12T11:12:38-07:00 New Revision: 91ed7e19418181ae385c2626cedd3b08b6ba43a6 URL: https://github.com/llvm/llvm-project/commit/91ed7e19418181ae385c2626cedd3b08b6ba43a6 DIFF:

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

rnk added a comment. In D123534#3507891 , @hctim wrote: > Not sure about PDB. I did run a quick test with `gdb`, and very > unscientifically, didn't notice any difference in usability or errors between > pre- and post-this patch on a `clang` invocation

[PATCH] D121911: [Clang] Add DriverKit support

egorzhdan updated this revision to Diff 429025. egorzhdan added a comment. Remove static analyzer changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121911/new/ https://reviews.llvm.org/D121911 Files: clang/include/clang/Basic/Attr.td

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D125487 This is 4/4 of a series of patches, bringing the following benefits:

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

pcc added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1843 + + auto *FTRTTIProxy = new llvm::GlobalVariable( + TheModule, Addr->getType(), Are these proxy variables necessary? I think that now that we have custom code generation for

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D125486 This is 3/4 of a series of patches for making the special lexing for

[PATCH] D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary added a comment. In D122747#3509495 , @lenary wrote: > I want to keep the number of llvm functions the same, as they cover a wide > variety of control flow at a wide variety of data widths which the pass > should cope with. > > One thing that I

[PATCH] D125486: [Tooling/DependencyScanning] Remove `ExcludedPreprocessorDirectiveSkipMapping` and related functionality

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D125484 This is 2/4 of a series of patches for making the special lexing for

[PATCH] D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens

akyrtzi created this revision. Herald added a subscriber: mgorny. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is 1/4 of a series of patches for making the special lexing for dependency

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

ahatanak added a comment. Is it not possible to handle this similarly to `volatile unsigned`? If I replace `_Atomic unsigned` with `volatile unsigned`, I see `LookupOverloadedBinOp` succeed without having to strip volatile because `addAssignmentArithmeticOverloads` adds candidates with

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 429005. ken-matsui added a comment. Revert the changes for errored directives Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 Files: clang/docs/ReleaseNotes.rst

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1257 // If we reached here, the preprocessing token is not valid! - Diag(Result, diag::err_pp_invalid_directive); + Diag(Result, diag::err_pp_invalid_directive) << 0;

[PATCH] D125481: [pseudo] NFC, bail out the parse loop if there is no active heads.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. And print the line number in the debug message, which makes it easier to

[PATCH] D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary added a comment. I want to keep the number of llvm functions the same, as they cover a wide variety of control flow at a wide variety of data widths which the pass should cope with. One thing that I would like to cut down is the duplicated set of CHECK lines, one with scheduling and

[PATCH] D125479: [pseudo] Fix the incorrect parameters-and-qualifiers rule.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The parenthese body should be `parameter-declaration-clause`, rather than

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

steplong updated this revision to Diff 429000. steplong added a comment. - Added description in release notes - Fixed up some comments in Sema.h Will merge once build passes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125011/new/

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1257 // If we reached here, the preprocessing token is not valid! - Diag(Result, diag::err_pp_invalid_directive); + Diag(Result, diag::err_pp_invalid_directive) << 0;

[PATCH] D124915: Check for resource exhaustion when recursively parsing declarators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc67104172034: Check for resource exhaustion when recursively parsing declarators (authored by aaron.ballman). Repository: rG LLVM Github Monorepo

[clang] c671041 - Check for resource exhaustion when recursively parsing declarators

Author: Aaron Ballman Date: 2022-05-12T13:20:35-04:00 New Revision: c671041720347c9deb35b1165ee6b6bb88abf07a URL: https://github.com/llvm/llvm-project/commit/c671041720347c9deb35b1165ee6b6bb88abf07a DIFF: https://github.com/llvm/llvm-project/commit/c671041720347c9deb35b1165ee6b6bb88abf07a.diff

[PATCH] D125254: [clang] Allow all string types for all attribute(format) styles

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM with one minor comment. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3864 - if (Kind == CFStringFormat) { -if (!isCFStringType(Ty, S.Context)) { -

[PATCH] D124915: Check for resource exhaustion when recursively parsing declarators

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. >> Another concern here: Do we properly initialize "Actions" in the case where >> we don't have a semantic Action? That is, if we are just preprocessing? Doh! Forgot we don't do

[PATCH] D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum

MaskRay added a comment. The test file has 4000+ lines. Any chance making it smaller? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122747/new/ https://reviews.llvm.org/D122747 ___ cfe-commits mailing

[PATCH] D124915: Check for resource exhaustion when recursively parsing declarators

aaron.ballman updated this revision to Diff 428987. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Simplify the implementation by using the facilities Sema already exposes. The behavior remains the same:

[PATCH] D124915: Check for resource exhaustion when recursively parsing declarators

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Parse/Parser.h:802 + /// more in that case. Use this in code that may recurse deeply (for example, + /// in template instantiation) to avoid stack overflow. +

[PATCH] D121733: Clean pathnames in FileManager.

benlangmuir added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:218 + llvm::sys::path::remove_dots(CleanFilename, /*remove_dot_dot=*/false); + Filename = CleanFilename; + ppluzhnikov wrote: > kadircet wrote: > > this is actually breaking the

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 428985. ken-matsui added a comment. Add test for errored directive but no suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 Files:

[PATCH] D124915: Check for resource exhaustion when recursively parsing declarators

erichkeane added inline comments. Comment at: clang/lib/Parse/Parser.cpp:2618 + // Only warn about this once. + if (!Actions.WarnedStackExhausted) { +Diag(Loc, diag::warn_stack_exhausted); Another concern here: Do we properly initialize "Actions" in the

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 428983. ken-matsui added a comment. Update the code as reviewed and add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 Files:

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added a comment. Thank you for your review :) Comment at: clang/lib/Lex/PPDirectives.cpp:1257 // If we reached here, the preprocessing token is not valid! - Diag(Result, diag::err_pp_invalid_directive); + Diag(Result, diag::err_pp_invalid_directive) << 0;

[PATCH] D124915: Check for resource exhaustion when recursively parsing declarators

erichkeane added a comment. I don't see how you can test this behavior without figuring out how to get a 'perfect' number to warn but not crash... The only way to validate that I would expect would be to do some bizarre flag that has us just 'don't run' in the case where the warning is

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

aaron.ballman added a comment. I think the only thing missing is an update to the documentation: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/AttrDocs.td#L5999, and add a release note about the change in functionality. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:421 install( FILES ${ppc_wrapper_files} craig.topper wrote: > qiongsiwu1 wrote: > > craig.topper wrote: > > > There appear to be two installs of ppc_wrapper_files with different

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 428981. steplong added a comment. - Updated line in docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124702/new/ https://reviews.llvm.org/D124702 Files: clang/docs/ReleaseNotes.rst

[PATCH] D125473: Comment parsing: Treat properties as zero-argument inline commands

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. That is more accurate, and using a separate class in TableGen seems

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary marked 3 inline comments as done. lenary added inline comments. Comment at: llvm/lib/Target/ARM/ARMFixCortexA57AES1742098Pass.cpp:12-19 +// The intention is this: +// - Any 128-bit or 64-bit writes to the neon input register of an AES fused +// pair are safe (the inputs

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary updated this revision to Diff 428978. lenary marked 3 inline comments as done. lenary added a comment. - Address comment nits - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119720/new/ https://reviews.llvm.org/D119720 Files:

[PATCH] D124026: [Headers][MSVC] Define wchar_t in stddef.h like MSVC if not using the builtin type

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f9837cfa636: [Headers][MSVC] Define wchar_t in stddef.h like MSVC if not using the builtin… (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7f9837c - [Headers][MSVC] Define wchar_t in stddef.h like MSVC if not using the builtin type

Author: Stephen Long Date: 2022-05-12T09:38:07-07:00 New Revision: 7f9837cfa63663ccd51da3e5de73acec8f776ee8 URL: https://github.com/llvm/llvm-project/commit/7f9837cfa63663ccd51da3e5de73acec8f776ee8 DIFF: https://github.com/llvm/llvm-project/commit/7f9837cfa63663ccd51da3e5de73acec8f776ee8.diff

[PATCH] D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary updated this revision to Diff 428975. lenary added a comment. Herald added subscribers: cfe-commits, MaskRay, hiraditya, mgorny. Herald added a project: clang. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122747/new/

[PATCH] D124915: Check for resource exhaustion when recursively parsing declarators

aaron.ballman updated this revision to Diff 428969. aaron.ballman added a comment. Rebased. I removed the test coverage because it turned out to not be testing anything. If we exhaust resources, then we don't run the `-verify` to test the diagnostic behavior, and we're relying on the crash

  1   2   >