[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

craig.topper added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:421 install( FILES ${ppc_wrapper_files} qiongsiwu1 wrote: > craig.topper wrote: > > qiongsiwu1 wrote: > > > craig.topper wrote: > > > > There appear to be two installs of

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari created this revision. Purva-Chaudhari added a reviewer: v.g.vassilev. Herald added a project: All. Purva-Chaudhari requested review of this revision. If error was encountered after template instantiation, the clang-repl interactive mode was aborted. The patch adds recovery

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

pcwang-thead updated this revision to Diff 430567. pcwang-thead added a comment. Add double underscore to all variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125875/new/ https://reviews.llvm.org/D125875 Files:

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

pcwang-thead added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1512 +__attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) +unsigned long vread_csr(enum RVV_CSR csr) { + unsigned long rv = 0; craig.topper wrote: >

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1512 +__attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) +unsigned long vread_csr(enum RVV_CSR csr) { + unsigned long rv = 0; pcwang-thead wrote: >

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

pcwang-thead added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1511 +__extension__ extern __inline +__attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) +unsigned long vread_csr(enum RVV_CSR csr) { craig.topper wrote: >

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

ChuanqiXu added a comment. In D125291#3523818 , @efriedma wrote: > I don't really understand how this is supposed to interact with D125292 > ; even if you strip the readnone attribute > from the call instruction, we'll

[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

mpaszkowski accepted this revision. mpaszkowski added a comment. This revision is now accepted and ready to land. The typos noticed by Ilia need to be fixed, but apart from this the patch LGTM! Thank you Anastasia! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125679/new/

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1511 +__extension__ extern __inline +__attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) +unsigned long vread_csr(enum RVV_CSR csr) { Do we need

[PATCH] D123649: Allow flexible array initialization in C++.

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4639 + getDataLayout().getTypeAllocSize(Init->getType())); + assert(VarSize == CstSize && "Emitted constant has unexpected size"); +#endif efriedma wrote: > ahatanak

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

efriedma added a comment. I don't really understand how this is supposed to interact with D125292 ; even if you strip the readnone attribute from the call instruction, we'll still treat a call to the intrinsic as readnone. I think I'd prefer to lower the

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak created this revision. ahatanak added reviewers: rjmccall, akyrtzi. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. The assertion doesn't hold if there are temporaries created in the AsmStmt passed to the method. rdar://92845835

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. I feel that to progress further on this change, it would be good to get details about the use cases and the limitations first. However, if there is sufficient evidence of the

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

jkorous added a comment. In D125349#3509073 , @aaron.ballman wrote: > It's interesting to note that `an_atomic_uint = an_atomic_uint + > an_enum_value` works correctly: https://godbolt.org/z/cvP9e6nh7. I was trying > to figure out whether the atomic

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

jkorous added a comment. In D125349#3509546 , @ahatanak wrote: > Is it not possible to handle this similarly to `volatile unsigned`? If I > replace `_Atomic unsigned` with `volatile unsigned`, I see > `LookupOverloadedBinOp` succeed without having to

[PATCH] D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr

craig.topper added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:346 + getSuffixStr(BasicType Type, int Log2LMUL, + const llvm::ArrayRef ); }; Drop the `const` and the reference Repository: rG LLVM Github

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Add support for correlated branches to the

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:769-783 +DataExtractor Data(Location.Expr, /*IsLittleEndian=*/true, 8); +uint64_t DataOffset = 0; +uint8_t Operation = Data.getU8(); +if (Operation == dwarf::DW_OP_addr) { +

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 430509. hctim marked an inline comment as done. hctim added a comment. Explicitly only match 'DW_OP_addr[x] [+ DW_OP_plus_uconst]' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/

[PATCH] D125840: [Analyzer] Removed extra space from NSErrorChecker debug message and updated relevant tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd7233bc67e4: [Analyzer] Remove extra space from NSErrorChecker message. (authored by usama54321, committed by Artem Dergachev adergac...@apple.com). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] dd7233b - [Analyzer] Remove extra space from NSErrorChecker message.

Author: Usama Hameed Date: 2022-05-18T14:35:12-07:00 New Revision: dd7233bc67e45106c4625df7d20391798f31d4a7 URL: https://github.com/llvm/llvm-project/commit/dd7233bc67e45106c4625df7d20391798f31d4a7 DIFF: https://github.com/llvm/llvm-project/commit/dd7233bc67e45106c4625df7d20391798f31d4a7.diff

[PATCH] D125930: [clangd] WIP: Experimental support for "IWYU pragma: export"

kbobyrev created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/CMakeLists.txt:1 +set(CLANG_PSEUDO_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) + sammccall wrote: > I think these variables shared across CMakeLists.txt files generally add more > confusion than

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

hokein updated this revision to Diff 430506. hokein added a comment. format fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125667/new/ https://reviews.llvm.org/D125667 Files: clang-tools-extra/pseudo/CMakeLists.txt

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

hokein updated this revision to Diff 430504. hokein marked 8 inline comments as done. hokein added a comment. Herald added a subscriber: mgrang. Address comments: - split to a grammar subdirectory - remove cxx_gen.cmake, move it to include/CMakeLists.txt - rename cxx -> CXX Repository: rG

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

LegalizeAdulthood added a comment. In D124806#3523228 , @njames93 wrote: > In D124806#3523109 , > @LegalizeAdulthood wrote: > >> LGTM! Thanks for taking my idea and implementing it much better than what I >>

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125770/new/ https://reviews.llvm.org/D125770

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa1fa0a0a07: Reland [dwarf] Emit a DIGlobalVariable for constant strings. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES

[clang] 7aa1fa0 - Reland "[dwarf] Emit a DIGlobalVariable for constant strings."

Author: Mitch Phillips Date: 2022-05-18T13:56:45-07:00 New Revision: 7aa1fa0a0a07f7949d2d77c099aab43cf9b75a91 URL: https://github.com/llvm/llvm-project/commit/7aa1fa0a0a07f7949d2d77c099aab43cf9b75a91 DIFF:

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 430494. hctim added a comment. Fix the fuchsia windows bot by making the DILocalVariables in the test order-independent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

efriedma added inline comments. Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:1844 +for (const auto : MBB) + if (MI.getOpcode() == ARM::tSTRspi || MI.getOpcode() == ARM::tSTRi) +for (const auto : MI.operands()) How do you end up with

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

rsmith added a comment. Header modules are part of the C++20 standard (where they are called "header units"), and module maps are an intended way for Clang to provide this functionality in C++20 mode. I don't think turning this off by default in C++20 is the right forward-looking plan; rather,

[PATCH] D125925: Add an option to fill container for ref

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This allows index

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

rouson added a comment. I think this is an exciting step. I hope it gets approved. Although it's technically true that this could appear to be a regression for current flang script users, the ultimate compilation currently happens by invoking an external compiler so most current flang script

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

rjmccall added a comment. We definitely don't want ObjC to differ here; thanks for the CC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125919/new/ https://reviews.llvm.org/D125919 ___ cfe-commits

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

shraiysh added a comment. > With this change the flang driver will not generate an executable unless it > is built with an option. Okay, thank you for the clarification. Is this a cmake option and? Are we documenting this somewhere except this patch summary, like on the flang documentation or

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

hokein added a comment. In D125311#3503452 , @sammccall wrote: > This looks good, but if that's the idiom we should add it to cook() also. cook is more tricky, it takes a TokenStream, and returns a new one with an allocator payload: - the input

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

kiranchandramohan added a comment. In D125788#3523259 , @shraiysh wrote: >> clarify that execution is still restricted to developers via a flag. > > Just confirming what this means: After this patch, would `flang sample.f90` > generate an executable? If

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman added reviewers: rjmccall, dexonsmith. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Adding some Apple reviewers because this touches ObjC behavior (I would be very surprised if ObjC wanted different rules here than C though).

[PATCH] D125874: [clang-tidy] Fix readability-simplify-boolean-expr when Ifs have an init statement or condition variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG35660247dd9c: [clang-tidy] Fix readability-simplify-boolean-expr when Ifs have an init… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 3566024 - [clang-tidy] Fix readability-simplify-boolean-expr when Ifs have an init statement or condition variable

Author: Nathan James Date: 2022-05-18T20:47:37+01:00 New Revision: 35660247dd9ce850dccd60cc55428a510dbdd1c8 URL: https://github.com/llvm/llvm-project/commit/35660247dd9ce850dccd60cc55428a510dbdd1c8 DIFF: https://github.com/llvm/llvm-project/commit/35660247dd9ce850dccd60cc55428a510dbdd1c8.diff

[PATCH] D125920: [analyzer][NFC] Remove the unused LocAsInteger::getPersistentLoc()

steakhal created this revision. steakhal added reviewers: NoQ, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay added a comment. In addition, if every new GCC release requires addition to /opt/rh/gcc-toolset-$major (if I understand correctly), we probably want to switch to `llvm::vfs::directory_iterator` iteration and using the largest version. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

njames93 added a comment. These tests aren't that great. I'd advise adding a test that just checks using the userDefinedLiteral in `bugprone-argument-comment-literals.cpp`, That check file will add comments to parameters that don't have them. That way you aren't testing against distinguishing

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay added a comment. It may be time to add unittests to `clang/unittests/Driver/ToolChainTest.cpp` for /opt/rh detection. You may use `TEST(ToolChainTest, VFSGCCInstallation)` as an example creating a pseudo file hierarchy in memory. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] d8166e1 - [Driver] Refactor /opt/rh detection

Author: Fangrui Song Date: 2022-05-18T12:40:27-07:00 New Revision: d8166e1900c05429abc726d379bc33281c4c98e4 URL: https://github.com/llvm/llvm-project/commit/d8166e1900c05429abc726d379bc33281c4c98e4 DIFF: https://github.com/llvm/llvm-project/commit/d8166e1900c05429abc726d379bc33281c4c98e4.diff

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Sema/warn-missing-prototypes.c:61 +// FIXME: because qualifiers are ignored in the return type when forming the +// type from the

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, tahonermann, jyknight, efriedma, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. WG14 DR423

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

steakhal added a comment. Okay, it took me a while to get what's going on. Do you have anything in mind to express it by slightly less indirection, references, templates and well, virtual functions xD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125693: [DebugInfo][WIP] Support types, imports and static locals declared in a lexical block (3/5)

asavonic added a comment. Thanks a lot for the patch! It would be great to get this issue finally fixed. I assume that this is the main patch, other patches in the stack seem like just preparation/adjustments needed for this one to work. > This an alternative implementation for D113741 >

[PATCH] D125874: [clang-tidy] Fix readability-simplify-boolean-expr when Ifs have an init statement or condition variable

njames93 updated this revision to Diff 430473. njames93 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125874/new/ https://reviews.llvm.org/D125874 Files:

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

shraiysh added a comment. > clarify that execution is still restricted to developers via a flag. Just confirming what this means: After this patch, would `flang sample.f90` generate an executable? If not, how to generate an executable using `flang-new`? If yes, does this mean that if I just

[PATCH] D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/lib/Parse/ParseOpenMP.cpp:2925 EndLoc); - // Exit scope. Restore Repository: rG LLVM Github Monorepo

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 updated this revision to Diff 430472. njames93 added a comment. Remove unnecessary parens in documentation as check will remove the parens when possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124806/new/

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

shraiysh added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend abidmalikwaterloo wrote: > shraiysh wrote: > > unrelated change? > When I rebase, these changes were highlighted in the main branch which

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 added a comment. In D124806#3523109 , @LegalizeAdulthood wrote: > LGTM! Thanks for taking my idea and implementing it much better than what I > had `:)`. Cheers. Can I ask why you feel that this should be behind an option? Repository: rG

[PATCH] D125840: [Analyzer] Removed extra space from NSErrorChecker debug message and updated relevant tests

usama54321 updated this revision to Diff 430469. usama54321 added a comment. Fixed clang-format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125840/new/ https://reviews.llvm.org/D125840 Files:

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:488-490 +`private_var`, `firstprivate_var`, and `lastprivate_var` arguments are +variadic list of operands that specify

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

rsundahl updated this revision to Diff 430461. rsundahl added a comment. Fix (and cleanup) for failure of CodeGen arm.c check in ci/cd pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125195/new/ https://reviews.llvm.org/D125195 Files:

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Discarding in favor of Nathan James's improved implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124650/new/ https://reviews.llvm.org/D124650 ___

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM! Thanks for taking my idea and implementing it much better than what I had `:)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e64722f - [CMake][Fuchsia] Build runtimes as universal libraries on OS X

Author: Petr Hosek Date: 2022-05-18T18:14:42Z New Revision: e64722f686bd8a6d0c2c099ce6fb90e84f51341d URL: https://github.com/llvm/llvm-project/commit/e64722f686bd8a6d0c2c099ce6fb90e84f51341d DIFF: https://github.com/llvm/llvm-project/commit/e64722f686bd8a6d0c2c099ce6fb90e84f51341d.diff LOG:

[PATCH] D125908: [CMake][Fuchsia] Build runtimes as universal libraries on OS X

This revision was automatically updated to reflect the committed changes. Closed by commit rGe64722f686bd: [CMake][Fuchsia] Build runtimes as universal libraries on OS X (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125908/new/

[PATCH] D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, sstefan1. Herald added a

[PATCH] D125909: [AMDGPU] emit macro __GFX9__ etc

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:414 + assert(CanonName.startswith("gfx") && "Invalid amdgcn canonical name"); + Builder.defineMacro(Twine("__") + Twine(CanonName.drop_back(2).upper())

[PATCH] D125840: [Analyzer] Removed extra space from NSErrorChecker debug message and updated relevant tests

usama54321 updated this revision to Diff 430450. usama54321 added a comment. Updated tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125840/new/ https://reviews.llvm.org/D125840 Files: clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp

[PATCH] D125909: [AMDGPU] emit macro __GFX9__ etc

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:414 + assert(CanonName.startswith("gfx") && "Invalid amdgcn canonical name"); + Builder.defineMacro(Twine("__") +

[PATCH] D125829: [clang] Fix __has_builtin

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2555-2557 if (FeatureList.empty()) return; assert(!FeatureList.contains(' ') && "Space in feature list"); tra wrote: >

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

Anastasia added a comment. In D124382#3496417 , @jchlanda wrote: > In D124382#3480600 , @Anastasia > wrote: > >> > > > >> And I think we could add this feature in a very light way for example by >> reserving

[PATCH] D125829: [clang] Fix __has_builtin

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a possible nit. Comment at: clang/lib/Basic/BuiltinTargetFeatures.h:32 +/// pairs. +class TargetFeatures { + struct FeatureListStatus { yaxunl wrote: >

[libunwind] bedf657 - [runtimes] Default LIB*_HERMETIC_STATIC_LIBRARY to ON on Windows

Author: Martin Storsjö Date: 2022-05-18T20:31:51+03:00 New Revision: bedf657d0f4c54ffe9ef4303382657a74296b544 URL: https://github.com/llvm/llvm-project/commit/bedf657d0f4c54ffe9ef4303382657a74296b544 DIFF:

[PATCH] D125911: [pseudo] (trivial) bracket-matching

sammccall added a comment. The Bracket struct & translation between token/bracket streams is not really justified by the implementation in this patch. Next patch will run nontrivial algorithms on the bracket strings. Happy to scope this patch down (avoid that struct) or up (include the full

[PATCH] D122256: [clang][ABI] New C++20 module mangling scheme

MaskRay added a comment. The differential has the same intention/subject as D118352 . In such a case reusing the preexisting differential would have been better. I have left more comments on https://reviews.llvm.org/D125825#3522911 Note: a revert was

[PATCH] D125911: [pseudo] (trivial) bracket-matching

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Error-tolerant bracket

[PATCH] D125909: [AMDGPU] emit macro __GFX9__ etc

yaxunl created this revision. yaxunl added reviewers: b-sumner, tra, arsenm. Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. Emit predefined macros for

[PATCH] D125908: [CMake][Fuchsia] Build runtimes as universal libraries on OS X

phosek created this revision. phosek added a reviewer: abrachet. Herald added subscribers: pengfei, kristof.beyls, mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to build libunwind,

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added a comment. I managed to get a stack trace from a bot (by leaving the broken commit up for longer this time). In D115232#3522598 , @thakis wrote: > In D115232#3522571

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 created this revision. jhuber6 added reviewers: yaxunl, tra. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CUDA requires that static variables

[PATCH] D125829: [clang] Fix __has_builtin

yaxunl updated this revision to Diff 430420. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125829/new/ https://reviews.llvm.org/D125829 Files: clang/include/clang/Basic/Builtins.h

[PATCH] D125829: [clang] Fix __has_builtin

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/Builtins.h:263 + ///false if it is disabled. + bool isRequiredTargetFeaturesEnabled( + unsigned BuiltinID, const llvm::StringMap ) const; tra

[PATCH] D125259: [C11] Diagnose unreachable generic selection associations

aaron.ballman added a comment. In D125259#3522198 , @aaron.ballman wrote: > In D125259#3520118 , @aaron.ballman > wrote: > >> In D125259#3519947 , >> @aaron.ballman

[PATCH] D125882: Correct the diagnostic behavior for unreachable _Generic associations in C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47b8424a533d: Correct the diagnostic behavior for unreachable _Generic associations in C++ (authored by aaron.ballman). Changed prior to commit:

[clang] 47b8424 - Correct the diagnostic behavior for unreachable _Generic associations in C++

Author: Aaron Ballman Date: 2022-05-18T12:45:38-04:00 New Revision: 47b8424a533d5c02fd8b3517047cf93e533f00d0 URL: https://github.com/llvm/llvm-project/commit/47b8424a533d5c02fd8b3517047cf93e533f00d0 DIFF: https://github.com/llvm/llvm-project/commit/47b8424a533d5c02fd8b3517047cf93e533f00d0.diff

[PATCH] D125882: Correct the diagnostic behavior for unreachable _Generic associations in C++

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1699 + // If T is a non-class type, the type of the prvalue is the cv- + // unqualified version of T. Otherwise, the type of the prvalue is T. unsigned Reason = 0;

[clang-tools-extra] 4739176 - [clang-tidy] Fix readability-simplify-boolean-expr crash with implicit cast in return.

Author: Nathan James Date: 2022-05-18T17:38:44+01:00 New Revision: 4739176fd3047dfa13eae307c56c6dba7b605019 URL: https://github.com/llvm/llvm-project/commit/4739176fd3047dfa13eae307c56c6dba7b605019 DIFF: https://github.com/llvm/llvm-project/commit/4739176fd3047dfa13eae307c56c6dba7b605019.diff

[PATCH] D125877: [clang-tidy] Fix readability-simplify-boolean-expr crash with implicit cast in return.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4739176fd304: [clang-tidy] Fix readability-simplify-boolean-expr crash with implicit cast in… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

steakhal marked 2 inline comments as done. steakhal added a comment. Thanks for the review @LegalizeAdulthood! Can I consider this change accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125770/new/ https://reviews.llvm.org/D125770

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 430408. MosheBerman marked an inline comment as done and 2 inline comments as not done. MosheBerman added a comment. Addressed feedback. - Removed comment about NS-classes - Changed some of the LIT test invocations - Added StringRef where appropriate.

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend shraiysh wrote: > unrelated change? When I rebase, these changes were highlighted in the main branch which was missing in the

[PATCH] D125882: Correct the diagnostic behavior for unreachable _Generic associations in C++

tahonermann accepted this revision. tahonermann added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125882/new/ https://reviews.llvm.org/D125882 ___ cfe-commits mailing list

[libunwind] c218fd3 - [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE.

Author: Daniel Kiss Date: 2022-05-18T17:56:16+02:00 New Revision: c218fd3d7d3764eb123c8429bbcd33bacfe2e633 URL: https://github.com/llvm/llvm-project/commit/c218fd3d7d3764eb123c8429bbcd33bacfe2e633 DIFF: https://github.com/llvm/llvm-project/commit/c218fd3d7d3764eb123c8429bbcd33bacfe2e633.diff

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

efriedma added a comment. On a target that doesn't support SMP, you don't need memory barriers, sure. (I think we'd want a CMake flag to explicitly assert that you're only going to run the code on chips without SMP.) That doesn't really solve your issue, though. To implement atomic

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-deprecated-headers-extern-c.cpp:37 -#include // FIXME: We should have no warning into system headers. -// CHECK-MESSAGES-WARN-INTO-HEADERS: mysystemlib.h:1:10: warning:

[PATCH] D115232: [clangd] Indexing of standard library

thakis added a comment. In D115232#3522571 , @sammccall wrote: > In D115232#3522514 , @thakis wrote: > >> In D115232#3520461 , @sammccall >> wrote: >> >>> Hmm, the test

[clang-tools-extra] 77533ea - Revert "Reland(2) "[clangd] Indexing of standard library""

Author: Sam McCall Date: 2022-05-18T17:38:45+02:00 New Revision: 77533ea443aca6e9978d7c8a6822420f8345f6af URL: https://github.com/llvm/llvm-project/commit/77533ea443aca6e9978d7c8a6822420f8345f6af DIFF: https://github.com/llvm/llvm-project/commit/77533ea443aca6e9978d7c8a6822420f8345f6af.diff

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added a comment. In D115232#3522514 , @thakis wrote: > In D115232#3520461 , @sammccall > wrote: > >> Hmm, the test keeps crashing on the GN bot: >> http://45.33.8.238/win/58316/step_9.txt >>

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

steakhal added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-deprecated-headers-extern-c.cpp:37 -#include // FIXME: We should have no warning into system headers. -// CHECK-MESSAGES-WARN-INTO-HEADERS: mysystemlib.h:1:10: warning:

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 430392. kosarev added a comment. Herald added a project: Flang. Added Flang fixes and rebased. Thanks Simon for the quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/

[PATCH] D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr

kito-cheng updated this revision to Diff 430391. kito-cheng added a comment. Changes: - clang-format has applied on unexpected part, remove that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125893/new/ https://reviews.llvm.org/D125893 Files:

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125885/new/ https://reviews.llvm.org/D125885

  1   2   >