[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

rsmith added a comment. This direction looks good to me. Thanks! Regarding the possibility of storing the declaration attributes on the `DeclSpec` rather than on the `Declarator`, I wonder if a better choice might be to make the `Declarator` hold a non-owning reference to the attributes, like

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. @compnerd Thanks for reporting. I will take a look as soon as possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99/new/ https://reviews.llvm.org/D99 ___

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

flx added a comment. I don't have access to Windows, perhaps rebase and try again? It looks like the template specialization related tests are failing there though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593

[PATCH] D126052: [clang-format] Handle "complex" conditionals in RemoveBracesLLVM

owenpan updated this revision to Diff 431100. owenpan added a comment. Changed an unnecessary condition to an assertion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126052/new/ https://reviews.llvm.org/D126052 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

NoQ added a comment. Thx Dmitry! Usama, I heard you have plans to make `isUnevaluated()` consume statements so that you could feed the entire loop into the machine without separating it into parts. You can either update this patch or do that as a follow-up patch. Also I think it's time for

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

NoQ added a comment. Looks awesome! > add_new_check.py I'm surprised it wasn't executable already, do we want to keep it? Comment at: clang-tools-extra/clang-tidy/objc/CMakeLists.txt:13 NSInvocationArgumentLifetimeCheck.cpp + NsdateformatterCheck.cpp

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim created this revision. hctim added reviewers: vitalybuka, kstoimenov. Herald added subscribers: ormris, jdoerfert, steven_wu, hiraditya. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D126093: Sema: adjust assertion to account for deduced types

compnerd updated this revision to Diff 431084. compnerd added a comment. git-clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126093/new/ https://reviews.llvm.org/D126093 Files: clang/include/clang/Sema/DeclSpec.h clang/test/Sema/typerep-typespec.c Index:

[PATCH] D126097: Adds the NSDateFormatter checker to clang-tidy

t-rasmud created this revision. t-rasmud added a reviewer: NoQ. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. t-rasmud requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Reports incorrect string

[PATCH] D126096: [clang-format] Fix QualifierAlignment with global namespace qualified types.

curdeius added a comment. If you can think of other cases that may misbehave, I'll be happy to test (and fix) these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126096/new/ https://reviews.llvm.org/D126096

[PATCH] D126096: [clang-format] Fix QualifierAlignment with global namespace qualified types.

curdeius created this revision. curdeius added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

amyk added a comment. I was wondering where are the test cases in this patch. Did they get missed when updating the revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124093/new/ https://reviews.llvm.org/D124093

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

sunfish updated this revision to Diff 431067. sunfish added a comment. Add tests for -mcpu=mvp and -mcpu=bleeding-edge. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125728/new/ https://reviews.llvm.org/D125728 Files:

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126024/new/ https://reviews.llvm.org/D126024

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126023/new/ https://reviews.llvm.org/D126023

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

sunfish updated this revision to Diff 431064. sunfish added a comment. Add a driver test, and add release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125728/new/ https://reviews.llvm.org/D125728 Files: clang/docs/ReleaseNotes.rst

[PATCH] D126093: Sema: adjust assertion to account for deduced types

compnerd created this revision. compnerd added a reviewer: aaron.ballman. compnerd added a project: clang. Herald added a project: All. compnerd requested review of this revision. Previous changes for the BTF attributes introduced a new sub-tree visitation. That uncovered that when accessing the

[PATCH] D125350: [RFC][Clang] Add a check if the target supports atomicrmw instruction with specific operator and type

tianshilei1992 abandoned this revision. tianshilei1992 added a comment. Do it in BE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125350/new/ https://reviews.llvm.org/D125350 ___ cfe-commits mailing

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added a comment. In D124836#3528521 , @vvereschaka wrote: > got it. Yes, looks like it fixed. The test got passed during the last build: > https://lab.llvm.org/buildbot/#/builders/104/builds/7812 > Thank you. I'm sorry for the failure. I thought

[PATCH] D125911: [pseudo] (trivial) bracket-matching

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/unittests/BracketTest.cpp:103 +TEST(Bracket, SimplePair) { + verifyBrackets("^{ ^[ ^( ^) ^( ^) ^] ^}"); + verifyBrackets(") ^{ ^[ ^] ^} ("); hokein wrote: > For this simple case, just using

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

vvereschaka added a comment. got it. Yes, looks like it fixed. The test got passed during the last build: https://lab.llvm.org/buildbot/#/builders/104/builds/7812 Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

fhahn added a comment. In D124836#3528109 , @vvereschaka wrote: > Hi @void , > > the `zero-call-used-regs.ll` test gets failed on > `llvm-clang-x86_64-expensive-checks-ubuntu` builder with the following errors: > > ... > *** Bad machine code:

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:31 + -std=c++(98|11|14|17|20)[-or-later]: +This flag will cause multiple runs within the same check_clang_tidy +execution. Make sure you don't have shared state

[PATCH] D125911: [pseudo] (trivial) bracket-matching

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks a good start version! Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Bracket.h:9 +// +// Bracket structure (particularly brackes) is key to

[clang] acec070 - [OpenMP] Fix partial unrolling off-by-one.

Author: Michael Kruse Date: 2022-05-20T15:19:52-05:00 New Revision: acec07005e038ab2891f235ae60ba2f0236bb952 URL: https://github.com/llvm/llvm-project/commit/acec07005e038ab2891f235ae60ba2f0236bb952 DIFF: https://github.com/llvm/llvm-project/commit/acec07005e038ab2891f235ae60ba2f0236bb952.diff

[clang] ade5b55 - Add a page to track C defect report status

Author: Aaron Ballman Date: 2022-05-20T16:07:48-04:00 New Revision: ade5b55af5747413dab8dd57896532fdee19cdf5 URL: https://github.com/llvm/llvm-project/commit/ade5b55af5747413dab8dd57896532fdee19cdf5 DIFF: https://github.com/llvm/llvm-project/commit/ade5b55af5747413dab8dd57896532fdee19cdf5.diff

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

nathanchance added subscribers: nickdesaulniers, nathanchance. nathanchance added a comment. I bisected a crash when compiling the Linux kernel to this change. A reduced C reproducer: enum { OP_CB_GETATTR = 3, OP_CB_RECALL, OP_CB_RECALL_ANY = 8, OP_CB_RECALL_SLOT = 10,

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa82e344c29: [clang-tidy] modernize-deprecated-headers should ignore system headers (authored by steakhal). Repository: rG LLVM Github Monorepo

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. steakhal marked an inline comment as done. Closed by commit rG0606467ea122: [clang-tidy] Introduce the WarnIntoHeaders option to modernize-deprecated… (authored by

[clang-tools-extra] 6fa82e3 - [clang-tidy] modernize-deprecated-headers should ignore system headers

Author: Balazs Benics Date: 2022-05-20T21:41:25+02:00 New Revision: 6fa82e344c291cf0e1134b357b1f09fd2dcd3f4f URL: https://github.com/llvm/llvm-project/commit/6fa82e344c291cf0e1134b357b1f09fd2dcd3f4f DIFF: https://github.com/llvm/llvm-project/commit/6fa82e344c291cf0e1134b357b1f09fd2dcd3f4f.diff

[clang-tools-extra] 0606467 - [clang-tidy] Introduce the WarnIntoHeaders option to modernize-deprecated-headers

Author: Balazs Benics Date: 2022-05-20T21:41:25+02:00 New Revision: 0606467ea122da5cb23a588e1222a4140445734a URL: https://github.com/llvm/llvm-project/commit/0606467ea122da5cb23a588e1222a4140445734a DIFF: https://github.com/llvm/llvm-project/commit/0606467ea122da5cb23a588e1222a4140445734a.diff

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal updated this revision to Diff 431028. steakhal marked 2 inline comments as done. steakhal added a comment. Generalized the flag help text to all supported standard versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) sammccall wrote: > dgoldman wrote: >

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added a comment. The assertion `assert(FromType->isIntegralOrUnscopedEnumerationType())` in `StandardConversionSequence::getNarrowingKind` fails when the invalid initialization is performed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak created this revision. ahatanak added reviewers: rsmith, aaron.ballman. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. rdar://93660425 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126084 Files:

[clang-tools-extra] 665bfbb - Reland "[clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks""

Author: Balazs Benics Date: 2022-05-20T21:12:39+02:00 New Revision: 665bfbb98daa0e40a2e6cecfbbfd6949980d8f2f URL: https://github.com/llvm/llvm-project/commit/665bfbb98daa0e40a2e6cecfbbfd6949980d8f2f DIFF: https://github.com/llvm/llvm-project/commit/665bfbb98daa0e40a2e6cecfbbfd6949980d8f2f.diff

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG665bfbb98daa: Reland [clang-tidy] modernize-deprecated-headers check should respect extern… (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme added inline comments. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s -std=c++17 -fsyntax-only -verify + +struct S1 { mboehme wrote: > mboehme wrote: > > rsmith wrote: > > > mboehme wrote: > > > > rsmith wrote: > > > > >

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

steplong updated this revision to Diff 431021. steplong added a comment. - Use `CharUnits::One()` instead of `getTypeAlignInChars()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126024/new/ https://reviews.llvm.org/D126024 Files:

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong updated this revision to Diff 431019. steplong added a comment. - Switch to `CharUnits::One()` instead of `getContext().getTypeInChars()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126023/new/ https://reviews.llvm.org/D126023 Files:

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

compnerd added a comment. Herald added a project: All. The sema portions of this change are still causing an issue. Although the revert (rGf95bd18b5faa6a5af4b5786312c373c5b2dce687 ) and the subsequent re-application in

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9977 +StoreInst *Store = Builder.CreateAlignedStore( +Val, Ptr, getContext().getTypeAlignInChars(E->getType())); +return Store; I think I'd prefer just

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

efriedma added inline comments. Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:1863 // to combine multiple loads / stores. - bool CanEliminateFrame = true; + bool CanEliminateFrame = !requiresAAPCSFrameRecord(MF); bool CS1Spilled = false; Should

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

tianshilei1992 added a comment. LGTM, but please fix the build error first. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:228 + void Visit(const OMPFailClause *C) { +getNodeDelegate().AddChild([=] { koops wrote: > tianshilei1992 wrote: > >

[clang-tools-extra] 1fef69d - Avoid uninitialized Diag.ID (which we pass but never read)

Author: Sam McCall Date: 2022-05-20T20:29:47+02:00 New Revision: 1fef69da0bfd51de916f0a869f97740c51211cc1 URL: https://github.com/llvm/llvm-project/commit/1fef69da0bfd51de916f0a869f97740c51211cc1 DIFF: https://github.com/llvm/llvm-project/commit/1fef69da0bfd51de916f0a869f97740c51211cc1.diff

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong updated this revision to Diff 431013. steplong added a comment. - Changed addrspace(256) to the default addrspace 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126023/new/ https://reviews.llvm.org/D126023 Files:

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

steven_wu added a comment. In D125847#3528111 , @aeubanks wrote: > I'm still looking into a whole program devirtualization bug that only repros > with opaque pointers, and there are still potential performance issues to > look into Thanks. Maybe here

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

steplong updated this revision to Diff 431011. steplong added a comment. - Change addrspace(256) to the default addrspace 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126024/new/ https://reviews.llvm.org/D126024 Files:

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

aeubanks added a comment. I'm still looking into a whole program devirtualization bug that only repros with opaque pointers, and there are still potential performance issues to look into Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

steven_wu added a comment. Is there any issues currently if we just always use opaque pointer in LTO? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://reviews.llvm.org/D125847 ___

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

vvereschaka added a comment. Hi @void , the `zero-call-used-regs.ll` test gets failed on `llvm-clang-x86_64-expensive-checks-ubuntu` builder with the following errors: ... *** Bad machine code: Illegal physical register for instruction *** - function:all_arg - basic block: %bb.0

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong added a comment. In D126023#3528077 , @rnk wrote: > I was unable to find any documentation for the meaning of AArch64 > addrspace(256), and I wasn't able to figure it out after studying the code in > llvm/lib/Target/AArch64 for ten minutes or

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

rnk added a comment. I was unable to find any documentation for the meaning of AArch64 addrspace(256), and I wasn't able to figure it out after studying the code in llvm/lib/Target/AArch64 for ten minutes or so. The change seems fine, but please add some documentation as a follow-up. X86 has

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

LegalizeAdulthood added a comment. Herald added a project: All. Are we waiting on some sort of benchmark before accepting/rejecting this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117460/new/ https://reviews.llvm.org/D117460

[PATCH] D117409: [clang-tidy] Move IncludeInserter into ClangTidyContext

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Herald added a project: All. If the only thing holding this up is my comments about following the Law of Demeter, I don't think that should block submitting this change.

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125209/new/ https://reviews.llvm.org/D125209

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Address one nit and ship. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125769/new/ https://reviews.llvm.org/D125769

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:180 + the ``CheckHeaderFile=true`` option if header files of the project only + included by c++ source files. Capitalize to `C++` Comment at:

[PATCH] D126077: Fix stack crash in classIsDerivedFrom triggered by clang-tidy

datacompboy created this revision. datacompboy added reviewers: bixia, aartbik. Herald added a project: All. datacompboy requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Protect classIsDerivedFrom from run-out-of-stack

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) dgoldman wrote: > sammccall wrote:

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:22 [-check-suffixes=] \ +[-std=(c++11-or-later|c++17)] \ \ These aren't the only two valid options for this argument Valid values

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

egorzhdan added a comment. Looks like `index-concepts.cpp` is failing on Windows, @arphaman could you please take a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) sammccall wrote: > oops, I forgot

[PATCH] D126002: [clang] Fixing arm-common, windows only and openmp header install targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f12718ccfd6: [clang] Fixing arm-common, windows only and openmp header install targets (authored by qiongsiwu1). Repository: rG LLVM Github

[clang] 1f12718 - [clang] Fixing arm-common, windows only and openmp header install targets

Author: Qiongsi Wu Date: 2022-05-20T12:29:10-04:00 New Revision: 1f12718ccfd660f01ac0e444d4632cf8ce6b98e2 URL: https://github.com/llvm/llvm-project/commit/1f12718ccfd660f01ac0e444d4632cf8ce6b98e2 DIFF: https://github.com/llvm/llvm-project/commit/1f12718ccfd660f01ac0e444d4632cf8ce6b98e2.diff

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

steplong updated this revision to Diff 430994. steplong added a comment. The assembly for LLVM is now: __readx18byte: ldrbw0, [x18, w0, uxtw] __readx18word: ldrhw0, [x18, w0, uxtw] __readx18dword: ldr w0, [x18, w0, uxtw] __readx18qword: ldr

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if (PR->isMessagingSetter()) { dgoldman wrote:

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 430991. pratlucas marked 2 inline comments as done. pratlucas added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files:

[PATCH] D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.

balazske updated this revision to Diff 430990. balazske added a comment. Use of addDeclToContexts, added new test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125986/new/ https://reviews.llvm.org/D125986 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked 4 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:1844 +for (const auto : MBB) + if (MI.getOpcode() == ARM::tSTRspi || MI.getOpcode() == ARM::tSTRi) +for (const auto :

[PATCH] D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.

balazske added a reviewer: martong. balazske added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/lib/AST/ASTImporter.cpp:4861 + ToUsingPack->setLexicalDeclContext(LexicalDC); + LexicalDC->addDeclInternal(ToUsingPack); + martong wrote:

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG322e2a3b40fa: [clangd][ObjC] Filter ObjC method completions on the remaining selector (authored by dgoldman). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 322e2a3 - [clangd][ObjC] Filter ObjC method completions on the remaining selector

Author: David Goldman Date: 2022-05-20T11:49:16-04:00 New Revision: 322e2a3b40fa5f6bfcb868e827960c812b185710 URL: https://github.com/llvm/llvm-project/commit/322e2a3b40fa5f6bfcb868e827960c812b185710 DIFF: https://github.com/llvm/llvm-project/commit/322e2a3b40fa5f6bfcb868e827960c812b185710.diff

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

ilya-biryukov added a comment. In D125773#3525215 , @tahonermann wrote: >> So the proposal is that -fheader-modules=parse would parse #include of >> header unit in the same TU, and import .pcm on import, right? > > Per cpp.includep7

[PATCH] D107082: [X86][RFC][WIP] Enable `_Float16` type support on X86 following the psABI

pengfei updated this revision to Diff 430985. pengfei retitled this revision from "[X86][RFC] Enable `_Float16` type support on X86 following the psABI" to "[X86][RFC][WIP] Enable `_Float16` type support on X86 following the psABI". pengfei added a comment. Fix a few minor issues. I think it's

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong updated this revision to Diff 430979. steplong added a comment. The assembly for LLVM now looks like: __writex18byte: strbw1, [x18, w0, uxtw] ret __writex18word: strhw1, [x18, w0, uxtw]

[PATCH] D126067: [analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal updated this revision to Diff 430978. steakhal added a comment. Mention this removal in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126067/new/ https://reviews.llvm.org/D126067 Files:

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

dgoldman updated this revision to Diff 430974. dgoldman marked an inline comment as done. dgoldman added a comment. Go through chunks in getName and add missed FilterText place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124637/new/

[PATCH] D126065: [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedc7a0814575: [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs (authored by sammccall). Changed prior to commit:

[clang-tools-extra] edc7a08 - [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs

Author: Sam McCall Date: 2022-05-20T16:33:48+02:00 New Revision: edc7a0814575002abecb8ac7b49c669bf5f5ab7a URL: https://github.com/llvm/llvm-project/commit/edc7a0814575002abecb8ac7b49c669bf5f5ab7a DIFF: https://github.com/llvm/llvm-project/commit/edc7a0814575002abecb8ac7b49c669bf5f5ab7a.diff

[PATCH] D126068: [llvm][clang][bolt][NFC] Use llvm::less_first() when applicable

steakhal created this revision. steakhal added reviewers: aaron.ballman, lattner. Herald added subscribers: ayermolo, jdoerfert, martong, mgrang, hiraditya. Herald added a reviewer: JDevlieghere. Herald added a reviewer: jhenderson. Herald added a reviewer: Szelethus. Herald added a reviewer:

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

xazax.hun added a comment. In D125931#3527584 , @ymandel wrote: > 1. In this patch, we go with a widening operation, but put the relevant logic > in the core, so it can be reused for booleans in general. Depending on how much simplicity are we willing

[PATCH] D126067: [analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

martong added a comment. Uhh, ohh, don't forget to reflect this change in the ReleaseNotes.rst, so urers will be notified! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126067/new/ https://reviews.llvm.org/D126067

[PATCH] D126067: [analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. > However, this arises a couple of burning questions. > > Should the cc1 frontend still accept this flag - to keep tools/users passing > this flag directly to cc1 (which is unsupported,

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield added a comment. If it was adding a calling convention, sure - caution warranted. There's no llvm change here though, an existing CC is exposed to C++. No change to the type system either. I'll propose a patch with some documentation for it if you wish, but it'll just say "For

[PATCH] D125749: [analyzer][NFC] Introduce SVal::isa

steakhal added a comment. There is one minor problem with this patch. At `SVal` member function's context one needs to call `llvm::isa<...>()` with by the qualified name, otherwise, the `isa` is ambiguous. The compiler won't know if we want to refer to the free-function or the variadic member

[PATCH] D125961: [clang-format] Don't break lines after pragma region

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG749fb33e82ff: [clang-format] Dont break lines after pragma region (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 749fb33 - [clang-format] Don't break lines after pragma region

Author: Tobias Hieta Date: 2022-05-20T16:11:20+02:00 New Revision: 749fb33e82ff19d656af9c9205f3ac81c1ce52d8 URL: https://github.com/llvm/llvm-project/commit/749fb33e82ff19d656af9c9205f3ac81c1ce52d8 DIFF: https://github.com/llvm/llvm-project/commit/749fb33e82ff19d656af9c9205f3ac81c1ce52d8.diff

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

steakhal marked an inline comment as done. steakhal added a comment. WDYT, are there any blocker issues with this patch stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125209/new/ https://reviews.llvm.org/D125209

[PATCH] D125920: [analyzer][NFC] Remove the unused LocAsInteger::getPersistentLoc()

This revision was automatically updated to reflect the committed changes. Closed by commit rG5450db5f54b8: [analyzer][NFC] Remove the unused LocAsInteger::getPersistentLoc() (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5450db5 - [analyzer][NFC] Remove the unused LocAsInteger::getPersistentLoc()

Author: Balazs Benics Date: 2022-05-20T16:06:46+02:00 New Revision: 5450db5f54b86f908ce67cb681fbdf86b88abc54 URL: https://github.com/llvm/llvm-project/commit/5450db5f54b86f908ce67cb681fbdf86b88abc54 DIFF: https://github.com/llvm/llvm-project/commit/5450db5f54b86f908ce67cb681fbdf86b88abc54.diff

[PATCH] D125920: [analyzer][NFC] Remove the unused LocAsInteger::getPersistentLoc()

steakhal added a comment. In D125920#3524586 , @martong wrote: > LGTM. Are there any other `getPersistentLoc` function definitions in other > SVals? Might they be also unused? IDK, might be. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125893/new/ https://reviews.llvm.org/D125893

[PATCH] D126067: [analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus. Herald added subscribers: carlosgalvezp, manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

aaron.ballman added a comment. In D125970#3527624 , @aaron.ballman wrote: >> The primary application is for more rapid debugging of the amdgpu backend by >> permuting a C or C++ test file instead of manually updating an IR file. > > Given that this is

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

aaron.ballman added a comment. > The primary application is for more rapid debugging of the amdgpu backend by > permuting a C or C++ test file instead of manually updating an IR file. Given that this is adding a calling convention, which has significant impacts on our type system: is this use

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")

[PATCH] D126066: [clang] Don't plumb access specifier attributes through Parser unnecessarily.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. I noticed that a lot of functions in the parser take an `AccessAttrs`

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGae80024fbe51: [clang] Honor __attribute__((no_builtin(foo))) on functions (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124701/new/

[clang] ae80024 - [clang] Honor __attribute__((no_builtin("foo"))) on functions

Author: Stephen Long Date: 2022-05-20T06:41:47-07:00 New Revision: ae80024fbe51339afabfa2ff43ae532356fa3c93 URL: https://github.com/llvm/llvm-project/commit/ae80024fbe51339afabfa2ff43ae532356fa3c93 DIFF: https://github.com/llvm/llvm-project/commit/ae80024fbe51339afabfa2ff43ae532356fa3c93.diff

  1   2   >