[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson updated this revision to Diff 431589. royjacobson added a comment. Update the approach to use an AST property, and enable this for all language variants (not just CPP20). There's still one test failing because OpenCL have got their own destructor thing going, I'll try to see what I

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev added reviewers: rsmith, vsapsai. v.g.vassilev added a comment. Just to add that the `invalidateCache` is important for cling and clang-repl where we do something like: clang-repl> #include "file_with_error.h" // error is printed, we

[PATCH] D126247: `readability-indentifier-naming` resolution order and examples

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst:2742 double dValueDouble = 0.0; ULONGulValueUlong = 0; Phabricator says there is no context available. Did you

[PATCH] D126246: bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

usama54321 created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. This revision was not accepted when it landed; it landed in state "Draft". This revision was automatically updated to reflect the committed changes. Closed by commit rG63ecb7dcc80d: bugfix in

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

This revision was automatically updated to reflect the committed changes. usama54321 marked an inline comment as done. Closed by commit rG602682225ad6: bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops (authored by usama54321). Changed prior to commit:

[clang] ca81abc - updated canResolveToExpr to accept both statements and expressions. Removed unnecessary code

Author: usama hameed Date: 2022-05-23T20:18:49-07:00 New Revision: ca81abcfd752e65c533825a5fadac19ce5a33578 URL: https://github.com/llvm/llvm-project/commit/ca81abcfd752e65c533825a5fadac19ce5a33578 DIFF: https://github.com/llvm/llvm-project/commit/ca81abcfd752e65c533825a5fadac19ce5a33578.diff

[clang] 63ecb7d - bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

Author: usama hameed Date: 2022-05-23T20:18:49-07:00 New Revision: 63ecb7dcc80d17770461c8bf01bddeb2b795625b URL: https://github.com/llvm/llvm-project/commit/63ecb7dcc80d17770461c8bf01bddeb2b795625b DIFF: https://github.com/llvm/llvm-project/commit/63ecb7dcc80d17770461c8bf01bddeb2b795625b.diff

[clang] 6026822 - bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

Author: usama hameed Date: 2022-05-23T20:18:48-07:00 New Revision: 602682225ad6c9135e84bbca3b91d5738712c64f URL: https://github.com/llvm/llvm-project/commit/602682225ad6c9135e84bbca3b91d5738712c64f DIFF: https://github.com/llvm/llvm-project/commit/602682225ad6c9135e84bbca3b91d5738712c64f.diff

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 431565. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld

[PATCH] D126187: [C++20] [Coroutines] Conform the updates for CWG issue 2585

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1293 // that just takes the requested size. - - FunctionDecl *OperatorNew = nullptr; - FunctionDecl *OperatorDelete = nullptr; - FunctionDecl *UnusedResult = nullptr; - bool PassAlignment =

[PATCH] D126187: [C++20] [Coroutines] Conform the updates for CWG issue 2585

ChuanqiXu updated this revision to Diff 431558. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126187/new/ https://reviews.llvm.org/D126187 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

rprichard added subscribers: craig.topper, rprichard. rprichard added a comment. Herald added a project: All. Maybe this change is obsolete now that D59566 is merged? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D29542/new/

[PATCH] D126132: [clang-format] Fix a crash on lambda trailing return type

owenpan added a comment. @HazardyKnusperkeks I think you know this better than any of us as you added the assertion to `setType()`. Does this look ok to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126132/new/

[PATCH] D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

cishida updated this revision to Diff 431543. cishida added a comment. Restrict using the canonical decl's source location to only when the prototype was inferred from previously seen decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126258/new/

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

NoQ accepted this revision. NoQ added a comment. Whoops, no, this isn't an actual concern. Looks good then, please commit! Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:234-236 +bool ExprMutationAnalyzer::isUnevaluated(const Expr *Exp) { + return isUnevaluated(Exp,

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:827 +def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, + HelpText<"Pass to the offload linker identified by ">, + MetaVarName<" ">,

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Couple of nits. LGTM otherwise. Comment at: clang/include/clang/Driver/Options.td:827 +def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, + HelpText<"Pass to the

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

NoQ added inline comments. Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:234-236 +bool ExprMutationAnalyzer::isUnevaluated(const Expr *Exp) { + return isUnevaluated(Exp, Stm, Context); +} Shouldn't this one be removed now? Repository: rG LLVM

[PATCH] D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

cishida created this revision. cishida added reviewers: jyknight, aaron.ballman. Herald added a subscriber: ributzka. Herald added a project: All. cishida requested review of this revision. Herald added a project: clang. Clang has recently started diagnosing prototype redeclaration errors like

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123319/new/ https://reviews.llvm.org/D123319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

usama54321 updated this revision to Diff 431516. usama54321 added a comment. - updated canResolveToExpr to accept both statements and expressions. Removed unnecessary code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126034/new/

[PATCH] D126224: Add DWARF string debug to clang release notes.

dblaikie added a comment. In D126224#3531949 , @rnk wrote: > I am reminded of the perennial problem of "optional" protobuf fields that, > when omitted, will cause production crashes. > > Do you think it would be less disruptive to synthesize a name? I

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 updated this revision to Diff 431511. jhuber6 added a comment. Merging into a single argument and checking if the joined arg is empty. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126226/new/ https://reviews.llvm.org/D126226 Files:

[clang] 4f89ff3 - [test][clang] Move -O3 in command line

Author: Vitaly Buka Date: 2022-05-23T15:57:14-07:00 New Revision: 4f89ff3fc71b0b2adfeb74b900e9a2a90ef80174 URL: https://github.com/llvm/llvm-project/commit/4f89ff3fc71b0b2adfeb74b900e9a2a90ef80174 DIFF: https://github.com/llvm/llvm-project/commit/4f89ff3fc71b0b2adfeb74b900e9a2a90ef80174.diff

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 431508. hctim added a comment. Add an extra Global creation path from the frontend, and fix up a comment from Kirill on the other revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman updated this revision to Diff 431506. arphaman added a comment. Herald added a project: clang. Fix the windows test failure (add -fno-delayed-template-parsing) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:826 Group; +def Xoffload_linker : Separate<["-"], "Xoffload-linker">, + HelpText<"Pass to the offload linker">, MetaVarName<"">, tra wrote: > This option still stands out as a

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

hctim planned changes to this revision. hctim added a comment. Pulled out the IR-specific changes to D126100 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:826 Group; +def Xoffload_linker : Separate<["-"], "Xoffload-linker">, + HelpText<"Pass to the offload linker">, MetaVarName<"">, This option still stands out as a sore thumb.

[PATCH] D126247: `readability-indentifier-naming` resolution order and examples

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst:2747 +Resolution order +--- + Please make length same as title. Comment at:

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay added a comment. Because of `TargetTriple.getOS() == llvm::Triple::Linux`, you need to guard the unittest under a similar check. > Harbormaster completed remote builds in `B165047: Diff 430277.` You can get Windows bot results in the link. Repository: rG LLVM Github Monorepo

[PATCH] D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/

owenpan added a comment. In D126157#3531635 , @MyDeveloperDay wrote: > LGTM too.. @owenpan this is one of my favourite features!! I love it too! :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ExprMutationAnalyzer.h:43-44 +ASTContext ); + static bool isUnevaluated(const Expr *Exp, const Stmt , +ASTContext ); I suspect

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. Yes, I'm going to check what's wrong with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126247: `readability-indentifier-naming` resolution order and examples

KazNX created this revision. KazNX added reviewers: whisperity, clang-tools-extra. KazNX added a project: clang-tools-extra. Herald added a subscriber: rnkovacs. Herald added a project: All. KazNX requested review of this revision. Herald added a subscriber: cfe-commits. Added extensive

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

tra added a comment. In D125904#3532545 , @jhuber6 wrote: > clang a.c -c -o a-0.o // Has some externalized static variable. > clang a.c -c -o a-1.o > clang a-0.o a-1.o // Redefined symbol error Ah. OK. This is a bit less of a concern. As long as we take

[PATCH] D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2769 - if (Style.isCSharp()) { do { curdeius wrote: > owenpan wrote: > > From > >

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

usama54321 updated this revision to Diff 431497. usama54321 added a comment. Updating patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126034/new/ https://reviews.llvm.org/D126034 Files:

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

rsmith added a comment. In D125773#3525127 , @ilya-biryukov wrote: > It looks like this particular change actually breaks standard compatibility > as we also use the same parsing action and don't build a module separately on > `import`. > >

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 updated this revision to Diff 431491. jhuber6 added a comment. Go back to old joined method and also change the name to remote `_EQ`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126226/new/ https://reviews.llvm.org/D126226 Files:

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

usama54321 updated this revision to Diff 431490. usama54321 added a comment. Added a separate check for unevaluated statements. Updated InfiniteLoopCheck to use new check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126034/new/

[PATCH] D125848: [clang-format] Handle attributes in enum declaration.

tchatow updated this revision to Diff 431489. tchatow added a comment. Added tests for non-empty enums Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125848/new/ https://reviews.llvm.org/D125848 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D126245: Added a separate check for unevaluated statements. Updated InfiniteLoopCheck to use new check

usama54321 created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. usama54321 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123286/new/ https://reviews.llvm.org/D123286 ___ cfe-commits mailing

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Parse/ParseOpenMP.cpp:3692-3694 + if (Kind == llvm::omp::Clause::OMPC_fail) { +Clause = ParseOpenMPFailClause(Clause); + }

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added a comment. In D125904#3532492 , @tra wrote: > This is a moderately serious issue. Some users care about the build > reproducibility. Recompiling the same sources and getting different results > will trigger all sorts of red flags that

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

MaskRay added a comment. In D126226#3532423 , @tra wrote: > In D126226#3532257 , @MaskRay wrote: > >> It's better to avoid `JoinedAndSeparate` for new options. It is for `--xxx >> val` and `--xxxval` but not

[PATCH] D126224: Add DWARF string debug to clang release notes.

probinson added a comment. Unnamed variables are an oddity, sure; we've had to patch a downstream test or two that wasn't being careful enough. But not providing a name is entirely defensible, and consumers should be willing to cope with DWARF that doesn't fully meet their expectations.

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

tra added a comment. In D126226#3532471 , @jhuber6 wrote: > In D126226#3532423 , @tra wrote: > >> We keep running into the same old underlying issue that we do not have a >> good way to name/reference specific

[PATCH] D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2769 - if (Style.isCSharp()) { do { owenpan wrote: > From >

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

tra added a comment. > The one downside to this is that we are no longer stable under multiple > compilations of the same file. This is a moderately serious issue. Some users care about the build reproducibility. Recompiling the same sources and getting different results will trigger all

[PATCH] D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2769 - if (Style.isCSharp()) { do { From https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements, it's

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 added a comment. In D126226#3532423 , @tra wrote: > We keep running into the same old underlying issue that we do not have a good > way to name/reference specific parts of the compilation pipeline. -Xfoo used > to work OK for the linear

[PATCH] D126132: [clang-format] Fix a crash on lambda trailing return type

owenpan added a comment. In D126132#3531643 , @MyDeveloperDay wrote: > LGTM (sorry I've been slow on the reviews, my day job keeps getting in the > way ;-)) Np! It's really that @curdeius and @HazardyKnusperkeks are fast. :)

[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

MichielDerhaeg marked an inline comment as done. MichielDerhaeg added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4760-4762 // reject options that shouldn't be supported in bitcode // also reject kernel/kext static const constexpr unsigned

[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

MichielDerhaeg updated this revision to Diff 431479. MichielDerhaeg added a comment. Herald added a reviewer: alexander-shaposhnikov. - Render options for other platforms and test - comment and propagate list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [clang] 7aa1fa0 - Reland "[dwarf] Emit a DIGlobalVariable for constant strings."

(when recommitting a patch it can be helpful to mention the revisions of the previous commit/revert, the reason for the revert and what's different in this version of the patch that addresses that issue (or how was the issue otherwise addressed)) On Wed, May 18, 2022 at 1:59 PM Mitch Phillips via

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

tra added a comment. In D126226#3532257 , @MaskRay wrote: > It's better to avoid `JoinedAndSeparate` for new options. It is for `--xxx > val` and `--xxxval` but not intended for the option this patch will add. I'm not sure I understand your argument.

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 updated this revision to Diff 431475. jhuber6 added a comment. Updating to use @MaskRay's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126226/new/ https://reviews.llvm.org/D126226 Files:

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcead4eceb01b: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals (authored by hctim). Repository: rG LLVM Github Monorepo

[PATCH] D126224: Add DWARF string debug to clang release notes.

paulkirth added a comment. I'm going to try to summarize an offline discussion w/ @mcgrathr about this here: There are some other considerations to think about w.r.t. emitting names for non-source language constructs, as would be the case here. In fact, DWARF already handles this case: the

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

MaskRay added a comment. IIRC there is no built-in way supporting multiple (but fixed number of) values for an option (e.g. `-Xoffload-linker- `). In D105330 (llvm-nm option refactoring) I used a hack to support `-s __DATA __data`. The multiple-value support

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 431463. hctim marked 4 inline comments as done. hctim added a comment. David's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/ https://reviews.llvm.org/D123538 Files:

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 added a comment. In D126226#3532257 , @MaskRay wrote: > It's better to avoid `JoinedAndSeparate` for new options. It is for `--xxx > val` and `--xxxval` but not intended for the option this patch will add. So how should I pass these two

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. It's better to avoid `JoinedAndSeparate` for new options. It is for `--xxx val` and `--xxxval` but not intended for the option this patch

[clang] 217531f - [PS5] Make driver's PIC behavior match PS4

Author: Paul Robinson Date: 2022-05-23T12:50:22-07:00 New Revision: 217531f12b4b97dadb80c66ab97c71e57ae0adcf URL: https://github.com/llvm/llvm-project/commit/217531f12b4b97dadb80c66ab97c71e57ae0adcf DIFF: https://github.com/llvm/llvm-project/commit/217531f12b4b97dadb80c66ab97c71e57ae0adcf.diff

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 updated this revision to Diff 431452. jhuber6 added a comment. Changing the `-Xoffload-linker=` to `-Xoffload-linker-`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126226/new/ https://reviews.llvm.org/D126226 Files:

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 added a comment. In D126226#3532216 , @tra wrote: > You do not need to hardcode it. The idea of `JoinedAndSeparate` is that an > option `foo` assepts two argumants, one glued to it and another following > after a whitespace. > So, when you

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 updated this revision to Diff 431451. roberteg16 added a comment. Fix wrongly moved clang-format disabling comment when trying to fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

tra added a comment. In D126226#3532147 , @jhuber6 wrote: > We already use this approach for the `-Xopenmp-target= ` option > that forwards arguments to the given toolchain, so that's what I was using as > a basis. Yup. I've noticed that. It's

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 added a comment. In D126226#3532127 , @tra wrote: > `-Xoffload-linker= ` > > The syntax is confusing. Normally only `triple` would be the argument for > `-Xoffload-linker` option. > Having both `-Xoffload-linker` and `-Xoffload-linker=`

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

tra added a comment. `-Xoffload-linker= ` The syntax is confusing. Normally only `triple` would be the argument for `-Xoffload-linker` option. Having both `-Xoffload-linker` and `-Xoffload-linker=` variants also looks odd to me. In effect you're making `-Xoffload-linker=foo` a full option

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal planned changes to this revision. steakhal added a comment. In D126215#3531780 , @martong wrote: >> We should support deprecated analyzer flags for at least one release. In >> this case I'm planning to drop this flag in clang-17 > > Should we

[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi abandoned this revision. akyrtzi added a comment. This has been superseded by the above set of patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124687/new/ https://reviews.llvm.org/D124687

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

markdewing accepted this revision. markdewing added a comment. This revision is now accepted and ready to land. Works for passing libraries to nvlink. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126226/new/ https://reviews.llvm.org/D126226

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

nickdesaulniers added a comment. In D126137#3530777 , @kristof.beyls wrote: > Therefore, I wonder if it wouldn't be better to name this -mharden-sls=retbr > for more consistency across architectures? I think it's best to maintain compatibility with

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

nickdesaulniers added a comment. Thanks for the patch! > A tangential question is do we need these two options expect all? For the Linux kernel's use, no. But I think it would extremely simple to implement. Instead of having one `SubtargetFeature` (`FeatureHardenSlsAll`), you'd have two (say

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi marked an inline comment as done. akyrtzi added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesScanner.cpp:153 + + SmallVector CurDirToks; + SmallVector DirsWithToks; jansvoboda11 wrote: > Can you add a comment explaining the

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f1e64b54f59: [MSVC, ARM64] Add __readx18 intrinsics (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126024/new/

[clang] 4f1e64b - [MSVC, ARM64] Add __readx18 intrinsics

Author: Stephen Long Date: 2022-05-23T10:59:12-07:00 New Revision: 4f1e64b54f59dd4c303d04b62926f35bde5a2c79 URL: https://github.com/llvm/llvm-project/commit/4f1e64b54f59dd4c303d04b62926f35bde5a2c79 DIFF: https://github.com/llvm/llvm-project/commit/4f1e64b54f59dd4c303d04b62926f35bde5a2c79.diff

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi updated this revision to Diff 431429. akyrtzi marked an inline comment as done. akyrtzi added a comment. Add documentation comments for a couple of fields of `Scanner` in `DependencyDirectivesScanner.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125555: [clang] Add __has_target_feature

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:260 +``__has_target_feature`` + yaxunl wrote: > aaron.ballman wrote: > > The first question that comes to mind for me is: why is `__has_feature` not > >

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank updated this revision to Diff 431426. nicovank added a comment. Fix formatting issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101471/new/ https://reviews.llvm.org/D101471 Files:

[PATCH] D126224: Add DWARF string debug to clang release notes.

paulkirth added a subscriber: mcgrathr. paulkirth added a comment. @rnk the standard even has an example of this exact behavior, so I think it's hard to say its //wrong// for LLVM to do this, but that may be more gentle. I'm going to defer to more expert opinions here, however, and loop in

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

jhuber6 created this revision. jhuber6 added reviewers: markdewing, jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added

[clang] dbd1ba2 - [PS5] Disable a test, same as PS4

Author: Paul Robinson Date: 2022-05-23T10:43:26-07:00 New Revision: dbd1ba28a3a435c87eb2a977028ea22e9aabf148 URL: https://github.com/llvm/llvm-project/commit/dbd1ba28a3a435c87eb2a977028ea22e9aabf148 DIFF: https://github.com/llvm/llvm-project/commit/dbd1ba28a3a435c87eb2a977028ea22e9aabf148.diff

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

aaron.ballman added a comment. In D125970#3531673 , @JonChesterfield wrote: > In D125970#3531645 , @aaron.ballman > wrote: > >> In D125970#3527685 , >>

[PATCH] D126224: Add DWARF string debug to clang release notes.

rnk added a comment. I am reminded of the perennial problem of "optional" protobuf fields that, when omitted, will cause production crashes. Do you think it would be less disruptive to synthesize a name? I believe the string lives in a string pool, so naming all string literals `` seems like

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim created this revision. hctim added reviewers: paulkirth, dblaikie. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D12353 added inline strings to the DWARF info

[PATCH] D126223: [Clang][Sema] Fix a SemaType/VisitTagTypeLoc assertion

yonghong-song created this revision. yonghong-song added reviewers: compnerd, aaron.ballman. Herald added a project: All. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Patch [1] added btf_type_tag attribute support. In

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 updated this revision to Diff 431416. roberteg16 added a comment. Fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172 Files: clang/lib/AST/TemplateBase.cpp

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added a comment. In D125272#3515874 , @heatd wrote: > In D125272#3504113 , @heatd wrote: > >> Adjusted the driver code to use addOptInFlag, adjusted the test, fixed the >> comment. > > Ping. Ping.

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

martong added a comment. > We should support deprecated analyzer flags for at least one release. In this > case I'm planning to drop this flag in clang-17 Should we emit a warning for the user about the deprecation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126216: [analyzer][NFC] Remove unused RegionStoreFeatures

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126216/new/ https://reviews.llvm.org/D126216

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

koops added a comment. In D123286#3527374 , @koops wrote: > In D123286#3513797 , > @tianshilei1992 wrote: > >> Can we have test for right usage? > > I do not understand "test for right usage". From the

[PATCH] D126216: [analyzer][NFC] Remove unused RegionStoreFeatures

steakhal created this revision. steakhal added reviewers: NoQ, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal created this revision. steakhal added reviewers: NoQ, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added inline comments. Comment at: clang/docs/ReleaseNotes.rst:239-243 +- GCC doesn't pack non-POD members in packed structs unless the packed + attribute is also specified on the member. Clang historically did perform + such packing. Clang now matches the gcc

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield added a comment. In D125970#3531645 , @aaron.ballman wrote: > In D125970#3527685 , > @JonChesterfield wrote: > >> If it was adding a calling convention, sure - caution warranted. There's no >>

[PATCH] D125848: [clang-format] Handle attributes in enum declaration.

curdeius added a comment. Could you please add test cases with non-empty enums both with and without comments please like in the bug report? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125848/new/ https://reviews.llvm.org/D125848

  1   2   >