[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3d3e2528e60: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer` (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d3d3e25 - [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

Author: Yuki Okushi Date: 2022-05-28T14:58:04+09:00 New Revision: d3d3e2528e60c93000c6d7f90053d1672cc7b47d URL: https://github.com/llvm/llvm-project/commit/d3d3e2528e60c93000c6d7f90053d1672cc7b47d DIFF: https://github.com/llvm/llvm-project/commit/d3d3e2528e60c93000c6d7f90053d1672cc7b47d.diff

[PATCH] D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:371 +- Support ``-mharden-sls=all`` for X86. + MaskRay wrote: > nickdesaulniers wrote: > > pengfei wrote: > > > nickdesaulniers wrote: > > > > This should be updated if additional options

[clang] 3b45000 - [Driver] Replace err_invalid_branch_protection with err_drv_unsupported_option_argument

Author: Fangrui Song Date: 2022-05-27T22:28:39-07:00 New Revision: 3b4500014a481f0de300f42e1e59a8137d136ed1 URL: https://github.com/llvm/llvm-project/commit/3b4500014a481f0de300f42e1e59a8137d136ed1 DIFF: https://github.com/llvm/llvm-project/commit/3b4500014a481f0de300f42e1e59a8137d136ed1.diff

[PATCH] D126511: [ARM][AArch64] Change -mharden-sls= to use err_drv_unsupported_option_argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG068b8af7961c: [ARM][AArch64] Change -mharden-sls= to use err_drv_unsupported_option_argument (authored by MaskRay). Repository: rG LLVM Github

[clang] 068b8af - [ARM][AArch64] Change -mharden-sls= to use err_drv_unsupported_option_argument

Author: Fangrui Song Date: 2022-05-27T22:03:48-07:00 New Revision: 068b8af7961caafadeffd1a99a103ef1d7a36e21 URL: https://github.com/llvm/llvm-project/commit/068b8af7961caafadeffd1a99a103ef1d7a36e21 DIFF: https://github.com/llvm/llvm-project/commit/068b8af7961caafadeffd1a99a103ef1d7a36e21.diff

[PATCH] D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`

pengfei updated this revision to Diff 432692. pengfei added a comment. 1. Revert the change to clang/docs/ClangCommandLineReference.rst 2. Update missing options 3. Rebase on D126511 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

JamesNagurne added a comment. In D121838#3543421 , @JamesNagurne wrote: > After some investigation, I found that we did not set LLVM_INCLUDE_TESTS from > the top-level project. This seems like an oversight because we build the > test-depends (and

[PATCH] D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. OK, fair enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126566/new/ https://reviews.llvm.org/D126566

[PATCH] D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

vsapsai added a comment. For the record, `FunctionTemplate` case was added in https://reviews.llvm.org/rG9359e8f22a5403ad9524a92c4ccab4db46c9c100 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126566/new/ https://reviews.llvm.org/D126566

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood updated this revision to Diff 432676. LegalizeAdulthood added a comment. - Add C++ test case for acceptable `operator,` initializer CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125622/new/ https://reviews.llvm.org/D125622 Files:

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood marked 5 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:324 { - IntegralLiteralExpressionMatcher Matcher(MacroTokens); - return Matcher.match(); +

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood updated this revision to Diff 432675. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. - Update from review comments - Disallow operator, unless inside parentheses CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125622/new/

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. all stuff under llvm/... here needs testing, Bitcode and AsmParser have many tests usable as examples Also probably better to separate from clang changes: Patch 1: extends

[PATCH] D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

vsapsai added a comment. To trigger "function template|different function template" diagnostic we need the entire "case FunctionTemplate" in "switch (FirstDiffType)"

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

wanders updated this revision to Diff 432669. wanders added a comment. Diff updated with release note + updated text in documentation as per jyknight's suggestion. Tests for existing behavior added in separate patch: https://reviews.llvm.org/D126578 Repository: rG LLVM Github Monorepo

[PATCH] D126578: [clang] Add tests for (const) weak variables

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds tests checking the behavior of const variables declared with weak

[PATCH] D126547: [OpenACC][OpenMP] Document atomic-in-teams extension

jdenny added a comment. Thanks for the quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126547/new/ https://reviews.llvm.org/D126547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126547: [OpenACC][OpenMP] Document atomic-in-teams extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a368136693b: [OpenACC][OpenMP] Document atomic-in-teams extension (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126547/new/

[clang] 4a36813 - [OpenACC][OpenMP] Document atomic-in-teams extension

Author: Joel E. Denny Date: 2022-05-27T18:53:19-04:00 New Revision: 4a368136693ba9c4e827702e9d390280c3d5e7ac URL: https://github.com/llvm/llvm-project/commit/4a368136693ba9c4e827702e9d390280c3d5e7ac DIFF: https://github.com/llvm/llvm-project/commit/4a368136693ba9c4e827702e9d390280c3d5e7ac.diff

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

JamesNagurne added a comment. After some investigation, I found that we did not set LLVM_INCLUDE_TESTS from the top-level project. This seems like an oversight because we build the test-depends (and check-all) regularly. After seeing LLVM_INCLUDE_TESTS to ON, the builds worked. This commit

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

JamesNagurne added a comment. Hi Sam, I've got a downstream build system that is failing here and I'm trying to figure out why. After your commit, I get an error during bootstrapped runtime builds: 05-27 14:41 __main__ INFO [202/796] cd

Re: Call for an assistance pushing patch review forward

Hi Paul, Thank you for the tips. Pinging is indeed mentioned in the docs, but I didn't want to piss everyone off, so after two pings I thought that I'm doing something wrong. From now on I'll ping once a week in such situations. Got review comments now, so we're back on track. Gonna implement

[PATCH] D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

rsmith added a comment. We perhaps can't or don't want to add test coverage for the "unexpected decl" case here. Can we add coverage for the "function template" case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126566/new/

[PATCH] D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

vsapsai added a comment. We emit `err_module_odr_violation_mismatch_decl_unknown` at https://github.com/llvm/llvm-project/blob/0fbe3f3f486e01448121f7931a4ca29fac1504ab/clang/lib/Serialization/ASTReader.cpp#L11143-L11150 `ODRMismatchDecl` is defined at

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:563 + } else if (IsInstantiation || getContext().GetGVALinkageForVariable(D) == GVA_DiscardableODR || D->hasAttr()) { rnk wrote: > rsmith wrote: > > rnk wrote:

[PATCH] D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

vsapsai created this revision. vsapsai added a reviewer: rtrieu. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. No test changes because `err_module_odr_violation_mismatch_decl_unknown` is a catch-all when

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne updated this revision to Diff 432634. ldionne added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125683/new/ https://reviews.llvm.org/D125683 Files: clang/cmake/caches/Android.cmake

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")

[PATCH] D125695: [clang][DebugInfo] Allow function-local type-like entities to be scoped within a lexical block (5/5)

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:231-234 + assert(LexicalBlockMap.find() == LexicalBlockMap.end() && + "D is already mapped to a lexical block scope"); + if (!LexicalBlockStack.empty()) +LexicalBlockMap.insert({,

[PATCH] D126412: Fix a buglet in remove_dots().

ppluzhnikov created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. ppluzhnikov updated this revision to Diff 432324. ppluzhnikov added a comment. ppluzhnikov updated this revision to Diff 432461. ppluzhnikov updated this revision to Diff 432551. ppluzhnikov

[PATCH] D126068: [llvm][clang][bolt][NFC] Use llvm::less_first() when applicable

lattner added a comment. This patch LGTM other than the apparent build breakage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126068/new/ https://reviews.llvm.org/D126068 ___ cfe-commits mailing list

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() ||

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() ||

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

efriedma added inline comments. Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:732 + // AAPCS requires use of R11, and PACBTI gets in the way of regular pushes, + // so FP ends up on area two. if (HasFP) { I guess this is related to this patch because

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code

martong created this revision. martong added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Haven't had a chance to try it yet, but based on a quick glance, my suspicion is that the problem is the use of `ReferenceType::getPointeeType()`, which may do more unwrapping than we want (its implementation contains a loop

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 432606. python3kgae marked 2 inline comments as done. python3kgae added a comment. Use default value of MarshallingInfoString. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126559/new/ https://reviews.llvm.org/D126559 ___

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

efriedma added a comment. ldr+op+swp still isn't atomic. For each point in the code, please try the exercise of "what if my code is interrupted here"? The only way to use swp to implement general atomic operations is to use a separate spinlock. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

ASDenysPetrov added a comment. @martong As you said, my solution D103096 suppose to pass these and more other tests cases. So how it will help in combination with my solution D103096 ? Although, your patch is really simple

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. I mean that ActOnPragmaFEnvAccess shouldn't call hasRoundingModeOverride()/setRoundingModeOverride(), and setRoundingMode shouldn't call getAllowFEnvAccess(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126364/new/

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:563 + } else if (IsInstantiation || getContext().GetGVALinkageForVariable(D) == GVA_DiscardableODR || D->hasAttr()) { rsmith wrote: > rnk wrote: > > @rsmith , if

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `isExternCContext()` is returning false for functions in C files Change-Id: I51cccb476aa19dc0a0a78e951d7f482befdb78ca

[PATCH] D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`

nickdesaulniers requested changes to this revision. nickdesaulniers added a subscriber: aaron.ballman. nickdesaulniers added a comment. This revision now requires changes to proceed. Let's get this rebased on top of D126511 . Comment at:

[libunwind] 719bf2d - [runtimes] Officially deprecate the legacy testing configuration system

Author: Louis Dionne Date: 2022-05-27T13:15:48-04:00 New Revision: 719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36 URL: https://github.com/llvm/llvm-project/commit/719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36 DIFF: https://github.com/llvm/llvm-project/commit/719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36.diff

[clang] 4dc3893 - Revert "[Clang] Extend -gen-reproducer flag"

Author: Alex Brachet Date: 2022-05-27T17:03:32Z New Revision: 4dc3893eeb47bef9298c34cdc993165af88721a5 URL: https://github.com/llvm/llvm-project/commit/4dc3893eeb47bef9298c34cdc993165af88721a5 DIFF: https://github.com/llvm/llvm-project/commit/4dc3893eeb47bef9298c34cdc993165af88721a5.diff LOG:

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

thakis added a comment. Looks like this breaks tests on (at least) Mac and window, see eg http://45.33.8.238/macm1/36198/step_7.txt (passes on my Linux bit though). Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf1ab1f0eb95: cmake: use llvm dir variables for clang/utils/hmaptool (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] bf1ab1f - cmake: use llvm dir variables for clang/utils/hmaptool

Author: Matheus Izvekov Date: 2022-05-27T18:44:58+02:00 New Revision: bf1ab1f0eb9578914343f48096229ecccd0ecf52 URL: https://github.com/llvm/llvm-project/commit/bf1ab1f0eb9578914343f48096229ecccd0ecf52 DIFF:

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong updated this revision to Diff 432588. martong marked 7 inline comments as done. martong added a comment. - Hoist S->getOperand, rework the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126481/new/ https://reviews.llvm.org/D126481

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1359 + return cache(S, + SVB.evalCast(Op, S->getType(), S->getOperand()->getType())); +} steakhal wrote: > Hoist this common subexpression.

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5596 + DefaultedSMFArePOD = false; + } + probinson wrote: > dblaikie wrote: > > probinson wrote: > > > dblaikie wrote: > > > > probinson wrote: > > > > > Does this mean

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rGe917801eddbe: [Clang][Driver] Fix include paths for `--sysroot /` on Linux (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e917801 - [Clang][Driver] Fix include paths for `--sysroot /` on Linux

Author: Egor Zhdan Date: 2022-05-27T16:51:36+01:00 New Revision: e917801eddbe1b32f1adc81391fd434557391b5e URL: https://github.com/llvm/llvm-project/commit/e917801eddbe1b32f1adc81391fd434557391b5e DIFF: https://github.com/llvm/llvm-project/commit/e917801eddbe1b32f1adc81391fd434557391b5e.diff

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

abrachet marked an inline comment as done. abrachet added inline comments. Comment at: clang/test/Driver/emit-reproducer.c:1 +// RUN: rm -rf %t; mkdir %t + hans wrote: > I'm not sure if lit handles that semicolon, or if it hands this over to the > shell, in

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG684c08010876: [Clang] Extend -gen-reproducer flag (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 684c080 - [Clang] Extend -gen-reproducer flag

Author: Alex Brachet Date: 2022-05-27T15:49:13Z New Revision: 684c080108766b4f112f172fed4a49059484614d URL: https://github.com/llvm/llvm-project/commit/684c080108766b4f112f172fed4a49059484614d DIFF: https://github.com/llvm/llvm-project/commit/684c080108766b4f112f172fed4a49059484614d.diff LOG:

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae updated this revision to Diff 432574. python3kgae added a comment. Add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052 Files: clang/include/clang/Driver/Options.td

[PATCH] D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend

tejohnson added inline comments. Herald added a subscriber: StephenFan. Comment at: lld/ELF/LTO.cpp:96 + c.PTO.LoopVectorization = c.OptLevel > 1; + c.PTO.SLPVectorization = c.OptLevel > 1; xbolva00 wrote: > COFF? This came up recently on discourse:

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, RaviNarayanaswamy. jdenny added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added a

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432568. egorzhdan marked an inline comment as done. egorzhdan added a comment. Rebase & fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/ https://reviews.llvm.org/D126289 Files:

[PATCH] D126547: [OpenACC][OpenMP] Document atomic-in-teams extension

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, clementval. jdenny added projects: OpenMP, OpenACC. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11721 + Diag(FD->getLocation(), diag::err_hlsl_missing_numthreads) << "Compute"; + FD->setInvalidDecl(); +} bruno wrote: >

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae updated this revision to Diff 432563. python3kgae added a comment. Add hlsl-entry for cc1 option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 Files: clang/include/clang/Basic/Attr.td

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource marked an inline comment as done. frederic-tingaud-sonarsource added a comment. Thanks for looking at the PR! In D126534#3542402 , @steakhal wrote: > You also mentioned this copy elision, but I don't see anywhere checks for

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource updated this revision to Diff 432558. frederic-tingaud-sonarsource added a comment. Document tests better CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126534/new/ https://reviews.llvm.org/D126534 Files:

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

steakhal added a comment. I haven't checked the implementation; the Deadstores checker was always a nemesis for me. Off the top of my head, I think in the analyzer we have the `elide-constructors=true/false` analyzer config option, which quotes: > Whether elidable C++ copy-constructors and

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 432553. maryammo added a comment. NFC update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource updated this revision to Diff 432552. frederic-tingaud-sonarsource added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126534/new/ https://reviews.llvm.org/D126534 Files: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal added a comment. A sanitizer buildbot caught a wrong annotation, fixed by e651ed8621c3719937517ddb0b0815b18ec888e4 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e651ed8 - [analyzer] Fix wrong annotation of LazyCompoundVal::getStore

Author: Balazs Benics Date: 2022-05-27T16:07:33+02:00 New Revision: e651ed8621c3719937517ddb0b0815b18ec888e4 URL: https://github.com/llvm/llvm-project/commit/e651ed8621c3719937517ddb0b0815b18ec888e4 DIFF: https://github.com/llvm/llvm-project/commit/e651ed8621c3719937517ddb0b0815b18ec888e4.diff

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is the last prerequisite to switch the default behaviour to

[PATCH] D126419: [clang][dataflow] Improve handling of constructor initializers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3682e22ef404: [clang][dataflow] Improve handling of constructor initializers. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[clang] 3682e22 - [clang][dataflow] Improve handling of constructor initializers.

Author: Yitzhak Mandelbaum Date: 2022-05-27T13:54:11Z New Revision: 3682e22ef404e1314ee1eab9daf6de99dc9ea8ee URL: https://github.com/llvm/llvm-project/commit/3682e22ef404e1314ee1eab9daf6de99dc9ea8ee DIFF: https://github.com/llvm/llvm-project/commit/3682e22ef404e1314ee1eab9daf6de99dc9ea8ee.diff

[clang] 67136d0 - [clang][dataflow] Remove private-field filtering from `StorageLocation` creation.

Author: Yitzhak Mandelbaum Date: 2022-05-27T13:39:53Z New Revision: 67136d0e8fb57251dece4be0907414fdbe081f7a URL: https://github.com/llvm/llvm-project/commit/67136d0e8fb57251dece4be0907414fdbe081f7a DIFF: https://github.com/llvm/llvm-project/commit/67136d0e8fb57251dece4be0907414fdbe081f7a.diff

[PATCH] D126420: [clang][dataflow] Remove private-field filtering from `StorageLocation` creation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG67136d0e8fb5: [clang][dataflow] Remove private-field filtering from `StorageLocation`… (authored by

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

jansvoboda11 added a comment. The differential I linked doesn't contain the right diff. Here's the commit I meant to point out: 3a75330f573a31c7e0f7e27c5d34501c293673a5. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126524/new/

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Nice. This is the patch that makes the condition obsolete: D60871 . You might also remove the `else`, since the first `if` now has an

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Grammar.h:87 +// Defines the built-in attribute keys. +enum class AttributeKey : uint8_t { + // A guard controls whether a reduction of a rule will be conducted by the GLR

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan marked 2 inline comments as done. egorzhdan added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:917 +/*static*/ std::string ToolChain::concat(const std::string , + const Twine , const Twine ,

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein added a comment. This patch might cover too many things (at least we could split the guide/glr implementation bit), but want to give you an overview of the picture first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126536/new/

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432539. egorzhdan added a comment. - Change arg type from `std::string` to `StringRef` - Remove unnecessary `//` • Remove unneeded test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: mgrang, mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. - Add annotation handling

[PATCH] D126067: [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal added a comment. I plan to land this stack next Wednesday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126067/new/ https://reviews.llvm.org/D126067 ___ cfe-commits mailing list

[PATCH] D126534: Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource created this revision. frederic-tingaud-sonarsource added a reviewer: dcoughlin. Herald added a subscriber: martong. Herald added a project: All. frederic-tingaud-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend

xbolva00 added inline comments. Herald added a reviewer: MaskRay. Herald added subscribers: vporpo, pmatos, asb. Herald added a project: All. Comment at: lld/ELF/LTO.cpp:96 + c.PTO.LoopVectorization = c.OptLevel > 1; + c.PTO.SLPVectorization = c.OptLevel > 1;

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

martong accepted this revision. martong added a comment. Still looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/ https://reviews.llvm.org/D126215 ___ cfe-commits mailing list

[PATCH] D119675: Also remove the empty StoredDeclsList entry from the lookup table

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c0eb32d2aa0: Also remove the empty StoredDeclsList entry from the lookup table (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8c0eb32 - Also remove the empty StoredDeclsList entry from the lookup table

Author: Vassil Vassilev Date: 2022-05-27T12:36:37Z New Revision: 8c0eb32d2aa0bc73c176d7b25f47bdf37f967d3b URL: https://github.com/llvm/llvm-project/commit/8c0eb32d2aa0bc73c176d7b25f47bdf37f967d3b DIFF: https://github.com/llvm/llvm-project/commit/8c0eb32d2aa0bc73c176d7b25f47bdf37f967d3b.diff

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:621 +void CodeGenModule::EmitCXXModuleInitFunc(Module *Primary) { + while (!CXXGlobalInits.empty() && !CXXGlobalInits.back()) iains wrote: > ChuanqiXu wrote: > > iains wrote: > > >

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

JohnTitor updated this revision to Diff 432527. JohnTitor added a comment. Fix the indention Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126524/new/ https://reviews.llvm.org/D126524 Files: clang/lib/Frontend/CompilerInstance.cpp Index:

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

JohnTitor updated this revision to Diff 432526. JohnTitor added a comment. [CompilerInstance] Tweak the condition on `createCodeCompletionConsumer` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126524/new/ https://reviews.llvm.org/D126524 Files:

[PATCH] D126067: [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal updated this revision to Diff 432525. steakhal retitled this revision from "[analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag" to "[analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag". steakhal edited the summary of this revision.

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 432522. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 Files: clang-tools-extra/clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added a comment. In D126364#3540673 , @efriedma wrote: > For FENV_ROUND, I think we should try to stick to the standard as closely as > possible in Sema; since the standard models FENV_ROUND as a separate state, > Sema should also model it as

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke updated this revision to Diff 432520. Sockke added a comment. Rebased and added '-fno-delayed-template-parsing' option for the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 Files:

[PATCH] D121413: [clang-repl] Add an accessor to our underlying execution engine

v.g.vassilev closed this revision. v.g.vassilev added a comment. Herald added a subscriber: StephenFan. Landed in https://github.com/llvm/llvm-project/commit/788e0f7f3e96a9d61c2412e452c4589e2693b79a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121413/new/

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 432518. upsj added a comment. Of course, I forgot to create a new diff. There is some debug output and logic errors for some of the tests, but the simple ones already show the issue. The function in question is `getPackTemplateParameter`, which provides similar

  1   2   >