[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2291 + // statement. + CodeGenFunction::RunCleanupsScope Cleanups(*this); + rjmccall wrote: > Do we need to do anything special when entering the full expressions to make > sure that

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 437796. ahatanak added a comment. Fix misleading comment and add a test case for C compound literal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 Files:

[PATCH] D127826: [Driver] Pass -X to ld for riscv*-{elf,freebsd,linux}

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. ld's help message just confused me, that say `-X` is default, but actually default action is `Discard local temporary symbols in SEC_MERGE sections.` which is no option can enable

[PATCH] D128022: [HIP] add -fhip-kernel-arg-name

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Add option -fhip-kernel-arg-name to emit kernel argument name metadata, which is needed for certain HIP applications.

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

dyung added a comment. @mboehme, one of our internal tests started to fail to compile after this change due to the compiler no longer accepting what I think should be a valid attribute declaration. I have filed issue #56077 for the problem, can you take a look? Repository: rG LLVM Github

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added a comment. In principle, I think the algorithm is fine. I'm pretty sure you can rewrite bits of it to get rid of the map/sets. I'm only concerned about handling attributes. (e.g. `cmpi slt` vs `cmpi sgt`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl added a comment. In D127142#3571260 , @MaskRay wrote: > In D127142#3570290 , @yaxunl wrote: > >> If I use --rtlib=compiler-rt, does that also requires --unwindlib=unwindlib ? > > No. --unwindlib=libunwind

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG711a71d1ab10: PowerPC] Emit warning for incompatible vector types that are currently… (authored by maryammo, committed by lei). Repository: rG

[clang] 711a71d - PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

Author: Maryam Moghadas Date: 2022-06-16T20:28:34-05:00 New Revision: 711a71d1ab1056b9ae1364eeec5eff2443629bf7 URL: https://github.com/llvm/llvm-project/commit/711a71d1ab1056b9ae1364eeec5eff2443629bf7 DIFF:

[clang] febe4f6 - [PowerPC][NFC] Undefine __XL_COMPAT_ALTIVEC__ in builtin lit test

Author: Lei Huang Date: 2022-06-16T20:16:52-05:00 New Revision: febe4f650b8754188c8cde01701bc16bd4a7a696 URL: https://github.com/llvm/llvm-project/commit/febe4f650b8754188c8cde01701bc16bd4a7a696 DIFF: https://github.com/llvm/llvm-project/commit/febe4f650b8754188c8cde01701bc16bd4a7a696.diff

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb83f8e70bd1: [OpenMP] Initial parsing and sema for parallel masked construct (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES

[clang] bb83f8e - [OpenMP] Initial parsing and sema for 'parallel masked' construct

Author: Jennifer Yu Date: 2022-06-16T18:01:15-07:00 New Revision: bb83f8e70bd1d56152f02307adacd718cd67e312 URL: https://github.com/llvm/llvm-project/commit/bb83f8e70bd1d56152f02307adacd718cd67e312 DIFF: https://github.com/llvm/llvm-project/commit/bb83f8e70bd1d56152f02307adacd718cd67e312.diff

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 437750. mingmingl added a comment. Use `--target=aarch64` rather than `--target=aarch64-unknown-linux-gnu`, given the former means all ELF based operating systems can expect the feature. (thanks maskray@ for pointing it out!) Repository: rG LLVM

[clang] 0e18246 - [sanitizer] Delete empty sanitizer_openbsd.cpp after D89759

Author: Fangrui Song Date: 2022-06-16T16:38:01-07:00 New Revision: 0e182469ee765613ea860e3b1024094411be9628 URL: https://github.com/llvm/llvm-project/commit/0e182469ee765613ea860e3b1024094411be9628 DIFF: https://github.com/llvm/llvm-project/commit/0e182469ee765613ea860e3b1024094411be9628.diff

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 437749. mingmingl marked an inline comment as done. mingmingl added a comment. change from `-target=aarch64-none-linux-gnu` to `--target=aarch64-none-linux-gnu` to resolve a compile error. Verified no other compilation error by `ninja check-all`

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. In D113107#3585672 , @zahiraam wrote: > @rjmccall > The comma && ternary cases for EmitPromoted, I am not sure what needs to > happen there? Basically just the same thing that the normal paths do, except you recurse with

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437740. maryammo added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:1022 +new HLSLExternalSemaSource()); +CI.getASTContext().setExternalSource(HLSLSema); + } python3kgae wrote: > Does this mean features like PCH which use ExternalSource

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

aeubanks added a comment. If I'm understanding correctly, previously the LLVM pointee type was used to represent a frontend OpenCL type. An alternative to marking everything with `elementtype` or adding metadata, can something be done in the frontend to mangle the function name with OpenCL

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. The OpenMP tests passed on D127998 (I think just randomly?). I'm going to commit this tomorrow morning so I can revert if needed. Javier, thanks again for the patch and for the patience! Repository: rG LLVM Github Monorepo

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim updated this revision to Diff 437734. hctim marked 2 inline comments as done. hctim added a comment. Create test input files rather than synthesizing on the fly, fix tests on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: aaron.ballman wrote: > hctim wrote: > > aaron.ballman wrote: > > > Spurious whitespace change? > >

[clang] dba2ff5 - fix x86 sanitizer failure due to use of or

Author: Lei Huang Date: 2022-06-16T17:20:31-05:00 New Revision: dba2ff500d5b29f2d18b93aed5caa5b4ef7c94dd URL: https://github.com/llvm/llvm-project/commit/dba2ff500d5b29f2d18b93aed5caa5b4ef7c94dd DIFF: https://github.com/llvm/llvm-project/commit/dba2ff500d5b29f2d18b93aed5caa5b4ef7c94dd.diff

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

python3kgae added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:1022 +new HLSLExternalSemaSource()); +CI.getASTContext().setExternalSource(HLSLSema); + } Does this mean features like PCH which use ExternalSource will not work

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen added a comment. In D127259#3590127 , @rnk wrote: > I think Richard had some concerns in the other review that this may not be > enough to really guarantee initialization order within the TU. I couldn't say > either way, I shouldn't review this

[clang] ee28837 - [NFCI] Whitespace in SemaDeclAttr.cpp

Author: Mitch Phillips Date: 2022-06-16T15:10:32-07:00 New Revision: ee28837a1fbd574dbec14b9f09cb4effab6a492a URL: https://github.com/llvm/llvm-project/commit/ee28837a1fbd574dbec14b9f09cb4effab6a492a DIFF:

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

hctim abandoned this revision. hctim added a comment. Herald added a subscriber: Enna1. Integrated slowly and surely as part of the stack leading up to D127911 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

amyk accepted this revision. amyk added a comment. This patch also LGTM. Thank you Lei. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124093/new/ https://reviews.llvm.org/D124093 ___ cfe-commits mailing

[PATCH] D128013: [clang][dataflow] Add support for comma binary operator

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Add support for comma binary operator. Repository:

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz created this revision. beanz added reviewers: aaron.ballman, kuhar, bogner, rnk, python3kgae. Herald added subscribers: Anastasia, jeroen.dobbelaere, mgorny. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL vector types are ext_vector

[PATCH] D126224: Add DWARF string debug to clang release notes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG011e0604ebc9: Add DWARF string debug to clang release notes. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

jhuber6 added a comment. In D127901#3590402 , @tra wrote: > Playing devil's advocate, I've got to ask -- do we even want to support JIT? > > JIT brings more trouble than benefits. > > - substantial start-up time on nontrivial apps. Last time I tried

[clang] 011e060 - Add DWARF string debug to clang release notes.

Author: Mitch Phillips Date: 2022-06-16T14:54:12-07:00 New Revision: 011e0604ebc9d85db3585ebb2f63df465f726417 URL: https://github.com/llvm/llvm-project/commit/011e0604ebc9d85db3585ebb2f63df465f726417 DIFF:

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim updated this revision to Diff 437717. hctim marked an inline comment as done. hctim added a comment. Change a small amount of wording, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 Files:

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim marked an inline comment as done. hctim added a comment. In D126224#3534643 , @probinson wrote: > I see some unrelated whitespace changes, we generally don't like mixing those > with "real" changes. But the description seems fine to me. Looks

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; aaron.ballman wrote: > beanz wrote: >

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

tra added a comment. Playing devil's advocate, I've got to ask -- do we even want to support JIT? JIT brings more trouble than benefits. - substantial start-up time on nontrivial apps. Last time I tried launching a tensorflow app and needed to JIT its kernels, it took about half an hour until

[PATCH] D128008: [clang][deps] Sort submodules when calculating dependencies

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Dependency scanning does not care about the order of

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat.c:8 // RUN: -D__XL_COMPAT_ALTIVEC__ -target-cpu pwr8 | FileCheck %s -// RUN: %clang_cc1

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

nemanjai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7571-7573 + "Current bitcast for incompatible vector types (%0 and %1) are deprecated. " + "The default behaviour will change to what is implied by the " +

[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added a comment. Looks good to me in general, one general question though. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:773 + // TODO: Make this work unconditionally once Flang is mature enough. + if (!Args.hasArg(options::OPT_flang_experimental_exec)) +

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. For referente, I run the tests without this change on commit: commit 94d1692aa155adf3b69609d142762b8c696e0710 (upstream/main, upstream/HEAD) Author: Fangrui Song Date: Tue Jun 14 21:25:56 2022 -0700 [MC] Remove unused MCStreamer::SwitchSection

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. I had the same failures with and without this change. It looks like these tests are already broken upstream. Without this patch: Unsupported: 15 Passed : 50 Failed : 232 With this patch: Unsupported: 15 Passed : 50 Failed : 232

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl marked an inline comment as done. mingmingl added inline comments. Comment at: clang/test/Preprocessor/aarch64-target-features.c:22 // CHECK-NOT: __ARM_FEATURE_CRC32 1 +// CHECK-NOT: __ARM_FEATURE_RCPC 1 // CHECK-NOT: __ARM_FEATURE_CRYPTO 1 MaskRay

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 437691. mingmingl marked an inline comment as done. mingmingl added a comment. In clang/test/Preprocessor/aarch64-target-features.c, move `__ARM_FEATURE_RCPC` to keep the alphabetical list, and use `-target=aarch64..` (the join style) rather than legacy

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. I started to get those errors on D126194 as well, definitely annoying. They both do spooky things with type triviality so maybe this is somehow related? I'm not sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

rnk added a subscriber: aaron.ballman. rnk added a comment. I think Richard had some concerns in the other review that this may not be enough to really guarantee initialization order within the TU. I couldn't say either way, I shouldn't review this code. Conceptually, this change seems small

[PATCH] D127860: [msan] Allow KMSAN to use -fsanitize-memory-param-retval

glider updated this revision to Diff 437678. glider added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127860/new/ https://reviews.llvm.org/D127860 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

erichkeane added a comment. In D127593#3590072 , @Javier-varez wrote: > I did try this locally and the built test binaries seem to crash with a > segmentation fault. I run one of them in lldb to check the error and I got > this backtrace: > >

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. I did try this locally and the built test binaries seem to crash with a segmentation fault. I run one of them in lldb to check the error and I got this backtrace: llvm-project/build on  fix-trivially-copyable-check [?⇕] via △ v3.22.3 took 3s ❯ lldb

[PATCH] D127890: [Docs] Update clang & llvm release notes for HLSL

MaskRay added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:117 +* DirectX has been added as an experimental target. Specify +`-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=DirectX` in your CMake configuration to + enable it. The target is not packaged in pre-built binaries.

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

lei marked an inline comment as not done. lei added inline comments. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat.c:8 // RUN: -D__XL_COMPAT_ALTIVEC__ -target-cpu pwr8 | FileCheck %s -// RUN: %clang_cc1 -no-opaque-pointers -target-feature +altivec

[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3495 +/// \code +///true: false: +///new (buf) T;vs.new(buf) T; MyDeveloperDay wrote: > should

[PATCH] D127890: [Docs] Update clang & llvm release notes for HLSL

beanz updated this revision to Diff 437672. beanz added a comment. Updates based on review feedback. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127890/new/ https://reviews.llvm.org/D127890 Files: clang/docs/ReleaseNotes.rst

[PATCH] D127802: [HLSL] Support HLSL vector initializers

beanz updated this revision to Diff 437670. beanz added a comment. Updates based on feedback from @aaron.ballman. Thank you for all the test suggestions, it caught an extra-odd AST generation. Fix included :). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen added a comment. gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127259/new/ https://reviews.llvm.org/D127259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

ychen added a comment. gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

erichkeane added a comment. I probably need to spend more time on this at one point, but first look seemed fine to me. I think the approach is about right, and the solution is there. @aaron.ballman is messing with the constexpr-ness of SM functions, so there is likely some collaboration that

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

MaskRay added inline comments. Comment at: clang/test/Preprocessor/aarch64-target-features.c:22 // CHECK-NOT: __ARM_FEATURE_CRC32 1 +// CHECK-NOT: __ARM_FEATURE_RCPC 1 // CHECK-NOT: __ARM_FEATURE_CRYPTO 1 The list is alphabetical. RCPC should be moved below.

[PATCH] D127998: [CI test] D127593

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Testing D127593 by Javier varez to see if the CI failures are

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl added a comment. In D127798#3588283 , @lenary wrote: > Yes. Please submit a PR or Issue to the ACLE, explaining the use-case (the > explanation here is good enough, I think). > > Once the ACLE changes are merged, then you can proceed with a

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson updated this revision to Diff 437656. royjacobson added a comment. Update the PR to now handle triviality, which turned out to require a different approach. On the bright side it is now easier to see how to implemenet the rest of P0848. Added an AST dump test that checks the

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d43de13df03: [AMDGPU] gfx11 new dot instruction codegen support (authored by Joe_Nash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 2d43de1 - [AMDGPU] gfx11 new dot instruction codegen support

Author: Joe Nash Date: 2022-06-16T14:19:34-04:00 New Revision: 2d43de13df03eab0fda1023b22b335b207afc507 URL: https://github.com/llvm/llvm-project/commit/2d43de13df03eab0fda1023b22b335b207afc507 DIFF: https://github.com/llvm/llvm-project/commit/2d43de13df03eab0fda1023b22b335b207afc507.diff

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:209 def IsTupleSet: FlagType<0x4>; +def IsSME : FlagType<0x8>; +def IsSMELoadStore: FlagType<0x10>;

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim added a comment. (thanks for the bump - this one fell off the radar) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___ cfe-commits mailing list

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim added a comment. Yeah, I'll look at landing it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___ cfe-commits mailing list

[PATCH] D126224: Add DWARF string debug to clang release notes.

paulkirth added a comment. so do we want to land this? or are there some outstanding issues I'm unaware of? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

fcloutier added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112579/new/ https://reviews.llvm.org/D112579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 added a comment. In D127910#3589068 , @sdesmalen wrote: > Hi @sagarkulkarni19, this patch will have to wait until the ABI is > implemented so that the builtins can be decorated with the attributes. A > first patch proposing these

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2291 + // statement. + CodeGenFunction::RunCleanupsScope Cleanups(*this); + Do we need to do anything special when entering the full expressions to make sure that enclosing-block

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3588787 , @aaron.ballman wrote: > In D126495#3574115 , > @LegalizeAdulthood wrote: > >> In D126495#3571511 , @njames93 >>

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127904/new/ https://reviews.llvm.org/D127904

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

steakhal added a comment. In the `describeErrnoCheckState()` the `Errno_MustBeChecked` is uncovered by tests. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:410 +/// Many of the descendant classes use this value. +

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 added a comment. I think it's a good idea. When does `MatchingParen` bind? The value of `PrevToken->MatchingParen` is still NULL in `determineStarAmpUsage` function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

vangthao updated this revision to Diff 437593. vangthao added a comment. Update commit message to include the motivation behind the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127923/new/ https://reviews.llvm.org/D127923 Files:

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl updated this revision to Diff 437587. yaxunl added a comment. use compiler-rt as runtime lib by default for --hip-link CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127142/new/ https://reviews.llvm.org/D127142 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

steakhal added a comment. Awesome! The generated doc section looks great. The test coverage it excellent, but I would recommend adding tests for covering the following lines: - `ErrnoChecker.cpp:99` - `ErrnoModeling.cpp:259` - `ErrnoModeling.cpp:264` There are two other uncovered cases, but

[PATCH] D127898: [clang][dataflow] Find unsafe locs after fixpoint

tschuett added a comment. C++ seems to be tied to templates. I wonder if super classes resp. inheritance would make your life easier. You can explicitly define the API and documentation. You could provide default implementations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

Joe_Nash added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1926 +// f16 %r = llvm.amdgcn.fdot2.f16.f16(v2f16 %a, v2f16 %b, f16 %c, i1 %clamp) +// %r = %a[0] * %b[0] + %a[1] * %b[1] + %c rampitec wrote: > I do not see clamp in the

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 437582. serge-sans-paille retitled this revision from "[clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays" to "[clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays". serge-sans-paille edited

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen added a comment. Thanks @aaron.ballman for your elaborate review, that was very helpful! I'm still working through some of your suggestions (although some of them weren't entirely clear to me), but I've addressed a number of them already. In D127762#3582753

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen updated this revision to Diff 437580. sdesmalen marked 10 inline comments as done. sdesmalen added a comment. Addressed bunch of the review comments (though not all yet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127762/new/

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

steakhal added a comment. In D127874#3588786 , @martong wrote: >> If some checker placed a sink node into some block, the successors of the >> sink block was marked unreachable previously. This leads to an unpleasant >> situation from the user's point

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa70b39abffb4: [clang] Dont emit type test/assume for virtual classes that should never… (authored by aeubanks). Repository: rG LLVM Github

[clang] a70b39a - [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

Author: Arthur Eubanks Date: 2022-06-16T09:38:14-07:00 New Revision: a70b39abffb42eb85fd2dd7960ec9dc7ae38510c URL: https://github.com/llvm/llvm-project/commit/a70b39abffb42eb85fd2dd7960ec9dc7ae38510c DIFF:

[PATCH] D127898: [clang][dataflow] Find unsafe locs after fixpoint

ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:35 +using NoopDiags = std::tuple<>; + I'm not sure that this is valid style. It's essentially a unit type, which I quite like, but I've never seen this

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

nemanjai added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15587 + +bool isUnaligned = (BuiltinID == PPC::BI__builtin_altivec_vinsw || +BuiltinID == PPC::BI__builtin_altivec_vinsd) This is strange. You don't need the

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added inline comments. Comment at: llvm/test/CodeGen/X86/fpclamptosat_vec.ll:605 +; CHECK-NEXT:.cfi_def_cfa_offset 80 +; CHECK-NEXT:movss %xmm2, {{[-0-9]+}}(%r{{[sb]}}p) # 4-byte Spill +; CHECK-NEXT:movss %xmm1, {{[-0-9]+}}(%r{{[sb]}}p) # 4-byte Spill

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 437566. ahatanak added a comment. Revert the changes made to SemaCoroutine.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 Files:

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

bsmith updated this revision to Diff 437557. bsmith added a comment. - Add info to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127976/new/ https://reviews.llvm.org/D127976 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D127886: [clang-tidy] Allow access to the SourceManager in clang-tidy checks

nicovank abandoned this revision. nicovank added a comment. Looks like `registerPPCallbacks` / `Result.Context->getSourceManager()` gives me the information I need. Thank you @gribozavr2 for your help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127933: [clang] Don't emit IFUNC when targeting Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4f6adc451a2: [clang] Dont emit IFUNC when targeting Fuchsia (authored by abrachet). Herald added a project: clang. Herald added a subscriber:

[clang] f4f6adc - [clang] Don't emit IFUNC when targeting Fuchsia

Author: Alex Brachet Date: 2022-06-16T15:38:12Z New Revision: f4f6adc451a2dc901c08c2fdac81ef2cf98a5cc6 URL: https://github.com/llvm/llvm-project/commit/f4f6adc451a2dc901c08c2fdac81ef2cf98a5cc6 DIFF: https://github.com/llvm/llvm-project/commit/f4f6adc451a2dc901c08c2fdac81ef2cf98a5cc6.diff LOG:

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

tschuett added a comment. Maybe a line in the Release Notes of LLVM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127976/new/ https://reviews.llvm.org/D127976 ___ cfe-commits mailing list

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

Joe_Nash updated this revision to Diff 437552. Joe_Nash marked 3 inline comments as done. Joe_Nash added a comment. added builtin positive tests, removed clamp from intrinsic comments, combined gisel with normal codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, c-rhodes, sdesmalen. Herald added subscribers: ctetreau, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

jcranmer-intel added a comment. In D127579#3588607 , @iliya-diyachkov wrote: > I think the return type information can be added in the next version of the > patch, however it should be attached to function declarations (not > definitions as it's done

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sdesmalen added a comment. Hi @sagarkulkarni19, this patch will have to wait until the ABI is implemented so that the builtins can be decorated with the attributes. A first patch proposing these attributes is in D127762 . LLVM patches that use these attributes

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

ABataev added a comment. provide full context of the changes. Comment at: clang/include/clang/AST/OpenMPClause.h:7646 - /// A kind of the 'default' clause. + /// A kind of the 'order' clause. OpenMPOrderClauseKind Kind = OMPC_ORDER_unknown; Commit as

  1   2   >