[clang] 97afce0 - [clang] Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-25T22:26:24-07:00 New Revision: 97afce08cbbb1390cf8ddab8bf398f3ff5b39676 URL: https://github.com/llvm/llvm-project/commit/97afce08cbbb1390cf8ddab8bf398f3ff5b39676 DIFF: https://github.com/llvm/llvm-project/commit/97afce08cbbb1390cf8ddab8bf398f3ff5b39676.diff

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire marked 3 inline comments as done. junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:281 +void IncrementalParser::Restore(PartialTranslationUnit ) { + TranslationUnitDecl *MostRecentTU = PTU.TUPart; v.g.vassilev

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 440027. junaire added a comment. Address @v.g.vassilev 's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files:

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. A gentle ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:25 + "'M' (Integer Multiplication and Division)", + [FeatureStdExtZmmul]>; def HasStdExtM : Predicate<"Subtarget->hasStdExtM()">, This

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e32ff106e74: [clang-format] Handle Verilog preprocessor directives (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/

[clang] 2e32ff1 - [clang-format] Handle Verilog preprocessor directives

Author: sstwcw Date: 2022-06-26T02:02:29Z New Revision: 2e32ff106e740c76601004493816d0ed7c483056 URL: https://github.com/llvm/llvm-project/commit/2e32ff106e740c76601004493816d0ed7c483056 DIFF: https://github.com/llvm/llvm-project/commit/2e32ff106e740c76601004493816d0ed7c483056.diff LOG:

[PATCH] D123450: [clang-format] Parse Verilog if statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed2e68c9ae5: [clang-format] Parse Verilog if statements (authored by sstwcw). Changed prior to commit:

[clang] 9ed2e68 - [clang-format] Parse Verilog if statements

Author: sstwcw Date: 2022-06-26T01:52:15Z New Revision: 9ed2e68c9ae5cf346f938cc095e5448c1ff60f51 URL: https://github.com/llvm/llvm-project/commit/9ed2e68c9ae5cf346f938cc095e5448c1ff60f51 DIFF: https://github.com/llvm/llvm-project/commit/9ed2e68c9ae5cf346f938cc095e5448c1ff60f51.diff LOG:

[clang] 370bee4 - [clang-format] Fix whitespace counting stuff

Author: sstwcw Date: 2022-06-26T01:27:27Z New Revision: 370bee480139bd37fe8c0c8c03ecd19ed9223f01 URL: https://github.com/llvm/llvm-project/commit/370bee480139bd37fe8c0c8c03ecd19ed9223f01 DIFF: https://github.com/llvm/llvm-project/commit/370bee480139bd37fe8c0c8c03ecd19ed9223f01.diff LOG:

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

This revision was automatically updated to reflect the committed changes. Closed by commit rG370bee480139: [clang-format] Fix whitespace counting stuff (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124748/new/

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

ksyx updated this revision to Diff 440017. ksyx retitled this revision from "[RISCV][Clang] Implement support for zmmul-experimental" to "[RISCV][Clang] Add support for Zmmul extension". ksyx edited the summary of this revision. ksyx added a comment. Herald added subscribers: sunshaoce,

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 440016. pengfei marked 3 inline comments as done. pengfei added a comment. Address review comments. Thanks @rjmccall ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571

[clang-tools-extra] b2cb7e8 - [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

Author: Joachim Priesner Date: 2022-06-25T15:50:13-06:00 New Revision: b2cb7e81f8978ccce5c5e7b316480b88785ca9cc URL: https://github.com/llvm/llvm-project/commit/b2cb7e81f8978ccce5c5e7b316480b88785ca9cc DIFF:

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Well, it must have been unrelated to your change or some weird interaction on my machine because I rebased and ran `check-clang-extra` again and it passed this time.

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

HazardyKnusperkeks added a comment. But for now you should wait for @MyDeveloperDay that he at least removes the changes needed, or state what you have to change, or even better accept it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

HazardyKnusperkeks added a comment. In D127873#3610106 , @jackhong12 wrote: > Hi. I passed the unit tests on my computer. But the build status here is > failed. The build log only shows the issue is related to `git reset --hard`. > So, I don't know

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:282 +// These are all class names in ExprCXX.h without 'CXX' prefix. +#define CXXStmts \ + ArrayTypeTraitExpr,\ I'm not a fan of this macro, and

[PATCH] D128554: [Driver][Minix] -r: imply -nostdlib like GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rG066043c84fdb: [Driver][Minix] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128554/new/

[clang] 066043c - [Driver][Minix] -r: imply -nostdlib like GCC

Author: Brad Smith Date: 2022-06-25T16:16:38-04:00 New Revision: 066043c84fdb0ee0d719fd80b0ff9e0f853850d0 URL: https://github.com/llvm/llvm-project/commit/066043c84fdb0ee0d719fd80b0ff9e0f853850d0 DIFF: https://github.com/llvm/llvm-project/commit/066043c84fdb0ee0d719fd80b0ff9e0f853850d0.diff

[PATCH] D128372: [Clang-Tidy] Empty Check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-standalone-empty.cpp:1 +// RUN: %check_clang_tidy %s

[PATCH] D37797: Fix crash in Sema when wrongly assuming VarDecl init is not value dependent.

v.g.vassilev resigned from this revision. v.g.vassilev added a comment. Herald added a project: All. According to godbolt this example does not crash anymore. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37797/new/ https://reviews.llvm.org/D37797

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Rebase against main to get updated docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a comment. In D125944#3544341 , @v.g.vassilev wrote: > @Purva-Chaudhari, can you rebase this patch, seems that it is not buildable. > > @rsmith, we need to do something similar in cling to handle pending template > instantiations, I

[PATCH] D125946: Handles failing driver tests of clang

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/clangtests.cpp:1 +// RUN: clang-repl %S/../Lexer/badstring_in_if0.c -Xcc -E -Xcc -verify +// RUN: clang-repl %S/../Lexer/unknown-char.c -Xcc -E -Xcc -verify dblaikie wrote: > v.g.vassilev

[PATCH] D54986: Make CodeGen choose when to emit vtables.

v.g.vassilev resigned from this revision. v.g.vassilev added a comment. Herald added a project: All. I think this landed in a different form. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54986/new/ https://reviews.llvm.org/D54986

[PATCH] D128589: [clang-repl] Support destructors of global objects.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM, modulo the comment. Comment at: clang/lib/Interpreter/IncrementalExecutor.h:46 llvm::Error runCtors() const; + llvm::Error cleanUp(); llvm::Expected

[clang] b8df409 - [clang, clang-tools-extra] Don't use Optional::{hasValue,getValue} (NFC)

Author: Kazu Hirata Date: 2022-06-25T11:55:33-07:00 New Revision: b8df4093e4d82c67a419911a46b63482043643e5 URL: https://github.com/llvm/llvm-project/commit/b8df4093e4d82c67a419911a46b63482043643e5 DIFF: https://github.com/llvm/llvm-project/commit/b8df4093e4d82c67a419911a46b63482043643e5.diff

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin added a comment. @aaron.ballman @tahonermann Thanks for the review. I landed the change after confirming with Aaron he was happy with it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc92056d03881: [Clang][C++23] P2071 Named universal character escapes (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128257: invalidateCache in addModule and removeModules

tapaswenipathak added a comment. https://github.com/llvm/llvm-project/commit/ca39214f4e9fddf247e880ef9562865be850fce6#diff-a59fa24a712b79c57b4d922d0d407b8f63a9a88fa79ba0d85b0063e1a2a6fda3L157 closing, now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

MaskRay added a comment. In D126864#3609965 , @xbolva00 wrote: >>> -fsanitize=array-bounds workaround for size-1 array as the last member of a >>> structure > > Could you provide option for that (to enable stricker bound checks introduced > with this

[PATCH] D128554: [Driver][Minix] -r: imply -nostdlib like GCC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128554/new/ https://reviews.llvm.org/D128554

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a comment. After landing https://reviews.llvm.org/D126682 we might be able to write a test in clang-repl such as: cpp clang-repl> #include clang-repl> #include clang-repl>using namespace std; clang-repl> int write_str (const char* str) { ofstream myfile;

[PATCH] D128257: invalidateCache in addModule and removeModules

v.g.vassilev added a comment. I think this patch is not needed in the `main` branch as https://github.com/llvm/llvm-project/commit/f91b6f8159b101688eef87c75179209699c0d405 removes the need of calling `invalidateCache` altogether. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128319: Survive #pragma once from virtual file.

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a comment. Can we write a test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128319/new/ https://reviews.llvm.org/D128319 ___

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:72 + void Restore(PartialTranslationUnit ); + v.g.vassilev wrote: > I am not sure if that's the best function. We Please ignore this comment it was superseded by

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added a comment. Thanks for working on this. Here are some more comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:72 + void Restore(PartialTranslationUnit ); + I am not sure if that's the best function. We

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:746 * SPIR -* X86 (Only available under feature AVX512-FP16) +* X86 (Enabled with feature SSE2 and up) Could you take the wording I suggested from the other patch? You'll need to

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

sstwcw updated this revision to Diff 439981. sstwcw added a comment. - address comments - add token annotator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126845/new/ https://reviews.llvm.org/D126845 Files: clang/lib/Format/FormatToken.h

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

jackhong12 marked 2 inline comments as done. jackhong12 added a comment. Hi. I passed the unit tests on my computer. But the build status here is failed. The build log only shows the issue is related to `git reset --hard`. So, I don't know where the bug is. Could you give me some hints to fix

[PATCH] D128569: Start support for HLSL `RWBuffer`

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1703 LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_pointer, "v*", "i", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_status, "Ui",

[PATCH] D126934: [clang-format] NFC Sort names of format token types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f69f7ea9af4: [clang-format] NFC Sort names of format token types (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 1f69f7e - [clang-format] NFC Sort names of format token types

Author: sstwcw Date: 2022-06-25T12:09:49Z New Revision: 1f69f7ea9af4bd4e8001a25044aa026557f366f7 URL: https://github.com/llvm/llvm-project/commit/1f69f7ea9af4bd4e8001a25044aa026557f366f7 DIFF: https://github.com/llvm/llvm-project/commit/1f69f7ea9af4bd4e8001a25044aa026557f366f7.diff LOG:

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

nlopes added a comment. In D128501#3608846 , @efriedma wrote: > Under this scheme, is it illegal to link together object files built with > -ffine-grained-bitfield-accesses and object files built with > -fno-fine-grained-bitfield-accesses? No, you can

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp added a comment. @LegalizeAdulthood I've addressed your comments, thanks for the clear instructions! One thing I didn't manage to do is build the target `docs-clang-tools-html`, it says it doesn't exist. I've enabled `LLVM_BUILD_DOCS=ON` in the CMake call - do you know if I need

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 439974. carlosgalvezp added a comment. Fix test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 Files:

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 439973. carlosgalvezp added a comment. Rebase and fix directory structure for doc and test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 Files:

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

xbolva00 added a comment. >> -fsanitize=array-bounds workaround for size-1 array as the last member of a >> structure Could you provide option for that (to enable stricker bound checks introduced with this patch) ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/