[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

sberg added a comment. In D126864#3612149 , @sberg wrote: > see https://reviews.llvm.org/D128643 "[clang] -fsanitize=array-bounds: treat > all trailing size-1 arrays as flexible" for another regression For the record (now that the original commit has

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128624: [RISCV] Zero extend immediate for vget/vset builtins to match vector.insert/extract intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG17a36c7c40e9: [RISCV] Zero extend immediate for vget/vset builtins to match vector. (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D128624?vs=440112=440459#toc

[clang] 17a36c7 - [RISCV] Zero extend immediate for vget/vset builtins to match vector.insert/extract intrinsics.

Author: Craig Topper Date: 2022-06-27T20:26:54-07:00 New Revision: 17a36c7c40e99aa28d4323698f69845d92d96682 URL: https://github.com/llvm/llvm-project/commit/17a36c7c40e99aa28d4323698f69845d92d96682 DIFF: https://github.com/llvm/llvm-project/commit/17a36c7c40e99aa28d4323698f69845d92d96682.diff

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

efriedma added a comment. > Is that seen as a defect or as for some reason desirable? Because I worry > that optimizer people are talking themselves into something that would be a > truly beautiful model if only there were a frontend that could emit code for > it. > > Doesn't this make it e.g.

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Gentle ping. Verified the patch works with latest code base, all tests green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 ___

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune added a comment. PR31524 (https://github.com/llvm/llvm-project/issues/31524) discusses about the lowering of such intrinsics. According to the PR, it seems users consider undefined intrinsics as returning unknown but consistent bits. If it works, my updates in the draft

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

rjmccall added a comment. In D128501#3613890 , @efriedma wrote: >> Is there no way in LLVM to load partially-initialized memory and then freeze >> it that will preserve the parts of the value that are initialized? Because >> that seems like something

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

vsapsai updated this revision to Diff 440451. vsapsai added a comment. More preparations to minimize subsequent diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128690/new/ https://reviews.llvm.org/D128690 Files:

[PATCH] D128624: [RISCV] Zero extend immediate for vget/vset builtins to match vector.insert/extract intrinsics.

liaolucy accepted this revision. liaolucy added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128624/new/ https://reviews.llvm.org/D128624

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440450. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h clang/lib/ASTMatchers/ASTMatchersInternal.cpp

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 440447. vangthao added a comment. Remove "" delimiter. Change ScratchSize [bytes/thread] to ScratchSize [bytes/lane]. Use lambda expression to emit remarks. Do not output yaml if specific remark is not enabled. Add indentation to make it easier to

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

NoQ added a comment. Looks great, thanks! Comment at: clang/docs/LibASTMatchersReference.html:2041 + +Example matches "abcd" + NSString *s = @"abcd"; I think it's more appropriate for this documentation to mention the entire literal so that the reader didn't

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440443. t-rasmud added a comment. Documentation edits and other fixes, thanks to suggestions from @ziqingluo-90 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files:

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1143 MarshallingInfoFlag>; +def fstrict_flex_arrays_EQ : Joined<["-"], "fstrict-flex-arrays=">,Group, + MetaVarName<"">, Values<"0,1,2,3">, Comment at:

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specifically, making the following changes: - Turn lambdas calculating ODR hashes

[clang] efd90ff - [test] Add -fsanitize=array-bounds test for pseudo flexible array member

Author: Fangrui Song Date: 2022-06-27T16:40:52-07:00 New Revision: efd90ffbfc427ad4c4675ac1fcae9d53cc7f1322 URL: https://github.com/llvm/llvm-project/commit/efd90ffbfc427ad4c4675ac1fcae9d53cc7f1322 DIFF: https://github.com/llvm/llvm-project/commit/efd90ffbfc427ad4c4675ac1fcae9d53cc7f1322.diff

[PATCH] D128667: [WIP] Add Zstd ELF support

dblaikie added a comment. Yeah, probably worth splitting this up a bit - somewhat hard to split up generation+parsing in LLVM itself (eg: llvm-mc+llvm-objdump), so maybe they're grouped together (alternatively the objdump support gets checked in first with precompiled/binary test files - I

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

efriedma added a comment. > Is there no way in LLVM to load partially-initialized memory and then freeze > it that will preserve the parts of the value that are initialized? Because > that seems like something that LLVM needs to be providing. It's currently possible to `load <32 x i1>`, freeze

[PATCH] D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128686/new/ https://reviews.llvm.org/D128686

[PATCH] D128318: [pseudo] prototype: faster data structures for LRTable

sammccall abandoned this revision. sammccall added a comment. This is obsoleted by D128485 and D128472 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128318/new/

[PATCH] D128687: [pseudo] Allow mixed designated/undesignated init lists.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. This isn't allowed by the standard grammar but is allowed

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123319/new/ https://reviews.llvm.org/D123319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests

jdoerfert added a comment. I'm not so sure but phab things this is small, so no complaints: F23600771: 2022-06-27_18-06-1656371325.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128686/new/

[PATCH] D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests

jdoerfert created this revision. jdoerfert added reviewers: jhuber6, JonChesterfield, ABataev, RaviNarayanaswamy, ggeorgakoudis, tianshilei1992. Herald added subscribers: mattd, asavonic, guansong, bollu, yaxunl. Herald added a project: All. jdoerfert requested review of this revision. Herald

[PATCH] D128685: [OpenMP][NFC] Remove unused check lines in Clang/OpenMP tests

jdoerfert created this revision. jdoerfert added a reviewer: jhuber6. Herald added subscribers: mattd, asavonic, guansong, bollu, yaxunl. Herald added a project: All. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

jdenny added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126549/new/ https://reviews.llvm.org/D126549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

This revision was automatically updated to reflect the committed changes. Closed by commit rG0103d4da740c: [Clang][OpenMP] Dont overload extension in status doc (authored by jdenny). Changed prior to commit: https://reviews.llvm.org/D126549?vs=432567=440419#toc Repository: rG LLVM Github

[clang] 0103d4d - [Clang][OpenMP] Don't overload "extension" in status doc

Author: Joel E. Denny Date: 2022-06-27T18:41:17-04:00 New Revision: 0103d4da740c9d2688389e2aa5e3c2f3792e6940 URL: https://github.com/llvm/llvm-project/commit/0103d4da740c9d2688389e2aa5e3c2f3792e6940 DIFF: https://github.com/llvm/llvm-project/commit/0103d4da740c9d2688389e2aa5e3c2f3792e6940.diff

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85eaecbe8e54: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 85eaecb - [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

Author: Sam McCall Date: 2022-06-28T00:36:16+02:00 New Revision: 85eaecbe8e541924b6f87dd83f169056e74ce237 URL: https://github.com/llvm/llvm-project/commit/85eaecbe8e541924b6f87dd83f169056e74ce237 DIFF: https://github.com/llvm/llvm-project/commit/85eaecbe8e541924b6f87dd83f169056e74ce237.diff

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

sammccall marked 13 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/LRTable.h:136 + // check whether a reduction should apply in the current context. + llvm::ArrayRef getReduceRules(StateID State)

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

sammccall updated this revision to Diff 440415. sammccall marked 3 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128472/new/ https://reviews.llvm.org/D128472 Files:

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

ychen added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

MaskRay added a comment. In D128333#3613665 , @awarzynski wrote: > @MaskRay, thank for taking a look! > > In D128333#3605745 , @MaskRay wrote: > >> gfortran defaults to PIE as well. > > While we strive to be

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

sammccall added a comment. Thanks, the split here looks good! Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:115 // Parameters for the GLR parsing. +// FIXME: refine it with the ParseLang struct. struct ParseParams { You're already touching

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep updated this revision to Diff 440406. samestep added a comment. - Bring back Diagnosis.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hctim marked an inline comment as done. Closed by commit rGdacfa24f75c3: Delete llvm.asan.globals for global metadata. (authored by hctim). Changed prior to commit:

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:747 + /// Return difference with the given option set. + FPOptionsOverride diffWith(const FPOptions ); + Can you make direction more obvious in the method name? `diffFrom`

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski added a comment. @MaskRay, thank for taking a look! In D128333#3605745 , @MaskRay wrote: > gfortran defaults to PIE as well. While we strive to be compatible with `gfortan`, there's a lot relatively "basic" things still missing in LLVM

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

mwyman added a reviewer: doug.gregor. mwyman added a comment. Adding Doug Gregor who appears to have created the original warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128031/new/ https://reviews.llvm.org/D128031 ___ cfe-commits

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:76 + +auto Methods = Arg->getType()->getAsCXXRecordDecl()->methods(); +auto Clear = llvm::find_if(Methods, [](const CXXMethodDecl *F) { denik wrote: >

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

rjmccall added a comment. Is there no way in LLVM to load partially-initialized memory and then freeze it that will preserve the parts of the value that are initialized? Because that seems like something that LLVM needs to be providing. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1355-1356 // at all, we assume it has dynamic initializer (in other TU). - // - // FIXME: Metadata should be attched directly to the global directly instead - // of being

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka updated this revision to Diff 440396. vitalybuka added a comment. restore blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 Files: clang/docs/ClangCommandLineReference.rst

[clang] df18167 - [docs] Restore missing blank line

Author: Vitaly Buka Date: 2022-06-27T14:21:08-07:00 New Revision: df18167ac56d05f2ab55f9d874aee7ab6d5bc9a2 URL: https://github.com/llvm/llvm-project/commit/df18167ac56d05f2ab55f9d874aee7ab6d5bc9a2 DIFF: https://github.com/llvm/llvm-project/commit/df18167ac56d05f2ab55f9d874aee7ab6d5bc9a2.diff

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

bmahjour added inline comments. Comment at: clang/test/CodeGen/lower-mass-end-to-end.c:33-34 +// CHECK-MASS-AFN: __xl_sin +// CHECK-NOMASS-FAST-NOT: __xl_sin_finite +// CHECK-NOMASS-AFN-NOT: __xl_sin +// CHECK: blr Please also check for CHECK-NOMASS-FAST-NOT:

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall updated this revision to Diff 440393. sammccall edited the summary of this revision. sammccall added a comment. update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128486/new/ https://reviews.llvm.org/D128486 Files:

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

mwyman updated this revision to Diff 440390. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128031/new/ https://reviews.llvm.org/D128031 Files: clang/lib/Sema/SemaType.cpp clang/test/SemaObjCXX/Inputs/nullability-consistency-2.h Index:

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:83 +KCFI_NT_CALL, +KCFI_TC_RETURN, + samitolvanen wrote: > pcc wrote: > > samitolvanen wrote: > > > joaomoreira wrote: > > > > samitolvanen wrote: > > > > > joaomoreira

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka updated this revision to Diff 440388. vitalybuka edited the summary of this revision. vitalybuka added a comment. exactly as reverted revision 886715af962de2c92fac4bd37104450345711e4a +

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

shafik added a comment. Are you sure it is failing on the line you indicated? After looking at the code, a little before that line we have: Result = APValue(APValue::UninitArray(), NumEltsToInit, NumElts); which should assure that we have an array at this point. Looking at the result of the

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall updated this revision to Diff 440383. sammccall added a comment. revert format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128486/new/ https://reviews.llvm.org/D128486 Files:

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall created this revision. Herald added a subscriber: mgrang. Herald added a project: All. sammccall updated this revision to Diff 440376. sammccall retitled this revision from "xxx recover" to "[pseudo] Add error-recovery framework & brace-based recovery". sammccall edited the summary of

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reverted with cdfa15da94f06289dcf86173d18b6627f92ac403 (inlcuding 572b08790a69f955ae0cbb1b4a7d4a215f15dad9

[clang] cdfa15d - Revert "[clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays"

Author: Vitaly Buka Date: 2022-06-27T14:03:09-07:00 New Revision: cdfa15da94f06289dcf86173d18b6627f92ac403 URL: https://github.com/llvm/llvm-project/commit/cdfa15da94f06289dcf86173d18b6627f92ac403 DIFF: https://github.com/llvm/llvm-project/commit/cdfa15da94f06289dcf86173d18b6627f92ac403.diff

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka added a comment. This bot is broken by this patch https://lab.llvm.org/buildbot/#/builders/85/builds/8881 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-commits mailing list

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

efriedma added a comment. > This only matters if the IRs are linked together with IPO. Otherwise, at > object level it doesn't really matter. Right. > Do you think we can get away by just documenting the incompatibility of doing > IPO with files compiled with different

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 440374. vaibhav.y added a comment. Discard include: `clang/Lex/Lexer.h` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 440371. vaibhav.y added a comment. Use `CharSourceRange` instead of FullSourceRange so we no longer need to compute the length of the last token. This should already be encoded in the end location of the `CharSourceRange` by the caller TODO(@vaibhav.y):

[PATCH] D128449: [clang] Introduce -Warray-parameter

shafik added inline comments. Comment at: clang/test/Sema/array-parameter.c:17 + +void f5(int a[restrict 2]); +void f5(int a[2]); // no warning Since we are covering `static`, `const` and `restict` we should also cover `volatile` for completeness. CHANGES

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

hokein updated this revision to Diff 440366. hokein added a comment. remove a dependency from pseudoCLI lib Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128679/new/ https://reviews.llvm.org/D128679 Files:

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

nlopes added a comment. In D128501#3613420 , @efriedma wrote: >> No, you can still link those. There's no ABI change nor any interference at >> IR level. > > The scenario I was thinking of with -ffine-grained-bitfield-accesses is > something like the

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. - define a common data structure

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

efriedma added a comment. > No, you can still link those. There's no ABI change nor any interference at > IR level. The scenario I was thinking of with -ffine-grained-bitfield-accesses is something like the following: File A: struct X { int a : 8; int b : 24; }; void f(struct X*); int

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126549/new/ https://reviews.llvm.org/D126549

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

jdenny added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126549/new/ https://reviews.llvm.org/D126549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440359. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/lib/ASTMatchers/ASTMatchersInternal.cpp clang/lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked an inline comment as done. abidmalikwaterloo added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend shraiysh wrote: > abidmalikwaterloo wrote: > > shraiysh wrote: > > >

[PATCH] D108469: Improve handling of static assert messages.

erichkeane added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; erichkeane wrote: > cor3ntin wrote: > >

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:161 +Region["endColumn"] = adjustColumnPos( +R.getEnd(), Lexer::MeasureTokenLength(R.getEnd().getLocWithOffset(0), + R.getEnd().getManager(), LO));

[PATCH] D108469: Improve handling of static assert messages.

erichkeane added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; cor3ntin wrote: > cor3ntin wrote: > >

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; cor3ntin wrote: > erichkeane wrote: > > What

[clang] 8f7cca9 - Revert "[X86] Support `_Float16` on SSE2 and up"

Author: Vitaly Buka Date: 2022-06-27T12:43:29-07:00 New Revision: 8f7cca90af6e06daab4ce23cb0f894380ca7a6a1 URL: https://github.com/llvm/llvm-project/commit/8f7cca90af6e06daab4ce23cb0f894380ca7a6a1 DIFF: https://github.com/llvm/llvm-project/commit/8f7cca90af6e06daab4ce23cb0f894380ca7a6a1.diff

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; erichkeane wrote: > What about...? I doesn't

[PATCH] D128677: [clangd] Support #import insertions

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang,

[PATCH] D108469: Improve handling of static assert messages.

erichkeane added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; What about...? Repository: rG LLVM Github

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane added a comment. In D128667#3613222 , @MaskRay wrote: > `llvm-objcopy --decompress-debug-sections clang.zstd clang.zstd.uncompress` > doesn't work. > > % /tmp/out/custom1/bin/llvm-objcopy --decompress-debug-sections clang.zstd >

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; erichkeane wrote: > Something here that uses

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440354. cor3ntin added a comment. - Add release note - Address Erich's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/docs/ReleaseNotes.rst

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:161 +Region["endColumn"] = adjustColumnPos( +R.getEnd(), Lexer::MeasureTokenLength(R.getEnd().getLocWithOffset(0), + R.getEnd().getManager(), LO));

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille added inline comments. Comment at: clang/test/Sema/array-parameter.c:2 +// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -Warray-parameter -verify %s + +void f0(int a[]); aaron.ballman wrote: > aaron.ballman wrote: > > I'd like to

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 440352. serge-sans-paille marked 3 inline comments as done. serge-sans-paille added a comment. Take review into account + add C++ test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/ScopeInfo.h:77-78 - CompoundScopeInfo(bool IsStmtExpr) : IsStmtExpr(IsStmtExpr) {} + /// FP options at the beginning of the compound statement, prior to + /// any pragma. + FPOptions FPFeatures;

[PATCH] D128372: [Clang-Tidy] Empty Check

denik added a comment. Thanks for adding a check! Please check my comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:76 + +auto Methods = Arg->getType()->getAsCXXRecordDecl()->methods(); +auto Clear = llvm::find_if(Methods, [](const

[PATCH] D108469: Improve handling of static assert messages.

erichkeane added a comment. I'm generally OK with this. BUT Aaron/JF/Tom should review it. Comment at: clang/lib/Basic/Diagnostic.cpp:817 +if (isPrintable(*Begin) || isWhitespace(*Begin)) { + OutStr.push_back(*Begin); + ++Begin; OutStream <<

[clang] 6678f8e - [ubsan] Using metadata instead of prologue data for function sanitizer

Author: Yuanfang Chen Date: 2022-06-27T12:09:13-07:00 New Revision: 6678f8e505b19069a9dbdc3e3ee088d543752412 URL: https://github.com/llvm/llvm-project/commit/6678f8e505b19069a9dbdc3e3ee088d543752412 DIFF: https://github.com/llvm/llvm-project/commit/6678f8e505b19069a9dbdc3e3ee088d543752412.diff

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6678f8e505b1: [ubsan] Using metadata instead of prologue data for function sanitizer (authored by ychen). Repository: rG LLVM Github Monorepo

[clang] ae90bc8 - [clang][dataflow] Add `buildAndSubstituteFlowCondition` to `DataflowEnvironment`

Author: Wei Yi Tee Date: 2022-06-27T21:09:05+02:00 New Revision: ae90bc8467589cbc2079b93fae2b6ceec0821e27 URL: https://github.com/llvm/llvm-project/commit/ae90bc8467589cbc2079b93fae2b6ceec0821e27 DIFF: https://github.com/llvm/llvm-project/commit/ae90bc8467589cbc2079b93fae2b6ceec0821e27.diff

[PATCH] D128659: [clang][dataflow] Add `buildAndSubstituteFlowCondition` to `DataflowEnvironment`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae90bc846758: [clang][dataflow] Add `buildAndSubstituteFlowCondition` to `DataflowEnvironment` (authored by wyt, committed by gribozavr).

[PATCH] D128658: [clang][dataflow] Do not allow substitution of true/false boolean literals in `buildAndSubstituteFlowCondition`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa34210fa69f: [clang][dataflow] Do not allow substitution of true/false boolean literals in… (authored by wyt, committed by gribozavr). Repository:

[clang] fa34210 - [clang][dataflow] Do not allow substitution of true/false boolean literals in `buildAndSubstituteFlowCondition`

Author: Wei Yi Tee Date: 2022-06-27T21:04:52+02:00 New Revision: fa34210fa69f64a96dc64983b3de00ddd21e55e1 URL: https://github.com/llvm/llvm-project/commit/fa34210fa69f64a96dc64983b3de00ddd21e55e1 DIFF: https://github.com/llvm/llvm-project/commit/fa34210fa69f64a96dc64983b3de00ddd21e55e1.diff

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y marked an inline comment as not done. vaibhav.y added a comment. Comment isn't done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 ___ cfe-commits

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:161 +Region["endColumn"] = adjustColumnPos( +R.getEnd(), Lexer::MeasureTokenLength(R.getEnd().getLocWithOffset(0), + R.getEnd().getManager(), LO));

[PATCH] D128667: [WIP] Add Zstd ELF support

MaskRay added a comment. `llvm-objcopy --decompress-debug-sections clang.zstd clang.zstd.uncompress` doesn't work. % /tmp/out/custom1/bin/llvm-objcopy --decompress-debug-sections clang.zstd clang.zstd.uncompress /tmp/out/custom1/bin/llvm-objcopy: error: 'clang.zstd': '.debug_loc': zlib

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 440346. abrahamcd marked 7 inline comments as done. abrahamcd added a comment. Addressed review edits and clarity feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/

[PATCH] D128649: [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC

steplong updated this revision to Diff 440344. steplong added a comment. - Error for c also Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128649/new/ https://reviews.llvm.org/D128649 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440343. ckissane added a comment. improve style on ELFWriter::maybeWriteCompression fix typo in comment on zstd value for elf enum CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files:

[PATCH] D128256: [Clang][AArch64] Limit arm_locally_streaming to function definitions only.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9835-9839 + if (D.isFunctionDefinition()) { +NewFD->setWillHaveBody(); +ProcessDeclAttributes(S, NewFD, D); +NewFD->setWillHaveBody(false); + } else sdesmalen wrote: >

[PATCH] D128658: [clang][dataflow] Do not allow substitution of true/false boolean literals in `buildAndSubstituteFlowCondition`

wyt updated this revision to Diff 440341. wyt added a comment. Add assert message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128658/new/ https://reviews.llvm.org/D128658 Files: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp

  1   2   3   >