[PATCH] D129538: [clang] adds prototype for being able to alternate diagnostic formats

cjdb updated this revision to Diff 443833. cjdb added a comment. `arc diff` no longer seems to autoformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129538/new/ https://reviews.llvm.org/D129538 Files: clang/include/clang/Basic/Diagnostic.h

[PATCH] D129538: [clang] adds prototype for being able to alternate diagnostic formats

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In an effort to move from unstructured text diagnostics to structured diagnostics, while

[PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione updated this revision to Diff 443830. kastiglione added a comment. added error handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files: clang/include/clang/Frontend/FrontendActions.h

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

NoQ added a comment. Looks great! Maybe `clang_analyzer_range()` instead? Please add documentation to https://clang.llvm.org/docs/analyzer/developer-docs/DebugChecks.html Comment at: clang/test/Analysis/print-ranges.cpp:1 +// RUN: %clang_analyze_cc1

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6254 return false; if (TXTC->hasExplicitTemplateArgs() != TYTC->hasExplicitTemplateArgs()) return false; ilya-biryukov

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ChuanqiXu updated this revision to Diff 443823. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

jdoerfert created this revision. jdoerfert added a reviewer: tra. Herald added subscribers: mattd, bollu, yaxunl. Herald added a project: All. jdoerfert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A copy-paste error caused UB in the

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu added a comment. @erichkeane @ilya-biryukov gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. In D126907#3642530 , @erichkeane wrote: > This version passes check-runtimes, so libc++ is fine, and it passes > everything I have available. @ChuanqiXu : Would you be able to do 1 more run > over this to make sure it won't

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

ellis planned changes to this revision. ellis added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896 + if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone) +if (isProfileInstrExcluded(F, SourceLocation())) +

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen added a comment. In D129530#3644094 , @ChuanqiXu wrote: > In D129530#3644091 , @ychen wrote: > >> In D129530#3644074 , @ChuanqiXu >> wrote: >> >>> This looks good

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen updated this revision to Diff 443818. ychen added a comment. - Address Chuanqi's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129530/new/ https://reviews.llvm.org/D129530 Files: clang/test/CodeGenCoroutines/coro-attributes.cpp

[PATCH] D129534: [OpenMP] Do not link static library with `-nogpulib`

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tianshilei1992, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a

[PATCH] D129346: [X86] [Linux build][Stack Protector] Support for -mstack-protector-guard-symbol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa45dd3d8140e: [X86] Support -mstack-protector-guard-symbol (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber:

[clang] a45dd3d - [X86] Support -mstack-protector-guard-symbol

Author: Xiang1 Zhang Date: 2022-07-12T10:17:00+08:00 New Revision: a45dd3d8140eab78a4554484c2b0435582ee262a URL: https://github.com/llvm/llvm-project/commit/a45dd3d8140eab78a4554484c2b0435582ee262a DIFF: https://github.com/llvm/llvm-project/commit/a45dd3d8140eab78a4554484c2b0435582ee262a.diff

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D129530#3644091 , @ychen wrote: > In D129530#3644074 , @ChuanqiXu > wrote: > >> This looks good to

[clang] 6437862 - Revert "[X86] Support -mstack-protector-guard-symbol"

Author: Xiang1 Zhang Date: 2022-07-12T10:14:32+08:00 New Revision: 643786213b34c7bd971c14db63dfbae8bb979997 URL: https://github.com/llvm/llvm-project/commit/643786213b34c7bd971c14db63dfbae8bb979997 DIFF: https://github.com/llvm/llvm-project/commit/643786213b34c7bd971c14db63dfbae8bb979997.diff

[clang] efbaad1 - [X86] Support -mstack-protector-guard-symbol

Author: Xiang1 Zhang Date: 2022-07-12T10:13:48+08:00 New Revision: efbaad1c4a526e91b034e56386e98a9268cd87b2 URL: https://github.com/llvm/llvm-project/commit/efbaad1c4a526e91b034e56386e98a9268cd87b2 DIFF: https://github.com/llvm/llvm-project/commit/efbaad1c4a526e91b034e56386e98a9268cd87b2.diff

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen added a comment. In D129530#3644074 , @ChuanqiXu wrote: > This looks good to me basically. I would love to see an example to test the > two coro.save wouldn't be merged. Yep, `hoist-skip-token.ll` is testing this. Repository: rG LLVM Github

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ChuanqiXu added a comment. This looks good to me basically. I would love to see an example to test the two coro.save wouldn't be merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129530/new/ https://reviews.llvm.org/D129530

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

dblaikie added a comment. > hmm there seems to be a compiler error, which looks somewhat unrelated to the > active patch: > > > /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/cross-project-tests/debuginfo-tests/clang_llvm_roundtrip/simplified_template_names.cpp:125:27: > error:

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

dblaikie added a subscriber: JDevlieghere. dblaikie added a comment. In D125693#3641742 , @krisb wrote: > @dblaikie, could you please take a look at this and/or D113741 > ? Do you see any ways to proceed? My concern

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 443812. ZarkoCA added a comment. - Rebase and add FDecl check before calling checkAIXMemberAlignment() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files:

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3644022 , @thakis wrote: > This breaks check-clang on mac: http://45.33.8.238/macm1/39907/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Let me know if rGfe6a391357fc

[clang] fe6a391 - [Clang] Fix tests failing due to invalid syntax for host triple

Author: Joseph Huber Date: 2022-07-11T21:31:56-04:00 New Revision: fe6a391357fcf0823a97a9a3814572655c3b3b74 URL: https://github.com/llvm/llvm-project/commit/fe6a391357fcf0823a97a9a3814572655c3b3b74 DIFF: https://github.com/llvm/llvm-project/commit/fe6a391357fcf0823a97a9a3814572655c3b3b74.diff

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3644022 , @thakis wrote: > This breaks check-clang on mac: http://45.33.8.238/macm1/39907/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I changed some of the argument formats in a

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

thakis added a comment. This breaks check-clang on mac: http://45.33.8.238/macm1/39907/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128914/new/

[PATCH] D127304: [LinkerWrapper] Embed OffloadBinaries for OpenMP offloading images

jhuber6 updated this revision to Diff 443810. jhuber6 added a comment. Removing `.image` from section name. This was originally done to avoid it getting the `SHF_EXCLUDE` flag when it should not be removed by the linker. That behaviour was moved to the `!exclude` metadata in a previous patch.

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen created this revision. ychen added reviewers: nikic, ChuanqiXu. Herald added subscribers: jdoerfert, hiraditya. Herald added a project: All. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. It is illegal to

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. I was busy with other stuff. I will take a look at it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 ___ cfe-commits mailing list

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. In D105255#3643428 , @clementval wrote: > Why not adding the assembly format directly for these operations like your > patch D105584 ? OK, I will do it! Repository: rG LLVM

[clang] fe3780f - [DependencyScanningTool.cpp] Use `using namespace` instead of wrapping the `.cpp` file contents in namespaces, NFC

Author: Argyrios Kyrtzidis Date: 2022-07-11T17:44:17-07:00 New Revision: fe3780f32ae81187e0700e52bd551cc02c7a63b4 URL: https://github.com/llvm/llvm-project/commit/fe3780f32ae81187e0700e52bd551cc02c7a63b4 DIFF:

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3643802 , @tra wrote: > For what it's worth, NCCL is the only > nontrivial library that needs RDC compilation that I'm aware of. > It's also self-contained for RDC purposes we only

[PATCH] D128048: Add a new clang option "-ftime-trace="

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2831 MarshallingInfoInt, "500u">; +def ftime_trace_path : Joined<["-"], "ftime-trace=">, Group, + HelpText<"Turn on time profiler. Generates JSON file based on output filename. "

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3853 +/// objcMessageExpr(objcMessageCallee(objcMethodDecl(hasName("foo" +AST_MATCHER_P(ObjCMessageExpr, objcMessageCallee, + internal::Matcher, InnerMatcher) {

[PATCH] D128712: [clang-format] Handle Verilog modules

sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4072 +Keywords.kw_randsequence)) { +AddLevels += Style.IndentCaseLabels; +nextToken();

[PATCH] D128712: [clang-format] Handle Verilog modules

sstwcw updated this revision to Diff 443791. sstwcw added a comment. - take out check - use boolean as boolean Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128712/new/ https://reviews.llvm.org/D128712 Files: clang/lib/Format/FormatToken.h

[PATCH] D129524: [Lex/HeaderSearch] Only lookup `HeaderFileInfo` for a `FileEntry` from `ExternalSource` once

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without marking the `HeaderFileInfo` as resolved the `FileEntries` of files that were not found in `ExternalSource` are

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

tra added a comment. In D128914#3643495 , @jhuber6 wrote: > Yes, it's actually pretty difficult to find a CUDA application using > `fgpu-rdc`. It seems much more common to just stick everything that's needed > in the file.I've considered finding a CUDA

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5184 - // FIXME: This mimics what GCC implements, but doesn't match up with the - // proposed resolution for core issue 692. This area needs to be sorted out, ychen wrote: >

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2488 +bool XHasMoreArg = X.pack_size() > Y.pack_size(); +if (!(XHasMoreArg && X.pack_elements().back().isPackExpansion()) && +!(!XHasMoreArg &&

[PATCH] D129504: [libclang][ObjC] Inherit availability attribute from containing decls or interface decls

benlangmuir added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:8271 +else if (auto *IMD = dyn_cast(D)) + CD = IMD->getCategoryDecl(); +else if (auto *ID = dyn_cast(DC)) So this goes Impl -> Class, and CategoryImpl -> Category.

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 443772. Herald added subscribers: usaxena95, kadircet, arphaman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files:

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen updated this revision to Diff 443771. ychen marked an inline comment as done. ychen added a comment. - fix a bug - update comments - check-all, check-runtimes pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/CMakeLists.txt:21 + +include(ProtobufMutator) +include_directories(${ProtobufMutator_INCLUDE_DIRS}) Commenting out this line causes the project to generate, but I

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Herald added a subscriber: JDevlieghere. In D111509#3168178 , @shafik wrote: > llvm-lit -sv lldb/test --filter TestScalarURem.py > > The change looks expected. Thanks for letting me know. Unfortunately that test is not

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 443769. Herald added subscribers: lldb-commits, Enna1. Herald added projects: LLDB, All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 443768. cassanova added a comment. Shows top-of-tree changes, however CMake generation fails that the ProtobufMutator target already exists for clang-fuzzer: CMake Error at

[PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione added a comment. @JDevlieghere I had it as `dump pcm` at first, but switched it to `pcm-info` for two reasons 1. it doesn't dump the whole pcm, the actual ast itself is not dumped 2. to match the clang flag `-module-file-info` I agree that `pcm` is better, but I was worried it

[PATCH] D129512: [Driver] Don't use frame pointer on Fuchsia when optimizations are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ed8d8209584: [Driver] Dont use frame pointer on Fuchsia when optimizations are enabled (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0ed8d82 - [Driver] Don't use frame pointer on Fuchsia when optimizations are enabled

Author: Petr Hosek Date: 2022-07-11T21:45:42Z New Revision: 0ed8d8209584daa5ff30aae51b5396d05d7aa997 URL: https://github.com/llvm/llvm-project/commit/0ed8d8209584daa5ff30aae51b5396d05d7aa997 DIFF: https://github.com/llvm/llvm-project/commit/0ed8d8209584daa5ff30aae51b5396d05d7aa997.diff LOG:

[PATCH] D129456: [lldb] Add image dump pcm-info command

JDevlieghere added a comment. [bikeshedding] `pcm-info` seems a little odd. Do we have other command that end with `-info`? `target modules dump` already sounds like you're about to dump some kind of "info". What about just `pcm`? [/bikeshedding] Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

benlangmuir updated this revision to Diff 443755. benlangmuir added a comment. Updates per review - Switched to a per-output callback - Removed preserved-args.c test - Removed error handling that I no longer have a real use for - Only request .d and .diag paths if they were enabled in the

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen updated this revision to Diff 443756. ychen added a comment. - handle more cases to implement DR692, DR1395 - tentatively implement DR1432 which DR692 needs, otherwise there would be regressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

rnk added subscribers: arphaman, dexonsmith. rnk added a comment. Seeking additional opinions on the PCH change: @dexonsmith @arphaman The use case makes sense to me. It seems reasonable to me that the compiler shouldn't use the same PCH file with mismatched defines on the command line.

[PATCH] D128411: [syntax] Introduce a BaseToken class.

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:370 + TreeBuilder(syntax::Arena ) + : Arena(Arena), STM(cast(Arena.getTokenManager())), +Pending(Arena, STM.tokenBuffer()) { hokein wrote: > sammccall wrote: > >

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

benlangmuir marked an inline comment as done. benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:55 + getCommandLine(llvm::function_ref< + Expected(const ModuleID &)> +

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 443749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[clang] c7fd751 - Revert "[C++20][Modules] Update handling of implicit inlines [P1779R3]"

Author: Jonas Devlieghere Date: 2022-07-11T13:59:41-07:00 New Revision: c7fd7512a5c5b133665bfecbe2e9748c0607286e URL: https://github.com/llvm/llvm-project/commit/c7fd7512a5c5b133665bfecbe2e9748c0607286e DIFF:

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3643451 , @yaxunl wrote: > If you only unregister fatbin once for the whole program, then it should be > safe -fgpu-rdc. I am not sure if that is the case. it should be here, the generated handle is private to the

[PATCH] D129514: Thread safety analysis: Support builtin pointer-to-member operators

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. Herald added a reviewer: NoQ. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We consider an access to x.*pm as

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

yaxunl added a comment. In D128914#3643270 , @jhuber6 wrote: >> There is only one fatbin for -fgpu-rdc mode but the fatbin unregister >> function is called multiple times in each TU. HIP runtime expects each >> fatbin is unregistered only once. The old

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + aaron.ballman wrote: > royjacobson wrote: > >

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson updated this revision to Diff 443742. royjacobson added a comment. Warn on <=C++03 as well, warn on __has_trivial_destructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129170/new/ https://reviews.llvm.org/D129170 Files:

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

clementval added a comment. Why not adding the assemblyFormat directly for these operations like your patch D105584 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ https://reviews.llvm.org/D105255

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

clementval added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:449 ParentOneOf<["WsLoopOp", "ReductionDeclareOp", - "AtomicUpdateOp", "SimdLoopOp"]>]> { + "AtomicUpdateOp", "SimdLoopOp","DistributeOp"]>]> { let summary = "loop yield

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/SyntaxTokenManager.h:20 +/// It tracks the underlying token buffers, source manager, etc. +class SyntaxTokenManager : public TokenManager { +public: sammccall wrote: > I don't think

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein updated this revision to Diff 443737. hokein added a comment. more update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128411/new/ https://reviews.llvm.org/D128411 Files: clang/include/clang/Tooling/Syntax/Mutations.h

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein updated this revision to Diff 443736. hokein marked 7 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128411/new/ https://reviews.llvm.org/D128411 Files:

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

efriedma added a comment. Are you saying that it's faster to use clasta targeting a float register, then move the result to an integer register, rather than use the integer form directly? Or is the issue just that we want to split the operations in case we can simplify the resulting bitcast?

[PATCH] D129512: [Driver] Don't use frame pointer on Fuchsia when optimizations are enabled

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm but be sure that Fuchsia target users get clear release-notes warning about the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 443734. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D129512: [Driver] Don't use frame pointer on Fuchsia when optimizations are enabled

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This matches the standard behavior on other

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11551-11552 +if (Unqualified && !Ctx.hasSameType(X, Y)) { + assert(Ctx.hasSameUnqualifiedType(X, Y)); + auto XQuals = X.getCVRQualifiers(), YQuals = Y.getCVRQualifiers(); +

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 443731. mizvekov marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files:

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek updated this revision to Diff 443729. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D88299 Files: clang/lib/Format/CMakeLists.txt

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 443726. sridhar_gopinath added a comment. Replaced subprocess.check_call with subprocess.call since the former crashes when the return code is not zero. + formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128709: [clang-format] Handle Verilog attributes

owenpan accepted this revision. owenpan added a comment. Can you mark D128709#3617654 as done? Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1466-1471 + } else if (FormatTok->is(tok::l_paren)) { +const FormatToken

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce091eb3b91f: [HIP] Add support for handling HIP in the linker wrapper (authored by jhuber6). Changed prior to commit:

[PATCH] D128850: [HIP] Generate offloading entries for HIP with the new driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe88d53d25f3b: [HIP] Generate offloading entries for HIP with the new driver. (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ce091eb - [HIP] Add support for handling HIP in the linker wrapper

Author: Joseph Huber Date: 2022-07-11T15:49:23-04:00 New Revision: ce091eb3b91fc683513f47a565d68cf2799804c9 URL: https://github.com/llvm/llvm-project/commit/ce091eb3b91fc683513f47a565d68cf2799804c9 DIFF: https://github.com/llvm/llvm-project/commit/ce091eb3b91fc683513f47a565d68cf2799804c9.diff

[clang] e88d53d - [HIP] Generate offloading entries for HIP with the new driver.

Author: Joseph Huber Date: 2022-07-11T15:49:21-04:00 New Revision: e88d53d25f3b48204615195615da35e575081903 URL: https://github.com/llvm/llvm-project/commit/e88d53d25f3b48204615195615da35e575081903 DIFF: https://github.com/llvm/llvm-project/commit/e88d53d25f3b48204615195615da35e575081903.diff

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek marked 7 inline comments as done. klimek added inline comments. Comment at: clang/lib/Format/Macros.h:201 + /// Generally, this line tries to have the same structure as the expanded, + /// formatted unwrapped lines handed in via \c addLine(), with the exception + ///

[PATCH] D128712: [clang-format] Handle Verilog modules

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4040 +void UnwrappedLineParser::parseVerilogSensitivityList() { + if (!FormatTok->is(tok::at)) +return; I prefer to make such checks before calling the function.

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

This revision was automatically updated to reflect the committed changes. Closed by commit rG359e4a824731: [Clang] Parse toolchain-specific offloading arguments directly (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 359e4a8 - [Clang] Parse toolchain-specific offloading arguments directly

Author: Joseph Huber Date: 2022-07-11T15:37:50-04:00 New Revision: 359e4a8247316c2f0c21072919836fd9fd4cf0f1 URL: https://github.com/llvm/llvm-project/commit/359e4a8247316c2f0c21072919836fd9fd4cf0f1 DIFF: https://github.com/llvm/llvm-project/commit/359e4a8247316c2f0c21072919836fd9fd4cf0f1.diff

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. Thanks for the patch. Please add the full context for the next revision: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3642869 , @yaxunl wrote: > In D128914#3642567 , @jhuber6 wrote: > >> In D128914#3642558 , >> @JonChesterfield wrote: >> >>> Code

[PATCH] D129404: Change default C dialect for PS5 to gnu17/gnu18.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129404/new/ https://reviews.llvm.org/D129404

[PATCH] D128672: Update DynInit generation for ASan globals.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf18de7619e5d: Update DynInit generation for ASan globals. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/

[clang] f18de76 - Update DynInit generation for ASan globals.

Author: Mitch Phillips Date: 2022-07-11T12:23:37-07:00 New Revision: f18de7619e5d5dde301d8d4f6f3ec0f8260be710 URL: https://github.com/llvm/llvm-project/commit/f18de7619e5d5dde301d8d4f6f3ec0f8260be710 DIFF:

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 443708. abidmalikwaterloo added a comment. Update ops.mlir test cases. llvm-lit is working and all tests are passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. I need to do some more builds to be able to reproduce this - my guess (at present) is that this is a manifestation of '-fcxx-modules -std=c++20' being almost, but not exactly, the same as C++20 standardised modules. It is possible that the -gmodules flag interacts with

[PATCH] D129298: Add denormal-fp-math attribute for f16

arsenm added a comment. In D129298#3638759 , @dcandler wrote: > There are currently no Arm specific changes, this is just being able to more > accurately describe the floating point environment via attributes in the case > where singles and doubles

[clang] b19d3ee - Revert "[C++20][Modules] Build module static initializers per P1874R1."

Author: Iain Sandoe Date: 2022-07-11T19:50:31+01:00 New Revision: b19d3ee7120bff4a84db7c9fa8f86c9b6ec3b1cf URL: https://github.com/llvm/llvm-project/commit/b19d3ee7120bff4a84db7c9fa8f86c9b6ec3b1cf DIFF: https://github.com/llvm/llvm-project/commit/b19d3ee7120bff4a84db7c9fa8f86c9b6ec3b1cf.diff

[clang] e7c8ded - Revert "[C++20][Modules] Fix two tests for CTORs that return pointers [NFC]."

Author: Iain Sandoe Date: 2022-07-11T19:49:48+01:00 New Revision: e7c8ded6df6d38b019a1de268535d2dd73e7adaf URL: https://github.com/llvm/llvm-project/commit/e7c8ded6df6d38b019a1de268535d2dd73e7adaf DIFF: https://github.com/llvm/llvm-project/commit/e7c8ded6df6d38b019a1de268535d2dd73e7adaf.diff

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

kees added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:906 // member, only a T[0] or T[] member gets that treatment. + // Under StrictFlexArraysLevel, obey c99+ that disallows FAM in union, see + // C11 6.7.2.1 §18 jyknight wrote:

[PATCH] D128672: Update DynInit generation for ASan globals.

hctim updated this revision to Diff 443702. hctim marked an inline comment as done. hctim added a comment. Integrate Vitaly's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/ https://reviews.llvm.org/D128672 Files:

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3853 +/// objcMessageExpr(objcMessageCallee(objcMethodDecl(hasName("foo" +AST_MATCHER_P(ObjCMessageExpr, objcMessageCallee, + internal::Matcher, InnerMatcher) {

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

JDevlieghere added a comment. In D126189#3643045 , @iains wrote: > In D126189#3643021 , @JDevlieghere > wrote: > >> In D126189#3643001 , @iains wrote: >> >>> In

  1   2   >