[clang] 3b0dce5 - Use value_or (NFC)

Author: Kazu Hirata Date: 2022-07-15T19:46:29-07:00 New Revision: 3b0dce5b8b1596c50360952a8fb031d52562ccf6 URL: https://github.com/llvm/llvm-project/commit/3b0dce5b8b1596c50360952a8fb031d52562ccf6 DIFF: https://github.com/llvm/llvm-project/commit/3b0dce5b8b1596c50360952a8fb031d52562ccf6.diff

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 445172. omarahmed added a comment. Change removes to remove Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D129466: [clang-format][NFC] Replace most of std::vector with SmallVector

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:40 static unsigned getLengthToMatchingParen(const FormatToken , - const std::vector ) { + const SmallVector ) {

[PATCH] D129912: [Tooling/DependencyScanning] Enable passing a `vfs::FileSystem` object to `DependencyScanningTool`

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also include a unit test to validate that the `vfs::FileSystem` object is properly used. Repository: rG LLVM Github

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/test/SemaHLSL/cbuffer_tbuffer.hlsl:1 +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -ast-dump -o - %s | FileCheck %s + beanz wrote: > This

[clang] a7789d6 - [clang-format][NFC] Replace SmallVector parameter with ArrayRef

Author: owenca Date: 2022-07-15T17:26:22-07:00 New Revision: a7789d6315ff663fb5e21698264b7b77e89312fe URL: https://github.com/llvm/llvm-project/commit/a7789d6315ff663fb5e21698264b7b77e89312fe DIFF: https://github.com/llvm/llvm-project/commit/a7789d6315ff663fb5e21698264b7b77e89312fe.diff LOG:

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae updated this revision to Diff 445162. python3kgae added a comment. Code cleanup and add test for error case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/ https://reviews.llvm.org/D129883 Files:

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

isuckatcs added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:157 "Storage provided to placement new is only {0} bytes, " -"whereas the allocated array type requires more space for " -"internal needs", -

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 added a comment. In D128401#3656559 , @NoQ wrote: > Looks great, thanks! > > Yes, I think refactoring can be done in a follow-up patch. Thank you, @NoQ! Let me politely ping the rest of the commenters: @LegalizeAdulthood, @gribozavr2,

[clang] 46a6989 - [unittests/Tooling/DependencyScannerTest.cpp] Use `using namespace` instead of wrapping the `.cpp` file contents in namespaces, NFC

Author: Argyrios Kyrtzidis Date: 2022-07-15T16:10:36-07:00 New Revision: 46a69897364354c9ffcfb1f5f2341e675898d116 URL: https://github.com/llvm/llvm-project/commit/46a69897364354c9ffcfb1f5f2341e675898d116 DIFF:

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

NoQ accepted this revision. NoQ added a comment. Looks great, thanks! Yes, I think refactoring can be done in a follow-up patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 ___ cfe-commits

[PATCH] D129885: [CUDA] Make the new driver properly ignore non-CUDA inputs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb957a8d524c: [CUDA] Make the new driver properly ignore non-CUDA inputs (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[clang] bb957a8 - [CUDA] Make the new driver properly ignore non-CUDA inputs

Author: Joseph Huber Date: 2022-07-15T17:38:34-04:00 New Revision: bb957a8d524cd38d6c5f7d547302258026049438 URL: https://github.com/llvm/llvm-project/commit/bb957a8d524cd38d6c5f7d547302258026049438 DIFF: https://github.com/llvm/llvm-project/commit/bb957a8d524cd38d6c5f7d547302258026049438.diff

[PATCH] D129504: [libclang][ObjC] Inherit availability attribute from containing decls or interface decls

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129504/new/ https://reviews.llvm.org/D129504

[PATCH] D129504: [libclang][ObjC] Inherit availability attribute from containing decls or interface decls

ahatanak updated this revision to Diff 445130. ahatanak marked an inline comment as done. ahatanak added a comment. If a category decl doesn't have availability, inherit it from the class decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129892: [clang-format] Fix aligning of trailing comments after comment at the end of a namespace

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17468-17470 + "// Lorem ipsum dolor sit amet, consectetur adipiscing elit. " + "Nullam cursus nunc\n" + "// non", Shouldn't this

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

beanz added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2820 SourceLocation *EndLoc = nullptr); + Decl *ParseCTBuffer(SourceLocation , + SourceLocation InlineLoc = SourceLocation()); nit: maybe

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif for SARIF diagnostics

vaibhav.y added a comment. Might be worth hiding it from `--help`, despite the instability warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886 ___

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

mstorsjo added subscribers: phosek, hans, thakis, rnk. mstorsjo added a comment. In D121141#3655323 , @ldionne wrote: > The `experimental-library-flag` test is currently failing on Windows because > on Windows, `-stdlib=libc++` seems to be ignored and

[PATCH] D129892: Fix aligning of trailing comments after comment at the end of a namespace

eoanermine created this revision. eoanermine added reviewers: owenpan, HazardyKnusperkeks, curdeius, MyDeveloperDay. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Fix aligning

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

aaron.ballman created this revision. aaron.ballman added reviewers: fhahn, erichkeane, jroelofs. Herald added subscribers: kristof.beyls, mgorny. Herald added a project: All. aaron.ballman requested review of this revision. This updates the test suite to ignore `-Wint-conversion` warnings which

[clang] 5b8337c - [syntax] Some #includes cleanup, NFC.

Author: Haojian Wu Date: 2022-07-15T21:05:59+02:00 New Revision: 5b8337cf402b224c5ed310dc570aa471dcdbd116 URL: https://github.com/llvm/llvm-project/commit/5b8337cf402b224c5ed310dc570aa471dcdbd116 DIFF: https://github.com/llvm/llvm-project/commit/5b8337cf402b224c5ed310dc570aa471dcdbd116.diff

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif for SARIF diagnostics

cjdb added a comment. Thanks for getting this started! To get this ready for submission, would you be able to add a test please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

rjmccall added a comment. This property adheres to a function definition, so it seems to me that an explicit *instantiation* ought to preserve it from the instantiated template definition, but an explicit *specialization* ought to be independent. i.e. #pragma float_control(precise, on,

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 added a comment. Thanks @aaron.ballman , I plan to commit this patch on Monday (18th July 2022). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129398/new/ https://reviews.llvm.org/D129398 ___ cfe-commits mailing list

[PATCH] D129885: [CUDA] Make the new driver properly ignore non-CUDA inputs

jhuber6 updated this revision to Diff 445087. jhuber6 added a comment. Adjusting tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129885/new/ https://reviews.llvm.org/D129885 Files: clang/lib/Driver/Driver.cpp

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8483 +if ((SemaRef.getLangOpts().CPlusPlus && Trap.hasErrorOccurred()) || +Res.isInvalid()) return ExprError(); aaron.ballman wrote: > efriedma wrote: > > I'd

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

ASDenysPetrov closed this revision. ASDenysPetrov added a comment. Closed with bc08c3cb7f8e797fee14e96eedd3dc358608ada3 Comment at: clang/test/Analysis/print-ranges.cpp:1 +// RUN: %clang_analyze_cc1

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman updated this revision to Diff 445086. aaron.ballman added a comment. Removed the SFINAEFailure and trap changes, added a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 Files:

[PATCH] D129885: [CUDA] Make the new driver properly ignore non-CUDA inputs

MaskRay added inline comments. Comment at: clang/test/Driver/cuda-phases.cu:270 + +// RUN: %clang -### -target powerpc64le-ibm-linux-gnu -ccc-print-phases --offload-new-driver \ +// RUN: --offload-arch=sm_52 --offload-arch=sm_70 %s %S/Inputs/empty.cpp 2>&1 | FileCheck

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif for SARIF diagnostics

abrahamcd updated this revision to Diff 445077. abrahamcd retitled this revision from "Adds `-fdiagnostics-format=sarif` flag option and warning." to "[clang] Add -fdiagnostics-format=sarif for SARIF diagnostics". abrahamcd edited the summary of this revision. abrahamcd added a comment. Commit

[PATCH] D129885: [CUDA] Make the new driver properly ignore non-CUDA inputs

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129885/new/ https://reviews.llvm.org/D129885 ___

[PATCH] D129886: Adds `-fdiagnostics-format=sarif` flag option and warning.

abrahamcd updated this revision to Diff 445073. abrahamcd added a comment. Edited commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886 Files:

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8483 +if ((SemaRef.getLangOpts().CPlusPlus && Trap.hasErrorOccurred()) || +Res.isInvalid()) return ExprError(); efriedma wrote: > I'd prefer not to introduce

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67357739c6d3: [AMDGPU] Add remarks to output some resource usage (authored by vangthao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 6735773 - [AMDGPU] Add remarks to output some resource usage

Author: Vang Thao Date: 2022-07-15T11:01:53-07:00 New Revision: 67357739c6d36a61972c1fc0e829e35cb5375279 URL: https://github.com/llvm/llvm-project/commit/67357739c6d36a61972c1fc0e829e35cb5375279 DIFF: https://github.com/llvm/llvm-project/commit/67357739c6d36a61972c1fc0e829e35cb5375279.diff

[PATCH] D129886: Adds `-fdiagnostics-format=sarif` flag option and warning.

abrahamcd created this revision. Herald added a project: All. abrahamcd requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129886 Files:

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

efriedma added a comment. Given this is an on-by-default warning already, I don't expect changing it to an error by default to have much impact in practice. Changing it fine. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8483 +if ((SemaRef.getLangOpts().CPlusPlus &&

[PATCH] D129885: [CUDA] Make the new driver properly ignore non-CUDA inputs

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new driver

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

erichkeane added a comment. This seems like a good idea despite the breaking change. I dont see anything in the code to be concerned about, but I'm hoping others will comment as to whether this is completely acceptable. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8482

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese, akyrtzi. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "strict context hash" is insufficient to

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae created this revision. python3kgae added reviewers: svenvh, asavonic, beanz, pow2clk, Anastasia, aaron.ballman. Herald added a subscriber: mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson marked an inline comment as done. royjacobson added inline comments. Comment at: clang/test/AST/conditionally-trivial-smfs.cpp:39 + +template struct DefaultConstructorCheck<2>; +// CHECK: "kind": "ClassTemplateSpecializationDecl", BRevzin

[PATCH] D129832: [sanitizer] Add "mainfile" prefix to sanitizer special case list

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d5a62faca59: [sanitizer] Add mainfile prefix to sanitizer special case list (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES

[clang] 0d5a62f - [sanitizer] Add "mainfile" prefix to sanitizer special case list

Author: Fangrui Song Date: 2022-07-15T10:39:26-07:00 New Revision: 0d5a62faca5924c5a197faa946b5b78b3d80a0b2 URL: https://github.com/llvm/llvm-project/commit/0d5a62faca5924c5a197faa946b5b78b3d80a0b2 DIFF: https://github.com/llvm/llvm-project/commit/0d5a62faca5924c5a197faa946b5b78b3d80a0b2.diff

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman created this revision. aaron.ballman added reviewers: efriedma, jyknight, erichkeane, clang-language-wg. Herald added subscribers: steakhal, Enna1, kosarev, arphaman, jvesely. Herald added a project: All. aaron.ballman requested review of this revision. Herald added projects: clang,

[PATCH] D129832: [sanitizer] Add "mainfile" prefix to sanitizer special case list

MaskRay updated this revision to Diff 445051. MaskRay retitled this revision from "[sanitizer] Add "mainsrc" prefix to sanitizer special case list" to "[sanitizer] Add "mainfile" prefix to sanitizer special case list". MaskRay edited the summary of this revision. MaskRay added a comment.

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. "unit:" ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129832/new/ https://reviews.llvm.org/D129832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. I guess Kirills' complain is about **main** part, not **src**. But I have no idea what name could be better. I guess thechnically it's preprocessed src? :) To me as is name is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

BRevzin added inline comments. Comment at: clang/test/AST/conditionally-trivial-smfs.cpp:39 + +template struct DefaultConstructorCheck<2>; +// CHECK: "kind": "ClassTemplateSpecializationDecl", royjacobson wrote: > BRevzin wrote: > > It's possible

[PATCH] D129835: [clang] adds a discardable attribute

aaron.ballman added a comment. In D129835#3655548 , @cjdb wrote: > In D129835#3655487 , @aaron.ballman > wrote: > >>> When we have a function that can have its value discarded, we can use >>>

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson marked 4 inline comments as done and an inline comment as not done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17960-17961 +} +if (AnotherMethodIsMoreConstrained) + break; + } cor3ntin

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 445044. royjacobson edited the summary of this revision. royjacobson added a comment. Address Corentin's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619

[clang] bc08c3c - [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

Author: Denys Petrov Date: 2022-07-15T20:07:04+03:00 New Revision: bc08c3cb7f8e797fee14e96eedd3dc358608ada3 URL: https://github.com/llvm/llvm-project/commit/bc08c3cb7f8e797fee14e96eedd3dc358608ada3 DIFF: https://github.com/llvm/llvm-project/commit/bc08c3cb7f8e797fee14e96eedd3dc358608ada3.diff

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

ASDenysPetrov added a comment. @manas I'm sorry but it seems like I brought you a new work :-) I've just loaded these two patches (D129678 and D129498 ) and now you have to rebase your changes. But there is a good news as

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added a comment. Gentle ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

tahonermann added a comment. I'm not following what the root problem is. You stated: > When we write the attribute preferred_name(foo) in ASTWriter, the compiler > would try to write the type for the argument foo. Then when the compiler > write the type for foo, the compiler find the type for

[PATCH] D129835: [clang] adds a discardable attribute

cjdb added a subscriber: ldionne. cjdb added a comment. In D129835#3655487 , @aaron.ballman wrote: >> When we have a function that can have its value discarded, we can use >> [[clang::discardable]] to indicate that the `[[nodiscard]]` attribute should

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

MaskRay added a comment. In D129832#3654436 , @vitalybuka wrote: > The patch is LGTM, but please consider to keep an ignorelist limited. Thanks! In D129832#3655393 , @kstoimenov wrote: > I think the name

[PATCH] D129678: [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer

This revision was automatically updated to reflect the committed changes. Closed by commit rG82f76c04774f: [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 82f76c0 - [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer

Author: Denys Petrov Date: 2022-07-15T19:24:57+03:00 New Revision: 82f76c04774fbeb2313b84932afac478f010c8d0 URL: https://github.com/llvm/llvm-project/commit/82f76c04774fbeb2313b84932afac478f010c8d0 DIFF: https://github.com/llvm/llvm-project/commit/82f76c04774fbeb2313b84932afac478f010c8d0.diff

[PATCH] D129835: [clang] adds a discardable attribute

aaron.ballman added a comment. > When we have a function that can have its value discarded, we can use > [[clang::discardable]] to indicate that the `[[nodiscard]]` attribute should > be ignored. Alternatively, you can scope the pragma and declarations appropriately and then we don't need to

[PATCH] D129305: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129305/new/ https://reviews.llvm.org/D129305

[PATCH] D129304: [clang-offload-bundler] Library-ize ClangOffloadBundler (3/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129304/new/ https://reviews.llvm.org/D129304

[PATCH] D129303: [clang-offload-bundler] Library-ize ClangOffloadBundler (2/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129303/new/ https://reviews.llvm.org/D129303

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a reviewer: jdoerfert. Herald added a

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 created this revision. jyu2 added reviewers: ddpagan, ABataev, mikerice. jyu2 added projects: clang, OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers:

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

kstoimenov accepted this revision. kstoimenov added a comment. I think the name 'mainsrc' is slightly misleading because of the association with the 'main' function. Maybe something like primarysrc would be better to avoid this confusion? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128048: Add a new clang option "-ftime-trace="

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5d9de8cc330: [Clang] Add a new clang option -ftime-trace=value (authored by dongjunduo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/

[clang] f5d9de8 - [Clang] Add a new clang option "-ftime-trace="

Author: dongjunduo Date: 2022-07-15T08:55:17-07:00 New Revision: f5d9de8cc33014923fbd1c5682758557887e85ba URL: https://github.com/llvm/llvm-project/commit/f5d9de8cc33014923fbd1c5682758557887e85ba DIFF: https://github.com/llvm/llvm-project/commit/f5d9de8cc33014923fbd1c5682758557887e85ba.diff

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

ldionne added a subscriber: mstorsjo. ldionne added a comment. The `experimental-library-flag` test is currently failing on Windows because on Windows, `-stdlib=libc++` seems to be ignored and we don't add `-lc++` or `-lc++experimental`. Does someone understand how things are supposed to work

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 445002. usaxena95 added a comment. Removed unused headers and fix spellings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files:

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne added inline comments. Comment at: clang/include/clang/Driver/Options.td:1186 -defm unstable : BoolFOption<"unstable", - LangOpts<"Unstable">, DefaultFalse, - PosFlag, +defm experimental_library : BoolFOption<"experimental-library", +

[PATCH] D129864: [Flang] Generate documentation for compiler flags

DylanFleming-arm created this revision. Herald added subscribers: arphaman, mgorny. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. DylanFleming-arm requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

Mordante accepted this revision. Mordante added a comment. LGTM, but please update the name of the flag in the title before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121141/new/ https://reviews.llvm.org/D121141

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains updated this revision to Diff 444989. iains added a comment. rebased, fixed the interaction with clang module map modules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 Files:

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains reopened this revision. iains added a comment. This revision is now accepted and ready to land. reopening to post the patch I intend to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5444 + if (Better1 && Better2) { +bool ClangABICompat14 = S.Context.getLangOpts().getClangABICompat() <= +

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

hokein updated this revision to Diff 444976. hokein added a comment. rebase and address the main comment -- encoding the function-declarator into the grammar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129222/new/

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:185 +if (auto *Paired = Tok.pair()) { + if (Tok.Line < Paired->Line) { +Position Start = offsetToPosition( hokein wrote: > The `if` logic seems tricky,

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 444975. usaxena95 marked 15 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files:

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

chrish_ericsson_atx added a comment. In D112374#3653967 , @JDevlieghere wrote: > I don't. I think reverting your change was well within the guidelines > outlined by LLVM's patch reversion policy: >

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

quinnp created this revision. Herald added subscribers: steven.zhang, shchenz, kbarton, nemanjai. Herald added a project: All. quinnp requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch changes the default linker for `clang`

[PATCH] D129359: [pseudo] Generate an enum type for identifying grammar rules.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/grammar/Grammar.cpp:48 +std::string Grammar::mangleSymbol(SymbolID SID) const { + static const char *const TokNames[] = { hokein wrote: > sammccall wrote: > > I'm not sure exposing

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

BRevzin added inline comments. Comment at: clang/test/AST/conditionally-trivial-smfs.cpp:39 + +template struct DefaultConstructorCheck<2>; +// CHECK: "kind": "ClassTemplateSpecializationDecl", It's possible that I just don't understand what these

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

Wilco1 added a comment. The general requirement is that inline and outline atomics have identical behaviour, and that GCC and LLVM emit the same sequences. I agree __sync is badly documented, so it's hard to figure whether an extra DMB barrier could actually make a difference, but it's best to

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

iains updated this revision to Diff 444965. iains added a comment. rebased, fixed interaction with clang modules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129045/new/ https://reviews.llvm.org/D129045 Files: clang/lib/AST/TextNodeDumper.cpp

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

iains reopened this revision. iains added a comment. This revision is now accepted and ready to land. reopening to post the patch I plan to re-land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129045/new/ https://reviews.llvm.org/D129045

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM assuming precommit CI comes back happy with it, thank you! I'll land it once I see things are green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129280/new/ https://reviews.llvm.org/D129280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

aaron.ballman added a comment. In D129748#3654909 , @erichkeane wrote: > I think there _IS_ perhaps an acceptability to ignoring this attribute when > it would cause a problem. However, I think doing it as you're doing it now > is wrong. IF we are

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

erichkeane added a comment. In D129748#3653897 , @ChuanqiXu wrote: > In D129748#3651771 , @erichkeane > wrote: > >> I guess I don't have a good idea why this attribute would cause ODR issues? >> It would seem

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

This revision was automatically updated to reflect the committed changes. Closed by commit rG76910d4a56c8: [pseudo] Share the underly payload when stripping comments for a token stream (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 76910d4 - [pseudo] Share the underly payload when stripping comments for a token stream

Author: Haojian Wu Date: 2022-07-15T15:20:48+02:00 New Revision: 76910d4a56c8dba000f198bba13e71cf0492c8cb URL: https://github.com/llvm/llvm-project/commit/76910d4a56c8dba000f198bba13e71cf0492c8cb DIFF: https://github.com/llvm/llvm-project/commit/76910d4a56c8dba000f198bba13e71cf0492c8cb.diff

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 444960. vaibhav.y added a comment. Undo test case renames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h

[PATCH] D129359: [pseudo] Generate an enum type for identifying grammar rules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG231535890655: [pseudo] Generate an enum type for identifying grammar rules. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 2315358 - [pseudo] Generate an enum type for identifying grammar rules.

Author: Haojian Wu Date: 2022-07-15T15:09:31+02:00 New Revision: 2315358906078cd35e2eb64bdcb711b2ec35 URL: https://github.com/llvm/llvm-project/commit/2315358906078cd35e2eb64bdcb711b2ec35 DIFF: https://github.com/llvm/llvm-project/commit/2315358906078cd35e2eb64bdcb711b2ec35.diff

[PATCH] D129359: [pseudo] Generate an enum type for identifying grammar rules.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/Grammar.h:172 + // terminal `,` becomes `comma`; + // terminal `INT` becomes `int`; + std::string mangleSymbol(SymbolID) const; sammccall wrote: > I hope you

[PATCH] D129359: [pseudo] Generate an enum type for identifying grammar rules.

hokein updated this revision to Diff 444956. hokein marked 2 inline comments as done. hokein added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129359/new/ https://reviews.llvm.org/D129359 Files:

  1   2   >