[PATCH] D129311: [clang-format] Fix the return code of git-clang-format

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9a2f6b6aecf: [clang-format] Fix the return code of git-clang-format (authored by sridhar_gopinath, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f9a2f6b - [clang-format] Fix the return code of git-clang-format

Author: Sridhar Gopinath Date: 2022-07-27T21:01:24-07:00 New Revision: f9a2f6b6aecf0dd2b484d99458c99f799caee584 URL: https://github.com/llvm/llvm-project/commit/f9a2f6b6aecf0dd2b484d99458c99f799caee584 DIFF:

[PATCH] D130678: [clang-tools-extra] Refactor to reduce code duplication

prehistoric-penguin created this revision. Herald added a project: All. prehistoric-penguin requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130678 Files:

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf537bef6393: Use pseudoparser-based folding ranges in ClangdServer. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130011/new/

[clang-tools-extra] df537be - Use pseudoparser-based folding ranges in ClangdServer.

Author: Utkarsh Saxena Date: 2022-07-28T05:43:17+02:00 New Revision: df537bef6393042d40275567679ed51c7731e859 URL: https://github.com/llvm/llvm-project/commit/df537bef6393042d40275567679ed51c7731e859 DIFF:

[PATCH] D119296: KCFI sanitizer

joaomoreira accepted this revision. joaomoreira added a comment. I really like this revision. It removes the redundancy of having KCFI passes both in CodeGen and in the backend; it detangles CALL instructions from KCFI by creating a new MIR instruction; it fixes alignment while still supporting

[clang] fe1887d - [NFC] [C++20] [Modules] Add tests for merging redefinitions in modules

Author: Chuanqi Xu Date: 2022-07-28T11:32:47+08:00 New Revision: fe1887da36c63f64903de112f2a8e88f973318fa URL: https://github.com/llvm/llvm-project/commit/fe1887da36c63f64903de112f2a8e88f973318fa DIFF: https://github.com/llvm/llvm-project/commit/fe1887da36c63f64903de112f2a8e88f973318fa.diff

[clang] 76e951e - [Docs] Fix column ordering on clang attribute docs

Author: Chris Bieneman Date: 2022-07-27T21:36:43-05:00 New Revision: 76e951e80307d26da260a73d8209417d9bb5e9f9 URL: https://github.com/llvm/llvm-project/commit/76e951e80307d26da260a73d8209417d9bb5e9f9 DIFF:

[PATCH] D130593: [clang][dataflow] Separate context by frame

samestep added a comment. Note: after some discussion with @ymandel, we've decided to adjust our design for this. A new patch is on the way which will replace this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130593/new/

[clang] 4bb192b - DebugInfo: Test vtable homing overriding ctor homing only on itanium since msvc ABI doesn't home vtables

Author: David Blaikie Date: 2022-07-28T00:45:00Z New Revision: 4bb192b846854ab1dc49a2e4b2a2717a4e3a9b1e URL: https://github.com/llvm/llvm-project/commit/4bb192b846854ab1dc49a2e4b2a2717a4e3a9b1e DIFF: https://github.com/llvm/llvm-project/commit/4bb192b846854ab1dc49a2e4b2a2717a4e3a9b1e.diff

Re: [clang] 4821508 - Revert "DebugInfo: Fully integrate ctor type homing into 'limited' debug info"

Excuse the delay - yeah, pulled out the fix in 4e719e0f16933a8945a4e85db39fdad5afbede36 On Fri, Jul 1, 2022 at 7:21 AM Robinson, Paul wrote: > > Hi Dave, > > The original commit message included > Also fix a bug I found along the way that was causing ctor type homing > to kick in even

[clang] 4e719e0 - DebugInfo: Prefer vtable homing over ctor homing.

Author: David Blaikie Date: 2022-07-28T00:07:35Z New Revision: 4e719e0f16933a8945a4e85db39fdad5afbede36 URL: https://github.com/llvm/llvm-project/commit/4e719e0f16933a8945a4e85db39fdad5afbede36 DIFF: https://github.com/llvm/llvm-project/commit/4e719e0f16933a8945a4e85db39fdad5afbede36.diff

[PATCH] D130055: Clang extensions yolo, woot & kaboom

jkorous added a comment. One more thing - the "attributes as a cross-TU metadata" idea might be (possibly with some squinting) conceptually similar to `enforce_tcb` attribute that @NoQ made me aware of some time ago. https://clang.llvm.org/docs/AttributeReference.html#enforce-tcb Repository:

[PATCH] D130055: Clang extensions yolo, woot & kaboom

jkorous added a comment. In D130055#3683279 , @beanz wrote: > I'm wondering if there could be a generalization of the attribute like: I can't imagine it is possible to design a reasonable and practically usable system of attributes to model anything

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

arsenm added a comment. I can't see a scenario where we would need this with a variadic call. Ultimately these wrap specific physical instructions, not some kind of arbitrary call CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130224/new/ https://reviews.llvm.org/D130224

[PATCH] D130055: Clang extensions yolo, woot & kaboom

jkorous added a comment. In D130055#3683173 , @aaron.ballman wrote: > Are there circumstances where we cannot "simply" infer this from the > constructor itself? (After instantiation) we know the class hierarchy, we > know the data members, and we know

[PATCH] D130516: [llvm] compression classes

dblaikie added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:50-58 + compression::CompressionAlgorithm *CompressionScheme = + new compression::ZlibCompressionAlgorithm(); + + CompressionScheme = +

[PATCH] D130516: [llvm] compression classes

ckissane marked 2 inline comments as done. ckissane added a comment. marked outdated comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 ___

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

compnerd added inline comments. Comment at: clang/include/clang/Config/config.h.cmake:57 +/* Multilib basename for libdir. */ +#define CLANG_INSTALL_LIBDIR_BASENAME "${CLANG_INSTALL_LIBDIR_BASENAME}" Does this not potentially break downstreams? Repository:

[clang] 28cd7f8 - Revert "[Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values"

Author: Shafik Yaghmour Date: 2022-07-27T15:31:41-07:00 New Revision: 28cd7f86ed0e94ea3ae56a49ba85f0ccb7b51dd4 URL: https://github.com/llvm/llvm-project/commit/28cd7f86ed0e94ea3ae56a49ba85f0ccb7b51dd4 DIFF:

[PATCH] D130667: feat: use compression class for: clang ast serial zstd option + prof data compression variants + zstd elf + ztsd objcopy support

ckissane created this revision. ckissane added reviewers: leonardchan, phosek, dblaikie. Herald added subscribers: Enna1, wenlei, usaxena95, abrachet, kadircet, arphaman, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht.

[PATCH] D130516: compression classes

dblaikie added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:32 +llvm::compression::CompressionAlgorithm *StringTableCompressionScheme = +new llvm::compression::ZlibCompressionAlgorithm(); + ckissane wrote: > dblaikie wrote: >

[PATCH] D130516: compression classes

ckissane added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:32 +llvm::compression::CompressionAlgorithm *StringTableCompressionScheme = +new llvm::compression::ZlibCompressionAlgorithm(); + dblaikie wrote: > We're generally

[PATCH] D130626: [pseudo] experiment

hokein added a comment. The solution in imperfect here (it is based on the identifier content, so it won't work if the code happen to have two same-content-but-different-kind tokens, e.g. `trace::Span Span;`), but it at least shows that ambiguities in identifiers are the most critical one.

[PATCH] D130516: compression classes

ckissane updated this revision to Diff 448181. ckissane added a comment. - use CompressionScheme->notNone() in InstrProf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3710589f285: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum… (authored by shafik). Herald added a project: clang.

[clang] a371058 - [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

Author: Shafik Yaghmour Date: 2022-07-27T14:59:35-07:00 New Revision: a3710589f285de0bb22ff92b1fc24df9411e986f URL: https://github.com/llvm/llvm-project/commit/a3710589f285de0bb22ff92b1fc24df9411e986f DIFF:

[PATCH] D130516: compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54 + CompressionScheme = + CompressionScheme->when(Compress && DoInstrProfNameCompression) + ->whenSupported(); note the helpers such as

[PATCH] D130516: compression classes

ckissane updated this revision to Diff 448176. ckissane added a comment. - fix compression inheritence and some more compression class helpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik updated this revision to Diff 448173. shafik marked 14 inline comments as done. shafik added a comment. - Add release note - Reflow diagnostic - Update defect report status - Add test for E3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130058/new/

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

njames93 updated this revision to Diff 448172. njames93 added a comment. Fix typo in test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/ https://reviews.llvm.org/D130630 Files:

[PATCH] D130665: [clang-tidy] Fix false negative in readability-convert-member-functions-to-static

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

mstorsjo updated this revision to Diff 448163. mstorsjo added a comment. Updated with the new tool name, and renamed the cmake variable accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129799/new/ https://reviews.llvm.org/D129799 Files:

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov updated this revision to Diff 448161. ASDenysPetrov added a comment. Make changes according to the remarks. - Add complexity to function description. - Rewrite the loop making it deterministic. - Add back invert operation to the tests. CHANGES SINCE LAST ACTION

[PATCH] D129798: [clang-tidy] Add a "clang-" namespace prefix to the make-confusable-target executable

mstorsjo updated this revision to Diff 448162. mstorsjo added a comment. Updated with the new suggested executable name from https://reviews.llvm.org/D129799#3681524. Will push this change tomorrow if there's no further objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130516: compression classes

ckissane added a comment. In D130516#3683384 , @dblaikie wrote: > Any chance this could be split up to be more directly comparable to > https://reviews.llvm.org/D130458 ? yes definitely! Doing so now! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

aidengrossman updated this revision to Diff 448152. aidengrossman marked an inline comment as done. aidengrossman added a comment. Added two unit tests to ensure functionality is correct in both the assertion case and the default case. Should be sufficient to ensure correct functionality without

[PATCH] D130600: [clang][dataflow] Handle return statements

li.zhe.hua added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:114 + /// + /// `return` must not be assigned a storage location. + void setReturnStorageLocation(StorageLocation ) { samestep wrote: >

[PATCH] D130516: compression classes

dblaikie added a comment. Any chance this could be split up to be more directly comparable to https://reviews.llvm.org/D130458 ? Comment at: clang-tools-extra/clangd/index/Serialization.cpp:32 +llvm::compression::CompressionAlgorithm *StringTableCompressionScheme = +new

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 448141. Codesbyusman added a comment. updated with the small fixes and addition of release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files:

[clang] e27026c - [LinkerWrapper] Do not consume `--verbose` from the linker

Author: Joseph Huber Date: 2022-07-27T16:06:48-04:00 New Revision: e27026cce16a98f923bbdb71362334faf6d68cd3 URL: https://github.com/llvm/llvm-project/commit/e27026cce16a98f923bbdb71362334faf6d68cd3 DIFF: https://github.com/llvm/llvm-project/commit/e27026cce16a98f923bbdb71362334faf6d68cd3.diff

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

jansvoboda11 added a comment. The code change looks good to me, could you also include a test case for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130620/new/ https://reviews.llvm.org/D130620

[PATCH] D130055: Clang extensions yolo, woot & kaboom

beanz added a comment. In D130055#3683173 , @aaron.ballman wrote: > Are there circumstances where we cannot "simply" infer this from the > constructor itself? I think this gets tricky in cases where objects may have valid "uninitialized" state. Like

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov marked 3 inline comments as done. ASDenysPetrov added a comment. Now I'm working on the next patch and you'll see a motivation soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130372/new/ https://reviews.llvm.org/D130372

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov marked 6 inline comments as done. ASDenysPetrov added a comment. @martong Thanks for review. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:728-729 + ContainerType Result; + Result.reserve(What.size() + 1 - bool(What.getMinValue() != MIN)

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

Michael137 added a comment. In D123319#3682929 , @dblaikie wrote: > In D123319#3681884 , @Michael137 > wrote: > >> In D123319#3680169 , @aprantl >> wrote: >> >>> Sorry

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

dblaikie requested changes to this revision. dblaikie added a comment. This revision now requires changes to proceed. I'll flag this as "request changes" so we're clear the issue isn't fully understood nor fully reproducible - so once there's some more data on the scope/impact/cause/timeline

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

aidengrossman marked an inline comment as done. aidengrossman added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4549 +Invocation.generateCC1CommandLine(Args, SA); +Args.insert(Args.begin(), "-cc1"); + },

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

aidengrossman updated this revision to Diff 448132. aidengrossman added a comment. Moved insertion of cc1 flag to prevent shifting entire array Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130620/new/ https://reviews.llvm.org/D130620 Files:

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

MaskRay added a comment. I accepted this because this seems a major showstopper and we want to resolve it for the upcoming major release But I just recall that clang 14.0.0 has defaulted to DWARF v5 for most ELF operating systems on all architectures. > So far, I had only seen it with the GNU

[PATCH] D130055: Clang extensions yolo, woot & kaboom

aaron.ballman added a comment. Thank you for this! I'm starting to get dug out from standards meetings and able to think about this a bit more, and I had some questions. > The yolo attribute denotes a constructor as creating an "uninitialized" > variable. Are there circumstances where we

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17fb879764dc: [clang-format] FIX: Misannotation auto as trailing return type in lambdas (authored by denis-fatkulin, committed by ArcsinX).

[clang] 17fb879 - [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

Author: Denis Fatkulin Date: 2022-07-27T22:20:09+03:00 New Revision: 17fb879764dcaf1f5f6bc505c5c747067ba7c3cd URL: https://github.com/llvm/llvm-project/commit/17fb879764dcaf1f5f6bc505c5c747067ba7c3cd DIFF:

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

jansvoboda11 added a comment. Thanks for the fix! Left one suggestion. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4549 +Invocation.generateCC1CommandLine(Args, SA); +Args.insert(Args.begin(), "-cc1"); + }, This will shift all

[PATCH] D130510: Missing tautological compare warnings due to unary operators

aaron.ballman added a comment. In D130510#3683078 , @Codesbyusman wrote: > In D130510#3682902 , @aaron.ballman > wrote: > >> Thank you for this, I think this is good incremental progress and is almost >> ready

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f3f357e26cf: [clang-offload-bundler] Library-ize ClangOffloadBundler (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0f3f357 - [clang-offload-bundler] Library-ize ClangOffloadBundler

Author: Jacob Lambert Date: 2022-07-27T11:54:38-07:00 New Revision: 0f3f357e26cfdb887866215b234138e66fd0c4c9 URL: https://github.com/llvm/llvm-project/commit/0f3f357e26cfdb887866215b234138e66fd0c4c9 DIFF: https://github.com/llvm/llvm-project/commit/0f3f357e26cfdb887866215b234138e66fd0c4c9.diff

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman added a comment. In D130510#3682902 , @aaron.ballman wrote: > Thank you for this, I think this is good incremental progress and is almost > ready to go. Just a few small nits, but also, can you also add a release note > for the fix (be

[PATCH] D130017: [HLSL] Add RWBuffer default constructor

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Is it worth adding a test that calls this constructor / checks that we end up with a call to the builtin? Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:155 +

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:114 + /// + /// `return` must not be assigned a storage location. + void setReturnStorageLocation(StorageLocation ) { li.zhe.hua wrote: > Fix

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 448117. srishti-pm added a comment. Updated an outdated comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files:

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of values

[PATCH] D130600: [clang][dataflow] Handle return statements

li.zhe.hua added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:114 + /// + /// `return` must not be assigned a storage location. + void setReturnStorageLocation(StorageLocation ) { Fix this as well? A

[PATCH] D128569: Start support for HLSL `RWBuffer`

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Fairly straightforward. LGTM with a couple of nits Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:48 + + // Complete an incomplete HLSL builtin type + void

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you think this warrants a release note (or did it close any open issues in the tracker)? Comment at: clang/lib/Analysis/ThreadSafety.cpp:2091-2097 +

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath added a comment. I do not have commit access. Could you please commit on my behalf? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129311/new/ https://reviews.llvm.org/D129311

[clang] 5e28923 - [clang][dataflow][NFC] Remove last use of deprecated ctor

Author: Eric Li Date: 2022-07-27T14:23:35-04:00 New Revision: 5e28923e332f2e738d17d35f1978df3391ee10af URL: https://github.com/llvm/llvm-project/commit/5e28923e332f2e738d17d35f1978df3391ee10af DIFF: https://github.com/llvm/llvm-project/commit/5e28923e332f2e738d17d35f1978df3391ee10af.diff LOG:

[PATCH] D130653: [clang][dataflow][NFC] Remove last use of deprecated ctor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e28923e332f: [clang][dataflow][NFC] Remove last use of

[PATCH] D130653: [clang][dataflow][NFC] Remove last use of deprecated ctor

li.zhe.hua updated this revision to Diff 448105. li.zhe.hua added a comment. Explicitly name `TransferOptions` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130653/new/ https://reviews.llvm.org/D130653 Files:

[PATCH] D130653: [clang][dataflow][NFC] Remove last use of deprecated ctor

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. In D123319#3681884 , @Michael137 wrote: > In D123319#3680169 , @aprantl wrote: > >> Sorry for the silence — I was out on vacation. >> >> @Michael137 has recently started looking into

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

dblaikie added a comment. > This is all extremely weird, but until the error shows up again, I'll put > this patch on hold (not yet abandoning since there seems to be no way to > unabandon if necessary). You can abandon and then "reclaim" the revision to reopen it and continue work.

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 448099. sridhar_gopinath marked an inline comment as done. sridhar_gopinath added a comment. Addressed nitpick Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129311/new/

[PATCH] D130510: Missing tautological compare warnings due to unary operators

aaron.ballman added a comment. Thank you for this, I think this is good incremental progress and is almost ready to go. Just a few small nits, but also, can you also add a release note for the fix (be sure to mention which issue is being closed too). Note, the precommit CI failures are

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

jansvoboda11 added a comment. Makes sense, thanks. LGTM provided you add brief explanation to each of the new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129884/new/ https://reviews.llvm.org/D129884

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 448094. srishti-pm marked 5 inline comments as done. srishti-pm added a comment. 1. Addressed all the comments. 2. Refactored the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/

[PATCH] D130055: Clang extensions yolo, woot & kaboom

dblaikie added a comment. In D130055#3682497 , @beanz wrote: > In D130055#3677743 , @dblaikie > wrote: > >> Any chance this could be a generalization of >>

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Do you think we should backport this to llvm 15, since it missed the branch point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125728/new/

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. I just updated the patch. Something went wrong. I used arc `diff --update ` for uploading. However, it seems it is not comparing the last submitted patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

benlangmuir added a comment. In D129884#3677435 , @jansvoboda11 wrote: > Would it make sense for this to replace the existing strict context hash > implementation? It's not clear to me whether this would be a good tradeoff or not: the explicit build

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 448086. abidmalikwaterloo added a comment. Added assembly format changed the type of mape_type_modifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ https://reviews.llvm.org/D105255

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

cjdb added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of values

[PATCH] D130018: [HLSL] Add HLSLResource attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6473-6475 +The HLSL ``resource`` attribute is not valid to manually specify in +HLSL. It is applied by the compiler to HLSL resource type objects enabling them +to be handled appropriately in

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

njames93 updated this revision to Diff 448064. njames93 marked an inline comment as done. njames93 added a comment. Remove Excessive Newline. Hopefully fix the windows test failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:61 + +GlobalVariable *replaceCBuffer(CGHLSLRuntime::CBuffer ) { + const unsigned CBufferAddressSpace = 4; I don't think I understand the intent of this function along with

[PATCH] D130641: [clang-tidy] Extend redundant-string-c-str to also flag constructing a string_view.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 448060. Codesbyusman added a comment. updating the code suggestions and test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files:

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 marked 6 inline comments as done. Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake:65 set(output_dir "${LLVM_LIBRARY_OUTPUT_INTDIR}") - set(install_dir "${CMAKE_INSTALL_PREFIX}/lib${LLVM_LIBDIR_SUFFIX}") +

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448058. Ericson2314 added a comment. Add deprecation notice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files: bolt/runtime/CMakeLists.txt

[PATCH] D130055: Clang extensions yolo, woot & kaboom

beanz added a comment. In D130055#3677743 , @dblaikie wrote: > Any chance this could be a generalization of > https://clang.llvm.org/doxygen/Consumed_8cpp_source.html ? I'm not really familiar with that code, but at glance there seems to be some

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

martong added a comment. > The motivation is to extend the set of operations that can be performed on > range sets. Specifically, this function is needed for the next patch in the > stack. Would be great to see the motivation clearly and early. What will be the next patch about?

[PATCH] D130639: [clang-tidy] Fix readability-redundant-string-c-str fix for overloaded operator->

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448053. Ericson2314 marked an inline comment as done. Ericson2314 added a comment. Fix review comments. Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/

[PATCH] D130018: [HLSL] Add HLSLResource attribute

beanz added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6473-6475 +The HLSL ``resource`` attribute is not valid to manually specify in +HLSL. It is applied by the compiler to HLSL resource type objects enabling them +to be handled appropriately in CodeGen.

[PATCH] D130581: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property"

Jake-Egan added a comment. Hi, this new test is failing on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/2544/steps/6/logs/FAIL__Clang__objc_property_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

royjacobson added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of

  1   2   >