[clang] efa8783 - [NFC] Add unittest for inline functions in modules

Author: Chuanqi Xu Date: 2022-08-16T13:35:38+08:00 New Revision: efa8783290d81689054d47bf71de452134bf4910 URL: https://github.com/llvm/llvm-project/commit/efa8783290d81689054d47bf71de452134bf4910 DIFF: https://github.com/llvm/llvm-project/commit/efa8783290d81689054d47bf71de452134bf4910.diff

[PATCH] D131655: [analyzer] Nullability: Enable analysis of non-inlined nullable objc properties.

NoQ updated this revision to Diff 452893. NoQ added a comment. Remove a redundant `C.addTransition(State)`. This caused us to run both the old mode and the new mode by producing a state split on an otherwise linear path. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131655/new/

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

craig.topper updated this revision to Diff 452889. craig.topper added a comment. Handle TUNE_PROC in checkTuneCPUKind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131708/new/ https://reviews.llvm.org/D131708 Files:

[PATCH] D131940: [clang-format] Handle comments between access specifier and colon

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

craig.topper planned changes to this revision. craig.topper added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:27 // RUN: %clang --target=riscv64 -### -c %s 2>&1 -mtune=rocket | FileCheck -check-prefix=MTUNE-ROCKET-64 %s -// MTUNE-ROCKET-64: "-tune-cpu"

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu accepted this revision. ChuanqiXu added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Sema/Sema.h:2264 + /// be checked at the end of the TU. + llvm::SmallPtrSet PendingInlineFuncDecls; + I'm

[PATCH] D131655: [analyzer] Nullability: Enable analysis of non-inlined nullable objc properties.

NoQ updated this revision to Diff 452887. NoQ added a comment. Get rid of unrelated code (whoops). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131655/new/ https://reviews.llvm.org/D131655 Files: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. This LGTM; thanks! In D131541#3721383 , @royjacobson wrote: > I still don't diagnose the dependent friend case, but

[PATCH] D131919: Move googletest to the third-party directory

stellaraccident accepted this revision. stellaraccident added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:1257 + +set(LLVM_THIRD_PARTY_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../third-party CACHE STRING +"Directory containing third party software used

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

njames93 added a comment. Please can you run git clang-format over the patch to keep the pre-merge bot happy. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/sizeof-expression.cpp:236-238 - // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of

[PATCH] D129628: [clang-format] Fix aligning of java-style declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8d331bc9710: [clang-format] Fix aligning of java-style declarations (authored by eoanermine, committed by owenpan). Repository: rG LLVM Github

[clang] d8d331b - [clang-format] Fix aligning of java-style declarations

Author: Danil Sidoruk Date: 2022-08-15T20:27:15-07:00 New Revision: d8d331bc97103b6e191b96189166fefc6be54148 URL: https://github.com/llvm/llvm-project/commit/d8d331bc97103b6e191b96189166fefc6be54148 DIFF: https://github.com/llvm/llvm-project/commit/d8d331bc97103b6e191b96189166fefc6be54148.diff

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ChuanqiXu updated this revision to Diff 452880. ChuanqiXu added a comment. Add ReleaseNotes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131938/new/ https://reviews.llvm.org/D131938 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. I am not sure if I don't miss any points. But if it is OK to run libc++/libstdc++, I think it should be good to land this. Comment at: clang/include/clang/Sema/Sema.h:3642 + // template, for the purposes of [temp.friend] p9. + bool

[PATCH] D131933: DebugInfo: Remove auto return type representation support

shafik added a comment. If we are not deriving any useful functionality from supporting this in debug-info then this makes sense to me but I will let someone still directly involved to approve it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, erichkeane, ychen, avogelsgesang. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Closing

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

phosek added a comment. In D128133#3724984 , @benshi001 wrote: > @phosek , > > I have re-landed my patch, it seems the core reason is compiler-rt is default > in Fuchsia environment, other than libgcc. > > please inform me if it went wrong any longer.

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. @phosek , I have re-landed my patch, it seems the core reason is compiler-rt is default in Fuchsia environment, other than libgcc. please inform me if it went wrong any longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 452875. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 Files: clang/docs/CPlusPlus20Modules.rst

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

ChuanqiXu accepted this revision. ChuanqiXu added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCXX/threadlocal_address.cpp:27 // CHECK-O1-NEXT: entry: -// CHECK-O1-NEXT: %[[I_ADDR:.+]] = {{.*}}call ptr

[clang] f45d89d - [Driver] Support linking to compiler-rt for target AVR

Author: Ben Shi Date: 2022-08-16T09:22:50+08:00 New Revision: f45d89d73d3fcf4fd105a4d31c40eee9f0aa7fa1 URL: https://github.com/llvm/llvm-project/commit/f45d89d73d3fcf4fd105a4d31c40eee9f0aa7fa1 DIFF: https://github.com/llvm/llvm-project/commit/f45d89d73d3fcf4fd105a4d31c40eee9f0aa7fa1.diff LOG:

[PATCH] D131935: [clang][llvm][NFC] Change misexpect's tolerance option to be 32-bit

paulkirth created this revision. paulkirth added reviewers: jloser, tejohnson, davidxl. Herald added a subscriber: hiraditya. Herald added a project: All. paulkirth requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In

[PATCH] D131934: [clang][deps] Compute command-lines for dependencies immediately

benlangmuir created this revision. benlangmuir added a reviewer: jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of delaying the generation of command-lines to after all

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. Herald added a project: All. I've posted D131933 to revert this patch based on discussion in D123319 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. In D123319#3723648 , @Michael137 wrote: > FYI, had an offline chat with @dblaikie and we decided that the best way > forward would be to try stop emitting auto return types in DWARF, instead of > relying on

[PATCH] D131933: DebugInfo: Remove auto return type representation support

dblaikie created this revision. dblaikie added reviewers: aprantl, probinson, shafik, awpandey. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Seems this complicated lldb sufficiently for some cases

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. In D128133#3723847 , @phosek wrote: > We started seeing test failures after this change on our bots. Would it be > possible to revert the change and address these issues before relanding? > > In `Clang :: Driver/avr-ld.c`: > >

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:75 +emitFilename(FE->getName(), Loc.getManager()); +// FIXME: No current way to add file-only location to SARIF object + } @vaibhav.y , just wanted to

[clang] 65c022a - Revert "[Driver] Support linking to compiler-rt for target AVR"

Author: Ben Shi Date: 2022-08-16T07:55:41+08:00 New Revision: 65c022a75fa7ca87dbf8375527c76eaf7d5f16c5 URL: https://github.com/llvm/llvm-project/commit/65c022a75fa7ca87dbf8375527c76eaf7d5f16c5 DIFF: https://github.com/llvm/llvm-project/commit/65c022a75fa7ca87dbf8375527c76eaf7d5f16c5.diff LOG:

[PATCH] D131707: [analyzer][NFC] Cache the result of getLocationType in TypedValueRegion

xazax.hun added a comment. In D131707#3724747 , @NoQ wrote: > So I think the most valuable optimizations are low-level optimizations to > `ImmutableMap`. There were a few suggestions on the mailing list to use > something more modern than the AVL trees

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

alexander-shaposhnikov marked 2 inline comments as done. alexander-shaposhnikov added inline comments. Comment at: clang/test/CodeGenCXX/threadlocal_address.cpp:27 // CHECK-O1-NEXT: entry: -// CHECK-O1-NEXT: %[[I_ADDR:.+]] = {{.*}}call ptr @llvm.threadlocal.address.p0(ptr

[PATCH] D131707: [analyzer][NFC] Cache the result of getLocationType in TypedValueRegion

NoQ added a comment. Hmm at a glance I disagree with the FIXME, this doesn't look like a valuable optimization. This operation is typically constant-time anyway so it's probably not worth the memory impact and the added complexity. The easiest way to roughly estimate impact is to take

[PATCH] D131919: Move googletest to the third-party directory

tstellar added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:1257 + +set(LLVM_THIRD_PARTY_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../third-party CACHE STRING +"Directory containing third party software used by LLVM (e.g. googletest)")

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 452843. abrahamcd added a comment. Naming fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SARIFDiagnostic.h

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 452840. abrahamcd added a comment. Minor cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SARIFDiagnostic.h

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM once minor nits are fixed. I am not opposed to getting this back to where it was, we can take a more careful look later at what this checker should be doing instead.

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 452833. abrahamcd retitled this revision from "[WIP] Enable SARIF Diagnostics" to "[clang] Enable output of SARIF diagnostics". abrahamcd edited the summary of this revision. abrahamcd added a comment. Removed unused remaining parts of traditional text

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

chrish_ericsson_atx created this revision. chrish_ericsson_atx added reviewers: mizvekov, baloghadamsoftware, njames93, cfe-commits. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. Herald added a project: All. chrish_ericsson_atx requested review of this revision. Herald added a

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. Thanks, this is looking very close now. Please handle the unary minus case in the complex emitter as well; I think that's all we need in terms of basic features. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:296 + ComplexPairTy

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. Thanks Akira. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131714/new/ https://reviews.llvm.org/D131714

[PATCH] D131910: [Windows] Put init_seg(compiler/lib) in llvm.global_ctors

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131910/new/ https://reviews.llvm.org/D131910

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:746 unsigned Depth, Index; -std::tie(Depth, Index) = getDepthAndIndex(Unexpanded[I]); +std::tie(Depth, Index) = getDepthAndIndex(U); if (Depth ==

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

phosek added inline comments. Comment at: clang/lib/Basic/Targets.cpp:579 +case llvm::Triple::UEFI: + //TODO(prabhukr): Template param check if required for other architectures + return new UEFITargetInfo(Triple, Opts); What does this comment

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:746 unsigned Depth, Index; -std::tie(Depth, Index) = getDepthAndIndex(Unexpanded[I]); +std::tie(Depth, Index) = getDepthAndIndex(U); if (Depth ==

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13547-13551 + if (auto ValD = Info.EvaluatingDecl.dyn_cast()) { +const VarDecl *VD = dyn_cast_or_null(ValD); +if (VD && !VD->isConstexpr()) + NotConstexprVar = true; + }

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

dexonsmith added a comment. In D130303#3724247 , @rnk wrote: > Pinging alternative reviewer +@dexonsmith for a libclang API addition Looks reasonable to me -- this only changes behaviour of the existing API when there was corruption before -- but if

[PATCH] D131806: Update hwasan test to fix failure on older Android API versions.

hctim added a comment. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131806/new/ https://reviews.llvm.org/D131806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131622: [NFC][PowerPC] Add missing NOCOMPAT checks for builtins-ppc-xlcompat.c

amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. I think this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131622/new/ https://reviews.llvm.org/D131622

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 452799. Codesbyusman added a comment. updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: clang/docs/ReleaseNotes.rst clang/lib/Analysis/CFG.cpp

[PATCH] D131919: Move googletest to the third-party directory

stellaraccident added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:1257 + +set(LLVM_THIRD_PARTY_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../third-party CACHE STRING +"Directory containing third party software used by LLVM (e.g. googletest)")

[PATCH] D131910: [Windows] Put init_seg(compiler/lib) in llvm.global_ctors

aeubanks updated this revision to Diff 452798. aeubanks added a comment. Herald added a reviewer: aaron.ballman. use 400 for lib, update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131910/new/ https://reviews.llvm.org/D131910

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 452797. Codesbyusman added a comment. updating for the missing tautological compare warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files:

[PATCH] D131919: Move googletest to the third-party directory

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919 ___ cfe-commits mailing list

[PATCH] D131919: Move googletest to the third-party directory

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. I didn't review the patch in detail, but +1 this is a great step forward to reorganize the repo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131919: Move googletest to the third-party directory

tstellar created this revision. tstellar added reviewers: stellaraccident, rnk, lattner, probinson, jyknight, phosek. Herald added subscribers: Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, mstorsjo, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo,

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

rnk added a subscriber: dexonsmith. rnk added a comment. Pinging alternative reviewer +@dexonsmith for a libclang API addition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

rnk added subscribers: ayzhao, usaxena95, ilya-biryukov. rnk added a comment. I think this is a straightforward improvement. I would like to see it land. Do the other reviewers have any outstanding concerns? +cc other clang people @ayzhao @ilya-biryukov @usaxena95 Comment

[PATCH] D131910: [Windows] Put init_seg(compiler/lib) in llvm.global_ctors

rnk added a comment. Please update the AttrDocs.td file to document the relationship between init_seg and init_priority on Windows. Can we increase the threshold for library so that we can insert

[PATCH] D131809: [clang][dataflow] Add an option for context-sensitive depth

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2efc8f8d6561: [clang][dataflow] Add an option for context-sensitive depth (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2efc8f8 - [clang][dataflow] Add an option for context-sensitive depth

Author: Sam Estep Date: 2022-08-15T19:58:40Z New Revision: 2efc8f8d6561421c3f47de2f27a365ddfb734425 URL: https://github.com/llvm/llvm-project/commit/2efc8f8d6561421c3f47de2f27a365ddfb734425 DIFF: https://github.com/llvm/llvm-project/commit/2efc8f8d6561421c3f47de2f27a365ddfb734425.diff LOG:

[PATCH] D131809: [clang][dataflow] Add an option for context-sensitive depth

samestep updated this revision to Diff 452783. samestep added a comment. Address Stanislav's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131809/new/ https://reviews.llvm.org/D131809 Files:

[PATCH] D131809: [clang][dataflow] Add an option for context-sensitive depth

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:665 +if (!(Options.ContextSensitiveOpts && + Env.canDescend(Options.ContextSensitiveOpts->Depth, F))) return; samestep wrote: > xazax.hun wrote: > >

[PATCH] D131809: [clang][dataflow] Add an option for context-sensitive depth

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:210 + const DeclContext *Callee) const { + return CallString.size() <= MaxDepth && + std::find(CallString.begin(), CallString.end(), Callee)

[PATCH] D131818: [clang][diagnostics] Don't warn about unreachable code in constexpr if

This revision was automatically updated to reflect the committed changes. Closed by commit rGff8aadf58d1a: [clang][diagnostics] Dont warn about unreachable code in constexpr if (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ff8aadf - [clang][diagnostics] Don't warn about unreachable code in constexpr if

Author: Alan Zhao Date: 2022-08-15T15:24:39-04:00 New Revision: ff8aadf58d1a0ea7d8fa2b9a7a17ff0c6059baa5 URL: https://github.com/llvm/llvm-project/commit/ff8aadf58d1a0ea7d8fa2b9a7a17ff0c6059baa5 DIFF: https://github.com/llvm/llvm-project/commit/ff8aadf58d1a0ea7d8fa2b9a7a17ff0c6059baa5.diff

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13547-13551 + if (auto ValD = Info.EvaluatingDecl.dyn_cast()) { +const VarDecl *VD = dyn_cast_or_null(ValD); +if (VD && !VD->isConstexpr()) + NotConstexprVar = true; + }

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

shafik updated this revision to Diff 452775. shafik marked an inline comment as done. shafik added a comment. - Changed `NotConstexprVar` to `ConstExprVar` - Moved checking of `ConstexprVar` up so that we do the less expensive check first CHANGES SINCE LAST ACTION

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk added a subscriber: hans. rnk added a comment. Regarding the usage of isPOD in the MSVC ABI code, we should have a routine similar to `isTrivialForAArch64MSVC` that works for the other MSVC architectures that we support (x86, x64, and arm32). I don't think we should try to rely on

[PATCH] D131892: [Sema] fix false -Wcomma being emitted from void returning functions

inclyc added inline comments. Comment at: clang/docs/ReleaseNotes.rst:74 number of arguments cause an assertion fault. +- Fix `#57151 `_. + ``-Wcomma`` is emitted for void returning functions. Do we need an

[PATCH] D131892: [Sema] fix false -Wcomma being emitted from void returning functions

inclyc updated this revision to Diff 452767. inclyc added a comment. Address comments. Thanks a lot for your suggestion, I noticed that the regression test tested both C and C++, so I split the test mentioned in the comment into two parts. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae added inline comments. Comment at: clang/test/SemaHLSL/resource_binding_attr_error.hlsl:15 +// expected-error@+1 {{invalid space specifier 's2' used; expected 'space' followed by an integer, like space1}} +cbuffer a : register(b0, s2) { + beanz

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae updated this revision to Diff 452761. python3kgae marked 3 inline comments as done. python3kgae added a comment. Add more comment about no name conflict for cbuffer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong updated this revision to Diff 452757. steplong added a comment. - Clang-format test The regex isn't optimal since it will still accept strings that aren't "Num Args: 1\n" or "Num Args: 2\n" such as "Num Args: \n2\n" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131818: [clang][diagnostics] Don't warn about unreachable code in constexpr if

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131818/new/ https://reviews.llvm.org/D131818

[PATCH] D131789: [clang-tools-extra][NFC] Rewrite prints in python3 compatible way

eoanermine added a comment. Please, commit this patch for me I don't have an access to commit the patch by myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131789/new/ https://reviews.llvm.org/D131789

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff added a comment. As specific interaction of FP pragmas and template instantiation was not supported, this patch is actual without additional changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129464/new/

[PATCH] D131910: [Windows] Put init_seg(compiler/lib) in llvm.global_ctors

aeubanks created this revision. aeubanks added reviewers: rnk, hans. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently we treat

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. In D105255#3723940 , @clementval wrote: > In D105255#3723865 , > @abidmalikwaterloo wrote: > >> [MLIR][OpenMP] Added target data, exit data, and enter data operation >>

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

clementval added a comment. In D105255#3723865 , @abidmalikwaterloo wrote: > [MLIR][OpenMP] Added target data, exit data, and enter data operation > definition for MLIR Looks like it's not the complete revision. There are almost no diffs anymore.

[PATCH] D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`

aaron.ballman added subscribers: owenpan, MyDeveloperDay. aaron.ballman added a comment. In D131386#3723490 , @Mordante wrote: > In D131386#3722749 , @aaron.ballman > wrote: > >> We leave formatting decisions in

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 452743. abidmalikwaterloo added a comment. [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/

[PATCH] D131892: [Sema] fix false -Wcomma being emitted from void returning functions

aaron.ballman added a comment. Thank you for working on this fix! I think it's quite close to finished, but it needs some additional test coverage. Also, please add a release note about the fix so users know what's going on. Comment at:

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

phosek added a comment. We started seeing test failures after this change on our bots. Would it be possible to revert the change and address these issues before relanding? In `Clang :: Driver/avr-ld.c`: Script: -- : 'RUN: at line 1'; /b/s/w/ir/x/w/staging/llvm_build/bin/clang -###

[clang] 465d908 - [test][clang] Opaquify pragma-init_seg.cpp

Author: Arthur Eubanks Date: 2022-08-15T10:45:24-07:00 New Revision: 465d9084ece1626335bc41eac96c56428faed7e9 URL: https://github.com/llvm/llvm-project/commit/465d9084ece1626335bc41eac96c56428faed7e9 DIFF:

[clang] f37b285 - Removing an unused function; NFC

Author: Aaron Ballman Date: 2022-08-15T13:35:16-04:00 New Revision: f37b2852999c695af03c6d809816793d8d345538 URL: https://github.com/llvm/llvm-project/commit/f37b2852999c695af03c6d809816793d8d345538 DIFF: https://github.com/llvm/llvm-project/commit/f37b2852999c695af03c6d809816793d8d345538.diff

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 452740. pscoro added a comment. chain input fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae updated this revision to Diff 452739. python3kgae added a comment. Fix format in AttrDocs.td and avoid name conflict in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130033/new/ https://reviews.llvm.org/D130033 Files:

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6649 + } else if (IsCPP17Onwards) { +CmdArgs.push_back("-faligned-allocation"); } thakis wrote: > Do we want to do this in the driver? From what I understand, we already do

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

beanz added inline comments. Comment at: clang/test/SemaHLSL/resource_binding_attr_error.hlsl:15 +// expected-error@+1 {{invalid space specifier 's2' used; expected 'space' followed by an integer, like space1}} +cbuffer a : register(b0, s2) { + aaron.ballman

[PATCH] D131818: [clang][diagnostics] Don't warn about unreachable code in constexpr if

ayzhao added a comment. In D131818#3723227 , @thakis wrote: > Thanks! > > Can you add a test for non-constexpr unreachable code within the constexpr if > and test that that still warns? Done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131818: [clang][diagnostics] Don't warn about unreachable code in constexpr if

ayzhao updated this revision to Diff 452721. ayzhao added a comment. Add tests for nested non-constexpr if Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131818/new/ https://reviews.llvm.org/D131818 Files: clang/lib/Analysis/ReachableCode.cpp

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

Michael137 added a comment. FYI, had an offline chat with @dblaikie and we decided that the best way forward would be to try stop emitting auto return types in DWARF, instead of relying on lambda/member-function specific hacks. Not sure what the timeline on this will be but tracking it

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:100 + "%select{binary|unary}0 bitwise operator") + << IsUnary << OperatorLoc; } We still need the source range of the

[PATCH] D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`

Mordante added a comment. In D131386#3722749 , @aaron.ballman wrote: > We leave formatting decisions in clang-tidy to clang-format and I don't think > we should deviate from that policy here without a very clear understanding of > when we should relax

[PATCH] D131707: [analyzer][NFC] Cache the result of getLocationType in TypedValueRegion

steakhal added a subscriber: balazske. steakhal added a comment. In D131707#3723403 , @ASDenysPetrov wrote: > @steakhal > Thank you for the review. > Could you please do testing for me, since I'm on Windows and have no prepared > testing environment as

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 452693. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/docs/ReleaseNotes.rst

[PATCH] D131892: [Sema] fix false -Wcomma being emited from void returning functions

inclyc updated this revision to Diff 452692. inclyc added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131892/new/ https://reviews.llvm.org/D131892 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/warn-comma-operator.cpp

[PATCH] D131892: [Sema] fix false -Wcomma being emited from void returning functions

inclyc updated this revision to Diff 452691. inclyc added a comment. Sync comments of function `IgnoreCommaOperand` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131892/new/ https://reviews.llvm.org/D131892 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D131707: [analyzer][NFC] Cache the result of getLocationType in TypedValueRegion

ASDenysPetrov added a comment. In D131707#3723403 , @ASDenysPetrov wrote: > @steakhal > Thank you for the review. > Could you please do testing for me, since I'm on Windows and have no prepared > testing environment as I know you do. > I'll add an

  1   2   >