[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder marked 5 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:662 + return this->emitGetPtrParam(It->second, E); + } + tahonermann wrote: > Perhaps add: > else { > assert(0 && "Unhandled

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder updated this revision to Diff 454164. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132111/new/ https://reviews.llvm.org/D132111 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/cxx20.cpp

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

usaxena95 added a comment. Can you please also add `consteval` related test case (mentioned in https://github.com/llvm/llvm-project/issues/57046#issuecomment-1211665079) to cxx2a-consteval.cpp

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

davrec added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12767 +Ctx.getQualifiedType(Underlying), +::getCommonDecl(EX->getOwnedTagDecl(), EY->getOwnedTagDecl())); + } mizvekov wrote: > davrec wrote: > > mizvekov wrote: > > > davrec

[PATCH] D132275: [clang] Reset some attributed calling lambda

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lambda invoker sets this argument to Undef, making it inconsistent with noundef, notnull, and dereferencable

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

tstellar added a comment. In D130586#3734012 , @Ericson2314 wrote: > Sorry. I have reverted this. I see why the `lib` and `lib64` mixup could be > caused by this, but I am baffled how the missing headers could be. Headers > search paths should be

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12767 +Ctx.getQualifiedType(Underlying), +::getCommonDecl(EX->getOwnedTagDecl(), EY->getOwnedTagDecl())); + } davrec wrote: > mizvekov wrote: > > davrec wrote: > > > This

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

davrec added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12767 +Ctx.getQualifiedType(Underlying), +::getCommonDecl(EX->getOwnedTagDecl(), EY->getOwnedTagDecl())); + } mizvekov wrote: > davrec wrote: > > This last argument should

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 454149. oleg.smolsky added a comment. Simplify and generalize the AST matcher. We just want to find all `return` statements in function definitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12767 +Ctx.getQualifiedType(Underlying), +::getCommonDecl(EX->getOwnedTagDecl(), EY->getOwnedTagDecl())); + } davrec wrote: > This last argument should probably be

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

nickdesaulniers created this revision. nickdesaulniers added a reviewer: aaron.ballman. Herald added a subscriber: emaste. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to commit

[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

thakis added a comment. To reproduce the warnings that this attempts to fix: % /Applications/CMake.app/Contents/bin/cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS='clang;lld' -DLLVM_ENABLE_RUNTIMES='compiler-rt' -DLLVM_APPEND_VC_REV=NO

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

yaxunl added a comment. In D132248#3736295 , @tra wrote: > I'm OK with that. > > @yaxunl -- what are your thoughts on whether this approach would work for > HIP? On one hand HIP already has a lot of features that the new driver is > intended to

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454129. abrahamcd edited the summary of this revision. abrahamcd added a comment. Addressed review style comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

sbc100 updated this revision to Diff 454128. sbc100 added a comment. improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131217/new/ https://reviews.llvm.org/D131217 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

sbc100 updated this revision to Diff 454122. sbc100 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131217/new/ https://reviews.llvm.org/D131217 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D131217: [WIP][clang][WebAssembly] Pass `-Wl, -no-type-check` through to the MC layer

sbc100 added a comment. ptal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131217/new/ https://reviews.llvm.org/D131217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

denik added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:155 +break; + } +} vaibhav.y wrote: > Does this need an `llvm_unreachable` after the switch? I guess no, because of `break`s. But... Although `case DiagnosticsEngine::Ignored`

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454113. abrahamcd marked 2 inline comments as done. abrahamcd added a comment. Added diagnostic level and default configuration to SARIF output. Removed unit test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

denik added a comment. Thanks Abraham! Please mention in the summary that some part of SARIF Diag implementation was copied from Text Diag and further refactoring is needed. Also, like we discussed: - drop the unittest; - replace strict match of json output in FileCheck with partial matches

[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG57c9780d60b1: [clang][ExtractAPI] Record availability information on all platforms (authored by dang). Changed prior to commit: https://reviews.llvm.org/D130918?vs=449228=454111#toc Repository: rG

[clang] 57c9780 - [clang][ExtractAPI] Record availability information on all platforms

Author: Daniel Grumberg Date: 2022-08-19T14:54:52-07:00 New Revision: 57c9780d60b15baf0eba4393857affce47f60aa7 URL: https://github.com/llvm/llvm-project/commit/57c9780d60b15baf0eba4393857affce47f60aa7 DIFF:

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. In D113107#3736312 , @zahiraam wrote: > This is a reduced test case from the codegen/complex-strictfp.c > > _Complex double g1, g2; > double D; > > void foo(void) { > > g1 = g1 + D; > > } > > The issue is that we are calling

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

alexfh added subscribers: kadircet, sammccall, alexfh. alexfh added a comment. Adding to the comment @joanahalili posted: this particular translation unit happens to have a large number of reverse dependencies and Clang's memory allocation has pushed it over the limits, which makes this issue

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. This is a reduced test case from the codegen/complex-strictfp.c _Complex double g1, g2; double D; void foo(void) { g1 = g1 + D; } The issue is that we are calling in VisitBinAssign the function EmitUnpromotion (since promotionTy is null). This creates 2

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 updated this revision to Diff 454108. jhuber6 added a comment. Updating documentation, cleaning up, and adjusting tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129507/new/ https://reviews.llvm.org/D129507 Files:

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e1a4ce0b55d: [clang-tidy] Fix for bugprone-sizeof-expression PR57167 (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 9e1a4ce - [clang-tidy] Fix for bugprone-sizeof-expression PR57167

Author: eahcmrh Date: 2022-08-19T23:29:32+02:00 New Revision: 9e1a4ce0b55db1388351550497e5ce43b588f71c URL: https://github.com/llvm/llvm-project/commit/9e1a4ce0b55db1388351550497e5ce43b588f71c DIFF: https://github.com/llvm/llvm-project/commit/9e1a4ce0b55db1388351550497e5ce43b588f71c.diff LOG:

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/offload-packager.c:26 +// RUN: --image=file=%S/Inputs/dummy-elf.o,kind=hip,triple=amdgcn-amd-amdhsa,arch=gfx90c +// RUN: cd $(dirname "%t")

[PATCH] D131646: [clang][dataflow] Restructure loops to call widen on back edges

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:228-234 + // If we are at the start of a loop, we will have two precessors, but we don't + // want to join these two predecessors. Instead, we want to take the back

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

b-sumner added a comment. In D132140#3732337 , @yaxunl wrote: > revised by Brian's comments Thank you. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/new/ https://reviews.llvm.org/D132140

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

tra added a comment. I'm OK with that. @yaxunl -- what are your thoughts on whether this approach would work for HIP? On one hand HIP already has a lot of features that the new driver is intended to provide, so AMD may have no pressure to change to something else. On the other hand, long term

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

phosek added inline comments. Comment at: lld/test/ELF/fatlto/Inputs/a-fatLTO.yaml:23 +AddressAlign:0x1 +Content:

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:125 +std::pair>>> +getAnnotationStates(AnalysisData ) { + using StateT = DataflowAnalysisState; gribozavr2 wrote: > Could we capture the lattice elements in the

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

paulkirth added inline comments. Comment at: lld/ELF/InputFiles.cpp:1721 +Expected fatLTOData = IRObjectFile::findBitcodeInMemBuffer(mb); +if (!errorToBool(fatLTOData.takeError())) + return make(*fatLTOData, archiveName, offsetInArchive, /*lazy=*/false);

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 updated this revision to Diff 454106. jhuber6 added a comment. Using @tra's suggestion to use `cd`. I had to make the test not apply to Windows however, since I had to use `realpath`. But we don't support Windows anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt updated this revision to Diff 454097. wyt marked 2 inline comments as done. wyt added a comment. Address comments: rename `AnalysisArguments` to `AnalysisInputs` and `AnalysisData` to `AnalysisOutputs`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131646: [clang][dataflow] Restructure loops to call widen on back edges

li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:168-169 +// back edge block. (That is, all paths from the entry block to the back edge +// block must go through `Block`.) It also means that there are only two +//

[PATCH] D131646: [clang][dataflow] Restructure loops to call widen on back edges

li.zhe.hua updated this revision to Diff 454089. li.zhe.hua marked 4 inline comments as done. li.zhe.hua added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131646/new/ https://reviews.llvm.org/D131646 Files:

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

wyt added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:144 llvm::Optional>>> -runDataflowAnalysis( +runDataflowAnalysisOnCFG( const ControlFlowContext , AnalysisT , gribozavr2 wrote: > Cannot be renamed

[PATCH] D132229: [clang][dataflow] Mark `getDeclCtx` function in dataflow `Environment` `const`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0befe3ac1ba: [clang][dataflow] Mark `getDeclCtx` function in dataflow `Environment` `const`. (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b0befe3 - [clang][dataflow] Mark `getDeclCtx` function in dataflow `Environment` `const`.

Author: Wei Yi Tee Date: 2022-08-19T20:07:21Z New Revision: b0befe3ac1baf5734a975d0bdbdb941d1c3b8364 URL: https://github.com/llvm/llvm-project/commit/b0befe3ac1baf5734a975d0bdbdb941d1c3b8364 DIFF: https://github.com/llvm/llvm-project/commit/b0befe3ac1baf5734a975d0bdbdb941d1c3b8364.diff LOG:

[PATCH] D132260: [pseudo] Eliminate a false parse of structured binding declaration.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Using the guard to implement part of the rule

[PATCH] D132079: [AMDGPU] Add iglp_opt builtin and MFMA GEMM Opt strategy

jrbyrnes accepted this revision. jrbyrnes added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:427 DAG->addMutation(createStoreClusterDAGMutation(DAG->TII, DAG->TRI));

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

sbc100 added a comment. Emscripten-side change in preparation for this to land: https://github.com/emscripten-core/emscripten/pull/17689 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125728/new/ https://reviews.llvm.org/D125728

[PATCH] D132232: Update coding standards for constexpr if statements; NFC

aaron.ballman added a comment. In D132232#3735911 , @dblaikie wrote: > Yeah, I'm OK with this, though yeah, having an example where the `else` is > necessary, but I don't mind too much. I went ahead and switched the example to Erich's because it wasn't

[PATCH] D132232: Update coding standards for constexpr if statements; NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGcda093681bad: Update coding standards for constexpr if statements; NFC (authored by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D132232?vs=453993=454085#toc Repository: rG LLVM

[PATCH] D132079: [AMDGPU] Add iglp_opt builtin and MFMA GEMM Opt strategy

kerbowa added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:427 DAG->addMutation(createStoreClusterDAGMutation(DAG->TII, DAG->TRI)); DAG->addMutation(createIGroupLPDAGMutation()); DAG->addMutation(createAMDGPUMacroFusionDAGMutation());

[clang] 95d94a6 - Revert "Re-apply "Deferred Concept Instantiation Implementation"""

Author: Erich Keane Date: 2022-08-19T12:47:34-07:00 New Revision: 95d94a67755620c0a2871ac6f056ca8e9731d5e9 URL: https://github.com/llvm/llvm-project/commit/95d94a67755620c0a2871ac6f056ca8e9731d5e9 DIFF: https://github.com/llvm/llvm-project/commit/95d94a67755620c0a2871ac6f056ca8e9731d5e9.diff

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: clang/docs/ControlFlowIntegrity.rst:319 +cross-DSO function address equality. These properties make KCFI easier to +adopt in low-level software. KCFI is limited to indirect call checking only, +and isn't compatible with

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

alexfh added a comment. In D129608#3735496 , @jyu2 wrote: > Hi @alexfh, > > How could I reproduce the problem? Thanks. > Thanks. > > Jennifer It should be reproducible by running the tests with the address sanitizer enabled. But it looks like this

[PATCH] D119296: KCFI sanitizer

efriedma added inline comments. Comment at: clang/docs/ControlFlowIntegrity.rst:319 +cross-DSO function address equality. These properties make KCFI easier to +adopt in low-level software. KCFI is limited to indirect call checking only, +and isn't compatible with executable-only

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

HazardyKnusperkeks added a comment. Please run `clang/docs/tools/dump_format_style.py`. Comment at: clang/include/clang/Format/Format.h:3189 + /// to DefinitionBlockSpacing. + /// \version 15 + unsigned DefinitionBlockSpacing; This isn't going to land in

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

HazardyKnusperkeks added a comment. In D132189#3733747 , @rymiel wrote: > There could also possibly be a TokenAnnotatorTest checking for > `TT_FunctionAnnotationRParen`, but there wasn't an existing one similar to > it, so I was unsure if I should add

[clang] bc53832 - [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard-float ABIs

Author: Alex Bradbury Date: 2022-08-19T20:31:06+01:00 New Revision: bc538320809fb52af12ec0366118c82201af4f40 URL: https://github.com/llvm/llvm-project/commit/bc538320809fb52af12ec0366118c82201af4f40 DIFF: https://github.com/llvm/llvm-project/commit/bc538320809fb52af12ec0366118c82201af4f40.diff

[PATCH] D131677: [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard-float ABIs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc538320809f: [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard… (authored by asb). Herald added a project: clang. Changed

[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

thakis added a comment. (Ref https://bugs.chromium.org/p/chromium/issues/detail?id=1265937#c4 , https://bugs.chromium.org/p/chromium/issues/detail?id=1265937#c6) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132258/new/ https://reviews.llvm.org/D132258

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:379 /// \version 3.7 bool AlignTrailingComments; Maybe you can port this to `AlignConsecutiveStyle`? `AcrossComments` would not affect anything in this context.

[PATCH] D132079: [AMDGPU] Add iglp_opt builtin and MFMA GEMM Opt strategy

jrbyrnes added a comment. Just a couple nitpicks Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:1071 PipelineSolver PS(SyncedSchedGroups, SyncedInstrs, DAG); // PipelineSolver performs the mutation by adding the edges it Have a fully unguarded

[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

thakis created this revision. thakis added a reviewer: akyrtzi. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. thakis requested review of this revision. Herald added a subscriber: MaskRay. Before this patch, clang would consider `-target x86_64-apple-darwin

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:1443-1447 +if (D->isTrivial()) { + data().HasTrivialSpecialMembers |= SMKind; +} +else + data().DeclaredNonTrivialSpecialMembers |= SMKind;

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tahonermann added inline comments. Comment at: clang/test/AST/Interp/cxx20.cpp:2 +// RUN: %clang_cc1 -fexperimental-new-constant-interpreter -std=c++20 -verify %s +// RUN: %clang_cc1 -std=c++20 -verify %s -DREFERENCE + tbaeder wrote: > tahonermann wrote: > > Is

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 updated this revision to Diff 454076. jhuber6 added a comment. Updating to error with `-o` and multiple files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132248/new/ https://reviews.llvm.org/D132248 Files: clang/lib/Driver/Driver.cpp

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 added a comment. In D132248#3735943 , @tra wrote: > In D132248#3735900 , @jhuber6 wrote: > >> Is this an architectural limitation? I'd imagine they'd just behave the same >> way here in my

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

tra added a comment. In D132248#3735900 , @jhuber6 wrote: > Is this an architectural limitation? I'd imagine they'd just behave the same > way here in my implementation. The constraint here is that we have to stick with a single output per compiler

[PATCH] D132232: Update coding standards for constexpr if statements; NFC

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Yeah, I'm OK with this, though yeah, having an example where the `else` is necessary, but I don't mind too much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 added a comment. In D132248#3735793 , @tra wrote: >> The old driver would put all the outputs in the final action list akin to a >> linker job. > > IIRC that's where HIP and CUDA behaved differently. CUDA compilation does not > allow

[PATCH] D131625: [HLSL] Entry functions require param annotation

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attr.h:193 +class HLSLAnnotationAttr : public InheritableAttr { +protected: beanz wrote: > aaron.ballman wrote: > > Is this intended to be used only for parameters (that's how I read the

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

alecto created this revision. alecto added reviewers: Richard, smith. Herald added a project: All. alecto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/57180 Given configuration:

[PATCH] D132079: [AMDGPU] Add iglp_opt builtin and MFMA GEMM Opt strategy

jrbyrnes added a comment. LGTM again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132079/new/ https://reviews.llvm.org/D132079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7125-7127 + // Currently FatLTO objects only embed ThinLTO bitcode + if (Args.hasArg(options::OPT_ffat_lto_objects)) +CmdArgs.push_back("-flto=thin"); Rather than assuming

[PATCH] D132244: [docs] improve documentation for misc-const-correctness

JonasToth updated this revision to Diff 454067. JonasToth added a comment. - mention C limitation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132244/new/ https://reviews.llvm.org/D132244 Files:

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

tra added a comment. > The old driver would put all the outputs in the final action list akin to a > linker job. IIRC that's where HIP and CUDA behaved differently. CUDA compilation does not allow device-only compilation for multiple targets if we have explicitly specified output. It does

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. IRGen has a strong postcondition about what IR types it expects specific from specific evaluations. Scalar expression emission is expected to return a scalar of type `ConvertType(E->getType())`, and complex expression emission is expected to return a pair of scalars

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

erichkeane added a comment. In D53847#3735738 , @ilya-biryukov wrote: > In D53847#3735704 , @erichkeane > wrote: > >> Note that this would also let us mark P2324 >> as complete

[PATCH] D132251: [clang][dataflow] Dummy patch

samestep created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ilya-biryukov added a comment. In D53847#3735704 , @erichkeane wrote: > Note that this would also let us mark P2324 > as complete as well. @ilya-biryukov : Since there is no response, I suspect > the answer here is

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

erichkeane added a comment. In D53847#3706965 , @ilya-biryukov wrote: > Hey! Also wondering what's the status of this. > @Rakete do you plan to finish the patch? Or would it be ok if someone > takes it over? Note that this would also let us mark

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

craig.topper added inline comments. Comment at: clang/lib/Headers/immintrin.h:300 +{ + unsigned int lo, hi; + if (__builtin_ia32_rdrand32_step() && __builtin_ia32_rdrand32_step()) { variable names in intrinsic headers must start with 2 underscores.

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae updated this revision to Diff 454051. python3kgae marked 2 inline comments as done. python3kgae added a comment. Use llvm::formatv. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 Files:

[PATCH] D128981: [C++20][Modules] Implement include translation.

jansvoboda11 added a comment. Thank you! Yes, I think this would be a good candidate for backporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128981/new/ https://reviews.llvm.org/D128981 ___

[clang] e41dd02 - Fix MSVC "not all control paths return a value" warning

Author: Simon Pilgrim Date: 2022-08-19T17:37:37+01:00 New Revision: e41dd0205242af4f8e2a370d0346f24f0b0eb788 URL: https://github.com/llvm/llvm-project/commit/e41dd0205242af4f8e2a370d0346f24f0b0eb788 DIFF: https://github.com/llvm/llvm-project/commit/e41dd0205242af4f8e2a370d0346f24f0b0eb788.diff

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda updated this revision to Diff 454048. arda added a comment. Invoke -flto=thin in the first stage of -ffat-lto-objects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131618/new/ https://reviews.llvm.org/D131618 Files:

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder updated this revision to Diff 454045. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132111/new/ https://reviews.llvm.org/D132111 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/cxx20.cpp

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/cxx20.cpp:2 +// RUN: %clang_cc1 -fexperimental-new-constant-interpreter -std=c++20 -verify %s +// RUN: %clang_cc1 -std=c++20 -verify %s -DREFERENCE +

[PATCH] D132197: [RISCV] Use Triple::isRISCV/isRISCV32/isRISCV64 helps in some places. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a60e003df8a: [RISCV] Use Triple::isRISCV/isRISCV32/isRISCV64 helps in some places. NFC (authored by craig.topper). Changed prior to commit:

[clang] 1a60e00 - [RISCV] Use Triple::isRISCV/isRISCV32/isRISCV64 helps in some places. NFC

Author: Craig Topper Date: 2022-08-19T09:11:22-07:00 New Revision: 1a60e003df8a8c03aae123bdec77e6a9db690862 URL: https://github.com/llvm/llvm-project/commit/1a60e003df8a8c03aae123bdec77e6a9db690862 DIFF: https://github.com/llvm/llvm-project/commit/1a60e003df8a8c03aae123bdec77e6a9db690862.diff

[PATCH] D132249: [clang][analyzer] Add some functions to StreamChecker with errno modeling.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a

[PATCH] D132246: [analyzer][NFC] Be more descriptive when we replay without inlining

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa47ec1b79797: [analyzer][NFC] Be more descriptive when we replay without inlining (authored by isuckatcs). Herald added a project: clang. Herald

[clang] a47ec1b - [analyzer][NFC] Be more descriptive when we replay without inlining

Author: isuckatcs Date: 2022-08-19T18:05:52+02:00 New Revision: a47ec1b79797c8c48c44f9ddf36fb82f8d87229d URL: https://github.com/llvm/llvm-project/commit/a47ec1b79797c8c48c44f9ddf36fb82f8d87229d DIFF: https://github.com/llvm/llvm-project/commit/a47ec1b79797c8c48c44f9ddf36fb82f8d87229d.diff

[PATCH] D131091: [clang][index] Index unresolved member expression as reference

This revision was automatically updated to reflect the committed changes. Closed by commit rGee648c0ce09b: [clang][index] Index unresolved member expression as reference (authored by denis-fatkulin, committed by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] ee648c0 - [clang][index] Index unresolved member expression as reference

Author: Denis Fatkulin Date: 2022-08-19T19:02:42+03:00 New Revision: ee648c0ce09b1edcee65407041eab38228f4b042 URL: https://github.com/llvm/llvm-project/commit/ee648c0ce09b1edcee65407041eab38228f4b042 DIFF:

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 updated this revision to Diff 454036. jhuber6 added a comment. Forgot to use the new driver in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132248/new/ https://reviews.llvm.org/D132248 Files: clang/lib/Driver/Driver.cpp

[PATCH] D132066: [clang][deps] Allow switching between lazily/eagerly loaded PCMs

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132066/new/ https://reviews.llvm.org/D132066

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl, JonChesterfield. Herald added subscribers: mattd, guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project:

[PATCH] D132247: [clang] Fix emitVoidPtrVAArg for non-zero default alloca address space

jrtc27 created this revision. jrtc27 added a reviewer: arsenm. Herald added subscribers: kosarev, tpr. Herald added a project: All. jrtc27 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Indirect arguments are passed on the stack and

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:103 + << NumThreadsAttr->getZ(); +OS.flush(); +F->addFnAttr(NumThreadsKindStr, NumThreadsStr); You can replace this whole chunk of code with: ``` std::string NumThreadsStr

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth updated this revision to Diff 454032. JonasToth added a comment. - remove bad change from diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130793/new/ https://reviews.llvm.org/D130793 Files:

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sbc100 added a comment. https://chromium-review.googlesource.com/c/emscripten-releases/+/3842345... I suppose the alternative would be to keep the backup method that was previously working in our case (but not in yours)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth updated this revision to Diff 454031. JonasToth marked an inline comment as done. JonasToth added a comment. - split patch - remove unnecessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130793/new/

  1   2   >