[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: clang/docs/ReleaseNotes.rst:243 + ``.cfg`` and ``.cfg`` if the former is not found. `Target` + is always the effective target (with respect to ``-target``, ``-m32``, etc.) + and `driver` first

[PATCH] D134733: [clang-format][chore] transparent #include name regex

MyDeveloperDay added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:400 +llvm::Regex getCppIncludeRegex() { + static const char CppIncludeRegexPattern[] = + R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; What if

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

pengfei added inline comments. Comment at: clang/test/Driver/config-file3.c:33 +// RUN: ln -s %clang %t/testdmode/x86_64-unknown-linux-gnu-clang +// RUN: echo > %t/testdmode/x86_64-unknown-linux-gnu-clang++.cfg +// RUN: echo > %t/testdmode/x86_64-unknown-linux-gnu-clang-g++.cfg

[PATCH] D134626: [clang-format] Correctly indent closing brace of compound requires

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134626/new/ https://reviews.llvm.org/D134626

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

MaskRay added a comment. Thanks. The previous behavior is too magical. I like this version. Comment at: clang/docs/ReleaseNotes.rst:243 + ``.cfg`` and ``.cfg`` if the former is not found. `Target` + is always the effective target (with respect to ``-target``, ``-m32``, etc.)

[PATCH] D132379: [Support] Class for response file expansion

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e491c48d6b9: [Support] Class for response file expansion (NFC) (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/

[clang] 6e491c4 - [Support] Class for response file expansion (NFC)

Author: Serge Pavlov Date: 2022-09-28T11:47:59+07:00 New Revision: 6e491c48d6b9cadcc5b77f730dd83a1448197329 URL: https://github.com/llvm/llvm-project/commit/6e491c48d6b9cadcc5b77f730dd83a1448197329 DIFF: https://github.com/llvm/llvm-project/commit/6e491c48d6b9cadcc5b77f730dd83a1448197329.diff

[PATCH] D132379: [Support] Class for response file expansion

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 added a comment. Here are all the details that i've said earlier Comment at: clang/lib/Parse/ParseExpr.cpp:1515 +// This is a temporary fix while we don't support C2x 6.5.2.5p4 +if (getLangOpts().C2x && GetLookAheadToken(2).getKind() == tok::l_brace) { +

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver added a comment. Decreased CPU loading during test-suite build did lower times in some instances, but not a lot. F24724990: results-subset.txt F24725002: results-full.txt Repository: rG LLVM Github Monorepo

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 463415. to268 marked 3 inline comments as done. to268 added a comment. I've fixed the diagnostic message and all of the bad TODOs comments from the Sema test. I've explained in details why i'm only able to handle `auto` in compound literals. In

[PATCH] D134749: [clang][Interp] Implement Div opcode

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:183 + + if (RHS.isZero()) { +const SourceInfo = S.Current->getSource(OpPC); Just like rem we need to catch `INT_MIN / -1` `CheckICE(...)` looks like it does checking for both in the

[PATCH] D134744: [clang][Interp] Implement rem opcode

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:164 + + if (RHS.isZero()) { +const SourceInfo = S.Current->getSource(OpPC); You also need to catch when the result is not representable e.g `INT_MIN % -1` see `CheckICE(...)`

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89e56e732d5e: [Clang] Dont warn if deferencing void pointers in unevaluated context (authored by junaire). Repository: rG LLVM Github Monorepo

[clang] 89e56e7 - [Clang] Don't warn if deferencing void pointers in unevaluated context

Author: Jun Zhang Date: 2022-09-28T12:30:02+08:00 New Revision: 89e56e732d5e89d8715a501158793ac305bc4b70 URL: https://github.com/llvm/llvm-project/commit/89e56e732d5e89d8715a501158793ac305bc4b70 DIFF: https://github.com/llvm/llvm-project/commit/89e56e732d5e89d8715a501158793ac305bc4b70.diff

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463413. mgorny retitled this revision from "[clang] [Driver] More flexible rules for loading default configs (WIP)" to "[clang] [Driver] More flexible rules for loading default configs". mgorny added a comment. Update release notes. I may have been a bit

[PATCH] D133266: [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

bd1976llvm added a comment. Whilst reviewing the impact of these dllimport/export restrictions I noticed that LLVM IR does not reject dllimport/export on local linkage globals. I have put up a PR for adding that restriction: D134784

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463408. SixWeining added a comment. Remove the first line "Assertions" in inline-asm-constraint-ZB.ll as it is not autogenerated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463404. SixWeining added a comment. Handle k and ZB in llvm/include/llvm/IR/InlineAsm.h::getMemConstraintName and add relevant tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:117 +// parsing. +R = std::string("^") + std::string(Constraint, 2); +Constraint++; MaskRay wrote: > First `std::string` can be omitted Thanks.

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463395. SixWeining marked 4 inline comments as done. SixWeining added a comment. Address comments from @rengolin and @MaskRay. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[PATCH] D134371: [clang-doc] Add typedef/using information.

haowei added a comment. In D134371#3819605 , @nemanjai wrote: > This causes failures with `-Werror` such as: > https://lab.llvm.org/buildbot/#/builders/57/builds/22322 > Please fix or revert. Thanks for reporting this. I reverted this change.

[clang-tools-extra] a759477 - Revert "[clang-doc] Add typedef/using information."

Author: Haowei Wu Date: 2022-09-27T18:35:34-07:00 New Revision: a7594772225b59ad75cd270aa261b49695985444 URL: https://github.com/llvm/llvm-project/commit/a7594772225b59ad75cd270aa261b49695985444 DIFF: https://github.com/llvm/llvm-project/commit/a7594772225b59ad75cd270aa261b49695985444.diff

[PATCH] D134371: [clang-doc] Add typedef/using information.

nemanjai added a comment. This causes failures with `-Werror` such as: https://lab.llvm.org/buildbot/#/builders/57/builds/22322 Please fix or revert. Comment at: clang-tools-extra/clang-doc/Representation.h:45 + IT_enum, + IT_typedef }; There are at least

[PATCH] D134688: MSVC AArch64 ABI: Homogeneous aggregates

dblaikie marked 2 inline comments as done. dblaikie added inline comments. Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:4478-4480 // MSVC Windows on Arm64 considers a type not HFA if it is not an // aggregate according to the C++14 spec. This is not consistent with

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

ychen added a comment. In D134772#3819551 , @mizvekov wrote: > I don't think the problem here is an uniquing problem per se, it's just that > the constraints are part of the canonical type of undeduced auto, which is > undesirable for the NTTP. > >

[PATCH] D134688: MSVC AArch64 ABI: Homogeneous aggregates

dblaikie updated this revision to Diff 463379. dblaikie added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134688/new/ https://reviews.llvm.org/D134688 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

ychen added a comment. @rsmith, thanks for chiming in. In D134772#3819502 , @rsmith wrote: > I'm somewhat skeptical of this approach, because constrained `auto` can > appear in places within the type of an NTTP other than the top level -- for >

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

thakis added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134657/new/ https://reviews.llvm.org/D134657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

mizvekov added a comment. I don't think the problem here is an uniquing problem per se, it's just that the constraints are part of the canonical type of undeduced auto, which is undesirable for the NTTP. Maybe it would work to just add a new flag parameter to `ASTContext::getAutoType` which

[clang] 697550a - [gn build] re-add hlsl.h after e432108bf254

Author: Nico Weber Date: 2022-09-27T20:16:56-04:00 New Revision: 697550ac2a5c508af397f9c936d4a0c9edf0222c URL: https://github.com/llvm/llvm-project/commit/697550ac2a5c508af397f9c936d4a0c9edf0222c DIFF: https://github.com/llvm/llvm-project/commit/697550ac2a5c508af397f9c936d4a0c9edf0222c.diff

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

rsmith added a comment. I'm somewhat skeptical of this approach, because constrained `auto` can appear in places within the type of an NTTP other than the top level -- for example, in `template`. (Clang is non-conforming and doesn't support this yet, but it will need to do so eventually.) In

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

ychen added a comment. In D134657#3819435 , @thakis wrote: > This breaks `Driver/crash-diagnostics-dir-2.c` on my mac: > > FAIL: Clang :: Driver/crash-diagnostics-dir-2.c (7510 of 15804) > TEST 'Clang ::

[clang] c4b79bf - Fix the test added in 55cd5bc50964449627f6f1

Author: Yuanfang Chen Date: 2022-09-27T16:42:55-07:00 New Revision: c4b79bf083e0c50f86f0dfe85b8bd0df1b3506a0 URL: https://github.com/llvm/llvm-project/commit/c4b79bf083e0c50f86f0dfe85b8bd0df1b3506a0 DIFF: https://github.com/llvm/llvm-project/commit/c4b79bf083e0c50f86f0dfe85b8bd0df1b3506a0.diff

[PATCH] D134371: [clang-doc] Add typedef/using information.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeed22583fd78: [clang-doc] Add typedef/using information. (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] eed2258 - [clang-doc] Add typedef/using information.

Author: Brett Wilson Date: 2022-09-27T23:35:16Z New Revision: eed22583fd78d4d657fb70b99e62fbdc1f83b8f9 URL: https://github.com/llvm/llvm-project/commit/eed22583fd78d4d657fb70b99e62fbdc1f83b8f9 DIFF: https://github.com/llvm/llvm-project/commit/eed22583fd78d4d657fb70b99e62fbdc1f83b8f9.diff LOG:

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0afc60858e11: [clang-doc] Clean up *Info constructors. (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 0afc608 - [clang-doc] Clean up *Info constructors.

Author: Brett Wilson Date: 2022-09-27T23:31:41Z New Revision: 0afc60858e1183344e0786eaa3b123f9faed185e URL: https://github.com/llvm/llvm-project/commit/0afc60858e1183344e0786eaa3b123f9faed185e DIFF: https://github.com/llvm/llvm-project/commit/0afc60858e1183344e0786eaa3b123f9faed185e.diff LOG:

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

thakis added a comment. This breaks `Driver/crash-diagnostics-dir-2.c` on my mac: FAIL: Clang :: Driver/crash-diagnostics-dir-2.c (7510 of 15804) TEST 'Clang :: Driver/crash-diagnostics-dir-2.c' FAILED Script: -- : 'RUN: at line 3';

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

ychen created this revision. ychen added reviewers: mizvekov, saar.raz, rsmith. Herald added subscribers: arphaman, martong, kristof.beyls. Herald added a reviewer: shafik. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 463351. ayzhao added a comment. add test and fix for P2092 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files:

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao added a comment. In D53847#3819200 , @cor3ntin wrote: > Good catch > > template > concept K = requires (typename T::Type X) { // (3) > X.next(); > } > > That typename should be optional. Can you add a test for that? If it works > you can

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl closed this revision. yaxunl added a comment. committed by 1172bdecfab364579d90e6aa5ba7fc64a5b96786 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705

[PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

ldionne added a comment. In D134604#3815634 , @mizvekov wrote: > I was aware of those discussions, and I even made a workaround to avoid this > extra cost of running unrelated pipelines. > The patch on the very bottom of this stack (D134079 >

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

MaskRay added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelDAGToDAG.cpp:92 + case InlineAsm::Constraint_m: { +SDValue Base, Offset; +Base = Op; Prefer initializing the variable when it is declared Comment at:

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:103 + Info.setAllowsMemory(); + Name++; // Skip over 'Z'. + return true; `++Name` Comment at: clang/lib/Basic/Targets/LoongArch.cpp:117 +//

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. GCC have implemented this yesterday , and they also apply the overload resolution change retroactively. So I've done it as well and downgraded the errors to ExtWarns. I'm not

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 463346. royjacobson added a comment. - Fix overload resolution and apply it retroactively - Allow static lambdas and static operator() as extensions - Define the feature macros in earlier versions and fix the tests Repository: rG LLVM Github Monorepo

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a reviewer: JonasToth. nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:360-361 // CSKY toolchains use different names for sysroot folder. if (!GCCInstallation.isValid()) return std::string(); // GCCInstallation.getInstallPath() =

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

phosek added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1288-1293 + llvm::Type *ComponentType; + if (UseRelativeLayout(*this)) +ComponentType = Int32Ty; + else +ComponentType = Int8PtrTy; + CharUnits ComponentWidth =

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

rengolin accepted this revision. rengolin added a comment. Looks good, with some nits. Thanks! Comment at: llvm/lib/Target/LoongArch/LoongArchAsmPrinter.cpp:76 + // TODO: handle extra code. + if (!ExtraCode) { +const MachineOperand = MI->getOperand(OpNo);

[PATCH] D134688: MSVC AArch64 ABI: Homogeneous aggregates

rnk added a comment. Nice! Mostly comment copy edits. Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:4478-4480 // MSVC Windows on Arm64 considers a type not HFA if it is not an // aggregate according to the C++14 spec. This is not consistent with the // AAPCS64,

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

cor3ntin added a comment. Good catch template concept K = requires (typename T::Type X) { // (3) X.next(); } That typename should be optional. Can you add a test for that? If it works you can mark P2092 as fully supported. Repository: rG LLVM Github

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

rnk added a comment. In D134456#3819042 , @aaron.ballman wrote: > Alternatively, we could document that we don't follow the intent of the > standard feature and that's just the way things are, and add a command line > option to honor that intent.

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver added a comment. In D134410#3816881 , @vitalybuka wrote: > Are these patches uploaded with arc tool? Yes, the patches were uploaded with `arc`. The size of the patch was too large to use the web interface. Repository: rG LLVM Github

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao added a comment. In D53847#3817376 , @cor3ntin wrote: > It's great to see this make progress. > Can you update cxx_status.html and ReleaseNotes.txt? Done. I also saw that P2092R0 was marked as partially supported in `cxx_status.html` due to

[clang] fbfb4a6 - Fix test after 5839fb6d25b4ba6edb

Author: Yuanfang Chen Date: 2022-09-27T14:01:13-07:00 New Revision: fbfb4a6359c100ac4f33982688cb0e2c299fb239 URL: https://github.com/llvm/llvm-project/commit/fbfb4a6359c100ac4f33982688cb0e2c299fb239 DIFF: https://github.com/llvm/llvm-project/commit/fbfb4a6359c100ac4f33982688cb0e2c299fb239.diff

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 463334. ayzhao added a comment. update cxx_status.html and ReleaseNotes.rst + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files:

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

mwyman added a comment. In D86049#3818981 , @plotfi wrote: > @ahatanak I can revive some of what I was working on from > https://reviews.llvm.org/D86049?id=285923 if we think we need a thunk for the > checks as @rjmccall mentioned. I believe the

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a reviewer: thesamesam. mgorny added a comment. Adding @thesamesam to reviewers since he's been testing it on Gentoo, and I'd like to get his ACK too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337

[clang] c12c26c - Fix test after 5839fb6d25b4ba6edb

Author: Yuanfang Chen Date: 2022-09-27T13:39:56-07:00 New Revision: c12c26c1768ac1525ce4240adf194c59bed11097 URL: https://github.com/llvm/llvm-project/commit/c12c26c1768ac1525ce4240adf194c59bed11097 DIFF: https://github.com/llvm/llvm-project/commit/c12c26c1768ac1525ce4240adf194c59bed11097.diff

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

aeubanks updated this revision to Diff 463327. aeubanks added a comment. mention -fno-sanitize-memory-param-retval in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134669/new/ https://reviews.llvm.org/D134669 Files:

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

wenlei added a subscriber: davidxl. wenlei added a comment. For instr PGO, changing behavior may have perf implication. cc @davidxl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:452 +-- +- ``-fsanitize-memory-param-retval`` is turned on by default. With + ``-fsanitize=memory``, passing uninitialized variables to functions and Probably I would mention that

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

aaron.ballman added a comment. In D134456#3818982 , @rnk wrote: > In D134456#3818952 , @aaron.ballman > wrote: > >> I think that would be reasonable to at least consider; the default behavior >> can be "the

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5839fb6d25b4: [Driver] pass -fcrash-diagnostics-dir to LTO (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134659: [Driver] pass -fjmc to LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG54967c01d2bb: [Driver] pass -fjmc to LTO (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134659/new/ https://reviews.llvm.org/D134659

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG55cd5bc50964: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134673/new/

[clang] 54967c0 - [Driver] pass -fjmc to LTO

Author: Yuanfang Chen Date: 2022-09-27T13:14:16-07:00 New Revision: 54967c01d2bb6daa1959865d9a780678e652419d URL: https://github.com/llvm/llvm-project/commit/54967c01d2bb6daa1959865d9a780678e652419d DIFF: https://github.com/llvm/llvm-project/commit/54967c01d2bb6daa1959865d9a780678e652419d.diff

[clang] 55cd5bc - [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

Author: Yuanfang Chen Date: 2022-09-27T13:14:16-07:00 New Revision: 55cd5bc50964449627f6f1fa82ce8268d0629d9e URL: https://github.com/llvm/llvm-project/commit/55cd5bc50964449627f6f1fa82ce8268d0629d9e DIFF: https://github.com/llvm/llvm-project/commit/55cd5bc50964449627f6f1fa82ce8268d0629d9e.diff

[clang] 5839fb6 - [Driver] pass -fcrash-diagnostics-dir to LTO

Author: Yuanfang Chen Date: 2022-09-27T13:14:16-07:00 New Revision: 5839fb6d25b4ba6edb4d9a707c75bffd178d6cc6 URL: https://github.com/llvm/llvm-project/commit/5839fb6d25b4ba6edb4d9a707c75bffd178d6cc6 DIFF: https://github.com/llvm/llvm-project/commit/5839fb6d25b4ba6edb4d9a707c75bffd178d6cc6.diff

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. In D133683#3819003 , @mizvekov wrote: > In D133683#3818935 , @ychen wrote: > >> This is described in https://eel.is/c++draft/temp.deduct.partial#13. >> Parietal ordering currently doesn't

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

aeubanks updated this revision to Diff 463322. aeubanks added a comment. rebase (to run through presubmits with test fixes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134669/new/ https://reviews.llvm.org/D134669 Files:

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

mizvekov added a comment. In D133683#3818935 , @ychen wrote: > This is described in https://eel.is/c++draft/temp.deduct.partial#13. Parietal > ordering currently doesn't consider the number of deduced arguments. During > the partial ordering stage, by

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

rnk added a comment. In D134456#3818952 , @aaron.ballman wrote: > I think that would be reasonable to at least consider; the default behavior > can be "the attribute wins" and this gives users an escape hatch to say "no, > I trust PGO more, let that

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @ahatanak I can revive some of what I was working on from https://reviews.llvm.org/D86049?id=285923 if we think we need a thunk for the checks as @rjmccall mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a subscriber: kyulee1. plotfi added a comment. In D86049#3818923 , @ahatanak wrote: > In D86049#3818696 , @plotfi wrote: > >> In D86049#3818435 , @mwyman wrote:

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

aaron.ballman added a comment. In D134456#3818548 , @thakis wrote: > Maybe we could have a `-f` flag to control whether to prefer annotations or > profile data when they conflict? I think that would be reasonable to at least consider; the default

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134702/new/ https://reviews.llvm.org/D134702 ___ cfe-commits mailing list

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0779756a0c4: [clang-format] Fix alignment in #else preprocessor blocks (authored by mitchell 56368743+mitchell-stel...@users.noreply.github.com).

[clang] c077975 - [clang-format] Fix alignment in #else preprocessor blocks

Author: mitchell Date: 2022-09-27T15:41:09-04:00 New Revision: c0779756a0c4cc84d9f98714734d47879701cc3d URL: https://github.com/llvm/llvm-project/commit/c0779756a0c4cc84d9f98714734d47879701cc3d DIFF: https://github.com/llvm/llvm-project/commit/c0779756a0c4cc84d9f98714734d47879701cc3d.diff

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. In D133683#3818887 , @mizvekov wrote: > In D133683#3818858 , @ychen wrote: > >> It is clear cut by https://eel.is/c++draft/temp.deduct.partial#3.1. It is >> orthogonal to the DRs

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added inline comments. Comment at: clang/lib/AST/Mangle.cpp:371 + OS << (MD->isInstanceMethod() ? '-' : '+'); + OS << (MD->hasMethodVisibilityDefault() ? '<' : '['); if (const auto *CID = MD->getCategory()) { ahatanak wrote: > Sorry, I might have

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

ahatanak added a comment. In D86049#3818696 , @plotfi wrote: > In D86049#3818435 , @mwyman wrote: > >> In D86049#3816006 , @plotfi wrote: >> >>> @dmaclach @ahatanak @mwyman

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

mizvekov added a comment. In D133683#3818858 , @ychen wrote: > It is clear cut by https://eel.is/c++draft/temp.deduct.partial#3.1. It is > orthogonal to the DRs implemented in D128745 > and here. >

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen updated this revision to Diff 463309. ychen added a comment. - Update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133683/new/ https://reviews.llvm.org/D133683 Files: clang/docs/ReleaseNotes.rst

[clang] 30cc712 - [Clang][OpenMP] Fix run time crash when use_device_addr is used.

Author: Jennifer Yu Date: 2022-09-27T11:53:57-07:00 New Revision: 30cc712eb6f23a5c7beaae669bf2ab6beede7f20 URL: https://github.com/llvm/llvm-project/commit/30cc712eb6f23a5c7beaae669bf2ab6beede7f20 DIFF: https://github.com/llvm/llvm-project/commit/30cc712eb6f23a5c7beaae669bf2ab6beede7f20.diff

[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

This revision was automatically updated to reflect the committed changes. jyu2 marked an inline comment as done. Closed by commit rG30cc712eb6f2: [Clang][OpenMP] Fix run time crash when use_device_addr is used. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. In D133683#3818804 , @mizvekov wrote: > In D133683#3818752 , @ychen wrote: > >> I didn't add that because this patch is logically part of D128745 >>

[PATCH] D134507: [Clang] add missing ClangABICompat check

probinson added a comment. In D134507#3818765 , @ychen wrote: > In D134507#3817928 , @probinson > wrote: > >> It feels odd to use a ClangABI check for something that is affecting what >> source is accepted, but

[PATCH] D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options

This revision was automatically updated to reflect the committed changes. Closed by commit rG86cd3535206d: [LTO][clang] Using Single Dash Consistently when Passing LTO Options (authored by Qiongsi Wu qiongsiwu@Qiongsis-MacBook-Air.local). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 86cd353 - [LTO][clang] Using Single Dash Consistently when Passing LTO Options

Author: Qiongsi Wu Date: 2022-09-27T14:50:41-04:00 New Revision: 86cd3535206d6db611260aae6f2869202eae4bb4 URL: https://github.com/llvm/llvm-project/commit/86cd3535206d6db611260aae6f2869202eae4bb4 DIFF: https://github.com/llvm/llvm-project/commit/86cd3535206d6db611260aae6f2869202eae4bb4.diff

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD updated this revision to Diff 463299. eopXD added a comment. Fix grammar error in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 Files: clang/lib/CodeGen/CGLoopInfo.cpp

[PATCH] D134507: [Clang] add missing ClangABICompat check

rjmccall added a comment. I don't think I agree that changes to template partial ordering rules are "ABI-breaking changes". They're breaking changes to *language semantics*, and the ABI break is downstream of that, just like any other semantic change to overload resolution would be. I think

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

mizvekov added a comment. In D133683#3818752 , @ychen wrote: > I didn't add that because this patch is logically part of D128745 > which has a release note already. Okay, I see that the existing release note entry

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134702/new/ https://reviews.llvm.org/D134702

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong added a comment. Yeah okay. I get it now. Thank you for your patience and your time on elaborating the issue. First, I think we'd need to fabricate a test case that shows us the bug even without applying your patch (D103096 ). Then we can iterate

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen added a comment. In D134507#3817928 , @probinson wrote: > It feels odd to use a ClangABI check for something that is affecting what > source is accepted, but this is not my area of expertise. > @aaron.ballman or @rjmccall would probably be the

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. In D133683#3817523 , @mizvekov wrote: > - Missing release notes. I didn't add that because this patch is logically part of D128745 which has a release note already. > - FWIW GCC treats the

  1   2   >