[PATCH] D130863: [clangd] Make git ignore index directories

sammccall added a comment. @sums I think this just needs minor comments addressed and can be landed. Are you still interested in finishing it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130863/new/ https://reviews.llvm.org/D130863

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is fantastic, I'm really not sure how I missed it, sorry :-( Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:857

[clang] 2f3d7c2 - [clang] Add debug info in MicrosoftCXXABI::EmitVirtualMemPtrThunk()

Author: Arthur Eubanks Date: 2022-09-28T22:06:04-07:00 New Revision: 2f3d7c2cc770c902b3a2fabc2ea92b98bf8f3e0a URL: https://github.com/llvm/llvm-project/commit/2f3d7c2cc770c902b3a2fabc2ea92b98bf8f3e0a DIFF:

[PATCH] D134825: [clang] Add debug info in MicrosoftCXXABI::EmitVirtualMemPtrThunk()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f3d7c2cc770: [clang] Add debug info in MicrosoftCXXABI::EmitVirtualMemPtrThunk() (authored by aeubanks). Repository: rG LLVM Github Monorepo

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

sammccall added a comment. I think this patch is great apart from the testing issue. (I do see the value in a good end-to-end test for the exact bug being fixed, but would also be fine with this being a unit-test of CommandMangler with the query driver part mocked out)

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

owenpan added a comment. In D134329#3822028 , @MyDeveloperDay wrote: > I guess the clang-format check might come before any building of the code. +1. > You know if we relex the "Unknown" YAML option, this would go a long way not > only to help us

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari added a comment. In D125944#3689022 , @v.g.vassilev wrote: > @Purva-Chaudhari can you rebase this patch? In D125944#3821679 , @aaron.ballman wrote: > The precommit CI failure looks relevant:

[PATCH] D119209: Implement -mctor_dtor_return_this ABI option.

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:3471 HelpText<"Set the deployment target to be the specified OS and OS version">; +def mctor_dtor_return_this : Flag<["-"], "mctor-dtor-return-this">, Group, Flags<[CC1Option]>, +

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about the long turnaround; have had some less-fun-than-code things to deal with :-) Thanks as always for patience... Main thing I'd still like is to split into two separate

[PATCH] D134384: [clangd] Add support for HeaderInsertion in .clangd config file

sammccall added a comment. Thanks, this is a great idea. It also opens the door to suppressing includes of particular files later (e.g. by regex) with another config option, though we need to be careful of performance there. Comment at: clang-tools-extra/clangd/Config.h:27

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Hmm, semantic tokens doesn't really provide a good way of "subclassing" kinds, I suppose modifiers are the best we have. It doesn't scale very well though: we're limited to 30 modifiers

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

bcl5980 updated this revision to Diff 463746. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134788/new/ https://reviews.llvm.org/D134788 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Based on the stacktrace, I came up with this crashing example, maybe it's a usable testcase? template class X { template class Y { using Y<0>::xxx; }; }; (not currently

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

bcl5980 updated this revision to Diff 463744. bcl5980 added a comment. add warning when /arm64EC has been override CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134788/new/ https://reviews.llvm.org/D134788 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[clang] 2d23175 - [clang-format] Fix a bug with C++ `export import `

Author: owenca Date: 2022-09-28T19:10:12-07:00 New Revision: 2d23175fae989f90a09e556542309cd5a903e7cc URL: https://github.com/llvm/llvm-project/commit/2d23175fae989f90a09e556542309cd5a903e7cc DIFF: https://github.com/llvm/llvm-project/commit/2d23175fae989f90a09e556542309cd5a903e7cc.diff LOG:

[PATCH] D134700: [clang-format] Fix a bug with C++ `export import `

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d23175fae98: [clang-format] Fix a bug with C++ `export import Foo/Bar` (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131698: [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case.

michele.scandale updated this revision to Diff 463727. michele.scandale added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131698/new/ https://reviews.llvm.org/D131698 Files: clang/lib/Sema/TreeTransform.h

[PATCH] D119209: Implement -mctor_dtor_return_this ABI option.

scw updated this revision to Diff 463722. scw edited the summary of this revision. scw added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Rebased and updated comments and option explain text to only affect Itanium C++ ABI. Repository: rG LLVM Github Monorepo

[PATCH] D134319: [HLSL] add ceil library function

bob80905 updated this revision to Diff 463720. bob80905 added a comment. - whitespace try 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D134369: [Clang] Support constexpr builtin fmax

Izaron updated this revision to Diff 463715. Izaron added a comment. Rebase and fix windows __float128 failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134369/new/ https://reviews.llvm.org/D134369 Files: clang/docs/LanguageExtensions.rst

[PATCH] D134369: [Clang] Support constexpr builtin fmax

Izaron added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:14033-14034 +!EvaluateFloat(E->getArg(1), RHS, Info)) + return false; +if (Result.isNaN() || RHS > Result) + Result = RHS; jcranmer-intel wrote: > If I'm reading

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

ychen added a comment. Herald added subscribers: pcwang-thead, abrachet. Herald added a reviewer: ThomasRaoux. Herald added a project: All. It is possible to just use `clang-format @response.txt`? That should also invoke the executable once. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen updated this revision to Diff 463702. samitolvanen added a comment. Added a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134831/new/ https://reviews.llvm.org/D134831 Files: clang/docs/ReleaseNotes.rst

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8686 +def warn_cast_function_type_strict : Warning, + InGroup, DefaultIgnore; def err_cast_pointer_to_non_pointer_int : Error< nickdesaulniers wrote: > I don't

[PATCH] D134838: [clang][deps] NFC: Expose more flexible version of `Worker::computeDependencies()`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds new

[PATCH] D134369: [Clang] Support constexpr builtin fmax

efriedma added a comment. > We shouldn't be claiming that except maybe if we're using -fp-model=strict Makes sense. > I'm wondering what needs to happen with that for regular floating-point > operations that may trigger exceptions In general, floating-point exceptions are affected by whether

[PATCH] D134837: [libclang] Split-out some data structures out of `Index.h`

jansvoboda11 created this revision. jansvoboda11 added reviewers: akyrtzi, benlangmuir. Herald added subscribers: ributzka, arphaman. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `Index.h`

[PATCH] D134825: [clang] Add debug info in MicrosoftCXXABI::EmitVirtualMemPtrThunk()

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me. (Ah, I see, that chrome bug actually hit the underlying problem, not even the verifier constraint - when the constraint is violated & not detected, then code gets

[PATCH] D134319: [HLSL] add ceil library function

bob80905 updated this revision to Diff 463680. bob80905 added a comment. - adhere to clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D134369: [Clang] Support constexpr builtin fmax

jcranmer-intel added a comment. In D134369#3821949 , @efriedma wrote: > I think __builtin_fmax can raise a floating-point exception; in that case, it > wouldn't be constant, I think? Not sure how consistent we are about handling > that sort of thing

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. SGTM; please make a note of this new diagnostic flag in clang/docs/ReleaseNotes.rst under `Improvements to Clang's diagnostics`. Comment at:

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen added reviewers: pcc, nickdesaulniers, kees. samitolvanen added a comment. Any thoughts about adding a stricter version of -Wcast-function-type to make it easier to catch potential CFI issues? I also considered also gating this behind `-fsanitize=cfi-icall/kcfi`, but having a

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen created this revision. Herald added a project: All. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang supports indirect call Control-Flow Integrity (CFI) sanitizers (e.g. -fsanitize=cfi-icall), which enforce

[PATCH] D88976: [clang] Use correct address space for global variable debug info

arsenm added a comment. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88976/new/ https://reviews.llvm.org/D88976

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

MyDeveloperDay added a comment. I'm not sure what version of clang-format they use in the premerge checks, I don't know who we contact to get it updated. I guess the clang-format check might come before any building of the code. You know if we relex the "Unknown" YAML option, this would go a

[PATCH] D134825: [clang] Add debug info in MicrosoftCXXABI::EmitVirtualMemPtrThunk()

aeubanks updated this revision to Diff 463669. aeubanks edited the summary of this revision. aeubanks added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134825/new/ https://reviews.llvm.org/D134825 Files:

[PATCH] D134801: [clang][Interp] Implement ConditionalOperators

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:357 + + if (!this->visit(Condition)) +return false; tbaeder wrote: > shafik wrote: > > Maybe I am misunderstanding what this is doing but can't we just check the > > result

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri added a comment. CI fail noted, update will come. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

owenpan added a comment. In D134329#3817601 , @MyDeveloperDay wrote: > Unfortunately this is causing the failing the "premerge checks" on reviews > likely because this machine is using an earlier version of clang-format Isn't this the case for any new

[PATCH] D134825: [clang] Add debug info in MicrosoftCXXABI::EmitVirtualMemPtrThunk()

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/microsoft-abi-member-pointers-debug-info.cpp:13 + +// CHECK: ![[DBG]] = !DILocation( + might be worth checking what location this is, to show it's a good one? (the code added makes some choice

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134733: [clang-format][chore] transparent #include name regex

MyDeveloperDay added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:407 +const llvm::SmallVectorImpl ) { + if (Matches.size() >= 3) { +return Matches[2]; kwk wrote: > MyDeveloperDay wrote: > > ‘>= 2’ > @MyDeveloperDay

[PATCH] D134369: [Clang] Support constexpr builtin fmax

efriedma added reviewers: jcranmer-intel, john.brawn, fhahn, sepavloff. efriedma added a comment. I think __builtin_fmax can raise a floating-point exception; in that case, it wouldn't be constant, I think? Not sure how consistent we are about handling that sort of thing in constant evaluation

[PATCH] D134825: [clang] Add debug info in MicrosoftCXXABI::EmitVirtualMemPtrThunk()

aeubanks updated this revision to Diff 463661. aeubanks added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134825/new/ https://reviews.llvm.org/D134825 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

nridge added a comment. Speculative fix for an infinite recursion with no testcase. I'm happy to circle back to this if/when we get a testcase, but I don't think there's any downside to this patch in the meantime. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

nridge created this revision. nridge added reviewers: sammccall, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D134825: [clang] Add debug info in MicrosoftCXXABI::EmitVirtualMemPtrThunk()

aeubanks created this revision. aeubanks added a reviewer: rnk. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://crbug.com/1355639 Repository: rG LLVM Github Monorepo

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

arsenm added a comment. Can this be abandoned now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128907/new/ https://reviews.llvm.org/D128907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134824: Fix frint ACLE intrinsic names

michaelplatings created this revision. michaelplatings added a reviewer: jaykang10. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Although the instruction names begin "frint", the ACLE spec

[clang-tools-extra] d4a6513 - try to fix build more after 16544cbe64b8

Author: Nico Weber Date: 2022-09-28T15:35:46-04:00 New Revision: d4a6513aeffac6b0fc30895714c5b421a3e0757d URL: https://github.com/llvm/llvm-project/commit/d4a6513aeffac6b0fc30895714c5b421a3e0757d DIFF: https://github.com/llvm/llvm-project/commit/d4a6513aeffac6b0fc30895714c5b421a3e0757d.diff

[PATCH] D129298: Add denormal-fp-math attribute for f16

arsenm added a comment. Reverse ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129298/new/ https://reviews.llvm.org/D129298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] a181de4 - [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

Author: Martin Sebor Date: 2022-09-28T13:27:58-06:00 New Revision: a181de452df311d7647329120d05f4eb9c158b6c URL: https://github.com/llvm/llvm-project/commit/a181de452df311d7647329120d05f4eb9c158b6c DIFF: https://github.com/llvm/llvm-project/commit/a181de452df311d7647329120d05f4eb9c158b6c.diff

[PATCH] D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa181de452df3: [clang] handle extended integer constant expressions in _Static_assert (PR… (authored by msebor). Changed prior to commit:

[clang-tools-extra] 74bab7d - try to fix build after 16544cbe64b8

Author: Nico Weber Date: 2022-09-28T15:18:15-04:00 New Revision: 74bab7d4a075a69b4d012ea7b91a0a4bd4822ad9 URL: https://github.com/llvm/llvm-project/commit/74bab7d4a075a69b4d012ea7b91a0a4bd4822ad9 DIFF: https://github.com/llvm/llvm-project/commit/74bab7d4a075a69b4d012ea7b91a0a4bd4822ad9.diff

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri created this revision. ekieri added reviewers: awarzynski, peixin, sscalpone. Herald added projects: Flang, All. ekieri requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a project: clang. Add --undefined=_QQmain to the link line, so

[PATCH] D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75be0482a2e2: [clang][DebugInfo] Emit debuginfo for non-constant case value (authored by yonghong-song). Repository: rG LLVM Github Monorepo

[clang] 75be048 - [clang][DebugInfo] Emit debuginfo for non-constant case value

Author: Yonghong Song Date: 2022-09-28T12:10:48-07:00 New Revision: 75be0482a2e2a78fae83f1ca604f4ee20d673796 URL: https://github.com/llvm/llvm-project/commit/75be0482a2e2a78fae83f1ca604f4ee20d673796 DIFF: https://github.com/llvm/llvm-project/commit/75be0482a2e2a78fae83f1ca604f4ee20d673796.diff

[PATCH] D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value

yonghong-song updated this revision to Diff 463643. yonghong-song added a comment. - simplify test case, add more CHECK's and add comments to explain the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134705/new/

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber:

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added a comment. In D131465#3812424 , @rnk wrote: > A simple rule like "clang 16.0 raised the default C++ standard version to 17, > except on PS4" seems preferable. Agreed that a simple rule is a good target for us to aim for. In

[PATCH] D125944: Template instantiation error recovery

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. The precommit CI failure looks relevant: TEST 'Clang :: Interpreter/template-recovery.cpp' FAILED Script: -- : 'RUN: at line 1';

[clang] 2ad41f9 - Repairing the release notes

Author: Aaron Ballman Date: 2022-09-28T14:34:37-04:00 New Revision: 2ad41f97f87ad94f4a6e536a0e9027fb954d651e URL: https://github.com/llvm/llvm-project/commit/2ad41f97f87ad94f4a6e536a0e9027fb954d651e DIFF: https://github.com/llvm/llvm-project/commit/2ad41f97f87ad94f4a6e536a0e9027fb954d651e.diff

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

efriedma added a comment. Please add a testcase verifying the interaction between "/arm64EC" and explicitly specifying "--target". (If we end up ignoring the "/arm64EC" flag, we probably want a warning.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134797: [X86][vectorcall] Make floating-type passed by value to match with MSVC

rnk added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1858-1859 } -return getIndirectResult(Ty, /*ByVal=*/false, State); +bool ByVal = IsVectorCall && Ty->isFloatingType(); +return getIndirectResult(Ty, ByVal, State); } I

[PATCH] D130510: Missing tautological compare warnings due to unary operators

aaron.ballman added a comment. In D130510#3817148 , @ebevhan wrote: > Hi! A bit of late feedback on this patch. We found a failure in our > downstream testing likely originating from here. Thank you for the feedback! I've addressed the issue in

[clang] 96a79cb - Fix a tautological comparison bug caught during post-commit

Author: Aaron Ballman Date: 2022-09-28T14:23:28-04:00 New Revision: 96a79cb308d1b8c00a83b180d9fecc5d54bacb9c URL: https://github.com/llvm/llvm-project/commit/96a79cb308d1b8c00a83b180d9fecc5d54bacb9c DIFF: https://github.com/llvm/llvm-project/commit/96a79cb308d1b8c00a83b180d9fecc5d54bacb9c.diff

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

beanz added a comment. I think this approach mostly looks sane to me. @phosek, and @Ericson2314 may have different feedback. Comment at: clang/lib/Support/CMakeLists.txt:23 + # libLLVM-*.so). + llvm_add_library(clangSupport_tablegen +STATIC Unless there

[PATCH] D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add the release note when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134311/new/ https://reviews.llvm.org/D134311

[PATCH] D134801: [clang][Interp] Implement ConditionalOperators

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:357 + + if (!this->visit(Condition)) +return false; shafik wrote: > Maybe I am misunderstanding what this is doing but can't we just check the > result of the condition and

[PATCH] D134801: [clang][Interp] Implement ConditionalOperators

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:357 + + if (!this->visit(Condition)) +return false; Maybe I am misunderstanding what this is doing but can't we just check the result of the condition and then just visit

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

reames added a comment. Please add to the review description a link to the appropriate specification. Please update docs/RISCVUsage.rst to add Zcmt, and link to the specification. It's impossible to review e.g. encoding without knowing what you're implementing. Comment

[PATCH] D134640: Unwind-tables: move back to original logic outline for kind.

abrachet added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134640/new/ https://reviews.llvm.org/D134640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:376 + if (getTriple().isMIPS()) { +const Multilib = GCCInstallation.getMultilib(); +Path = Path + "/libc" + Multilib.osSuffix(); nickdesaulniers wrote: > It might

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60727d856927: [C2x] implement typeof and typeof_unqual (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 60727d8 - [C2x] implement typeof and typeof_unqual

Author: Aaron Ballman Date: 2022-09-28T13:27:52-04:00 New Revision: 60727d856927383daf304fcf8f19fcc8ade828ad URL: https://github.com/llvm/llvm-project/commit/60727d856927383daf304fcf8f19fcc8ade828ad DIFF: https://github.com/llvm/llvm-project/commit/60727d856927383daf304fcf8f19fcc8ade828ad.diff

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:363 const StringRef TripleStr = GCCInstallation.getTriple().str(); - const Multilib = GCCInstallation.getMultilib(); + std::string Path = (InstallDir + "/../../../../" +

[PATCH] D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

msebor added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16733 + while (auto *BaseCast = dyn_cast(BaseExpr)) +BaseExpr = BaseCast->getSubExpr(); +} aaron.ballman wrote: > tbaeder wrote: > > There is `Expr::ignoreParenImpCasts()`

[PATCH] D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

msebor updated this revision to Diff 463607. msebor marked an inline comment as done. msebor added a comment. Changes from previous version: - Replace loop with `Expr::IgnoreImpCasts()`. - Use a multiline comment in a test to improve readability. CHANGES SINCE LAST ACTION

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Otherwise LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134804/new/ https://reviews.llvm.org/D134804 ___ cfe-commits mailing list

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

shafik added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:72 +static_assert(~-1 == 0, ""); +static_assert(~255 == -256, ""); + Some more tests covering `~INT_MIN == INT_MAX` and vice versa and unscoped enum case as well e.g. ``` enum E {}; E

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3821183 , @plotfi wrote: > In D86049#3819109 , @mwyman wrote: > >> In D86049#3818981 , @plotfi wrote: >> >>> @ahatanak I can revive some of

[PATCH] D134815: [Sema] print more readable identifier of anonymous struct of -Wconsumed

aaron.ballman added a comment. FWIW, I approached this in a slightly different way here: https://reviews.llvm.org/D134813 -- I've not landed it yet because I'm still hoping I can find a way to not modify lit just to fix one fragile test, but I think we ultimately want to go this other route

[PATCH] D134815: [Sema] print more readable identifier of anonymous struct of -Wconsumed

inclyc created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. inclyc published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Working in D133574 we discovered -Wconsumed

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:649 + +if (!ElemT) + return false; shafik wrote: > Curious what case requires this check? I don't think there's a real test case for this, we could as well change the

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:649 + +if (!ElemT) + return false; Curious what case requires this check? Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:382 + ByteCodeExprGen

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4848f3bf2ff5: [C++2a] P0634r3: Down with typename! (authored by Rakete, committed by ayzhao). Changed prior to commit:

[clang] 4848f3b - [C++2a] P0634r3: Down with typename!

Author: Nicolas Lesser Date: 2022-09-28T09:50:19-07:00 New Revision: 4848f3bf2ff5ec57a8e2b8d3676c947dcf0fd735 URL: https://github.com/llvm/llvm-project/commit/4848f3bf2ff5ec57a8e2b8d3676c947dcf0fd735 DIFF:

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

aaron.ballman added a comment. In D134578#3821301 , @ayzhao wrote: > In D134578#3821178 , @ilya-biryukov > wrote: > >> Is this the only thing that blocks D53847 ? >> I suggest to

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

ahatanak added a comment. In D86049#3819109 , @mwyman wrote: > In D86049#3818981 , @plotfi wrote: > >> @ahatanak I can revive some of what I was working on from >> https://reviews.llvm.org/D86049?id=285923 if we

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f2b34789541: Add missing `struct` keyword to the test p2-2.cpp (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134578/new/

[clang] 6f2b347 - Add missing `struct` keyword to the test p2-2.cpp

Author: Alan Zhao Date: 2022-09-28T09:48:00-07:00 New Revision: 6f2b34789541ff95d7f339eac5dc031d29655a58 URL: https://github.com/llvm/llvm-project/commit/6f2b34789541ff95d7f339eac5dc031d29655a58 DIFF: https://github.com/llvm/llvm-project/commit/6f2b34789541ff95d7f339eac5dc031d29655a58.diff

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

ayzhao added a comment. In D134578#3821178 , @ilya-biryukov wrote: > Is this the only thing that blocks D53847 ? > I suggest to stamp this if so (happy to do it myself). In case @ChuanqiXu > will have comments we can

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134286/new/ https://reviews.llvm.org/D134286 ___ cfe-commits mailing list

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1515 +// This is a temporary fix while we don't support C2x 6.5.2.5p4 +if (getLangOpts().C2x && GetLookAheadToken(2).getKind() == tok::l_brace) { + Diag(Tok,

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/AST/Decl.cpp:4480 + // the tag is anonymous and we should print it differently. + if (Name.isIdentifier() &&

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added a comment. Moving this to a top level discussion because it's easier to write replies here than in an inline comment. >> If it's that the tool is trying to get the type information purely from the >> string representation, maybe the tool should be doing things differently - >>

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134286/new/ https://reviews.llvm.org/D134286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 4824059 - Moving some C papers around on the status page; NFC

Author: Aaron Ballman Date: 2022-09-28T12:37:52-04:00 New Revision: 4824059c1a7d1b03c0e01b4ba4b0c53305e22d0a URL: https://github.com/llvm/llvm-project/commit/4824059c1a7d1b03c0e01b4ba4b0c53305e22d0a DIFF: https://github.com/llvm/llvm-project/commit/4824059c1a7d1b03c0e01b4ba4b0c53305e22d0a.diff

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG44ad67031cc1: [clang][msan] Turn on -fsanitize-memory-param-retval by default (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 44ad670 - [clang][msan] Turn on -fsanitize-memory-param-retval by default

Author: Arthur Eubanks Date: 2022-09-28T09:36:39-07:00 New Revision: 44ad67031cc1a10483337f8b1f728e2be237685e URL: https://github.com/llvm/llvm-project/commit/44ad67031cc1a10483337f8b1f728e2be237685e DIFF:

  1   2   >