[PATCH] D134626: [clang-format] Correctly indent closing brace of compound requires

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fa115b56979: [clang-format] Correctly indent closing brace of compound requires (authored by rymiel). Repository: rG LLVM Github Monorepo

[clang] 1fa115b - [clang-format] Correctly indent closing brace of compound requires

Author: Emilia Dreamer Date: 2022-10-01T08:16:57+03:00 New Revision: 1fa115b569797f64988f3d8ddd8baa05574aafa3 URL: https://github.com/llvm/llvm-project/commit/1fa115b569797f64988f3d8ddd8baa05574aafa3 DIFF:

[PATCH] D135011: Add sin and cos llvm intrinsics

bob80905 updated this revision to Diff 464472. bob80905 added a comment. - make format consistent, update test copy mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files:

[PATCH] D135011: Add sin and cos llvm intrinsics

bob80905 updated this revision to Diff 464471. bob80905 added a comment. rever format commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D135011: Add sin and cos llvm intrinsics

bob80905 created this revision. bob80905 added reviewers: beanz, python3kgae. Herald added a project: All. bob80905 requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. add codegen for llvm cos and sin intrinsics Repository: rG

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:2774 - -const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; kwk wrote: > owenpan wrote: > > kwk wrote: > > > MyDeveloperDay wrote: > > > >

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 464465. lime added a comment. I rearranged the error messages. But after I rebased this patch on D126907 , the file `p3-2a.cpp` no longer passed. So I did some investigations there .

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 464447. bob80905 added a comment. revert revision, remove int overloads Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files:

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

nridge added a comment. Thanks for the testcases! The indirect one is particularly interesting, and suggests that we may want a "seen decls" set (similar to `SeenTemplates` here ) in

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman added a comment. In D131424#3828647 , @ahatanak wrote: > `-fobjc-arc` is needed to see the assertion fail. Oops, yep I'll send a patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

ahatanak added a comment. `-fobjc-arc` is needed to see the assertion fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

ahatanak added a comment. It looks like this patch causes an assertion to fail (`Assertion failed: (it != LocalDeclMap.end() && "Invalid argument to GetAddrOfLocalVar(), no decl!")`) when the following code is compiled. __attribute__((objc_direct_members)) @interface C @property id prop;

[PATCH] D134115: [clang] Store in exprs the deduced arguments for function calls.

mizvekov updated this revision to Diff 464434. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134115/new/ https://reviews.llvm.org/D134115 Files: clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h

[PATCH] D134143: [clang] Misc type sugar preservation improvements

mizvekov updated this revision to Diff 464435. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134143/new/ https://reviews.llvm.org/D134143 Files: clang/lib/Sema/SemaCXXScopeSpec.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaType.cpp

[PATCH] D134921: [HLSL] add cos library function

python3kgae added a comment. In D134921#3828545 , @bob80905 wrote: > - lower cos to llvm This will affect things outside HLSL. Please create a new PR without HLSL related part. Sorry I didn't make things clear before :(. You can copy what

[PATCH] D134998: [HLSL] [Driver] Add -no-legacy-cbuf-layout to control layout for cbuffer.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Two new options

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 464428. bob80905 added a comment. - lower cos to llvm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

nickdesaulniers added inline comments. Comment at: clang/lib/Lex/TokenLexer.cpp:1008-1013 +assert(!Partition.empty() && + llvm::all_of(Partition.drop_front(), +[](const Token ) { + return SM.getFileID(( -

[clang-tools-extra] d4e8109 - [clang-tidy] Skip variadic ctors in modernize-use-equals-default

Author: Alexander Shaposhnikov Date: 2022-09-30T22:16:28Z New Revision: d4e81097ea3daf37b5480281a17ad5b20cd7ee8d URL: https://github.com/llvm/llvm-project/commit/d4e81097ea3daf37b5480281a17ad5b20cd7ee8d DIFF:

[PATCH] D134929: [clang-tidy] Skip variadic ctors in use-equals-default

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4e81097ea3d: [clang-tidy] Skip variadic ctors in modernize-use-equals-default (authored by alexander-shaposhnikov). Changed prior to commit: https://reviews.llvm.org/D134929?vs=464115=464417#toc

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

nickdesaulniers added a comment. In D134942#3827216 , @hokein wrote: > Some more perf data on building linux kernel (x86_64) > > before: getFileID 2.4% (1.10% on `getFileIDSlow`) > after: getFileID 2.35% (1.05% on `getFileIDSlow`) What compiler was used

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 464407. bob80905 added a comment. - remove double Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added a comment. In D134453#3826832 , @aaron.ballman wrote: > In D134453#3825902 , @dblaikie > wrote: > >> Again, I'm not advocating for the printing as-is, I think adding the top >> level

[PATCH] D125142: [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

MaskRay added a comment. Add the option to `Group` instead of adding a custom diagnostic code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 ___ cfe-commits

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

jcranmer-intel added a comment. Some extra constexpr tests that may be interesting: - Constant expressions that produce floating point exceptions other than `FE_INEXACT`. - Subnormal values as operands, as well as operations with normal operands that produce denormal values (i.e., check for

[PATCH] D125142: [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

srhines accepted this revision. srhines added a comment. Thank you, Kees and reviewers, for helping to make progress here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167 + for (const auto : Fn->args()) { +if (Param.hasStructRetAttr()) { + // FIXME: support output. beanz wrote: > python3kgae wrote: > > beanz wrote: > > > I might be

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 464392. python3kgae marked an inline comment as done. python3kgae added a comment. Insert position value for sret output to make a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/

[PATCH] D125142: [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3464-3465 + D.Diag(diag::warn_ignored_clang_option) + << "-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-" + "from-clang"; CmdArgs.push_back(

[PATCH] D134977: [clang][deps] NFC: Respect working directory on construction

jansvoboda11 updated this revision to Diff 464387. jansvoboda11 added a comment. Always check input exists. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134977/new/ https://reviews.llvm.org/D134977 Files:

[PATCH] D134744: [clang][Interp] Implement rem opcode

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134744/new/ https://reviews.llvm.org/D134744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added a comment. In D128465#3826150 , @mgorny wrote: > Is anyone working on a solution that would work for people using a zstd > install method that's actually supported upstream? I have created D134990 , it'd

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen added a comment. In D134831#3827861 , @nathanchance wrote: > If you want to move on it quicker, feel free to draft a commit message and > slap my Suggested-by on it.

[PATCH] D125142: [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

kees updated this revision to Diff 464381. kees added a comment. Keep git-clang-format happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 Files: clang/docs/ReleaseNotes.rst

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

craig.topper added a comment. In D134671#3824644 , @nickdesaulniers wrote: > I don't think it's an issue for us to work around downstream, but this did > regress support for `-mabi=ms` used in UEFI related build scripts. >

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

efriedma added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.nontype/p1-11.cpp:31 IP<> ip7; // expected-error{{non-type template argument of type 'int *' is not a constant expression}} +IP<(int*)1> ip8; // expected-error {{non-type template argument does

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

rsmith added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.nontype/p1-11.cpp:31 IP<> ip7; // expected-error{{non-type template argument of type 'int *' is not a constant expression}} +IP<(int*)1> ip8; // expected-error {{non-type template argument does not

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167 + for (const auto : Fn->args()) { +if (Param.hasStructRetAttr()) { + // FIXME: support output. python3kgae wrote: > beanz wrote: > > I might be missing something, but I'm

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167 + for (const auto : Fn->args()) { +if (Param.hasStructRetAttr()) { + // FIXME: support output. beanz wrote: > I might

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167 + for (const auto : Fn->args()) { +if (Param.hasStructRetAttr()) { + // FIXME: support output. I might be missing something, but I'm not seeing a test that exercises the

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

erichkeane added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.nontype/p1-11.cpp:31 IP<> ip7; // expected-error{{non-type template argument of type 'int *' is not a constant expression}} +IP<(int*)1> ip8; // expected-error {{non-type template argument does

[PATCH] D120862: Sema: Allow scoped enums as source type for integral conversion.

pcc added a comment. Ping^2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120862/new/ https://reviews.llvm.org/D120862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

efriedma updated this revision to Diff 464363. efriedma added a comment. Add release note. Add test coverage for C++17, since it uses a different codepath. (The C++17 codepath appears to work correctly without any changes.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Thank you for the feedback! In D131939#3822766 , @njames93 wrote: > I have a feeling the default should be to only warm in loops otherwise this > could get noisy. Agreed, the less noisy version was already the default,

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank updated this revision to Diff 464362. nicovank added a comment. Rename OnlyWarnInLoops to WarnOutsideLoops, cover missed cxxForRangeStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 Files:

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

erichkeane updated this revision to Diff 464360. erichkeane marked 4 inline comments as done. erichkeane added a comment. Do all the things Tom requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134874/new/ https://reviews.llvm.org/D134874 Files:

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

erichkeane added a comment. In D134334#3827895 , @shafik wrote: > In D134334#3805590 , @erichkeane > wrote: > >> I have no real idea what is going on here, the parser isn't an area where I >> spend much time.

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

serge-sans-paille added a comment. In D134791#3827722 , @msebor wrote: > Thanks for the heads up! My only general comment is that unless this change > has no externally observable effect I'd suggest adding tests. (Otherwise, > noting it has no such

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 464354. python3kgae marked an inline comment as done. python3kgae added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files:

[libunwind] f5c9931 - [libunwind] Fix compile error with CROSS_UNWINDING

Author: Florian Mayer Date: 2022-09-30T12:04:19-07:00 New Revision: f5c9931fefcab8de07a6c08c39b582fa58859dc9 URL: https://github.com/llvm/llvm-project/commit/f5c9931fefcab8de07a6c08c39b582fa58859dc9 DIFF: https://github.com/llvm/llvm-project/commit/f5c9931fefcab8de07a6c08c39b582fa58859dc9.diff

[PATCH] D134650: [runtimes] Remove all traces of the legacy testing configuration system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa48f018bb7d8: [runtimes] Remove all traces of the legacy testing configuration system (authored by ldionne). Repository: rG LLVM Github Monorepo

[PATCH] D134650: [runtimes] Remove all traces of the legacy testing configuration system

ldionne updated this revision to Diff 464351. ldionne added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134650/new/ https://reviews.llvm.org/D134650 Files: clang/cmake/caches/CrossWinToARMLinux.cmake

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

python3kgae added inline comments. Comment at: clang/test/SemaHLSL/resource_binding_attr_error.hlsl:51 +} + +struct S { aaron.ballman wrote: > Let's add another test for a local extern, like: > ``` > void func() { > extern RWBuffer U : register(u5); > } > ```

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

python3kgae updated this revision to Diff 464346. python3kgae marked 3 inline comments as done. python3kgae added a comment. Ignore local extern decl when check ExternalGlobalVar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134617/new/

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

shafik added a comment. In D134334#3805590 , @erichkeane wrote: > I have no real idea what is going on here, the parser isn't an area where I > spend much time. Can you ELI5? I am going to try but perhaps fail to explain this in more detail and more

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

nathanchance added a comment. In D134831#3827790 , @samitolvanen wrote: > In D134831#3827730 , > @nickdesaulniers wrote: > >> Please get the patch disabling this warning for the kernel in flight before >>

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

dexonsmith added a comment. SGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125142: [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

kees updated this revision to Diff 464337. kees retitled this revision from "[clang][auto-init] Remove -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang" to "[clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang". kees added

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

MaskRay added a comment. > While cross-compiling Linux kernel tools with Clang on ArchLinux, it was > revealed the sysroot is not properly detected and instead of fixing the root > cause in Clang, kernel developers started doing workarounds [1] upon > workarounds [2] in the kernel build to be

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

aaron.ballman added a reviewer: jcranmer-intel. aaron.ballman added a subscriber: jcranmer-intel. aaron.ballman added a comment. I've not given this a full review yet, but I do have some comments on a partial review. Mostly, I'm concerned we're going to have different semantics when evaluating

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

erichkeane marked 9 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:510 - /*Pattern*/ nullptr, - /*LookBeyondLambda*/ true); if

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

This revision was automatically updated to reflect the committed changes. Closed by commit rG9415aad6a40f: [Clang] Fix variant crashes from GH58028, GH57370 (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134885/new/

[clang] 9415aad - [Clang] Fix variant crashes from GH58028, GH57370

Author: Roy Jacobson Date: 2022-09-30T21:17:34+03:00 New Revision: 9415aad6a40fec74296008a25f34164a95c857f4 URL: https://github.com/llvm/llvm-project/commit/9415aad6a40fec74296008a25f34164a95c857f4 DIFF: https://github.com/llvm/llvm-project/commit/9415aad6a40fec74296008a25f34164a95c857f4.diff

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen added a comment. In D134831#3827730 , @nickdesaulniers wrote: > Please get the patch disabling this warning for the kernel in flight before > landing this. Agreed. @nathanchance do you want to send the patch above to LKML? Repository:

[PATCH] D134976: [clang][deps] Abolish FileManager sharing

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134976/new/ https://reviews.llvm.org/D134976

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 464332. paulkirth added a comment. rebase and change implementation to include provenance information directly in the MD_prof metadata Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/

[PATCH] D134977: [clang][deps] NFC: Respect working directory on construction

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch provides

[PATCH] D134976: [clang][deps] Abolish FileManager sharing

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes the

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Please get the patch disabling this warning for the kernel in flight before landing this. It's going to make a lot of CI red due to kernel builds enabling `-Werror`.

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM assuming precommit CI doesn't find any surprises, thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134831/new/ https://reviews.llvm.org/D134831

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

msebor added a comment. Thanks for the heads up! My only general comment is that unless this change has no externally observable effect I'd suggest adding tests. (Otherwise, noting it has no such effect would be helpful.) When I'm not familiar with the code (and often even what I am) I

[PATCH] D134475: [AST] Add C++11 attribute msvc::constexpr

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Thank you for this! I think it's heading in the right direction, but we're missing some significant test coverage for it. I had some suggestions for specific things we should be thinking about, but another useful test

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen updated this revision to Diff 464326. samitolvanen marked 3 inline comments as done. samitolvanen added a comment. Addressed feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134831/new/ https://reviews.llvm.org/D134831 Files:

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

aaron.ballman added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2817-2818 + void MaybeParseHLSLSemantics(Declarator , + SourceLocation *EndLoc = nullptr) { +if (Tok.is(tok::colon)) { Let's assert we're in

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

tahonermann added a comment. The refactoring looks like a good improvement to me. I think there may be some opportunities to make it more robust. I did some spot checking that previous behavior is retained, but didn't exhaustively do such checking; it does look like many of the changes were

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

aaron.ballman added a comment. In D134456#3827579 , @dexonsmith wrote: > In D134456#3827478 , @aaron.ballman > wrote: > >> In D134456#3827410 , @dexonsmith >> wrote:

[PATCH] D134974: [OpenMP] Add map clause to the LIT test on use_device_addr clause

animeshk-amd created this revision. animeshk-amd added reviewers: saiislam, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. animeshk-amd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D134654: [clang] Detect header loops

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/warn-loop-macro-1.h:3 +#define LOOP_MACRO_1 +// expected-warning@+1 {{#include cycle}} +#include "warn-loop-macro-1.h" erichkeane wrote: > aaron.ballman wrote: > > For example, as a user, I

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:366 + "'Zcmt' (table jump instuctions for code-size reduction)", + [FeatureExtZca]>; // TODO: add Zicsr as another dependence +def HasStdExtZcmt :

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:367 + [FeatureExtZca]>; // TODO: add Zicsr as another dependence +def HasStdExtZcmt : Predicate<"Subtarget->hasStdExtZcmt() && !Subtarget->hasStdExtC()">, +

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please address the concern by @martong before landing. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134654: [clang] Detect header loops

erichkeane added inline comments. Comment at: clang/test/Preprocessor/warn-loop-macro-1.h:3 +#define LOOP_MACRO_1 +// expected-warning@+1 {{#include cycle}} +#include "warn-loop-macro-1.h" aaron.ballman wrote: > For example, as a user, I would look at this

[PATCH] D134923: [clang][deps] Canonicalize module map path

benlangmuir updated this revision to Diff 464313. benlangmuir added a comment. Canonicalize path separator(s) in between the (already canonicalized directory) and the filename. This could cause issues with redundant path separators (`foo//bar`) or non-native separators (`foo/bar` vs `foo\bar`

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

nickdesaulniers added a comment. In D134454#3824630 , @MaskRay wrote: > Another opinion is whether we actually need the more and more complex sysroot > computation logic. > Inferring sysroot from GCCInstallation looks backward to me. We should get >

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

dexonsmith added a comment. In D134456#3827478 , @aaron.ballman wrote: > In D134456#3827410 , @dexonsmith > wrote: > >> In D134456#3827377 , >> @aaron.ballman wrote:

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

MaskRay added a comment. In D134337#3827522 , @nickdesaulniers wrote: > In D134337#3824862 , @MaskRay wrote: > >> It's unclear Clang wants to support GCC style specs file and whether GCC >> wants to adopt

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:367 + [FeatureExtZca]>; // TODO: add Zicsr as another dependence +def HasStdExtZcmt : Predicate<"Subtarget->hasStdExtZcmt() && !Subtarget->hasStdExtC()">, +

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

erichkeane added a comment. In D134885#3827535 , @royjacobson wrote: > In D134885#3827479 , @shafik wrote: > >> In D134885#3826335 , @royjacobson >> wrote: >> >>>

[PATCH] D134911: [clang][DebugInfo] Respect fmodule-file-home-is-cwd in skeleton CUs for clang modules

rmaz accepted this revision. rmaz added a comment. This revision is now accepted and ready to land. Nice, LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134911/new/ https://reviews.llvm.org/D134911

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson updated this revision to Diff 464309. royjacobson added a comment. Lock the test to standard version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134885/new/ https://reviews.llvm.org/D134885 Files: clang/lib/Sema/SemaInit.cpp

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson added a comment. In D134885#3827479 , @shafik wrote: > In D134885#3826335 , @royjacobson > wrote: > >> Apparently some of the workers crashed with the test - >>

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

nickdesaulniers added a comment. In D134337#3824862 , @MaskRay wrote: > It's unclear Clang wants to support GCC style specs file and whether GCC > wants to adopt another system beside its specs. > I lean toward there isn't much cooperation as we might

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

nickdesaulniers added a comment. In D20401#3824713 , @sammccall wrote: > Thanks Nick for the info! No kernel experience here, so if you have any > particular suggestions about how to measure the workload you care about it'd > be much appreciated (e.g.

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

shafik added a comment. In D134885#3826335 , @royjacobson wrote: > Apparently some of the workers crashed with the test - > https://lab.llvm.org/buildbot/#/builders/216/builds/10556, but I couldn't > reproduce this locally. @shafik any idea why the

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

aaron.ballman added a comment. In D134456#3827410 , @dexonsmith wrote: > In D134456#3827377 , @aaron.ballman > wrote: > >> Ah, I see, thank you for clarifying! Does that seem like a generally useful >>

[PATCH] D134177: Add MC support of RISCV Zcd Extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134177/new/ https://reviews.llvm.org/D134177

[PATCH] D134176: Add MC support of RISCV Zcf Extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134176/new/ https://reviews.llvm.org/D134176

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

erichkeane added a comment. Only thing I can think of is the 'Aggregate' calculation for this diagnostic is going wrong somewhere. See SemaDeclcXX.cpp ~6759 for where this all happens. Aggregate IS initialized correctly to 'true' in CXXRecordDecl's DefinitionData as far as I can tell. BUT I

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

balazske marked an inline comment as done. balazske added a comment. I added a simple detection of create a copy of `p` before `p = realloc(p, ...)`. This can remove the warning at very obvious cases when a copy of `p` is created (but even if the copy is made inside an `if` branch for example).

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

dexonsmith added a comment. In D134456#3827377 , @aaron.ballman wrote: > In D134456#3827332 , @dexonsmith > wrote: > >> In D134456#3827263 , >> @aaron.ballman wrote:

  1   2   3   >