[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

MyDeveloperDay added a comment. I know I have situations where I like `inline` and `static` to be in a certain order to avoid them getting constantly swapped around, they are never going to be after the type but I still want them the same way, I'd be ok with allow `friend` for the same reason.

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:809 Style.AllowShortCaseLabelsOnASingleLine); +IO.mapOptional("AllowShortCompoundRequirementOnASingleLine", +

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin updated this revision to Diff 482372. gonglingqin added a comment. Address @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139915/new/ https://reviews.llvm.org/D139915 Files:

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin added a comment. In D139915#3991089 , @xen0n wrote: > Linux only requires `__cpucfg` among the ones you just added. Please amend > the patch summary so it's more accurate. > > Otherwise LGTM, thanks! Thanks for your review, I will modify

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

xen0n added a comment. Linux only requires `__cpucfg` among the ones you just added. Please amend the patch summary so it's more accurate. Otherwise LGTM, thanks! Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:797 +ASRT_LE_GT_CASE(asrtle_d) +

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG as there seem to be only nits left. We can expand on this in tree Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:184 + + auto

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

ChuanqiXu updated this revision to Diff 482360. ChuanqiXu added a comment. Update as the dependent one changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.llvm.org/D137059 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added a comment. > (I'd probably still reduce the test down to one example, using -o and > skipping the extra OUTPUT_PATH details, only checking the last part of the > path is as specified (or perhaps checking that it matches the .o file?)) Done. > Also, could you consider the

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 482359. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. - Reduce the test down to one example, using -o and skipping the extra OUTPUT_PATH details - as the comment required. CHANGES SINCE LAST ACTION

[clang] cd50f91 - [Clang][NFC] Prevent lit tests from matching substrings in current path

Author: Sameer Sahasrabuddhe Date: 2022-12-13T11:18:39+05:30 New Revision: cd50f910f4d1a6bb54fd8968f067febbc7320f28 URL: https://github.com/llvm/llvm-project/commit/cd50f910f4d1a6bb54fd8968f067febbc7320f28 DIFF:

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. Sweet. Thanks again, Nathan. Guys, lmk how you'd like to go from here. If you approve; feel free to copy in/land as part of the other change if that would save time. (I don't have commit access anyway.) CHANGES SINCE LAST ACTION

[PATCH] D139910: [NFC] Cleanup: Remove Function::getBasicBlockList() when not required.

vporpo created this revision. vporpo added reviewers: aeubanks, asbirlea. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, mattd, awarzynski, sdasgup3, wenzhicui, wrengr, ormris, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,

[PATCH] D139906: [IR][NFC] Adds Function::insertBasicBlockAt() to replace things like F->getBasicBlockList().insert()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa19ae77d2a90: [IR][NFC] Adds Function::insertBasicBlockAt() to replace things like F… (authored by vporpo). Changed prior to commit:

[clang] a19ae77 - [IR][NFC] Adds Function::insertBasicBlockAt() to replace things like F->getBasicBlockList().insert()

Author: Vasileios Porpodas Date: 2022-12-12T20:22:55-08:00 New Revision: a19ae77d2a9016428fee7cd5af03fd20ad6d4464 URL: https://github.com/llvm/llvm-project/commit/a19ae77d2a9016428fee7cd5af03fd20ad6d4464 DIFF:

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

benshi001 added a comment. This patch fixes https://github.com/llvm/llvm-project/issues/58877 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139908/new/ https://reviews.llvm.org/D139908 ___ cfe-commits

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D139395: Add CFI integer types normalization

pcc added a comment. In D139395#3990772 , @rcvalle wrote: > I elaborated on the reasons why not use a generalized encoding in the design > document in the tracking issue > https://github.com/rust-lang/rust/issues/89653. The tl;dr; is that it will >

[PATCH] D139395: Add CFI integer types normalization

rcvalle added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2952 + // uu + if (NormalizeIntegers && T->isInteger()) { +if (T->isSignedInteger()) { pcc wrote: > `isInteger()` will return true for enums, but only if they are complete. This >

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. Some nits. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:132 + +OptimizationLevel getptLevel(unsigned OptLevel) { + switch (OptLevel) { typo Comment at:

[PATCH] D139395: Add CFI integer types normalization

rcvalle added a comment. I elaborated on the reasons why not use a generalized encoding in the design document in the tracking issue https://github.com/rust-lang/rust/issues/89653. The tl;dr; is that it will result in less comprehensive protection by either using a generalized encoding for all

[PATCH] D139906: [IR][NFC] Adds Function::insertBasicBlockAt() to replace things like F->getBasicBlockList().insert()

vporpo created this revision. vporpo added reviewers: aeubanks, asbirlea. Herald added subscribers: zzheng, hiraditya. Herald added a project: All. vporpo requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is part of a

[PATCH] D139395: Add CFI integer types normalization

pcc added a reviewer: pcc. pcc added a comment. A high level question is whether we want to base the cross-language encoding on Itanium at all. Itanium has concepts such as substitutions that will complicate the implementation in other languages. Encoding pointee types can also lead to

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#3989814 , @cor3ntin wrote: > Hey. Thanks a lot for working on this. > I did a first pass, looking at mostly style issues, looking at conformance > will probably take me a lot more time, but i think this looks pretty

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 482331. ychen marked 2 inline comments as done. ychen added a comment. - Address Corentin's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D139450: Warn about unsupported ibmlongdouble

qiucf added inline comments. Comment at: clang/test/Driver/lit.local.cfg:26 +if config.ppc_linux_default_ieeelongdouble == "ON": + config.available_features.add('ppc_linux_default_ieeelongdouble') tuliom wrote: > qiucf wrote: > > Can we assume if we are

[PATCH] D139045: [HIP] support --offload-arch=native

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3058 // Collect all offload arch parameters, removing duplicates. + const StringRef NativeArchStr = "native"; std::set GpuArchs; tra

[PATCH] D139295: [Coroutines] Don't mark the parameter attribute of resume function as noalias

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dccdd76b374: [Coroutines] Dont mark the parameter attribute of resume function as noalias (authored by ChuanqiXu). Herald added a project: clang.

[clang] 7dccdd7 - [Coroutines] Don't mark the parameter attribute of resume function as noalias

Author: Chuanqi Xu Date: 2022-12-13T10:19:24+08:00 New Revision: 7dccdd76b3749508f4a4147b0ba1f7f2689bebb2 URL: https://github.com/llvm/llvm-project/commit/7dccdd76b3749508f4a4147b0ba1f7f2689bebb2 DIFF: https://github.com/llvm/llvm-project/commit/7dccdd76b3749508f4a4147b0ba1f7f2689bebb2.diff

[PATCH] D139395: Add CFI integer types normalization

nickdesaulniers added subscribers: hjl.tools, rjmccall. nickdesaulniers added a comment. Thanks for the patch and the work on cross language CFI support! I wonder if we have precedent for other non-standard extensions to `ItaniumMangleContextImpl`? I wonder if we should perhaps have a distinct

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5545 +if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) + TempPath = FinalOutput->getValue(); +else + TempPath = BaseInput; + It'd be nice if we didn't

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 482327. rcvalle added a comment. Added ".normalized" suffix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst

[clang] f7a1f7a - Fix test on 32-bit targets.

Author: Richard Smith Date: 2022-12-12T17:38:51-08:00 New Revision: f7a1f7ab70eadd8264db2d3f956a1a6bab749c01 URL: https://github.com/llvm/llvm-project/commit/f7a1f7ab70eadd8264db2d3f956a1a6bab749c01 DIFF: https://github.com/llvm/llvm-project/commit/f7a1f7ab70eadd8264db2d3f956a1a6bab749c01.diff

[clang] 5982b0b - Add missing check for constant evaluation of a comparison of a pointer

Author: Richard Smith Date: 2022-12-12T17:09:26-08:00 New Revision: 5982b0b0b84296e34057a777e3d51e10fcd8abc7 URL: https://github.com/llvm/llvm-project/commit/5982b0b0b84296e34057a777e3d51e10fcd8abc7 DIFF: https://github.com/llvm/llvm-project/commit/5982b0b0b84296e34057a777e3d51e10fcd8abc7.diff

[PATCH] D139749: Headers: make a couple of builtins non-static

fsb4000 accepted this revision. fsb4000 added a comment. This revision is now accepted and ready to land. I also asked at MS STL Discord(https://discord.gg/XWanNww) about the patch. F25588619: изображение.png Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added a comment. https://reviews.llvm.org/D139889 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 ___ cfe-commits mailing list

[PATCH] D139889: [Clang] Fix a crash when encountering an ill-formed delimited UCN.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. \u{...} was incorrectly parsed as a valid UCN instead of emitting a diagnostic, causing an assertion failure.

[PATCH] D136554: Implement CWG2631

dankm added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9688 +} +return llvm::None; + } llvm::None has been deprecated in favour of std::nullopt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added a comment. In D138861#3988954 , @tahonermann wrote: > @cor3ntin, I suspect the answer is no, but do your changes perhaps address > this assertion failure? https://godbolt.org/z/1bPcPcWzv > > int \u1{234}; Interesting bug. No, it

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 482279. cor3ntin added a comment. Fix caret position Fix tests (defining a macro named 'a' caused issues) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files:

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:4819-4831 +// When we don't have 16 bit instructions, bf16 is illegal and gets +// softened to i16 for storage, with float being used for arithmetic. +// +// After softening, some

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

tahonermann added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5542 + // + // FIXME: Do we need to handle the case that the calculated output is + // conflicting with the specified output file or the input file? + if (!AtTopLevel && isa(JA) &&

[PATCH] D139045: [HIP] support --offload-arch=native

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:3058 // Collect all offload arch parameters, removing duplicates. + const StringRef NativeArchStr = "native";

[PATCH] D131655: [analyzer] Nullability: Enable analysis of non-inlined nullable objc properties.

NoQ added a comment. F25587055: obama.jpg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131655/new/ https://reviews.llvm.org/D131655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc73876db4f2d: Reapply DebugInfo: Add/support new DW_LANG codes for recent C and C++… (authored by dblaikie). Changed prior to commit: https://reviews.llvm.org/D138597?vs=480590=482273#toc Repository:

[clang] c73876d - Reapply "DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions""

Author: David Blaikie Date: 2022-12-12T22:36:23Z New Revision: c73876db4f2dfd2c38d5720f62509e57f23b2059 URL: https://github.com/llvm/llvm-project/commit/c73876db4f2dfd2c38d5720f62509e57f23b2059 DIFF: https://github.com/llvm/llvm-project/commit/c73876db4f2dfd2c38d5720f62509e57f23b2059.diff

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1594 + if (VarDecl *VD = dyn_cast(DRE->getDecl())) { +if (VD->isLocalVarDecl()) { + Diag(DRE->getLocation(), massberg wrote: > shafik wrote: > > So if we look at

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

owenpan added a comment. In D139801#3989812 , @HazardyKnusperkeks wrote: > My idea would be hardcoded `friend` as first entry, regardless of the chosen > sequence. > But others may have a different opinion on that. It would be confusing with

[clang] 6ab01d4 - [analyzer] Nullability: Enable analysis of non-inlined nullable objc properties.

Author: Paul Pelzl Date: 2022-12-12T14:19:26-08:00 New Revision: 6ab01d4a5cbd46f521de89b167571c0754e6c557 URL: https://github.com/llvm/llvm-project/commit/6ab01d4a5cbd46f521de89b167571c0754e6c557 DIFF: https://github.com/llvm/llvm-project/commit/6ab01d4a5cbd46f521de89b167571c0754e6c557.diff

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

amyk added a comment. In D138675#3989997 , @tblah wrote: > In D138675#3989826 , @amyk wrote: > >> Thanks for the follow up patch! I tested the patch locally and also saw the >> buildbot results, and it doesn't

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim added a comment. Herald added subscribers: Enna1, abrachet, MaskRay. Herald added a project: All. Partially merged (making -fsanitize=scudo use scudo_standalone) merged in D138157 . Will probably re-use this in a bit to add the dangling scudo tests to

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. In D129531#3988996 , @ilya-biryukov wrote: > Since the errors only shows up in modular builds, I would look closely for > bugs inside `ASTReader`/`ASTWriter`. > Also, it seems that `ArrayFiller` is not taken in to account in >

[PATCH] D131655: [analyzer] Nullability: Enable analysis of non-inlined nullable objc properties.

NoQ added a comment. (thanks @usama54321 for having a look and talking to me about this offline!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131655/new/ https://reviews.llvm.org/D131655 ___ cfe-commits mailing list

[PATCH] D131655: [analyzer] Nullability: Enable analysis of non-inlined nullable objc properties.

NoQ added a comment. Guess I'll commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131655/new/ https://reviews.llvm.org/D131655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 482261. ayzhao added a comment. rebase + some compiler warning fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

tblah added a comment. In D138675#3989826 , @amyk wrote: > Thanks for the follow up patch! I tested the patch locally and also saw the > buildbot results, and it doesn't appear like the follow up patch marked > `powerpc` as unsupported as the error

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille created this revision. serge-sans-paille added a reviewer: nikic. Herald added subscribers: steakhal, pmatos, asb, jhenderson, abrachet, ormris, martong, phosek, kadircet, arphaman, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: JDevlieghere. Herald

[PATCH] D139006: [UpdateTestChecks] Match define for labels

nikic added a comment. In D139006#3988227 , @sebastian-ne wrote: > In D139006#3988215 , @mkazantsev > wrote: > >> So now every single test needs to be regenerated? It'll create straw diff >> from nowhere... >

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

NoQ added a comment. Ok so at the conference @ymandel suggested us to use libTooling's Transformers API to make our lives easier (https://clang.llvm.org/docs/ClangTransformerTutorial.html). I'm fairly certain we should at least consider using them, but I haven't looked into it deeply enough

[PATCH] D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg

shafik added a comment. In D139713#3989709 , @Pierre-vh wrote: > In D139713#3989071 , @shafik wrote: > >> If I am reading the code correctly it looks like if the call to >> `(*I)->isValueDependent()` is true

[clang] 06911ba - [NFC] Cleanup: Replaces BB->getInstList().insert() with I->insertAt().

Author: Vasileios Porpodas Date: 2022-12-12T13:33:05-08:00 New Revision: 06911ba6ea1e552d3bcaed2728c92a9aa6cbf4d2 URL: https://github.com/llvm/llvm-project/commit/06911ba6ea1e552d3bcaed2728c92a9aa6cbf4d2 DIFF:

[PATCH] D138877: [NFC] Cleanup: Replaces BB->getInstList().insert() with I->insertAt().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06911ba6ea1e: [NFC] Cleanup: Replaces BB-getInstList().insert() with I-insertAt(). (authored by vporpo). Repository: rG LLVM Github Monorepo

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added a subscriber: urnathan. dblaikie added a comment. (I'd probably still reduce the test down to one example, using `-o` and skipping the extra `OUTPUT_PATH` details, only checking the last part of the path is as specified (or perhaps checking that it matches the .o file?)) Also,

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

dblaikie accepted this revision. dblaikie added a comment. In D137059#3989856 , @dblaikie wrote: > Nathan had a few questions in the cross-project flag naming thread - could > you check/reply to those? I think the right answer is probably "do whatever

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

dblaikie added a comment. Nathan had a few questions in the cross-project flag naming thread - could you check/reply to those? I think the right answer is probably "do whatever -o does" but would be good to verify that behavior makes sense, maybe explicitly test it in some way if it's

[PATCH] D138877: [NFC] Cleanup: Replaces BB->getInstList().insert() with I->insertAt().

vporpo added a comment. Herald added a subscriber: kmitropoulou. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138877/new/ https://reviews.llvm.org/D138877 ___ cfe-commits mailing list

[PATCH] D139045: [HIP] support --offload-arch=native

yaxunl updated this revision to Diff 482240. yaxunl added a comment. fix error handling CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139045/new/ https://reviews.llvm.org/D139045 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/AMDGPU.h Index:

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This LGTM. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2084-2089 + // On Apple platforms, C and C++ Standard Library headers are not provided + // with the base

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

amyk added a comment. In D138675#3989634 , @tblah wrote: > In D138675#3989403 , @amyk wrote: > >> Hi, >> >> The ppc64le-flang-rhel-clang >> bot is also experiencing

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. Hey. Thanks a lot for working on this. I did a first pass, looking at mostly style issues, looking at conformance will probably take me a lot more time, but i think this looks pretty good overall Comment at: clang/include/clang/AST/DeclCXX.h:1911

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

HazardyKnusperkeks added a comment. In D139801#3989284 , @red1bluelost wrote: > In D139801#3988790 , > @HazardyKnusperkeks wrote: > >> If only the first, I'd say we do that without adding this option. > > I'll

[PATCH] D139045: [HIP] support --offload-arch=native

yaxunl updated this revision to Diff 482234. yaxunl retitled this revision from "[HIP] use detected GPU in --offload-arch" to "[HIP] support --offload-arch=native". yaxunl edited the summary of this revision. yaxunl added a comment. use detected GPU when --offload-arch=native is specified based

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

jamieschmeiser accepted this revision. jamieschmeiser added a comment. This revision is now accepted and ready to land. LGTM Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720

[clang-tools-extra] c187182 - [clangd] Add a missing header guard for InsertionPoint.h

Author: Haojian Wu Date: 2022-12-12T21:25:29+01:00 New Revision: c187182429fb3c8af09827b816c1cb8976bc93e7 URL: https://github.com/llvm/llvm-project/commit/c187182429fb3c8af09827b816c1cb8976bc93e7 DIFF: https://github.com/llvm/llvm-project/commit/c187182429fb3c8af09827b816c1cb8976bc93e7.diff

[PATCH] D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg

Pierre-vh added a comment. In D139713#3989071 , @shafik wrote: > If I am reading the code correctly it looks like if the call to > `(*I)->isValueDependent()` is true then the temporary will not be created and > therefore we should not be attempting to

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 added a comment. In D139720#3989651 , @jamieschmeiser wrote: > I'm fine with handling the return for common as a separate change, if > necessary. Sounds good! In this case I will fix it in a different patch once we decide what exactly to

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

jamieschmeiser added a comment. I'm fine with handling the return for common as a separate change, if necessary. Is the error produced now because it passes back the incorrect option rather than quietly changing it to something appropriate as it did before? Repository: rG LLVM Github

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

tblah added a comment. In D138675#3989403 , @amyk wrote: > Hi, > > The ppc64le-flang-rhel-clang > bot is also experiencing some failures with the `Driver/fast_math.f90` test > case. In particular,

[PATCH] D138210: [clang] Require parameter pack to be last argument in concepts.

dblaikie added a comment. In D138210#3989385 , @luken-google wrote: > committed at afd800fc5679ccfe6f32b097586c658628500867 > For future reference it's handy to include the

[PATCH] D139868: [clang][dataflow] Change the diagnoser API to receive a correctly typed lattice element

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:134 +PostVisitCFG = +[=](ASTContext , const CFGElement , +const

[clang] 11b9c79 - [Clang] Try to fix test on Windows (NFC)

Author: Nikita Popov Date: 2022-12-12T20:36:35+01:00 New Revision: 11b9c7943bad1915e3ba096b597af3d050048d53 URL: https://github.com/llvm/llvm-project/commit/11b9c7943bad1915e3ba096b597af3d050048d53 DIFF: https://github.com/llvm/llvm-project/commit/11b9c7943bad1915e3ba096b597af3d050048d53.diff

[PATCH] D139868: [clang][dataflow] Change the diagnoser API to receive a correctly typed lattice element Previously, the diagnoser could only receive the Environment at a given program point. Now, it

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...lattice element. Repository:

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7793e676514b: [ZOS] Convert tests to check target={{.*}}-zos{{.*}} (authored by probinson). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 7793e67 - [ZOS] Convert tests to check 'target={{.*}}-zos{{.*}}'

Author: Paul Robinson Date: 2022-12-12T11:25:19-08:00 New Revision: 7793e676514bc102e97a993e90257e8628069a8b URL: https://github.com/llvm/llvm-project/commit/7793e676514bc102e97a993e90257e8628069a8b DIFF: https://github.com/llvm/llvm-project/commit/7793e676514bc102e97a993e90257e8628069a8b.diff

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

nridge added a comment. Thanks, Christian, for your work on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 ___ cfe-commits mailing list

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

amyk added a comment. Hi, The ppc64le-flang-rhel-clang bot is also experiencing some failures with the `Driver/fast_math.f90` test case. In particular, `crtfastmath.o` is not found at all for `CHECK-CRT` as we can see in the failure details

[PATCH] D138210: [clang] Require parameter pack to be last argument in concepts.

luken-google closed this revision. luken-google added a comment. committed at afd800fc5679ccfe6f32b097586c658628500867 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138210/new/

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.llvm.org/D139444 ___ cfe-commits mailing list

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

red1bluelost added a comment. In D139801#3988790 , @HazardyKnusperkeks wrote: > If only the first, I'd say we do that without adding this option. I'll work on doing this without adding the option. (Just reread and noticed you had answered what I asked

[PATCH] D139485: [LLVM] Remove redundant .c_str() and .get() calls where they are not needed.

shafik added inline comments. Comment at: lldb/source/API/SBPlatform.cpp:14 #include "lldb/API/SBLaunchInfo.h" -#include "lldb/API/SBPlatform.h" #include "lldb/API/SBUnixSignals.h" These redundant header removals looks unrelated and should be done as a

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Builds passed now. I think this looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148

[PATCH] D136554: Implement CWG2631

aeubanks added a comment. I'm fine with relanding and seeing if anything else pops up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 ___ cfe-commits mailing

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. Thanks @Kai and @uweigand, good to know a z/OS bot is in the works. Hope this patch now meets your needs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.llvm.org/D139444 ___ cfe-commits

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson updated this revision to Diff 482180. probinson added a comment. Herald added a subscriber: delcypher. Define 'system-zos' and use it in the one test that needs it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.llvm.org/D139444 Files:

[clang] fc7b8e7 - [test] Fix dr324.c again for non-writeable source directories

Author: Jordan Rupprecht Date: 2022-12-12T10:11:19-08:00 New Revision: fc7b8e71312f89986be1a7cc67377a2decfcf337 URL: https://github.com/llvm/llvm-project/commit/fc7b8e71312f89986be1a7cc67377a2decfcf337 DIFF:

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

red1bluelost added a comment. I would always want it first. I agree that `friend` would always go first. Had I not accidentally typed in the wrong order I probably wouldn't have know `friend` could be in any position. In the case of putting `friend` always first, would we want a user facing

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

Kai added a comment. In D139444#3988544 , @probinson wrote: > Searching the buildbot console page for 'zos' turns up nothing; 's390' turns > up clang-s390x-linux, clang-s390x-linux-lnt, mlir-s390x-linux. Are there any > zos hosted bots? I.e., is this

[clang] b7ada67 - [lit] Use 'target=' in a few more places

Author: Paul Robinson Date: 2022-12-12T09:58:38-08:00 New Revision: b7ada67f1c28ae67c61578dd3bc8acb4d8d55d28 URL: https://github.com/llvm/llvm-project/commit/b7ada67f1c28ae67c61578dd3bc8acb4d8d55d28 DIFF: https://github.com/llvm/llvm-project/commit/b7ada67f1c28ae67c61578dd3bc8acb4d8d55d28.diff

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

Kai added a comment. In D139444#3978189 , @uweigand wrote: > In D139444#3975182 , @probinson > wrote: > >> The changes in this patch assume that there aren't any possible suffixes >> after the `-zos` part of

  1   2   3   >