[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD updated this revision to Diff 487302. eopXD added a comment. Update code: Avoid emit clang version in test case. @pcwang-thead Thank you for checking and providing the corresponding resolution. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

pcwang-thead added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vlenb.c:33 +// RV32: !2 = !{i32 1, !"SmallDataLimit", i32 0} +// RV32: !3 = !{!"clang version 16.0.0 (g...@github.com:llvm/llvm-project.git e80f0cc0a318fe8473ba460d6a16166d81b303b1)"} +//

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added a comment. On the other hand, the LLVM coding standards talk about "implementation file". Ok, will leave as is. Then I'd say it's ready for review! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

thesamesam updated this revision to Diff 487296. thesamesam added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141248/new/ https://reviews.llvm.org/D141248 Files: clang/bindings/python/tests/cindex/util.py Index:

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

thesamesam updated this revision to Diff 487295. thesamesam added a comment. Set CLANG_NO_DEFAULT_CONFIG in environment instead to reduce cat-and-mouse issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141248/new/

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added a comment. In D141000#4034307 , @carlosgalvezp wrote: > Since we are at it - are we happy with the name > "ImplementationFileExtensions"? I think "SourceFileExtensions" is more common > in the literature, and it would look more

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

mgorny added reviewers: jbcoe, bkramer. mgorny added a comment. I'm wondering if we shouldn't just by setting `CLANG_NO_DEFAULT_CONFIG=1` like in clang's test suite rather than tying to predict how different config files will affect these tests. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD updated this revision to Diff 487293. eopXD marked 5 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141032/new/ https://reviews.llvm.org/D141032 Files:

[PATCH] D136817: [RISCV] Add H extension

kito-cheng added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136817/new/ https://reviews.llvm.org/D136817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

pcwang-thead added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1579 + llvm::Function *F = +CGM.getIntrinsic(llvm::Intrinsic::read_register, {Int64Ty}); + return Builder.CreateCall(F, Metadata); craig.topper wrote: >

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1579 + llvm::Function *F = +CGM.getIntrinsic(llvm::Intrinsic::read_register, {Int64Ty}); + return Builder.CreateCall(F, Metadata); pcwang-thead wrote: >

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

thesamesam created this revision. thesamesam added a reviewer: mgorny. Herald added a subscriber: arphaman. Herald added a project: All. thesamesam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In Gentoo, we make use of Clang's

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

pcwang-thead accepted this revision. pcwang-thead added a comment. This revision is now accepted and ready to land. The code is OK to me, except that a few small comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1579 + llvm::Function *F = +

[clang] 2893bcd - [NFC] Fix the test failure in 08f957808e5f7e44b11d in armv8

Author: Chuanqi Xu Date: 2023-01-09T11:54:17+08:00 New Revision: 2893bcd6cd88310da9ba4a37c142c6db463ba79e URL: https://github.com/llvm/llvm-project/commit/2893bcd6cd88310da9ba4a37c142c6db463ba79e DIFF: https://github.com/llvm/llvm-project/commit/2893bcd6cd88310da9ba4a37c142c6db463ba79e.diff

[PATCH] D141226: [WIP][clangd] support expanding `decltype(expr)`

v1nh1shungry added a comment. If this is okay to go ahead, I'm considering renaming the tweak. Does `ExpandType` or `ExpandDeducedType` sound good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141226/new/ https://reviews.llvm.org/D141226

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

h-vetinari added a comment. > BTW, the series of clang-scan-deps patch (https://reviews.llvm.org/D139168) > is also necessary [...] Yes, I meant both those series. > [...] but I am not sure if we can land them in time. I guess it may be > possible to backport these patches to 16.x since it is

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08f957808e5f: [C++20] [Modules] Dont generate global ctors/dtors for variables which are… (authored by ChuanqiXu). Herald added a project: clang.

[clang] 08f9578 - [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Author: Chuanqi Xu Date: 2023-01-09T10:48:43+08:00 New Revision: 08f957808e5f7e44b11d5e9015925955fe1e9d32 URL: https://github.com/llvm/llvm-project/commit/08f957808e5f7e44b11d5e9015925955fe1e9d32 DIFF: https://github.com/llvm/llvm-project/commit/08f957808e5f7e44b11d5e9015925955fe1e9d32.diff

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added a comment. > FWIW, the same with should happen with -MT. Yeah, it should be. Since the patch reuses the previous logics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 ___

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ben.boeckel added a comment. In D139168#4034885 , @ChuanqiXu wrote: > @Arthapz Great to hear that! It is pretty important for us to know there are > more build systems which are using these functionality. BTW, for header > units, it is still under

[PATCH] D141023: [C++20] [Modules] Make placement allocation functions always acceptable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee1be282241b: [C++20] [Modules] Make placement allocation functions always visible (authored by ChuanqiXu). Herald added a project: clang. Herald

[clang] ee1be28 - [C++20] [Modules] Make placement allocation functions always visible

Author: Chuanqi Xu Date: 2023-01-09T10:40:23+08:00 New Revision: ee1be282241b1253847e663af000f7082b7f03a3 URL: https://github.com/llvm/llvm-project/commit/ee1be282241b1253847e663af000f7082b7f03a3 DIFF: https://github.com/llvm/llvm-project/commit/ee1be282241b1253847e663af000f7082b7f03a3.diff

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added a comment. > Hi, just wanted to say that i added support of these patch to XMake (i built > a LLVM with your 4 patches) and it work pretty well :) (except for header > units) @Arthapz Great to hear that! It is pretty important for us to know there are more build systems which

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added a comment. In D137058#4033825 , @h-vetinari wrote: > Without undue haste, I just wanted to comment from the peanut gallery that it > would be amazing if the patches that are necessary for CMake + Clang to use > C++ modules would make

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu added a comment. gentle ping @jansvoboda11 . sorry for the a little bit hurried ping since LLVM-16 is going to be branched in the 24th of January. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137534/new/ https://reviews.llvm.org/D137534

[PATCH] D141240: [SVE][Builtins] Add metadata to intrinsic calls for builtins that don't define the result of inactive lanes.

paulwalker-arm updated this revision to Diff 487247. paulwalker-arm added a comment. Fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141240/new/ https://reviews.llvm.org/D141240 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D141240: [SVE][Builtins] Add metadata to intrinsic calls for builtins that don't define the result of inactive lanes.

paulwalker-arm created this revision. Herald added subscribers: ctetreau, psnobl, hiraditya, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. paulwalker-arm requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 487243. seanptmaher added a comment. Update python formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files:

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

xazax.hun added a comment. > Here is the gist of one *new* TP: Where would `sprops` get escaped? Did I miss that or was that reduced out of the example? Overall, this looks like a hard nut to crack. Escaping too much or too little are both problematic, and we don't have the information we

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mati865 added a comment. In D141206#4034451 , @mstorsjo wrote: > In D141206#4034159 , @mati865 wrote: > >> I had thought we do that already so this change looks reasonable for me. >> Just one thought, do we

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vaadd.c:3 // REQUIRES: riscv-registered-target -// RUN: %clang_cc1 -triple riscv64 -target-feature +v -disable-O0-optnone -emit-llvm %s -o - | opt

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mstorsjo added a comment. In D141206#4034451 , @mstorsjo wrote: > In D141206#4034159 , @mati865 wrote: > >> I had thought we do that already so this change looks reasonable for me. >> Just one thought, do we

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mstorsjo added a comment. In D141206#4034159 , @mati865 wrote: > I had thought we do that already so this change looks reasonable for me. > Just one thought, do we support multilib toolchains? I think in that case > Clang would have to add `/include`

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher created this revision. seanptmaher added a reviewer: MyDeveloperDay. Herald added a project: All. seanptmaher requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the implementation of clang-format-diff.py to

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:674 +else if (const auto *ND = dyn_cast(Context)) { + if (ND->isInlineNamespace()) +Scopes.AccessibleScopes.push_back(printQualifiedName(*ND) + "::");

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD marked 2 inline comments as done. eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1565 + unsigned long __rv = 0; + __asm__ __volatile__ ("csrr\t%0, vlenb" : "=r"(__rv) : : "memory"); + return __rv; pcwang-thead wrote:

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD updated this revision to Diff 487206. eopXD marked an inline comment as not done. eopXD added a comment. Update code. Apply suggestion from @pcwang-thead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141032/new/

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added a comment. In D141000#4034305 , @Eugene.Zelenko wrote: > It'll be good idea to check that `HeaderFileExtensions` and > `ImplementationFileExtensions` do not overlap. Good idea, done! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 487202. carlosgalvezp added a comment. Add check to ensure HeaderFileExtensions and ImplementationFileExtensions do not overlap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh updated this revision to Diff 487200. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files: clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaExpr.cpp clang/test/AST/Interp/shifts.cpp clang/test/C/drs/dr0xx.c

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added a comment. Since we are at it - are we happy with the name "ImplementationFileExtensions"? I think "SourceFileExtensions" is more common in the literature, and it would look more visually pleasing in the config file since it has the same length as "HeaderFileExtensions".

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added a comment. I've heard Clang 16 will be branched out on 24th January, it would be good to get this merged by then (if people are happy with it) so the full removal can happen in clang-tidy 18 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

Eugene.Zelenko added a comment. It'll be good idea to check that `HeaderFileExtensions` and `ImplementationFileExtensions` do not overlap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/ https://reviews.llvm.org/D141000

[PATCH] D141226: [WIP][clangd] support expanding `decltype(expr)`

v1nh1shungry created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Enable the existing code action

[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG310eea1c78e3: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants (authored by TIFitis). Repository: rG LLVM Github

[clang] 310eea1 - [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

Author: Akash Banerjee Date: 2023-01-08T16:45:43Z New Revision: 310eea1c78e3e7aac7c016ab9bdf00d04f354645 URL: https://github.com/llvm/llvm-project/commit/310eea1c78e3e7aac7c016ab9bdf00d04f354645 DIFF: https://github.com/llvm/llvm-project/commit/310eea1c78e3e7aac7c016ab9bdf00d04f354645.diff

[clang] e68fc86 - [NFCI][Offload Bundler] Replace hand-rolled endian conversion with llvm::support

Author: Benjamin Kramer Date: 2023-01-08T17:37:02+01:00 New Revision: e68fc86b22fd92f15c464b69e8d98a76f139cebd URL: https://github.com/llvm/llvm-project/commit/e68fc86b22fd92f15c464b69e8d98a76f139cebd DIFF:

[clang] b6942a2 - [NFC] Hide implementation details in anonymous namespaces

Author: Benjamin Kramer Date: 2023-01-08T17:37:02+01:00 New Revision: b6942a2880c578d2eab89ecb75e637aac41c5e51 URL: https://github.com/llvm/llvm-project/commit/b6942a2880c578d2eab89ecb75e637aac41c5e51 DIFF:

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 487195. ccotter added a comment. - tidy up docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files:

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD updated this revision to Diff 487194. eopXD added a comment. Rebase upon D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140686/new/ https://reviews.llvm.org/D140686 Files:

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp accepted this revision. carlosgalvezp added a comment. LGTM! Minor nit. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-capture-default-when-capturing-this.rst:4 +cppcoreguidelines-avoid-capture-default-when-capturing-this

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter marked an inline comment as done. ccotter added a comment. Thanks! I opted for 'avoid-capture-default-when-capturing-this' and updated the name and docs etc in the most recent diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 487193. ccotter added a comment. - rename to avoid-capture-deafult-when-capturing-this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files:

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 487192. carlosgalvezp retitled this revision from "[clang-tidy] Introduce HeaderFileExtensions option" to "[clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options". carlosgalvezp edited the summary of this revision.

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions option

carlosgalvezp updated this revision to Diff 487191. carlosgalvezp added a comment. - Add also ImplementationFileExtensions. - Add deprecation notice to affected checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 487189. ccotter added a comment. - Use const& Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files:

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureThisWithCaptureDefaultCheck.cpp:32 + if (Capture.getCaptureKind() == LCK_ByRef) { +SourceManager = Context.getSourceManager(); +SourceLocation

[PATCH] D141118: [clang-tidy][NFC] Remove unused User argument in misc-misleading-bidirectional check

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0d0b1237a9f: [clang-tidy][NFC] Remove unused User argument in misc-misleading-bidirectional… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c0d0b12 - [clang-tidy][NFC] Remove unused User argument in misc-misleading-bidirectional check

Author: Carlos Galvez Date: 2023-01-08T15:18:13Z New Revision: c0d0b1237a9f9ee992f6775305113738e9374ca0 URL: https://github.com/llvm/llvm-project/commit/c0d0b1237a9f9ee992f6775305113738e9374ca0 DIFF: https://github.com/llvm/llvm-project/commit/c0d0b1237a9f9ee992f6775305113738e9374ca0.diff

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Please give a few days for other reviewers to comment. If you are not 100% happy with the check name I'd suggest to change it before merging, it will be much harder to

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh updated this revision to Diff 487183. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files: clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaExpr.cpp clang/test/AST/Interp/shifts.cpp clang/test/C/drs/dr0xx.c

[clang-tools-extra] f7e9d5b - [clangd] Fix an inlay-hint crash on a null deduced type.

Author: Haojian Wu Date: 2023-01-08T15:48:04+01:00 New Revision: f7e9d5b43e72439f5841f9ff5ef690a625fd312c URL: https://github.com/llvm/llvm-project/commit/f7e9d5b43e72439f5841f9ff5ef690a625fd312c DIFF: https://github.com/llvm/llvm-project/commit/f7e9d5b43e72439f5841f9ff5ef690a625fd312c.diff

[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

TIFitis updated this revision to Diff 487179. TIFitis added a comment. Missed the other llvm::find_if in previous revision. This should fix Windows build issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140292/new/

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mati865 added a comment. I had thought we do that already so this change looks reasonable for me. Just one thought, do we support multilib toolchains? I think in that case Clang would have to add `/include` despite different triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. In D141192#4033962 , @tbaeder wrote: > In D141192#4033591 , @shafik wrote: > >> So it looks like in `handleIntIntBinOp` we do hit this code: >> >> unsigned SA = (unsigned)

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. I've modified `handleIntIntBinOp` so now it emits message about bad shift value. `DiagnoseBadShiftValues` changes are also needed because `handleIntIntBinOp` cant properly cover for example the case we are not in c++11 mode. CHANGES SINCE LAST ACTION

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh updated this revision to Diff 487174. chestnykh retitled this revision from "[Clang] Add warnings on bad shifts inside enums." to "[Clang] Fix warnings on bad shifts.". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files:

[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

TIFitis updated this revision to Diff 487171. TIFitis added a comment. Second attempt at fixing windows build issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140292/new/ https://reviews.llvm.org/D140292 Files:

[PATCH] D141192: [Clang] Add warnings on bad shifts inside enums.

chestnykh updated this revision to Diff 487168. chestnykh edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files: clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

This revision was automatically updated to reflect the committed changes. Closed by commit rG335668b11643: [C++20][Modules] Do not allow non-inline external definitions in header units. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 335668b - [C++20][Modules] Do not allow non-inline external definitions in header units.

Author: Iain Sandoe Date: 2023-01-08T12:19:23Z New Revision: 335668b116439d13c7555616e126acdc608ce59e URL: https://github.com/llvm/llvm-project/commit/335668b116439d13c7555616e126acdc608ce59e DIFF: https://github.com/llvm/llvm-project/commit/335668b116439d13c7555616e126acdc608ce59e.diff LOG:

[PATCH] D136554: Implement CWG2631

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca6196138012: Implement CWG2631 (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D136554?vs=486510=487151#toc

[clang] ca61961 - Implement CWG2631

Author: Corentin Jabot Date: 2023-01-08T10:35:26+01:00 New Revision: ca619613801233ef2def8c3cc7d311d5ed0033cb URL: https://github.com/llvm/llvm-project/commit/ca619613801233ef2def8c3cc7d311d5ed0033cb DIFF:

[PATCH] D141218: [clangd] Include the correct header for typeid()

nridge created this revision. nridge added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes