[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

kito-cheng added a comment. Wait, I fell HasTailPolicy and HasMaskPolicy should be part of Policy object, and then it's the Omit to present it's no policy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754

[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141768/new/ https://reviews.llvm.org/D141768

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141803/new/ https://reviews.llvm.org/D141803

[PATCH] D141767: [10/15][Clang][RISCV][NFC] Don't need to check for `MaskPolicy` in `isTAPolicy` and `isTUPolicy`

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141767/new/ https://reviews.llvm.org/D141767

[PATCH] D141764: [9/15][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141764/new/ https://reviews.llvm.org/D141764

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

ChuanqiXu added inline comments. Comment at: clang/lib/AST/Decl.cpp:4881-4882 + // For RecordDecl the ODRHash is stored in the remaining 26 + // bit of RecordDeclBits, adjust the hash to accomodate. + setODRHash(Hash.CalculateHash() >> 6); + return RecordDeclBits.ODRHash;

[PATCH] D141762: [8/15][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141762/new/ https://reviews.llvm.org/D141762

[PATCH] D141759: [7/15][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141759/new/ https://reviews.llvm.org/D141759

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

kito-cheng added inline comments. Herald added a subscriber: luke. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:388 + bool HasVL, PolicyScheme Scheme, const bool HasTailPolicy, + const bool HasMaskPolicy, bool SupportOverloading,

[PATCH] D141756: [6/15][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM, the condition of those predictor function more reasonable now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

hzq marked an inline comment as done. hzq added a comment. In D141886#4057549 , @bryanpkc wrote: > Thanks for the patch. I just have some simple suggestions. Thanks a lot, modified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141575: [3/15][Clang][RISCV][NFC] Clarify edge cases of RVVIntrinsic::getSupportedMaskedPolicies for clarity

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141575/new/ https://reviews.llvm.org/D141575

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

hzq updated this revision to Diff 489705. hzq retitled this revision from "[Clang][Test] Avoid matching version numbers" to "[Clang][test] Avoid FileCheck error when matching `-cc1`". hzq added a comment. Add `-###` to the command line and update the check content. Repository: rG LLVM Github

[PATCH] D141574: [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM, this made the code more expressive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141574/new/

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. Overall, we could eventually upgrade code in three stages, each a separate reusable check. 1. enable_if -> requires clauses 2. replace the non `_v` templates to the `_v` variants `is_same` -> `is_same_v` or the equivalent concept `same_as` 3. replace requires clause on

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. For the sake of demonstration, https://github.com/llvm/llvm-project/commit/9c556ce59edf5a4293d4497d5815544afc0eb878 is the result of running this tool on all headers under clang/include/clang and llvm/include/llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141892: Implement modernize-use-constraints

ccotter created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add new check to replace enable_if

Re: [clang] 931d04b - [ADT] Make StringRef::compare like std::string_view::compare

Nice! On Sun, Jan 15, 2023 at 12:10 PM Benjamin Kramer via cfe-commits wrote: > > > Author: Benjamin Kramer > Date: 2023-01-15T20:59:21+01:00 > New Revision: 931d04be2fc8f3f0505b43e64297f75d526cb42a > > URL: > https://github.com/llvm/llvm-project/commit/931d04be2fc8f3f0505b43e64297f75d526cb42a

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

vsapsai added a comment. Ping. Also checked the change on a bunch of internal Objective-C/C code using modules - no new errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734

[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

tbaeder updated this revision to Diff 489694. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140874/new/ https://reviews.llvm.org/D140874 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 489693. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Context.cpp

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. (If anyone knows what's going on with the (unrelated seeming?) testing timeouts please do say.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 ___ cfe-commits mailing list

[PATCH] D141886: [Clang][Test] Avoid matching version numbers

bryanpkc added a comment. Thanks for the patch. I just have some simple suggestions. Comment at: clang/test/Driver/modules-ts.cpp:23 // -// CHECK-USE: -cc1 +// CHECK-USE: -cc1{{[^[:xdigit:]]}} // CHECK-USE-SAME: -emit-obj An easier-to-understand fix is to

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc526e346deb: [C++20] [Coroutines] Disable to take the address of labels in coroutines (authored by ChuanqiXu). Changed prior to commit: https://reviews.llvm.org/D131938?vs=452925=489677#toc

[clang] cc526e3 - [C++20] [Coroutines] Disable to take the address of labels in coroutines

Author: Chuanqi Xu Date: 2023-01-17T11:35:32+08:00 New Revision: cc526e346debbaf1d2d32a59230288a4e98294c7 URL: https://github.com/llvm/llvm-project/commit/cc526e346debbaf1d2d32a59230288a4e98294c7 DIFF: https://github.com/llvm/llvm-project/commit/cc526e346debbaf1d2d32a59230288a4e98294c7.diff

[PATCH] D141873: [Clang][OpenMP] Fix the issue that a functor is not captured properly in a task region

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae53c7f4a211: [Clang][OpenMP] Fix the issue that a functor is not captured properly in a task… (authored by tianshilei1992). Repository: rG LLVM

[clang] ae53c7f - [Clang][OpenMP] Fix the issue that a functor is not captured properly in a task region

Author: Shilei Tian Date: 2023-01-16T22:35:05-05:00 New Revision: ae53c7f4a21104e2eb84139f3ce4c468e2632590 URL: https://github.com/llvm/llvm-project/commit/ae53c7f4a21104e2eb84139f3ce4c468e2632590 DIFF: https://github.com/llvm/llvm-project/commit/ae53c7f4a21104e2eb84139f3ce4c468e2632590.diff

[PATCH] D141886: [Clang][Test] Avoid matching version numbers

hzq created this revision. Herald added a project: All. hzq requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the version number starts with cc1, such as: clang-cc1514432c58 In the test case the `-cc1` option will match the version number

[clang] 61fa12d - [NFC][X86] clang-format change for avx512vlbwintrin.h

Author: Freddy Ye Date: 2023-01-17T10:43:51+08:00 New Revision: 61fa12d0c78b5624914b8bd7937eba03f8973434 URL: https://github.com/llvm/llvm-project/commit/61fa12d0c78b5624914b8bd7937eba03f8973434 DIFF: https://github.com/llvm/llvm-project/commit/61fa12d0c78b5624914b8bd7937eba03f8973434.diff

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu updated this revision to Diff 489665. ChuanqiXu added a comment. Address comments and refine the wording from "use `-std=c++20`" to "use `-std=c++20` or higher". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141572/new/ https://reviews.llvm.org/D141572 Files:

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Oh, sorry, I forgot this. Given D132084 is not updated recently, I think we can merge this first. And it should be fine to remove this one after

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added a comment. In D137058#4056647 , @Jake-Egan wrote: > Hi, this new test fails on AIX > https://lab.llvm.org/buildbot/#/builders/214/builds/5351/steps/6/logs/FAIL__Clang__module-output_cppm > Could you take a look? I added `// REQUIRES:

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd15cb935d7a: [clang] [MinGW] Avoid adding base/include and base/lib when cross compiling (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fd15cb9 - [clang] [MinGW] Avoid adding /include and /lib when cross compiling

Author: Martin Storsjö Date: 2023-01-17T00:39:12+02:00 New Revision: fd15cb935d7aae25ad62bfe06fe9f17cea585978 URL: https://github.com/llvm/llvm-project/commit/fd15cb935d7aae25ad62bfe06fe9f17cea585978 DIFF:

[PATCH] D141873: [Clang][OpenMP] Fix the issue that a functor is not captured properly in a task region

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141873/new/ https://reviews.llvm.org/D141873

[PATCH] D141873: [Clang][OpenMP] Fix the issue that a functor is not captured properly in a task region

tianshilei1992 created this revision. tianshilei1992 added reviewers: ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jdoerfert added a comment. FWIW, creating CUBIN from C/C++ directly would be really useful when debugging (and in combination with our soon to be available JIT object loader). @tra Can we get this in somehow? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

jloser added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:652 auto data = + llvm::MutableArrayRef(static_cast(buf), bytes_read); serge-sans-paille wrote: > random nit: This could be rewritten as > > ``` >

[PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa288d7f93770: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides (authored by jloser). Changed prior to commit:

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056825 , @barannikov88 wrote: > clangBasic and clangDriver already have a dependency on TargetParser (see > LLVM_LINK_COMPONENTS at the beginning of corresponding files). Is that not > enough? > Will it build

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:5780 + /// Iterator modifier + Expr *IteratorModifierExpr = nullptr; + We're using tail allocation for such objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141528/new/ https://reviews.llvm.org/D141528 ___ cfe-commits mailing list

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:81 + FromPointeeTy->getUnqualifiedDesugaredType(); + const Type *ToPointeeUQTy = ToPointeeTy->getUnqualifiedDesugaredType(); + Here I am also

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 created this revision. doru1004 added reviewers: jdoerfert, ABataev, carlo.bertolli, ronl, gregrodgers, jhuber6. doru1004 added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. doru1004 requested review of this revision. Herald added

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:95 + + if (P1->isArrayType() && P2->isArrayType()) { +// At every level that array type is involved in, at least xazax.hun wrote: > isuckatcs wrote: > >

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 489626. isuckatcs marked 7 inline comments as done. isuckatcs added a comment. Addressed comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files:

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

doru1004 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141528/new/ https://reviews.llvm.org/D141528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

daltenty added a comment. Needs a test, I think we should add a couple of `-fopenmp=foo` run lines to `clang/test/Driver/aix-ld.c` to verify that the correct linker options are produced for each. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140628: [flang] Add driver install directory to AIX toolchain program paths list

pscoro added a comment. Herald added a subscriber: sunshaoce. Ping. This is a needed fix for AIX, the code is trivial and used similarly on other targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140628/new/ https://reviews.llvm.org/D140628

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

fahadnayyar created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fahadnayyar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Disabled an invalid fix-it which suggested fixes to be applied in system

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

nridge added a comment. Sorry, that was a bad example as it's not actually valid. Here's a slightly modified one: template class a {}; constexpr int b = 2; constexpr int c = 3; constexpr int d = 4; a e; The parser knows the first `<` opens a template-param-list because the

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

nridge added a comment. In D139926#4056478 , @kadircet wrote: > This will only make sure we have a distinction between `<<` and `>>` used as > operators vs `<`/`>` Note that `<<` and `>>` are not the only (or even the primary, in my mind) issue: there

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9954516ffb10: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build (authored by jhuber6). Changed prior to commit:

[PATCH] D141859: [amdgpu-arch] Dynamically load the HSA runtime if not found during the build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6ace23172e5: [amdgpu-arch] Dynamically load the HSA runtime if not found during the build (authored by jhuber6). Changed prior to commit:

[clang] 9954516 - [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

Author: Joseph Huber Date: 2023-01-16T13:13:47-06:00 New Revision: 9954516ffb10a39ae0c8517f4865eec24e07d56e URL: https://github.com/llvm/llvm-project/commit/9954516ffb10a39ae0c8517f4865eec24e07d56e DIFF: https://github.com/llvm/llvm-project/commit/9954516ffb10a39ae0c8517f4865eec24e07d56e.diff

[clang] f6ace23 - [amdgpu-arch] Dynamically load the HSA runtime if not found during the build

Author: Joseph Huber Date: 2023-01-16T13:13:45-06:00 New Revision: f6ace23172e5930be0e7cc602f50e1e9c54d7a9a URL: https://github.com/llvm/llvm-project/commit/f6ace23172e5930be0e7cc602f50e1e9c54d7a9a DIFF: https://github.com/llvm/llvm-project/commit/f6ace23172e5930be0e7cc602f50e1e9c54d7a9a.diff

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. In D141717#4056971 , @yaxunl wrote: > The intention of -emit-llvm -S is usually to get LLVM assembly for all > targets for inspection or modification. HIP emits a bundled LLVM assembly in > textual format in this case. Users

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

yaxunl added a comment. The intention of -emit-llvm -S is usually to get LLVM assembly for all targets for inspection or modification. HIP emits a bundled LLVM assembly in textual format in this case. Users can modify it directly, or extract assembly for each device and bundle them together

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

royjacobson updated this revision to Diff 489607. royjacobson added a comment. rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141803/new/ https://reviews.llvm.org/D141803 Files: clang/docs/ReleaseNotes.rst

[PATCH] D136554: Implement CWG2631

cebowleratibm added a comment. In D136554#4056862 , @cor3ntin wrote: > Yes please! However the warning looks correct to me in that case. A > constructs x which constructs A etc. https://github.com/llvm/llvm-project/issues/60082 Please set the

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM from the libc++ side of things % nit. I think @aaron.ballman should take another look at the Clang changes. Comment at: libcxx/utils/generate_header_tests.py:22 +

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

xazax.hun added a comment. Also, could you open a bug report about the strange exception behavior on GitHub? Hopefully someone working on conformance can take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:60 +// Checks if T1 is convertible to T2. +static bool isMultiLevelConvertiblePointer(QualType

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141422/new/ https://reviews.llvm.org/D141422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler added a comment. In D139926#4056585 , @kadircet wrote: > Especially as this comes as two different `HighlightingKind`s and they're > likely to get colored differently, and having your matching brackets in > different colors is quite annoying.

Re: [PATCH] D136554: Implement CWG2631

Yes please! However the warning looks correct to me in that case. A constructs x which constructs A etc. On Mon, Jan 16, 2023, 18:00 Chris Bowler via Phabricator < revi...@reviews.llvm.org> wrote: > cebowleratibm added a comment. > > I've reduced a regression on: > > commit

[PATCH] D141432: Add two additional float8 types to MLIR and APFloat.

krzysz00 added a comment. Herald added a reviewer: ftynse. I think we have dueling patches that we should reconcile. I've put together https://reviews.llvm.org/D141863 to do the same thing. (it's just now posted because we were waiting to talk to y'all over at GraphCore to finalize naming,

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. Yeah, otherwise I suppose there will be some errors when compiling OpenMP program when there is no CUDA installed. Comment at:

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. Actually, sorting in `numberAnonymousDeclsWithin` doesn't work for some reasons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141625/new/ https://reviews.llvm.org/D141625 ___

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. clangBasic and clangDriver already have a dependency on TargetParser (see LLVM_LINK_COMPONENTS at the beginning of corresponding files). Is that not enough? Will it build if you just remove the additional dependency? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141547: Fix format for `case` in .proto files

This revision was automatically updated to reflect the committed changes. Closed by commit rGcaf393da1823: Fix format for `case` in .proto files (authored by fowles, committed by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141547/new/

[clang] caf393d - Fix format for `case` in .proto files

Author: Matt Kulukundis Date: 2023-01-16T17:43:50Z New Revision: caf393da1823d50852f51604b3793e8f4a23c140 URL: https://github.com/llvm/llvm-project/commit/caf393da1823d50852f51604b3793e8f4a23c140 DIFF: https://github.com/llvm/llvm-project/commit/caf393da1823d50852f51604b3793e8f4a23c140.diff

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. In D141581#4056671 , @fpetrogalli wrote: > @barannikov88 - I am stuck with an incomplete explanation: Ah, I see. The key point is that standalone build that depends on //installed// LLVM. RISCVTargetParser is a custom

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu updated this revision to Diff 489587. steven_wu added a comment. Minor touch up on the test case. Also add some comments in test to explain what is being tested. I don't measure any performance regression from `-fsyntax-only` on Foundation.h but if there are some other performance

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

xingxue created this revision. xingxue added reviewers: daltenty, cebowleratibm, kkwli0. xingxue added a project: LLVM. Herald added subscribers: guansong, yaxunl. Herald added a project: All. xingxue requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay.

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jholewinski.

[PATCH] D141859: [amdgpu-arch] Dynamically load the HSA runtime if not found during the build

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Yes, ok. Not thrilled about the copy from openmp but we can fix that as soon as we agree on a subdir to put code shared between llvm/clang/openmp and that has been tricky to

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for making the changes and for your patience. Please wait a couple of days to give other reviewers a chance to have a look before submitting. Could you

[PATCH] D141858: [clang][Interp] Fix Pointer::toAPValue() for expressions

tbaeder updated this revision to Diff 489581. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141858/new/ https://reviews.llvm.org/D141858 Files: clang/lib/AST/Interp/Pointer.cpp Index: clang/lib/AST/Interp/Pointer.cpp

[PATCH] D141859: [amdgpu-arch] Dynamically load the HSA runtime if not found during the build

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield, gregrodgers. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added

[PATCH] D141858: [clang][Interp] Fix Pointer::toAPValue() for expressions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is now relevant because we generate pointers

[PATCH] D136554: Implement CWG2631

cebowleratibm added a comment. I've reduced a regression on: commit ca619613801233ef2def8c3cc7d311d5ed0033cb (HEAD, refs/bisect/bad) Author: Corentin Jabot Date: Sun Oct 23 17:32:58 2022 +0200 template int f(T) {

Re: [clang] f2d301f - Revert "[codegen] Store address of indirect arguments on the stack"

Reminder to please always mention the reason for the revert/recommit in the commit message. On Mon, Jan 16, 2023 at 7:05 PM Felipe de Azevedo Piovezan via cfe-commits wrote: > > > Author: Felipe de Azevedo Piovezan > Date: 2023-01-16T13:05:22-03:00 > New Revision:

[PATCH] D141518: [AArch64] Move default extensions from clang Driver to TargetParser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f422215ac63: [AArch64] Move default extensions from clang Driver to TargetParser (authored by dmgreen). Herald added a project: clang. Herald added

[clang] 0f42221 - [AArch64] Move default extensions from clang Driver to TargetParser

Author: David Green Date: 2023-01-16T16:58:18Z New Revision: 0f422215ac63da4cb610a21998a2d24c11703fbf URL: https://github.com/llvm/llvm-project/commit/0f422215ac63da4cb610a21998a2d24c11703fbf DIFF: https://github.com/llvm/llvm-project/commit/0f422215ac63da4cb610a21998a2d24c11703fbf.diff LOG:

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. @barannikov88 - Imam stuck with an incomplete explanation: The issue raised by @mgorny is about stand-alone builds. In this build configuration, clang is built separately from LLVM, which is first

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve added a comment. In hindsight, this should have been obvious. While SROA will not touch this: define @foo(ptr %arg) { call void @llvm.dbg.declare(%arg, [...], metadata !DIExpression()) It completely destroys the debug information provided by: define @foo(ptr %arg) {

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

Jake-Egan added a comment. Hi, this new test fails on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/5351/steps/6/logs/FAIL__Clang__module-output_cppm Could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056612 , @barannikov88 wrote: > In D141581#4056503 , @fpetrogalli > wrote: > >> This is because the sources of clangBasic and clangDriver might be compiled >> before

[PATCH] D141838: [clang-tidy] fix a false positive of `cppcoreguidelines-avoid-non-const-global-variables`

njames93 added a comment. I'm not convinced this is the correct fix. The guildline states that tools should flag all variables declared at global or namespace scope. Therefore we shouldn't be

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. In D141581#4056503 , @fpetrogalli wrote: > This is because the sources of clangBasic and clangDriver might be compiled > before LLVMTargetParser is ready. ... > Therefore, if we say that clangDriver and clangBasic depend

[PATCH] D141586: [include-mapping] Replace the stdlib symbol maps with the newest official version from https://en.cppreference.com/w/File:html_book_20190607.zip.

VitaNuo abandoned this revision. VitaNuo added a comment. Abandoning since we will eventually parse a newer version of the archive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141586/new/ https://reviews.llvm.org/D141586

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141855 Files:

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

kadircet added a comment. > Note that we use this information to *animate* the matching tokens, i.e. when > the cursor is on one of them, both it and its counterpart get a special > highlighting. That's why it's so important that the language server > guarantees they always come in pairs. Oh

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve added a comment. There is a real regression in `lldb/test/API/functionalities/param_entry_vals/basic_entry_values/` when this is compiled with O2 : __attribute__((noinline)) void func15(StructPassedViaPointerToTemporaryCopy S) It seems

[clang] f2d301f - Revert "[codegen] Store address of indirect arguments on the stack"

Author: Felipe de Azevedo Piovezan Date: 2023-01-16T13:05:22-03:00 New Revision: f2d301fe82869f881b86b51da7b4752972c66707 URL: https://github.com/llvm/llvm-project/commit/f2d301fe82869f881b86b51da7b4752972c66707 DIFF:

[PATCH] D141547: Fix format for `case` in .proto files

krasimir accepted this revision. krasimir added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141547/new/ https://reviews.llvm.org/D141547 ___ cfe-commits mailing list

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056492 , @tschuett wrote: > I though Clang Basic is a leaf library and must not depend on anything. I wasn't aware of this requirement. As of https://reviews.llvm.org/D137517 it depends on some auto-generated

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056464 , @lebedev.ri wrote: > Why is it not sufficient to link to `RISCVTargetParserTableGen`, but is > sufficient to link to `LLVMTargetParser`? This is because the sources of clangBasic and clangDriver might

  1   2   >