[PATCH] D140954: [7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b28229412dc: [7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU` (authored by eopXD). Herald added a subscriber: luke. Changed prior

[clang] 6b28229 - [7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

Author: eopXD Date: 2023-01-23T23:57:04-08:00 New Revision: 6b28229412dc9760b3fab33763f3347761876227 URL: https://github.com/llvm/llvm-project/commit/6b28229412dc9760b3fab33763f3347761876227 DIFF: https://github.com/llvm/llvm-project/commit/6b28229412dc9760b3fab33763f3347761876227.diff LOG:

[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

tbaeder updated this revision to Diff 491619. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140874/new/ https://reviews.llvm.org/D140874 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

nridge added a comment. In D138546#4075681 , @cpsauer wrote: > Sounds like you're not concerned, then, that the > JSONCompilationDatabasePlugin will get invoked and the results then passed to > a SystemIncludeExtractor-enabled mangler? > (I'd seen some

[PATCH] D140947: [6/7][Clang][RISCV] Remove default tail-undisturbed for vmv_s_x and vfmv_s_f intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14261c1991fe: [6/7][Clang][RISCV] Remove default tail-undisturbed for vmv_s_x and vfmv_s_f… (authored by eopXD). Herald added a subscriber: luke.

[clang] 14261c1 - [6/7][Clang][RISCV] Remove default tail-undisturbed for vmv_s_x and vfmv_s_f intrinsics

Author: eopXD Date: 2023-01-23T23:53:27-08:00 New Revision: 14261c1991fe49e3a4ffcc58cdc5c5b91dc81ba9 URL: https://github.com/llvm/llvm-project/commit/14261c1991fe49e3a4ffcc58cdc5c5b91dc81ba9 DIFF: https://github.com/llvm/llvm-project/commit/14261c1991fe49e3a4ffcc58cdc5c5b91dc81ba9.diff LOG:

[PATCH] D140941: [4/7][Clang][RISCV] Remove default tail-undisturbed for multiply-add intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb106cb4a0060: [4/7][Clang][RISCV] Remove default tail-undisturbed for multiply-add intrinsics (authored by eopXD). Herald added a subscriber: luke.

[PATCH] D140942: [5/7][Clang][RISCV] Remove default tail-undisturbed for vcompress intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG380129657fe3: [5/7][Clang][RISCV] Remove default tail-undisturbed for vcompress intrinsics (authored by eopXD). Herald added a subscriber: luke.

[clang] 3801296 - [5/7][Clang][RISCV] Remove default tail-undisturbed for vcompress intrinsics

Author: eopXD Date: 2023-01-23T23:50:43-08:00 New Revision: 380129657fe3d594e966a8d7ff510ed6afb3e177 URL: https://github.com/llvm/llvm-project/commit/380129657fe3d594e966a8d7ff510ed6afb3e177 DIFF: https://github.com/llvm/llvm-project/commit/380129657fe3d594e966a8d7ff510ed6afb3e177.diff LOG:

[PATCH] D140936: [2/7][Clang][RISCV] Remove default tail-undisturbed for vslideup intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92717c2ca8c5: [2/7][Clang][RISCV] Remove default tail-undisturbed for vslideup intrinsics (authored by eopXD). Herald added a subscriber: luke.

[clang] 92717c2 - [2/7][Clang][RISCV] Remove default tail-undisturbed for vslideup intrinsics

Author: eopXD Date: 2023-01-23T23:34:57-08:00 New Revision: 92717c2ca8c53e51e99fd0a4adea8b56008bab53 URL: https://github.com/llvm/llvm-project/commit/92717c2ca8c53e51e99fd0a4adea8b56008bab53 DIFF: https://github.com/llvm/llvm-project/commit/92717c2ca8c53e51e99fd0a4adea8b56008bab53.diff LOG:

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754

[PATCH] D140895: [1/7][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG224d29e6f543: [1/7][Clang][RISCV] Remove default tail-undisturbed for vector reduction… (authored by eopXD). Repository: rG LLVM Github Monorepo

[PATCH] D140895: [1/7][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

eopXD updated this revision to Diff 491609. eopXD added a comment. Herald added a subscriber: luke. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140895/new/ https://reviews.llvm.org/D140895 Files:

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 491608. pmatos added a comment. Finish fixing tests after dianostic message changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files:

[PATCH] D140250: Define NULL in its own header

iana added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line: 19,

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 491607. iana added a comment. Fix the debuginfo-generic-assignment-tracking-sroa test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 Files:

[PATCH] D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40003af98456: [Clang][NFC] Remove a redundancy check in

[clang] 40003af - [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

Author: Shivam Gupta Date: 2023-01-24T11:56:06+05:30 New Revision: 40003af98456607f9b6bd1910424c5243eeb5d01 URL: https://github.com/llvm/llvm-project/commit/40003af98456607f9b6bd1910424c5243eeb5d01 DIFF: https://github.com/llvm/llvm-project/commit/40003af98456607f9b6bd1910424c5243eeb5d01.diff

[PATCH] D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f5099cd9422: Opting out of Clang 16 ABI Changes for AIX and z/OS (authored by nicolerabjohn, committed by hubert.reinterpretcast). Repository:

[clang] 0f5099c - Opting out of Clang 16 ABI Changes for AIX and z/OS

Author: Nicole Rabjohn Date: 2023-01-24T01:14:05-05:00 New Revision: 0f5099cd94226479fe30b4fc2d6a9743ebe2b12b URL: https://github.com/llvm/llvm-project/commit/0f5099cd94226479fe30b4fc2d6a9743ebe2b12b DIFF:

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 491604. iana added a comment. Rebase, update diagnostic to include the full module name instead of just the top level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250

[PATCH] D142430: [Clang] Treat `std::forward_like` as builtin

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: rsmith, aaron.ballman. alexander-shaposhnikov created this object with visibility "All Users". Herald added a reviewer: NoQ. Herald added a project: All. alexander-shaposhnikov requested review of this revision.

[PATCH] D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays

tbaeder added a comment. It's interrupted whenever one of the `emitXXX()` functions returns `false`, or when one of the function in `Interp.h` returns `false`, e.g. when trying to read from a null pointer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138275/new/

[PATCH] D140845: [clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)

shafik added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:149 + constexpr signed int R = 62; + constexpr decltype(L) M = L << R; }; Can we add a test for left shift as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays

shafik added a comment. This looks good to me but I am wondering how "interpretation is interrupted" can happen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138275/new/ https://reviews.llvm.org/D138275 ___ cfe-commits mailing list

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

hubert.reinterpretcast added a comment. Since this is a change only for AIX and z/OS, and considering that this is a patch to prevent ABI changes compared to the current ABI baselines for those platforms, I will land this ahead of the LLVM 16 branching. CHANGES SINCE LAST ACTION

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. Thanks @nicolerabjohn; this LGTM! Comment at: clang/test/SemaCXX/class-layout.cpp:685 +#if (defined(CLANG_ABI_COMPAT) && CLANG_ABI_COMPAT <=

[PATCH] D118493: Set rpath on openmp executables

MaskRay added a comment. Enabled-by-default `-fopenmp-implicit-rpath` is odd. For other shared objects (e.g. `libclang_rt.*.so`) we don't do this. For libraries in a well-known system directory, we just rely on the default `/etc/ld.so.conf*`. For libraries in other directories or when

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

nicolerabjohn marked an inline comment as done. nicolerabjohn added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:688 }; #if defined(CLANG_ABI_COMPAT) && CLANG_ABI_COMPAT <= 15 _Static_assert(sizeof(t3) == 8, ""); hubert.reinterpretcast

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

nicolerabjohn updated this revision to Diff 491595. nicolerabjohn added a comment. Update to assertions for z/OS case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files: clang/docs/ReleaseNotes.rst

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry marked an inline comment as done. v1nh1shungry added a comment. Thanks for the review! @tom-anders Comment at: clang-tools-extra/clangd/Hover.cpp:1035 } else if (const auto *MTE = CastNode->ASTNode.get()) { } else { // Unknown

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry updated this revision to Diff 491594. v1nh1shungry added a comment. land review's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142014/new/ https://reviews.llvm.org/D142014 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer updated this revision to Diff 491593. cpsauer added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-tools-extra/clangd/GlobalCompilationDatabase.cpp

[PATCH] D142377: Dead links on https://clang.llvm.org/extra/clang-tidy/ #60023

s-pratik added a comment. Great ! Please Use Name : Pratik Sharma Email : sharmapratik...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142377/new/ https://reviews.llvm.org/D142377 ___

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer updated this revision to Diff 491592. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-tools-extra/clangd/GlobalCompilationDatabase.cpp

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. Yay. Thanks, Nathan, for guiding, replying, and just generally being so kind, great, and thorough. I'll back out the plugin part of the changes changes momentarily, then. Just to confirm: Sounds like you're not concerned, then, that the JSONCompilationDatabasePlugin

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other

[clang] f2b58eb - Revert "[Fuchsia] Build windows runtimes using cross compilation on Linux"

Author: Haowei Wu Date: 2023-01-23T18:43:23-08:00 New Revision: f2b58eb4ad840f33caf970d6cf2906486647086b URL: https://github.com/llvm/llvm-project/commit/f2b58eb4ad840f33caf970d6cf2906486647086b DIFF: https://github.com/llvm/llvm-project/commit/f2b58eb4ad840f33caf970d6cf2906486647086b.diff

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#4067208 , @ayzhao wrote: > Thanks for your effort on this! > > FYI I landed parenthesized aggregate initialization in D141546 > , so CTAD for that feature should no longer > be

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 491581. ziqingluo-90 added a comment. Refactored the fix-it generation code to stop using the pretty-printer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files:

[PATCH] D142423: [clang-tidy] Fix segfault in bugprone-standalone-empty

denik created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. denik requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The check incorrectly

[PATCH] D142416: [clang][deps] NFC: Remove dead code

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:180 - // incompatible modules (e.g. with differences in search paths). - CI.getHeaderSearchOpts().ModulesStrictContextHash = true; - benlangmuir wrote:

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. rdar://99200922 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142421 Files:

[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

shafik updated this revision to Diff 491554. shafik marked 2 inline comments as done. shafik added a comment. - Switched to isValid() over isSet() - Added release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140598/new/ https://reviews.llvm.org/D140598 Files:

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Seems right to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765

[PATCH] D142416: [clang][deps] NFC: Remove dead code

benlangmuir added a comment. Removing `ImplicitModulePCMPath` LGTM; not sure about the other change. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:180 - // incompatible modules (e.g. with differences in search paths). -

[PATCH] D142403: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. In D142403#4075215 , @tstellar wrote: > LGTM. I tested and this fixes the build. @tstellar , I wonder how your build (and mine too, in fact) didn't complain about the typo... luckily the bots cover this functionality!

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D142416: [clang][deps] NFC: Remove dead code

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes some dead

[PATCH] D142393: [OpenMP] Add 'amdgpu-flat-work-group-size' to OpenMP kernels

jdoerfert added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:791 - // Get the device name and canonicalize it + // Get the ndevice name and canonicalize it const StringRef GpuArch = getGPUArch(DriverArgs); ^ Repository: rG LLVM

[PATCH] D142403: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. In D142403#4075215 , @tstellar wrote: > LGTM. I tested and this fixes the build. Thank you @tstellar, I landed it. I am going offline for until tomorrow morning - feel free to revert it if the world of bots collapses :)

[clang] 0ba42be - [Clang][NFC] Fix documentation and remove unused tool

Author: Joseph Huber Date: 2023-01-23T17:57:21-06:00 New Revision: 0ba42be63e1f26370565cd6b824a9de4ff53a801 URL: https://github.com/llvm/llvm-project/commit/0ba42be63e1f26370565cd6b824a9de4ff53a801 DIFF: https://github.com/llvm/llvm-project/commit/0ba42be63e1f26370565cd6b824a9de4ff53a801.diff

[PATCH] D142403: [build] Fix stand-alone builds of clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d02e38f56df: [build] Fix stand-alone builds of clang. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142403: [build] Fix stand-alone builds of clang.

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. I tested and this fixes the build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142403/new/ https://reviews.llvm.org/D142403

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:590 + std::optional OptLevelOrNone = + CodeGenOpt::getLevel(CGOpts.OptimizationLevel); + assert(OptLevelOrNone && "Invalid optimization level!"); aaronpuchert wrote: >

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

aaronpuchert added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:590 + std::optional OptLevelOrNone = + CodeGenOpt::getLevel(CGOpts.OptimizationLevel); + assert(OptLevelOrNone && "Invalid optimization level!"); Does this need

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To prevent

[PATCH] D142392: [clang][deps] Add module files for input dependencies earlier

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142392/new/ https://reviews.llvm.org/D142392

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder added a comment. I also ended up changing the underlying type to `int` to resolve https://lab.llvm.org/buildbot/#/builders/61/builds/38754 , and I removed the `getID` function (with the implicit conversions it would never get used anyway). Repository: rG LLVM Github Monorepo

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld marked an inline comment as done. Hahnfeld added a comment. In D142196#4074249 , @jansvoboda11 wrote: > Also I think we should mention this API in our docs, right where the removed > original used to be. Which API docs are you referring to?

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld updated this revision to Diff 491522. Hahnfeld added a comment. Update comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196 Files: clang/include/clang/Lex/PPCallbacks.h clang/lib/Lex/PPDirectives.cpp

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:67 + inline std::optional getLevel(IDType ID) { +if (ID < 0 || ID > 3) + return std::nullopt; mstorsjo wrote: > scott.linder wrote: > > barannikov88 wrote: > > > As I

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

philipp.tomsich created this revision. philipp.tomsich added a reviewer: dmgreen. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. philipp.tomsich requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

mstorsjo added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:67 + inline std::optional getLevel(IDType ID) { +if (ID < 0 || ID > 3) + return std::nullopt; scott.linder wrote: > barannikov88 wrote: > > As I can see, clients do not

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25c0ea2a5370: [NFC] Consolidate llvm::CodeGenOpt::Level handling (authored by scott.linder). Changed prior to commit:

[clang] 25c0ea2 - [NFC] Consolidate llvm::CodeGenOpt::Level handling

Author: Scott Linder Date: 2023-01-23T22:50:49Z New Revision: 25c0ea2a5370813f46686918a84e0de27e107d08 URL: https://github.com/llvm/llvm-project/commit/25c0ea2a5370813f46686918a84e0de27e107d08 DIFF: https://github.com/llvm/llvm-project/commit/25c0ea2a5370813f46686918a84e0de27e107d08.diff LOG:

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:688 }; #if defined(CLANG_ABI_COMPAT) && CLANG_ABI_COMPAT <= 15 _Static_assert(sizeof(t3) == 8, ""); hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D142296: [clang-format] Fix bugs in parsing C++20 module import statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02fd0020e577: [clang-format] Fix bugs in parsing C++20 module import statements (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] 02fd002 - [clang-format] Fix bugs in parsing C++20 module import statements

Author: Owen Pan Date: 2023-01-23T14:35:15-08:00 New Revision: 02fd0020e5771b2850f892712b8fa51d3b98e270 URL: https://github.com/llvm/llvm-project/commit/02fd0020e5771b2850f892712b8fa51d3b98e270 DIFF: https://github.com/llvm/llvm-project/commit/02fd0020e5771b2850f892712b8fa51d3b98e270.diff

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

shafik added a comment. I could not find any tests that test for this warning. Comment at: clang/lib/Sema/SemaExpr.cpp:5914 + runWithSufficientStackSpace(CallLoc, [&] { +MarkDeclarationsReferencedInExpr(Init, /*SkipLocalVariables*/ true); + });

[clang] 35912ad - [clang] Fix unused variable warning in isBuiltinSupported

Author: serge-sans-paille Date: 2023-01-23T23:16:45+01:00 New Revision: 35912ad39d8a0f244f36d24526ec70b8b028a6e0 URL: https://github.com/llvm/llvm-project/commit/35912ad39d8a0f244f36d24526ec70b8b028a6e0 DIFF:

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

thakis added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20bb7658f53b: [Fuchsia] Build windows runtimes using cross compilation on Linux (authored by haowei). Changed prior to commit:

[clang] 20bb765 - [Fuchsia] Build windows runtimes using cross compilation on Linux

Author: Haowei Wu Date: 2023-01-23T14:09:31-08:00 New Revision: 20bb7658f53b0b8db165ff4d404ede3f9b34862d URL: https://github.com/llvm/llvm-project/commit/20bb7658f53b0b8db165ff4d404ede3f9b34862d DIFF: https://github.com/llvm/llvm-project/commit/20bb7658f53b0b8db165ff4d404ede3f9b34862d.diff

[PATCH] D140434: readability-const-return-type: don't diagnose a template function returning T, even if sometimes instantiated with e.g. T = const int.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a11b23c0238: readability-const-return-type: dont diagnose a template function returning T… (authored by suertreus, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 9a11b23 - readability-const-return-type: don't diagnose a template function returning T, even if sometimes instantiated with e.g. T = const int.

Author: Andy Getzendanner Date: 2023-01-23T22:08:12Z New Revision: 9a11b23c0238ebfa0210ce89dee97f68ae3dfbd4 URL: https://github.com/llvm/llvm-project/commit/9a11b23c0238ebfa0210ce89dee97f68ae3dfbd4 DIFF: https://github.com/llvm/llvm-project/commit/9a11b23c0238ebfa0210ce89dee97f68ae3dfbd4.diff

[PATCH] D142024: [clang] Optimize clang::Builtin::Info density

serge-sans-paille added a comment. This got fixed in d1f313e73a1b33d662dbab54be76720b9c875645 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142024/new/

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

fpetrogalli updated this revision to Diff 491506. fpetrogalli added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. Address code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

nicolerabjohn updated this revision to Diff 491505. nicolerabjohn added a comment. Reverting previous directive change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files: clang/docs/ReleaseNotes.rst

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:18 // expected-no-diagnostics +#if !defined(__MVS__) && !defined(_AIX) dblaikie wrote: > What's the reason this part is #ifdef'd out? Does it contain code that's >

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:688 }; #if defined(CLANG_ABI_COMPAT) && CLANG_ABI_COMPAT <= 15 _Static_assert(sizeof(t3) == 8, ""); hubert.reinterpretcast wrote: > Because z/OS has some of the

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

tstellar added a comment. In D142403#4074905 , @fpetrogalli wrote: > In D142403#4074885 , @tstellar > wrote: > >> This is still the wrong change IMO. I don't know, maybe I'm not being >> clear, but I don't

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

fpetrogalli added a comment. In D142403#4074885 , @tstellar wrote: > This is still the wrong change IMO. I don't know, maybe I'm not being clear, > but I don't 'think you ever actually tried my suggestion in D141581 >

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

dblaikie added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:18 // expected-no-diagnostics +#if !defined(__MVS__) && !defined(_AIX) What's the reason this part is #ifdef'd out? Does it contain code that's unsupported on these platforms?

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

tstellar added a comment. This is still the wrong change IMO. I don't know, maybe I'm not being clear, but I don't 'think you ever actually tried my suggestion in D141581 which was to leave the RISCVTargetParserTableGen Depends as is and add the pseudo

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

fpetrogalli created this revision. fpetrogalli added reviewers: mgorny, tstellar. Herald added subscribers: luismarques, s.egerton, kadircet, PkmX, simoncook, arichardson. Herald added a project: All. fpetrogalli requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D142393: [OpenMP] Add 'amdgpu-flat-work-group-size' to OpenMP kernels

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9552 F->addFnAttr("uniform-work-group-size", "true"); + if (IsOpenMPkernel) +F->addFnAttr("amdgpu-flat-work-group-size", jhuber6 wrote: > arsenm wrote: > > jhuber6 wrote: > > >

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter marked an inline comment as done. ccotter added a comment. Thanks for reviewing and merging my recent changes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141463/new/ https://reviews.llvm.org/D141463

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

nicolerabjohn updated this revision to Diff 491501. nicolerabjohn added a comment. Addressing review comments - spacing, updates to run lines, updates to a directive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files:

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

yaxunl added a comment. Can we keep the original behaviour for the older driver for HIP? Only enable the change for the new driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141717/new/ https://reviews.llvm.org/D141717

[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. Reverted in https://reviews.llvm.org/rG20ffb9aaf982 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581 ___ cfe-commits mailing list

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added a comment. @fpetrogalli The solution is to add RISCVTargetParserTableGen to the Depnds list of clang/lib/Driver and clang/lib/Basic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581

[clang] 20ffb9a - Revert "[build] Fix stand-alone builds of clang."

Author: Francesco Petrogalli Date: 2023-01-23T22:31:34+01:00 New Revision: 20ffb9aaf982f341c1ea34808e002daa5be0df76 URL: https://github.com/llvm/llvm-project/commit/20ffb9aaf982f341c1ea34808e002daa5be0df76 DIFF:

[PATCH] D142396: [AArch64] Add the Ampere1A core

philipp.tomsich updated this revision to Diff 491499. philipp.tomsich added a comment. v2 changes: - fixes a whitespace issue - fixes a rebase artifact on Ampere1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142396/new/

  1   2   3   4   >