[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

carlosgalvezp added a comment. In D144217#4143554 , @PiotrZSL wrote: > In D144217#4143540 , @carlosgalvezp > wrote: > >>> Perhaps, this can even be generalized to all types whose size() and empty() >>> are

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

phosek added a comment. I missed this change so I apologize for late response, but can you elaborate on why this is needed? Clang first checks the name without architecture and if the file doesn't exist then it'll return the one with architecture unconditionally, see

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

This revision was automatically updated to reflect the committed changes. Closed by commit rGd61a863050bb: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d61a863 - [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

Author: Michael Platings Date: 2023-02-22T07:45:16Z New Revision: d61a863050bb4afd22d08bbe53af1e24c0657aba URL: https://github.com/llvm/llvm-project/commit/d61a863050bb4afd22d08bbe53af1e24c0657aba DIFF: https://github.com/llvm/llvm-project/commit/d61a863050bb4afd22d08bbe53af1e24c0657aba.diff

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, given

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

PiotrZSL added a comment. In D144217#4143540 , @carlosgalvezp wrote: >> Perhaps, this can even be generalized to all types whose size() and empty() >> are constexpr. Problem is that you can mark function constexpr, but it doesnt need to be constexpr

[PATCH] D144447: [Clang] Teach buildFMulAdd to peek through fneg to find fmul.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3738 - assert(!(negMul && negAdd) && "Only one of negMul and negAdd should be set."); - Value *MulOp0 = MulOp->getOperand(0); kpn wrote: > If I'm reading this right it looks

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

carlosgalvezp added a comment. Looks good in general, thanks for the fix! I have minor comments. Also, I found the comment on the Github issue interesting: > Perhaps, this can even be generalized to all types whose size() and empty() > are constexpr. Would that be a more scalable approach

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime updated this revision to Diff 499374. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143840/new/ https://reviews.llvm.org/D143840 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144510/new/ https://reviews.llvm.org/D144510

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

TimNN added a comment. Herald added a subscriber: StephenFan. The ThinLTO related breakage I mentioned above should be fixed as of https://github.com/llvm/llvm-project/commit/451799bb8261bde52bbfef226d019caf1d82aa42. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. Ok, all feedback should be addressed (thanks for the comment to consolidate into a single matcher) with appropriate options to relax the enforcement of the guideline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 499366. ccotter added a comment. - Include non-deduced template types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:301 + } + void never_moves(T&& t) {} + // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: rvalue reference parameter 't' is never moved

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 499363. ccotter marked an inline comment as done. ccotter added a comment. - Finish combining into a single matcher - Rename option and add docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

benshi001 added a comment. Different AVR device families have different default linker scripts in avr-ld, but they have 95% similarity and look like as following, we can use `--defsym=__DATA_REGION_ORIGIN__` to decide the default data region range instead of current `-Tdata`. /* Script for

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Different AVR

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto = clang::driver::getDriverOptTable();

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 added a comment. Pass two benchmarks: XSBench and RSBench. The patch will break the old plugins as well. I'm wondering we might want to land it after D142820 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:583 + if (!KernelEnvOrError) +return KernelEnvOrError.takeError(); + jdoerfert

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 499355. tianshilei1992 added a comment. rebase, update tests, fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files:

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked 2 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:103-125 + StatementMatcher MoveCallMatcher = callExpr( +

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 499350. ccotter added a comment. - Use bool - Combine into a single matcher Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a comment. In D144035#4143030 , @pcc wrote: > Passes shouldn't be replacing aliases with aliasees in general, see D66606 > . The right fix is to fix SCEV to not do > that. Updated Repository: rG

[PATCH] D144035: [hwasan] Ensure SCEV does not replace aliases with their aliasees

leonardchan updated this revision to Diff 499349. leonardchan retitled this revision from "[hwasan] Ensure hwasan aliases do not have ODR linkage" to "[hwasan] Ensure SCEV does not replace aliases with their aliasees". leonardchan edited the summary of this revision. Repository: rG LLVM

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

zixuan-wu added a comment. In D141899#4065375 , @nikic wrote: > In D141899#4061237 , @zixuan-wu > wrote: > >> With considering >> https://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility I >>

[PATCH] D143301: [flang] Handle unsupported warning flags

PeteSteinfeld added a comment. > @PeteSteinfeld, I think vzakhari's most recent commit > > fixes this. Thanks, @ elmcdonough, and @vzakhari! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough added a comment. In D143301#4143241 , @PeteSteinfeld wrote: > In D143301#4143108 , @vzakhari > wrote: > >> The new tests fail to link: > > That is, these new tests cause check-flang to fail.

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.h:32-33 +private: + const unsigned StrictMode : 1; + const unsigned IgnoreUnnamedParams : 1; +}; PiotrZSL wrote: > use bool here, or it

[PATCH] D143301: [flang] Handle unsupported warning flags

PeteSteinfeld added a comment. In D143301#4143108 , @vzakhari wrote: > The new tests fail to link: That is, these new tests cause check-flang to fail. @elmcdonough, can you please fix things so that check-flang no longer fails? Repository: rG LLVM

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. Simplified matchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144074/new/ https://reviews.llvm.org/D144074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 499341. ccotter marked 4 inline comments as done. ccotter added a comment. - Simplify matcher Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime updated this revision to Diff 499339. lime edited the summary of this revision. lime added a comment. Updated as suggested. I will do a stage-2 build before landing the patch to confirm whether it would case another crash, and it takes time. CHANGES SINCE LAST ACTION

[PATCH] D144320: [Clang][OpenMP] Update tests using update_cc_test_checks.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG270f533e8b0c: [Clang][OpenMP] Update tests using update_cc_test_checks.py (authored by tianshilei1992). Repository: rG LLVM Github Monorepo

[PATCH] D144320: [Clang][OpenMP] Update tests using update_cc_test_checks.py

tianshilei1992 updated this revision to Diff 499337. tianshilei1992 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144320/new/ https://reviews.llvm.org/D144320 Files: clang/test/OpenMP/amdgcn_target_codegen.cpp

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

rymiel updated this revision to Diff 499330. rymiel added a comment. Inline and remove LevelIndentTracker::skipLine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144296/new/ https://reviews.llvm.org/D144296 Files:

[PATCH] D144320: [Clang][OpenMP] Update tests using update_cc_test_checks.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61faf261506f: [Clang][OpenMP] Update tests using update_cc_test_checks.py (authored by tianshilei1992). Repository: rG LLVM Github Monorepo

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:387 +if (!(*compactedLine)->InPPDirective) + (*compactedLine)->Level-= dedentBy; + } owenpan wrote: > Did git-clang-format miss this? Nope, I

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

rymiel updated this revision to Diff 499328. rymiel marked 7 inline comments as done. rymiel added a comment. Apply suggestions and add extra test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144296/new/ https://reviews.llvm.org/D144296 Files:

[PATCH] D143301: [flang] Handle unsupported warning flags

vzakhari added a comment. The new tests fail to link: flang-new: warning: The warning option '-Wextra' is not supported /usr/bin/ld: cannot find -lFortran_main /usr/bin/ld: cannot find -lFortranRuntime /usr/bin/ld: cannot find -lFortranDecimal Is the linking really necessary?

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt added a comment. Summarizing a brief offline discussion: I think it's probably fine to just get rid of the SemaChecking changes entirely; type-checking here is done by the generalized builtin-handling code. I'll do the change if there's no objection. Repository: rG LLVM

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

NoQ added a comment. I completely agree with @steakhal, these should be note tags: - The "visitor way" is to reverse-engineer the exploded graph after the fact. - The "slightly more sophisticated visitor way" is have checker callbacks leave extra hints in the graph to assist reverse

[PATCH] D144136: Add a "remark" to report on array accesses

void updated this revision to Diff 499321. void added a comment. Report when there's a non-constant access: array_access_report.c:32:17: remark: accessing fixed sized array 'int[16]' by 'index' [-Rarray-bounds] report_size(p->array, index); ^ Repository: rG LLVM Github

[PATCH] D144035: [hwasan] Ensure hwasan aliases do not have ODR linkage

pcc requested changes to this revision. pcc added a comment. This revision now requires changes to proceed. Passes shouldn't be replacing aliases with aliasees in general, see D66606 . The right fix is to fix SCEV to not do that. Repository: rG LLVM Github

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc marked an inline comment as done. bryanpkc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8874 case SVETypeFlags::EltTyBool64: + case SVETypeFlags::EltTyBool128: return Builder.getInt1Ty(); kmclaughlin wrote: > Is it

[libunwind] 141471a - [runtimes] Remove unused functions from Handle{Libcxx,Libunwind}Flags.cmake

Author: Nikolas Klauser Date: 2023-02-22T00:38:44+01:00 New Revision: 141471a0cbf2d029899b29baf1a54a238f6067f9 URL: https://github.com/llvm/llvm-project/commit/141471a0cbf2d029899b29baf1a54a238f6067f9 DIFF:

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

estewart08 added a comment. Herald added a subscriber: steakhal. Herald added a reviewer: NoQ. Herald added a project: All. In D74144#2308856 , @ABataev wrote: > In D74144#2308796 , @cchen wrote: > >> In

[PATCH] D143210: [PowerPC] Include vector bool and pixel when emitting lax warning

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG02a71b05fc67: [PowerPC] Include vector bool and pixel when emitting lax warning (authored by maryammo). Changed prior to

[clang] 02a71b0 - [PowerPC] Include vector bool and pixel when emitting lax warning

Author: Maryam Moghadas Date: 2023-02-21T22:26:18Z New Revision: 02a71b05fc67326d8ea336aa8ef934de0575be39 URL: https://github.com/llvm/llvm-project/commit/02a71b05fc67326d8ea336aa8ef934de0575be39 DIFF: https://github.com/llvm/llvm-project/commit/02a71b05fc67326d8ea336aa8ef934de0575be39.diff

[PATCH] D143301: [flang] Handle unsupported warning flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce3a1c59e180: [flang] Handle unsupported warning flags (authored by elmcdonough). Changed prior to commit:

[clang] ce3a1c5 - [flang] Handle unsupported warning flags

Author: Ethan Luis McDonough Date: 2023-02-21T16:14:19-06:00 New Revision: ce3a1c59e18027e7d18a2a0a99e4bc81ccc03491 URL: https://github.com/llvm/llvm-project/commit/ce3a1c59e18027e7d18a2a0a99e4bc81ccc03491 DIFF:

[PATCH] D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang

emaste added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3090 if (!EffectiveTriple.isOSLinux()) return; Why is this limited to `isOSLinux()` only? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96007/new/

[PATCH] D143301: [flang] Handle unsupported warning flags

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks for seeing this through! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee815ff2ce8d: [PowerPC] Fix the implicit casting for the emulated intrinsics (authored by maryammo). Repository: rG LLVM Github Monorepo CHANGES

[clang] ee815ff - [PowerPC] Fix the implicit casting for the emulated intrinsics

Author: Maryam Moghadas Date: 2023-02-21T15:44:57-06:00 New Revision: ee815ff2ce8d0782cf04f5cad1d4038207f661cf URL: https://github.com/llvm/llvm-project/commit/ee815ff2ce8d0782cf04f5cad1d4038207f661cf DIFF:

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

This revision was automatically updated to reflect the committed changes. Closed by commit rG1360bfb05b31: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing… (authored by madanial). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1360bfb - [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

Author: Mark Danial Date: 2023-02-21T16:34:26-05:00 New Revision: 1360bfb05b3153ad93a7e866f0ac6860d94337a2 URL: https://github.com/llvm/llvm-project/commit/1360bfb05b3153ad93a7e866f0ac6860d94337a2 DIFF: https://github.com/llvm/llvm-project/commit/1360bfb05b3153ad93a7e866f0ac6860d94337a2.diff

[PATCH] D144035: [hwasan] Ensure hwasan aliases do not have ODR linkage

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

estewart08 added inline comments. Herald added subscribers: sstefan1, yaxunl. Herald added a project: All. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15450 } + bool VisitCXXThisExpr(CXXThisExpr *CTE) { return true; } + bool VisitStmt(Stmt *) { cchen wrote: >

[PATCH] D144516: [Flang] Add user option -funderscoring/-fnounderscoring

madanial created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: mehdi_amini. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. madanial requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a

[PATCH] D144136: Add a "remark" to report on array accesses

void added a comment. In D144136#4137143 , @kees wrote: > Here's a test-case. I'd expect 6 remarks from building this: > > /* Build with -Wall -O2 -fstrict-flex-arrays=3 -fsanitize=bounds > -Rarray-bounds */ > #include > #include > #include >

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

maryammo updated this revision to Diff 499273. maryammo added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144293/new/ https://reviews.llvm.org/D144293 Files: clang/lib/Headers/ppc_wrappers/emmintrin.h

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

maryammo added inline comments. Comment at: clang/lib/Headers/ppc_wrappers/smmintrin.h:310 __charmask = vec_gb(__charmask); - __v8hu __shortmask = (__v8hu)vec_unpackh(__charmask); + __v8hu __shortmask = (__v8hu)vec_unpackh((__v16qi)__charmask); #ifdef __BIG_ENDIAN__

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

aaron.ballman added a comment. In D144334#4142462 , @Izaron wrote: > In D144334#4141646 , @erichkeane > wrote: > >> I'm on the fence as to whether we want to implement this feature at all. As >> was discussed

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:723-727 +case attr::Assume: { + llvm::Value *ArgValue = EmitScalarExpr(cast(A)->getCond()); + llvm::Function *FnAssume = CGM.getIntrinsic(llvm::Intrinsic::assume); +

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

Izaron marked an inline comment as done. Izaron added a comment. In D144334#4142490 , @erichkeane wrote: > Just deliberately not support a part of C++2b. Implementers have veto'ed > features in the past exactly that way. That's sad. Let's at least

[clang] cfca5f4 - [Driver][FreeBSD] Fix DWARF test after 2a2c0fd96757871f4e8052624000c208cc574fdf

Author: Brad Smith Date: 2023-02-21T14:54:23-05:00 New Revision: cfca5f4d0c36d7560930df37b3a4a9cc85521529 URL: https://github.com/llvm/llvm-project/commit/cfca5f4d0c36d7560930df37b3a4a9cc85521529 DIFF: https://github.com/llvm/llvm-project/commit/cfca5f4d0c36d7560930df37b3a4a9cc85521529.diff

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 499259. elmcdonough marked 3 inline comments as done. elmcdonough added a comment. Comment edit + exhuastive testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

erichkeane added a comment. In D144334#4142462 , @Izaron wrote: > In D144334#4141646 , @erichkeane > wrote: > >> I'm on the fence as to whether we want to implement this feature at all. As >> was discussed

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

Izaron added a comment. In D144334#4141646 , @erichkeane wrote: > I'm on the fence as to whether we want to implement this feature at all. As > was discussed extensively during the EWG meetings on this: multiple > implementers are against this

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

amyk added inline comments. Comment at: clang/lib/Headers/ppc_wrappers/emmintrin.h:57 typedef __vector unsigned char __v16qu; +typedef __vector float __v2f; nemanjai wrote: > The name `__v2f` seems strange since `__vector float` is a vector of 4 > `float`

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation2/.clang-tidy:115 value: On - - key: readability-identifier-naming.HungarianNotation.Options.TreatStructAsClass -

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

sivachandra accepted this revision. sivachandra added a comment. Herald added subscribers: sstefan1, JDevlieghere. OK for libc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: bollu, tstellar, mehdi_amini, MaskRay, ChuanqiXu, to268, kparzysz, thieta, tschuett, mgorny, stellaraccident, mizvekov, ldionne, jdoerfert, phosek. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1,

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

amurzeau created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools-extra. Adjust identifier-naming-hungarian-notation-cfgfile test with

[PATCH] D144320: [Clang][OpenMP] Update tests using update_cc_test_checks.py

jdoerfert added a comment. LG, assuming the bots are happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144320/new/ https://reviews.llvm.org/D144320 ___ cfe-commits mailing list

[clang] 5d585c9 - [PowerPC] Use member function to determine PowerPC Secure PLT

Author: Brad Smith Date: 2023-02-21T14:08:25-05:00 New Revision: 5d585c9dd07d0df4d450e2b1ba61fb17a5153aac URL: https://github.com/llvm/llvm-project/commit/5d585c9dd07d0df4d450e2b1ba61fb17a5153aac DIFF: https://github.com/llvm/llvm-project/commit/5d585c9dd07d0df4d450e2b1ba61fb17a5153aac.diff

[PATCH] D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a2c0fd96757: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a… (authored by brad). Repository: rG LLVM Github

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d585c9dd07d: [PowerPC] Use member function to determine PowerPC Secure PLT (authored by brad). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

erichkeane added a comment. In D143670#4142351 , @aaron.ballman wrote: > In D143670#4133677 , @rsmith wrote: > >> Until or unless a C++ DR permits us to define >> `__has_cpp_attribute(carries_dependency)` to

[clang] 2a2c0fd - [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

Author: Brad Smith Date: 2023-02-21T14:08:26-05:00 New Revision: 2a2c0fd96757871f4e8052624000c208cc574fdf URL: https://github.com/llvm/llvm-project/commit/2a2c0fd96757871f4e8052624000c208cc574fdf DIFF: https://github.com/llvm/llvm-project/commit/2a2c0fd96757871f4e8052624000c208cc574fdf.diff

[PATCH] D144320: [Clang][OpenMP] Update tests using update_cc_test_checks.py

tianshilei1992 updated this revision to Diff 499241. tianshilei1992 added a comment. remove hash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144320/new/ https://reviews.llvm.org/D144320 Files: clang/test/OpenMP/amdgcn_target_codegen.cpp

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D143670#4133677 , @rsmith wrote: > Until or unless a C++ DR permits us to define > `__has_cpp_attribute(carries_dependency)` to any value other than `200809L`, > we have

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:4218-4223 defm openmp_implicit_rpath: BoolFOption<"openmp-implicit-rpath", LangOpts<"OpenMP">, - DefaultTrue, + DefaultFalse, PosFlag, NegFlag, BothFlags<[NoArgumentUnused]>>;

[PATCH] D142569: [OpenMP] Introduce kernel environment

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3917 + + Twine DynamicEnvironmenttName = KernelName + "_dynamic_environment"; + Constant

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau updated this revision to Diff 499239. amurzeau added a comment. Add a release note for this fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144431/new/ https://reviews.llvm.org/D144431 Files:

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:303 + llvm::SmallVector Includes; + auto It = MainFileIncludesBySpelling.find(Spelling); + if (It == MainFileIncludesBySpelling.end()) nit: ``` llvm::SmallVector Includes; for

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly added a comment. Jacob Young Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

5chmidti added a comment. You're right, I'll incorporate the logic for lambdas into `FindDeclRefsVisitor` and change the docs/comments/commit message to reflect this. I will try to think of more edge cases to test as well. Though I'll be busy until mid march with uni, so there will be no new

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau updated this revision to Diff 499235. amurzeau edited the summary of this revision. amurzeau added a comment. Remove test changes, I will make a different patch for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144431/new/

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. We thought a bit about what it would take to link a constructor declaration DIE to the various definitions (e.g., via a `DW_AT_LLVM_complete_ctor_linkage_name` or `DW_AT_LLVM_complete_ctor_ref`). The issue with this is that it would mess with type uniquing. E.g.,

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:66 + CXXBasePath &) { +if (BS->getType()->getAsCXXRecordDecl() == BaseClass && +BS->getAccessSpecifier() == AS_public)

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 499234. isuckatcs marked an inline comment as done. isuckatcs added a comment. Addressed comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files:

[PATCH] D144454: Add builtin for llvm set rounding

rjmccall added a comment. New builtins should be documented in the user manual. There are standard pragmas for changing the rounding mode, right? What's the interaction between the ability to set this dynamically with a builtin call and those pragmas? Comment at:

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

dim accepted this revision. dim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144456: [clangd] Publish diagnostics with stale preambles

kadircet updated this revision to Diff 499224. kadircet marked 7 inline comments as done. kadircet added a comment. - Notify preamble peer before building an AST, to concurrently build fresh preamble & AST. - Refactoring for tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

  1   2   >