[PATCH] D145214: [TSAN] add support for riscv64

jrtc27 added inline comments. Comment at: compiler-rt/CMakeLists.txt:529 # natively, but supports --as-needed/--no-as-needed for GNU ld compatibility. -if("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "sparc") +if("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "sparc|riscv")

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi created this revision. Herald added subscribers: luke, Enna1, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

bader added inline comments. Comment at: clang/test/Driver/offload-packager.c:2-3 +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target +// REQUIRES: amdgpu-registered-target +// UNSUPPORTED: system-windows Are nvptx and amdgpu target

[PATCH] D143328: [analyzer] Remove the loop from the exploded graph caused by missing information in program points

This revision was automatically updated to reflect the committed changes. Closed by commit rGd65379c8d476: [analyzer] Remove the loop from the exploded graph caused by missing… (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] d65379c - [analyzer] Remove the loop from the exploded graph caused by missing information in program points

Author: isuckatcs Date: 2023-03-04T02:01:45+01:00 New Revision: d65379c8d4768ddae143672f5d4827acafe22553 URL: https://github.com/llvm/llvm-project/commit/d65379c8d4768ddae143672f5d4827acafe22553 DIFF: https://github.com/llvm/llvm-project/commit/d65379c8d4768ddae143672f5d4827acafe22553.diff

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 502308. cjdb added a comment. tidies up some stuff that I overlooked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145284/new/ https://reviews.llvm.org/D145284 Files:

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 502305. cjdb edited the summary of this revision. cjdb added a comment. adds dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145284/new/ https://reviews.llvm.org/D145284 Files:

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik, dblaikie. Herald added a project: All. cjdb requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The original `-fdiagnostics-format=sarif` wrote

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) || +

[PATCH] D145093: Add map info for dereference pointer.

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) ||

[PATCH] D145173: Make section attribute and -ffunction-sections play nicely

MaskRay added a comment. > the programmer is indicating the function has some special purpose, and is > not expected to be garbage collected. There are use cases that GC semantics are desired. They may place the address function in a variable. I don't think changing the behavior by default is

[PATCH] D145238: [NVPTX] Expose LDU builtins

tra added a comment. Nice. Thank you! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18104 CodeGenFunction::EmitNVPTXBuiltinExpr(unsigned BuiltinID, const CallExpr *E) { - auto MakeLdg = [&](unsigned IntrinsicID) { + auto HasHalfSupport = [&](unsigned BuiltinID) { +auto =

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

yln accepted this revision. yln added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + usama54321 wrote: > yln wrote: > >

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > agozillon wrote: > >

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson added a comment. See D145173 for a different tactic to solve this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143745/new/ https://reviews.llvm.org/D143745 ___ cfe-commits mailing list

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

owenpan added a comment. In D145262#4168058 , @jaredgrubb wrote: > I wasn't sure about testing (this is my first patch!) and the test-case I did > was in `clang/test/Format` .. I can look at `clang/unittests/Format` and see > how to model something

[PATCH] D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes

probinson added a subscriber: cfe-commits. probinson added a project: clang. probinson added a comment. I've looked at this but I'd like someone more in tune with MSVC behavior to review as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145271/new/

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. Would be nice to have feedback on this! So much work was put into it! @rnk, @efriedma CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

dblaikie added a comment. In D145077#4168209 , @dblaikie wrote: > In D145077#4162110 , @aprantl wrote: > >> I originally was hoping we wouldn't have to introduce a new attribute for >> this, but it looks like

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

dblaikie added a comment. In D145077#4162110 , @aprantl wrote: > I originally was hoping we wouldn't have to introduce a new attribute for > this, but it looks like there are legitimate concerns about the alternatives, > so in that sense this looks

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz, fhahn. Herald added subscribers: luke, Anastasia, StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,

[PATCH] D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e035651fd3a: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage`… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5e03565 - [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

Author: Argyrios Kyrtzidis Date: 2023-03-03T12:48:48-08:00 New Revision: 5e035651fd3acbb2645abbe80cae332d90eac78a URL: https://github.com/llvm/llvm-project/commit/5e035651fd3acbb2645abbe80cae332d90eac78a DIFF:

[PATCH] D145269: Dump functions attribute right before their return type

giulianobelinassi created this revision. Herald added a project: All. giulianobelinassi requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. GCC rejects the following kind of dumps: int f(void)

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb added a comment. I wasn't sure about testing (this is my first patch!) and the test-case I did was in `clang/test/Format` .. I can look at `clang/unittests/Format` and see how to model something like it. If I do that, would that be in-addition-to or instead-of the test-case I

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb added a comment. For background, the current clang-format results in the following (`-style="{BasedOnStyle: LLVM, ColumnLimit: 0, AttributeMacros: [MACRO]}`): MACRO MACRO(A) @interface Foo @end MACRO(A) MACRO @interface Foo @end This patch improves it

[PATCH] D145264: [OpenMP][MLIR] Lower and apply RTLModuleFlagsAttr

agozillon added a comment. This builds on the following phabricator patches that are in review at the moment, so there are components that are used here that are added from these: https://reviews.llvm.org/D144864 : add fopenmp-is-device and an mlir is-device attribute for the OpenMP dialect

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

HazardyKnusperkeks added a comment. And please add an entry to the `ReleaseNotes.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 ___ cfe-commits mailing

[PATCH] D145264: [OpenMP][MLIR] Lower and apply RTLModuleFlagsAttr

agozillon created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle,

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

HazardyKnusperkeks added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks added a comment. Our tests reside in `clang/unittests/Format`, you want to look into the `TokenAnnotatorTests`. In fact **I** can't read the tests you wrote there. And could you please provide an example

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

HazardyKnusperkeks added a comment. Please reupload with the complete context. Please add tests. Comment at: clang/include/clang/Format/Format.h:827 + /// \code + /// someFunction( + /// int argument1, That's not a valid declaration (missing return

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

owenpan added a comment. Please add unit tests to relevant files in `clang/unittests/Format/`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 ___ cfe-commits

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb created this revision. jaredgrubb added reviewers: HazardyKnusperkeks, djasper, egorzhdan. jaredgrubb added a project: clang-format. Herald added a project: All. jaredgrubb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

owenpan added a comment. See also https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

owenpan added a comment. Please see https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > awarzynski wrote: > > This

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 502204. francii added a comment. Fix missing bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6327 } - if (Arg *A = Args.getLastArgNoClaim(options::OPT_p)) { + if (Arg *A = Args.getLastArg(options::OPT_p)) { if (TC.getTriple().isOSAIX()) { daltenty wrote: >

[PATCH] D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

akyrtzi updated this revision to Diff 502201. akyrtzi added a comment. Avoid passing a new `IgnoringDiagConsumer` for the test since it's unused. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145256/new/ https://reviews.llvm.org/D145256 Files:

[PATCH] D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145256/new/ https://reviews.llvm.org/D145256

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 502190. cjdb added a comment. fixes string goof Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files: clang/include/clang/Frontend/SARIFDiagnostic.h

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb added a comment. That test is kinda problematic because it seems that the artifacts aren't ordered. I think we should change this from a Comment at: clang/lib/Basic/Sarif.cpp:314-317 + llvm::sort(*Artifacts, [](const json::Value , const json::Value ) { +return

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 502186. cjdb added a comment. Herald added a subscriber: mgrang. sorts artifacts so that they're output in index order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201

[PATCH] D145228: [clangd] Add clangd headers to install targets

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145228/new/ https://reviews.llvm.org/D145228

[PATCH] D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. "But when would you have a completely empty diagnostic message", you ask dear reader? That is when there is an empty

[PATCH] D142328: [clang][Interp] Fix compound assign operator types

tbaeder added a comment. All the interpreter work is experimental so it doesn't really need to be in the release branch. This should all be fine, thanks for asking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142328/new/

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + yln wrote: > usama54321 wrote: > > yln wrote: > > > zixuw

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. Thank you very much @awarzynski I will wait for further approval! Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `(DRE.data() + any)`

ymandel added a comment. In D143128#4167626 , @jkorous wrote: > This is an interesting topic. In the abstract I see the question as: "Should > the Fix-Its prioritize how the code will fit the desired end state > (presumably modern idiomatic C++) or

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb added a comment. In D145178#4167103 , @aaron.ballman wrote: > LGTM, this is incremental progress. Hopefully we won't be adding too many > more RUN lines to this file though (sticking too many tests into one file is > also tech debt). Thanks!

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4052-4060 + // LLVM utilities like blocks with terminators. + auto *UI = Builder.CreateUnreachable(); + Instruction *ThenTI = UI, *ElseTI = nullptr; + if (IfCond) { +

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

jansvoboda11 added a comment. In D145098#4167163 , @Jake-Egan wrote: > Hi, this new test fails on AIX, could you take a look please? > https://lab.llvm.org/buildbot/#/builders/214/builds/6148/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c

[clang] 3ac8d32 - [clang][deps] Fix test failing on AIX

Author: Jan Svoboda Date: 2023-03-03T10:22:39-08:00 New Revision: 3ac8d322100bc72aaacb67f13eb21d9b644f9930 URL: https://github.com/llvm/llvm-project/commit/3ac8d322100bc72aaacb67f13eb21d9b644f9930 DIFF: https://github.com/llvm/llvm-project/commit/3ac8d322100bc72aaacb67f13eb21d9b644f9930.diff

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `(DRE.data() + any)`

jkorous added a comment. This is an interesting topic. In the abstract I see the question as should the Fix-Its prioritize how the code will fit the desired end state (presumably modern idiomatic C++) or carefully respect the state of the code as is now. The only thing I feel pretty strongly

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 502175. TIFitis marked 7 inline comments as done. TIFitis added a comment. Addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D145187: [Fuchsia] Add other necessary components to LLDB install.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc65fb80b73aa: [Fuchsia] Add other necessary components to LLDB install. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145187/new/

[clang] c65fb80 - [Fuchsia] Add other necessary components to LLDB install.

Author: Daniel Thornburgh Date: 2023-03-03T10:07:08-08:00 New Revision: c65fb80b73aa5087a4bba79e61d96b4d652e1b54 URL: https://github.com/llvm/llvm-project/commit/c65fb80b73aa5087a4bba79e61d96b4d652e1b54 DIFF:

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

hazohelet added a comment. In D142800#4165090 , @aaron.ballman wrote: > In D142800#4104241 , @hazohelet > wrote: > >>> Also, why are these diagnostics off by default? Do we have some idea as to >>> the false

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

hazohelet updated this revision to Diff 502166. hazohelet added a comment. Update the differential - Revise warning messages based on ideas from @aaron.ballman. - Introduce a new warning flag `-Wchaining-comparisons` that is enabled by default, to warn about chaining relationals or equal

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. > Thank you very much @awarzynski for suggesting them that was a great help. I'm happy that I could help :) The driver logic LGTM, but please wait for either @jdoerfert and/or

[PATCH] D144309: [HLSL] add max/min library functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ac0551e77f4: [HLSL] add max/min library functions (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/

[clang] 7ac0551 - [HLSL] add max/min library functions

Author: Joshua Batista Date: 2023-03-03T09:31:50-08:00 New Revision: 7ac0551e77f4adab18f3ac6ae428d4c09f9b6c49 URL: https://github.com/llvm/llvm-project/commit/7ac0551e77f4adab18f3ac6ae428d4c09f9b6c49 DIFF:

[clang] 34d6a6e - Fix bots by adding a triple to the test

Author: Aaron Ballman Date: 2023-03-03T12:26:52-05:00 New Revision: 34d6a6e23a6d8d78c86fad06bc219107ce6b5780 URL: https://github.com/llvm/llvm-project/commit/34d6a6e23a6d8d78c86fad06bc219107ce6b5780 DIFF: https://github.com/llvm/llvm-project/commit/34d6a6e23a6d8d78c86fad06bc219107ce6b5780.diff

[PATCH] D144454: Add builtin for llvm set rounding

rjmccall added a comment. Okay, so if we're adding this builtin, and it's not just imitating a stdlib function, we should definitely document it as a language extension. There's a section in the manual about controlling FP modes which is probably an appropriate place for this. I assume we

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) || +

[PATCH] D145093: Add map info for dereference pointer.

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7487-7497 + auto TNext = Next; + bool IsVarDerefAssoWithArray = false; + if (UO && UO->getOpcode() == UO_Deref) +for (; TNext != CE; TNext

[PATCH] D145093: Add map info for dereference pointer.

jyu2 updated this revision to Diff 502144. jyu2 added a comment. Thanks Alexey for the code review. I removed loop by using last expression in the component for checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

balazske updated this revision to Diff 502153. balazske added a comment. rebase, reformatted code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143751/new/ https://reviews.llvm.org/D143751 Files:

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

yln added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + usama54321 wrote: > yln wrote: > > zixuw wrote: > > > dmaclach

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. The new update adds the suggested new tests! Thank you very much @awarzynski for suggesting them that was a great help. Hopefully the new additions cover what you have requested, if not I am of course happy to change or add more tests as needed.

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This results in expressions that appear in default function argument not being checked for being actual constant

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 637ce0f - [C2x] Claim support for WG14 N2838

Author: Aaron Ballman Date: 2023-03-03T11:57:21-05:00 New Revision: 637ce0f7139015735d7e50cf12ad312a382f6283 URL: https://github.com/llvm/llvm-project/commit/637ce0f7139015735d7e50cf12ad312a382f6283 DIFF: https://github.com/llvm/llvm-project/commit/637ce0f7139015735d7e50cf12ad312a382f6283.diff

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

balazske updated this revision to Diff 502143. balazske added a comment. changed comments, small variable rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143751/new/ https://reviews.llvm.org/D143751 Files:

[clang] 4679d7a - [NFC][ARM][AArch64] Cleanup TargetParser includes

Author: Archibald Elliott Date: 2023-03-03T16:24:55Z New Revision: 4679d7a26a5f42f1128fac6fdf49488d13066c52 URL: https://github.com/llvm/llvm-project/commit/4679d7a26a5f42f1128fac6fdf49488d13066c52 DIFF: https://github.com/llvm/llvm-project/commit/4679d7a26a5f42f1128fac6fdf49488d13066c52.diff

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 502139. agozillon added a comment. - [Flang][MLIR][Test] Add newline at end of test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 Files:

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. Went with unsupported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 502138. dmaclach marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:329 + * CXIndexOptions Opts = { sizeof(CXIndexOptions), + * clang_getDefaultGlobalOptions() }; + * \endcode vedgy wrote: > aaron.ballman wrote: > > vedgy

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

donat.nagy added inline comments. Comment at: clang/docs/analyzer/checkers.rst:78-80 +The ``SuppressAddressSpaces`` option suppresses warnings for null dereferences of all pointers with address spaces. You can disable this behavior with the option Why is this

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 502134. agozillon added a comment. - [MLIR][OpenMP] Fix attribute helpers to apply to more than builtin.module - [Flang][mlir] Adding space at the end of the omp-is-device test file - [Clang][Flang][Driver][Test] Add flang-omp.f90 to test

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

shafik added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19907 + if (Iter != I.end()) { +SemaRef.PendingInstantiations.push_back(*Iter); +I.erase(Iter); Doesn't this invalidate the iterators? Repository: rG LLVM

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

Jake-Egan added a comment. Hi, this new test fails on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/6148/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144546: [clang][dataflow] Fix assert for CXXConstructExpr argument number

steakhal added a comment. By looking at the title, I get the impression that this fixes an assertion violation. I also observed that this commit is part of `main` but not part of `release/16.x`, hence the `clang-16` would be released without this fix. I want to raise awareness of backporting

[PATCH] D142384: [C++20] Fix a crash with modules.

steakhal added a comment. @usaxena95 @ilya-biryukov, @hans, I wonder if we should backport this change to `release/16.x`. Otherwise, clang-16 won't have this fix. WDYT? I'm also a bit worried that we don't have tests. And that we have "unexpected" sideeffects like what you mentioned @hans.

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

nathanchance added a comment. @amyk thank you so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144967/new/ https://reviews.llvm.org/D144967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142328: [clang][Interp] Fix compound assign operator types

steakhal added a comment. Hi @tbaeder, I was looking for commits that mentions "fix" "assertion" or "crash" in the title, that are part of the `main` branch but not backported to `release/16.x` to be eventually released as `clang-16`. I wonder what's the status of this and the related patches

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

aaron.ballman added a comment. It looks like there's a valid precommit CI failure that needs to be addressed: Failed Tests (1): Clang :: Frontend/sarif-diagnostics.cpp Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:214 void

[PATCH] D145244: [clang-format] Add ability to trace tokens.

klimek updated this revision to Diff 502123. klimek added a comment. Remove superfluous include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145244/new/ https://reviews.llvm.org/D145244 Files: clang/lib/Format/CMakeLists.txt

[PATCH] D145244: [clang-format] Add ability to trace tokens.

klimek created this revision. klimek added a reviewer: sammccall. Herald added a project: All. klimek requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145244 Files: clang/lib/Format/CMakeLists.txt

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, this is incremental progress. Hopefully we won't be adding too many more RUN lines to this file though (sticking too many tests into one file is also tech debt).

[PATCH] D65956: clang: Diag running out of file handles while looking for files

karies added a comment. Herald added a project: All. Similar to the concern raised at https://github.com/llvm/llvm-project/commit/50fcf7285eeb001d751eadac5d001a0e216fd701 we have received user reports about this patch: with `-Ino-access-permissions -Iall-good`, clang will throw an error

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda created this revision. jchlanda added a reviewer: tra. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jchlanda requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jholewinski. Herald added projects: clang, LLVM.

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

DavidSpickett added a comment. I'm not familiar with the details of toolchain config, but added some general comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1404 + // OHOS-specific defaults for PIC/PIE + if (Triple.isOHOSFamily()) { +switch

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 502112. jrmolin added a comment. Finally figured out how to run the latest `git-clang-format` on the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Thanks for making the change. I am still going through the patch, I have a few comments. Comment at:

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 502110. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

mgabka added a comment. In D144179#4146599 , @MaskRay wrote: > This looks like introducing a footgun (when something behaves differently > from an upstream Clang, it would be difficult for toolchain maintainers to > know why). > Why can't your user

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added a comment. @kiranchandramohan I've added the MLIR test as requested. Please let me know if any other changes are required :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

amyk added a comment. In D144967#4164858 , @nathanchance wrote: > Could this be merged into `main` and backported to `release/16.x`? If this > makes 16.0.0 final, I think the kernel can avoid working around this issue > altogether, as `-mtune` was

  1   2   >