[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

nridge added a comment. Thanks for the patch! May I suggest the flag name `IncludeDelimiter`, with values `Auto` and `AlwaysBrackets` (with the default being `Auto`)? This leaves room for other styles in the future if desired. It would mean a slight implementation change since the YAML

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

dyung added a comment. In D143436#4203525 , @dyung wrote: > In D143436#4203394 , > @DmitryPolukhin wrote: > >> @dyung I cannot reproduce this issue on two different machines in both cases >> tests work fine.

[PATCH] D145401: [AMDGPU] Reserve extra SGPR blocks wth XNACK "any" TID Setting

This revision was automatically updated to reflect the committed changes. Closed by commit rG864a2b25beac: [AMDGPU] Reserve extra SGPR blocks wth XNACK any TID Setting (authored by kerbowa). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145401/new/

[clang] 864a2b2 - [AMDGPU] Reserve extra SGPR blocks wth XNACK "any" TID Setting

Author: Austin Kerbow Date: 2023-03-17T20:26:23-07:00 New Revision: 864a2b25beac507cc76b50030757283aae434c0c URL: https://github.com/llvm/llvm-project/commit/864a2b25beac507cc76b50030757283aae434c0c DIFF: https://github.com/llvm/llvm-project/commit/864a2b25beac507cc76b50030757283aae434c0c.diff

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

yaxunl added a comment. In D145721#4182834 , @tra wrote: >> clang should pass `-mno-amdgpu-ieee` to -cc1 > > It would be useful to have some details on why we should pass that option. `-mamdgpu-ieee` was introduced by https://reviews.llvm.org/D77013 but

[PATCH] D140663: CUDA/HIP: Use kernel name to map to symbol

yaxunl added a comment. In D140663#4203604 , @tra wrote: > It appears that this patch may be causing a use-after free when we attempt to > generate kernel registration code. > The root cause is that the value we insert into `KernelHandles` by name is

[PATCH] D146328: [clang][deps] Only cache files with specific extension

Bigcheese accepted this revision. Bigcheese added a comment. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 ___ cfe-commits mailing list

[PATCH] D140663: CUDA/HIP: Use kernel name to map to symbol

tra added a comment. It appears that this patch may be causing a use-after free when we attempt to generate kernel registration code. The root cause is that the value we insert into `KernelHandles` by name is later on replaced by a different instance of the global value with the same name.

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

vzakhari added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:238 + pm.addPass(mlir::createCanonicalizerPass()); + pm.addPass(hlfir::createLowerHLFIRIntrinsicsPass()); + pm.addPass(hlfir::createBufferizeHLFIRPass()); I would imagine we

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 updated this revision to Diff 506242. jansvoboda11 added a comment. Improve member documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 Files:

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 updated this revision to Diff 506241. jansvoboda11 added a comment. Disable brace initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 Files:

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 updated this revision to Diff 506240. jansvoboda11 added a comment. Use brace initialization in named constructors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 Files:

[PATCH] D146342: [WIP][-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a subscriber: ChuanqiXu. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Our

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 updated this revision to Diff 506237. jansvoboda11 added a comment. Herald added a subscriber: ormris. Use named constructors instead of an argument to `PathPolicy`, add unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

dyung added a comment. In D143436#4203394 , @DmitryPolukhin wrote: > @dyung I cannot reproduce this issue on two different machines in both cases > tests work fine. For clang and llvm-jitlink binaries (the only binaries used > in the tests) my changes

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

wolfgangp created this revision. wolfgangp added reviewers: hans, probinson, mstorsjo. Herald added a project: All. wolfgangp requested review of this revision. This replaces D145271 . Rather than coercing classes with UniqueExternalLInkage to ExternalLinkage as

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. Could you please also advice me what else need to be done for the ObjC, since there were many years since I wrote ObjC last time I'm not sure what else need to be done there. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:24 +namespace clang { +namespace clangd { +namespace { tschuett wrote: > You can merge this into `namespace clang::clangd`. I prefer not to do it, because all

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos updated this revision to Diff 506220. tupos marked 11 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/ https://reviews.llvm.org/D140275 Files: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp

[PATCH] D146328: [clang][deps] Only cache files with specific extension

Bigcheese added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:272-291 +enum class Enable { Yes, No }; +enum class ScanFile { Yes, No }; +enum class CacheStatFailure { Yes, No }; + +struct PathPolicy { + unsigned

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @dyung I cannot reproduce this issue on two different machines in both cases tests work fine. For clang and llvm-jitlink binaries (the only binaries used in the tests) my changes are non-functional and I didn't change anything in compiler-rt or ORC. Are you able

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 updated this revision to Diff 506205. jansvoboda11 added a comment. Remove configurable `CacheSuccess`, rename `CacheFailure` to `CacheStatFailure`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/

[PATCH] D146328: [clang][deps] Only cache files with specific extension

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. This doesn't appear to behave as expected for `PP_CacheFailure` or `PP_ScanFile` without `PP_CacheSuccess`. Looks like that will still cache. Should probably just assert that's not the

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

shafik added a comment. I would have loved to test the case from https://github.com/llvm/llvm-project/issues/61335 directly but I think in order to do it nicely I need `__builtin_memset` to be usable in a constant expression context. I will add this to my todo list. I am open to other

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, rsmith. Herald added a project: All. shafik requested review of this revision. If we look at class.bit p2 it tells us that that unnamed bit-fields are not members and

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c9ec74e3f2a: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead… (authored by dhruvachak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146326: [LinkerWrapper] Do not extract globals with no offloading language

jhuber6 updated this revision to Diff 506190. jhuber6 added a comment. Remove whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146326/new/ https://reviews.llvm.org/D146326 Files: clang/test/Driver/linker-wrapper-libs.c

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6acdf58919d5: [clang] Properly parse variable template requires clause in lambda (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D146328: [clang][deps] Only cache files with specific extension

ributzka added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161 -/// Whitelist file extensions that should be minimized, treating no extension as -/// a source file that should be minimized. +/// Whitelist file extensions

[clang] 6acdf58 - [clang] Properly parse variable template requires clause in lambda

Author: Emilia Dreamer Date: 2023-03-17T22:29:48+02:00 New Revision: 6acdf58919d5e66809555acf5809b12c54ba79dd URL: https://github.com/llvm/llvm-project/commit/6acdf58919d5e66809555acf5809b12c54ba79dd DIFF:

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the scanner's VFS,

[PATCH] D146326: [LinkerWrapper] Do not extract globals with no offloading language

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl, tianshilei1992. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. The linker wrapper

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. In D143436#4203008 , @dyung wrote: > @DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a > bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or > revert if you need time to

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

rsmith added a comment. I have no strong opinions on the merits of this patch in either direction; I think the "sorry"s in the Sema diagnostics for regrettable non-conformance make Clang marginally friendlier, but they do nothing to actually help people who encounter the diagnostic. FWIW, the

[PATCH] D146187: [docs] Update the status for coroutines

bruno added a comment. > ... I think in general we want feature testing macros to be treated as our > signal to the user that we think something is complete, not that we think > something is in progress but pretty usable. +1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146187/new/

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

dyung added a comment. @DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/247/builds/2639

[PATCH] D146323: inline stmt attribute diagnosing in templates

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. D146089 's author discovered that our diagnostics for always/no inline would null-dereference when used

[PATCH] D146163: Experimental new python bindings for clang/llvm based on Cython

tschuett added a comment. In D146163#4202969 , @rickmark wrote: > Began discussion in Discord to see interest for other collaborators on this > type of binding: > https://discord.com/channels/636084430946959380/700158649129238591/1086362007684513844

[PATCH] D146163: Experimental new python bindings for clang/llvm based on Cython

rickmark added a comment. Began discussion in Discord to see interest for other collaborators on this type of binding: https://discord.com/channels/636084430946959380/700158649129238591/1086362007684513844 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

rsmith added a comment. In D145737#4202351 , @aaron.ballman wrote: > Checking: are the libc++ precommit CI failures related to these changes? It's > a modules-specific build config, so I figured it's worth double-checking. I took a quick glance when I

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

taymonbeal added a comment. I don't have commit access; can someone who does commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146247/new/ https://reviews.llvm.org/D146247 ___ cfe-commits

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

taymonbeal updated this revision to Diff 506153. taymonbeal added a comment. Add release notes and unit test in TokenAnnotatorTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146247/new/ https://reviews.llvm.org/D146247 Files:

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

bruno added a comment. > @bruno, @ChuanqiXu please let us know if you have any objections, otherwise > we will land the revert in ~2 hours. No sweat, I didn't see this in time. Thanks for the reduced testcase. > What's the resolution here? Can we revert this and continue the discussions >

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 506141. VitaNuo added a comment. Finish the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

vzakhari added a comment. Thank you for working on this! Comment at: flang/include/flang/Tools/CLOptions.inc:235 +/// passes pipeline +inline void createHLFIRToFIRPassPipeline(mlir::PassManager , +llvm::OptimizationLevel optLevel = defaultOptLevel) {

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Sorry about that. I was trying to look for a fix, and I think it has something to do with these recent changes . I'll have a new revision soon. Repository: rG LLVM Github

[PATCH] D146310: [clang-format] Fix dropped 'else' in 398cddf6acec

jaredgrubb added a comment. The difference doesn't appear to affect any unit tests (which is unfortunate), but I think you didn't mean to remove this else, based both on the logic of the original commit and the format of the patched line. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146310: [clang-format] Fix dropped 'else' in 398cddf6acec

jaredgrubb created this revision. jaredgrubb added a reviewer: klimek. jaredgrubb added a project: clang-format. Herald added a project: All. jaredgrubb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A patch (398cddf6acec

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo added a comment. Thanks for the comments and the discussions! Comment at: clang-tools-extra/clangd/Hover.cpp:1118 + + for (const auto : Headers) { +if (H.kind() == include_cleaner::Header::Physical && hokein wrote: > now the for-range loop

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d0c88975212: [clang][WebAssembly] Initial support for reference type funcref in clang (authored by pmatos). Changed prior to commit:

[clang] 8d0c889 - [clang][WebAssembly] Initial support for reference type funcref in clang

Author: Paulo Matos Date: 2023-03-17T18:31:44+01:00 New Revision: 8d0c889752121e62e7258570c592b905f544d36f URL: https://github.com/llvm/llvm-project/commit/8d0c889752121e62e7258570c592b905f544d36f DIFF: https://github.com/llvm/llvm-project/commit/8d0c889752121e62e7258570c592b905f544d36f.diff

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 506132. VitaNuo marked 15 inline comments as done. VitaNuo added a comment. Address review comments, simplify test. Take care of main file as provider handling: - provider list [main-file,foo.h] and foo.h \#include'd - not show any providers on hover. -

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 506125. Leporacanthicus added a comment. Rebase and fix conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files:

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. I reverted your patch since the buildbot was failing for couple of hours. Feel free to re-land it when you have a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added a comment. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 506121. rymiel added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaConcept.cpp

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak updated this revision to Diff 506107. dhruvachak marked an inline comment as done. dhruvachak added a comment. Removed attributes (as original) from clang test OpenMP/target_map_codegen_hold.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 807d397 - [clang] Fix two unused variable warnings from if statements. NFC

Author: Craig Topper Date: 2023-03-17T09:18:13-07:00 New Revision: 807d397c751355ae02a89cb5178192752b832203 URL: https://github.com/llvm/llvm-project/commit/807d397c751355ae02a89cb5178192752b832203 DIFF: https://github.com/llvm/llvm-project/commit/807d397c751355ae02a89cb5178192752b832203.diff

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added a comment. In D146089#4202374 , @erichkeane wrote: > To highlight the fix. See the rest of our release notes. 4743c03ca8fcb61b8fa4022c38cf93cf55d7f6fd

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cd31a7d3087: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to… (authored by agozillon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0cd31a7 - [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

Author: Andrew Gozillon Date: 2023-03-17T11:12:16-05:00 New Revision: 0cd31a7d308714d26f49391ac4ea9f6bce5fa324 URL: https://github.com/llvm/llvm-project/commit/0cd31a7d308714d26f49391ac4ea9f6bce5fa324 DIFF:

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 3 inline comments as done. pmatos added a comment. Thanks all for the comments, fixed and will soon land after running a check-all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440

[clang] 4743c03 - [Docs] Add release notes for D146089.

Author: Craig Topper Date: 2023-03-17T09:03:08-07:00 New Revision: 4743c03ca8fcb61b8fa4022c38cf93cf55d7f6fd URL: https://github.com/llvm/llvm-project/commit/4743c03ca8fcb61b8fa4022c38cf93cf55d7f6fd DIFF: https://github.com/llvm/llvm-project/commit/4743c03ca8fcb61b8fa4022c38cf93cf55d7f6fd.diff

[clang] 4361ba7 - Revert "[Coroutines] Fix premature conversion of return object"

Author: Ilya Biryukov Date: 2023-03-17T17:01:43+01:00 New Revision: 4361ba791cd6ab6e41fca4df3fd337da0c116132 URL: https://github.com/llvm/llvm-project/commit/4361ba791cd6ab6e41fca4df3fd337da0c116132 DIFF: https://github.com/llvm/llvm-project/commit/4361ba791cd6ab6e41fca4df3fd337da0c116132.diff

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

aaron.ballman added a comment. In D146041#4198056 , @AryanGodara wrote: > I will try to split this commit, and update on this asap (Sorry for the late > update, I have mid-sem exams going on, I haven't abandoned this issue, still > working on it). No

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane added a comment. To highlight the fix. See the rest of our release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146089/new/ https://reviews.llvm.org/D146089 ___ cfe-commits mailing

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added a comment. In D146089#4202037 , @erichkeane wrote: > Please add a release note as requested. To highlight the fix or highlight the missing warning? Or both? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

aaron.ballman added a comment. Checking: are the libc++ precommit CI failures related to these changes? It's a modules-specific build config, so I figured it's worth double-checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145737/new/

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

asb added a comment. This broke `-DBUILD_SHARED_LIBS=True` builds - I committed rG482d22d05a4a30a4f8594273bd359f7d311c9d4c to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144651: [Serialization] Place command line defines in the correct file

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you should also add a release note for the fix. Comment at: clang/lib/Serialization/ASTReader.cpp:1593 +if (Record[3]) { +

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added a comment. May I please request a final acceptance from both @jhuber6 and @awarzynski before I commit this upstream! If you have no further comments to add or requests of course. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. pre-commit ci is showing a different failure: TEST 'Flang :: Examples/feature-list-class.f90' FAILED Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/flang-new -fc1 -load

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1696 if (TC.getTriple().isOSAIX()) { + if (Args.hasArg(options::OPT_r)) +break; I think this is redundant, we guard out this whole function call in the block

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237 +// Add directory to library search path. +Args.AddAllArgs(CmdArgs, options::OPT_L); +ToolChain.AddFilePathLibArgs(Args, CmdArgs); This mostly looks good, but I'm not

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

PiotrZSL added a comment. I will check this more deeply during weekend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. In D143704#4202146 , @elmcdonough wrote: > Haven't been able to check this yet, but I think it might be due to the tests > expecting a deterministic output. I've only ever tested on Ubuntu WSL, so > its possible the order

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito planned changes to this revision. ManuelJBrito added a comment. Implementing the 128 to 512 casts by filling the rest of the vector with the same definition of a nondeterministic_value is not correct because : a = freeze poison v = is not the same as v = freeze poison The only

[clang] 482d22d - [clang][test] Fix -DBUILD_SHARED_LIBS build by adding depency on MC from clangTesting

Author: Alex Bradbury Date: 2023-03-17T14:45:48Z New Revision: 482d22d05a4a30a4f8594273bd359f7d311c9d4c URL: https://github.com/llvm/llvm-project/commit/482d22d05a4a30a4f8594273bd359f7d311c9d4c DIFF: https://github.com/llvm/llvm-project/commit/482d22d05a4a30a4f8594273bd359f7d311c9d4c.diff

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 506081. MarcoFalke added a comment. sort doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:190 +- Improved :doc:`bugprone-use-after-move + ` check to also cover constructor Please keep alphabetical order (by check name) in this section. CHANGES SINCE LAST

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Haven't been able to check this yet, but I think it might be due to the tests expecting a deterministic output. I've only ever tested on Ubuntu WSL, so its possible the order is different on different platforms. I think replacing CHECK-NEXT with CHECK-DAG might

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

probinson added a comment. Is it possible you need to look only at the immediately preceding field, and not iterate? For example, struct zero_bitfield { char a : 8; char : 0; char b : 8; char c : 8; }; If processing `b` sees the zero-length bitfield and does the needful,

[PATCH] D144878: __builtin_FILE_NAME()

This revision was automatically updated to reflect the committed changes. Closed by commit rG2147e940e8a8: Add __builtin_FILE_NAME() (authored by karapsinie, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D144878?vs=505468=506078#toc Repository: rG LLVM

[clang] 2147e94 - Add __builtin_FILE_NAME()

Author: Ilya Karapsin Date: 2023-03-17T09:52:41-04:00 New Revision: 2147e940e8a8f85f97f28407989c628886b5cd7e URL: https://github.com/llvm/llvm-project/commit/2147e940e8a8f85f97f28407989c628886b5cd7e DIFF: https://github.com/llvm/llvm-project/commit/2147e940e8a8f85f97f28407989c628886b5cd7e.diff

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:805-807 +/// [C++11] simple-type-specifier braced-init-list [C++11 5.2.3] /// [C++] typename-specifier '(' expression-list[opt] ')' [C++ 5.2.3] +/// [C++11] typename-specifier

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane added a comment. Please add a release note as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146089/new/ https://reviews.llvm.org/D146089 ___ cfe-commits mailing list

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

4vtomat updated this revision to Diff 506062. 4vtomat added a comment. Resolved Craig and Kito's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4200821 , @rsmith wrote: > The approach of attempting to adjust the depth here is not correct, and we > should rip this whole mechanism out and reimplement it. Consider this > closely related testcase: > >

[PATCH] D146146: [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings.

This revision was automatically updated to reflect the committed changes. Closed by commit rG62f09d788f9f: [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings. (authored by paulwalker-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 62f09d7 - [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings.

Author: Paul Walker Date: 2023-03-17T12:49:45Z New Revision: 62f09d788f9fc540db12f3cfa2f98760071fca96 URL: https://github.com/llvm/llvm-project/commit/62f09d788f9fc540db12f3cfa2f98760071fca96 DIFF: https://github.com/llvm/llvm-project/commit/62f09d788f9fc540db12f3cfa2f98760071fca96.diff LOG:

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 506055. MarcoFalke added a comment. clang-format+doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added a comment. In D146140#4201481 , @cor3ntin wrote: > Do we need a release note for this? Yes, good catch! @rymiel : can you please add one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1523 + auto bodyCB = [&](InsertPointTy allocaIP, InsertPointTy codeGenIP) { +// DataOp has only one region associated with it. +auto = cast(op).getRegion();

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 506054. TIFitis marked 5 inline comments as done. TIFitis added a comment. Addresed reviewer comments. Removed flang changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[clang] e495eab - [clang] Include the error message in file reading error diagnostic

Author: Hans Wennborg Date: 2023-03-17T13:47:02+01:00 New Revision: e495eabd326801c1e00508898dbcb04073a31014 URL: https://github.com/llvm/llvm-project/commit/e495eabd326801c1e00508898dbcb04073a31014 DIFF: https://github.com/llvm/llvm-project/commit/e495eabd326801c1e00508898dbcb04073a31014.diff

[PATCH] D146280: [clang] Include the error message in file reading error diagnostic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe495eabd3268: [clang] Include the error message in file reading error diagnostic (authored by hans). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146280: [clang] Include the error message in file reading error diagnostic

hans added a comment. In D146280#4201769 , @thakis wrote: > (if the presubmit is related, maybe some flang test needs updating? Weird > that flang uses clang's diags.) The presubmit errors look unrelated and the flang tests seem fine locally.

[PATCH] D146275: [libclang] Fix documentation; NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d91b0dae0a9: [libclang] Fix documentation; NFC (authored by vedgy, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2d91b0d - [libclang] Fix documentation; NFC

Author: Igor Kushnir Date: 2023-03-17T08:40:08-04:00 New Revision: 2d91b0dae0a902317d384a44f588107d04c9ad3c URL: https://github.com/llvm/llvm-project/commit/2d91b0dae0a902317d384a44f588107d04c9ad3c DIFF: https://github.com/llvm/llvm-project/commit/2d91b0dae0a902317d384a44f588107d04c9ad3c.diff

[PATCH] D146275: [libclang] Fix documentation; NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146275/new/ https://reviews.llvm.org/D146275

  1   2   >