[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:3 +option(FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS "Use multiple distributions") +option(FUCHSIA_ENABLE_LLDB "Enable LLDB") Could we use multiple distributions unconditionally?

[PATCH] D146644: [documentation]Fixed Random Typos

ipriyanshi1708 updated this revision to Diff 507961. ipriyanshi1708 added a comment. Fixed one more Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146644/new/ https://reviews.llvm.org/D146644 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1779-1782 nextToken(); +// Return types: pointers are ok too. +while (FormatTok->is(tok::star)) + nextToken(); Comment at:

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Ruturaj4 updated this revision to Diff 507958. Ruturaj4 added a comment. 1. Updating D146385 : [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef # 2. Enter a brief description of the changes included in this update. 3.

[PATCH] D146758: Fix codegen for coroutine with function-try-block

ChuanqiXu requested changes to this revision. ChuanqiXu added a comment. This revision now requires changes to proceed. Thanks for finding this! We didn't notice this before. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:724-730 + Stmt *BodyStmt = S.getBody(); +

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth added a comment. I've split this into smaller patch sets by project: LLVM: https://reviews.llvm.org/D146776 Clang: https://reviews.llvm.org/D146777 LLD: https://reviews.llvm.org/D146778 If we're happy with that, then we can probably abandon this revision in favor of those.

[PATCH] D146777: [clang] Preliminary fat-lot-object support

paulkirth created this revision. paulkirth added reviewers: phosek, tejohnson, MaskRay, alexander-shaposhnikov. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

dblaikie added a comment. In D146595#4218040 , @augusto2112 wrote: What would happen if, instead, these trampolining functions were annotated nodebug? I guess then you wouldn't have the top level one as an entry point for the user, as

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11786 + "%select{" +"unsafe operation on raw pointer in expression|" +"unsafe arithmetic on raw pointer|" The first mode doesn't show up in any tests and it's

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ created this revision. NoQ added reviewers: jkorous, t-rasmud, ziqingluo-90, malavikasamak, aaron.ballman, gribozavr, ymandel, sgatev. Herald added subscribers: steakhal, martong. Herald added a project: All. NoQ requested review of this revision. So far we didn't pay enough attention to

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

augusto2112 marked an inline comment as done. augusto2112 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:776 + let Subjects = SubjectList<[Function, ObjCMethod]>; + let Args = [StringArgument<"Name">]; + let Documentation = [TrampolineDocs];

[PATCH] D146466: [clang] diagnose function fallthrough

dblaikie added a comment. In D146466#4218011 , @efriedma wrote: > I think the reason "recoverable" ubsan causes trouble is that it introduces > branches that subsequent optimizations can abuse. So without ubsan, we just > have an udiv instruction.

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 updated this revision to Diff 507922. augusto2112 added a comment. Addressed feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/include/clang/Basic/Attr.td

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB added inline comments. Comment at: clang/test/CodeGenCoroutines/coro-function-try-block.cpp:1 +// RUN: %clang_cc1 -std=c++20 -triple=x86_64-- -emit-llvm -fcxx-exceptions \ +// RUN:-disable-llvm-passes %s -o - | FileCheck %s bruno wrote: >

[PATCH] D146758: Fix codegen for coroutine with function-try-block

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! @ChuanqiXu wdyt? Comment at: clang/test/CodeGenCoroutines/coro-function-try-block.cpp:1 +// RUN: %clang_cc1 -std=c++20 -triple=x86_64-- -emit-llvm -fcxx-exceptions \ +//

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

This revision was automatically updated to reflect the committed changes. Closed by commit rG07ef7b1ff21e: [Builtins] Add __builtin_assume_separate_storage (authored by bruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/

[clang] 07ef7b1 - [Builtins] Add __builtin_assume_separate_storage

Author: Bruno Cardoso Lopes Date: 2023-03-23T16:35:30-07:00 New Revision: 07ef7b1ff21e8e3faaf8279b8ec6a7f0ac252fad URL: https://github.com/llvm/llvm-project/commit/07ef7b1ff21e8e3faaf8279b8ec6a7f0ac252fad DIFF:

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ updated this revision to Diff 507912. NoQ added a comment. Don't recommend enabling suggestions when suggestions are impossible (eg. due to lack of C++20). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146669/new/ https://reviews.llvm.org/D146669 Files:

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 added a comment. >>> What would happen if, instead, these trampolining functions were annotated >>> nodebug? I guess then you wouldn't have the top level one as an entry point >>> for the user, as there would be no debug info for it? >> >> These trampoline functions can call other

[clang] 399f313 - [Driver] Remove remnant mips64el-linux-android code after D146565

Author: Fangrui Song Date: 2023-03-23T16:00:17-07:00 New Revision: 399f313f271342d1d838bf396af5c5d8d587915a URL: https://github.com/llvm/llvm-project/commit/399f313f271342d1d838bf396af5c5d8d587915a DIFF: https://github.com/llvm/llvm-project/commit/399f313f271342d1d838bf396af5c5d8d587915a.diff

[PATCH] D146466: [clang] diagnose function fallthrough

efriedma added a comment. I think the reason "recoverable" ubsan causes trouble is that it introduces branches that subsequent optimizations can abuse. So without ubsan, we just have an udiv instruction. With ubsan, we conveniently have a branch on exactly the condition that would make the

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

int3 added a comment. I'm trying to add similar support to lld-macho, hence the question :) Comment at: lld/COFF/LTO.cpp:183 + [&](size_t task, const Twine ) { +buf[task].first = moduleName.str(); return std::make_unique( Any reason why

[clang] bb0ecb7 - [Driver][test] Remove remnant mips*-linux-android tests after 805f51f9fedf90d2aa0ad46c61cb4c9c0c5bcfe9

Author: Fangrui Song Date: 2023-03-23T15:49:38-07:00 New Revision: bb0ecb7bf0d0025e61086ae449dae099a8a8bf14 URL: https://github.com/llvm/llvm-project/commit/bb0ecb7bf0d0025e61086ae449dae099a8a8bf14 DIFF: https://github.com/llvm/llvm-project/commit/bb0ecb7bf0d0025e61086ae449dae099a8a8bf14.diff

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11792 "change type of '%0' to '%select{std::span|std::array|std::span::iterator}1' to preserve bounds information">; +def note_safe_buffer_usage_suggestions_disabled : Note< + "pass

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ updated this revision to Diff 507903. NoQ added a comment. Explain the weird variable name. Confirm that even though `warn_unsafe_buffer_operation` and `note_unsafe_buffer_operation` have a different number of modes, the mismatch doesn't cause problems yet. Add an assert to catch the

[PATCH] D146595: [clang] Add clang trampoline attribute

dblaikie added a comment. In D146595#4217855 , @augusto2112 wrote: >> Should there be some check that that symbol exists? (the current test uses >> the unmangled name "bar" for instance - which gives the wrong impression?) > > You mean as part of the

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC makes these string literals [1][2]. [1] https://godbolt.org/z/6vnTzbExx [2]

[PATCH] D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc13ccf1fbabe: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type… (authored by chaitanyav). Repository: rG LLVM Github

[clang] c13ccf1 - [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id

Author: NagaChaitanya Vellanki Date: 2023-03-23T15:10:27-07:00 New Revision: c13ccf1fbabede34ff28461b29d2d14aceb293fd URL: https://github.com/llvm/llvm-project/commit/c13ccf1fbabede34ff28461b29d2d14aceb293fd DIFF:

[PATCH] D146565: [clang] Remove mips target triple for Android

hiraditya added a comment. llvm/test/CodeGen/Mips/ removed here: https://reviews.llvm.org/rG805f51f9fedf90d2aa0ad46c61cb4c9c0c5bcfe9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146565/new/ https://reviews.llvm.org/D146565

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:2886-2889 +struct UnnamedEmptyBitfield { + int named; + int : 0; +}; royjacobson wrote: > shafik wrote: > > aaron.ballman wrote: > > > I think there's one more test to add: > > >

[PATCH] D146712: [clang-tidy] Add portability-non-portable-integer-constant check

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Additionally, fix build. Once you finish making changes to this review, switch it back to ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146396: [clang-tidy] Use checks dependences for Analyzer checks

PiotrZSL planned changes to this revision. PiotrZSL added a comment. Verify with Static Analyser developers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146396/new/ https://reviews.llvm.org/D146396

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 marked 4 inline comments as done. augusto2112 added a comment. > Should there be some check that that symbol exists? (the current test uses > the unmangled name "bar" for instance - which gives the wrong impression?) You mean as part of the attribute validation? > What would happen

[PATCH] D146466: [clang] diagnose function fallthrough

dblaikie added a comment. (recoverable feels like a bit of a distraction here? recoverable just means you've asked ubsan not to trap/stop on failure - but to let the program continue and do whatever it would've done without the sanitizer enabled - sometimes that's crash/trap anyway, sometimes

[clang] 9ddc03a - [OpenMP] Fix test after updating NVPTX atomic inlines

Author: Joseph Huber Date: 2023-03-23T16:41:25-05:00 New Revision: 9ddc03a17dba1d7aaad73067325344f6b79441b0 URL: https://github.com/llvm/llvm-project/commit/9ddc03a17dba1d7aaad73067325344f6b79441b0 DIFF: https://github.com/llvm/llvm-project/commit/9ddc03a17dba1d7aaad73067325344f6b79441b0.diff

[PATCH] D146760: [clang-format] Treat NTTP default values as expressions

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-format

[PATCH] D146595: [clang] Add clang trampoline attribute

dblaikie added a comment. >> What about function overloading & namespaces? Is the debugger expected to >> figure out which `bar` function the DWARF/user is referring to? > > The symbol name that's passed in the attribute is supposed to be the mangled > name, so there shouldn't be any ambiguity

[PATCH] D146750: [NVPTX] Set the atomic inling threshold when targeting NVPTX directly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf54d1e85285: [NVPTX] Set the atomic inling threshold when targeting NVPTX directly (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] af54d1e - [NVPTX] Set the atomic inling threshold when targeting NVPTX directly

Author: Joseph Huber Date: 2023-03-23T16:30:07-05:00 New Revision: af54d1e852850edcc7b9485851320d9ebf1be4fe URL: https://github.com/llvm/llvm-project/commit/af54d1e852850edcc7b9485851320d9ebf1be4fe DIFF: https://github.com/llvm/llvm-project/commit/af54d1e852850edcc7b9485851320d9ebf1be4fe.diff

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c9173365a93: Fix highlighting issue with _complex and initialization list with more than 2… (authored by chaitanyav). Repository: rG LLVM Github

[clang] 1c91733 - Fix highlighting issue with _complex and initialization list with more than 2 items

Author: NagaChaitanya Vellanki Date: 2023-03-23T14:18:02-07:00 New Revision: 1c9173365a932a0d289ec86704ec645a138de03e URL: https://github.com/llvm/llvm-project/commit/1c9173365a932a0d289ec86704ec645a138de03e DIFF:

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

owenpan accepted this revision. owenpan added a comment. @rymiel I'm deferring to you and @HazardyKnusperkeks, so doing nothing for now is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145642/new/ https://reviews.llvm.org/D145642

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Unfortunately I still can't reproduce this even using exactly the same cmake command as you gave. Looking at above cmake log some possible causes of difference are: - I'm doing this on an M1 macbook with host triple

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB created this revision. MatzeB added reviewers: GorNishanov, EricWF, ChuanqiXu, bruno. Herald added subscribers: modimo, wenlei, martong, mcrosier. Herald added a reviewer: shafik. Herald added a project: All. MatzeB requested review of this revision. Herald added a project: clang. Herald

[PATCH] D146565: [clang] Remove mips target triple for Android

This revision was automatically updated to reflect the committed changes. Closed by commit rG156d966ec470: Remove mips target triple for Android (authored by AdityaK 1894981+hiradi...@users.noreply.github.com). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior

[clang] 156d966 - Remove mips target triple for Android

Author: AdityaK Date: 2023-03-23T13:52:38-07:00 New Revision: 156d966ec47041a071022460d68d94717460fa5a URL: https://github.com/llvm/llvm-project/commit/156d966ec47041a071022460d68d94717460fa5a DIFF: https://github.com/llvm/llvm-project/commit/156d966ec47041a071022460d68d94717460fa5a.diff LOG:

[PATCH] D146701: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions

mariusz-sikora-at-amd updated this revision to Diff 507871. mariusz-sikora-at-amd added a comment. Put back Real Instructions under SubtargetPredicate associated with gfx generation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146701/new/

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 507870. krzysz00 added a comment. ... actually fix the typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 507869. krzysz00 added a comment. Fix typo, rebase while making next patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files:

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 507864. michaelplatings added a comment. Move change to print options into D146757 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/

[PATCH] D146310: [clang-format] Fix dropped 'else' in 398cddf6acec

jaredgrubb added a comment. Manuel, if you're happy with the change, do you mind committing it? I don't have commit access (at least I've never requested it, so I assume I can't, I've never tried) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Sometimes it's necessary to define a multilib in terms of

[PATCH] D146560: [PATCH] [PATCH] Enable targeting riscv64-linux-android

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d30afdc2d97: [PATCH] Enable targeting riscv64-linux-android (authored by ccross, committed by AdityaK 1894981+hiradi...@users.noreply.github.com).

[clang] 1d30afd - [PATCH] Enable targeting riscv64-linux-android

Author: Colin Cross Date: 2023-03-23T13:33:52-07:00 New Revision: 1d30afdc2d97d348b971ae48716a0e79c6c5a29e URL: https://github.com/llvm/llvm-project/commit/1d30afdc2d97d348b971ae48716a0e79c6c5a29e DIFF: https://github.com/llvm/llvm-project/commit/1d30afdc2d97d348b971ae48716a0e79c6c5a29e.diff

[PATCH] D146310: [clang-format] Fix dropped 'else' in 398cddf6acec

jaredgrubb added a comment. Yeh, I considered trying to craft one as courtesy but this seemed like a very far edge case and didn't seem really worth it. So glad you agree :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146310/new/

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added a comment. @tra would it be possible to go to the earlier version that simply duplicated a slight amount of logic to introduce the new and separate attribute `nvptx_kernel`? Overloading CUDA's `device` attribute is problematic because it's used and checked in several different

[PATCH] D146310: [clang-format] Fix dropped 'else' in 398cddf6acec

klimek added a comment. Thanks, yes, I did not intend to delete the else. This only triggers with fuzzing with rather involved inputs, thus I wasn't able to create a nice enough unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146310/new/

[PATCH] D146466: [clang] diagnose function fallthrough

nikic added a comment. @nickdesaulniers I don't think we want to handle that on the LLVM side. That will be fundamentally unreliable. If Clang wishes to make "recoverable" ubsan have arbitrary but well-defined behavior in the case of UB, it needs to generate appropriate IR to model that. For

[PATCH] D146701: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions

mariusz-sikora-at-amd added inline comments. Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:1915 +defm GLOBAL_ATOMIC_PK_ADD_F16 : FLAT_Global_Real_Atomics_vi <0x04e, 0>; +defm GLOBAL_ATOMIC_PK_ADD_BF16 : FLAT_Global_Real_Atomics_vi<0x52>; foad wrote: >

[PATCH] D146466: [clang] diagnose function fallthrough

nickdesaulniers added a comment. In D146466#4217487 , @efriedma wrote: > The problem with a change like that is that it's not clear what the > underlying semantic model is. If we add a flag that says "try to generate > code that matches Linux kernel

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav marked 3 inline comments as done. chaitanyav added a comment. Thank you, I will commit myself. Should i wait for the build to finish?. this will be my first direct commit to repo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

t-rasmud added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2159 Sema + bool SuggestSuggestions; Was there a reason for naming this variable SuggestSuggestions? Can this be called EmitSuggestions? I think that would make it

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I think this is okay. A followup could handle single line lambdas. But I have a personal struggle with them, especially the name `AllowShortLambdasOnASingleLine` no it is not //allow// if turned on it is //force//.

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

awarzynski accepted this revision. awarzynski added a comment. This is a very nice patch, thanks for working on this! A few final nits, but feel free to ignore. LGTM Comment at: flang/lib/Frontend/FrontendActions.cpp:103 + std::error_code ec; + llvm::ToolOutputFile

[PATCH] D146750: [NVPTX] Set the atomic inling threshold when targeting NVPTX directly

jhuber6 created this revision. jhuber6 added reviewers: tra, arsenm, tianshilei1992, JonChesterfield. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, wdng, jholewinski. Herald

[PATCH] D146466: [clang] diagnose function fallthrough

efriedma added a comment. The problem with a change like that is that it's not clear what the underlying semantic model is. If we add a flag that says "try to generate code that matches Linux kernel developers' mental model of the underlying machine", or "loop unrolling should try to preserve

[PATCH] D141472: [clang][Interp] Add function pointers

aaron.ballman added a comment. In D141472#4112790 , @tbaeder wrote: > I'm not sure what to do about this right now. I was wondering about > restructuring pointers so all the metadata is before all the actual data, but > that would be a large

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill updated this revision to Diff 507843. Endill added a comment. - Handle expressions as unevaluated operands - Numerous fixes to documentation wording - Add release notes entry - Prevent generic "unknown argument" diagnostic from being issued when other more specific diagnostics have been

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. In D146148#4217382 , @zahiraam wrote: > In D146148#4213475 , @rjmccall > wrote: > >> The user isn't modifying the `float_t` type definition, they're using it. I >> think the

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

ziqingluo-90 added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2203 +if (IsRelatedToDecl) { + assert(!SuggestSuggestions && + "Variables blamed for unsafe buffer usage without suggestions!"); nitpick: I was a bit

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1139 UnsafeBufferUsageHandler , + bool EmitSuggestions, bool EmitFixits) {

[PATCH] D145860: [clang][Interp] Fix initializing fields after base class members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a bit more testing. Comment at: clang/test/AST/Interp/cxx20.cpp:600 + + constexpr C c = {1,2,3}; +} Repository: rG LLVM Github

[PATCH] D146466: [clang] diagnose function fallthrough

nickdesaulniers added a comment. In D146466#4217363 , @efriedma wrote: > There are limits to how much we can do by just changing the code clang > generates... but the two particular cases you mention probably could be > "fixed" by messing with the IR

[PATCH] D76547: [WebAssembly] Add `wasm-exported` function attribute

sbc100 added a comment. I just figured out that this cannot replace the current use of `__attribute__((used))` in emscripten because function attributes only work for functions and we need this mechanism to work for global data addresses too. There is simply no way to do something like

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4213475 , @rjmccall wrote: > The user isn't modifying the `float_t` type definition, they're using it. I > think the diagnostic should say something like `cannot use type 'float_t' > within '#pragma clang fp

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 507829. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaType.cpp

[PATCH] D146466: [clang] diagnose function fallthrough

efriedma added a comment. There are limits to how much we can do by just changing the code clang generates... but the two particular cases you mention probably could be "fixed" by messing with the IR generated by clang. Sure, that probably makes sense to pursue. (If you're going to pick an

[PATCH] D76547: [WebAssembly] Add `wasm-exported` function attribute

sbc100 updated this revision to Diff 507826. sbc100 edited the summary of this revision. sbc100 added a comment. - limit to emscripten Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76547/new/ https://reviews.llvm.org/D76547 Files:

[PATCH] D76547: [WebAssembly] Add `wasm-exported` function attribute

sbc100 added a comment. I've limited to new attribute to only the emcripten triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76547/new/ https://reviews.llvm.org/D76547 ___ cfe-commits mailing list

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2640 if (!D || !D->isCompleteDefinition()) -return FwdDecl; +return {FwdDecl, nullptr}; aprantl wrote: > I'm curious if this works if we encounter a forward declaration,

[PATCH] D145841: [clang][Interp] Fix diagnostics for calling non-constexpr constructors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/AST/Interp/records.cpp:353 struct YetAnotherDerived : YetAnotherBase { -using YetAnotherBase::YetAnotherBase; //ref-note

[PATCH] D146466: [clang] diagnose function fallthrough

nickdesaulniers added a comment. In D146466#4214770 , @efriedma wrote: >> Note how __ubsan_handle_out_of_bounds is literally marked RECOVERABLE in >>

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507811. paulkirth added a comment. Restore check lines in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D76547: [WebAssembly] Add `wasm-exported` function attribute

sbc100 updated this revision to Diff 507807. sbc100 added a comment. - update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76547/new/ https://reviews.llvm.org/D76547 Files: clang/include/clang/Basic/Attr.td

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

efriedma added a comment. The relevant text of the current Itanium ABI (which was updated in https://github.com/itanium-cxx-abi/cxx-abi/commit/d8e9d102c83f177970f0db6cc8bee170f2779bc1) > In the following contexts, however, the one-definition rule requires closure > types in different

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507805. paulkirth added a comment. Remove unrelated changes, due to bad commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files:

[PATCH] D141811: [clang-format] Allow trailing return types in macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc70e360b355a: [clang-format] Allow trailing return types in macros (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c70e360 - [clang-format] Allow trailing return types in macros

Author: Emilia Dreamer Date: 2023-03-23T19:37:53+02:00 New Revision: c70e360b355ad30a7dd299435aae0324c5033b3f URL: https://github.com/llvm/llvm-project/commit/c70e360b355ad30a7dd299435aae0324c5033b3f DIFF:

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

sbc100 added a comment. In D76547#1945094 , @sbc100 wrote: > What about your idea of using the `default` keyword rather than adding a new > clang attr? I quite liked that approach. IIRC I tried this approach but wan't able to make it works since a

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth added a comment. ugh. I accidentally commited some temporary work here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 ___ cfe-commits mailing list

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

sbc100 updated this revision to Diff 507802. sbc100 added a comment. Herald added a reviewer: aaron.ballman. Herald added subscribers: llvm-commits, pmatos, asb, wingo, ecnelises. Herald added projects: LLVM, All. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507801. paulkirth added a comment. Address comments. - Remove `.` from warning message - use `;;` prefix in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463

[PATCH] D146408: [clang][Interp] Start supporting complex types

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1595 +return true; + } else if (const auto *CE = dyn_cast(Initializer)) { +if (!this->emitDupPtr(Initializer)) Member calls as well? Comment at:

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel added a comment. So, it took me a while but I finally found where the logic is that makes the lambda braces stay on one line, but, now I'm not so sure if I should change it: The thing I wanted to avoid was cases like [&](T&& t) requires T { t; }; Simply because "those braces

[clang-tools-extra] 40e5d21 - [clangd] Fix indentation in HoverTests.cpp

Author: Viktoriia Bakalova Date: 2023-03-23T17:27:10Z New Revision: 40e5d212cffd2b87f688dd441cd7c7f4084d407d URL: https://github.com/llvm/llvm-project/commit/40e5d212cffd2b87f688dd441cd7c7f4084d407d DIFF: https://github.com/llvm/llvm-project/commit/40e5d212cffd2b87f688dd441cd7c7f4084d407d.diff

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed an issue in :doc:`google-avoid-underscore-in-googletest-name + ` when using carlosgalvezp wrote: > Eugene.Zelenko wrote: > > Eugene.Zelenko wrote: > > >

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1172 +include_cleaner::Includes ConvertedIncludes = +convertIncludes(SM, llvm::ArrayRef{Inc}); +for (const

[clang] 5f883cd - [docs] Document -fomit-frame-pointer

Author: Fangrui Song Date: 2023-03-23T10:19:10-07:00 New Revision: 5f883cdbfbe216ec184194114676075f3633e08b URL: https://github.com/llvm/llvm-project/commit/5f883cdbfbe216ec184194114676075f3633e08b DIFF: https://github.com/llvm/llvm-project/commit/5f883cdbfbe216ec184194114676075f3633e08b.diff

  1   2   3   >