[PATCH] D147165: [Windows SEH] Fix catch+return crash for Windows -EHa

pengfei added a comment. I checked no difference in codegen between `/EHa` and `/EHsc` in MSVC. So it should be correct for clang as well. We should land it ASAP since it fixes a crash case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 509546. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files:

[PATCH] D147197: [llvm-docs] Added documentation for the 'neg' operation

oyalesalami created this revision. oyalesalami added a reviewer: samtebbs. Herald added a subscriber: jdoerfert. Herald added a project: All. oyalesalami requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fixing the github issue:

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 509544. ccotter added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 509543. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 509541. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 Files: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 509539. ccotter added a comment. - Use common function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files:

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

simideveloper added a comment. ok, no problem and thanks for those further issues @hazohelet CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. remove

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

rymiel added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ? Style.ContinuationIndentWidth + :

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b868139458d: [SYCL] Always set NoUnwind attribute for SYCL. (authored by hvdijk). Changed prior to commit:

[clang] 6b86813 - [SYCL] Always set NoUnwind attribute for SYCL.

Author: Harald van Dijk Date: 2023-03-30T02:18:52+01:00 New Revision: 6b868139458d258c1ed4c0279e8f4374556c1c1e URL: https://github.com/llvm/llvm-project/commit/6b868139458d258c1ed4c0279e8f4374556c1c1e DIFF:

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. In D143967#4232089 , @jemarch wrote: > Thinking about typedef, some C cases may be problematic if we adopt the > flexible rule we are discussing: > > typedef int bar; > const bar __tag1 var1; > bar var2; > > DWARF: >

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

mcgrathr added a comment. In D146463#4232252 , @craig.topper wrote: > In D146463#4232221 , @mcgrathr > wrote: > >> In D146463#4232214 , @craig.topper >> wrote: >> >>>

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ? Style.ContinuationIndentWidth + :

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith added a comment. This all looks good to me. Sorry for the delay. Comment at: clang/lib/Sema/SemaConcept.cpp:728 bool SkipForSpecialization = false) { MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs(

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

craig.topper added a comment. In D146463#4232221 , @mcgrathr wrote: > In D146463#4232214 , @craig.topper > wrote: > >> Does the kernel populate the initial value of the register for the shadow >> stack or is

[PATCH] D147111: [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

owenpan requested review of this revision. owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:4299 InsertNewlineAtEOF == R.InsertNewlineAtEOF && IntegerLiteralSeparator.Binary ==

[PATCH] D147111: [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

owenpan updated this revision to Diff 509511. owenpan added a comment. Adds `IntegerLiteralSeparatorStyle::operator==`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147111/new/ https://reviews.llvm.org/D147111 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

mcgrathr added a comment. In D146463#4232214 , @craig.topper wrote: > Does the kernel populate the initial value of the register for the shadow > stack or is that done by a runtime inside the application? This is a change to code generation and is

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

craig.topper added a comment. Does the kernel populate the initial value of the register for the shadow stack or is that done by a runtime inside the application? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 509508. paulkirth retitled this revision from "[CodeGen][RISCV] Change Shadow Call Stack Register to S11" to "[CodeGen][RISCV] Change Shadow Call Stack Register to X3". paulkirth edited the summary of this revision. paulkirth added a comment. update to

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added a comment. In D146358#4230122 , @simideveloper wrote: > hey, I was working on the same issue so can we collaborate on this issue? @simideveloper Thanks for your interest in collaborating on this issue, and sorry if I discouraged you

[PATCH] D145264: [OpenMP][MLIR] Lower and apply RTLModuleFlagsAttr

agozillon added a comment. All the mechanisms for this patch to now function are upstream, so I believe it is ready for a review if at all possible @kiranchandramohan @awarzynski and other reviewers that this patch may be of interest to. Although if we wish for it to be split into two separate

[PATCH] D145264: [OpenMP][MLIR] Lower and apply RTLModuleFlagsAttr

agozillon updated this revision to Diff 509487. agozillon edited the summary of this revision. agozillon added a comment. Herald added subscribers: jplehr, sunshaoce. - [Flang][MLIR][OpenMP] Fix rebase inconsistencies - [Flang][bbc][Tools] Add OpenMP RTL flags to bbc and adjust

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

dfaust added a comment. In D143967#4231911 , @jemarch wrote: >> eddyz87 added a subscriber: anakryiko. >> eddyz87 added a comment. >> >> In D143967#4231746 >> https://reviews.llvm.org/D143967#4231746, @jemarch

[PATCH] D147179: [RISCV] Bump I, F, D, and A extension versions to 20191214 spec version

craig.topper updated this revision to Diff 509481. craig.topper added a comment. Zve32x needs to imply Zicsr too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147179/new/ https://reviews.llvm.org/D147179 Files:

[PATCH] D144893: [OpenMP][WIP] `spir64` device runtime library template

spoutn1k updated this revision to Diff 509478. spoutn1k added a comment. Herald added subscribers: cfe-commits, jplehr, sunshaoce. Herald added a project: clang. Defined spirv methods as extern and defined spirv enums. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

> eddyz87 added a subscriber: anakryiko. > eddyz87 added a comment. > > In D143967#4231746 , @jemarch wrote: > >>> eddyz87 added a comment. >>> ... >>> If we consider type tag a qualifier, conceptually it would be simpler >>> if ordering would not matter

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

rymiel added a comment. > didn't go via the normal clang-format reviewers Is there a reason for this? This isn't the only case either, for example: https://reviews.llvm.org/D143070 https://reviews.llvm.org/D144170 https://reviews.llvm.org/D88299 https://reviews.llvm.org/D135356 I don't have a

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Ruturaj4 updated this revision to Diff 509473. Ruturaj4 added a comment. 1. Updating D146385 : [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef # 2. Enter a brief description of the changes included in this update. 3.

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Ruturaj4 marked an inline comment as done. Ruturaj4 added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:56 + Record.second.get()->Declaration.removeLast(); + Record.second.get() + ->Declaration dang wrote: > I think

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Ruturaj4 updated this revision to Diff 509472. Ruturaj4 added a comment. 1. Updating D146385 : [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef # 2. Enter a brief description of the changes included in this update. 3.

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

chaitanyav added a comment. @dang Please review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146866/new/ https://reviews.llvm.org/D146866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf98f3b1f4db: [clang-format] JSON Add ability to add a space before the colon (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo

[clang] af98f3b - [clang-format] JSON Add ability to add a space before the colon

Author: mydeveloperday Date: 2023-03-29T21:28:40+01:00 New Revision: af98f3b1f4db065ff82b50a9689511dd3223655b URL: https://github.com/llvm/llvm-project/commit/af98f3b1f4db065ff82b50a9689511dd3223655b DIFF:

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07616c5db0cd: [clang-format] NFC ensure Style operator== remains sorted for ease of editing (authored by MyDeveloperDay). Repository: rG LLVM

[clang] 07616c5 - [clang-format] NFC ensure Style operator== remains sorted for ease of editing

Author: mydeveloperday Date: 2023-03-29T21:25:29+01:00 New Revision: 07616c5db0cd10568b7e4bf2ef59caeb4905e3f8 URL: https://github.com/llvm/llvm-project/commit/07616c5db0cd10568b7e4bf2ef59caeb4905e3f8 DIFF:

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a subscriber: anakryiko. eddyz87 added a comment. In D143967#4231746 , @jemarch wrote: >> eddyz87 added a comment. >> ... >> If we consider type tag a qualifier, conceptually it would be simpler >> if ordering would not matter for it as

[PATCH] D147179: [RISCV] Bump I, F, D, and A extension versions to 20191214 spec version

craig.topper created this revision. craig.topper added reviewers: reames, asb, jrtc27, kito-cheng, philipp.tomsich. Herald added subscribers: jobnoorman, luke, VincentWu, ormris, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei,

[PATCH] D147135: [include-cleaner] Visit the VarDecl in ASTWalker.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7cd6ce9e917f: [include-cleaner] Visit the VarDecl in ASTWalker. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 7cd6ce9 - [include-cleaner] Visit the VarDecl in ASTWalker.

Author: Haojian Wu Date: 2023-03-29T22:20:30+02:00 New Revision: 7cd6ce9e917ff4dfe0c0afa236df6e284d98e620 URL: https://github.com/llvm/llvm-project/commit/7cd6ce9e917ff4dfe0c0afa236df6e284d98e620 DIFF: https://github.com/llvm/llvm-project/commit/7cd6ce9e917ff4dfe0c0afa236df6e284d98e620.diff

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin added a comment. In D125171#4230397 , @jrmolin wrote: > I think I have hit all the requests now. We're in the middle of building > release candidates and testing, so management is taking longer and longer to > get back to me about a style guide

Re: [PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

> eddyz87 added a comment. > > In D143967#4231517 , @dfaust wrote: > >> In D143967#4220233 , @jemarch >> wrote: >> >>> >> >> Ok, I understand your point. >> For example if we have: >> >> volatile int __tag1

[PATCH] D147144: [include-cleaner] Report references to operator calls as implicit

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:98 return false; - -// Operators are always ADL extension points, by design references to them -

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. royjacobson marked an inline comment as done. Closed by commit rG0eb06cb3aa27: [Sema] Stop stripping CV quals from *this captures in lambdas (authored by royjacobson).

[clang] 0eb06cb - [Sema] Stop stripping CV quals from *this captures in lambdas

Author: Roy Jacobson Date: 2023-03-29T23:11:51+03:00 New Revision: 0eb06cb3aa2700508c20da28f22ff91e7b82a436 URL: https://github.com/llvm/llvm-project/commit/0eb06cb3aa2700508c20da28f22ff91e7b82a436 DIFF: https://github.com/llvm/llvm-project/commit/0eb06cb3aa2700508c20da28f22ff91e7b82a436.diff

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. In D143967#4231517 , @dfaust wrote: > In D143967#4220233 , @jemarch wrote: > >> > > Ok, I understand your point. > For example if we have: > > volatile int __tag1 b; > > The tag

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4155 if (Right.is(tok::colon)) - return false; + return Style.SpaceBeforeJsonColon; } else if (Style.isCSharp()) { owenpan wrote: > MyDeveloperDay wrote: > >

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

MyDeveloperDay updated this revision to Diff 509439. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. add missing unit test let's go defensive on the JsColon detection CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147003/new/

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, owenpan. MyDeveloperDay added projects: clang-format, clang. Herald added a project: All. MyDeveloperDay requested review of this revision. D144170: [clang-format] Add simple macro replacements in

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson marked an inline comment as done. royjacobson added a comment. In D146168#4231457 , @aaron.ballman wrote: > LGTM aside from a minor nit, though I have some minor concerns that we may > silently break people's code by calling different

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson updated this revision to Diff 509436. royjacobson added a comment. fix unintended indentation & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146168/new/ https://reviews.llvm.org/D146168 Files: clang/docs/ReleaseNotes.rst

[clang] 389e93c - Mark test added in D141824 as unsupported for PS4/PS5 as those platforms require an external linker that is not present.

Author: Douglas Yung Date: 2023-03-29T12:09:28-07:00 New Revision: 389e93cfcdd7410566dc913e46e4a47e37574c05 URL: https://github.com/llvm/llvm-project/commit/389e93cfcdd7410566dc913e46e4a47e37574c05 DIFF: https://github.com/llvm/llvm-project/commit/389e93cfcdd7410566dc913e46e4a47e37574c05.diff

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

dyung added a comment. In D141824#4231374 , @probinson wrote: > In D141824#4231372 , @probinson > wrote: > >> In D141824#4229953 , @argentite >> wrote: >> >>> Just to

[clang] 0ca6dd9 - [clang-format] NFC ensure clang-format is itself clang-formatted

Author: mydeveloperday Date: 2023-03-29T20:01:03+01:00 New Revision: 0ca6dd96d66db43fa7edd6f8b261808801750554 URL: https://github.com/llvm/llvm-project/commit/0ca6dd96d66db43fa7edd6f8b261808801750554 DIFF:

[PATCH] D147141: [clang][documentation][enhancement]Documented Optimization Flags

aaron.ballman added a comment. We already have documentation for these: https://clang.llvm.org/docs/CommandGuide/clang.html#code-generation-options I think there's sufficient confusion in this space that we should fix *something*. We have at least three places where we list a lot of command

[PATCH] D76547: [WebAssembly] Add `wasm-exported` function attribute

sbc100 abandoned this revision. sbc100 added a comment. In D76547#4231604 , @aaron.ballman wrote: > In D76547#4231501 , @sbc100 wrote: > >> In D76547#4231476 ,

[PATCH] D76547: [WebAssembly] Add `wasm-exported` function attribute

aaron.ballman added a comment. In D76547#4231501 , @sbc100 wrote: > In D76547#4231476 , @aaron.ballman > wrote: > >> In D76547#4231422 , @sbc100 wrote: >> >>> The reason

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik created this revision. philnik added a reviewer: aaron.ballman. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a new trait to allow standard libraries to forward `std::equal`

[clang] 3be6c4d - Revert "Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656""

Author: Mitch Phillips Date: 2023-03-29T11:39:44-07:00 New Revision: 3be6c4d413f6ccabdcc8205ce73970bf3df162d3 URL: https://github.com/llvm/llvm-project/commit/3be6c4d413f6ccabdcc8205ce73970bf3df162d3 DIFF:

[clang] 96f028c - Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang"

Author: Mitch Phillips Date: 2023-03-29T11:39:32-07:00 New Revision: 96f028c0a2826c1fe13d126124692ba5470d227a URL: https://github.com/llvm/llvm-project/commit/96f028c0a2826c1fe13d126124692ba5470d227a DIFF:

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 ___ cfe-commits mailing list

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147097/new/ https://reviews.llvm.org/D147097

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

chaitanyav updated this revision to Diff 509429. chaitanyav added a comment. Add comment to indicate that id* is not an qualified id type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146866/new/ https://reviews.llvm.org/D146866 Files:

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

dfaust added a comment. In D143967#4220233 , @jemarch wrote: >> eddyz87 added a comment. >> >> In D143967#4200331 >> https://reviews.llvm.org/D143967#4200331, @dfaust wrote: >> >>> In D143967#4197288

[PATCH] D76547: [WebAssembly] Add `wasm-exported` function attribute

sbc100 added a comment. In D76547#4231476 , @aaron.ballman wrote: > In D76547#4231422 , @sbc100 wrote: > >> The reason `__attribute__((export_name("foo")))` doesn't work in all use >> cases is that we have a lot

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

This revision was automatically updated to reflect the committed changes. Closed by commit rG477f9cea77e6: [MSCV][dllexport/dllimport][PS] Allow UniqueExternal linkage classes with… (authored by wolfgangp). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 477f9ce - [MSCV][dllexport/dllimport][PS] Allow UniqueExternal linkage classes with dllexport/dllimport

Author: Wolfgang Pieb Date: 2023-03-29T18:15:04Z New Revision: 477f9cea77e6d55ecddaafbedccd418750c40dbd URL: https://github.com/llvm/llvm-project/commit/477f9cea77e6d55ecddaafbedccd418750c40dbd DIFF: https://github.com/llvm/llvm-project/commit/477f9cea77e6d55ecddaafbedccd418750c40dbd.diff

[PATCH] D76547: [WebAssembly] Add `wasm-exported` function attribute

aaron.ballman added a comment. In D76547#4231422 , @sbc100 wrote: > The reason `__attribute__((export_name("foo")))` doesn't work in all use > cases is that we have a lot of existing code that uses the > `EMSCRIPTEN_KEEPALIVE` macro. We also have

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

tahonermann accepted this revision. tahonermann added a comment. Thank you, Mariya! Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 ___

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a minor nit, though I have some minor concerns that we may silently break people's code by calling different overloads or instantiating templates differently so I wonder if this is a potentially breaking change

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon added a comment. Ping @shafik ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2182-2183 -clang::DumpModuleInfoAction dump_module_info; -dump_module_info.OutputStream = ().AsRawOstream(); +std::shared_ptr Out( +().AsRawOstream(),

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon updated this revision to Diff 509420. Fznamznon added a comment. Add comment explaining custom deleter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 Files:

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:980-981 +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputType = types::lookupTypeForExtension( +llvm::sys::path::extension(BaseInput).drop_front()); +if

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509417. AMS21 added a comment. Use llvm::DenseMap instead of std::map Add some more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files:

[PATCH] D76547: [WebAssembly] Add `wasm-exported` function attribute

sbc100 added a comment. The reason `__attribute__((export_name("foo")))` doesn't work in all use cases is that we have a lot of existing code that uses the `EMSCRIPTEN_KEEPALIVE` macro. We also have run into other folks who want to include this is some kind of `FOO_API`, or `EXPORT_API`

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added a comment. No problem at all, I broke it, happy to fix it! Submitting the fix in the next 30 minutes~ after a rebase as the build bots seem to have passed happily, it took a lot longer than I expected for the build-bot to roundtable to my patch, my apologies, teaches me to use

[PATCH] D76547: [WebAssembly] Add `wasm-exported` function attribute

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. The changes need a release note at some point, and this is missing all of the usual sema diagnostic tests (wrong subject, wrong number of args, wrong target, etc). That said, are we sure this attribute is sufficiently

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL updated this revision to Diff 509412. PiotrZSL added a comment. Remove added -- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146875/new/ https://reviews.llvm.org/D146875 Files: clang-tools-extra/clang-tidy/add_new_check.py Index:

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL updated this revision to Diff 509411. PiotrZSL added a comment. Remove change added by mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146875/new/ https://reviews.llvm.org/D146875 Files:

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL updated this revision to Diff 509410. PiotrZSL added a comment. Move fix from note to warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146875/new/ https://reviews.llvm.org/D146875 Files:

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

probinson added a comment. In D141824#4231372 , @probinson wrote: > In D141824#4229953 , @argentite > wrote: > >> Just to confirm, `UNSUPPORTED: target=x86_64-scei-ps4` should be enough, >> right? > >

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

probinson added a comment. In D141824#4229953 , @argentite wrote: > Just to confirm, `UNSUPPORTED: target=x86_64-scei-ps4` should be enough, > right? `UNSUPPORTED: target={{.*-(ps4|ps5)}}` please. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 marked 2 inline comments as done. AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:21 + +enum CanMoveConstrcutorThrowResult { + CMCT_CanThrow,///< We are sure the move constructor can throw

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionSpecAnalyzer.h:79 + + std::map FunctionCache; +}; std::unordered_map, or try to check if llvm doesn't have something better with some pre-allocation. Repository: rG

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509409. AMS21 marked 8 inline comments as done. AMS21 added a comment. Sprinkle some more `const` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files:

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/noexcept-move-constructor.cpp:278 + OK22 =(OK22 &&) = default; +}; add test with 2 base classes (no templates). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL added a comment. In D146922#4231317 , @AMS21 wrote: > In D146922#4227832 , @PiotrZSL > wrote: > >> Try refactoring code a lite bit, check suggestions, add tests for typedefs, >> and inheritance from

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionSpecAnalyzer.cpp:83 + DefaultableMemberKind Kind) { + auto *RecType = Base.getType()->getAs(); + if (!RecType) Should be `const auto

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

erichkeane accepted this revision. erichkeane added a comment. Yeah, LGTM too. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146719/new/ https://reviews.llvm.org/D146719 ___ cfe-commits mailing

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please give @erichkeane a chance to give it a second set of eyes given he's been knee-deep in concepts recently. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added a comment. Looking around I've found the `ExceptionAnalyzer` class inside utils. In D146922#4227832 , @PiotrZSL wrote: > Try refactoring code a lite bit, check suggestions, add tests for typedefs, > and inheritance from template type. I'm

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509405. AMS21 marked an inline comment as done. AMS21 added a comment. Herald added a subscriber: ChuanqiXu. Move functionality to a seperate file Also the noexcept move constrcutor check now only runs with exceptions enabled like other checks. Repository:

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

njames93 added a comment. In D146875#4229544 , @carlosgalvezp wrote: > I think easiest is to go for Option A) - this is how we normally write checks > nowadays. Maybe the discussion about removing support for `--fix-notes` can > be done in an RFC?

[clang] 1f48a1f - Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain

Author: Walter Gray Date: 2023-03-29T09:44:01-07:00 New Revision: 1f48a1fce23551cc24f5b598af5994f5cfc6b6d0 URL: https://github.com/llvm/llvm-project/commit/1f48a1fce23551cc24f5b598af5994f5cfc6b6d0 DIFF: https://github.com/llvm/llvm-project/commit/1f48a1fce23551cc24f5b598af5994f5cfc6b6d0.diff

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f48a1fce235: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain (authored by yeswalrus, committed by erichkeane). Changed

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir added a comment. Thank you, @aaron.ballman and @tahonermann for your comments! This was committed to https://github.com/llvm/llvm-project.git with hash 6f2a865d2f6bc426a61939a0a1acfcb25d5c1a18 CHANGES SINCE LAST

[clang] bbc204b - [PS4][clang] Limit ThinLTO parallelism when requested

Author: Matthew Voss Date: 2023-03-29T09:36:46-07:00 New Revision: bbc204b944eea829a029268fff37faabdf61fcaf URL: https://github.com/llvm/llvm-project/commit/bbc204b944eea829a029268fff37faabdf61fcaf DIFF: https://github.com/llvm/llvm-project/commit/bbc204b944eea829a029268fff37faabdf61fcaf.diff

  1   2   >