[libunwind] ff0aabf - [libunwind][LoongArch] Restore $r1 before $r4 in `jumpto`

Author: Weining Lu Date: 2023-04-07T13:42:23+08:00 New Revision: ff0aabf14dfa0a369c38f6e267c56a83ee48d647 URL: https://github.com/llvm/llvm-project/commit/ff0aabf14dfa0a369c38f6e267c56a83ee48d647 DIFF: https://github.com/llvm/llvm-project/commit/ff0aabf14dfa0a369c38f6e267c56a83ee48d647.diff

[libunwind] 366c547 - [libunwind][test] Add test to check for unw_resume()

Author: zhanglimin Date: 2023-04-07T13:42:23+08:00 New Revision: 366c5474a3002114b8980ab278d93baa96046385 URL: https://github.com/llvm/llvm-project/commit/366c5474a3002114b8980ab278d93baa96046385 DIFF: https://github.com/llvm/llvm-project/commit/366c5474a3002114b8980ab278d93baa96046385.diff

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

chapuni accepted this revision. chapuni added a comment. This revision is now accepted and ready to land. It's obvious. I think it was bad just to swallow stderr there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

smeenai added reviewers: Michael137, dblaikie, aprantl. smeenai added a comment. Thanks! I'm not super familiar with this, so I'm adding the original author and reviewers to confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

yozhu created this revision. Herald added a project: All. yozhu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add missing "REQUIRES: asserts" for the two tests added in commit 711a64412749ae73709562b591ab1609a3ee7751

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

shafik added a comment. PR for fix: https://reviews.llvm.org/D147762 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135370/new/ https://reviews.llvm.org/D135370 ___ cfe-commits mailing list

[PATCH] D147762: [Clang] Fix filtering of inline namespaces for friend functions

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, troyj, rsmith, bruno. Herald added a project: All. shafik requested review of this revision. PR D135370 implemented a performance improvement but it restricted the filtering of

[PATCH] D147757: Fix static analyzer tool remarks about unchecked return values

Manna abandoned this revision. Manna added a comment. Closing this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147757/new/ https://reviews.llvm.org/D147757 ___ cfe-commits mailing list

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

rsmith added inline comments. Comment at: clang/test/SemaCXX/cxx2b-designated-initializers.cpp:13 + const S result { // expected-error {{field designator (null) does not refer to any field in type 'const S'}} +.a = x + }; Why are we rejecting this?

[PATCH] D147757: Fix static analyzer tool remarks about unchecked return values

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, luismarques, s.egerton, dkrupp, donat.nagy, Szelethus, PkmX, a.sidorin, simoncook, baloghadamsoftware, kristof.beyls, arichardson. Herald added a reviewer: NoQ. Herald

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ChuanqiXu added a comment. In D147722#4250133 , @alexander-shaposhnikov wrote: > fwiw - I can revert https://reviews.llvm.org/D146178 for now till we fix the > newly discovered cases (at the moment I'm aware of GH61959 and the one > reported by

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:315 + /// `D` must currently be associated with a value. + void unsetChild(const ValueDecl ) { +auto It = Children.find(); Modifying already-created values is

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ayermolo added a comment. That would be great. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147722/new/ https://reviews.llvm.org/D147722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Thank you for taking care of this, LGTM Comment at: clang/lib/Sema/SemaInit.cpp:2646 + if (Loc.isInvalid()) +// This could happen with a "null"

[clang] bf9de4c - Reject attempts to initialize non-aggregate types from a designated

Author: Richard Smith Date: 2023-04-06T18:01:01-07:00 New Revision: bf9de4cf131032502c8967a65283a461fe36520d URL: https://github.com/llvm/llvm-project/commit/bf9de4cf131032502c8967a65283a461fe36520d DIFF: https://github.com/llvm/llvm-project/commit/bf9de4cf131032502c8967a65283a461fe36520d.diff

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511575. paulkirth marked an inline comment as done. paulkirth added a comment. Add default small-data-limit for Android and Fuchsia. - update tests - update clang driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

shafik added a comment. I guess I should have waited till I saw: https://reviews.llvm.org/D147673 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147580/new/ https://reviews.llvm.org/D147580 ___

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG711a64412749: [clang][DebugInfo] Emit DW_AT_type of preferred name if available (authored by Michael137). Repository:

[clang] 711a644 - [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Author: Michael Buch Date: 2023-04-07T01:37:36+01:00 New Revision: 711a64412749ae73709562b591ab1609a3ee7751 URL: https://github.com/llvm/llvm-project/commit/711a64412749ae73709562b591ab1609a3ee7751 DIFF: https://github.com/llvm/llvm-project/commit/711a64412749ae73709562b591ab1609a3ee7751.diff

[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

shafik added a comment. I guess this is prep work for tackling unifying them later on as you attempted in https://reviews.llvm.org/D140584 I knew this is not exactly the same change but can you add the test case identified in https://github.com/llvm/llvm-project/issues/61118 and

[PATCH] D147744: [clang][Sema] Add MultiLevelTemplateArgumentList::dump()

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm happy with this, I think it is useful here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147744/new/

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

alexander-shaposhnikov added a subscriber: ilya-biryukov. alexander-shaposhnikov added a comment. fwiw - I can revert https://reviews.llvm.org/D146178 for now till we fix the newly discovered cases (at the moment I'm aware of GH61959 and the one reported by @ilya-biryukov. Basically let me

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ayermolo added a comment. With this patch here is still a build failure in our code base. I am trying to create a small repro. But from high level there is a templated class that has partial specializations, and it errors out on definition of a function that doesn't have any. CHANGES SINCE

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added a comment. In D147655#4248800 , @royjacobson wrote: > I agree it doesn't affect too much code, but people do instantiate templates > manually sometimes. IIUC, linking against shared libraries would break if > that library does explicit

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

zhuhan0 added a comment. In D141824#4250011 , @sgraenitz wrote: > In D141824#4247891 , @zhuhan0 wrote: > >> This seems to be the first clang test that involves actual linking. > > Interesting, I think we all

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

MyDeveloperDay added a comment. Can you mark your comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 ___ cfe-commits mailing list

[PATCH] D147744: [clang][Sema] Add MultiLevelTemplateArgumentList::dump()

alexander-shaposhnikov added a comment. for template struct X { template struct Y { int f() requires(I2 == 1) { return 1; } int f() requires(I2 == 2) { return 1; } }; }; this would print the following:

[clang] bc95f27 - Revert "Revert "[Modules] Remove unnecessary check when generating name lookup table in ASTWriter""

Author: Richard Smith Date: 2023-04-06T15:42:00-07:00 New Revision: bc95f27337c7ed77c28e713c855272848f01802a URL: https://github.com/llvm/llvm-project/commit/bc95f27337c7ed77c28e713c855272848f01802a DIFF: https://github.com/llvm/llvm-project/commit/bc95f27337c7ed77c28e713c855272848f01802a.diff

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

sgraenitz added a comment. In D141824#4247891 , @zhuhan0 wrote: > This seems to be the first clang test that involves actual linking. Interesting, I think we all didn't have this on our radars. > If the intention is to test loading a dynamic library,

[PATCH] D147744: [clang][Sema] Add MultiLevelTemplateArgumentList::dump()

alexander-shaposhnikov updated this revision to Diff 511551. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147744/new/ https://reviews.llvm.org/D147744 Files:

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna updated this revision to Diff 511547. Manna added a comment. Fix clang-format error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D147744: [clang][Sema] Add MultiLevelTemplateArgumentList::dump()

rsmith added inline comments. Comment at: clang/include/clang/Sema/Template.h:265 + +LLVM_DUMP_METHOD void dump() const { + LangOptions LO; I think it would be useful to also print out the number of retained outer levels. Repository: rG LLVM Github

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cjdb added a comment. In D147717#4248989 , @erichkeane wrote: > @cjdb has been running some GDB test suites against our compiler: I am > wondering if we could ask him to try the consteval ones too before we set > this? A lot of that work is manual

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

benhamilton updated this revision to Diff 511539. benhamilton added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147577/new/ https://reviews.llvm.org/D147577 Files: clang/lib/Format/Format.cpp

[PATCH] D147744: [clang][Sema] Add MultiLevelTemplateArgumentList::dump()

erichkeane added a comment. Also, this prints backwards: it'll print 'inner to outer', but I suspect most people will expect 'outer to inner'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147744/new/ https://reviews.llvm.org/D147744

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 511537. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt

[PATCH] D147744: [clang][Sema] Add MultiLevelTemplateArgumentList::dump()

erichkeane added a comment. I like the idea of this, this is really useful. Can you show what the output looks like? It might be valuable to print the 'depth' before each list as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147744/new/

[PATCH] D147744: [clang][Sema] Add MultiLevelTemplateArgumentList::dump()

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: erichkeane, rsmith. alexander-shaposhnikov created this object with visibility "All Users". Herald added a project: All. alexander-shaposhnikov requested review of this revision. Herald added a project: clang.

[PATCH] D147495: [Clang][Attributes] Add MeaningfulToClassTemplateDefinition to unavailable attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb206cde3504c: [Clang][Attributes] Add MeaningfulToClassTemplateDefinition to unavailable… (authored by shafik). Herald added a project: clang.

[clang] b206cde - [Clang][Attributes] Add MeaningfulToClassTemplateDefinition to unavailable attribute

Author: Shafik Yaghmour Date: 2023-04-06T14:40:39-07:00 New Revision: b206cde3504c0078469f02bd74aeb5eb5ab875f5 URL: https://github.com/llvm/llvm-project/commit/b206cde3504c0078469f02bd74aeb5eb5ab875f5 DIFF:

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void created this revision. void added reviewers: rsmith, rjmccall, aaron.ballman, dblaikie. Herald added a subscriber: arphaman. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "getField" method is a

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 added a comment. Possibly verifier ignores it? Because I dont see any verifier error compiling this testcase: void NoParams(); void TestParamArityMismatchNonPortable(int x) { [[clang::nonportable_musttail]] return NoParams(); } But yeah, this is something we need to

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

void updated this revision to Diff 511529. void added a comment. Remove extraneous space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147673/new/ https://reviews.llvm.org/D147673 Files: clang/lib/Sema/SemaInit.cpp

[PATCH] D147495: [Clang][Attributes] Add MeaningfulToClassTemplateDefinition to unavailable attribute

shafik updated this revision to Diff 511526. shafik added a comment. - Add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147495/new/ https://reviews.llvm.org/D147495 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Attr.td

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

shafik added a comment. A quick test indicated the `!FunctionTemplate` is the culprit for the noted regression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135370/new/ https://reviews.llvm.org/D135370

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

haberman added a comment. Correct me if I am wrong, but won't this produce LLVM IR that fails to validate? The checks that exist today for `[[clang::musttail]]` are necessary to follow LLVM's rules about where `musttail` may appear: https://llvm.org/docs/LangRef.html#id328 > Calls marked

[PATCH] D147564: [clang] Mark CWG536 as N/A

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! This doesn't seem plausible to write a test for (it's basically a clarification rather than a change, as best I can tell). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 511522. Herald added subscribers: jplehr, sstefan1, aheejin. Herald added a reviewer: jdoerfert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D147742: [python] Enable bindings tests on Windows

R2RT created this revision. R2RT added a project: clang. Herald added a project: All. R2RT requested review of this revision. Herald added a subscriber: cfe-commits. Unlike stated by removed comment, they do simply pass in my local enviroment. In order to find necessary fixes (if any), CI has to

[PATCH] D147661: [Sema] Tweak merging of availability attributes

aaron.ballman added a comment. In D147661#4249696 , @aaron.ballman wrote: > I don't think there's a way to test this change, unfortunately. However, I > think this exposed a bigger concern, which is that `AttributeCommonInfo` has > some

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

shafik added a comment. It looks like this causes a regression, we can see in this bug report: https://github.com/llvm/llvm-project/issues/61851 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135370/new/ https://reviews.llvm.org/D135370

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

augusto2112 updated this revision to Diff 511515. augusto2112 added a comment. Updated MetadataTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

augusto2112 added a comment. @aaron.ballman thanks all the code reviews. In D146595#4240608 , @aaron.ballman wrote: > Additionally, should you be allowed to write this on a lambda to skip over > the function call operator? (If so, you may need to move

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

rjmccall added a comment. Totally fair :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

augusto2112 updated this revision to Diff 511513. augusto2112 added a comment. Added release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147661: [Sema] Tweak merging of availability attributes

aaron.ballman added a comment. I don't think there's a way to test this change, unfortunately. However, I think this exposed a bigger concern, which is that `AttributeCommonInfo` has some single-argument constructors that are not `explicit` so that we don't run into this issue again. However,

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

rsmith added a comment. In D147722#4249612 , @erichkeane wrote: > Hmmm... the examples I thought would cause a problem don't seem to when > switching that to Done. So I'm going to run regression tests and give that a > shot. > > I think I now get

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 updated this revision to Diff 511512. augusto2112 added a comment. Updated git commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/include/clang/Basic/Attr.td

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 updated this revision to Diff 511511. augusto2112 marked 4 inline comments as done. augusto2112 added a comment. Updated to debug_trampoline, and addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane added a comment. The switching that to 'done' seems to have broken cases where the partial specialization itself has requires clauses on it, see

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

rsmith added a comment. In D146897#4249300 , @rjmccall wrote: > The third idea seems like a valuable warning, but it's basically a > *different* warning and shouldn't be lumped into this one. I understand the > instinct to carve it out here so that we

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:291 /// encountering a lambda generic call operator, and continue looking for /// arguments on an enclosing class template. /* not directly related to this

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane added a comment. Hmmm... the examples I thought would cause a problem don't seem to when switching that to Done. So I'm going to run regression tests and give that a shot. I think I now get what you mean about 'Identity' arguments, we basically need to have arguments to keep

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:322 + // they mean. + R = Response::UseNextDecl(PartialClassTemplSpec); } else if (const auto *ClassTemplSpec = erichkeane wrote: > rsmith wrote: > > Can we

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

rampitec added a comment. In D147732#4249584 , @jrbyrnes wrote: > In D147732#4249567 , @rampitec > wrote: > >> Isn't it simpler to lower it to an existing int intrinsic and casts in clang? > > Thanks for your

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2854-2858 -template <> -bool DeducedArgsNeedReplacement( -ClassTemplatePartialSpecializationDecl *Spec) { - return !Spec->isClassScopeExplicitSpecialization(); -} rsmith

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, pengfei. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. In strict mode the 'roundin_mode' is set to 'dynamic'. Using this pragma to get out of strict mode doesn't

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

jrbyrnes added a comment. In D147732#4249567 , @rampitec wrote: > Isn't it simpler to lower it to an existing int intrinsic and casts in clang? Thanks for your comment Stas! I think it would be ideal if clang inserted pure bitcasts for floats instead

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:101 +- :doc:`bugprone-fold-init-type + ` now handles iterators that do not Wrong section, this should be in 'Changes in existing checks' Repository: rG LLVM Github

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2854-2858 -template <> -bool DeducedArgsNeedReplacement( -ClassTemplatePartialSpecializationDecl *Spec) { - return !Spec->isClassScopeExplicitSpecialization(); -} It's not

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

rampitec added a comment. Isn't it simpler to lower it to an existing int intrinsic and casts in clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147732/new/ https://reviews.llvm.org/D147732 ___

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

jrbyrnes created this revision. jrbyrnes added reviewers: rampitec, arsenm. Herald added subscribers: kosarev, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. jrbyrnes requested review of this revision. Herald added subscribers: llvm-commits,

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 added a comment. In D147714#4249357 , @efriedma wrote: > An error message pointing at the call in the source code would be good > enough, I think. Adding a "reason" might be nice, but not strictly necessary. Good idea. So now for: short

[PATCH] D147731: [3/N][POC][Clang] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD created this revision. eopXD added reviewers: craig.topper, rogfer01, frasercrmck, reames, kito-cheng, nikic. Herald added subscribers: luke, StephenFan, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27,

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 updated this revision to Diff 511498. xbolva00 added a comment. Herald added subscribers: llvm-commits, pengfei, hiraditya. Herald added a project: LLVM. Added location when emiting diagnostic about failed TCO in the backend. CHANGES SINCE LAST ACTION

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 511496. zequanwu added a comment. - Add a `-use-target-path-separator` flag for llc. - Add test for llc with that flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 marked 4 inline comments as done. jp4a50 added a comment. Just FYI this is ready for review again. I believe I've addressed all comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. These all LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 ___ cfe-commits

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna updated this revision to Diff 511486. Manna added a comment. I have addressed @erichkeane's review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 Files: clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D147554: [clang] Mark CWG562 as N/A

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147554/new/ https://reviews.llvm.org/D147554 ___ cfe-commits mailing list

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

efriedma added a comment. An error message pointing at the call in the source code would be good enough, I think. Adding a "reason" might be nice, but not strictly necessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147714/new/ https://reviews.llvm.org/D147714

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna added a comment. I have uploaded wrong one. I will fix it with new patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

dblaikie added a comment. > we should probably warn about all inconsistent references to the same > variable within a single statement. +1 here, that that seems like the suitable generalization/unrelated to the use in/restriction to assignments Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna updated this revision to Diff 511478. Manna added a comment. Thanks @erichkeane for reviews. I have updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 Files: clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

myhsu updated this revision to Diff 511477. myhsu marked 2 inline comments as done. myhsu added a comment. - Explicit add `isa-68882` even for newer (>=68040) CPUs. Such that's it's a lot easier to conditionally add related macro definitions with TargetOptions::FeatureMap - Add cases to test

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 added a comment. In D147714#4249274 , @efriedma wrote: > Any thoughts on diagnostics here? If I'm not mistaken, with this patch, if > you request an impossible tail call, you get a crash with very little useful > information. (Although, see

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

rjmccall added a comment. Yeah, I feel there are three ideas here: - Clang should warn about self simple assignment in all cases, because it's probably a mistake. We can assume it's a mistake because it's reasonable to assume that the simple assignment operator behaves like a value

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

efriedma added a subscriber: nickdesaulniers. efriedma added a comment. Any thoughts on diagnostics here? If I'm not mistaken, with this patch, if you request an impossible tail call, you get a crash with very little useful information. (Although, see

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511466. paulkirth marked 2 inline comments as done. paulkirth added a comment. Remove extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files:

[PATCH] D147661: [Sema] Tweak merging of availability attributes

erichkeane added a comment. In D147661#4249244 , @rsandifo-arm wrote: > In D147661#4249004 , @erichkeane > wrote: > >> This test doesn't show a change in behavior. > > Yeah. Is there a way to force the syntax

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf27b77e5c59a: [Sema] Populate declarations inside TypeLocs for some invalid types (authored by ilya-biryukov). Repository: rG LLVM Github

[clang] f27b77e - [Sema] Populate declarations inside TypeLocs for some invalid types

Author: Ilya Biryukov Date: 2023-04-06T19:02:41+02:00 New Revision: f27b77e5c59a1a907fa45eeb5f2e279a5c8bd17d URL: https://github.com/llvm/llvm-project/commit/f27b77e5c59a1a907fa45eeb5f2e279a5c8bd17d DIFF: https://github.com/llvm/llvm-project/commit/f27b77e5c59a1a907fa45eeb5f2e279a5c8bd17d.diff

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

ilya-biryukov added a comment. Sorry for taking so long to land this, it fell off my radar. In D146971#4227482 , @aaron.ballman wrote: > LGTM, though the change should come with a release note. Suggestion you can > take or leave as you see fit: should

[PATCH] D147661: [Sema] Tweak merging of availability attributes

rsandifo-arm added a comment. In D147661#4249004 , @erichkeane wrote: > This test doesn't show a change in behavior. Yeah. Is there a way to force the syntax and spelling fields to be dumped, even for implicit attributes? I was struggling to find

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

ilya-biryukov updated this revision to Diff 511463. ilya-biryukov added a comment. - Another forgotten non-null assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146971/new/ https://reviews.llvm.org/D146971 Files:

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

ilya-biryukov updated this revision to Diff 511462. ilya-biryukov added a comment. - Add assertions for removed null checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146971/new/ https://reviews.llvm.org/D146971 Files:

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. FYI, this bugfix was attempted back in 2021 here: https://reviews.llvm.org/D101237 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. In D147175#4246513 , @aaron.ballman wrote: > Ah, I like this approach -- it keeps things roughly in sync with checking for > unique object representations, which is great. I spotted a few questions, but > in general this is

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 511460. philnik marked 4 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files:

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511458. paulkirth added a comment. Fix formatting and update documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/docs/ShadowCallStack.rst

  1   2   >