[PATCH] D148981: [clang][Interp] PointerToBoolean casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Just emit `p != nullptr` for this. Repository:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

mehdi_amini added inline comments. Herald added a subscriber: bviyer. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond,

[PATCH] D147844: [clang][Sema]Print diagnostic warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav updated this revision to Diff 515978. chaitanyav added a comment. Revise commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav updated this revision to Diff 515974. chaitanyav marked an inline comment as done. chaitanyav added a comment. Modify the commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

joerg added a comment. For me long matching prefix makes more sense, but if the same prefix is used multiple times, the last option should win. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148975/new/ https://reviews.llvm.org/D148975

[PATCH] D148757: [clang] Follow user-provided order for prefix map

MaskRay added a comment. In D148757#4289076 , @MaskRay wrote: > I'm creating a patch to change DebugPrefixMap to respect the command line > option order... Created D148975 to follow GCC's behavior (the last

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

MaskRay created this revision. MaskRay added reviewers: debug-info, dankm, gulfem, phosek. Herald added subscribers: hiraditya, emaste. Herald added a project: All. MaskRay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D148757: [clang] Follow user-provided order for prefix map

MaskRay added a comment. I'm creating a patch to change DebugPrefixMap to respect the command line option order... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757

[PATCH] D148757: [clang] Follow user-provided order for prefix map

phosek added a comment. I wasn't aware that `debug-prefix-map` prefers longest prefix. I agree that ideally `coverage-prefix-map`, `debug-prefix-map` and `macro-prefix-map` should be consistent across all LLVM tools and ideally also across compilers. Repository: rG LLVM Github Monorepo

[PATCH] D148757: [clang] Follow user-provided order for prefix map

MaskRay added a comment. Created https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109591 to discuss GCC's behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

dblaikie added a comment. > Additionally, lambdas are always going to have internal linkage so they will > not differ accross TUs. This isn't true - if a lambda appears in a header in any way, it probably has linkage the same as an inline function, not internal. (eg: a lambda inside an inline

[PATCH] D148757: [clang] Follow user-provided order for prefix map

MaskRay added a comment. In D148757#4285735 , @gulfem wrote: > I compared Clang and GCC behavior. > **1) Following user-specified prefix mapping order** > GCC uses a linked list to store the prefix mappings, so it applies the prefix > mappings based on

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

MaskRay added a comment. In D148958#4288782 , @vzakhari wrote: > In D148958#4288728 , @MaskRay wrote: > >> This is an unnecessary change. The arguments are interchangeable. >> In musl, there are at least 2 places

[PATCH] D148967: WIP: Disable atexit()-based lowering when LTO'ing kernel/kext code

yln created this revision. Herald added subscribers: llvm-commits, cfe-commits, ormris, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM, All. yln requested review of this revision. Herald added a subscriber: MaskRay. rdar://93536111 Repository: rG LLVM Github Monorepo

[PATCH] D148961: [clang] Remove unnecessary virtual inheritance in `TargetInfo`

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148961/new/ https://reviews.llvm.org/D148961

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth abandoned this revision. paulkirth added a comment. This can be abandoned in favor of https://reviews.llvm.org/D146776, https://reviews.llvm.org/D146777, and https://reviews.llvm.org/D146778 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

zhuhan0 added a comment. Hi, I have just got the time to come back to https://reviews.llvm.org/D147823, but I wanna check here first if you guys have any fix in flight? In addition to the linking issue, we also encountered the "cstdio" not found issue as mentioned above. Repository: rG

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

vzakhari added a comment. In D148958#4288728 , @MaskRay wrote: > This is an unnecessary change. The arguments are interchangeable. > In musl, there are at least 2 places where the parameters could be swapped, > but I not unsure this warrants a commit.

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt planned changes to this revision. RIscRIpt marked 2 inline comments as done. RIscRIpt added a comment. > Does it prohibit the inverse? I think this documentation overall needs a > much better description of what the semantics are here, particularly anything > that you found in

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. This is an unnecessary change. In musl, there are at least 2 places where the parameters could be swapped, but I not unsure this warrants a commit. Repository: rG LLVM Github

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. This revision is now accepted and ready to land. Thanks for the fix Zarko! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148960/new/ https://reviews.llvm.org/D148960

[PATCH] D148962: [RISCV] Make Zicntr and Zihpm imply Zicsr.

craig.topper created this revision. craig.topper added reviewers: asb, reames, kito-cheng, jrtc27. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

Stoorx added a comment. Can you commit it? I have no commit access. Stoorx me[at]stoorx.one CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/ https://reviews.llvm.org/D148954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148961: [clang] Remove unnecessary virtual inheritance in `TargetInfo`

Stoorx created this revision. Herald added a project: All. Stoorx requested review of this revision. Herald added a project: clang. Since the `TargetInfo` has no diamond-like inheritance diagram, the `virtual` keyword is not necessary. Repository: rG LLVM Github Monorepo

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: qiongsiwu1, w2yehia. Herald added a project: All. ZarkoCA requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. D148177 also removed the error for

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 515910. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

gAlfonso-bit created this revision. gAlfonso-bit added a reviewer: MaskRay. Herald added a subscriber: Enna1. Herald added projects: Flang, All. gAlfonso-bit requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, jdoerfert. Herald added projects: clang, Sanitizers.

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/ https://reviews.llvm.org/D148954 ___ cfe-commits mailing list

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

efriedma added a comment. If you have a library function that's built with "denormal-fp-math"="dynamic,dynamic", you can link it into code built in any mode, and LTO should be able to propagate that mode from the caller to the callee. That doesn't require clang to do anything special; you can

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

Stoorx updated this revision to Diff 515892. Stoorx added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/ https://reviews.llvm.org/D148954 Files: clang-tools-extra/modularize/CoverageChecker.cpp clang-tools-extra/modularize/ModularizeUtilities.cpp

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

Stoorx created this revision. Herald added a project: All. Stoorx requested review of this revision. Herald added projects: clang, clang-tools-extra. In file `clang/lib/Basic/Module.cpp` the `Module` class had `submodule_begin()` and `submodule_end()` functions to retrieve corresponding

[PATCH] D148835: [clang] removes trailing whitespace

cjdb added a comment. In D148835#4288151 , @erichkeane wrote: > In D148835#4288148 , @cjdb wrote: > >> In D148835#4286924 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 515880. paulkirth added a comment. Add relese note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst

[PATCH] D129835: [clang] adds a discardable attribute

cjdb added a comment. Yeah, in retrospect, I agree (and may need to clean up a few iterator types now, grr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129835/new/ https://reviews.llvm.org/D129835

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. In D142907#4288247 , @efriedma wrote: > Given that, I don't follow the whole "merging" thing... we should just be > setting whatever mode is active. The attribute setting should not depend on > whether the function is

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 515876. tianshilei1992 added a comment. update more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

aaron.ballman added a comment. Precommit CI found a relevant failure that should be addressed. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:8593 +const FunctionProtoType *FnType = FD->getType()->castAs(); +if (FnType->isVolatile()) { ilya-biryukov

[PATCH] D148951: [dataflow] HTMLLogger: fix off-by-one in the BB listing

sammccall added a comment. Before: F27217511: image.png After: F27217508: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148951/new/

[PATCH] D148951: [dataflow] HTMLLogger: fix off-by-one in the BB listing

sammccall created this revision. sammccall added a reviewer: mboehme. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

thurston added a comment. Thanks Aaron and Jorge for the quick revert and replies! :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276 ___ cfe-commits mailing

[clang] fa2a8c2 - [dataflow] Don't crash in Environment::dump when decls have weird names

Author: Sam McCall Date: 2023-04-21T21:08:26+02:00 New Revision: fa2a8c2e1cdf188ce985d69fca6f78866390b715 URL: https://github.com/llvm/llvm-project/commit/fa2a8c2e1cdf188ce985d69fca6f78866390b715 DIFF: https://github.com/llvm/llvm-project/commit/fa2a8c2e1cdf188ce985d69fca6f78866390b715.diff

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

sousajo added a comment. In D148276#4288236 , @aaron.ballman wrote: > In D148276#4288145 , @sousajo wrote: > >> hey :( I will try to investigate it a bit sometime next week ^^ thanks for >> pointing it out > >

[PATCH] D129835: [clang] adds a discardable attribute

erichkeane added a comment. In D129835#4288240 , @aaron.ballman wrote: > In D129835#4287866 , @cjdb wrote: > With [[discardable]] one just needs to push/pop at the extremes of a file (and if a future

[PATCH] D148835: [clang] removes trailing whitespace

sbc100 added a comment. In D148835#4288151 , @erichkeane wrote: > In D148835#4288148 , @cjdb wrote: > >> In D148835#4286924 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

efriedma added a comment. I'm having trouble understanding the changes on the clang side. If I'm following correctly; the "denormal-fp-math" setting is a promise from the user to the compiler: if the setting is not "dynamic", the user promises that the definition will only execute in the

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

shafik added a comment. Thank you for this fix. Can you please add a summary in the details explaining the motivation for this fix and a link to the github bug report as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148944/new/

[PATCH] D129835: [clang] adds a discardable attribute

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. In D129835#4287866 , @cjdb wrote: >>> With [[discardable]] one just needs to push/pop at the extremes of a file >>> (and if a future version of module maps supports global

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

aaron.ballman added a comment. In D148276#4288145 , @sousajo wrote: > hey :( I will try to investigate it a bit sometime next week ^^ thanks for > pointing it out Thank you for looking into it! I didn't think about `remove_const`, `remove_cv`, etc.

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 515854. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

shafik added inline comments. Comment at: clang/test/CXX/class/class.compare/class.compare.default/p1.cpp:18 bool operator<=(const A&) const = default; - bool operator==(const A&) const volatile && = default; // surprisingly, OK + bool operator==(const A&) const && =

[PATCH] D148835: [clang] removes trailing whitespace

erichkeane added a comment. In D148835#4288148 , @cjdb wrote: > In D148835#4286924 , @aaron.ballman > wrote: > >> In D148835#4286905 , @erichkeane >> wrote: >> >>> In

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber updated this revision to Diff 515843. Krishna-13-cyber added a comment. I have tried a little modification from my side thinking on a beneficial note. I will make the changes to all the other test files as well if this diagnostic representation goes well after mentor review.

[PATCH] D148835: [clang] removes trailing whitespace

cjdb added a comment. In D148835#4286924 , @aaron.ballman wrote: > In D148835#4286905 , @erichkeane > wrote: > >> In D148835#4284871 , @cjdb wrote: >> >>> I've had some

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

sousajo added a comment. hey :( I will try to investigate it a bit sometime next week ^^ thanks for pointing it out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276

[PATCH] D148757: [clang] Follow user-provided order for prefix map

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

MaskRay added a comment. Related: D122444 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148945/new/ https://reviews.llvm.org/D148945 ___ cfe-commits mailing list

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148945/new/ https://reviews.llvm.org/D148945

[PATCH] D145197: [clang][deps] NFC: Refactor and comment ModuleDeps sorting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b80f00bac6a: [clang][deps] NFC: Refactor and comment ModuleDeps sorting (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[clang] 6b80f00 - [clang][deps] NFC: Refactor and comment ModuleDeps sorting

Author: Jan Svoboda Date: 2023-04-21T10:56:42-07:00 New Revision: 6b80f00bac6a4832af4f8ebde96564690a35f7e1 URL: https://github.com/llvm/llvm-project/commit/6b80f00bac6a4832af4f8ebde96564690a35f7e1 DIFF: https://github.com/llvm/llvm-project/commit/6b80f00bac6a4832af4f8ebde96564690a35f7e1.diff

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea0dae096189: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an… (authored by craig.topper). Changed prior to commit:

[clang] ea0dae0 - [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

Author: Craig Topper Date: 2023-04-21T10:54:24-07:00 New Revision: ea0dae0961897da69b960caf68063db86312674d URL: https://github.com/llvm/llvm-project/commit/ea0dae0961897da69b960caf68063db86312674d DIFF: https://github.com/llvm/llvm-project/commit/ea0dae0961897da69b960caf68063db86312674d.diff

[PATCH] D146987: [Assignment Tracking] Enable by default

srj added a comment. In D146987#4287847 , @srj wrote: > In D146987#4287819 , @jmorse wrote: > >> Should have been reverted in rG0ba922f60046 >>

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

ldionne added subscribers: phosek, Ericson2314, aaron.ballman. ldionne added a comment. CCing some folks that were watching D132324 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148945/new/

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We don't support the LLVM_ENABLE_PROJECTS=libcxx build anymore (and have not for over a year), so it should be fine

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

This revision was automatically updated to reflect the committed changes. Closed by commit rG53a4a2b45bb2: [clang] NFCI: Optimize storage and lookup of analyzer options (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D137258?vs=515455=515828#toc Repository: rG

[clang] 53a4a2b - [clang] NFCI: Optimize storage and lookup of analyzer options

Author: Jan Svoboda Date: 2023-04-21T10:39:55-07:00 New Revision: 53a4a2b45bb2407f3249dea54f1a8b3e230b188a URL: https://github.com/llvm/llvm-project/commit/53a4a2b45bb2407f3249dea54f1a8b3e230b188a DIFF: https://github.com/llvm/llvm-project/commit/53a4a2b45bb2407f3249dea54f1a8b3e230b188a.diff

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

jansvoboda11 added a comment. Sorting at compile-time would be nicer, but I don't have the bandwidth to implement something like that. I'll leave a FIXME in case someone wants to pick it up. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Reverted in 7f00ecd029213aee9baf297554b0cb25a5ffbd0f Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 7f00ecd - Revert "[clang] trigger -Wcast-qual on functional casts"

Author: Aaron Ballman Date: 2023-04-21T13:33:39-04:00 New Revision: 7f00ecd029213aee9baf297554b0cb25a5ffbd0f URL: https://github.com/llvm/llvm-project/commit/7f00ecd029213aee9baf297554b0cb25a5ffbd0f DIFF: https://github.com/llvm/llvm-project/commit/7f00ecd029213aee9baf297554b0cb25a5ffbd0f.diff

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

aaron.ballman added a comment. In D148276#4287931 , @aaron.ballman wrote: > In D148276#4287900 , @thurston > wrote: > >> I think this change is triggering an error on a buildbot >>

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

aaron.ballman added a comment. In D148276#4287900 , @thurston wrote: > I think this change is triggering an error on a buildbot > (https://lab.llvm.org/buildbot/#/builders/37/builds/21631/steps/20/logs/stdio): > > >

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. I'd appreciate some riscv32 RUN lines for completeness, but otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148817/new/

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

Mordante accepted this revision. Mordante added a comment. I too am not really convinced by all changes in libc++. On the other hand I don't think the change make the libc++ code looking bad. So I don't feel a reason to reject the libc++ changes. I don't like the commit message, there's only a

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

thurston added a comment. I think this change is triggering an error on a buildbot (https://lab.llvm.org/buildbot/#/builders/37/builds/21631/steps/20/logs/stdio): /b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Analysis/UnsafeBufferUsage.cpp:1348:45: error: cast from 'const

[PATCH] D129835: [clang] adds a discardable attribute

cjdb added a comment. >> With [[discardable]] one just needs to push/pop at the extremes of a file >> (and if a future version of module maps supports global pragmas for a >> module, there too, but that's a discussion that requires a design doc). > > I understood that, I just don't think that's

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

k-mana created this revision. k-mana added a reviewer: fhahn. Herald added subscribers: StephenFan, mstorsjo. Herald added a project: All. k-mana requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D146987: [Assignment Tracking] Enable by default

srj added a comment. In D146987#4287819 , @jmorse wrote: > Should have been reverted in rG0ba922f60046 > earlier > today, are you still experiencing the same behaviour with that

[PATCH] D146987: [Assignment Tracking] Enable by default

jmorse added a comment. In D146987#4287794 , @srj wrote: > (But more seriously, could we please revert all of this unless/until a fix is > imminent? Our testing is dead in the water at the moment.) Should have been reverted in rG0ba922f60046

[PATCH] D146987: [Assignment Tracking] Enable by default

srj added a comment. In D146987#4287137 , @jmorse wrote: > Ah, you're right, it's actually the same assertion message that @srj reported > which I totally skipped over. Currently I suspect that's due to different > std::sort implementations.

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: mlir/test/Target/LLVMIR/omptarget-llvm.mlir:4-5 -llvm.func @_QPopenmp_target_data() { - %0 = llvm.mlir.constant(1 : i64) : i64 - %1 = llvm.alloca %0 x i32 {bindc_name = "i", in_type = i32,

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 515805. TIFitis marked an inline comment as done. TIFitis edited the summary of this revision. TIFitis added a comment. Updated tests. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148925: [clang][Interp] Fix discarding void-typed comma expressions

tbaeder added a comment. In D148925#4287502 , @erichkeane wrote: > Cool! Mind adding the tests I proposed? it would be nice to ensure/show > side-effects are guaranteed. Sure, thanks for the test case! CHANGES SINCE LAST ACTION

[PATCH] D148925: [clang][Interp] Fix discarding void-typed comma expressions

tbaeder updated this revision to Diff 515800. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148925/new/ https://reviews.llvm.org/D148925 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. reduced test case (that is currently blocking this diff) : namespace outer::internal { template concept myconcept = true; } namespace outer { template class Foo; template struct Bar { template friend class Foo; };

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

erichkeane added a comment. Still suspicious about this/whether it models the MSVC implementation correctly, but no real implementation concerns. I REALLY want us to document the attribute extensively however. Comment at: clang/include/clang/Basic/AttrDocs.td:3543

[PATCH] D148925: Fix discarding void-typed comma expressions

erichkeane added a comment. In D148925#4287497 , @tbaeder wrote: > In D148925#4287218 , @erichkeane > wrote: > >> So things cast to 'void' can have side effects, right? Does the call to >> discard still

[PATCH] D148925: Fix discarding void-typed comma expressions

tbaeder added a comment. In D148925#4287218 , @erichkeane wrote: > So things cast to 'void' can have side effects, right? Does the call to > discard still evaluate them? > > https://godbolt.org/z/a3ej9bxKe Yes. `discard(E)` is just `visit(E)`, except

[PATCH] D148925: Fix discarding void-typed comma expressions

tbaeder updated this revision to Diff 515762. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148925/new/ https://reviews.llvm.org/D148925 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

ilya-biryukov added a reviewer: clang-language-wg. ilya-biryukov added a comment. Thanks! I believe we should also recover in the similar manner we do for missing `const`, see corresponding comment. Extra NITs: - there is a typo in description: *compariosn* should be comparison, - we probably

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin added inline comments. Comment at: clang/include/clang/Format/Format.h:851 + /// The function parameter breaking style to use. + /// \version 16.0 + FunctionParameterBreakingStyle BreakBeforeFunctionParameters; so should this be 17.0 now? This has

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 515756. jrmolin added a comment. a unit test was failing, so I fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files:

[PATCH] D148799: [clang] Return `std::string_view` from `TargetInfo::getClobbers()`

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. If you have commit access already, wait until the pre-commit builds finish and check there isn't anything failing there. If you don't, I can commit this for you as I did before.

[PATCH] D148799: [clang] Return `std::string_view` from `TargetInfo::getClobbers()`

Stoorx updated this revision to Diff 515752. Stoorx edited the summary of this revision. Stoorx added a comment. Fix, Rebase & retitle CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148799/new/ https://reviews.llvm.org/D148799 Files: clang/include/clang/Basic/TargetInfo.h

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt updated this revision to Diff 515740. RIscRIpt added a comment. A proper implementation In D134475#4224082 , @erichkeane wrote: > I don't have a good idea, I don't think any sort of RAII object is the right > way (since it will be wrong on

[PATCH] D148914: [Sema][NFC] add check before using `BuildExpressionFromIntegralTemplateArgument`

erichkeane added a comment. See my comment on https://github.com/llvm/llvm-project/issues/62265 for results of my debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148914/new/ https://reviews.llvm.org/D148914

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:167-168 - NonLoc rawOffsetVal = rawOffset.getByteOffset(); - - // CHECK LOWER BOUND: Is byteOffset < extent begin? - // If so, we are doing a load/store - // before the

[PATCH] D148926: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt abandoned this revision. RIscRIpt added a comment. This had to be submitted to https://reviews.llvm.org/D134475 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148926/new/ https://reviews.llvm.org/D148926

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

donat.nagy added a comment. @steakhal Thanks for the review, it was really instructive :). I'll probably upload the updated commit on Monday. What kind of measurements are you suggesting? I analyzed a few open source projects with the patched Clang SA (see results in my previous commit) and a

[PATCH] D148799: [clang] Return `std::string_view` from `TargetInfo::getClobbers()`

DavidSpickett added a comment. Build issues will also show up in the "Build Status" here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148799/new/ https://reviews.llvm.org/D148799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >