[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

mingmingl created this revision. Herald added subscribers: mstorsjo, kristof.beyls. Herald added a project: All. mingmingl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before: - Clang emits 'invalid output constraint error'

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM. About formatting the tests: Personally, I would have preferred to "clean as you code", but I can see your point. Leave it as-is. Land it, please. CHANGES SINCE LAST ACTION

[PATCH] D148962: [RISCV] Make Zicntr and Zihpm imply Zicsr.

asb accepted this revision. asb added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148962/new/ https://reviews.llvm.org/D148962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] bdbc6c6 - [clang][AST][NFC] Turn some single-line comments into doc comments

Author: Timm Bäder Date: 2023-04-25T07:17:58+02:00 New Revision: bdbc6c6c325adb6fc55b1e6228fef7c52b3d6731 URL: https://github.com/llvm/llvm-project/commit/bdbc6c6c325adb6fc55b1e6228fef7c52b3d6731 DIFF: https://github.com/llvm/llvm-project/commit/bdbc6c6c325adb6fc55b1e6228fef7c52b3d6731.diff

[PATCH] D143704: [flang] Feature list plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00d0749f92ec: [flang] Feature list plugin (authored by elmcdonough). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148757: [clang] Follow user-provided order for prefix map

gulfem added a comment. In D148757#4289152 , @MaskRay wrote: > In D148757#4289076 , @MaskRay wrote: > >> I'm creating a patch to change DebugPrefixMap to respect the command line >> option order... > > Created

[PATCH] D148757: [clang] Follow user-provided order for prefix map

gulfem updated this revision to Diff 516616. gulfem added a comment. Remove the changes from debuginfo, which is handled in D14897 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 updated this revision to Diff 516615. HerrCai0907 added a comment. add comment and more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149009/new/ https://reviews.llvm.org/D149009 Files: clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D149119: [CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows

ikudrin created this revision. ikudrin added reviewers: john.brawn, daltenty, jsji, simon_tatham, tmatheson, mstorsjo, phosek. ikudrin added projects: LLVM, clang. Herald added subscribers: ekilmer, inglorion. Herald added a project: All. ikudrin requested review of this revision. As for now,

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

joshua-arch1 added a comment. In D147610#4294260 , @craig.topper wrote: > In D147610#4294247 , @joshua-arch1 > wrote: > >> I'm wondering whether it is appropriate to just use FPR16 for the >> destination of

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

sstwcw added a comment. Is this patch accepted or rejected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148484/new/ https://reviews.llvm.org/D148484 ___ cfe-commits mailing list

[clang] e66c2db - -Wframe-larger-than=: improve error with an invalid argument

Author: Fangrui Song Date: 2023-04-24T20:11:21-07:00 New Revision: e66c2db7996ed0ce8cd27548a623ce62246be33b URL: https://github.com/llvm/llvm-project/commit/e66c2db7996ed0ce8cd27548a623ce62246be33b DIFF: https://github.com/llvm/llvm-project/commit/e66c2db7996ed0ce8cd27548a623ce62246be33b.diff

[PATCH] D148962: [RISCV] Make Zicntr and Zihpm imply Zicsr.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148962/new/ https://reviews.llvm.org/D148962

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

kito-cheng added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2408 + +OperandMatchResultTy RISCVAsmParser::parseZcSpimm(OperandVector ) { + if (getLexer().is(AsmToken::Minus)) `parseZcSpimm` -> `parseZcmpSpimm`

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 516598. 4vtomat added a comment. Removed unnecessary comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files:

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

craig.topper added a comment. In D147610#4294247 , @joshua-arch1 wrote: > I'm wondering whether it is appropriate to just use FPR16 for the destination > of fcvt.bf16.s? The destination is in BF16 format instead of simple FP16. > Your implemention

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 516596. 4vtomat added a comment. Resolved Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files: clang/include/clang/Basic/riscv_sifive_vector.td

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

joshua-arch1 added a comment. I'm wondering whether it is appropriate to just use FPR16 for the destination of fcvt.bf16.s? The destination is in BF16 format instead of simple FP16. Your implemention looks like just replacing fcvt.h.s with fcvt.bf16.s. Do we need to define a new register

[PATCH] D148490: [AIX] use system assembler for assembly files

qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:427 + Assembler.reset(buildAssembler()); +return Assembler.get(); + } I saw we have a `ToolChain::getAssemble()` method. Can we use that directly? Comment

[PATCH] D149110: [HIP] Detect HIP for Ubuntu, Mint, Gentoo, etc.

cgmb created this revision. cgmb added reviewers: scchan, tra, yaxunl. Herald added subscribers: kosarev, kerbowa, jvesely. Herald added a project: All. cgmb published this revision for review. cgmb added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string

nickdesaulniers updated this revision to Diff 516582. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - fix typos - simplify maybeDemangleSymbol in lld COFF - restore maybeDemangleSymbol Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b63b2c2 - Reland "[-Wunsafe-buffer-usage] Bug fix: Handles the assertion violations for code within macros"

Author: MalavikaSamak Date: 2023-04-24T16:49:13-07:00 New Revision: b63b2c2350ad1af9131fd95bb94c642d912bd4cf URL: https://github.com/llvm/llvm-project/commit/b63b2c2350ad1af9131fd95bb94c642d912bd4cf DIFF: https://github.com/llvm/llvm-project/commit/b63b2c2350ad1af9131fd95bb94c642d912bd4cf.diff

[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string

nickdesaulniers added inline comments. Comment at: lld/ELF/Symbols.cpp:50 +std::string root = symName.str(); +return demangle(root); + } MaskRay wrote: > `return demangle(symName.str());` > > perhaps `return demangle(symName);` works as well? > perhaps

[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string

nickdesaulniers added inline comments. Comment at: lld/COFF/Symbols.cpp:43 if (demangled != demangleInput) - return prefix + demangle(demangleInput.str()); + return prefix + demangle(demangleInput); return (prefix + prefixless).str();

[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string

MaskRay added inline comments. Comment at: lld/ELF/Symbols.cpp:50 +std::string root = symName.str(); +return demangle(root); + } `return demangle(symName.str());` perhaps `return demangle(symName);` works as well? Repository: rG LLVM Github

[clang] 84ec1f7 - Revert "[-Wunsafe-buffer-usage] Bug fix: Handles the assertion violations for code within macros"

Author: MalavikaSamak Date: 2023-04-24T16:48:46-07:00 New Revision: 84ec1f7725d4f4575474b59467e598d7c5528a4e URL: https://github.com/llvm/llvm-project/commit/84ec1f7725d4f4575474b59467e598d7c5528a4e DIFF: https://github.com/llvm/llvm-project/commit/84ec1f7725d4f4575474b59467e598d7c5528a4e.diff

[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string

nickdesaulniers updated this revision to Diff 516580. nickdesaulniers marked an inline comment as done. nickdesaulniers retitled this revision from "[Demangle] use moar std::string_view" to "[Demangle] make llvm::demangle take std::string_view rather than const std::string&". nickdesaulniers

[clang] 1d097ad - [clang] Fix -Wimplicit-fallthrough in UnsafeBufferUsage.cpp [NFC]

Author: Jie Fu Date: 2023-04-25T07:34:39+08:00 New Revision: 1d097ad73b3fe38ff301f471356d15f093a2dbef URL: https://github.com/llvm/llvm-project/commit/1d097ad73b3fe38ff301f471356d15f093a2dbef DIFF: https://github.com/llvm/llvm-project/commit/1d097ad73b3fe38ff301f471356d15f093a2dbef.diff LOG:

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

sbc100 added a comment. We bisected a build failure on the emscripten waterfall to this change: https://ci.chromium.org/ui/p/emscripten-releases/builders/try/linux/b878293284529557/overview

[PATCH] D146450: [-Wunsafe-buffer-usage] Bug fix: Handles the assertion violations for code within macros.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bd0db80784e: [-Wunsafe-buffer-usage] Bug fix: Handles the assertion violations for code… (authored by malavikasamak). Herald added a project:

[clang] 9bd0db8 - [-Wunsafe-buffer-usage] Bug fix: Handles the assertion violations for code within macros

Author: MalavikaSamak Date: 2023-04-24T16:10:15-07:00 New Revision: 9bd0db80784e30d40a4a65f1b47109c833f05b54 URL: https://github.com/llvm/llvm-project/commit/9bd0db80784e30d40a4a65f1b47109c833f05b54 DIFF: https://github.com/llvm/llvm-project/commit/9bd0db80784e30d40a4a65f1b47109c833f05b54.diff

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

dblaikie added a comment. In D147844#4293743 , @cjdb wrote: > In D147844#4293693 , @dblaikie > wrote: > >>> I think some of the cases are ambiguous while others are not. >> >> Data would be good to have - if

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) { +// if Function defined by inline friend, use inline fried as

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:209 - std::map DebugPrefixMap; + llvm::SmallVector, 0> DebugPrefixMap; std::map CoveragePrefixMap; scott.linder wrote: > What

[PATCH] D148981: [clang][Interp] PointerToBoolean casts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148981/new/ https://reviews.llvm.org/D148981

[PATCH] D149059: [clang][Interp] Fix zero-init of float and pointer arrays

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149059/new/ https://reviews.llvm.org/D149059

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

This revision was automatically updated to reflect the committed changes. Closed by commit rG38ecb9767c14: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/

[clang] 38ecb97 - [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Author: Manna, Soumi Date: 2023-04-24T14:52:55-07:00 New Revision: 38ecb9767c1485abe0eb210ceeb827a884bc55c9 URL: https://github.com/llvm/llvm-project/commit/38ecb9767c1485abe0eb210ceeb827a884bc55c9 DIFF: https://github.com/llvm/llvm-project/commit/38ecb9767c1485abe0eb210ceeb827a884bc55c9.diff

[PATCH] D149084: [clang-tidy] Added bugprone-multi-level-implicit-pointer-conversion check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/multi-level-implicit-pointer-conversion.rst:43 +safety of the conversion before using an explicit cast. +This extra level of caution can help catch potential issues early on in

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

scott.linder added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:209 - std::map DebugPrefixMap; + llvm::SmallVector, 0> DebugPrefixMap; std::map CoveragePrefixMap; What benefit does forcing allocation have? Why not use the

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

cjdb added a comment. In D147844#4293693 , @dblaikie wrote: >> I think some of the cases are ambiguous while others are not. > > Data would be good to have - if this assessment is true, we'd expect this to > bear out in terms of bug finding, yeah? (that

[PATCH] D148992: [clang-repl] Fix dynamic library test to avoid cstdio and linker

zhuhan0 accepted this revision. zhuhan0 added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148992/new/ https://reviews.llvm.org/D148992

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

cor3ntin added a comment. I'm afraid I have been bitten by this very issue several more than once. I can only assume I'm not the only one. so this looks like a nice improvement. There are only a few changes in libc++ so it seems fairly low noise. Did you try to compile llvm with it? I'd be

[PATCH] D149098: [Clang] Add tests and mark as implemented WG14 N2728 (char16_t & char32_t string literals shall be UTF-16 & UTF-32)

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM (modulo nitpicking comment) Comment at: clang/test/Lexer/char-literal.cpp:49 +#ifndef __cplusplus +// expected-error@-2 {{universal character name refers to a

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

dblaikie added a comment. > I think some of the cases are ambiguous while others are not. Data would be good to have - if this assessment is true, we'd expect this to bear out in terms of bug finding, yeah? (that the cases you find to be ambiguous turn up as real bugs with some significant

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

This revision was automatically updated to reflect the committed changes. Closed by commit rG5084ba395e48: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5084ba3 - [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

Author: Louis Dionne Date: 2023-04-24T16:44:05-04:00 New Revision: 5084ba395e487adee67ba38cc5c68ff7e052e37c URL: https://github.com/llvm/llvm-project/commit/5084ba395e487adee67ba38cc5c68ff7e052e37c DIFF: https://github.com/llvm/llvm-project/commit/5084ba395e487adee67ba38cc5c68ff7e052e37c.diff

[PATCH] D149098: [Clang] Add tests and mark as implemented WG14 N2728 (char16_t & char32_t string literals shall be UTF-16 & UTF-32)

tahonermann added inline comments. Comment at: clang/test/Lexer/char-literal.cpp:2-5 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -std=c++17 -Wfour-char-constants -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple x86_64-apple-darwin -std=c++20 -Wfour-char-constants

[PATCH] D149003: [clang] Add test for CWG1821

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149003/new/ https://reviews.llvm.org/D149003

[PATCH] D149000: Update with warning message for comparison to NULL pointer

shafik added inline comments. Comment at: clang/test/Sema/warn-tautological-compare.c:102 +} \ No newline at end of file Please add back the missing newline Comment at: clang/test/SemaCXX/constant-expression-cxx2a.cpp:252 // ... but in the

[PATCH] D149098: [Clang] Add tests and mark as implemented WG14 N2728 (char16_t & char32_t string literals shall be UTF-16 & UTF-32)

tahonermann created this revision. tahonermann added reviewers: aaron.ballman, erichkeane, cor3ntin. Herald added a project: All. tahonermann requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change expands testing of UTF-8, UTF-16, and

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna added a comment. In D149074#4293543 , @tahonermann wrote: > Looks good to me Thank you @tahonermann CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/ https://reviews.llvm.org/D149074

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

This revision was automatically updated to reflect the committed changes. Closed by commit rG74f00516e5ce: [DFSAN] Add support for strsep. (authored by tkuchta, committed by browneee). Herald added a subscriber: Sanitizers. Changed prior to commit:

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me, thanks @Manna! Comment at: clang/utils/TableGen/NeonEmitter.cpp:392 -for (auto Type : Types) { +for (const auto : Types) { //

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

awarzynski added a comment. Thanks for all the great effort, @ekieri ! @sunshaoce , mostly makes sense, just a few small suggestions. @peixin , wdyt? Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:601-603 +// A Fortran main program will be lowered to a function named

[PATCH] D149088: [clang-format] Add run-clang-format.py script.

Eugene.Zelenko added inline comments. Comment at: clang/tools/run-clang-format.py:1 +#!/usr/bin/env python3 +# Looks like Windows en of lines were mixed with UNIX ones. Comment at: clang/tools/run-clang-format.py:26 + +from __future__ import

[PATCH] D149088: [clang-format] Add run-clang-format.py script.

curdeius added a comment. I guess I need to add a test in a similar that run-clang-tidy is tested, but I'd like to gather some initial review still. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149088/new/ https://reviews.llvm.org/D149088

[PATCH] D149088: [clang-format] Add run-clang-format.py script.

curdeius created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. curdeius requested review of this revision. Herald added a comment. NOTE: Clang-Format Team

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

aaron.ballman added a comment. In D146595#4284340 , @dblaikie wrote: > In D146595#4284268 , @aaron.ballman > wrote: > >> In D146595#4284220 , @dblaikie >> wrote: >> >>>

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

cjdb added a comment. I think this is a good diagnostic to add: it improves readability and eliminates ambiguities. My only request is that if there isn't already a FixIt hint, one be added, please. Comment at: clang/test/Sema/parentheses.c:94 (void)(x + y > 0 ? 1 : 2);

[PATCH] D141310: [clang] add -Wcompare-function-pointers

aaron.ballman added a comment. In D141310#4285703 , @dblaikie wrote: > FWIW I think it's still worth some data from applying this to a broad > codebase like Chromium/wherever it's planned to be used - whether it's > practical to make a codebase clean

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note to `clang/docs/ReleaseNotes.rst` for the fix. Do you need me to commit on your behalf? If so, please let me know what name and email

[PATCH] D144603: Disable compiler launcher on external projects and multi stage clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe38cdc5933b0: Disable compiler launcher on external projects and multi stage clang (authored by haowei). Repository: rG LLVM Github Monorepo

[clang] e38cdc5 - Disable compiler launcher on external projects and multi stage clang

Author: Haowei Wu Date: 2023-04-24T12:15:44-07:00 New Revision: e38cdc5933b026cd25cf70c06f690a431c608d63 URL: https://github.com/llvm/llvm-project/commit/e38cdc5933b026cd25cf70c06f690a431c608d63 DIFF: https://github.com/llvm/llvm-project/commit/e38cdc5933b026cd25cf70c06f690a431c608d63.diff

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

bryanpkc added a comment. > May I ask you to commit the change? I do not have commit access. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148211/new/ https://reviews.llvm.org/D148211 ___

[PATCH] D147989: [clang] Fix Attribute Placement

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Oops, I spoke too soon -- it looks like the precommit CI failure is related to this patch. This is what I get when I tested locally: Assertion failed: NextVal !=

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b85bfffc486: [clang][tests] Fix Flang driver tests for Windows (authored by kaadam, committed by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7b85bff - [clang][tests] Fix Flang driver tests for Windows

Author: Ádám Kallai Date: 2023-04-24T15:21:08-04:00 New Revision: 7b85bfffc486257361a598a3c9d4b6b67e3f6765 URL: https://github.com/llvm/llvm-project/commit/7b85bfffc486257361a598a3c9d4b6b67e3f6765 DIFF: https://github.com/llvm/llvm-project/commit/7b85bfffc486257361a598a3c9d4b6b67e3f6765.diff

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:4662 - for (auto KNPair : KnownNamespaces) + for (const auto : KnownNamespaces) Namespaces.addNameSpecifier(KNPair.first); tahonermann wrote: > The element type is a pair of

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:392 -for (auto Type : Types) { +for (const auto : Types) { // If this builtin takes an immediate argument, we need to #define it rather tahonermann wrote: > The

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna updated this revision to Diff 516488. Manna marked 7 inline comments as done. Manna edited the summary of this revision. Manna added a comment. I have addressed @tahonermann review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/

[PATCH] D147989: [clang] Fix Attribute Placement

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Do you need someone to land this on your behalf? If so, what name and email address would you like used for patch attribution? (I can fix the tiny style nit myself when landing,

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL updated this revision to Diff 516481. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148458/new/ https://reviews.llvm.org/D148458 Files:

[PATCH] D149084: [clang-tidy] Added bugprone-multi-level-implicit-pointer-conversion check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects implicit

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added a comment. Need to update RISCVUsage.rst Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:969 +case KindTy::Spimm: + OS << "{Spimm: "; + RISCVZC::printSpimm(Spimm.Val, OS); Why curly braces when everything else

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

aaron.ballman added reviewers: dblaikie, cjdb, echristo, clang-language-wg. aaron.ballman added a comment. In D147844#4286500 , @philnik wrote: > I have to say I'm not really convinced this change is a good idea. The cases > it flags don't really seem

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

tahonermann added a comment. I added a comment to skip the one where the element type is a simple pair. The rest look fine to me. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:182 // Skip methods in records. -for (auto P :

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

sunshaoce updated this revision to Diff 516476. sunshaoce added a comment. This revision is now accepted and ready to land. Herald added subscribers: pcwang-thead, s.egerton, simoncook, asb. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

sunshaoce added a comment. I would like to help land this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list

[PATCH] D144603: Disable compiler launcher on external projects and multi stage clang

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144603/new/ https://reviews.llvm.org/D144603

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri abandoned this revision. ekieri added a comment. Herald added a subscriber: sunshaoce. Sorry to drop out on this. I got interrupted by other duties in life, and now I am no longer able to continue this work. If anybody wants to pick up the ball from here, please feel free to commandeer

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

tra added a comment. lib/CodeGen changes look OK to me. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6257 + // Device code should not be at top level. + if (LangOpts.CUDA && LangOpts.CUDAIsDevice) +return; Could you give me an example of what exactly

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

rsmith added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5364-5368 if (const ConstantArrayType *CAT = S.getASTContext().getAsConstantArrayType(Entity.getType())) ArrayLength = CAT->getSize().getZExtValue(); else ArrayLength =

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 516452. jrmolin added a comment. pulled upstream/main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 516450. jrmolin marked an inline comment as done. jrmolin added a comment. change formatting of enum options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files:

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. The patch this is dependent on has now been accepted and landed, so this should be ready for review now if anyone is available! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/ https://reviews.llvm.org/D148370

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna updated this revision to Diff 516445. Manna edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/ https://reviews.llvm.org/D149074 Files: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h clang/lib/AST/ComputeDependence.cpp

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: kosarev, tpr. Herald added a reviewer: aaron.ballman. Herald added a reviewer: ributzka. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan,

[PATCH] D147666: [OPENMP] Adds /lib to rpath to avoid need to set LD_LIBRARY_PATH to find plugins.

gregrodgers abandoned this revision. gregrodgers added a comment. Its ugly, but to avoid requirement to set LD_LIBRARY_PATH for end-users who may need LD_LIBRARY_PATH for their own application, we will modify the compiler installation with these bash commands where _INSTALL_DIR is the

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b617081420d: [M68k] Add basic Clang support for M68881/2 (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147481/new/

[clang] 9b61708 - [M68k] Add basic Clang support for M68881/2

Author: Min-Yih Hsu Date: 2023-04-24T09:32:49-07:00 New Revision: 9b617081420dc579c52b53a4d8929b206b206eed URL: https://github.com/llvm/llvm-project/commit/9b617081420dc579c52b53a4d8929b206b206eed DIFF: https://github.com/llvm/llvm-project/commit/9b617081420dc579c52b53a4d8929b206b206eed.diff

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

steakhal added a comment. Please mark comments "Done" where applicable. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:173 + const MemSpaceRegion *SR = rawOffset.getRegion()->getMemorySpace(); + if (SR->getKind() != MemRegion::UnknownSpaceRegionKind) {

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

jyknight requested changes to this revision. jyknight added a comment. This revision now requires changes to proceed. I believe this is abandoned, correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145416/new/ https://reviews.llvm.org/D145416

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 516435. VincentWu marked 2 inline comments as done. VincentWu added a comment. remove testcse of Codegen & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

awarzynski added a comment. In D148038#4292549 , @agozillon wrote: > In D148038#4292262 , @awarzynski > wrote: > >> LGTM, thanks for addressing my comments! > > Thank you for your time and the great review

[clang] 8eea50c - Add missing HTML closing tag

Author: Aaron Ballman Date: 2023-04-24T11:58:50-04:00 New Revision: 8eea50c7c5569b13f8c910349754c72337075b1f URL: https://github.com/llvm/llvm-project/commit/8eea50c7c5569b13f8c910349754c72337075b1f DIFF: https://github.com/llvm/llvm-project/commit/8eea50c7c5569b13f8c910349754c72337075b1f.diff

[clang] 8aea6e0 - [clang][Interp][NFC] Take a QualType in visitZeroInitializer()

Author: Timm Bäder Date: 2023-04-24T17:58:15+02:00 New Revision: 8aea6e004fd2edafbdee2d3d13571ab5eace004e URL: https://github.com/llvm/llvm-project/commit/8aea6e004fd2edafbdee2d3d13571ab5eace004e DIFF: https://github.com/llvm/llvm-project/commit/8aea6e004fd2edafbdee2d3d13571ab5eace004e.diff

[clang] d64811f - Remove the "implement better version of existing tools" open project

Author: Aaron Ballman Date: 2023-04-24T11:56:25-04:00 New Revision: d64811f976b4305b54a5cbe0427002f5460c2d89 URL: https://github.com/llvm/llvm-project/commit/d64811f976b4305b54a5cbe0427002f5460c2d89 DIFF: https://github.com/llvm/llvm-project/commit/d64811f976b4305b54a5cbe0427002f5460c2d89.diff

[clang] 5259ff7 - Reword the open project for generating documentation

Author: Aaron Ballman Date: 2023-04-24T11:55:11-04:00 New Revision: 5259ff7f0aef9aa1871e623608d5c00d3284adb0 URL: https://github.com/llvm/llvm-project/commit/5259ff7f0aef9aa1871e623608d5c00d3284adb0 DIFF: https://github.com/llvm/llvm-project/commit/5259ff7f0aef9aa1871e623608d5c00d3284adb0.diff

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

kadircet added a comment. can you also add test coverage for the new LSP fields? Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:439 + for (auto : RemoveAll.Edits) { +E.annotationId.emplace(); +*E.annotationId = RemoveAllUnusedID; nit:

  1   2   >