[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

xgupta created this revision. xgupta added a reviewer: aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There seems to be a lot of documentation is missing for different command line flags

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1048 + static std::unique_ptr createRlist(unsigned RlistEncode, + SMLoc S, bool IsRV64) { +auto Op =

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. In D127284#4303390 , @tahonermann wrote: > This change appears to have negatively impacted some users that were > dependent on the previous

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

shafik added a comment. Please also add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149389/new/ https://reviews.llvm.org/D149389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

shafik added a comment. I need to look at this more carefully but can we add a release note in the meantime Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

MaskRay added inline comments. Comment at: clang/test/Driver/mips-cpu64abi32.c:1 +// Check handling the CPU is 64bit while ABI is O32. +// when build for MIPS platforms. Use `///` for non-CHECK non-RUN comments. Comment at:

[PATCH] D149401: [Clang][RISCV] Set native half type to legal when has zfh extension

craig.topper added a comment. Is this the same as https://reviews.llvm.org/D145071 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149401/new/ https://reviews.llvm.org/D149401 ___ cfe-commits mailing list

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:7 +// CHECK-NEXT: entry: +// CHECK-NEXT:[[CALL:%.*]] = call noalias noundef ptr @_Znwm(i64 noundef 4) #[[ATTR2:[0-9]+]] +// CHECK-NEXT:ret ptr [[CALL]] ` #[[ATTR2:[0-9]+]]`

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

shafik added a comment. So the change makes sense but the original issue: https://github.com/llvm/llvm-project/issues/62266 it worked for the first once but not the second, it also worked for the non-paren aggregate init. So I feel like the explanation is missing some details. It seems like

[PATCH] D149401: [Clang][RISCV] Set native half type to legal when has zfh extension

Yunzezhu created this revision. Yunzezhu added reviewers: asb, kito-cheng, craig.topper. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[clang] 876df74 - [flang][driver] Allow main program to be in an archive

Author: Shao-Ce SUN Date: 2023-04-28T09:53:25+08:00 New Revision: 876df74dd47196a9ca3b4fff21ffb5441491a0a0 URL: https://github.com/llvm/llvm-project/commit/876df74dd47196a9ca3b4fff21ffb5441491a0a0 DIFF: https://github.com/llvm/llvm-project/commit/876df74dd47196a9ca3b4fff21ffb5441491a0a0.diff

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG876df74dd471: [flang][driver] Allow main program to be in an archive (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145088/new/ https://reviews.llvm.org/D145088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] ce861ec - [Clang][Sema] Add a temporary workaround in SemaConcept.cpp

Author: Alexander Shaposhnikov Date: 2023-04-27T23:34:03Z New Revision: ce861ec782ae3f41807b61e855512aaccf3c2149 URL: https://github.com/llvm/llvm-project/commit/ce861ec782ae3f41807b61e855512aaccf3c2149 DIFF:

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out that FieldDecl::getInClassInitializer() will return nullptr for default member initializers if the field is part

[PATCH] D149364: [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. wow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149364/new/ https://reviews.llvm.org/D149364

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 517734. void added a comment. Use the new memory location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/Attr.td

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added a comment. (I apologize it took me so long to get back to reviewing this.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Herald added subscribers: bd1976llvm, jplehr. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:520 + getOpenMPRuntime().emitDeclareTargetVarDefinition(D, Addr, PerformInit)) +return; + efriedma wrote: > I don't really like the

[PATCH] D149364: [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h

tra added a comment. Fun tidbit: https://github.com/NVIDIA/thrust/issues/1703#issuecomment-1526604000 > Indeed, I believe the nvcc frontend has special handling for that attribute > expansion. clang would need to emulate that "special" handling > > Right. The

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. These changes all look good to me. For the `DeclaratorChunk` case, I noted an additional removal of a comment that I think should be considered. Assuming I haven't misread the code,

[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17cfd2e025cb: [profiling] Improve error message for raw profile header mismatches (authored by paquette). Herald added a project: clang. Herald

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

dankm added a comment. I certainly like the idea. I'll spend some time later looking at the implementation, but from a quick glance it looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149193/new/ https://reviews.llvm.org/D149193

[clang] 17cfd2e - [profiling] Improve error message for raw profile header mismatches

Author: Jessica Paquette Date: 2023-04-27T14:51:38-07:00 New Revision: 17cfd2e025cb3aa929ad219c6ed0974d6198bf5b URL: https://github.com/llvm/llvm-project/commit/17cfd2e025cb3aa929ad219c6ed0974d6198bf5b DIFF:

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + Weird indentation Comment at:

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

dankm added a comment. In D148975#4296895 , @MaskRay wrote: > Thank you! I feel that specifying multiple `-fdebug-prefix-map=` is a very > uncommon situation, so a release note entry is likely overkill. > I updated the HelpText, though. The Yocto

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3b1083e00e6: [Clang][Sema] Fix comparison of constraint

[clang] e3b1083 - [Clang][Sema] Fix comparison of constraint expressions

Author: Alexander Shaposhnikov Date: 2023-04-27T21:33:32Z New Revision: e3b1083e00e62f5d157d15cb8c63a1c3dfdf12e2 URL: https://github.com/llvm/llvm-project/commit/e3b1083e00e62f5d157d15cb8c63a1c3dfdf12e2 DIFF:

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149098: [Clang] Add tests and mark as implemented WG14 N2728 (char16_t & char32_t string literals shall be UTF-16 & UTF-32)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tahonermann marked 2 inline comments as done. Closed by commit rGa68039c51e61: [Clang] Add tests and mark as implemented WG14-N2728 (authored by tahonermann).

[clang] a68039c - [Clang] Add tests and mark as implemented WG14-N2728

Author: Tom Honermann Date: 2023-04-27T14:25:41-07:00 New Revision: a68039c51e6123bea4a019c02b72297e0de58529 URL: https://github.com/llvm/llvm-project/commit/a68039c51e6123bea4a019c02b72297e0de58529 DIFF: https://github.com/llvm/llvm-project/commit/a68039c51e6123bea4a019c02b72297e0de58529.diff

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

tahonermann added a comment. Herald added a subscriber: jplehr. This change appears to have negatively impacted some users that were dependent on the previous `Preprocessing::enableIncrementalProcessing(true)` behavior. See https://github.com/llvm/llvm-project/issues/62413. Repository: rG

[clang] 61976af - [clang][driver] Enable MisExpect diagnostics flag outside of CC1

Author: Paul Kirth Date: 2023-04-27T21:19:46Z New Revision: 61976af3ba9347935e9715067fcc0f5a568e6e7d URL: https://github.com/llvm/llvm-project/commit/61976af3ba9347935e9715067fcc0f5a568e6e7d DIFF: https://github.com/llvm/llvm-project/commit/61976af3ba9347935e9715067fcc0f5a568e6e7d.diff LOG:

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61976af3ba93: [clang][driver] Enable MisExpect diagnostics flag outside of CC1 (authored by paulkirth). Repository: rG LLVM Github Monorepo

[PATCH] D149380: [clang] Add -Wunused-result-always warning

gpanders created this revision. gpanders added a reviewer: theraven. Herald added a project: All. gpanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag enables warnings for unused function return values universally, even for

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:88 +if (PreambleIndexTask) + PreambleIndexTask->runAsync("task:" + Path + Version, + std::move(Task)); ilya-biryukov wrote: > This

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void added a comment. This is a precursor to specifying the field with the designated initializer syntax. Therefore, it may be a bit cumbersome. The code in `CGExpr.cpp` is decidedly gross. I would appreciate any advice on how to de-grossify it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

pcc added a comment. In D149215#4303197 , @tejohnson wrote: > In D149215#4303149 , @pcc wrote: > >>> Adds an LTO option >> >> Usual question: does it need to be an option? Could the allocator expose a >> symbol

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 517706. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 517704. void added a comment. Fix ICE when the FD isn't found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/Attr.td

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 517700. void added a comment. Add the ability to specify a "path" to the element count if it resides within a sub-structure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 517699. ayzhao marked an inline comment as done. ayzhao added a comment. code review comments + pull in D149301 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. The difference is that `clang-rename` is a stand-alone binary with CLI whereas `clangd` isn't typically used as such (it can be, but it's a weird use-case). I don't know if there are any existing users out there, if there are then I assume there are very few. It was

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson added a comment. In D149215#4303149 , @pcc wrote: >> Adds an LTO option > > Usual question: does it need to be an option? Could the allocator expose a > symbol such as `__malloc_hot_cold` that the linker could check for in the > symbol table?

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

ivanmurashko added a comment. In D148088#4302269 , @ilya-biryukov wrote: > > Could you elaborate a bit more on what is being cached with modules and how > this patch would affect it? I hope that I can provide some info here. We are going to use

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

kamaub accepted this revision. kamaub added a comment. This revision is now accepted and ready to land. Hello, sorry for missing you ping and delaying the patch so long just for test case adjustments, thank you for addressing them. Everything LGTM but lei and I had one request that can be made

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

pcc added a comment. > Adds an LTO option Usual question: does it need to be an option? Could the allocator expose a symbol such as `__malloc_hot_cold` that the linker could check for in the symbol table? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon updated this revision to Diff 517682. agozillon added a comment. - Move hostIRFilePath initialize invocation to ModuleTranslation.cpp to respect TargetOp patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson updated this revision to Diff 517678. tejohnson added a comment. Expand command and patch description for mechanism used by distributed ThinLTO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149215/new/ https://reviews.llvm.org/D149215

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:52-58 +enum AttrPrintLoc { + SIDE_NONE = 0, + SIDE_LEFT = 1, + SIDE_MIDDLE = 2, + SIDE_RIGHT = 4, + SIDE_ANY = SIDE_LEFT | SIDE_MIDDLE | SIDE_RIGHT, +};

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added a comment. Thanks for all the reviews. In D149280#4301188 , @njames93 wrote: > It may be a good idea to create unittests for the formatconverter in > `clang-tools-extra/unittests/clang-tidy/` I started there but had decided that the

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

scott.linder added a comment. I am OK to give LGTM, assuming the other reviewers don't still have reservations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149193/new/ https://reviews.llvm.org/D149193

[clang] 3e22eb3 - Fix spacing in ReleaseNotes.rst link

Author: Alan Zhao Date: 2023-04-27T11:41:21-07:00 New Revision: 3e22eb36b6ffd60608a0e70401b021738c1c4fe8 URL: https://github.com/llvm/llvm-project/commit/3e22eb36b6ffd60608a0e70401b021738c1c4fe8 DIFF: https://github.com/llvm/llvm-project/commit/3e22eb36b6ffd60608a0e70401b021738c1c4fe8.diff

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

aaron.ballman added a comment. In D148439#4299178 , @kbobyrev wrote: > Thanks Aaron! > > Yes, fair enough, that looks good to me, probably no need to move a sanity > check to the front of `main()` in this case. > > Also, just as a note: I don't know how

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

aaron.ballman added a comment. In D149314#4302892 , @craig.topper wrote: > Release note added in 0e02e5decc732155d8dc4b63ecccbb1477603ecd > Thanks Craig, that looks great

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

craig.topper added a comment. Release note added in 0e02e5decc732155d8dc4b63ecccbb1477603ecd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149314/new/

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

efriedma added a comment. Restructuring seems overall reasonable. (I'm assuming there isn't actually any changed code, just moving code around.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094

[clang] 0e02e5d - [RISCV] Add a release note for the removal of __attribute__((interrupt("user"))). NFC

Author: Craig Topper Date: 2023-04-27T11:22:21-07:00 New Revision: 0e02e5decc732155d8dc4b63ecccbb1477603ecd URL: https://github.com/llvm/llvm-project/commit/0e02e5decc732155d8dc4b63ecccbb1477603ecd DIFF: https://github.com/llvm/llvm-project/commit/0e02e5decc732155d8dc4b63ecccbb1477603ecd.diff

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

efriedma added a comment. Is this supposed to be different from D148093 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/6]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148089/new/ https://reviews.llvm.org/D148089

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/6]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148090/new/ https://reviews.llvm.org/D148090

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/6]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148091/new/ https://reviews.llvm.org/D148091

[PATCH] D149364: [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h

tra created this revision. Herald added subscribers: mattd, carlosgalvezp, bixia, yaxunl. Herald added a project: All. tra updated this revision to Diff 517656. tra added a comment. tra published this revision for review. tra added reviewers: jlebar, phawkins. Herald added a project: clang. Herald

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

aaron.ballman added a comment. In D148505#4300483 , @sberg wrote: >> But the fact that these two attributes already confuse users (AND we've got >> unused as an attribute in the mix as well, which doesn't help) means we >> should proceed with caution

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman edited reviewers, added: hubert.reinterpretcast, clang-language-wg; removed: jdoerfert. aaron.ballman added a comment. The changes generally LGTM, but: > in a way consistent with the proposed resolution to CWG1223. What are the chances that CWG changes their mind and picks a

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:237 static bool Verbose = false; ///< 'v' modifier -static bool Symtab = true;///< 's' modifier +static WriteSymTabType Symtab = true; ///< 's' modifier static bool

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 517638. DiggerLin marked 9 inline comments as done. DiggerLin added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. address comment and set option -Xany as invalid option and environment OBJECT-MODE=any as invalid too(let

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7354fb63471: Keep multiple-include optimization for null directives (authored by IncludeGuardian, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d7354fb - Keep multiple-include optimization for null directives

Author: Elliot Goodrich Date: 2023-04-27T13:44:11-04:00 New Revision: d7354fb63471a7a38993280c8264fd8d57432dc7 URL: https://github.com/llvm/llvm-project/commit/d7354fb63471a7a38993280c8264fd8d57432dc7 DIFF:

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7417e9d75c9a: [clang] Fix a crash with parenthesized aggregate initialization and base classes (authored by ayzhao). Repository: rG LLVM Github

[clang] 7417e9d - [clang] Fix a crash with parenthesized aggregate initialization and base classes

Author: Alan Zhao Date: 2023-04-27T10:43:16-07:00 New Revision: 7417e9d75c9af7dd0d3dad12eebdee84b10b56d7 URL: https://github.com/llvm/llvm-project/commit/7417e9d75c9af7dd0d3dad12eebdee84b10b56d7 DIFF: https://github.com/llvm/llvm-project/commit/7417e9d75c9af7dd0d3dad12eebdee84b10b56d7.diff

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

ayzhao added a comment. In D149301#4302621 , @aaron.ballman wrote: > I think you should add a release note for this when landing, Done > and this seems pretty reasonable to consider backporting to 16.x, WDYT? Agreed, given that this is a crash.

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

ayzhao updated this revision to Diff 517636. ayzhao added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149301/new/ https://reviews.llvm.org/D149301 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaInit.cpp

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay marked an inline comment as done. MaskRay added a comment. In D149193#4302337 , @scott.linder wrote: > In D149193#4300885 , @MaskRay wrote: > >> I think the patch as-is implements all the useful parts of

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

cjdb added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning-optimize.c:12 foo(); // expected-error {{call to 'foo' declared with 'error' attribute: oh no foo}} + // expected-note@* {{In function 'baz'}} if (x())

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, good catch! I think you should add a release note for this when landing, and this seems pretty reasonable to consider backporting to 16.x, WDYT? Repository: rG LLVM

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

aaron.ballman added a comment. In D149314#4302342 , @asb wrote: > In D149314#4302312 , @reames wrote: > >> In D149314#4302300 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:3150 + SMLoc Loc = Operands[1]->getStartLoc(); + return Error(Loc, "'rs1' and 'rs2' mast be different."); +} mast -> must Repository: rG LLVM

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 517616. skatrak added a comment. Remove checks from lowering that belong in semantic analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files:

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ab76b77cee0: [AArch64][InlineAsm]Add Clang support for flag output constraints (authored by mingmingl). Repository: rG LLVM Github Monorepo

[clang] 4ab76b7 - [AArch64][InlineAsm]Add Clang support for flag output constraints

Author: Mingming Liu Date: 2023-04-27T09:39:08-07:00 New Revision: 4ab76b77cee0e27510d5d5cb3072ee7e92d96eec URL: https://github.com/llvm/llvm-project/commit/4ab76b77cee0e27510d5d5cb3072ee7e92d96eec DIFF: https://github.com/llvm/llvm-project/commit/4ab76b77cee0e27510d5d5cb3072ee7e92d96eec.diff

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4301977 , @aaron.ballman wrote: > Thank you for working on this! These changes should come with test coverage > (we have a handful of verifier tests in `clang/test/Frontend` -- you can add > a new test file

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

asb added a comment. In D149314#4302312 , @reames wrote: > In D149314#4302300 , @aaron.ballman > wrote: > >> In D149314#4302266 , @asb wrote: >> >>> In D149314#4302203

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm updated this revision to Diff 517595. dankm added a comment. Correct test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 Files: clang/lib/AST/Decl.cpp clang/lib/AST/DeclarationName.cpp

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

scott.linder added a comment. In D149193#4300885 , @MaskRay wrote: > I think the patch as-is implements all the useful parts of GCC's complex > rules and in the absence of `-dumpbase` (we deliberately don't implement), > the rule almost exactly matches

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.cpp:1 +// RUN: %clang++ -g -fdebug-prefix-map=%p=./UNLIKELY_PATH/empty -S -c %s -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-REL + dankm wrote: > aaron.ballman wrote: > > I'm

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

aaron.ballman added a comment. In D149314#4302312 , @reames wrote: > In D149314#4302300 , @aaron.ballman > wrote: > >> In D149314#4302266 , @asb wrote: >> >>> In

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

reames added a comment. In D149314#4302300 , @aaron.ballman wrote: > In D149314#4302266 , @asb wrote: > >> In D149314#4302203 , >> @aaron.ballman wrote: >> >>> Is this

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. In D149314#4302266 , @asb wrote: > In D149314#4302203 , @aaron.ballman > wrote: > >> Is this a potentially breaking change that we need

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

kiranchandramohan added a comment. In D146557#4301955 , @TIFitis wrote: > In D146557#4295550 , > @kiranchandramohan wrote: > >> In D146557#4292223 , @TIFitis >> wrote:

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.cpp:1 +// RUN: %clang++ -g -fdebug-prefix-map=%p=./UNLIKELY_PATH/empty -S -c %s -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-REL + aaron.ballman wrote: > I'm taking a guess at

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

ilya-biryukov added a comment. In D148088#4302182 , @kuganv wrote: > 1. We see preamble indexing taking as much as 18% of the time for some files. > Moving preamble indexing out of the critical path helps there. Which operation are you measuring? 18%

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

asb added a comment. In D149314#4302203 , @aaron.ballman wrote: > Is this a potentially breaking change that we need to call out for users to > be aware of? We should mention this in the Clang release notes I think. Repository: rG LLVM Github

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

jyu2 added a comment. If it is okay with is_divece_ptr. I am okay with it. Please add a lit test for this? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627

[PATCH] D149352: [clang-format] Recognize Verilog type dimension in module header

sstwcw created this revision. sstwcw added a reviewer: curdeius. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. We had the function

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

aaron.ballman added a comment. Is this a potentially breaking change that we need to call out for users to be aware of? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149314/new/ https://reviews.llvm.org/D149314

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d0caef6081: [RISCV] Remove support for attribute interrupt(user). (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES

[clang] 05d0cae - [RISCV] Remove support for attribute interrupt("user").

Author: Craig Topper Date: 2023-04-27T08:21:36-07:00 New Revision: 05d0caef6081e1a6cb23a5a5afe43dc82e8ca558 URL: https://github.com/llvm/llvm-project/commit/05d0caef6081e1a6cb23a5a5afe43dc82e8ca558 DIFF: https://github.com/llvm/llvm-project/commit/05d0caef6081e1a6cb23a5a5afe43dc82e8ca558.diff

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

kuganv added a comment. In D148088#4302092 , @ilya-biryukov wrote: >> We would like to move the preamble index out of the critical path > > Could you provide motivation why you need to do it? What is the underlying > problem that this change is trying

  1   2   >