[PATCH] D136436: [Clang][LoongArch] Add GPR alias handling without `$` prefix

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bbf3ddf5fea: [Clang][LoongArch] Add GPR alias handling without `$` prefix (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0bbf3dd - [Clang][LoongArch] Add GPR alias handling without `$` prefix

Author: Weining Lu Date: 2023-05-13T12:08:59+08:00 New Revision: 0bbf3ddf5fea86e0eb0726142827e175aadaf53b URL: https://github.com/llvm/llvm-project/commit/0bbf3ddf5fea86e0eb0726142827e175aadaf53b DIFF: https://github.com/llvm/llvm-project/commit/0bbf3ddf5fea86e0eb0726142827e175aadaf53b.diff

[PATCH] D150450: Add C++26 compile flags.

shafik added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6649 .Case("c++20", "-std=c++20") // TODO add c++23 when MSVC supports it. + .Case("c++latest", "-std=c++26")

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530 + Triple.isAArch64() || Triple.isPS() || Triple.isVE() || + (Triple.isAndroid() && (Triple.getArch() == llvm::Triple::riscv64))); if (NoOmitFP ||

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

awson added a comment. Now, this #include #include auto drop1(const std::vector& s){ return s | std::views::drop(1); } when compiled against gcc's-13.1 libstdc++ spits: boro.cpp:5:11: error: invalid operands to binary expression ('const std::vector' and '_Partial<_Drop,

[PATCH] D150504: [AST] Construct Capture objects before use

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Msan reports https://reviews.llvm.org/P8308 So the reason is if PointerIntPair is not properly constructed,

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

sstwcw added a comment. > To this end, I am tracking the previous token type in a stack parallel > to LBraceStack to help scope this particular case. Maybe keep the description up to date with the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/

[clang-tools-extra] 81e149a - Replace None with std::nullopt in comments (NFC)

Author: Kazu Hirata Date: 2023-05-12T18:33:26-07:00 New Revision: 81e149aab9b3676b16728e883e2f21ee938cff93 URL: https://github.com/llvm/llvm-project/commit/81e149aab9b3676b16728e883e2f21ee938cff93 DIFF: https://github.com/llvm/llvm-project/commit/81e149aab9b3676b16728e883e2f21ee938cff93.diff

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

sstwcw added a comment. I would suggest adding a link to the revision on the issue thread for your future bug fixes. This people like me don't try to fix what others have fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/D150403

[PATCH] D150450: Add C++26 compile flags.

h-vetinari added inline comments. Comment at: clang/include/clang/Basic/LangStandard.h:128 + + // hasDigraphs - Language supports digraphs. bool hasDigraphs() const { return Flags & Digraphs; } Spuriously removed slash Comment at:

[PATCH] D150452: [clang-format] Recognize nested blocks

sstwcw abandoned this revision. sstwcw added a comment. I like D150403 better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150452/new/ https://reviews.llvm.org/D150452

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh accepted this revision. enh added a comment. This revision is now accepted and ready to land. (lgtm with craig.topper's suggested simplification.) Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530 + Triple.isAArch64() || Triple.isPS() || Triple.isVE()

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka updated this revision to Diff 521847. vitalybuka added a comment. use 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 Files: clang/include/clang/AST/Type.h

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no initialization of the data between allocation and first getBeginLoc call.

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530 + Triple.isAArch64() || Triple.isPS() || Triple.isVE() || + (Triple.isAndroid() && (Triple.getArch() == llvm::Triple::riscv64))); if (NoOmitFP ||

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

craig.topper added a comment. Is there more context on why Android enables the frame pointer? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521835. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { hiraditya wrote: > enh wrote: > > (where? is

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521833. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { enh wrote: > (where? is it simpler to just add

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 9c254184

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias added a comment. @HazardyKnusperkeks, thanks for the feedback. I added the TokenAnnotatorTests from @sstwcw's review. I also updated the design to use a single stack instead of the two parallel stacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias updated this revision to Diff 521828. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/D150403 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp clang/unittests/Format/TokenAnnotatorTest.cpp Index:

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6adb9a0602bc: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__` (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github

[clang] 6adb9a0 - [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__`

Author: Yaxun (Sam) Liu Date: 2023-05-12T18:50:52-04:00 New Revision: 6adb9a0602bcd75acd383e13c253e471edc9b189 URL: https://github.com/llvm/llvm-project/commit/6adb9a0602bcd75acd383e13c253e471edc9b189 DIFF:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { (where? is it simpler to just add arm64 to the

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521826. hiraditya added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c

[PATCH] D148654: Modify BoundsSan to improve debuggability

smeenai added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/BoundsChecking.cpp:189 auto GetTrapBB = [](BuilderTy ) { -if (TrapBB && SingleTrapBB) - return TrapBB; - -Function *Fn = IRB.GetInsertBlock()->getParent(); -// FIXME: This debug

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/BoundsChecking.cpp:189 auto GetTrapBB = [](BuilderTy ) { -if (TrapBB && SingleTrapBB) - return TrapBB; - -Function *Fn = IRB.GetInsertBlock()->getParent(); -// FIXME: This debug

[PATCH] D150492: [AST] Initialized local counter

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I assume it's optional and ReadAST does not have to set the counter on success. Repository: rG LLVM Github

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

stephenpeckham added a comment. Do the -U and -D flags have any effect on the behavior of llvm-ranlib? Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:16 + +## Test OBJECT_MODE environment variable when adding symbol table +# RUN: env OBJECT_MODE=32 llvm-ranlib

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:423 + if (Triple.isAndroid() && Triple.getArch() == llvm::Triple::riscv64) +return true; should this... Comment at: clang/lib/Driver/ToolChains/Clang.cpp:439

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya created this revision. hiraditya added reviewers: enh, danalbert, pirama, srhines. Herald added subscribers: VincentWu, danielkiss, vkmr, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. hiraditya

[clang] 7a0900f - [-Wunsafe-buffer-usage] Remove an unnecessary const-qualifier

Author: ziqingluo-90 Date: 2023-05-12T14:46:56-07:00 New Revision: 7a0900fd3e2d34bc1d513a97cf8fbdc1754252d7 URL: https://github.com/llvm/llvm-project/commit/7a0900fd3e2d34bc1d513a97cf8fbdc1754252d7 DIFF: https://github.com/llvm/llvm-project/commit/7a0900fd3e2d34bc1d513a97cf8fbdc1754252d7.diff

[PATCH] D148654: Modify BoundsSan to improve debuggability

nlopes added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/BoundsChecking.cpp:189 auto GetTrapBB = [](BuilderTy ) { -if (TrapBB && SingleTrapBB) - return TrapBB; - -Function *Fn = IRB.GetInsertBlock()->getParent(); -// FIXME: This debug

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:39 const PreprocessorOptions // Only used for debug info. -const CodeGenOptions CodeGenOpts; // Intentionally copied in. +CodeGenOptions CodeGenOpts; // Intentionally copied in.

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1787 case LMM_NoDirectory: return nullptr; We should probably `break` for `LMM_AlreadyLoaded` instead of returning null. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are situations

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When Clang loads a PCM

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo updated this revision to Diff 521781. mstorsjo added a comment. Updated to check for `defined(_WIN32) && !defined(__MINGW32__)`. It's a kinda ugly way of checking for an MSVC-like environment specifically (when the MSVC mode is the exception compared with the rest), but neither

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo added a comment. In D149997#4338304 , @rnk wrote: > I think `_MSC_EXTENSIONS` will work, but it's kind of gross. `_MSC_VER` is > controlled by `-fms-compatibility-verson=`, which I think is off by default > or unset at the cc1 level: >

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. In D150226#4338738 , @manojgupta wrote: >> I was under the impression from https://github.com/boostorg/mpl/issues/69 >> that this was fixed but there are a number of issues off of the main one and >> maybe I am confused. >

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D149562#4337955 , @sstwcw wrote: >> I'll go along with other reviewers on this one. > > So what do the other reviewers

[PATCH] D150452: [clang-format] Recognize nested blocks

HazardyKnusperkeks added a comment. On this change I like the token annotator tests, and reusing the same stack instead of adding a second one which always has the same size. But the code changes in D150403 seem to be better, at least I couldn't think directly

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

HazardyKnusperkeks added a comment. Shouldn't it have token annotator tests? Comment at: clang/lib/Format/UnwrappedLineParser.cpp:495-496 SmallVector LBraceStack; + // Track the previous token type corresponding to our lbraces // to help + // detect brace types +

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2385 + // sprintf(char *buffer, const char* format, ... /* format arguments */); + unsigned int format_arguments_start_idx = 3; + // snprintf case: one extra extra arguments

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay added inline comments. Comment at: clang/test/Driver/ftime-trace.cpp:54 +// RUN: %clang -### -ftime-trace=e -ftime-trace-granularity=0 d/a.cpp d/b.c -o f/x -dumpdir f/ 2>&1 | FileCheck %s --check-prefix=LINK3 +// LINK3: -cc1{{.*}} "-ftime-trace=e/a-{{[^.]*}}.json"

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

MaskRay added a comment. In D146054#4337866 , @kito-cheng wrote: > GCC ins't implement yet, but planed, so add it later I think? > > @4vtomat already drop -march=help, @MaskRay did you mind take a look again? Done. But this update still doesn't look

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga updated this revision to Diff 521767. oskarwirga added a comment. Add full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D148654: Modify BoundsSan to improve debuggability

smeenai added a reviewer: melver. smeenai added a comment. The patch should be uploaded with full context to make review easier. Adding another potential reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/

[PATCH] D150473: [clang/Driver] Also consider `gnu++` standard when checking for modules support

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150473 Files:

[clang] d66417f - [test] Fix ftime-trace.cpp on Windows

Author: Fangrui Song Date: 2023-05-12T12:23:30-07:00 New Revision: d66417f0ae9d6b5e1be9b80c0c3630601169818d URL: https://github.com/llvm/llvm-project/commit/d66417f0ae9d6b5e1be9b80c0c3630601169818d DIFF: https://github.com/llvm/llvm-project/commit/d66417f0ae9d6b5e1be9b80c0c3630601169818d.diff

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. > I was under the impression from https://github.com/boostorg/mpl/issues/69 > that this was fixed but there are a number of issues off of the main one and > maybe I am confused. Seems like boost 1.81 has the mentioned fix. I can try it and see if the warning still

[clang] 6d861d4 - [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

Author: ziqingluo-90 Date: 2023-05-12T11:50:51-07:00 New Revision: 6d861d498de1320d22771c329ec69f9419ef06b7 URL: https://github.com/llvm/llvm-project/commit/6d861d498de1320d22771c329ec69f9419ef06b7 DIFF: https://github.com/llvm/llvm-project/commit/6d861d498de1320d22771c329ec69f9419ef06b7.diff

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked an inline comment as done. Closed by commit rG6d861d498de1: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

dyung added inline comments. Comment at: clang/test/Driver/ftime-trace.cpp:54 +// RUN: %clang -### -ftime-trace=e -ftime-trace-granularity=0 d/a.cpp d/b.c -o f/x -dumpdir f/ 2>&1 | FileCheck %s --check-prefix=LINK3 +// LINK3: -cc1{{.*}} "-ftime-trace=e/a-{{[^.]*}}.json"

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

steakhal added a comment. I still struggle to see the motivation. Please consider adding a test demonstraing a case when the diagnostic is not relevant or easily misunderstood by the users. Alternatively, give an evaluation of this change so that I can see it myself. In the end it would still

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 marked an inline comment as done. ziqingluo-90 added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2364 + Node->getBeginLoc())) { + UnsafeBufferUsageReporter R(S); + clang::checkUnsafeBufferUsage(Node, R,

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. In D150291#4338118 , @tahonermann wrote: >> I do wonder if we need two bfloat implementations, but for that I'll leave a >> comment on D149573 . > > Given the discussions occurring in D149573

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 521743. erichkeane marked an inline comment as done. erichkeane added a comment. Added double-backticks, updated the tests for the new __cplusplus entries I changed during review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite updated this revision to Diff 521742. argentite marked an inline comment as done. argentite added a comment. Add some CUDA basic functionality tests. Disallow undo-ing of the initial PTU. This should fix the undo command test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. ping :) Any comments / questions / suggestions are welcome Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga added a comment. CC: @nlopes @chandlerc @jgalenson I have y'all added here because of your past work on BoundsSan, if you know of anyone else who may be able to provide review please tag them! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150450: Add C++26 compile flags.

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:114 +^ +- Compiler flags -std=c++2c and -std=gnu++2c have been added for experimental C++26 implementation work. + cor3ntin wrote: > This

[clang] dd02984 - [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

Author: Joseph Huber Date: 2023-05-12T13:14:27-05:00 New Revision: dd02984519abafe7637cdafcf4ede8b303f385ab URL: https://github.com/llvm/llvm-project/commit/dd02984519abafe7637cdafcf4ede8b303f385ab DIFF: https://github.com/llvm/llvm-project/commit/dd02984519abafe7637cdafcf4ede8b303f385ab.diff

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd02984519ab: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder (authored by jhuber6). Repository: rG LLVM Github

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

gchatelet added a comment. In D150461#4338499 , @jhuber6 wrote: > In D150461#4338498 , @gchatelet > wrote: > >> quick question, did you try to build the openmp runtime as well to check if >> the tests still

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

qianzhen added a comment. This is useful in keeping the static variables in a patchable function (https://clang.llvm.org/docs/AttributeReference.html#patchable-function-entry), so that they can be directly addressed by a hot patch when the optimization to merge them is enabled

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

jhuber6 added a comment. In D150461#4338498 , @gchatelet wrote: > quick question, did you try to build the openmp runtime as well to check if > the tests still pass? I'm an OpenMP developer so I always have it built : ). Yes they still pass.

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

gchatelet added a comment. quick question, did you try to build the openmp runtime as well to check if the tests still pass? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150461/new/ https://reviews.llvm.org/D150461

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

gchatelet accepted this revision. gchatelet added a comment. You beat me to it :) Thx for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150461/new/ https://reviews.llvm.org/D150461 ___

[PATCH] D150452: [clang-format] Recognize nested blocks

galenelias added a comment. Coincidentally I also sent out a review to fix this issue yesterday, but went with a different approach of trying to scope the ProbablyBracedList logic by just looking at the lbrace previous token. https://reviews.llvm.org/D150403 Repository: rG LLVM Github

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias added a subscriber: sstwcw. galenelias added a comment. Looks like @sstwcw also submitted a fix for the same issue, with a bit of a different approach: https://reviews.llvm.org/D150452 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49b87b05726b: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir (authored by MaskRay). Repository: rG LLVM Github Monorepo

[clang] 49b87b0 - [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

Author: Fangrui Song Date: 2023-05-12T10:46:06-07:00 New Revision: 49b87b05726b4395503230c3d400f93c626e6dce URL: https://github.com/llvm/llvm-project/commit/49b87b05726b4395503230c3d400f93c626e6dce DIFF: https://github.com/llvm/llvm-project/commit/49b87b05726b4395503230c3d400f93c626e6dce.diff

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. In D150226#4336803 , @thesamesam wrote: > Adding to the concerns raised above, I don't think we're there yet. See > https://bugs.gentoo.org/buglist.cgi?quicksearch=enum-constexpr-conversion_id=6843355 > and keep in mind that a

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:274 LANGOPT(OffloadingNewDriver, 1, 0, "use the new driver for generating offloading code.") +ENUM_LANGOPT(AMDGPUPrintfKindVal, AMDGPUPrintfKind, 2, AMDGPUPrintfKind::Buffered, "printf

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__`

yaxunl updated this revision to Diff 521714. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Matt's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145343/new/ https://reviews.llvm.org/D145343 Files:

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

jhuber6 added a comment. Where does the runtime implementation of this live? I'm not very familiar with the HIP / hostcall ecosystem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. In D150226#4336771 , @manojgupta wrote: > We also use Wno-enum-constexpr-conversion in ChromeOS. There are many > packages that break with this warning. One of them is boost which is used in > many other packages. > > The

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

rnk added a comment. In D149997#4337548 , @mstorsjo wrote: > So, the reason why this failed, is that when invoked as `%clang_cc1` in a > MSVC/clang-cl style build, `_MSC_VER` isn't predefined, while `_WIN32` is. > When invoked via the Clang driver

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150461/new/ https://reviews.llvm.org/D150461

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ABataev, JonChesterfield, tstellar, gchatelet. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers:

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. In D150226#4336755 , @rupprecht wrote: > We're still using `-Wno-enum-constexpr-conversion`, although I'm not sure if > we need that or if we just forgot to remove it after doing some cleanup. I'm > trying it out now. (Sorry,

[PATCH] D150450: Add C++26 compile flags.

cor3ntin accepted this revision. cor3ntin added a comment. LGTM. I'm looking forward to start implementing upcoming proposals CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 ___ cfe-commits mailing

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 521688. erichkeane added a comment. Updated last few things @Mordante mentioned, did a rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs marked an inline comment as done. codemzs added a comment. In D149573#4337480 , @stuij wrote: > I made a comment on the RFC > > to understand

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:1036 + NormalizedValues<["Hostcall", "Buffered"]>, + MarshallingInfoEnum, "Hostcall">; def fgpu_default_stream_EQ : Joined<["-"], "fgpu-default-stream=">, as a target option,

[PATCH] D150450: Add C++26 compile flags.

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. In D150450#4338065 , @erichkeane wrote: > In D150450#4338034 , @Mordante > wrote: > >> In

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

yaxunl added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:274 LANGOPT(OffloadingNewDriver, 1, 0, "use the new driver for generating offloading code.") +ENUM_LANGOPT(AMDGPUPrintfKindVal, AMDGPUPrintfKind, 2, AMDGPUPrintfKind::Buffered, "printf

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. > I do wonder if we need two bfloat implementations, but for that I'll leave a > comment on D149573 . Given the discussions occurring in

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__`

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:146 +return false; + return TargetFeature == "no-cumode"; +} yaxunl wrote: > arsenm wrote: > > I don't understand the use of "no-cumode". Where is this defined? > This

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 521680. erichkeane added a comment. Added clang-cl versioning as stolen from @Mordante CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst

[PATCH] D150450: Add C++26 compile flags.

erichkeane added a comment. In D150450#4338034 , @Mordante wrote: > In D150450#4337952 , @erichkeane > wrote: > >> In D150450#4337858 , @cor3ntin >> wrote: >> >>>

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 521675. erichkeane marked an inline comment as done. erichkeane added a comment. fix init-preprocessor, remove fixme. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files:

[PATCH] D150450: Add C++26 compile flags.

Mordante added a comment. In D150450#4337952 , @erichkeane wrote: > In D150450#4337858 , @cor3ntin > wrote: > >> Similar PR here https://reviews.llvm.org/D149875 > > Ah! I'd not noticed that one (or maybe

[PATCH] D150452: [clang-format] Recognize nested blocks

sstwcw updated this revision to Diff 521667. sstwcw added a comment. - Remove the special case for operator[], it isn't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150452/new/ https://reviews.llvm.org/D150452 Files:

[PATCH] D150063: [clang] Restores some -std=c++2b tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd556368a1a8: [clang] Restores some -std=c++2b tests. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150063/new/

[clang] fd55636 - [clang] Restores some -std=c++2b tests.

Author: Mark de Wever Date: 2023-05-12T17:44:59+02:00 New Revision: fd556368a1a85eda27c2490331646b2913f16527 URL: https://github.com/llvm/llvm-project/commit/fd556368a1a85eda27c2490331646b2913f16527 DIFF: https://github.com/llvm/llvm-project/commit/fd556368a1a85eda27c2490331646b2913f16527.diff

  1   2   >