[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz added a comment. For a quick peek to the hint: F27483170: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150635/new/ https://reviews.llvm.org/D150635

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz added a comment. @zyounan np! Feel free to leave your review comments! @sammccall Thank you for you insightful and detailed review! I addressed many review comments in the updated patch and left things I'm not very sure. Regarding to **Naming**, I agree that `EndDefinitionComment`

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

phosek created this revision. phosek added a reviewer: Amir. Herald added subscribers: treapster, ayermolo, abrachet. Herald added a reviewer: rafauler. Herald added a reviewer: maksfb. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz updated this revision to Diff 522898. daiyousei-qz marked 16 inline comments as done. daiyousei-qz added a comment. - addressed many review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150635/new/

[PATCH] D150740: [clang] Add `__attribute__((nooutline))`

paquette updated this revision to Diff 522894. paquette added a comment. Also support blocks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150740/new/ https://reviews.llvm.org/D150740 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D150740: [clang] Add `__attribute__((nooutline))`

paquette added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1474 + let Spellings = [Clang<"nooutline">]; + let Subjects = SubjectList<[Function, ObjCMethod]>; + let Documentation = [NoOutlineDocs]; jroelofs wrote: > does it make sense on

[PATCH] D150723: clang/openmp: Fix alignment for ThreadID Address variables

jlpeyton accepted this revision. jlpeyton added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150723/new/ https://reviews.llvm.org/D150723

[PATCH] D150632: [IR] Adds Instruction::setNoSanitizeMetadata()

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/include/llvm/IR/Instruction.h:353 + /// Sets the nosanitize metadata on this instruction. + void setNoSanitizeMetadata();

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM I find it a little odd that we have if you include cpuid.h you get the gcc interface for __cpuid and the MSVC interface for __cpuidex. But gcc did it first so I guess we

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

craig.topper added a comment. For MSVC compatibility this was already implemented as a builtin for intrin.h in https://reviews.llvm.org/D121653 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150646/new/ https://reviews.llvm.org/D150646

[PATCH] D150632: [IR] Adds Instruction::setNoSanitizeMetadata()

Enna1 updated this revision to Diff 522884. Enna1 added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150632/new/ https://reviews.llvm.org/D150632 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna updated this revision to Diff 522877. Herald added subscribers: steakhal, martong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Parse/Parser.h

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx created this revision. AlexVlx added reviewers: aaron.ballman, yaxunl. Herald added subscribers: arichardson, tpr. Herald added a project: All. AlexVlx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When lowering from a HLL that

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna created this revision. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h

[PATCH] D150730: [Clang][Sema] Substitute constraints only for declarations with different lexical contexts

alexander-shaposhnikov updated this revision to Diff 522856. alexander-shaposhnikov added a comment. Include context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150730/new/ https://reviews.llvm.org/D150730 Files:

[PATCH] D150723: clang/openmp: Fix alignment for ThreadID Address variables

tstellar updated this revision to Diff 522853. tstellar added a comment. Add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150723/new/ https://reviews.llvm.org/D150723 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang added a comment. In D137872#4327615 , @efriedma wrote: > I'm having a bit of trouble following how exactly the thunk creation is > working here... do we generate different code depending on whether the call > operator and/or the static invoker

[PATCH] D150740: [clang] Add `__attribute__((nooutline))`

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/Attr.td:1474 + let Spellings = [Clang<"nooutline">]; + let Subjects = SubjectList<[Function, ObjCMethod]>; + let

[PATCH] D150740: [clang] Add `__attribute__((nooutline))`

paquette created this revision. paquette added reviewers: fhahn, aemerson, jroelofs, arphaman, ahatanak. paquette added a project: clang. Herald added a reviewer: aaron.ballman. Herald added a subscriber: StephenFan. Herald added a project: All. paquette requested review of this revision.

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150492: [AST] Initialize local counter

bnbarham accepted this revision. bnbarham added inline comments. Comment at: clang/lib/Frontend/ASTUnit.cpp:825 HeaderSearch = *AST->HeaderInfo; - unsigned Counter; > I assume it's optional and ReadAST does not have to set the counter on > success.

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci updated this revision to Diff 522829. denizevrenci added a comment. Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/ https://reviews.llvm.org/D147417 Files:

[PATCH] D150730: [Clang][Sema] Substitute constraints only for declarations with different lexical contexts

shafik added a comment. Can you please add context to the diff. thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150730/new/ https://reviews.llvm.org/D150730 ___ cfe-commits mailing list

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

samitolvanen accepted this revision. samitolvanen added a comment. This revision is now accepted and ready to land. Looks good to me, but maybe worth waiting for someone more familiar with compiler-rt to take a look as well. Comment at:

[PATCH] D150492: [AST] Initialize local counter

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. Not my area, but the change is trivial. Nit: could move the variable closer to its use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 522826. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analysis/Analyses/Consumed.h

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. So the problem is that `CMakePolicy.cmake` is not included in `compiler-rt/CMakeLists.txt`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay added a comment. In D148785#4348053 , @vitalybuka wrote: > Is possible to split the patch into smaller ones? The Clang CodeGen side needs to match `llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp` and `compiler-rt/lib/ubsan`, so no, I think this

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

aaronpuchert added a comment. I'd probably abstain from explicitly deleting what is already implicitly deleted, but otherwise this looks good to me. Thanks! Comment at: clang/include/clang/Sema/Sema.h:1790 SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default; +

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1789-1791 +SemaDiagnosticBuilder =(SemaDiagnosticBuilder &) = delete; SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default; +SemaDiagnosticBuilder =(const SemaDiagnosticBuilder &) =

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 522821. Manna marked 3 inline comments as done. Manna added a comment. Thanks @tahonermann for your reviews and feedbacks. I have addressed your review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/

[PATCH] D150492: [AST] Initialize local counter

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150492/new/ https://reviews.llvm.org/D150492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

vitalybuka added a comment. Is possible to split the patch into smaller ones? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 ___ cfe-commits mailing list

[PATCH] D150629: [clang-format] Don't allow template to be preceded by closing brace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4d3e8880239: [clang-format] Dont allow template to be preceded by closing brace (authored by rymiel). Repository: rG LLVM Github Monorepo

[clang] e4d3e88 - [clang-format] Don't allow template to be preceded by closing brace

Author: Emilia Kond Date: 2023-05-17T01:37:19+03:00 New Revision: e4d3e88802390a51ae62ade18e48c1a65a862d12 URL: https://github.com/llvm/llvm-project/commit/e4d3e88802390a51ae62ade18e48c1a65a862d12 DIFF: https://github.com/llvm/llvm-project/commit/e4d3e88802390a51ae62ade18e48c1a65a862d12.diff

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7983f8aca82e: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple (authored by wzssyqa, committed by MaskRay). Repository: rG LLVM

[clang] 7983f8a - MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

Author: YunQiang Su Date: 2023-05-16T15:31:37-07:00 New Revision: 7983f8aca82e258174849f1cc6a70029353e9887 URL: https://github.com/llvm/llvm-project/commit/7983f8aca82e258174849f1cc6a70029353e9887 DIFF: https://github.com/llvm/llvm-project/commit/7983f8aca82e258174849f1cc6a70029353e9887.diff

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. It's related, though, because now that I look at my build logs, the difference between when it works and when it doesn't is `/MT` vs `-MD` when compiler-rt is compiled. The main peculiarity on our end, though, is that the Windows compiler-rt is cross-compiled.

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

wzssyqa added a comment. In D146269#4347514 , @MaskRay wrote: > Is this the new GCC behavior? Marking o32 objects with 64bit CPU is a long history gas behaviour, maybe appeared in 1990s, or even in the era of Irix. I guess the reason is that to achive

[PATCH] D148723: [clang] Enforce external linkage for inline builtin original declaration

efriedma added a comment. Is there some reason we actually need to do this whole dance in C++? The whole point of "inline builtins" was to handle constructs in the glibc headers that involve implementations of libc functions that somehow end up recursively calling themselves instead of a real

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. In D144509#4347604 , @mstorsjo wrote: > See D150688 - I believe that might fix the > issue you're seeing, as that one mentions compiler-rt. Unfortunately, it doesn't. FWIW, the errors looks

[PATCH] D150733: [clang] Convert remaining OpenMP tests to opaque pointers

barannikov88 added a comment. These are the last tests in OpenMP subdirectory. Comment at: clang/test/OpenMP/target_simd_codegen.cpp:143 - // CHECK: call void [[HVT1:@.+]](i[[SZ]] {{[^,]+}}, i{{32|64}}{{[*]*}} {{[^)]+}}) + // CHECK: call void

[PATCH] D150733: [clang] Convert remaining OpenMP tests to opaque pointers

barannikov88 created this revision. barannikov88 added a reviewer: nikic. Herald added subscribers: sunshaoce, StephenFan, guansong, yaxunl. Herald added a project: All. barannikov88 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits,

[PATCH] D150694: [clang] Convert NVPTX OpenMP tests to opaque pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG9beb817cc8db: [clang] Convert NVPTX OpenMP tests to opaque pointers (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150694/new/

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. @rjmccall Made a bit of progress on this, but still not quite where it should be! Would appreciate your feedback/guidance to see that's moving in the right direction. Not sure about lazily creating the interesting identifiers? There are still some LIT tests failing

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 522800. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. I added a few comments and suggested edits, but this is mostly looking good. Comment at: clang/include/clang/Sema/Sema.h:1790

[PATCH] D150730: [Clang][Sema] Substitute constraints only for declarations with different lexical contexts

alexander-shaposhnikov created this revision. alexander-shaposhnikov added a reviewer: erichkeane. alexander-shaposhnikov created this object with visibility "All Users". Herald added a project: All. alexander-shaposhnikov requested review of this revision. Herald added a project: clang. Herald

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

efriedma added a comment. > This is an adaptation of the IBM XL compiler's -qstatsym option, which is > meant to generate symbol table entries for static variables. An artifact of > that compiler is that static variables are often not discarded even when > unused. Oh, I see; the compiler

[PATCH] D124642: [WIP] Add support for return from an SEH __finally block.

efriedma updated this revision to Diff 522782. efriedma added a comment. Fixup a couple LLVM tests which are failing; I think they're affected by the WinException.cpp changes? Maybe need to look a bit more closely to see if the changes make sense. Repository: rG LLVM Github Monorepo

[PATCH] D150723: clang/openmp: Fix alignment for ThreadID Address variables

arsenm added a comment. Needs test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150723/new/ https://reviews.llvm.org/D150723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150723: clang/openmp: Fix alignment for ThreadID Address variables

tstellar created this revision. tstellar added a reviewer: jlpeyton. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. tstellar requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald

[PATCH] D150629: [clang-format] Don't allow template to be preceded by closing brace

rymiel updated this revision to Diff 522776. rymiel added a comment. Add annotator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150629/new/ https://reviews.llvm.org/D150629 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D124642: [WIP] Add support for return from an SEH __finally block.

efriedma updated this revision to Diff 522773. efriedma added a comment. Herald added a subscriber: arichardson. Rebased so it builds, and added a couple tests, to unblock anyone wanting to look at this further. Haven't re-done my runtime testing. Still haven't addressed all the review

[PATCH] D124642: [WIP] Add support for return from an SEH __finally block.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:1833 +/// Find all local variable captures in the statement. +struct ReturnStmtFinder : ConstStmtVisitor { + bool ContainsRetStmt = false; rnk wrote: > We have the option to

[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10490 +def warn_omp_minus_in_reduction_deprecated : Warning< + "minus(-) operator for reductions is deprecated; use an user defined reduction instead">, + InGroup;

[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

tra created this revision. Herald added subscribers: mattd, carlosgalvezp, bixia, yaxunl. Herald added a project: All. tra added reviewers: jlebar, yaxunl. tra published this revision for review. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Allow parsing GPU-side

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

mstorsjo added a comment. In D144509#4347562 , @glandium wrote: > FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c > is > causing problems on Windows compiler-rt for some reason I

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. Herald added subscribers: bviyer, ekilmer, jplehr. FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c is causing problems on Windows compiler-rt for some reason I haven't identified yet (with cmake

[PATCH] D150539: [clang-format] Handle ud suffixes in IntegerLiteralSeparator

This revision was automatically updated to reflect the committed changes. Closed by commit rGa72b064acf95: [clang-format] Handle chrono ud suffixes in IntegerLiteralSeparator (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a72b064 - [clang-format] Handle ud suffixes in IntegerLiteralSeparator

Author: Owen Pan Date: 2023-05-16T13:17:31-07:00 New Revision: a72b064acf9546ee41c67c77ed8662d5d3b2fadc URL: https://github.com/llvm/llvm-project/commit/a72b064acf9546ee41c67c77ed8662d5d3b2fadc DIFF: https://github.com/llvm/llvm-project/commit/a72b064acf9546ee41c67c77ed8662d5d3b2fadc.diff

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

MaskRay added a comment. Is this the new GCC behavior? > `clang -target mipsel-linux-gnu -mabi=64` Use `--target=` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 ___ cfe-commits mailing list

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

aaron.ballman added a comment. In D148276#4324314 , @sousajo wrote: > have been sick, and could not advance much except I added the tests to > replicate the issue. Any ideas on how to proceed here? Sorry to hear you've been sick, but thank you for your

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20136 "#ifdef _DEBUG\n" - "void bar()\n" - " {\n" - " }\n" + "void bar() {}\n" "#else\n"

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20136 "#ifdef _DEBUG\n" - "void bar()\n" - " {\n" - " }\n" + "void bar() {}\n" "#else\n"

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

steakhal added a comment. In D150430#4347365 , @ArnaudBienner wrote: > Thanks for the review :) > > I implemented the suggested changes. > > Just one question: `PointeeTy.isNull()`: is this guaranteed to always work > even though

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner added a comment. Thanks for the review :) I implemented the suggested changes. Just one question: `PointeeTy.isNull()`: is this guaranteed to always work even though `getType()->isAnyPointerType() == false`? I'm assuming yes since the tests still pass, but wanted to confirm this

[PATCH] D150694: [clang] Convert NVPTX OpenMP tests to opaque pointers

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150694/new/ https://reviews.llvm.org/D150694 ___

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner updated this revision to Diff 522738. ArnaudBienner added a comment. - Code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/ https://reviews.llvm.org/D150430 Files:

[PATCH] D150704: [clang] Convert several smaller OpenMP tests to opaque pointers

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150704/new/ https://reviews.llvm.org/D150704 ___

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

HazardyKnusperkeks added a comment. In D150403#4343708 , @galenelias wrote: > Thanks @HazardyKnusperkeks! I don't have commit access, so will need someone > to land this for me. We'll wait a bit, if someone might have a comment. And (at least I) need

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20136 "#ifdef _DEBUG\n" - "void bar()\n" - " {\n" - " }\n" + "void bar() {}\n" "#else\n"

[PATCH] D150629: [clang-format] Don't allow template to be preceded by closing brace

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:10682 verifyFormat("a < 0 ? b : a > 0 ? c : d;"); + verifyFormat("ratio{-1, 2} < ratio{-1, 3} == -1 / 3 > -1 / 2;"); verifyFormat("void f() {\n" owenpan wrote: >

[PATCH] D150704: [clang] Convert several smaller OpenMP tests to opaque pointers

barannikov88 added a comment. target_map_codegen_34.cpp was converted manually. I think I got it right, but I'm not 100% sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150704/new/ https://reviews.llvm.org/D150704

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir abandoned this revision. Amir added a comment. Herald added a subscriber: ekilmer. No longer needed for Clang-BOLT. @thevinster – feel free to commandeer if it fits your needs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/

[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

mdfazlay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10490 +def warn_omp_minus_in_reduction_deprecated : Warning< + "minus(-) operator for reductions is deprecated; use an user defined reduction instead">, + InGroup;

[PATCH] D150668: Add doc link to missing include diagnostics.

thakis added a comment. For the records: Fixed in 76941b68ecd9 . Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150668/new/

[PATCH] D150531: Fix start index for sprintf ovlerap check + tests

ArnaudBienner abandoned this revision. ArnaudBienner added a comment. Sorry about creating a new patch instead of updating the existing one. Closing that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150531/new/

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

dschuff added a comment. FWIW X86 seems to do something similar elsewhere in this file (https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGBuiltin.cpp#L985-L986), although it doesn't seem common otherwise. I think I'd be OK with this approach (and it does seem better than

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146389/new/ https://reviews.llvm.org/D146389

[PATCH] D150694: [clang] Convert NVPTX OpenMP tests to opaque pointers

barannikov88 updated this revision to Diff 522718. barannikov88 added a comment. Update failing checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150694/new/ https://reviews.llvm.org/D150694 Files: clang/test/OpenMP/nvptx_SPMD_codegen.cpp

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite updated this revision to Diff 522717. argentite added a comment. Update the filenames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146389/new/ https://reviews.llvm.org/D146389 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 522714. Prabhuk added a comment. Addressing Petr's comments. Adding buildLinker initial draft for UEFI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files:

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. rebased and added helper function as recommended, in recent update! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://reviews.llvm.org/D149162 ___ cfe-commits

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon updated this revision to Diff 522710. agozillon added a comment. - [Clang][OpenMP][IRBuilder] Tidy up function calls with helpful reviewer advice - [Clang][OpenMP][IRBuilder] Replace all getTargetEntryUniqueInfo with IRBuilder version - [Clang][OpenMP][IRBuilder] Run clang-format and

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LG with a request for an additional test. Comment at: clang/lib/AST/Interp/Interp.cpp:390 - if (isa(ElemType.getTypePtr())) { + if

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

MaskRay added a comment. This seems fine, but please consider making `MC/SubtargetFeature.h` a forwarding header temporarily. Our official build system CMake doesn't do layering checking for headers (https://llvm.org/docs/CodingStandards.html#library-layering). Our unofficial build system

[PATCH] D150647: [WIP][analyzer] Fix EnumCastOutOfRangeChecker C++17 handling

gamesh411 added a comment. In D150647#4345345 , @steakhal wrote: >> In C++17 the initialization rules for enum classes are relaxed. > > In what way are they relaxed compared to regular enums? The initialization rules are relaxed compared to their

[PATCH] D150694: [clang] Convert NVPTX OpenMP tests to opaque pointers

barannikov88 planned changes to this revision. barannikov88 added a comment. Nah, they need some hand work after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150694/new/ https://reviews.llvm.org/D150694

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm marked an inline comment as done. rsandifo-arm added a comment. Thanks @erichkeane . Adding the documentation with that kind of disclaimer sounds good to me. I've done that in the updated version, and also fixed the comment problem that Aaron pointed out. Repository: rG LLVM

[clang] 92b8ed6 - Correct documentation for -fconstexpr-depth=

Author: Aaron Ballman Date: 2023-05-16T13:42:25-04:00 New Revision: 92b8ed6e5e5dc921c611eae4160570f169657030 URL: https://github.com/llvm/llvm-project/commit/92b8ed6e5e5dc921c611eae4160570f169657030 DIFF: https://github.com/llvm/llvm-project/commit/92b8ed6e5e5dc921c611eae4160570f169657030.diff

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm updated this revision to Diff 522703. rsandifo-arm added a comment. Add documentation. Fix a comment cut-&-pasto that Aaron pointed out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148700/new/ https://reviews.llvm.org/D148700

[PATCH] D150694: [clang] Convert NVPTX OpenMP tests to opaque pointers

barannikov88 added a comment. These were completely handled by the script except that I manually renumbered basic blocks in the large SIMD test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150694/new/ https://reviews.llvm.org/D150694

[PATCH] D150694: [clang] Convert NVPTX OpenMP tests to opaque pointers

barannikov88 created this revision. barannikov88 added a reviewer: nikic. Herald added subscribers: sunshaoce, mattd, gchakrabarti, asavonic, StephenFan, guansong, yaxunl. Herald added a project: All. barannikov88 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D148614: [clang][Interp] Add frame depth checking

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though I would appreciate adding the other test case from my comments since it's interesting behavior. Comment at:

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:717-723 +Value *SubExprVal = Env.getValueStrict(*SubExpr); +if (SubExprVal == nullptr) return; -Env.setStorageLocation(*S,

[PATCH] D148614: [clang][Interp] Add frame depth checking

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:345-352 + if ((S.Current->getDepth() + 1) > S.getLangOpts().ConstexprCallDepth) { +S.FFDiag(S.Current->getSource(OpPC), + diag::note_constexpr_depth_limit_exceeded) +<<

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

efriedma added a comment. > I'd really want to look at IR for return inside try/finally, but for some > reason, I an not build compiler with your patch: no member named > 'setHasAddressTaken' in 'llvm::MachineBasicBlock'; did you mean > 'hasAddressTaken'. I may missing some thing in my

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. In D143967#4346934 , @dfaust wrote: > In D143967#4343841 , @eddyz87 wrote: > >> Changes to avoid attaching type tags to DWARF derived types for >> const/volatile/restrict qualifiers. > >

[PATCH] D150690: [RISCV] Use IRBuilder::CreateInsertVector/CreateExtractVector to simplify code. NFC

craig.topper updated this revision to Diff 522690. craig.topper added a comment. Update more intrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150690/new/ https://reviews.llvm.org/D150690 Files: clang/include/clang/Basic/riscv_vector.td

  1   2   3   >