[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:578 +constexpr unsigned HintMinLineLimit = 2; +constexpr unsigned HintMaxLengthLimit = 50; + nridge wrote: > daiyousei-qz wrote: > > sammccall wrote: > > > We

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

dyung added a comment. In D145739#4370674 , @barannikov88 wrote: > Hi, just a heads-up, some bots seem to be unhappy with the test: > > https://lab.llvm.org/buildbot/#/builders/216/builds/21765 > > error: 'note' diagnostics expected but not seen: >

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 lines breaks in inline asm

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:361 +(Style.BreakBeforeInlineASMColon == FormatStyle::BBIAS_OnlyMultiline && + Style.ColumnLimit != 0 { return true;

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 updated this revision to Diff 525431. evelez7 marked 8 inline comments as done. evelez7 added a comment. Address some review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151293/new/ https://reviews.llvm.org/D151293 Files:

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

smeenai updated this revision to Diff 525429. smeenai added a comment. Call SetLLVMFunctionAttributesForDefinition instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151393/new/ https://reviews.llvm.org/D151393 Files:

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

xazax.hun added a comment. I generally support the idea of a CXXLifetimeExtendedObj region, definitely cleaner than a CXXTempObjectRegion with static lifetime. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

efriedma added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4698 +if (CodeGenOpts.UnwindTables) + fn->setUWTableKind(llvm::UWTableKind(CodeGenOpts.UnwindTables)); + We probably want to call SetLLVMFunctionAttributesForDefinition()

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:1365 defm vaaddu : RISCVSaturatingBinaryAAX; - defm vaadd : RISCVSaturatingBinaryAAX; - defm vaadd_rm : RISCVSaturatingBinaryAAXRoundingMode; + defm vaadd :

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:578 +constexpr unsigned HintMinLineLimit = 2; +constexpr unsigned HintMaxLengthLimit = 50; + daiyousei-qz wrote: > sammccall wrote: > > We actually already have a

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 525425. junaire added a comment. Remove `Interpereter::getParser` + More clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files:

[PATCH] D151402: Address some review feedback

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Delete unnecessary includes, revert SymbolGraphSerializer

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz added a comment. Sorry for the inactivity. I have replace the parameter with const ref. By the way, I also removed the existing `IncludeInactiveRegionTokens` flag and uses this filter instead. Please help review the change. Thanks! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz updated this revision to Diff 525421. daiyousei-qz added a comment. - Address review comment and remove a unnecessary flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 Files:

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:434 + +llvm::Expected Interpreter::CompileDecl(Decl *D) { + assert(D && "The Decl being compiled can't be null"); aaron.ballman wrote: > Any way to make this take a `const Decl *`

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2131 +} + Extra blank line Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vaadd.c:16 // -vint8mf8_t

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 525420. junaire marked 15 inline comments as done. junaire added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files:

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

barannikov88 added a comment. Hi, just a heads-up, some bots seem to be unhappy with the test: https://lab.llvm.org/buildbot/#/builders/216/builds/21765 error: 'note' diagnostics expected but not seen: File

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

MaskRay accepted this revision. MaskRay added a comment. LGTM. Comment at: compiler-rt/docs/ASanABI.rst:15 + +... +void __asan_load1(uptr p) { __asan_abi_loadn(p, 1, true); } Delete `...`. Sample content implies that this is a code fragment and does

[PATCH] D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

jansvoboda11 added a comment. Herald added a subscriber: ributzka. TODO: Try rebasing this on top of D151398 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127647/new/ https://reviews.llvm.org/D127647

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz added a comment. Addressed review comments except for those we don't have an agreement yet. Comment at: clang-tools-extra/clangd/InlayHints.cpp:578 +constexpr unsigned HintMinLineLimit = 2; +constexpr unsigned HintMaxLengthLimit = 50; +

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz updated this revision to Diff 525418. daiyousei-qz marked 9 inline comments as done. daiyousei-qz added a comment. - Move computeBlockEndHintRange - Correct label length limit logic - Correct line number computation for '{' - Address other review comments Repository: rG LLVM

[PATCH] D151194: [clang][dataflow] Add support for return values of reference type.

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:196 + void popCall(const CallExpr *Call, const Environment ); + void popCall(const CXXConstructExpr *Call, const Environment );

[PATCH] D151201: [clang][dataflow] Fix a crash in `getLogicOperatorSubExprValue()`.

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:5064 +bool target() { + return true || false || false || false; +} Should we also test that the value of the expression is `true` in the analysis

[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:39 + /// Builds a ControlFlowContext from an

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD updated this revision to Diff 525413. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D151398: [clang] Make `FileEntryRef::getDir()` return the as-requested `DirectoryEntryRef`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham, rmaz. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For redirected

[PATCH] D151281: [NFC][CLANG] Fix issue with dereference null return value found by Coverity

This revision was automatically updated to reflect the committed changes. Closed by commit rGad571e0d84b3: [NFC][CLANG] Fix issue with dereference null return value found by Coverity (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ad571e0 - [NFC][CLANG] Fix issue with dereference null return value found by Coverity

Author: Manna, Soumi Date: 2023-05-24T19:17:03-07:00 New Revision: ad571e0d84b30f73fa36d6694c66d5b0fb896f97 URL: https://github.com/llvm/llvm-project/commit/ad571e0d84b30f73fa36d6694c66d5b0fb896f97 DIFF: https://github.com/llvm/llvm-project/commit/ad571e0d84b30f73fa36d6694c66d5b0fb896f97.diff

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

smeenai created this revision. smeenai added reviewers: efriedma, jyknight, rnk, MaskRay. Herald added a subscriber: kristof.beyls. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables debuggers

[PATCH] D139267: Supporting tbaa.struct metadata generation for bitfields

strimo378 updated this revision to Diff 525387. strimo378 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Updated a test case - Supporting correct output for -new-struct-path-tbaa - Added a paragraph to LangRef.rst (see

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 525388. Manna added a comment. Thank you @erichkeane for reviews! I have updated assert message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151280/new/ https://reviews.llvm.org/D151280 Files: clang/lib/CodeGen/CGExprConstant.cpp Index:

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

efriedma added a comment. > It makes sense to me that const int foo[] = [ ...massive list...]; would take > long to validate the entire initializer as all constant expressions The expensive part we're currently avoiding by bailing out of the constant evaluator (the code D76169

[PATCH] D151235: [Clang] Switch from TransformExpr to TransformInitializer in places we need to revert initializer to it syntactic form for Sema

shafik marked 2 inline comments as done. shafik added inline comments. Comment at: clang/test/CodeGenCXX/gh62818.cpp:1 +// RUN: %clang_cc1 -no-opaque-pointers -std=c++17 -emit-llvm -triple x86_64-linux-gnu -o - %s | FileCheck %s + Fznamznon wrote: > Why no

[PATCH] D151235: [Clang] Switch from TransformExpr to TransformInitializer in places we need to revert initializer to it syntactic form for Sema

shafik updated this revision to Diff 525385. shafik added a comment. - Update test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151235/new/ https://reviews.llvm.org/D151235 Files: clang/lib/Sema/TreeTransform.h clang/test/Analysis/missing-bind-temporary.cpp

[PATCH] D151281: [NFC][CLANG] Fix issue with dereference null return value found by Coverity

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151281/new/ https://reviews.llvm.org/D151281 ___ cfe-commits mailing list

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150504: [AST] Construct Capture objects before use

This revision was automatically updated to reflect the committed changes. Closed by commit rG8826cd57825d: [AST] Construct Capture objects before use (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150504/new/

[clang] 8826cd5 - [AST] Construct Capture objects before use

Author: Vitaly Buka Date: 2023-05-24T17:09:45-07:00 New Revision: 8826cd57825d829121ad7fb73fab0a6cf30f29f6 URL: https://github.com/llvm/llvm-project/commit/8826cd57825d829121ad7fb73fab0a6cf30f29f6 DIFF: https://github.com/llvm/llvm-project/commit/8826cd57825d829121ad7fb73fab0a6cf30f29f6.diff

[PATCH] D151388: [HWASan] use hwasan linker for Android 14+

fmayer created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. fmayer requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This will allow to compile binaries that use hwasan to run on a non-HWASan

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee6b08e99375: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments (authored by t-rasmud). Herald added a project: clang.

[clang] ee6b08e - [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

Author: Rashmi Mudduluru Date: 2023-05-24T16:20:55-07:00 New Revision: ee6b08e99375fc48d1e5848704a66c2e8e57eb3b URL: https://github.com/llvm/llvm-project/commit/ee6b08e99375fc48d1e5848704a66c2e8e57eb3b DIFF:

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers added a comment. So, @rsmith are you ok with a patch like https://reviews.llvm.org/D76169 that removes those fixmes? It makes sense to me that `const int foo[] = [ ...massive list...];` would take long to validate the entire initializer as all constant expressions, but I'm

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 525359. chaitanyav added a comment. Reuse diag code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 Files:

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

Eugene.Zelenko added a comment. Please extend test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 ___ cfe-commits mailing list

[PATCH] D151383: Check for specific return types on all functions

chaitanyav added a comment. @royjacobson Please list other types that must be included here. The tests are coming... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383

[PATCH] D151383: Check for specific return types on all functions

chaitanyav created this revision. chaitanyav added a reviewer: royjacobson. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

sbc100 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1984 + TargetSpecificAttr { + let Spellings = [Clang<"wasm_async">]; + let Documentation = [WebAssemblyAsyncDocs]; brendandahl wrote: > sbc100 wrote: > > Should

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

brendandahl added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1984 + TargetSpecificAttr { + let Spellings = [Clang<"wasm_async">]; + let Documentation = [WebAssemblyAsyncDocs]; sbc100 wrote: > Should we call this

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

brendandahl updated this revision to Diff 525348. brendandahl marked 5 inline comments as done. brendandahl added a comment. Review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files:

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. This went through a few rounds of testing on our internal benchmarks and it's at a point where there are no meaningful run-time regressions observed, but the compile-time improvements

[PATCH] D151362: [CUDA] Add CUDA wrappers over clang builtins for sm_90.

tra created this revision. Herald added subscribers: mattd, bixia, yaxunl. Herald added a project: All. tra updated this revision to Diff 525338. tra added a comment. tra updated this revision to Diff 525340. tra published this revision for review. tra added a reviewer: jlebar. Herald added a

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

cor3ntin added a comment. Give some time for @tahonermann to have an opportunity to review again, but otherwise this looks good to me. Thanks! Comment at: clang/lib/Frontend/TextDiagnostic.cpp:124-128 + if (CharSize == 1 && llvm::isLegalUTF8Sequence(Begin, End) && +

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525333. HerrCai0907 added a comment. change solution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

MaskRay accepted this revision. MaskRay added a comment. LGTM. Comment at: clang/test/CodeGen/ubsan-function.cpp:4 // RUN: %clang_cc1 -triple aarch64_be-linux-gnu -emit-llvm -o - %s -fsanitize=function -fno-sanitize-recover=all | FileCheck %s +// RUN: %clang_cc1 -triple

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

MaskRay added a comment. In D151308#4367704 , @peter.smith wrote: > This looks good to me. Will be worth waiting for a day to give the US time > zone time to leave any comments. Thanks! > I note that this is also broken in -fsanitize=kcfi [*] >

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

fridtjof created this revision. fridtjof added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. fridtjof requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables easy consumption of arbitrary

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono added a comment. Heh, ok, so I wasn't that naive then to not run the tests of everything :-) I had a look at the issue. The ClangRenameTests first do some replacements, and then call formatAndApplyReplacements()

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao added a comment. In D151162#4369584 , @aaron.ballman wrote: > Please be sure to add a release note for the change, and it'd probably be > good to have a test case that shows this triggers under `-Wall` (the modified > test case explicitly

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

qianzhen added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150221/new/ https://reviews.llvm.org/D150221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/warn-padded-packed.cpp:5 +// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -verify=top %s -emit-llvm-only +// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -fclang-abi-compat=15 %s

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

glandium added a comment. I haven't tested this patch, but it looks like it contains everything that unbreaks our builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151344/new/ https://reviews.llvm.org/D151344

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

erichkeane added a comment. In D151365#4369650 , @HerrCai0907 wrote: > In D151365#4369605 , @erichkeane > wrote: > >> As Richard says, we should just be taking the first parameter type and using >> that

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 added a comment. In D151365#4369605 , @erichkeane wrote: > As Richard says, we should just be taking the first parameter type and using > that instead (obviously de-qualified and removing reference if necessary). But we still can find the

[PATCH] D151363: [NVPTX, CUDA] barrier intrinsics and builtins for sm_90

tra updated this revision to Diff 525309. tra added a comment. whitespace fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151363/new/ https://reviews.llvm.org/D151363 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

erichkeane added a comment. As Richard says, we should just be taking the first parameter type and using that instead (obviously de-qualified and removing reference if necessary). Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:964 } else if (DFK.isComparison())

[PATCH] D151363: [NVPTX, CUDA] barrier intrinsics and builtins for sm_90

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, bixia, hiraditya, yaxunl. Herald added a project: All. tra updated this revision to Diff 525307. tra added a comment. tra published this revision for review. tra added a reviewer: jlebar. Herald added subscribers:

[PATCH] D151365: [Sema] cast to CXXRecoradDecl correctly when diag a default comparison method

shafik added a comment. Comments here are relavant: https://github.com/llvm/llvm-project/issues/62102 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 ___

[PATCH] D151356: [OpenMP] Fix transformed loop's var privacy

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151356/new/ https://reviews.llvm.org/D151356

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

aaron.ballman added a comment. Please be sure to add a release note for the change, and it'd probably be good to have a test case that shows this triggers under `-Wall` (the modified test case explicitly names the diagnostic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

aaron.ballman added a comment. In D149677#4365031 , @sammccall wrote: > In D149677#4356863 , @aaron.ballman > wrote: > >> I'm not seeing how the changes you've got here interact with >> `isScopeVisible()`;

[PATCH] D151365: [Sema] cast to CXXRecoradDecl correctly when diag a default comparison method

HerrCai0907 created this revision. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed: https://github.com/llvm/llvm-project/issues/62791 in c++20, default comparison is supported.

[PATCH] D150996: LLVM_FALLTHROUGH => [[fallthrough]]. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6006d43e2d7d: LLVM_FALLTHROUGH = [[fallthrough]]. NFC (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150996/new/

[clang] 6006d43 - LLVM_FALLTHROUGH => [[fallthrough]]. NFC

Author: Craig Topper Date: 2023-05-24T12:40:10-07:00 New Revision: 6006d43e2d7dda56844f1c3867baa981cfefb8ea URL: https://github.com/llvm/llvm-project/commit/6006d43e2d7dda56844f1c3867baa981cfefb8ea DIFF: https://github.com/llvm/llvm-project/commit/6006d43e2d7dda56844f1c3867baa981cfefb8ea.diff

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs updated this revision to Diff 525298. codemzs marked 5 inline comments as done. codemzs retitled this revision from "[Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support." to "[Clang][BFloat16] Upgrade __bf16 to arithmetic type, change

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

HazardyKnusperkeks added a comment. In D151047#4369503 , @MyDeveloperDay wrote: > I think we need to extract the context of the test from RenameTests to ensure > we have it covered here. I don't personally normally run the entire LLVM > suite. Dito,

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

MyDeveloperDay added a comment. I think we need to extract the context of the test from RenameTests to ensure we have it covered here. I don't personally normally run the entire LLVM suite. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/

[PATCH] D151361: [CUDA] bump supported CUDA version to 12.1/11.8

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, bixia, hiraditya, yaxunl. Herald added a project: All. tra published this revision for review. tra added a reviewer: jlebar. Herald added subscribers: llvm-commits, cfe-commits, MaskRay, jholewinski. Herald added

[PATCH] D151076: [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0687b47a0ce: [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f0687b4 - [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue.

Author: Florian Hahn Date: 2023-05-24T20:16:42+01:00 New Revision: f0687b47a0ce82da07127fee4fe6af801df54ca6 URL: https://github.com/llvm/llvm-project/commit/f0687b47a0ce82da07127fee4fe6af801df54ca6 DIFF: https://github.com/llvm/llvm-project/commit/f0687b47a0ce82da07127fee4fe6af801df54ca6.diff

[PATCH] D151359: [CUDA] Relax restrictions on variadics in host-side compilation.

tra created this revision. Herald added subscribers: mattd, bixia, yaxunl. Herald added a project: All. tra published this revision for review. tra added a reviewer: jlebar. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. D150718

[PATCH] D150996: LLVM_FALLTHROUGH => [[fallthrough]]. NFC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150996/new/ https://reviews.llvm.org/D150996

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

MyDeveloperDay added a comment. We don't normally land broken tests, even if they are disabled, its better for us if we get a fix at the same time ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151145/new/ https://reviews.llvm.org/D151145

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao added inline comments. Comment at: clang/test/CodeGenCXX/warn-padded-packed.cpp:5 +// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -verify=top %s -emit-llvm-only +// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -fclang-abi-compat=15 %s

[PATCH] D151243: [CUDA] Fix wrappers for sm_80 functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG29cb080c363d: [CUDA] Fix wrappers for sm_80 functions (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151243/new/

[clang] 29cb080 - [CUDA] Fix wrappers for sm_80 functions

Author: Artem Belevich Date: 2023-05-24T11:48:39-07:00 New Revision: 29cb080c363d655ab1179a5564f1a82460e49a06 URL: https://github.com/llvm/llvm-project/commit/29cb080c363d655ab1179a5564f1a82460e49a06 DIFF:

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

rjmccall added a comment. As far as I'm concerned as editor of the Itanium ABI, the ABI treatment of trivial-for-the-purposes-of-calls classes is purely a psABI matter, and the Itanium ABI's wording around empty classes is merely a suggestion if the psABI doesn't have more specific rules

[PATCH] D151076: [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Nice catch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151076/new/ https://reviews.llvm.org/D151076

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for your patience while we worked through the design details. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao updated this revision to Diff 525280. SlaterLatiao added a comment. - Removed the -triple flag from warn-padded-packed testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D151162 Files:

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

denik added inline comments. Comment at: clang/test/CodeGenCXX/warn-padded-packed.cpp:4 +// -Wpacked-non-pod itself should not emit the "packed attribute is unnecessary" warnings. +// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -verify=top %s -emit-llvm-only +//

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

This revision was automatically updated to reflect the committed changes. Closed by commit rGfca4e2add0f8: Make dereferencing a void* a hard-error instead of warn-as-error (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fca4e2a - Make dereferencing a void* a hard-error instead of warn-as-error

Author: Erich Keane Date: 2023-05-24T11:27:13-07:00 New Revision: fca4e2add0f8b0471e4dbae5cf647006ec360bb2 URL: https://github.com/llvm/llvm-project/commit/fca4e2add0f8b0471e4dbae5cf647006ec360bb2 DIFF: https://github.com/llvm/llvm-project/commit/fca4e2add0f8b0471e4dbae5cf647006ec360bb2.diff

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D151162

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

dblaikie added a comment. yeah, doesn't look like it found any bugs there (the `arrow` one seems the most non-trivwial, but I'm guessing the code as-is is correct), so seems a bit questionable as an addition But @aaron.ballman if you figure this falls more under the "minor tweak to existing

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman added a comment. Do you have any more information? Do you have your own implementation of `__cpuidex` somewhere else before including `cpuid.h`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150646/new/

[clang] 2daf91d - Fix shared library build again from 1c9a800. NFC

Author: Michael Liao Date: 2023-05-24T14:09:38-04:00 New Revision: 2daf91dae3bc25d2ffb869d9781d9f4496a27d02 URL: https://github.com/llvm/llvm-project/commit/2daf91dae3bc25d2ffb869d9781d9f4496a27d02 DIFF: https://github.com/llvm/llvm-project/commit/2daf91dae3bc25d2ffb869d9781d9f4496a27d02.diff

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:852 ``double`` when passed to ``printf``, so the programmer must explicitly cast it to ``double`` before using it with an ``%f`` or similar specifier. pengfei wrote: > rjmccall

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

tra added a comment. As I said, I'm OK with the patch in principle, I just don't know what other factors I may be missing. Tests seem to be missing for c11 variants of the builtins. Comment at: clang/test/Sema/atomic-ops.c:209 + __atomic_fetch_min(D, 3,

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek added a comment. In D151186#4369203 , @MaskRay wrote: > In D151186#4369181 , @phosek wrote: > >> That alias is already recognized by the GNU driver. I'm sharing the >> implementation between the two

  1   2   3   >