[PATCH] D152661: [XRay] Make xray_fn_idx entries PC-relative

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0a6561ec9ec: [XRay] Make xray_fn_idx entries PC-relative (authored by MaskRay). Changed prior to commit:

[clang] e0a6561 - [XRay] Make xray_fn_idx entries PC-relative

Author: Fangrui Song Date: 2023-06-20T22:40:56-07:00 New Revision: e0a6561ec9ec10f8c0c43b15dfcbbc3c57d37d3f URL: https://github.com/llvm/llvm-project/commit/e0a6561ec9ec10f8c0c43b15dfcbbc3c57d37d3f DIFF: https://github.com/llvm/llvm-project/commit/e0a6561ec9ec10f8c0c43b15dfcbbc3c57d37d3f.diff

[PATCH] D152661: [XRay] Make xray_fn_idx entries PC-relative

MaskRay added a comment. Tested on aarch64-linux-gnu and powerpc64le-linux-gnu. I'll use `createLinkerPrivateSymbol` instead of `createLinkerPrivateTempSymbol` since the symbol is not considered `IsTemporary` by MC... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.

VincentWu added inline comments. Comment at: clang/test/Driver/riscv-arch.c:376 -// RUN: %clang --target=riscv32-unknown-elf -march=rv32izca -### %s \ +// RUN: %clang --target=riscv32-unknown-elf -march=rv32izfa -### %s \ // RUN: -fsyntax-only 2>&1 | FileCheck

[PATCH] D152661: [XRay] Make xray_fn_idx entries PC-relative

MaskRay updated this revision to Diff 533131. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. fix clang/test/CodeGen/xray-function-index.c Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

tbaeder added a comment. Can you post a before/after comparison of the exact output for that example? Comment at: clang/lib/Sema/SemaOverload.cpp:10752 QualType ToTy = Conv.Bad.getToType(); + ParmVarDecl *ToPVD = !isObjectArgument ? Fn->getParamDecl(I) : nullptr;

[clang] d5bebb3 - [Driver] Allow XRay on Apple Silicon

Author: Oleksii Lozovskyi Date: 2023-06-20T20:47:32-07:00 New Revision: d5bebb3fb402c4ba7e5838d267fa840eee8ecdce URL: https://github.com/llvm/llvm-project/commit/d5bebb3fb402c4ba7e5838d267fa840eee8ecdce DIFF:

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5bebb3fb402: [Driver] Allow XRay on Apple Silicon (authored by ilammy, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D145849?vs=530285=533116#toc Repository: rG LLVM

[clang] e105141 - [Driver] Allow XRay for more architectures on ELF systems

Author: Fangrui Song Date: 2023-06-20T20:41:54-07:00 New Revision: e1051414a16e970c2e36c2ab7dfe2b17353c4751 URL: https://github.com/llvm/llvm-project/commit/e1051414a16e970c2e36c2ab7dfe2b17353c4751 DIFF: https://github.com/llvm/llvm-project/commit/e1051414a16e970c2e36c2ab7dfe2b17353c4751.diff

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added a comment. I'm happy to merge it, but perhaps we should get @sunfish to lg too. Also, should we remove the `-experimental-pic` linker flag, or are you OK with that warning from the linker? If yes, I wonder if we should do that as part of this CL or a followup? Repository: rG

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

MaskRay added a comment. In D145849#4436623 , @MaskRay wrote: > In D145849#4430870 , @ilammy wrote: > >> In D145849#4412286 , @MaskRay >> wrote: >> >>> However,

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

MaskRay added a comment. In D145849#4430870 , @ilammy wrote: > In D145849#4412286 , @MaskRay wrote: > >> However, `Triple.isMacOSX()` is allowed before the feature actually works >> and

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. @sbc100 Thanks for the "lgtm". What's the next step to get this merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 ___ cfe-commits

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

shafik added a comment. It looks like the build failure happens on other PR as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153375/new/ https://reviews.llvm.org/D153375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

NoQ added a comment. Ok whew that's a big patch! I *think* I found a couple of bugs. In any case, this code is quickly becoming very complicated, and the functions we're editing are rapidly growing out of control. Chopping them up into smaller functions with clear separation of concerns would

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2077 + for (const auto &[VD, Fixables] : FixablesForUnsafeVars.byVar) { FixItsForVariable[VD] = There's a bug in variable naming: `FixablesForUnsafeVars`actually contains

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

jdoerfert added a comment. @ABataev wdyt? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG015049338d7e: Try to implement lambdas with inalloca parameters by forwarding without use of… (authored by akhuang). Repository: rG LLVM Github

[clang] 0150493 - Try to implement lambdas with inalloca parameters by forwarding without use of inallocas.

Author: Amy Huang Date: 2023-06-20T17:30:20-07:00 New Revision: 015049338d7e8e0e81f2ad2f94e5a43e2e3f5220 URL: https://github.com/llvm/llvm-project/commit/015049338d7e8e0e81f2ad2f94e5a43e2e3f5220 DIFF: https://github.com/llvm/llvm-project/commit/015049338d7e8e0e81f2ad2f94e5a43e2e3f5220.diff

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

NoQ added a comment. I'll just leave this tiny bit of analysis here, that we did on the whiteboard a while ago. > The "intermediate" overload `void f(std::span, int *)` stays there but > usually is not useful. If there are more than two parameters need to be > fixed, there will be more such

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/test/MC/ARM/thumb-fixups.s:1 +@ RUN: llvm-mc -triple armv6m-unknown-unknown %s --show-encoding > %t +@ RUN: FileCheck < %t %s We normally just pipe the output to FileCheck, e.g. `|

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

jrbyrnes updated this revision to Diff 533080. jrbyrnes marked 5 inline comments as done. jrbyrnes added a comment. Address comments + enable selection of ptr types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147732/new/

[PATCH] D144911: adding bf16 support to NVPTX

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXInstrInfo.td:559-568 -multiclass CVT_FROM_FLOAT_SM80 { -def _f32 : - NVPTXInst<(outs RC:$dst), -(ins Float32Regs:$src, CvtMode:$mode), -

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang updated this revision to Diff 533079. akhuang added a comment. rebase and clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files: clang/include/clang/CodeGen/CGFunctionInfo.h

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

NoQ added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:1945 + auto DRE = + DeclRefExpr::Create(*Context, {}, {}, VD, false, SourceLocation(), + VD->getType(), VK_PRValue); tbaeder wrote: > NoQ wrote: > > Is

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

rnk added a comment. The other thing I'm getting at here is that our TargetInfo.cpp abstraction is pretty well built out, even if it's a huge mess. The C++ rules are generally platform neutral, and we don't usually have to resort to these kinds of triple checks, but sometimes it's the most

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153179/new/ https://reviews.llvm.org/D153179 ___

[PATCH] D153379: Remove -flang-experimental-exec flag

everythingfunctional created this revision. everythingfunctional added reviewers: ktras, rouson, sscalpone, PeteSteinfeld, awarzynski. everythingfunctional added projects: Flang, LLVM. Herald added subscribers: sunshaoce, jdoerfert, mstorsjo. Herald added a project: All. everythingfunctional

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

efriedma updated this revision to Diff 533050. efriedma added a comment. Upload correct diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153179/new/ https://reviews.llvm.org/D153179 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 533051. kushanam added a comment. fixing bf16 test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

efriedma updated this revision to Diff 533049. efriedma added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153179/new/ https://reviews.llvm.org/D153179 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

modimo updated this revision to Diff 533048. modimo added a comment. Remove leftover code from original implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152741/new/ https://reviews.llvm.org/D152741 Files:

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); } zahiraam wrote: > rjmccall wrote: > > Please

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added a comment. Looking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

efriedma updated this revision to Diff 533045. efriedma added a comment. Updated testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153179/new/ https://reviews.llvm.org/D153179 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

efriedma added a comment. Filed https://github.com/llvm/llvm-project/issues/63417 . (On a related note, I also filed https://github.com/llvm/llvm-project/issues/63360 for an issue I stumbled over involving deleted copy constructors.) > Interesting. In Clang, we basically layer the C++ rules

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding

[PATCH] D153184: [NFC][clang] Refactor FileCheck metadata references in pragma-followup_inner.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG148075cf87c7: [clang][test] Refactor FileCheck metadata in pragma-followup_inner.cpp (authored by jmciver). Repository: rG LLVM Github Monorepo

[clang] 148075c - [clang][test] Refactor FileCheck metadata in pragma-followup_inner.cpp

Author: John McIver Date: 2023-06-20T14:55:12-06:00 New Revision: 148075cf87c76672474306fa463aadd93b1c027a URL: https://github.com/llvm/llvm-project/commit/148075cf87c76672474306fa463aadd93b1c027a DIFF: https://github.com/llvm/llvm-project/commit/148075cf87c76672474306fa463aadd93b1c027a.diff

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, rsmith. Herald added a project: All. shafik requested review of this revision. In `Sema::CreateBuiltinBinOp()` we were incorrectly using direct initialization instead of copy initialization. This led to a crash in a

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Not sure if this is the driving motivation, but this would probably allow LLDB's expression evaluator to synthesize a default implementation for these functions if they were optimized away.

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

rnk added a comment. Interesting. In Clang, we basically layer the C++ rules over the C rules: if C++ aspects of a class allow it to be passed directly transparently, then we defer down to the C rules, which deal with HVAs, structs, and things like that. In D153179#4429813

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

rnk added a comment. I'm really happy to see this limitation finally addressed! It's quite a bit of embarrassing tech debt that affects folks making Windows x86 builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/

[PATCH] D142994: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56e36e47f504: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile… (authored by hoy). Repository: rG LLVM Github Monorepo

[clang] 56e36e4 - [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

Author: Hongtao Yu Date: 2023-06-20T13:26:30-07:00 New Revision: 56e36e47f50446f519dfa2132cf5a49cc0816866 URL: https://github.com/llvm/llvm-project/commit/56e36e47f50446f519dfa2132cf5a49cc0816866 DIFF: https://github.com/llvm/llvm-project/commit/56e36e47f50446f519dfa2132cf5a49cc0816866.diff

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

dblaikie added a comment. Any particular use for this debug info in DWARF consumers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153362/new/ https://reviews.llvm.org/D153362 ___ cfe-commits mailing

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 533029. sammccall added a comment. clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clang/include/clang/Analysis/FlowSensitive/Arena.h

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 533028. sammccall added a comment. remove dead comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clang/include/clang/Analysis/FlowSensitive/Arena.h

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 533027. sammccall edited the summary of this revision. sammccall added a comment. more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files:

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

clementval added a comment. Looks ok to me. Note that some of the polymorphic TODOs will only be removed when HLFIR is in place. Looks like you have a clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153281/new/

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 533025. sammccall edited the summary of this revision. sammccall added a comment. updating description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files:

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

rsmith added a comment. A constant expression (including the immediate invocations generated for `consteval` functions) is a full-expression, so destructors should be run at the end of evaluating it, not as part of the enclosing expression. That's presumably why the code is calling

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 533022. sammccall added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clang/include/clang/Analysis/FlowSensitive/Arena.h

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

awarzynski accepted this revision. awarzynski added a comment. LGTM, thanks David! Could you also add a test in https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/frontend-forwarding.f90? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hoy added a comment. Hello, I'm seeing a build failure that seems related to this patch. I'm seeing the patch has been relanded and reverted a couple times and not sure where it is right now. Can you please confirm if the failure is related and fixed? Thanks. 2023-06-20T05:19:14.441-07:00]

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 533007. arsenm marked an inline comment as done. arsenm added a comment. Keep fixing documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl added a comment. @aaron.ballman or @erichkeane Did you want to re-review after that latest changes (more generic attribute) or are things good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); } rjmccall wrote: > Please switch over the

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

jhuber6 updated this revision to Diff 533002. jhuber6 added a comment. Fix logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153369/new/ https://reviews.llvm.org/D153369 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/AST/dump.cpp Index:

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

jhuber6 updated this revision to Diff 533000. jhuber6 added a comment. Adding AST mutation listener to the other modified declaration to signal that it was changed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153369/new/

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:23099 +CD->addAttr(A); if (ASTMutationListener *ML = Context.getASTMutationListener()) ML->DeclarationMarkedOpenMPDeclareTarget(D, A); Need to use

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532996. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed668ad9321: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5510f0b8f4b1: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction… (authored by eopXD). Repository: rG LLVM Github

[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

Caslyn created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, abrachet, phosek, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. Caslyn updated this revision to Diff 531489. Caslyn added a comment. Caslyn updated this revision to Diff 531932. Caslyn

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 created this revision. garvitgupta08 added reviewers: asb, apazos, jrtc27. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sunfish added a comment. In D150803#4419436 , @sbc100 wrote: > Did you mean to comment on the old PR? This new PR doesn't propose either > "jspi" or "async", but adds that ability to define custom attributes.. since > that was deemed more flexible and

[PATCH] D153248: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fe9cfe4137b: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 6fe9cfe - [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

Author: Nathan Ridge Date: 2023-06-20T13:40:26-04:00 New Revision: 6fe9cfe4137bc140c909850c26b52e9406495566 URL: https://github.com/llvm/llvm-project/commit/6fe9cfe4137bc140c909850c26b52e9406495566 DIFF: https://github.com/llvm/llvm-project/commit/6fe9cfe4137bc140c909850c26b52e9406495566.diff

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); } Please switch over the interesting identifiers

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, tra, ABataev, carlo.bertolli. Herald added subscribers: sunshaoce, guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr,

[PATCH] D142994: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142994/new/ https://reviews.llvm.org/D142994

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare updated this revision to Diff 532967. gedare added a comment. Do not use temporary variable for getBlockKind(). Fix test case syntax errors. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare added a comment. In D153205#4431235 , @HazardyKnusperkeks wrote: > You add a lot of checks and I honestly can't say if it does not affect other > code that is not covered by the tests. Not much I can do about that. I guess it is worth noting

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:393-395 +const auto *FileEntry = SM.getFileEntryForID(FID); +for (const auto *Export : PI.getExporters(FileEntry, SM.getFileManager())) + return

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 532964. VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Herald added a subscriber: javed.absar. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

ilya-biryukov added a comment. As mentioned in the GH issue, I think this change looks fine. But I would suggest waiting for feedback from @rsmith to ensure there isn't a reason for cleanups being removed that we are missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall created this revision. Herald added subscribers: martong, mgrang, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is the first step in

[PATCH] D153235: [RISCV] Change the type of argument to clz and ctz from ZiZi/WiWi to iUZi/iUWi

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153235/new/ https://reviews.llvm.org/D153235

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:887 + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseStmt, Case.get()); Fznamznon wrote:

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

paulkirth accepted this revision. paulkirth added a comment. Herald added a subscriber: wangpc. Also LGTM for the changes in MisExpect.rst, modulo feedback from @erichkeane. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151963/new/

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

egorzhdan added a comment. @compnerd @martong would you be OK with merging this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 updated this revision to Diff 532957. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153362/new/ https://reviews.llvm.org/D153362 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D153363: [clang][analyzer] No end-of-file when seek to file begin.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added a comment. In principle I like this as its annoyed me for years Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D153205 ___ cfe-commits mailing

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25511 + // Designated initializers. + verifyFormat("int LongVariable[1] = {\n" + "[0] = 1000, [1] = 2000\n" nit [2]

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/FormatToken.cpp:79 bool FormatToken::opensBlockOrBlockTypeList(const FormatStyle ) const { + auto bk = getBlockKind(); // C# Does not indent object initialisers as continuations.

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 updated this revision to Diff 532952. Michael137 added a comment. Herald added a subscriber: ormris. - remove redundant includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153362/new/ https://reviews.llvm.org/D153362 Files:

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

This revision was automatically updated to reflect the committed changes. Closed by commit rGbca11bafba97: [clang-format] Add InsertNewlineAtEOF to .clang-format files (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153208/new/

[clang] bca11ba - [clang-format] Add InsertNewlineAtEOF to .clang-format files

Author: Owen Pan Date: 2023-06-20T08:30:09-07:00 New Revision: bca11bafba9788dd80135b76a187c5f00e64f735 URL: https://github.com/llvm/llvm-project/commit/bca11bafba9788dd80135b76a187c5f00e64f735 DIFF: https://github.com/llvm/llvm-project/commit/bca11bafba9788dd80135b76a187c5f00e64f735.diff

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. Now that clang supports printing of multiple lines of code snippet in diagnostics, source

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:648 + {"bool operator==(const Foo &) const noexcept = default", +

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments, I have added an additional test to FindTargetTest. See also my other comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:4051 +TEST(Hover,

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 532921. massberg added a comment. Add test to FindTargetTests and extend test in HoverTests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files:

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

arsenm added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.readlane.ll:5 +declare i16 @llvm.amdgcn.readlane.i16(i16, i32) #0 +declare half @llvm.amdgcn.readlane.f16(half, i32) #0 +declare float @llvm.amdgcn.readlane.f32(float, i32) #0 arsenm

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp:209 +bool is16Bit = +(EltType->isIntegerTy() && EltType->getIntegerBitWidth() == 16) || +(EltType->isHalfTy()); isIntegerTy(16). Also, just check

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

nlopes added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp:213 + +Value *Result = UndefValue::get(Ty); +for (int i = 0; i < EC; i += 1 + is16Bit) { Please use poison wherever possible. In this case it seems it's just a

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:131 return HighlightingKind::Interface; - if (isa(D)) + if (isa(D)) return HighlightingKind::Namespace; kadircet wrote: > let's do this in a separate

  1   2   >