[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/fuchsia/GlobalVariablesCheck.cpp:26 +void GlobalVariablesCheck::registerMatchers(MatchFinder *Finder) { + const auto is_global_or_static_candidate = + allOf(hasGlobalStorage(), isDefinition(),

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4989 if (SS->getCond()->isValueDependent()) { if (!EvaluateDependentExpr(SS->getCond(), Info)) return ESR_Failed; As far as I can tell `Value` will still not be set if

[PATCH] D152632: [Clang] Add warnings for CWG2521

shafik added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:56 + NotStartsWithUnderscore, + ContainsDoubleUnderscore, +}; I would think starting with a double underscore would also not be allowed, at least that is my reading.

[PATCH] D152632: [Clang] Add warnings for CWG2521

shafik added a comment. I am wondering why we don't fold this into `-Wreserved-identifier` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4988 + if (SS->getCond()->containsErrors() || + !EvaluateDependentExpr(SS->getCond(), Info)) return ESR_Failed; yronglin wrote: > erichkeane wrote: > > It seems to me

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ddpagan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9823 +def err_omp_loop_reduction_clause : Error< + "reduction clause not handled with '#pragma omp loop bind(teams)'">; def warn_break_binds_to_switch : Warning< Should

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4893 + // Stop evaluate if E is a RecoveryExpr. + if (isa(E)) +return false; yronglin wrote: > erichkeane wrote: > > I'd probably suggest `E->containsErrors()` instead, to cover

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2293 +// search of connected components. +if (!ParmsNeedFix.empty()) { + auto First = ParmsNeedFix.begin(), Last = First; ziqingluo-90 wrote: > NoQ wrote: > >

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added a comment. Tests seem mostly fine, but since this is the primary patch for a major feature, consider adding more descriptions how this works? For example, you can add something like the following to the summary/commit message, which should make a curious reader know how to play

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896 +// Each section in COFF can directly contain relocations. +if (isa() && Section.relocations().empty()) + continue; HaohaiWen wrote: > skan wrote:

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2293 +// search of connected components. +if (!ParmsNeedFix.empty()) { + auto First = ParmsNeedFix.begin(), Last = First; NoQ wrote: > ziqingluo-90 wrote:

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan created this revision. Herald added subscribers: kbarton, hiraditya, nemanjai. Herald added a project: All. Jake-Egan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github

[PATCH] D153205: [clang-format] Add new block type ListInit

owenpan added a comment. In D153205#4438782 , @HazardyKnusperkeks wrote: > In D153205#4437966 , > @MyDeveloperDay wrote: > >> My only concern is that this changes behaviour without someone making the >>

[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

Caslyn added a comment. Thanks for the review @PiotrZSL, I’m new to this space and appreciate the comments. I have a few questions around some of them and would greatly appreciate any guidance you can give. The intent of this patch is to upstream a generic version of the google style check

[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

Caslyn updated this revision to Diff 533832. Caslyn marked 4 inline comments as done. Caslyn added a comment. Fixes from review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152953/new/ https://reviews.llvm.org/D152953 Files:

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 updated this revision to Diff 533824. eddyz87 added a comment. Rebase, `nomerge` documentation updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152986/new/ https://reviews.llvm.org/D152986 Files: clang/include/clang/Basic/Attr.td

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added a comment. Should there be tests added for usage of scalable vector types for RISC-V / AArch64? I typically have added such tests in the past, as shown here: https://reviews.llvm.org/D135011 Also, would you be able to add something at the top of the strictfp file that states

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added a comment. I believe it's also necessary to declare the builtin_elementwise builtins in \clang\include\clang\Basic\Builtins.def. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 ___

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

dblaikie added a comment. Basing this on "defined" or "undefined" member functions isn't /perfectly/ correct (though might be correct enough for this flag - though I do prefer something about "canonicality" of types, but perhaps it's too inside-baseball for the average user - though these

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 533809. Prabhuk added a comment. Clean up lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

MyDeveloperDay added a comment. Can you reference the GitHub bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153585/new/ https://reviews.llvm.org/D153585 ___ cfe-commits mailing list

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 533799. evelez7 added a comment. Do not include return types for constructors/destructors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files:

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

erichkeane added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

rjmccall added a comment. `abi-check` is a really generic name for a test case; could you rename those three tests to something more specific to this feature? Also, your tests are only testing this behavior in C++. Patch functionality LGTM. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:58 /// used as arguments will necessarily be available at construction time. - LazyRuntimeFunction() - : CGM(nullptr), FunctionName(nullptr), Function(nullptr) {} + LazyRuntimeFunction() {}

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir updated this revision to Diff 533798. schittir added a comment. Make the constructor default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 Files: clang/lib/Analysis/CFG.cpp clang/lib/CodeGen/CGObjCGNU.cpp

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 533795. Prabhuk added a comment. Improve lit test for uefi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

erichkeane added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir updated this revision to Diff 533794. schittir added a comment. Address comment- Use default member initialization instead of initializing in a constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 Files:

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir marked an inline comment as done. schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() &&

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 533789. arsenm added a comment. SemaCXX test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 533788. evelez7 added a comment. Add access control serialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

zahiraam created this revision. zahiraam added reviewers: rjmccall, andrew.w.kaylor, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. When float_t and double_t types are used inside a scope

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

erichkeane added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 533782. Prabhuk added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Set the Objectformat in the appropriate place to fix the triple string for UEFI. Simplify the lit test for UEFI toolchain to C. Repository:

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir created this revision. schittir added reviewers: aaron.ballman, erichkeane, tahonermann. Herald added subscribers: cfe-commits, steakhal, martong. Herald added a reviewer: NoQ. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan,

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 533779. arsenm added a comment. Rebase on fix for wrong debug name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

h-vetinari added a comment. In D129635#4440613 , @animeshk-amd wrote: > In the multi-company community meeting, the agreement was to move to the 5.1 > version assuming that these features are supported. We shouldn't need to assume - either the

[PATCH] D153379: Remove -flang-experimental-exec flag

h-vetinari added a comment. Does this merit a mention in the release notes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153379/new/ https://reviews.llvm.org/D153379 ___ cfe-commits mailing list

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

This revision was automatically updated to reflect the committed changes. Closed by commit rG213709e7be03: [CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 213709e - [CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

Author: Manna, Soumi Date: 2023-06-22T13:29:28-07:00 New Revision: 213709e7be031751170f04b05203b3228f87850a URL: https://github.com/llvm/llvm-project/commit/213709e7be031751170f04b05203b3228f87850a DIFF: https://github.com/llvm/llvm-project/commit/213709e7be031751170f04b05203b3228f87850a.diff

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:716 +void VisitObjCImplementationDecl(const ObjCImplementationDecl *OIMD) { + if (const auto *CI = OIMD->getClassInterface()) +

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 533769. dgoldman marked an inline comment as done. dgoldman added a comment. Add more FindTarget tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files:

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

Manna added a comment. Thank you @tahonermann and @tra for reviews and comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151606/new/ https://reviews.llvm.org/D151606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

gedare added a comment. I'm not sure how to properly stack dependent revs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153585/new/ https://reviews.llvm.org/D153585 ___ cfe-commits mailing list

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

gedare added a comment. Split this out from D153579 . This requires D153579 first, for the test cases to pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153585/new/

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. Fixes a bug that prevents alignment from proceeding through

[PATCH] D153579: [clang-format] Fix RAS reference alignment when PAS is left or middle

gedare added a comment. In D153579#4442346 , @HazardyKnusperkeks wrote: > Could you please split this into two reviews? yes, done, will stage the other review soon. The function pointer alignment requires this fix for the formatting to be correct

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11148 if (LHSType->isVLSTBuiltinType() && RHSType->isVLSTBuiltinType() && + LHSBuiltinTy && RHSBuiltinTy &&

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 updated this revision to Diff 533746. eddyz87 edited the summary of this revision. eddyz87 added a comment. Rebase: replace usage of removeLocalCVRQualifiers by removeLocalFastQualifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153579: [clang-format] Align consecutive function pointers and references

gedare updated this revision to Diff 533745. gedare edited the summary of this revision. gedare added a comment. Split and keep right-aligned references, will put function pointers in new rev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 533743. cor3ntin added a comment. Herald added a subscriber: jdoerfert. As approved by CWG Updates to cxx_status / doc will come later :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

This revision was automatically updated to reflect the committed changes. Closed by commit rG982a87ab74d8: [CLANG] Fix potential null pointer dereference bugs (authored by Manna). Changed prior to commit: https://reviews.llvm.org/D153033?vs=532138=533742#toc Repository: rG LLVM Github

[clang] 982a87a - [CLANG] Fix potential null pointer dereference bugs

Author: Manna, Soumi Date: 2023-06-22T12:58:38-07:00 New Revision: 982a87ab74d8d050ae56164fcead7cf19038b077 URL: https://github.com/llvm/llvm-project/commit/982a87ab74d8d050ae56164fcead7cf19038b077 DIFF: https://github.com/llvm/llvm-project/commit/982a87ab74d8d050ae56164fcead7cf19038b077.diff

[PATCH] D153584: [dataflow] Make SAT solver deterministic

sammccall created this revision. sammccall added reviewers: ymandel, xazax.hun. Herald added subscribers: martong, mgrang. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added a comment. In D153296#4442363 , @erichkeane wrote: > Just a rewording of the message, else LGTM. Thanks a lot for you're review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin updated this revision to Diff 533738. yronglin marked an inline comment as done. yronglin added a comment. Update wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 Files:

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin marked an inline comment as done. yronglin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4893 + // Stop evaluate if E is a RecoveryExpr. + if (isa(E)) +return false; erichkeane wrote: > I'd probably suggest

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Just a rewording of the message, else LGTM. Comment at: clang/docs/ReleaseNotes.rst:523 (`#38717 _`). +- Stop

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin updated this revision to Diff 533735. yronglin marked an inline comment as done. yronglin added a comment. Add ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 Files:

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

Manna added a comment. Thank you for reviews @aaron.ballman! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153579: [clang-format] Align consecutive function pointers and references

HazardyKnusperkeks added a comment. Could you please split this into two reviews? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153579/new/ https://reviews.llvm.org/D153579 ___ cfe-commits mailing list

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

SeanP created this revision. SeanP added reviewers: abhina.sreeskantharajan, Kai, fanbo-meng. Herald added a project: All. SeanP requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Add the required options and macros to the compilation

[PATCH] D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign

This revision was automatically updated to reflect the committed changes. Closed by commit rG11528fceac6b: [Clang] Fix Static Code Analysis Concerns with copy without assign (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 11528fc - [Clang] Fix Static Code Analysis Concerns with copy without assign

Author: Manna, Soumi Date: 2023-06-22T12:36:26-07:00 New Revision: 11528fceac6bb8a8d11749fb5ec5ea1baf27b1d1 URL: https://github.com/llvm/llvm-project/commit/11528fceac6bb8a8d11749fb5ec5ea1baf27b1d1 DIFF: https://github.com/llvm/llvm-project/commit/11528fceac6bb8a8d11749fb5ec5ea1baf27b1d1.diff

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3476-3477 + + // Regarding the 16: Note that multiple passes are added in + // addQualifierAlignmentFixerPasses(). + SmallVector Passes; owenpan wrote: > This comment is

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

jfurtek updated this revision to Diff 533726. jfurtek added a comment. - Fix comment and clang-formatting - Another clang-format fix - Rebase, clang-format... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151923/new/

[PATCH] D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign

Manna added a comment. Thank you @tahonermann and @aaronpuchert for reviews and comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2293 +// search of connected components. +if (!ParmsNeedFix.empty()) { + auto First = ParmsNeedFix.begin(), Last = First; ziqingluo-90 wrote: > NoQ wrote: > > What

[PATCH] D153580: Add support for z/OS link step (executable and shared libs)

SeanP created this revision. SeanP added reviewers: zibi, Kai, abhina.sreeskantharajan. Herald added a project: All. SeanP requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Add support for performing a link step on z/OS. This will

[PATCH] D153578: [Clang] Disable `libc` headers for offloading languages

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG767852b1a8e3: [Clang] Disable `libc` headers for offloading languages (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153579: [clang-format] Align consecutive function pointers and references

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. Allows alignment of consecutive declarations that include

[clang] 767852b - [Clang] Disable `libc` headers for offloading languages

Author: Joseph Huber Date: 2023-06-22T14:12:32-05:00 New Revision: 767852b1a8e38b87fc9a20a28adb0056d1bf2cb8 URL: https://github.com/llvm/llvm-project/commit/767852b1a8e38b87fc9a20a28adb0056d1bf2cb8 DIFF: https://github.com/llvm/llvm-project/commit/767852b1a8e38b87fc9a20a28adb0056d1bf2cb8.diff

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

Manna added a comment. Thank you everyone for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e12f5ab2df1: [CLANG] Fix uninitialized scalar field issues (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/

[clang] 5e12f5a - [CLANG] Fix uninitialized scalar field issues

Author: Manna, Soumi Date: 2023-06-22T12:09:14-07:00 New Revision: 5e12f5ab2df101cbdd6942678f26dcdd221c6e18 URL: https://github.com/llvm/llvm-project/commit/5e12f5ab2df101cbdd6942678f26dcdd221c6e18 DIFF: https://github.com/llvm/llvm-project/commit/5e12f5ab2df101cbdd6942678f26dcdd221c6e18.diff

[PATCH] D153491: [dataflow] Avoid copying environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51717c93e749: [dataflow] Avoid copying environment (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 51717c9 - [dataflow] Avoid copying environment

Author: Sam McCall Date: 2023-06-22T21:08:57+02:00 New Revision: 51717c93e74936a7d22f262b8c5f63efae3f8d11 URL: https://github.com/llvm/llvm-project/commit/51717c93e74936a7d22f262b8c5f63efae3f8d11 DIFF: https://github.com/llvm/llvm-project/commit/51717c93e74936a7d22f262b8c5f63efae3f8d11.diff

[PATCH] D153578: [Clang] Disable `libc` headers for offloading languages

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks, unblocked :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153578/new/ https://reviews.llvm.org/D153578

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

erichkeane added a comment. Also needs a release note. Comment at: clang/lib/AST/ExprConstant.cpp:4893 + // Stop evaluate if E is a RecoveryExpr. + if (isa(E)) +return false; I'd probably suggest `E->containsErrors()` instead, to cover cases where we're

[PATCH] D153578: [Clang] Disable `libc` headers for offloading languages

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, tra, yaxunl. Herald added a subscriber: Anastasia. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1, MaskRay. Herald added a project:

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin marked an inline comment as done. yronglin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4988 + if (SS->getCond()->containsErrors() || + !EvaluateDependentExpr(SS->getCond(), Info)) return ESR_Failed;

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin updated this revision to Diff 533714. yronglin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-multi-parm-span.cpp:13-15 + expected-note{{change type of 'p' to 'std::span' to preserve bounds information, and change 'q' and 'a' to 'std::span' to propagate bounds

[clang] 8ed7aa5 - Revert "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

Author: Amy Huang Date: 2023-06-22T11:42:33-07:00 New Revision: 8ed7aa59f489715d39d32e72a787b8e75cfda151 URL: https://github.com/llvm/llvm-project/commit/8ed7aa59f489715d39d32e72a787b8e75cfda151 DIFF: https://github.com/llvm/llvm-project/commit/8ed7aa59f489715d39d32e72a787b8e75cfda151.diff

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added inline comments. Comment at: clang/test/CodeGen/strictfp-elementwise-bulitins.cpp:190 +// CHECK-NEXT: entry: +// CHECK-NEXT:[[ELT_TRUNC:%.*]] = tail call <4 x float> @llvm.canonicalize.v4f32(<4 x float> [[A]]) #[[ATTR4]] +// CHECK-NEXT:ret <4 x float>

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4a93d80f425: [RISCV] Sort the extensions in SupportedExtensions and… (authored by craig.topper). Changed prior to commit:

[clang] e4a93d8 - [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

Author: Craig Topper Date: 2023-06-22T11:25:47-07:00 New Revision: e4a93d80f425114e4d943ba176b34590c8d0fece URL: https://github.com/llvm/llvm-project/commit/e4a93d80f425114e4d943ba176b34590c8d0fece DIFF: https://github.com/llvm/llvm-project/commit/e4a93d80f425114e4d943ba176b34590c8d0fece.diff

[PATCH] D153576: [Headers] Fix up some conditionals

probinson closed this revision. probinson added a comment. Committed [[here|https://github.com/llvm/llvm-project/commit/3db8410487ce704f02ef8a175e87295d4e86c8df]] and closing manually because I forgot to put the review link in the commit message. CHANGES SINCE LAST ACTION

[clang] 3db8410 - [Headers] Fix up some conditionals

Author: Paul Robinson Date: 2023-06-22T11:21:16-07:00 New Revision: 3db8410487ce704f02ef8a175e87295d4e86c8df URL: https://github.com/llvm/llvm-project/commit/3db8410487ce704f02ef8a175e87295d4e86c8df DIFF: https://github.com/llvm/llvm-project/commit/3db8410487ce704f02ef8a175e87295d4e86c8df.diff

[PATCH] D153576: [Headers] Fix up some conditionals

probinson added a comment. The Intel documentation doesn't hint that `_mulx_32` isn't available in 64-bit mode. I'm guessing gcc messed up and we copied them. CHANGES SINCE LAST

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. The static analysis results look suspect since there does not appear to be a way for `Log2_32` to return a value larger than 31. Regardless, the change looks safe to me;

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare added a comment. Can someone land for me? thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D153205 ___ cfe-commits mailing list

[PATCH] D152975: [clang-format] Allow break after return keyword

gedare abandoned this revision. gedare added a comment. I don't like the approach I took. It will be hard (impossible) to tune a default return penalty that ensures backward compatibility. The only way I see to make this work is to add an option to enable breaks after the return keyword. This

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

rjmccall added a comment. Does https://reviews.llvm.org/D143241 solve the original problem here, or is there something deeper? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152818/new/ https://reviews.llvm.org/D152818

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

emosy added a comment. Is this tool abandoned? Are maintainers still open to adding this tool? I am interested in it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89765/new/ https://reviews.llvm.org/D89765

[PATCH] D153576: [Headers] Fix up some conditionals

craig.topper added a comment. The mulx function being 32-bit mode only is also true in gcc. It probably won't generate a mulx instruction on x86-64. Maybe that's why it was 32-bit only? But it should still be functionally correct. CHANGES SINCE LAST ACTION

[PATCH] D153576: [Headers] Fix up some conditionals

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153576/new/ https://reviews.llvm.org/D153576 ___ cfe-commits mailing list

  1   2   3   >