[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

qiucf created this revision. qiucf added reviewers: stefanp, shchenz, amyk, tingwang, PowerPC. Herald added a subscriber: nemanjai. Herald added a reviewer: aaron.ballman. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D155857: [CMake] Disable GCC -Wnonnull

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f8f8760b586: [CMake] Disable GCC -Wnonnull (authored by fzakaria, committed by MaskRay). Changed prior to commit:

[PATCH] D155863: [X86][Regcall] Add an option to respect regcall ABI v.4 in win64

pengfei added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7897-7899 + if (Args.hasArg(options::OPT_regcall4)) { +CmdArgs.push_back("-regcall4"); + } Remove parentheses Comment at:

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543344. FreddyYe added a comment. Update cpu_specific required features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/ReleaseNotes.rst

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

owenpan added a comment. Like `while (a);`, `while (a) {}` is also an empty loop, so `NonEmpty` is misleading if it excludes the former but not the latter. IMO we should just fix the bug without extending the option because any loop with a single-statement body is a short loop.

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1082 FeaturePREFETCHI, - FeatureSHA512,

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543342. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files:

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1082 FeaturePREFETCHI, - FeatureSHA512,

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

madscientist added a comment. I built latest main with this patch applied and it does fix the issues in my environment. My headers that include xmmintrin.h etc. don't throw errors in clangd. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142569: [OpenMP] Introduce kernel environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5c8040390e7: [OpenMP] Introduce kernel environment (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 54. tianshilei1992 added a comment. rebase. I'll land it and see if AMD buildbot will be happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files:

[clang] 14b466b - [X86] Fix a typo of Broadwell after D74918. NFC

Author: Fangrui Song Date: 2023-07-23T15:15:05-07:00 New Revision: 14b466b940c674dc225b6dd2fd05c2faebcc11d5 URL: https://github.com/llvm/llvm-project/commit/14b466b940c674dc225b6dd2fd05c2faebcc11d5 DIFF: https://github.com/llvm/llvm-project/commit/14b466b940c674dc225b6dd2fd05c2faebcc11d5.diff

[PATCH] D156064: [SemaCXX] Recognise initializer_list injected-class-name types as initializer_lists

MitalAshok created this revision. Herald added a project: All. MitalAshok added reviewers: EricWF, CornedBee, erichkeane. MitalAshok published this revision for review. MitalAshok added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. The implicitly-generated

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:3137 +"} // namespace C\n" +" }// TESTSUITE(B)\n" +"} // NaMeSpAcE A",

[PATCH] D156065: [clang-format] Insert namespace comments with leading spaces

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Insert missing `namespace` comments with

[PATCH] D154893: [Clang] Fix some triviality computations

philnik added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1269 /// Determine whether this class has a non-trivial copy constructor /// (C++ [class.copy]p6, C++11 [class.copy]p12) bool hasNonTrivialCopyConstructor() const { royjacobson

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder updated this revision to Diff 543321. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155568/new/ https://reviews.llvm.org/D155568 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/InterpBuiltin.cpp Index: clang/lib/AST/Interp/InterpBuiltin.cpp

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder updated this revision to Diff 543320. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155568/new/ https://reviews.llvm.org/D155568 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/InterpBuiltin.cpp Index: clang/lib/AST/Interp/InterpBuiltin.cpp

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson updated this revision to Diff 543319. royjacobson added a comment. Update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 Files: clang/docs/ReleaseNotes.rst

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1269 /// Determine whether this class has a non-trivial copy constructor /// (C++ [class.copy]p6, C++11 [class.copy]p12) bool hasNonTrivialCopyConstructor() const { shafik

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

carlosgalvezp added a comment. A thought came to mind - since we are doing workarounds anyway, would it be easier to ask people to simply add `-clang-diagnostic*` to the `Checks` in their config file? It's fair to assume they will get those warnings when compiling the code. I feel the more

[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

crobeck updated this revision to Diff 543318. crobeck added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update clang frontend test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156040/new/

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:114 + + // TODO: Push platform-dependent size_t. + S.Stk.push>(Integral<64, false>::from(Len)); cor3ntin wrote: > Why not do that in

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

tbaeder updated this revision to Diff 543317. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST/Interp/builtin-functions.cpp

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4523388 , @cor3ntin wrote: > I'm not sure I understand the motivation for this change. Sure, people do > that but they also might do the same thing for ssize_t, intmax_t, or to > compare int to int32_t. > I think a

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

tbaeder added a comment. @cor3ntin It's next week :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4523227 , @aaron.ballman wrote: > In D155457#4513812 , @xgupta wrote: > >> In D155457#4511652 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e512688376c: [clang-tidy] performance-* checks: Also allow allow member expressions to be… (authored by shivam-amd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 1e51268 - [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

Author: Shivam Gupta Date: 2023-07-24T00:08:29+05:30 New Revision: 1e512688376c83d96f097e9b0ddb19132247a646 URL: https://github.com/llvm/llvm-project/commit/1e512688376c83d96f097e9b0ddb19132247a646 DIFF: https://github.com/llvm/llvm-project/commit/1e512688376c83d96f097e9b0ddb19132247a646.diff

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao updated this revision to Diff 543315. rZhBoYao marked an inline comment as done. rZhBoYao added a comment. Improve the test. Not sure what the lack of C++17 checks was referring to in your conversation with Aaron. Can @aaron.ballman confirm whether it is addressed by this patch?

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL updated this revision to Diff 543314. PiotrZSL added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add -fexceptions to tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. I'm sorry for hand-waving, but I also remember @aaron.ballman saying that code related to `-Wunsequenced` or around it was missing checks for C++17. I can't say whether you addressed that or not, so just leaving it here for you and reviewers. CHANGES SINCE LAST ACTION

[clang-tools-extra] 490bf27 - Revert "[clang-tidy] Add bugprone-empty-catch check"

Author: Piotr Zegar Date: 2023-07-23T18:13:52Z New Revision: 490bf27e53445fc4514c85142dec33ddf5bdcfe2 URL: https://github.com/llvm/llvm-project/commit/490bf27e53445fc4514c85142dec33ddf5bdcfe2 DIFF: https://github.com/llvm/llvm-project/commit/490bf27e53445fc4514c85142dec33ddf5bdcfe2.diff LOG:

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

This revision was automatically updated to reflect the committed changes. Closed by commit rGf256fee53430: [clang-tidy] Add bugprone-empty-catch check (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/

[clang-tools-extra] f256fee - [clang-tidy] Add bugprone-empty-catch check

Author: Piotr Zegar Date: 2023-07-23T18:02:10Z New Revision: f256fee5343033bf8a31aee06a80f3e982b76f82 URL: https://github.com/llvm/llvm-project/commit/f256fee5343033bf8a31aee06a80f3e982b76f82 DIFF: https://github.com/llvm/llvm-project/commit/f256fee5343033bf8a31aee06a80f3e982b76f82.diff LOG:

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. Thank you for working on this! Comment at: clang/test/SemaCXX/warn-unsequenced.cpp:3 // RUN:-Wunsequenced -Wno-c++17-extensions -Wno-c++14-extensions %s -// RUN: %clang_cc1 -fsyntax-only -verify=cxx17 -std=c++17 -Wno-unused

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

rZhBoYao added a comment. https://eel.is/c++draft/namespace.std#7 is in the library clause. Couldn't find a better place to put the test other than clang/test/CXX/dcl.dcl/basic.namespace/namespace.def/p7.cpp which is for https://eel.is/c++draft/namespace.def.general#4.sentence-2. Repository:

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

MitalAshok added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4249-4250 InitializedEntity::EK_LambdaToBlockConversionBlockElement && - UnwrappedArgs.size() == 1 && UnwrappedArgs[0]->isPRValue() && -

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

rZhBoYao created this revision. rZhBoYao added reviewers: philnik, clang-language-wg. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 ___ cfe-commits mailing list

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543307. xgupta added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

kiloalphaindia updated this revision to Diff 543304. kiloalphaindia added a comment. Sorry... forgot formatting... removed commented code... changed "Hallo Welt!" to english CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156053/new/ https://reviews.llvm.org/D156053 Files:

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

kiloalphaindia updated this revision to Diff 543302. kiloalphaindia added a comment. Yes, that's a good idea. Now `kdevelop` also highlights the message-expression properly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156053/new/ https://reviews.llvm.org/D156053 Files:

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

MitalAshok added inline comments. Comment at: clang/test/CXX/drs/dr14xx.cpp:433 -S s1; -S s2 = {s1}; // ok, not list-initialization so we pick the non-explicit constructor - } This relies on the old wording. "If T is a class type and the initializer

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 543303. tianshilei1992 added a comment. Herald added subscribers: gysit, Dinistro, bviyer, Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:523 +- Improved :doc:`performance-for-range-copy + ` sort them by name, performance checks are before readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

MitalAshok updated this revision to Diff 543301. MitalAshok edited the summary of this revision. MitalAshok added a comment. Removing "SelfInitIsNotListInit" test case: copy-list-init for non-aggregate classes remains as copy-list-inits, only aggregates copies are converted into copy-inits

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543300. xgupta marked 2 inline comments as done. xgupta added a comment. minor update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files:

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543299. xgupta added a comment. Update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added inline comments. Comment at: clang/test/Frontend/verify.c:159 + +// what-error {{huh?}} +// CHECK9: error: 'what-error' diagnostics expected but not seen: MaskRay wrote: > This may need a comment explaining that this is not recognized as a

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder updated this revision to Diff 543298. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 Files: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp clang/test/ARCMT/verify.m

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao updated this revision to Diff 543295. rZhBoYao added a comment. Put `-Windeterminately-sequenced` under `-Wsequence-point`'s control CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156057/new/ https://reviews.llvm.org/D156057 Files: clang/docs/ReleaseNotes.rst

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

mati865 added a comment. > If we make the flag imply linker options, then it becomes much clearer to > spot the error, if you enabled this but the code base still would need > autoimports somewhere. (This has happened - see >

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:83 Diags.setSourceManager(); + ProcessWarningOptions(Diags, Compiler.getDiagnosticOpts()); carlosgalvezp wrote: > A bit unclear to me why we should

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

sammccall updated this revision to Diff 543291. sammccall added a comment. fix incomplete cleanup of dead option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156044/new/ https://reviews.llvm.org/D156044 Files:

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:83 Diags.setSourceManager(); + ProcessWarningOptions(Diags, Compiler.getDiagnosticOpts()); A bit unclear to me why we should add this line

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao created this revision. rZhBoYao added reviewers: aaron.ballman, Endill, clang-language-wg. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add -Windeterminately-sequenced and fix -Wunsequenced

[PATCH] D78223: [clang-tidy] performance-range-for-copy only for copy.

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-for-range-copy.cpp:66-67 } + for (const S S2 : C) { + } } Those tests already exist and pass in current version. Most probably this change is obsolete.

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:523 +- Improved :doc:`performance-unnecessary-copy-initialization + `, PiotrZSL wrote: > Split it multiple entry's, 1 per check, keep in alphabetical order. > and maybe keep

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:523 +- Improved :doc:`performance-unnecessary-copy-initialization + `, Split it multiple entry's, 1 per check, keep in alphabetical order. and maybe keep it in format;

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543287. xgupta added a comment. Added release note and fix unit test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files:

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok created this revision. Herald added a project: All. MitalAshok added a comment. MitalAshok added a reviewer: aaron.ballman. MitalAshok published this revision for review. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. There is one observable difference by

[PATCH] D126855: [clang-tidy] check_clang_tidy.py: Print output nicely in Python 3.

PiotrZSL added a comment. Herald added a subscriber: carlosgalvezp. Fixed by f7a80c3d08d4821e621fc88d6a2e435291f82dff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126855/new/

[PATCH] D78223: [clang-tidy] performance-range-for-copy only for copy.

PiotrZSL added a comment. Release notes are missing, and patch not not apply gracefully. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78223/new/ https://reviews.llvm.org/D78223 ___ cfe-commits mailing

[PATCH] D86993: Document Clang's expectations of the C standard library.

nikic added a comment. Sorry for the delay, this took more time than expected. I've created an initial draft here: https://docs.google.com/document/d/1guH_HgibKrX7t9JfKGfWX2UCPyZOTLsnRfR6UleD1F8/edit?usp=sharing While writing this I remembered another bit that is somewhat relevant here: Clang

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added a comment. Some release notes would be nice, looks like impacted checks are: performance-unnecessary-copy-initialization, performance-inefficient-vector-operation, performance-unnecessary-value-param, performance-for-range-copy. Some info about "Improved XYZ check by handling

[PATCH] D78223: [clang-tidy] performance-range-for-copy only for copy.

xgupta added a comment. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a project: All. Reverse ping, this patch was never gets committed after being accepted. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78223/new/

[PATCH] D82784: [clang-tidy] For `run-clang-tidy.py` do not treat `allow_enabling_alpha_checkers` as a none value.

xgupta closed this revision. xgupta added a comment. Herald added subscribers: wangpc, PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This was committed in

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Thanks for the insightful suggestions! (Apologies for my late update. Just had a really busy week.) As suggested, I left the CCR intact and handled these functions in `CodeCompletionResult::createCodeCompletionStringForDecl`. I think this preserves the Declaration,

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543282. xgupta added a comment. Rebase and address one last comment. I think now it will be fine to commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files:

[PATCH] D155370: [CodeComplete] Don't emit parameters when not FunctionCanBeCall

zyounan updated this revision to Diff 543280. zyounan added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155370/new/ https://reviews.llvm.org/D155370 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

cor3ntin added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:1297 return true; - if (auto *Message = dyn_cast(D->getMessage())) + if (auto *Message = dyn_cast_if_present(D->getMessage())) if (Visit(MakeCXCursor(Message, StmtParent, TU,

[PATCH] D155370: [CodeComplete] Don't emit parameters when not FunctionCanBeCall

zyounan updated this revision to Diff 543277. zyounan added a comment. Don't change the CCR. Handle these in CreateCodeCompletionString. Emit template arguments if possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155370/new/

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, but we can wait for a couple of before committing in case other reviewers have more review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

kiloalphaindia created this revision. kiloalphaindia added a reviewer: cor3ntin. Herald added a subscriber: arphaman. Herald added a project: All. kiloalphaindia requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. After implementation

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL updated this revision to Diff 543276. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Rebase (release notes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm.org/D144748 Files:

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL marked 3 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:71 + +bool EmptyCatchCheck::isLanguageVersionSupported( +const LangOptions ) const { xgupta wrote: > This can be

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

xgupta closed this revision. xgupta added a comment. Herald added a reviewer: njames93. Herald added a subscriber: PiotrZSL. Herald added a project: All. https://reviews.llvm.org/rG475440703238ca32adab6c3fe5e0039c3f96d1a5 committed the remaining shebang change from python to python3.

[clang-tools-extra] 4754407 - [clang-tidy][clang-tidy-diff.py] Change shebang from python to python3

Author: Shivam Gupta Date: 2023-07-23T19:24:11+05:30 New Revision: 475440703238ca32adab6c3fe5e0039c3f96d1a5 URL: https://github.com/llvm/llvm-project/commit/475440703238ca32adab6c3fe5e0039c3f96d1a5 DIFF: https://github.com/llvm/llvm-project/commit/475440703238ca32adab6c3fe5e0039c3f96d1a5.diff

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

xgupta added a comment. Other than these three points everything looks good to me. Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:71 + +bool EmptyCatchCheck::isLanguageVersionSupported( +const LangOptions ) const { This can be

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet added inline comments. Comment at: clang/test/SemaCXX/vartemplate-lambda.cpp:17 +// expected-note{{cannot be used in a constant expression}} \ +//

[PATCH] D155707: [clang][Interp] Handle CXXNoexceptExprs

tbaeder updated this revision to Diff 543266. tbaeder added a comment. Always ignore the operand expression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155707/new/ https://reviews.llvm.org/D155707 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp

[PATCH] D155707: [clang][Interp] Handle CXXNoexceptExprs

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1203 + if (DiscardResult) +return this->discard(Operand); + return this->emitConstBool(E->getValue(), E); Looks like this is

[PATCH] D155707: [clang][Interp] Handle CXXNoexceptExprs

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:1037-1045 +namespace NE { + constexpr int foo() noexcept { +return 1; + } + static_assert(noexcept(foo()), ""); + constexpr int foo2() { +return 1;

[PATCH] D155707: [clang][Interp] Handle CXXNoexceptExprs

tbaeder updated this revision to Diff 543265. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155707/new/ https://reviews.llvm.org/D155707 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/literals.cpp

[clang] ca3ad82 - [Clang][NFC] Restore changelog entry incorrectly removed by 02bb2beeef

Author: Corentin Jabot Date: 2023-07-23T11:11:04+02:00 New Revision: ca3ad82cb50c79d8e43445bf93311ff39ec52c52 URL: https://github.com/llvm/llvm-project/commit/ca3ad82cb50c79d8e43445bf93311ff39ec52c52 DIFF:

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02bb2beeef3d: [clang] Fix diagnostics for defaulted, implicitly deleted operator==. (authored by AMP999, committed by cor3ntin). Changed prior to

[clang] 02bb2be - [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

Author: Amirreza Ashouri Date: 2023-07-23T10:58:17+02:00 New Revision: 02bb2beeef3d93360694de29573430f584caafe9 URL: https://github.com/llvm/llvm-project/commit/02bb2beeef3d93360694de29573430f584caafe9 DIFF:

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks for the patch, it looks good to me. I'll commit on your behalf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155714/new/

[clang] 142bfaf - [clang][Interp][NFC] Fix two small code style problems

Author: Timm Bäder Date: 2023-07-23T10:31:22+02:00 New Revision: 142bfaff7e7bbb768b5f22b3b14691b5ce3615f9 URL: https://github.com/llvm/llvm-project/commit/142bfaff7e7bbb768b5f22b3b14691b5ce3615f9 DIFF: https://github.com/llvm/llvm-project/commit/142bfaff7e7bbb768b5f22b3b14691b5ce3615f9.diff

[clang] 91cab53 - [clang][Interp][NFC] Fix InterpStack::dump() for empty stacks

Author: Timm Bäder Date: 2023-07-23T10:31:22+02:00 New Revision: 91cab53f881086c45b44541eec8e408e3a7446b4 URL: https://github.com/llvm/llvm-project/commit/91cab53f881086c45b44541eec8e408e3a7446b4 DIFF: https://github.com/llvm/llvm-project/commit/91cab53f881086c45b44541eec8e408e3a7446b4.diff

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

cor3ntin accepted this revision. cor3ntin added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/source_location.cpp:764-768 +#if defined(USE_CONSTEVAL) && !defined(NEW_INTERP) static_assert(test_init_capture() == __LINE__ - 4);

[PATCH] D155707: [clang][Interp] Handle CXXNoexceptExprs

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:1037-1045 +namespace NE { + constexpr int foo() noexcept { +return 1; + } + static_assert(noexcept(foo()), ""); + constexpr int foo2() { +return 1; Can you either add

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/vartemplate-lambda.cpp:17 +// expected-note{{cannot be used in a constant expression}} \ +//

[clang] 0d91cb5 - [clang][Interp][NFC] Clean up getOrCreateDummy()

Author: Timm Bäder Date: 2023-07-23T10:27:51+02:00 New Revision: 0d91cb5ef9c01ab633243838e892f61f73ebc56b URL: https://github.com/llvm/llvm-project/commit/0d91cb5ef9c01ab633243838e892f61f73ebc56b DIFF: https://github.com/llvm/llvm-project/commit/0d91cb5ef9c01ab633243838e892f61f73ebc56b.diff

[clang] 25b7417 - [clang][Interp][NFC] Use existing local variable

Author: Timm Bäder Date: 2023-07-23T10:27:51+02:00 New Revision: 25b7417bba4efcc9058f0057f854703dd3859776 URL: https://github.com/llvm/llvm-project/commit/25b7417bba4efcc9058f0057f854703dd3859776 DIFF: https://github.com/llvm/llvm-project/commit/25b7417bba4efcc9058f0057f854703dd3859776.diff

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:101-112 + for (;;) { +const Pointer = StrPtr.atIndex(I); + +if (!CheckRange(S, OpPC, ElemPtr, AK_Read)) + return false; + +uint8_t Val = ElemPtr.deref(); maybe

[PATCH] D154688: [clang] Show verify prefix in error messages

MaskRay added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:881 + std::string KindStr = Prefix + "-" + Kind; + Diags.Report(diag::err_verify_inconsistent_diags).setForceEmit() The variables are immediately used. I think in this

  1   2   >