[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

bnbarham added a comment. > Are there other users of incremental processing mode, other than the REPL / > IncrementalParser? It seems Swift's clang importer also uses incremental processing mode, I'm assuming to keep the `TUScope` and `CurLexer` alive after EOF. We also end up using the same

[PATCH] D157066: [clang][modules][deps] Create more efficient API for visitation of `ModuleFile` inputs

jansvoboda11 updated this revision to Diff 547097. jansvoboda11 added a comment. Remove leftover `std::string` constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157066/new/ https://reviews.llvm.org/D157066 Files:

[PATCH] D157066: [clang][modules][deps] Create more efficient API for visitation of `ModuleFile` inputs

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current

[PATCH] D157046: [clang] Abstract away string allocation in command line generation

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4323 +GenerateArg(Consumer, OPT_darwin_target_variant_sdk_version_EQ, +Opts.DarwinTargetVariantSDKVersion.getAsString()); } benlangmuir wrote: > Maybe

[PATCH] D157052: [clang][deps] NFC: Speed up canonical context hash computation

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fd56ea11256: [clang][deps] NFC: Speed up canonical context hash computation (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8fd56ea - [clang][deps] NFC: Speed up canonical context hash computation

Author: Jan Svoboda Date: 2023-08-03T20:36:34-07:00 New Revision: 8fd56ea11256f220502fe9819b496b15582f8d1e URL: https://github.com/llvm/llvm-project/commit/8fd56ea11256f220502fe9819b496b15582f8d1e DIFF: https://github.com/llvm/llvm-project/commit/8fd56ea11256f220502fe9819b496b15582f8d1e.diff

[PATCH] D157048: [clang] NFC: Avoid double allocation when generating command line

This revision was automatically updated to reflect the committed changes. Closed by commit rGacd1ab869fca: [clang] NFC: Avoid double allocation when generating command line (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] acd1ab8 - [clang] NFC: Avoid double allocation when generating command line

Author: Jan Svoboda Date: 2023-08-03T20:35:42-07:00 New Revision: acd1ab869fca0cfa09065aac518da399f755ed5c URL: https://github.com/llvm/llvm-project/commit/acd1ab869fca0cfa09065aac518da399f755ed5c DIFF: https://github.com/llvm/llvm-project/commit/acd1ab869fca0cfa09065aac518da399f755ed5c.diff

[PATCH] D157046: [clang] Abstract away string allocation in command line generation

This revision was automatically updated to reflect the committed changes. Closed by commit rG83452650490e: [clang] Abstract away string allocation in command line generation (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8345265 - [clang] Abstract away string allocation in command line generation

Author: Jan Svoboda Date: 2023-08-03T20:35:00-07:00 New Revision: 83452650490eb1021939129682b01fcdff34c691 URL: https://github.com/llvm/llvm-project/commit/83452650490eb1021939129682b01fcdff34c691 DIFF: https://github.com/llvm/llvm-project/commit/83452650490eb1021939129682b01fcdff34c691.diff

[PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 added inline comments. Comment at: lld/ELF/Driver.h:28 OPT_INVALID = 0, -#define OPTION(_1, _2, ID, _4, _5, _6, _7, _8, _9, _10, _11, _12) OPT_##ID, +#define OPTION(...) LLVM_MAKE_OPT_ID(__VA_ARGS__), #include "Options.inc" MaskRay wrote: >

[PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 updated this revision to Diff 547090. jansvoboda11 added a comment. Herald added subscribers: pmatos, asb, aheejin, sbc100. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. Convert missed LLD parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

MaskRay added inline comments. Comment at: lld/ELF/Driver.h:28 OPT_INVALID = 0, -#define OPTION(_1, _2, ID, _4, _5, _6, _7, _8, _9, _10, _11, _12) OPT_##ID, +#define OPTION(...) LLVM_MAKE_OPT_ID(__VA_ARGS__), #include "Options.inc" lld/wasm lld/COFF

[PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D157028#4558724 , @jansvoboda11 wrote: > Here's an example of a patch that changes the `OPTION` macro: D157029 >

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

bcain added a comment. ping? any concerns about this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/ https://reviews.llvm.org/D156771 ___ cfe-commits mailing list

[PATCH] D156962: [Driver] Mark m_x86_Features_Group options as TargetSpecific

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fd5f8027fa1: [Driver] Mark m_x86_Features_Group options as TargetSpecific (authored by MaskRay). Changed prior to commit:

[clang] 5fd5f80 - [Driver] Mark m_x86_Features_Group options as TargetSpecific

Author: Fangrui Song Date: 2023-08-03T19:04:53-07:00 New Revision: 5fd5f8027fa196913138a34082a933abd5be0b4e URL: https://github.com/llvm/llvm-project/commit/5fd5f8027fa196913138a34082a933abd5be0b4e DIFF: https://github.com/llvm/llvm-project/commit/5fd5f8027fa196913138a34082a933abd5be0b4e.diff

[PATCH] D156866: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. The change is loongarch-specific and it looks goold to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156866/new/

[PATCH] D156866: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

wangleiat updated this revision to Diff 547072. wangleiat added a comment. Address @SixWeining's commonts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156866/new/ https://reviews.llvm.org/D156866 Files:

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:156 +- New :doc:`cppcoreguidelines-no-suspend-with-lock + ` check. Please keep alphabetical order in new checks list. Comment at:

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

AntonRydahl updated this revision to Diff 547065. AntonRydahl added a comment. Removed whitespace that caused CI tests to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156901/new/ https://reviews.llvm.org/D156901 Files:

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

owenpan added inline comments. Comment at: clang/docs/ReleaseNotes.rst:167-168 +- Fix a bug that erroneously placed function arguments on a new line despite +all arguments being able to fit on the same line. Please delete it. We only update the

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter updated this revision to Diff 547061. ccotter added a comment. - Specify version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057 Files:

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D157055: [clang][deps] Avoid unnecessary work for seen dependencies

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Modular dependencies the client

[PATCH] D156320: [FLang] Add support for Rpass flag

kiranchandramohan added a comment. > rpass flag now prints remarks when requested but does not display > the passName used, i.e [-Rpass=inline] I think the location information is also not printed. Please check the difference in implementation of the `TextDiagnosticPrinter::HandleDiagnostic`

[PATCH] D157046: [clang] Abstract away string allocation in command line generation

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4323 +GenerateArg(Consumer, OPT_darwin_target_variant_sdk_version_EQ, +

[PATCH] D157054: [clang] NFC: Use compile-time option spelling when generating command line

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When generating command lines,

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

jroelofs added a subscriber: lei. jroelofs added a comment. In D74094#4559037 , @dexonsmith wrote: > In D74094#4554327 , @foad wrote: > >> Hi @erik.pilkington, I see this got reverted: > > I'm not sure if

[PATCH] D157050: [clang] NFC: Avoid double allocation when generating command line

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. In D157050#4559138 , @benlangmuir wrote: > Dupe of https://reviews.llvm.org/D157048 ? Yes, weird. Closing this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157052: [clang][deps] NFC: Speed up canonical context hash computation

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes use of the

[PATCH] D157050: [clang] NFC: Avoid double allocation when generating command line

benlangmuir added a comment. Dupe of https://reviews.llvm.org/D157048 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157050/new/ https://reviews.llvm.org/D157050 ___ cfe-commits mailing list

[PATCH] D157050: [clang] NFC: Avoid double allocation when generating command line

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes use of the

[PATCH] D157048: [clang] NFC: Avoid double allocation when generating command line

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes use of the

[PATCH] D157046: [clang] Abstract string allocation in command line generation

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 547024. AlexVlx added a comment. Remove noise, correct style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/ https://reviews.llvm.org/D155850 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D154999: [clang-tidy] Add bugprone-std-forward-type-mismatch check

ccotter added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/std-forward-type-mismatch.rst:18 +doSomething(std::forward(base)); // Incorrect usage +doSomething(static_cast(base)); // Suggested usage + } How confident are

[PATCH] D155870: [Clang][CodeGen] Another follow-up for `vtable`, `typeinfo` et al. are globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7240008c0afa: [Clang][CodeGen] `__dynamic_cast` should care about `type_info`s address space (authored by AlexVlx). Repository: rG LLVM Github

[clang] 7240008 - [Clang][CodeGen] `__dynamic_cast` should care about `type_info`'s address space

Author: Alex Voicu Date: 2023-08-03T23:25:06+01:00 New Revision: 7240008c0afa3e2d12f3f51cfe0235668feb6ef3 URL: https://github.com/llvm/llvm-project/commit/7240008c0afa3e2d12f3f51cfe0235668feb6ef3 DIFF: https://github.com/llvm/llvm-project/commit/7240008c0afa3e2d12f3f51cfe0235668feb6ef3.diff

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

dexonsmith added subscribers: arphaman, akyrtzi, jroelofs. dexonsmith added a comment. In D74094#4554327 , @foad wrote: > Hi @erik.pilkington, I see this got reverted: I'm not sure if @erik.pilkington is still watching Phabricator, but in any case I

[PATCH] D157029: [llvm] Construct option spelling at compile-time

jansvoboda11 updated this revision to Diff 547019. jansvoboda11 added a comment. Rebase on top of D157028 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm.org/D157029 Files:

[PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 updated this revision to Diff 547018. jansvoboda11 added a comment. Herald added a reviewer: alexander-shaposhnikov. Consolidate all usages by extra `_WITH_ID_PREFIX` macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/

[PATCH] D157035: [clang][cli] Accept option spelling as `Twine`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG243bc7504965: [clang][cli] Accept option spelling as `Twine` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 243bc75 - [clang][cli] Accept option spelling as `Twine`

Author: Jan Svoboda Date: 2023-08-03T15:09:52-07:00 New Revision: 243bc7504965b885c34487f358d2a4b4a355a6b5 URL: https://github.com/llvm/llvm-project/commit/243bc7504965b885c34487f358d2a4b4a355a6b5 DIFF: https://github.com/llvm/llvm-project/commit/243bc7504965b885c34487f358d2a4b4a355a6b5.diff

[PATCH] D157035: [clang][cli] Accept option spelling as `Twine`

jansvoboda11 added a comment. That's a good point. Updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157035/new/ https://reviews.llvm.org/D157035 ___ cfe-commits mailing list

[PATCH] D157035: [clang][cli] Accept option spelling as `Twine`

jansvoboda11 updated this revision to Diff 547014. jansvoboda11 added a comment. Assert that spelling is null-terminated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157035/new/ https://reviews.llvm.org/D157035 Files:

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman updated this revision to Diff 547011. dgoldman added a comment. run clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156704/new/ https://reviews.llvm.org/D156704 Files:

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2219 + // cannot be fixed... + eraseVarsForUnfixableGroupMates(FixItsForVariable, VarGrpMgr); + // Now `FixItsForVariable` gets further reduced: a variable is in NoQ

[PATCH] D157033: [clang][CFG] Fix 2 memory errors in interval computation.

ymandel updated this revision to Diff 547008. ymandel added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157033/new/ https://reviews.llvm.org/D157033 Files: clang/lib/Analysis/IntervalPartition.cpp

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. In D74094#4554327 , @foad wrote: > Hi @erik.pilkington, I see this got reverted: > > commit e26c24b849211f35a988d001753e0cd15e4a9d7b > Author: Erik Pilkington > Date: Wed Feb 12 12:02:58 2020 -0800 > >

[PATCH] D157035: [clang][cli] Accept option spelling as `Twine`

benlangmuir added a comment. This code asserts that the Twine is a single stringref, but it's also relying on the fact it's null-terminated; can we check for that as well, or at least document it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157035: [clang][cli] Accept option spelling as `Twine`

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This will make it possible to

[PATCH] D157033: [clang][CFG] Fix 2 memory errors in interval computation.

ymandel created this revision. ymandel added a reviewer: xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This fixes 2 bugs and adds corresponding tests. Both related to unreachable blocks. One occured

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 546996. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D156911: [clang][CodeGen] Drop some typed pointer bitcasts

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2bdc86484d03: [clang][CodeGen] Drop some typed pointer bitcasts

[clang] 2bdc864 - [clang][CodeGen] Drop some typed pointer bitcasts

Author: Bjorn Pettersson Date: 2023-08-03T22:54:33+02:00 New Revision: 2bdc86484d03234f5155b0865f33009d0da74da9 URL: https://github.com/llvm/llvm-project/commit/2bdc86484d03234f5155b0865f33009d0da74da9 DIFF:

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 546991. ccotter marked an inline comment as done. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files:

[PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 added a comment. Here's an example of a patch that changes the `OPTION` macro: D157029 . I wonder if we could have counterparts to `LLVM_MAKE_OPT_ID` and `LLVM_CONSTRUCT_OPT_INFO` that allow overriding the default `OPT_` prefix. That would make

[PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

MaskRay added a comment. I'll be away for a few days but I took a quick glance. This change looks reasonable. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/ https://reviews.llvm.org/D157028

[PATCH] D157029: [llvm] Construct option spelling at compile-time

jansvoboda11 created this revision. jansvoboda11 added a reviewer: MaskRay. Herald added subscribers: ormris, ributzka, kadircet, arphaman, hiraditya. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: jhenderson. Herald added a project: All. jansvoboda11 requested review of

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

brendandahl updated this revision to Diff 546986. brendandahl added a comment. Cleanup some extra brackets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156172/new/ https://reviews.llvm.org/D156172 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

HazardyKnusperkeks added a comment. In D156259#4558570 , @jp4a50 wrote: > @HazardyKnusperkeks could you merge this for me assuming the build is green > please? I don't have merge rights. Thanks. That will have to wait, but if no one else stepped in,

[PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 created this revision. jansvoboda11 added a reviewer: MaskRay. Herald added subscribers: jhenderson, ormris, ributzka, steven_wu, hiraditya, arichardson, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: jhenderson. Herald added a project: All. jansvoboda11

[PATCH] D156799: Update generic scheduling to use A510 scheduling model

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. Looks good. You may need to rebase over new tests, make sure everything is still passing when you do. LGTM Comment at:

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

t-rasmud added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2145 -static bool impossibleToFixForVar(const FixableGadgetSets , - const Strategy , - const VarDecl * Var) { - for (const

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

jcranmer-intel added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:503 + // If during the evaluation of an expression, the result is not + // mathematically defined [...], the behavior is undefined. + // FIXME: C++ rules require us to not conform to IEEE

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 added a comment. @HazardyKnusperkeks could you merge this for me assuming the build is green please? I don't have merge rights. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 546972. jp4a50 added a comment. Format files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156877: Update Clang-REPL docs with removing the redundant subsections

This revision was automatically updated to reflect the committed changes. Closed by commit rG54081868dd22: [clang-repl] Remove redundant subsections from the table of content. (authored by Krishna-13-cyber, committed by v.g.vassilev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 5408186 - [clang-repl] Remove redundant subsections from the table of content.

Author: Krishna-13-cyber Date: 2023-08-03T19:16:18Z New Revision: 54081868dd2220c4de77f481648ec7e10a68618b URL: https://github.com/llvm/llvm-project/commit/54081868dd2220c4de77f481648ec7e10a68618b DIFF: https://github.com/llvm/llvm-project/commit/54081868dd2220c4de77f481648ec7e10a68618b.diff

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

v.g.vassilev added inline comments. Comment at: clang/docs/index.rst:96 ClangRepl + ExecutionResultsHandling We should probably move that under `ClangRepl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman added a comment. I'm not opposed to a revert, but I know some downstream users like MinGW have already adapted to this change so I'm not sure how much headache it would cause them to do a revert. Maybe I'm not understanding things correctly, but I originally `_MSC_EXTENSIONS`

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

brendandahl updated this revision to Diff 546966. brendandahl added a comment. Update deferred annotations whenever EmitGlobalDefinition is called with a FunctionDecl and it has already been used or defined. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146023: [AMDGPU] Remove Code Object V2

cfang added a comment. Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5598 return ParseDirectiveHSAMetadata(); } else { -if (IDVal == ".hsa_code_object_version") Are you sure Non-HSA does not have the four directives you

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aaron.ballman added a comment. In D150646#4450915 , @aidengrossman wrote: > In D150646#4450551 , @glandium > wrote: > >> Did you find something? > > Not yet. I just finished finals a week ago so I haven't had

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

AntonRydahl added a comment. The unit test that fails, `flang/test/Driver/omp-driver-offload.f90`, also fails on main. I don't see that it should be related to this patch. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

aaron.ballman added a comment. Thank you for working on this! FWIW, precommit Ci found a relevant test failure that should also be addressed. Comment at: clang/lib/Sema/SemaExpr.cpp:1062-1073 + // C2x 6.5.2.2p6: + // The integer promotions are performed on each trailing

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

AntonRydahl updated this revision to Diff 546964. AntonRydahl added a comment. Removing information about Flang default version of OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156901/new/ https://reviews.llvm.org/D156901 Files:

[PATCH] D156989: FloatingPointMode: Use -1 for "Dynamic"

sepavloff added a comment. In D156989#4558134 , @arsenm wrote: > In D156989#4558133 , @sepavloff > wrote: > >> Rounding mode is presented in FPOptions with 3 bits, so there is only 8 >> values available for

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate (NFC)

SuperSodaSea updated this revision to Diff 546962. SuperSodaSea added a comment. Update patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154646/new/ https://reviews.llvm.org/D154646 Files: clang/include/clang/AST/Expr.h clang/lib/Serialization/ASTWriter.cpp

[clang] 32056aa - [docs] Fix doxygen markers for grouping methods. NFC.

Author: Volodymyr Sapsai Date: 2023-08-03T11:16:42-07:00 New Revision: 32056aa3443786822963e6e469d98deb7b857d79 URL: https://github.com/llvm/llvm-project/commit/32056aa3443786822963e6e469d98deb7b857d79 DIFF:

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

aaron.ballman added a comment. Was there an RFC for this extension to the attribute? (There doesn't need to be one, I'm just wondering if there's more background info on what's driving this patch forward and discussion around the design.) I'd like some more details about how this attribute

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43dfe0f08eca: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 43dfe0f - [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

Author: Rainer Orth Date: 2023-08-03T20:01:13+02:00 New Revision: 43dfe0f08ecaf50f986512d0548bd3ac84d1813b URL: https://github.com/llvm/llvm-project/commit/43dfe0f08ecaf50f986512d0548bd3ac84d1813b DIFF: https://github.com/llvm/llvm-project/commit/43dfe0f08ecaf50f986512d0548bd3ac84d1813b.diff

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

MaskRay added inline comments. Comment at: clang/test/Driver/lit.local.cfg:23 ".yaml", +".test", ] ro wrote: > MaskRay wrote: > > Instead of adding a new extension, you can just name your test `.c`? > I could, but went for `.test` instead because the

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:113 + static Boolean bitcastFromMemory(const std::byte *Buff) { +bool Val = static_cast(*Buff); +return Boolean(Val); tbaeder wrote: > MitalAshok wrote: > > Does this handle

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

ro added inline comments. Comment at: clang/test/Driver/lit.local.cfg:23 ".yaml", +".test", ] MaskRay wrote: > Instead of adding a new extension, you can just name your test `.c`? I could, but went for `.test` instead because the `clang` invocations

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/lit.local.cfg:23 ".yaml", +".test", ] Instead of adding a new extension, you can just name your test `.c`?

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:503 + // If during the evaluation of an expression, the result is not + // mathematically defined [...], the behavior is undefined. + // FIXME: C++ rules require us to not conform to IEEE 754 here.

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman updated this revision to Diff 546927. dgoldman added a comment. Rename IsSystem to IsAngled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156704/new/ https://reviews.llvm.org/D156704 Files:

[PATCH] D156911: [clang][CodeGen] Drop some typed pointer bitcasts

bjope updated this revision to Diff 546921. bjope added a comment. Rebased+updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156911/new/ https://reviews.llvm.org/D156911 Files: clang/lib/CodeGen/CGBlocks.cpp

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. Since GCC 11, the bundled Solaris/SPARC GCC uses the `sparcv8plus` subdirectory

[PATCH] D156989: FloatingPointMode: Use -1 for "Dynamic"

arsenm added a comment. In D156989#4558133 , @sepavloff wrote: > Rounding mode is presented in FPOptions with 3 bits, so there is only 8 > values available for particular modes. 5 of them, which are specified in > IEEE-754, are listed in

[PATCH] D156989: FloatingPointMode: Use -1 for "Dynamic"

sepavloff added a comment. Rounding mode is presented in FPOptions with 3 bits, so there is only 8 values available for particular modes. 5 of them, which are specified in IEEE-754, are listed in `RoundingMode`. `Dynamic` (which is -1 in 3-bit numbers) is not a real rounding mode, it

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 546915. cor3ntin added a comment. Fix release notes formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ https://reviews.llvm.org/D153536 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. added some comments for minor changes. Two sections to be removed since they are not yet merged to upstream code: - Complex Data Types - Users can create their own types

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin added a comment. Note: we are waiting for feedback from @hubert.reinterpretcast's people before progressing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156596/new/ https://reviews.llvm.org/D156596

[PATCH] D155870: [Clang][CodeGen] Another follow-up for `vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 546911. AlexVlx added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155870/new/ https://reviews.llvm.org/D155870 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/dynamic-cast-address-space.cpp Index:

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 546910. cor3ntin marked an inline comment as done. cor3ntin added a comment. - Rebase - Address Aaron's comments - Mention the lack of debugging support in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

aaron.ballman added a comment. Because this is fixing a regression, it may be worth backporting it to the 17.x branch: https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153969/new/

  1   2   3   >