[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

efriedma added a comment. I see what you're getting at here... but I don't think this works quite right. If the empty class has a non-trivial constructor, we have to pass the correct "this" address to that constructor. Usually a constructor for an empty class won't do anything with that

[PATCH] D157362: [RISCV] Add Zicfilp extension.

fakepaper56 created this revision. fakepaper56 added reviewers: craig.topper, reames, frasercrmck, rogfer01, asb. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. > How to reproduce locally: > https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Does not reproduce on my workstation too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/

[PATCH] D157353: [RISCV] Remove pre-defined macro test for b extension. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG767ca3a70d6d: [RISCV] Remove pre-defined macro test for b extension. NFC. (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 767ca3a - [RISCV] Remove pre-defined macro test for b extension. NFC.

Author: Jim Lin Date: 2023-08-08T13:01:34+08:00 New Revision: 767ca3a70d6d60bd52ff0829335942aa6dafcc28 URL: https://github.com/llvm/llvm-project/commit/767ca3a70d6d60bd52ff0829335942aa6dafcc28 DIFF: https://github.com/llvm/llvm-project/commit/767ca3a70d6d60bd52ff0829335942aa6dafcc28.diff LOG:

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4565993 , @jroelofs wrote: > In D157119#4564546 , @vitalybuka > wrote: > >> I suspect one of your recent changes broke >>

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 548042. evelez7 added a comment. Add brackets for SerializerBase visit methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 Files:

[PATCH] D157353: [RISCV] Remove pre-defined macro test for b extension. NFC.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157353/new/ https://reviews.llvm.org/D157353

[PATCH] D157353: [RISCV] Remove pre-defined macro test for b extension. NFC.

Jim created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal,

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. In D142609#4566418 , @aaron.ballman wrote: > Concerns have been raised in > https://github.com/llvm/llvm-project/issues/64356 that this is an undesirable > change in diagnostic behavior. The diagnostic is supposed to fire when

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2193 // Skip other prefixes once a GCC installation is found. -if (Version > VersionZero) +// Solaris GCC installations live in separate Prefixes per Version +// (/usr/gcc/) that

[PATCH] D157352: Revert "[Clang] Fix -Wconstant-logical-operand when LHS is a constant"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa84525233776: Revert [Clang] Fix -Wconstant-logical-operand when

[clang] a845252 - Revert "[Clang] Fix -Wconstant-logical-operand when LHS is a constant"

Author: Shivam Gupta Date: 2023-08-08T08:00:02+05:30 New Revision: a84525233776a716e2c6291993f0b33fd1c76f7c URL: https://github.com/llvm/llvm-project/commit/a84525233776a716e2c6291993f0b33fd1c76f7c DIFF: https://github.com/llvm/llvm-project/commit/a84525233776a716e2c6291993f0b33fd1c76f7c.diff

[PATCH] D157352: Revert "[Clang] Fix -Wconstant-logical-operand when LHS is a constant"

xgupta created this revision. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976

[PATCH] D157238: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb92fb8726fc: [clang][ASTImporter] Add import of DependentSizedExtVectorType (authored by dingfei fd...@feysh.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157249: [clang][ASTImporter] Add import of 'ConvertVectorExpr'

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf21f9fc0373: [clang][ASTImporter] Add import of ConvertVectorExpr (authored by dingfei fd...@feysh.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] df21f9f - [clang][ASTImporter] Add import of 'ConvertVectorExpr'

Author: dingfei Date: 2023-08-08T10:23:56+08:00 New Revision: df21f9fc037329ae05ff4640d9172364bb9ef6ed URL: https://github.com/llvm/llvm-project/commit/df21f9fc037329ae05ff4640d9172364bb9ef6ed DIFF: https://github.com/llvm/llvm-project/commit/df21f9fc037329ae05ff4640d9172364bb9ef6ed.diff LOG:

[clang] db92fb8 - [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

Author: dingfei Date: 2023-08-08T10:22:00+08:00 New Revision: db92fb8726fc09e6d76346a02169685025fd59ca URL: https://github.com/llvm/llvm-project/commit/db92fb8726fc09e6d76346a02169685025fd59ca DIFF: https://github.com/llvm/llvm-project/commit/db92fb8726fc09e6d76346a02169685025fd59ca.diff LOG:

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

danix800 added a comment. 1. Use invalid loc: `SourceLocation()` ExprWithCleanups 0x55d1067162c8 'void' `-CoyieldExpr 0x55d106716280 'void' |-CXXMemberCallExpr 0x55d106715ed8 'std::suspend_always':'std::suspend_always' | |-MemberExpr 0x55d106715ea8 '' .yield_value

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 548027. fakepaper56 added a comment. Bump to 0.2 and address part of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files:

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 548022. AlexVlx added a comment. Extend handling of unsupported builtins to include dealing with the `target` attribute. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/ https://reviews.llvm.org/D155850 Files:

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. Got it. Being patience is not bad and it is good enough to know that we are moving forward : ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153114/new/ https://reviews.llvm.org/D153114 ___ cfe-commits mailing

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Serialize global C++ variable templates and

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5bc4b34a3aa9: [clang][hexagon] Handle library path arguments earlier (authored by androm3da). Repository: rG LLVM

[clang] 5bc4b34 - [clang][hexagon] Handle library path arguments earlier

Author: Brian Cain Date: 2023-08-07T18:18:59-07:00 New Revision: 5bc4b34a3aa9c6ea10663a252ac46d20862b38d5 URL: https://github.com/llvm/llvm-project/commit/5bc4b34a3aa9c6ea10663a252ac46d20862b38d5 DIFF: https://github.com/llvm/llvm-project/commit/5bc4b34a3aa9c6ea10663a252ac46d20862b38d5.diff

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7a8a7d49776: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC… (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e7a8a7d - [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

Author: Weining Lu Date: 2023-08-08T09:07:11+08:00 New Revision: e7a8a7d4977627ebc43e9ed43462aebad4a66e8d URL: https://github.com/llvm/llvm-project/commit/e7a8a7d4977627ebc43e9ed43462aebad4a66e8d DIFF: https://github.com/llvm/llvm-project/commit/e7a8a7d4977627ebc43e9ed43462aebad4a66e8d.diff

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

rsandifo-arm added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK sdesmalen wrote: > rsandifo-arm wrote: > > sdesmalen wrote: > > > rsandifo-arm wrote: > > > > Would be good

[PATCH] D157326: [clang-tidy] Fix handling of out-of-line functions in readability-static-accessed-through-instance

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:23 static unsigned getNameSpecifierNestingLevel(const QualType ) { if (const ElaboratedType *ElType = QType->getAs()) { if (const

[PATCH] D157331: [clang] Implement C23

yabinc added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > enh wrote: > > enh wrote: > > > ZijunZhao wrote: > > > > enh wrote: > > > > > is this

[PATCH] D157331: [clang] Implement C23

xbolva00 added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > enh wrote: > > enh wrote: > > > ZijunZhao wrote: > > > > enh wrote: > > > > > is

[PATCH] D157135: [OpenMP][Docs] Update OpenMP supported features table

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6204724df56: [OpenMP][Docs] Update OpenMP supported features table (authored by ddpagan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157135/new/

[clang] f620472 - [OpenMP][Docs] Update OpenMP supported features table

Author: Dave Pagan Date: 2023-08-07T19:16:13-04:00 New Revision: f6204724df56188e82c6363aa13e1806cf6c5176 URL: https://github.com/llvm/llvm-project/commit/f6204724df56188e82c6363aa13e1806cf6c5176 DIFF: https://github.com/llvm/llvm-project/commit/f6204724df56188e82c6363aa13e1806cf6c5176.diff

[PATCH] D156523: [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written) constructor initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG291eb2589fdc: [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written)… (authored by strimo378). Changed prior to commit:

[clang] 291eb25 - [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written) constructor initializers

Author: Timo Stripf Date: 2023-08-07T23:13:50Z New Revision: 291eb2589fdc78827af6c2c858bc5e9456e3dc20 URL: https://github.com/llvm/llvm-project/commit/291eb2589fdc78827af6c2c858bc5e9456e3dc20 DIFF: https://github.com/llvm/llvm-project/commit/291eb2589fdc78827af6c2c858bc5e9456e3dc20.diff LOG:

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > enh wrote: > > ZijunZhao wrote: > > > enh wrote: > > > > is this ever _not_ set for

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > ZijunZhao wrote: > > enh wrote: > > > is this ever _not_ set for clang? > >

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) ZijunZhao wrote: > enh wrote: > > is this ever _not_ set for clang? >

[PATCH] D157331: [clang] Implement C23

ZijunZhao added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > is this ever _not_ set for clang?

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) is this ever _not_ set for clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 547986. ZijunZhao marked an inline comment as done. ZijunZhao added a comment. 1. Fix some format nits 2. Change `CHECK-NEXT` to `CHECK` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ddpagan updated this revision to Diff 547982. ddpagan added a comment. As requested, added reference to OpenMP 5.2 specification that discusses handling of if clauses with combined/composite directives. Also, improved comment relating to what was being done and why. CHANGES SINCE LAST ACTION

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

arsenm added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:832 + +inline float __ovld __cnfn sqrt(float __x) { + return __builtin_elementwise_sqrt(__x); Anastasia wrote: > arsenm wrote: > > svenvh wrote: > > > Anastasia wrote: > > > > Is this a

[PATCH] D157331: [clang] Implement C23

hiraditya added a comment. For the record, the documentation for stdckdint.h is here: https://open-std.org/JTC1/SC22/WG14/www/docs/n3096.pdf#page=330 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331

[clang] 3e66a17 - Reland [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

Author: Timo Stripf Date: 2023-08-07T22:14:15Z New Revision: 3e66a174dfd2144672cb7e23afb33df109abadd1 URL: https://github.com/llvm/llvm-project/commit/3e66a174dfd2144672cb7e23afb33df109abadd1 DIFF: https://github.com/llvm/llvm-project/commit/3e66a174dfd2144672cb7e23afb33df109abadd1.diff LOG:

[PATCH] D157331: [clang] Implement C23

hiraditya added inline comments. Comment at: clang/lib/Headers/stdckdint.h:1 +/*=== stdckdint.h - Standard header for checking integer + *-=== nit: format. Comment at: clang/test/Headers/stdckdint.cpp:1 +// RUN:

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

steven_wu added a comment. In D156014#4567446 , @jhuber6 wrote: > In D156014#4567363 , @steven_wu > wrote: > >> This breaks macOS bot: >>

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 547971. evelez7 added a comment. Refactor template arg name deduction to get as string for FragmentKind::typeIdentifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/

[PATCH] D157331: [clang] Implement C23

yabinc accepted this revision. yabinc added a comment. This revision is now accepted and ready to land. LGTM, but please wait for a couple of days in case others wish to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/

[PATCH] D156466: [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6267d3b98c1: [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 added a comment. In D156014#4567363 , @steven_wu wrote: > This breaks macOS bot: > https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/36900/testReport/junit/Clang/SemaCUDA/alias_cu/ I should've fixed that already. Is it

[clang] f6267d3 - [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts

Author: Nick Desaulniers Date: 2023-08-07T14:57:25-07:00 New Revision: f6267d3b98c11b50bf24946f21c6646d2d3f6fa8 URL: https://github.com/llvm/llvm-project/commit/f6267d3b98c11b50bf24946f21c6646d2d3f6fa8 DIFF:

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman added reviewers: aaron.ballman, hans, mstorsjo, rnk, glandium. aidengrossman added a comment. This should fix the issues seen in https://reviews.llvm.org/D150646 regarding `-fms-extensions` being set on MinGW and the builtins being defined but no `_MSC_EXTENSIONS` macro being set

[PATCH] D156378: [clang][CGExprConstant] handle unary negation on integrals

This revision was automatically updated to reflect the committed changes. Closed by commit rG769333aeeb45: [clang][CGExprConstant] handle unary negation on integrals (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 769333a - [clang][CGExprConstant] handle unary negation on integrals

Author: Nick Desaulniers Date: 2023-08-07T14:51:01-07:00 New Revision: 769333aeeb4508a39ce61cde5d70d880f9abfc35 URL: https://github.com/llvm/llvm-project/commit/769333aeeb4508a39ce61cde5d70d880f9abfc35 DIFF:

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman created this revision. Herald added subscribers: pengfei, mstorsjo. Herald added a project: All. aidengrossman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes sure _MSC_EXTENSIONS is defined if

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

steven_wu added a comment. This breaks macOS bot: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/36900/testReport/junit/Clang/SemaCUDA/alias_cu/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156014/new/

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, efriedma. Herald added subscribers: steven.zhang, pengfei. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. An empty struct is handled as a struct with a dummy i8, on

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

ldionne updated this revision to Diff 547950. ldionne added a comment. Try to fix build on queue=linux builders Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ https://reviews.llvm.org/D157324 Files:

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 547949. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/stdckdint.h clang/lib/Lex/ModuleMap.cpp

[PATCH] D157331: [clang] Implement C23

ZijunZhao created this revision. Herald added a project: All. ZijunZhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://github.com/llvm/llvm-project/issues/62248 Repository: rG LLVM Github Monorepo

[PATCH] D157246: [clang-tidy] Update tests to include C++23 and C++26

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfda777849b00: [clang-tidy] Update tests to include C++23 and C++26 (authored by avogelsgesang). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] fda7778 - [clang-tidy] Update tests to include C++23 and C++26

Author: Adrian Vogelsgesang Date: 2023-08-07T21:25:22Z New Revision: fda777849b0088ba83e28683c53c5c8321ef2558 URL: https://github.com/llvm/llvm-project/commit/fda777849b0088ba83e28683c53c5c8321ef2558 DIFF:

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17143-17145 + llvm::LoadInst *LD; + Constant *Offset, *Offset1; + Value *DP, *DP1; Move down to define and initialize Comment at:

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK rsandifo-arm wrote: > sdesmalen wrote: > > rsandifo-arm wrote: > > > Would be good to have some tests for

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen updated this revision to Diff 547936. sdesmalen marked an inline comment as done. sdesmalen added a comment. - Replaced `|=` into normal assignment `=` - Added test for global initializer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157326: [clang-tidy] Fix handling of out-of-line functions in readability-static-accessed-through-instance

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Use isStatic instead

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen added a subscriber: paulwalker-arm. sdesmalen added a comment. Thanks for the review of the Clang side @aaron.ballman and @rsandifo-arm. @paulwalker-arm would you be happy to have a look at the LLVM side of this patch? Comment at:

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen updated this revision to Diff 547933. sdesmalen marked 2 inline comments as done. sdesmalen added a comment. Removed double error message for missing 'sme' for both ZA and Streaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157246: [clang-tidy] Update tests to include C++23 and C++26

avogelsgesang updated this revision to Diff 547931. avogelsgesang added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157246/new/ https://reviews.llvm.org/D157246 Files:

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

ldionne added a subscriber: goncharov. ldionne added a comment. @goncharov Now that we have a `buildkite-pipeline.yml` for Clang, would it make sense to stop running the "builtin" jobs like https://buildkite.com/llvm-project/premerge-checks/builds/169498#0189d1af-3c81-4ab5-a87a-ac8db177ccf0

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

ldionne created this revision. Herald added a subscriber: JDevlieghere. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The libc++ builders do not have the capacity to serve both libc++ and Clang CI

[PATCH] D157321: [InstrProf] Fix macOS profile tests after D156569

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157321/new/ https://reviews.llvm.org/D157321

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

thakis added a comment. Reverted in 0342bbf223fa12701a0570a23f9eac433b8b341c for now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155895/new/ https://reviews.llvm.org/D155895 ___ cfe-commits

[clang] 0342bbf - Revert "Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`."

Author: Nico Weber Date: 2023-08-07T15:48:23-04:00 New Revision: 0342bbf223fa12701a0570a23f9eac433b8b341c URL: https://github.com/llvm/llvm-project/commit/0342bbf223fa12701a0570a23f9eac433b8b341c DIFF: https://github.com/llvm/llvm-project/commit/0342bbf223fa12701a0570a23f9eac433b8b341c.diff

[clang] 9e99a4f - [NVPTX] Fix missed test after adding alias support for NVPTX

Author: Joseph Huber Date: 2023-08-07T14:35:02-05:00 New Revision: 9e99a4f0db0e21b68e9aab9ad6f32f34d42eb460 URL: https://github.com/llvm/llvm-project/commit/9e99a4f0db0e21b68e9aab9ad6f32f34d42eb460 DIFF: https://github.com/llvm/llvm-project/commit/9e99a4f0db0e21b68e9aab9ad6f32f34d42eb460.diff

[clang-tools-extra] 1af159e - [clang-tidy][NFC] Update tests to CheckOptions using new syntax

Author: Piotr Zegar Date: 2023-08-07T19:32:27Z New Revision: 1af159e98c23a293c103e1f548866488126ed6f6 URL: https://github.com/llvm/llvm-project/commit/1af159e98c23a293c103e1f548866488126ed6f6 DIFF: https://github.com/llvm/llvm-project/commit/1af159e98c23a293c103e1f548866488126ed6f6.diff LOG:

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 547905. koops added a comment. In clang/test/OpenMP/loop_bind_enclosed.cpp Generalizing the CHECK pattern for aarch64-linux, s390x-linux and ppc64le-linux. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza added a comment. In D155895#4566903 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/82239/step_7.txt Thanks for the report! It seems that `#if defined(_WIN64) && !defined(__MINGW32__)` from

[PATCH] D157164: [clang-tidy] Add fix-it support to `llvmlibc-inline-function-decl`

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d4162ff28b4: [clang-tidy] Add fix-it support to `llvmlibc-inline-function-decl` (authored by mcgrathr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 9d4162f - [clang-tidy] Add fix-it support to `llvmlibc-inline-function-decl`

Author: Roland McGrath Date: 2023-08-07T12:15:59-07:00 New Revision: 9d4162ff28b479c93d55df67bf38507bdc50a2d1 URL: https://github.com/llvm/llvm-project/commit/9d4162ff28b479c93d55df67bf38507bdc50a2d1 DIFF:

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman added a comment. In D151683#4566907 , @eaeltsin wrote: > Hi, > > Is it a known issue, that clang doesn't compile `void foo(char *argv[] > [[maybe_unused]]) {}` ? The error is `error: 'maybe_unused' attribute cannot > be applied to types`.

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

yaxunl updated this revision to Diff 547901. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154300/new/ https://reviews.llvm.org/D154300 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ba9aec38faa: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] 0ba9aec - [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

Author: Joseph Huber Date: 2023-08-07T14:08:04-05:00 New Revision: 0ba9aec38faa8f567741fdb4eac1149c3fe94ceb URL: https://github.com/llvm/llvm-project/commit/0ba9aec38faa8f567741fdb4eac1149c3fe94ceb DIFF: https://github.com/llvm/llvm-project/commit/0ba9aec38faa8f567741fdb4eac1149c3fe94ceb.diff

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

eaeltsin added a comment. Hi, Is it a known issue, that clang doesn't compile `void foo(char *argv[] [[maybe_unused]]) {}` ? https://godbolt.org/z/r9E81cWxh - clang fails, but gcc doesn't. It looks like there is a lot of oss code of the form `void foo(char *argv[] ATTRIBUTE_UNUSED)`, where

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12758-12764 +std::optional MorePreferableByCUDA = +CheckCUDAPreference(FD, Result); +// If FD has different CUDA preference than Result.

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/82239/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155895/new/

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/include/clang/AST/Expr.h:1279 + explicit DeclRefExpr(EmptyShell Empty) : Expr(DeclRefExprClass, Empty) { +DeclRefExprBits.CapturedByCopyInLambdaWithExplicitObjectParameter = false; + } aaron.ballman wrote:

[PATCH] D157164: [clang-tidy] Add fix-it support to `llvmlibc-inline-function-decl`

PiotrZSL added a comment. Release notes are missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157164/new/ https://reviews.llvm.org/D157164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dde755188e3: [AggressiveInstCombine][NFC] Fix typo (authored by kitaisreal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157227: [Clang] Don't add `undef` for `operator new` under -fno-exceptions.

ldionne added a comment. In D157227#4564817 , @nikic wrote: > Removing noundef makes no sense to me, because the return value is noundef > even under fno-exceptions. If we remove something, it should be the nonnull > attribute, because that's what's

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

craig.topper added a comment. This looks good to me, but I'm not sure I'm a fully qualified reviewer here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 ___ cfe-commits mailing list

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

smeenai added a comment. Thanks for the rebase! We're eager to try this for Meta's Android apps, where size is a priority and better `noexcept` codegen would be really helpful. I ran into a crash with coroutines though, which blocks me from fully evaluating the size difference made by these

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.empty() ? Loc : Args.back()->getEndLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, EndLoc, nullptr); } hokein wrote: > Thanks for the

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

hokein added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.empty() ? Loc : Args.back()->getEndLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, EndLoc, nullptr); } Thanks for the fast fix. Reading the

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 547884. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157157/new/ https://reviews.llvm.org/D157157 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/fsplit-machine-functions.c Index:

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157296/new/ https://reviews.llvm.org/D157296

[PATCH] D154559: [clang] Fix constant evaluation about static member function

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. Clang was correct here until fairly recently; P2280 (https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html) changed the language

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok added inline comments. Comment at: clang/test/Sema/format-pointer.c:39 + printf("%p", np); + scanf("%p", ); // expected-warning {{format specifies type 'void **' but the argument has type 'nullptr_t *'}} + scanf("%p", ); // pedantic-warning {{format specifies

  1   2   3   >