[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 added reviewers: MaskRay, jdoerfert, awarzynski. kaz7 added a comment. I randamly added reviewrs who review code related to feature flags and features group in clang. I appreciate if some of you guys have a time to check this patch too. Thank you so much. Repository: rG LLVM Github

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 550185. 4vtomat added a comment. 1. Apply clang-format for this patch 2. Replace FileCheck --implicit-check-not=warning: with %clang -Werror Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

ChuanqiXu marked 4 inline comments as done. ChuanqiXu added a comment. Address comments. Thanks for reviewing. Comment at: clang/lib/CodeGen/CGCall.cpp:5496 + // execution of the await_suspend. To achieve this, we need to prevent the + // await_suspend get inlined before

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

ChuanqiXu updated this revision to Diff 550181. ChuanqiXu added a comment. Address comments: - Remove the complicated TypeVisitor, use the simple `getNonReferenceType()->getAsCXXRecordDecl()` form instead. - Reword `*leak*` to `*escape*`. - Use the suggested comments. CHANGES SINCE LAST

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat marked 2 inline comments as done. 4vtomat added a comment. In D146054#4586067 , @MaskRay wrote: > I think the best place to test `RISCVISAInfo.cpp` is > `llvm/unittests/Support/RISCVISAInfoTest.cpp`. > >

[PATCH] D157777: [ASTMatcher] Add matcher for 'MacroQualifiedType'

danix800 updated this revision to Diff 550178. danix800 added a comment. 1. Improve matcher description 2. Add a counter-example for test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files:

[PATCH] D157777: [ASTMatcher] Add matcher for 'MacroQualifiedType'

danix800 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7261 +/// Matches macro qualified types. +/// aaron.ballman wrote: > How about: Matches qualified types when the qualifier is applied via a macro. > > and then a second

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

ABataev added a comment. In D157933#4587164 , @mdfazlay wrote: > In D157933#4586816 , @ABataev wrote: > >> Need to add the tests (and the checks, if required) for the nesting of the >> regions > > I think I have

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay added a comment. In D157933#4586816 , @ABataev wrote: > Need to add the tests (and the checks, if required) for the nesting of the > regions I think I have the nesting of regions checks in //scope_messages.cpp//. Do you prefer to have those

[PATCH] D126586: [InstrProf][WIP] Implement boolean counters in coverage

gulfem updated this revision to Diff 550163. gulfem added a comment. - Extend the prototype by implementing the rest of the control-flow statements - Rename the prototype to single byte counters to be consistent with the single byte coverage used in PGO Repository: rG LLVM Github Monorepo

[PATCH] D157944: [InstrProf] Single byte counters in coverage

gulfem created this revision. Herald added subscribers: wlei, ellis, wenlei. Herald added a project: All. gulfem requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch inserts 1-byte counters instead of an 8-byte counters into llvm

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

danix800 updated this revision to Diff 550160. danix800 added a comment. 1. Add unit testcase 2. Use better API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157691/new/ https://reviews.llvm.org/D157691 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

felix642 updated this revision to Diff 550159. felix642 added a comment. Updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157829/new/ https://reviews.llvm.org/D157829 Files:

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

felix642 updated this revision to Diff 550156. felix642 added a comment. Code review Move constructor to cpp file Added store options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157829/new/ https://reviews.llvm.org/D157829 Files:

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

thakis added a comment. Hello, one of the many dump commits broke tests on macOS: http://45.33.8.238/macm1/67030/step_7.txt Please take a look and revert for now if it takes a while to fix. Also, consider spreading out commits a bit so that if one breaks something, it's easily to see which

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner added inline comments. Comment at: llvm/include/llvm/Option/OptParser.td:153 class Flags flags> { list Flags = flags; } +class Vis vis> { list Vis = vis; } class Group { OptionGroup Group = group; } phosek wrote: > Would it be possible to spell this out

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

hubert.reinterpretcast added a comment. Thanks, @cor3ntin, for addressing my feedback. I am not familiar enough with various aspects of it to approve it, but I see Aaron has already approved it and I think all comments have been addressed. I also appreciate that the patch helps towards making

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

jhuber6 updated this revision to Diff 550140. jhuber6 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157738/new/ https://reviews.llvm.org/D157738 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

phosek added inline comments. Comment at: llvm/include/llvm/Option/OptParser.td:153 class Flags flags> { list Flags = flags; } +class Vis vis> { list Vis = vis; } class Group { OptionGroup Group = group; } Would it be possible to spell this out in full, that

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan marked an inline comment as done. shenhan added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1281-1282 +else + WithColor::warning() + << "-fsplit-machine-functions is only valid for X86.\n"; } arsenm wrote: >

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550137. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

paulkirth added a comment. Hi, we're seeing a test failure in our CI after this stack. Not exactly sure which commit though. You can find the failing bot here: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8772753421607483249/overview Some test output

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

bogner updated this revision to Diff 550125. bogner edited the summary of this revision. bogner added a comment. Rebase on top of "DefaultVis" naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157150/new/ https://reviews.llvm.org/D157150

[PATCH] D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a135bceb66b: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets. (authored by jroelofs). Repository: rG LLVM Github

[clang] 1a135bc - [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

Author: Jon Roelofs Date: 2023-08-14T16:22:48-07:00 New Revision: 1a135bceb66b2d448ba4363af2f8626b6e4110bd URL: https://github.com/llvm/llvm-project/commit/1a135bceb66b2d448ba4363af2f8626b6e4110bd DIFF: https://github.com/llvm/llvm-project/commit/1a135bceb66b2d448ba4363af2f8626b6e4110bd.diff

[clang] b7e1d26 - Revert "[clang] Add missing field to VisibilityAttr json AST dump"

Author: Douglas Yung Date: 2023-08-14T16:15:30-07:00 New Revision: b7e1d26f841c7ef3db46d30239c179a1e1b4d156 URL: https://github.com/llvm/llvm-project/commit/b7e1d26f841c7ef3db46d30239c179a1e1b4d156 DIFF: https://github.com/llvm/llvm-project/commit/b7e1d26f841c7ef3db46d30239c179a1e1b4d156.diff

[clang] 4ac4d4a - Revert "[clang] Add missing field to TLSModelAttr json AST dump"

Author: Douglas Yung Date: 2023-08-14T16:14:28-07:00 New Revision: 4ac4d4a9777e47324766aef80cfd094d06b460ec URL: https://github.com/llvm/llvm-project/commit/4ac4d4a9777e47324766aef80cfd094d06b460ec DIFF: https://github.com/llvm/llvm-project/commit/4ac4d4a9777e47324766aef80cfd094d06b460ec.diff

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana added inline comments. Comment at: clang/test/Headers/stdarg.c:34 +__va_copy(g, v); +va_copy(g, v); // c89-error{{implicit}} c89-note{{va_copy}} c99-no-diagnostics +} aaron.ballman wrote: > You should spell out these diagnostics, and I think

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana updated this revision to Diff 550121. iana marked 4 inline comments as done. iana added a comment. Review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157793/new/ https://reviews.llvm.org/D157793 Files: clang/lib/Headers/stdarg.h

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

ABataev added a comment. Need to add the tests (and the checks, if required) for the nesting of the regions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157933/new/ https://reviews.llvm.org/D157933

[PATCH] D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

tellenbach accepted this revision. tellenbach added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157925/new/ https://reviews.llvm.org/D157925

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay created this revision. mdfazlay added reviewers: ABataev, jyu2, mikerice. Herald added subscribers: steakhal, martong, arphaman, guansong, yaxunl. Herald added a reviewer: NoQ. Herald added a project: All. mdfazlay requested review of this revision. Herald added a reviewer: jdoerfert.

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1996-1997 +llvm::GlobalValue *GV) { + std::optional ActiveAttr = +

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19f2b68095fe: Make globals with mutable members non-constant, even in custom sections (authored by dblaikie). Repository: rG LLVM Github Monorepo

[clang] 19f2b68 - Make globals with mutable members non-constant, even in custom sections

Author: David Blaikie Date: 2023-08-14T22:25:42Z New Revision: 19f2b68095fe727e40079b7c6380b36b6462e691 URL: https://github.com/llvm/llvm-project/commit/19f2b68095fe727e40079b7c6380b36b6462e691 DIFF: https://github.com/llvm/llvm-project/commit/19f2b68095fe727e40079b7c6380b36b6462e691.diff

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. In D74094#4566543 , @nickdesaulniers wrote: > Hi @lei can you please help us retest this version of this patch that > previously broke your multistage build? >

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

dyung added a comment. Hi @serge-sans-paille, your change is causing the test you modified, `clang/test/AST/ast-dump-attr-json.cpp` to fail. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/47461 https://lab.llvm.org/buildbot/#/builders/109/builds/71264 Repository:

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

JonChesterfield added a comment. Ok, I'm really sure this needs to be reflected in the type system. for some target foo gets to be larger than 8 bytes and we use a different calling convention for it. Otherwise however we carve this the type erasure is going to make unrelated calls acquire

[PATCH] D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

jroelofs created this revision. jroelofs added reviewers: aemerson, tellenbach. Herald added subscribers: ormris, inglorion. Herald added a project: All. jroelofs requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. ... that have the

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157332/new/ https://reviews.llvm.org/D157332

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1996-1997 +llvm::GlobalValue *GV) { + std::optional ActiveAttr = + OMPDeclareTargetDeclAttr::getActiveAttr(FD); + not a huge fan

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

JonChesterfield added a comment. If calling an indirect function pointer on the GPU requires a table lookup (keyed by host function addresses, which I didn't think we knew at GPU compile time), and we cannot distinguish indirect function pointers from function pointers, then this feature must

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

RaviNarayanaswamy added a comment. In D157738#4586465 , @JonChesterfield wrote: >> calling device functions via their associated host pointer > > What does this mean? Defining a function foo such that the host and each > individual target each have

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

rjmccall added a comment. The path of least resistance here is that IRGen should just insert conversions from the global AS to the default AS as part of evaluating `typeid`. I haven't looked at it closely, but that seems to be what this patch is doing. However, `std::type_info` is an

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156726/new/ https://reviews.llvm.org/D156726 ___ cfe-commits mailing list

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -if (var->getType().isConstQualified()) { - if (HasConstInit) rnk wrote: > efriedma wrote: > > dblaikie wrote: > > > efriedma

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie updated this revision to Diff 550097. dblaikie added a comment. Diagnose specific reasons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156726/new/ https://reviews.llvm.org/D156726 Files: clang/include/clang/AST/Type.h

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 ___ cfe-commits mailing list

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

jhuber6 added a comment. In D157738#4586465 , @JonChesterfield wrote: >> calling device functions via their associated host pointer > > What does this mean? Defining a function foo such that the host and each > individual target each have their own

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

JonChesterfield added a comment. > calling device functions via their associated host pointer What does this mean? Defining a function foo such that the host and each individual target each have their own machine code for it, such that can be copied over to the target and then invoked to mean

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked an inline comment as done. iana added inline comments. Comment at: clang/lib/Headers/stddef.h:16 +defined(__need_wint_t) || \ +(defined(__STDC_WANT_LIB_EXT1__) && __STDC_WANT_LIB_EXT1__ >= 1)

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 550091. iana marked 3 inline comments as done. iana added a comment. Review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 Files: clang/lib/Headers/stddef.h

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

fakepaper56 updated this revision to Diff 550089. fakepaper56 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157362/new/ https://reviews.llvm.org/D157362 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D157917: clang/HIP: Use abs builtins instead of implementing them

arsenm created this revision. arsenm added reviewers: yaxunl, AlexVlx, JonChesterfield, jhuber6, doru1004. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. InstCombine already put these back together so there's no visible change in the -O1

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 550083. fakepaper56 added a comment. Update docs/RISCVUsage.rst to move zicfiss to experimental extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files:

[PATCH] D157814: [clang] Add missing field to TLSModelAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2105c32b32bf: [clang] Add missing field to TLSModelAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2107d87c5a91: [clang] Add missing field to VisibilityAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 550079. fakepaper56 added a comment. Update docs/RISCVUsage.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files:

[PATCH] D157795: [clang] Add missing field to SectionAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cf7666b8f09: [clang] Add missing field to SectionAttr json AST dump (authored by serge-sans-paille). Changed prior to commit:

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3dadc290b210: [clang] Add missing fields to DeprecatedAttr and Unavailable json AST dump (authored by serge-sans-paille). Repository: rG LLVM

[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG903e530bb898: [clang] Add cleanup_function field to CleanupAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github

[PATCH] D157775: [clang] Add aliasee field to AliasAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11f3286585ce: [clang] Add aliasee field to AliasAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2105c32 - [clang] Add missing field to TLSModelAttr json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:45+02:00 New Revision: 2105c32b32bf3360f524f1f3a1e5af605821eff8 URL: https://github.com/llvm/llvm-project/commit/2105c32b32bf3360f524f1f3a1e5af605821eff8 DIFF:

[clang] 2107d87 - [clang] Add missing field to VisibilityAttr json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:45+02:00 New Revision: 2107d87c5a9103ffc4c0f76fc00ab203603f9df1 URL: https://github.com/llvm/llvm-project/commit/2107d87c5a9103ffc4c0f76fc00ab203603f9df1 DIFF:

[clang] 4cf7666 - [clang] Add missing field to SectionAttr json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:45+02:00 New Revision: 4cf7666b8f0962a21ab06769254391f633f07d1d URL: https://github.com/llvm/llvm-project/commit/4cf7666b8f0962a21ab06769254391f633f07d1d DIFF:

[clang] 3dadc29 - [clang] Add missing fields to DeprecatedAttr and Unavailable json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:45+02:00 New Revision: 3dadc290b21018d528bd6e46d8d596e1dbb68f3d URL: https://github.com/llvm/llvm-project/commit/3dadc290b21018d528bd6e46d8d596e1dbb68f3d DIFF:

[clang] 903e530 - [clang] Add cleanup_function field to CleanupAttr json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:45+02:00 New Revision: 903e530bb8980a3c30ea5eb98d2ec1cd61d94b57 URL: https://github.com/llvm/llvm-project/commit/903e530bb8980a3c30ea5eb98d2ec1cd61d94b57 DIFF:

[clang] 11f3286 - [clang] Add aliasee field to AliasAttr json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:40+02:00 New Revision: 11f3286585ce86df8107617536226dea24e74d94 URL: https://github.com/llvm/llvm-project/commit/11f3286585ce86df8107617536226dea24e74d94 DIFF:

[PATCH] D157497: feat: Migrate isArch16Bit

bulbazord added a comment. In D157497#4586165 , @MaskRay wrote: > In D157497#4584621 , @Pivnoy wrote: > >> This discussion was the main motivation for this change. >>

[PATCH] D157904: Improve reliability of CompilationDatabaseTest

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e11d6850a5a: Improve reliability of CompilationDatabaseTest (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9e11d68 - Improve reliability of CompilationDatabaseTest

Author: Ellis Hoag Date: 2023-08-14T13:46:21-07:00 New Revision: 9e11d6850a5a5a3518f300769724a5c13d2e6ec6 URL: https://github.com/llvm/llvm-project/commit/9e11d6850a5a5a3518f300769724a5c13d2e6ec6 DIFF: https://github.com/llvm/llvm-project/commit/9e11d6850a5a5a3518f300769724a5c13d2e6ec6.diff

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

efriedma added a comment. RecordDecl::hasFlexibleArrayMember() is supposed to reflect the standard's definition of a flexible array member, which only includes incomplete arrays. The places that care about other array members use separate checks. We wouldn't want to accidentally extend the

[PATCH] D157374: [clang-tidy] Ignore decltype in misc-redundant-expression

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157374/new/ https://reviews.llvm.org/D157374

[PATCH] D157326: [clang-tidy] Fix handling of out-of-line functions in readability-static-accessed-through-instance

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157326/new/ https://reviews.llvm.org/D157326

[clang] 4e3b894 - Revert "[Option] Add "Visibility" field and clone the OptTable APIs to use it"

Author: Justin Bogner Date: 2023-08-14T13:31:02-07:00 New Revision: 4e3b89483a6922d3f48670bb1c50a37f342918c6 URL: https://github.com/llvm/llvm-project/commit/4e3b89483a6922d3f48670bb1c50a37f342918c6 DIFF: https://github.com/llvm/llvm-project/commit/4e3b89483a6922d3f48670bb1c50a37f342918c6.diff

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 updated this revision to Diff 550067. qiongsiwu1 added a comment. Fixing method parameter name format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 Files: clang/docs/UsersManual.rst

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa16104e6da6f: [Option] Add Visibility field and clone the OptTable APIs to use it (authored by bogner). Repository: rG LLVM Github Monorepo

[clang] a16104e - [Option] Add "Visibility" field and clone the OptTable APIs to use it

Author: Justin Bogner Date: 2023-08-14T13:24:54-07:00 New Revision: a16104e6da6f36f3d72dbf53d10ba56495a0d65a URL: https://github.com/llvm/llvm-project/commit/a16104e6da6f36f3d72dbf53d10ba56495a0d65a DIFF: https://github.com/llvm/llvm-project/commit/a16104e6da6f36f3d72dbf53d10ba56495a0d65a.diff

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16876 + // other types. + if (CodePoint <= UCHAR_MAX) { +StringRef Escaped = escapeCStyle(CodePoint); cor3ntin wrote: > hubert.reinterpretcast wrote: > > For types

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

sammccall accepted this revision. sammccall added a comment. Still LG once you're happy Comment at: clang/include/clang/Sema/Sema.h:3026 + void ActOnParamDefaultArgumentError(Decl *param, SourceLocation EqualLoc, + ExprResult DefaultArg);

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added a comment. In D155610#4586213 , @abhina.sreeskantharajan wrote: > I've discussed offline with @hubert.reinterpretcast and agree with him that > with the addition of fexec-charset support, the set of characters deemed >

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

beanz accepted this revision. beanz added a comment. LGTM. This is definitely an improvement over the awfulness we were doing. Thanks @bogner! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157149/new/ https://reviews.llvm.org/D157149

[PATCH] D157885: [NFC][Clang] Fix static analyzer concern about null value derefence

This revision was automatically updated to reflect the committed changes. Closed by commit rGc70dab026d37: [NFC][Clang] Fix static analyzer concern about null value dereference (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c70dab0 - [NFC][Clang] Fix static analyzer concern about null value dereference

Author: Elizabeth Andrews Date: 2023-08-14T13:07:24-07:00 New Revision: c70dab026d377736c1281d3c8005bb5e578ec8b3 URL: https://github.com/llvm/llvm-project/commit/c70dab026d377736c1281d3c8005bb5e578ec8b3 DIFF:

[PATCH] D155081: Specify the developer policy around links to external resources

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. Looks like a great improvement to the policy, thank you all for sorting through this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

abhina.sreeskantharajan added a comment. I've discussed offline with @hubert.reinterpretcast and agree with him that with the addition of fexec-charset support, the set of characters deemed printable will not be accurate when other encodings are used. This will be similar to the printf/scanf

[PATCH] D157905: [include-cleaner] Filter references to identity macros

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:37 +namespace { +bool shouldSkipMacro(const Macro ) { + static const auto *MacroNamesToIgnore = new

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews added a comment. In D157888#4586126 , @steakhal wrote: > Hmm. I guess the assertion is to silence some tool. And I think actually that > function might very well also return null in some cases. > Why do you think it cannot or at least should

[PATCH] D157913: [WIP][Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu created this revision. Herald added subscribers: Enna1, hiraditya. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Debug info correlation is an option

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner updated this revision to Diff 550055. bogner edited the summary of this revision. bogner added a comment. Update comment wording to be less ambiguous about flags vs visibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157149/new/

[PATCH] D157497: feat: Migrate isArch16Bit

MaskRay added a comment. In D157497#4584621 , @Pivnoy wrote: > This discussion was the main motivation for this change. > https://discourse.llvm.org/t/rfc-refactor-triple-related-classes/70410/11 > As a result, Triple should become a data class, and its

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf58330cbe445: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially (authored by bogner). Changed prior to commit:

[clang] f58330c - [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

Author: Justin Bogner Date: 2023-08-14T12:27:13-07:00 New Revision: f58330cbe44598eb2de0cca3b812f67fea0a71ca URL: https://github.com/llvm/llvm-project/commit/f58330cbe44598eb2de0cca3b812f67fea0a71ca DIFF: https://github.com/llvm/llvm-project/commit/f58330cbe44598eb2de0cca3b812f67fea0a71ca.diff

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

awarzynski added a comment. Thanks for the updates - this is looking really good! A few more suggestions and then I'll scan the whole thing again (sorry, there's been quite a lot of code going back and forth). Comment at: flang/lib/Frontend/CompilerInvocation.cpp:1024 +

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

MaskRay accepted this revision. MaskRay added subscribers: python3kgae, beanz. MaskRay added a comment. This revision is now accepted and ready to land. > ... but it really doesn't scale well, as can be seen by things like the > somewhat recently introduced CLDXCOption. FYI @beanz @python3kgae

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

tra added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

mstorsjo added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4ada13e4b3e: [NFC][Clang] Fix static analyzer concern about null value dereference (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true, PGOOpt->CSProfileGenFile, -PGOOpt->ProfileRemappingFile, +

  1   2   3   >