[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added inline comments. Comment at: clang/lib/Headers/stddef.h:118-122 +#ifdef __cplusplus +namespace std { +typedef decltype(nullptr) nullptr_t; +} +using ::std::nullptr_t; aaron.ballman wrote: > ldionne wrote: > > iana wrote: > > > aaron.ballman wrote: > >

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 552591. iana added a comment. Only define nullptr_t in C++ if _MSC_EXTENSIONS is defined, even if __need_nullptr_t is explicitly set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:767-772 + std::optional T = classify(E->getType()); + if (T && E->hasAPValueResult() && + this->visitAPValue(E->getAPValueResult(), *T, E)) +return true; + return

[PATCH] D158499: [analyzer] Compute FAM dynamic size

danix800 added a comment. We have `getDynamicExtentWithOffset` to use, which can handle more general dynamic memory based cases than this fix. I'll abandon this one. There are issues worth clarifying and fixing: 1). Debugging APIs like `clang_analyzer_dumpExtent` in `ExprInspection` might be

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

fcloutier added inline comments. Comment at: clang/lib/AST/FormatString.cpp:480-481 + break; +case BuiltinType::Half: +case BuiltinType::Float16: +case BuiltinType::Float: aaron.ballman wrote: > Should these be

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

fcloutier updated this revision to Diff 552579. fcloutier marked an inline comment as done. fcloutier added a comment. Add release note, ensure `bool` as a formatted formal parameter is accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158318/new/ https://reviews.llvm.org/D158318

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

shafik added a comment. So while working on D148474 I realized this PR introduced a new crash bug, see the following code: https://godbolt.org/z/h1EezGjbr template class B3 : A3 { template()> B3(); }; B3(); which is one of my test

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

owenpan added a comment. In D156259#4607177 , @jp4a50 wrote: > Addressed all comments. Please let me know if there's anything else required > before merging. There are still a couple of comments unaddressed plus another that asked for changing `!is()`

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552575. AlexVlx edited the summary of this revision. AlexVlx added a comment. Updating to reflect the outcome of the RFC, which is that this will be added as a HIP extension exclusively. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/

[PATCH] D158484: [PowerPC][altivec] Correct modulo number of vec_promote on vector char

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b6ea93125bd: [PowerPC][altivec] Correct modulo number of vec_promote on vector char (authored by lkail). Repository: rG LLVM Github Monorepo

[clang] 6b6ea93 - [PowerPC][altivec] Correct modulo number of vec_promote on vector char

Author: Kai Luo Date: 2023-08-23T01:58:36Z New Revision: 6b6ea93125bd834cae22149e18b742d498dc79a3 URL: https://github.com/llvm/llvm-project/commit/6b6ea93125bd834cae22149e18b742d498dc79a3 DIFF: https://github.com/llvm/llvm-project/commit/6b6ea93125bd834cae22149e18b742d498dc79a3.diff LOG:

[PATCH] D155833: [HIP][Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552568. AlexVlx retitled this revision from "[Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload" to "[HIP][Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload". AlexVlx added a comment. Updating this to reflect the

[PATCH] D158469: [clang][deps] Compute command lines and file deps on-demand

jansvoboda11 updated this revision to Diff 552566. jansvoboda11 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158469/new/ https://reviews.llvm.org/D158469 Files:

[PATCH] D158346: [clang-tidy] readability-container-size-empty - detect missing usage of .empty() on string_literals

rnk added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp:26 +namespace string_literals{ +string operator""s(const char *, size_t); +} I discovered that this test started to fail when I landed my

[PATCH] D158573: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added subscribers: ributzka, arphaman. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When loading

[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552561. AlexVlx retitled this revision from "[Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload" to "[HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload". AlexVlx added a comment.

[clang-tools-extra] ba52a10 - [clang-tidy] Fix test to not depend on D153156, which was reverted

Author: Reid Kleckner Date: 2023-08-22T18:39:19-07:00 New Revision: ba52a10fca6fc7b791894c584233db012def68a5 URL: https://github.com/llvm/llvm-project/commit/ba52a10fca6fc7b791894c584233db012def68a5 DIFF: https://github.com/llvm/llvm-project/commit/ba52a10fca6fc7b791894c584233db012def68a5.diff

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ updated this revision to Diff 552560. NoQ added a comment. Rebase. Make warnings a bit more verbose than before. This plays nicely with our attempts to categorize unemitted fixits via `-mllvm -debug-only=SafeBuffers`, but this time it doesn't make sense to make the extra information

[PATCH] D158523: [clang][doc] Mentions -Wno-reserved-module-identifiers

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158523/new/ https://reviews.llvm.org/D158523

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch replaces absolute

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552556. AlexVlx retitled this revision from "[Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload" to "[HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload". AlexVlx added a comment. Updating this to reflect

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

rnk added a comment. I went ahead and pushed a revert of this, since this change was pretty disruptive, at least in our experience. I could be convinced that it's worth sunsetting this extension for accepting C-style format string macro code, but that doesn't seem like the original intent of

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 552554. void added a comment. Fix clang-ast-dump issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h

[clang] 0d9919d - Revert "[Clang] CWG1473: do not err on the lack of space after operator"""

Author: Reid Kleckner Date: 2023-08-22T18:10:41-07:00 New Revision: 0d9919d362a7a70b2a7970861d897ecc47ec9e4d URL: https://github.com/llvm/llvm-project/commit/0d9919d362a7a70b2a7970861d897ecc47ec9e4d DIFF: https://github.com/llvm/llvm-project/commit/0d9919d362a7a70b2a7970861d897ecc47ec9e4d.diff

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void added inline comments. Comment at: clang/lib/AST/Decl.cpp:4541-4544 +bool FieldDecl::isFlexibleArrayMemberLike( +ASTContext , +LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel, +bool IgnoreTemplateOrMacroSubstitution) const {

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 552552. void marked 3 inline comments as done. void added a comment. Address Nick's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files:

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552550. AlexVlx marked an inline comment as done. AlexVlx retitled this revision from "[Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload" to "[HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload". AlexVlx removed

[PATCH] D158571: [clang-format][NFC] Replace !is() with isNot()

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D158570: [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim

thetruestblue created this revision. thetruestblue added reviewers: kubamracek, yln, rsundahl, wrotki, usama54321, MaskRay, vitalybuka. Herald added a subscriber: Enna1. Herald added a project: All. thetruestblue requested review of this revision. Herald added projects: clang, Sanitizers. Herald

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya updated this revision to Diff 552543. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 Files: clang-tools-extra/clangd/CMakeLists.txt Index:

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ABataev added a comment. In D158559#4608410 , @ivanrodriguez3753 wrote: > Also, should the underlying issue and test case be filed as an issue on > Github? I wasn't sure since this revision includes the bug and a description If you're going to fix

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ABataev added a comment. In D158559#4608397 , @ivanrodriguez3753 wrote: > In D158559#4608388 , @ABataev wrote: > >> 1. Always provide full context in the patch. > > Sure, would you mind mentioning what's

[clang] dddfd93 - Revert "Test commit config"

Author: erichkeane Date: 2023-08-22T16:43:34-07:00 New Revision: dddfd93792b31e4bbeaeca3fe68fcefb289cfb51 URL: https://github.com/llvm/llvm-project/commit/dddfd93792b31e4bbeaeca3fe68fcefb289cfb51 DIFF: https://github.com/llvm/llvm-project/commit/dddfd93792b31e4bbeaeca3fe68fcefb289cfb51.diff

[clang] 3e50bcb - Test commit config

Author: erichkeane Date: 2023-08-22T16:39:30-07:00 New Revision: 3e50bcb44b7e850032d928ce53a582891336bc87 URL: https://github.com/llvm/llvm-project/commit/3e50bcb44b7e850032d928ce53a582891336bc87 DIFF: https://github.com/llvm/llvm-project/commit/3e50bcb44b7e850032d928ce53a582891336bc87.diff

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, serge-sans-paille, nickdesaulniers, tbaeder. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch warns on `snprintf` calls whose `n` argument is known to be

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

shafik added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.empty() ? Loc : Args.back()->getEndLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, EndLoc, nullptr); } We should use

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4608428 , @thakis wrote: > I think this is a useful feature, for the reasons mentioned on the thread. > > Since this is a superset of D115049 (... > right?), this should probably

[PATCH] D141414: [clang] add warning on shifting boolean type

angelomatnigoogle added a comment. Pardon me for losing sight on this change. Within the week, I will revisit this change based on the current outstanding comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141414/new/

[PATCH] D158476: [driver] Search for compatible Android runtime directories

thakis added a comment. I think this is a useful feature, for the reasons mentioned on the thread. Since this is a superset of D115049 (... right?), this should probably revert the changes over there? Maybe we should dump searched paths in `-v` mode?

[PATCH] D158561: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The debug note for an unclaimed DRE

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ivanrodriguez3753 added a comment. Also, should the underlying issue and test case be filed as an issue on Github? I wasn't sure since this revision includes the bug and a description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158559/new/

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ivanrodriguez3753 added a comment. In D158559#4608388 , @ABataev wrote: > 1. Always provide full context in the patch. Sure, would you mind mentioning what's missing? Or do you mean the stuff from debug output being shortened, as well as LLVM IR being

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ABataev added a comment. 1. Always provide full context in the patch. 2. It looks like we're counting the pointer size (or the size of just the first element of the array), because we do not account array section here, either just the pointer or the first element only (most probably second

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +//

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik added a comment. In D158557#4608262 , @erichkeane wrote: > Are there any Sema tests we can add to show that we warn/diagnose/SOMETHING > on these? If someone passes a negative size, we should probably at least do > the warning that it was

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik updated this revision to Diff 552518. shafik added a comment. -Updated values used in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-string.cpp Index:

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik updated this revision to Diff 552516. shafik added a comment. - Diff w/ context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-string.cpp Index:

[clang] 0d592c8 - [Driver][PS5] Simplify a condition

Author: Paul Robinson Date: 2023-08-22T15:01:55-07:00 New Revision: 0d592c8d49bc734e3807bd7093f61e634e8194cf URL: https://github.com/llvm/llvm-project/commit/0d592c8d49bc734e3807bd7093f61e634e8194cf DIFF: https://github.com/llvm/llvm-project/commit/0d592c8d49bc734e3807bd7093f61e634e8194cf.diff

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe81744563a53: [clang][ExtractAPI] Fix bool spelling coming from the macro definition. (authored by evelez7). Repository: rG LLVM Github Monorepo

[clang] e817445 - [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

Author: Erick Velez Date: 2023-08-22T15:00:14-07:00 New Revision: e81744563a53b1ed0aaa2cefda885287974a9e21 URL: https://github.com/llvm/llvm-project/commit/e81744563a53b1ed0aaa2cefda885287974a9e21 DIFF: https://github.com/llvm/llvm-project/commit/e81744563a53b1ed0aaa2cefda885287974a9e21.diff

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ivanrodriguez3753 created this revision. ivanrodriguez3753 added a reviewer: OpenMP. Herald added subscribers: pengfei, guansong, tpr, yaxunl. Herald added a project: All. ivanrodriguez3753 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers:

[PATCH] D157385: [clang][CFG] Cleanup functions

aaronpuchert added inline comments. Comment at: clang/test/Analysis/scopes-cfg-output.cpp:1480 +public: + ~F() {} +}; tbaeder wrote: > aaronpuchert wrote: > > As with the cleanup function, a definition shouldn't be necessary. > Is there a way to test whether

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

dblaikie added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +//

[PATCH] D158534: [clang-tidy] Disable trivially-destructible check for darwin

hiraditya abandoned this revision. hiraditya added a comment. In D158534#4607719 , @PiotrZSL wrote: > 626849c71e85d546a004cc91866beab610222194 > didn't > fix this issue already ? ah

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks reopened this revision. aeubanks added a comment. This revision is now accepted and ready to land. reverted in 9b6b6bbc9127d604881cdc9dcea0e7c74ef821fd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a side effect, introduce

[clang] 9b6b6bb - Revert "[Profile] Allow online merging with debug info correlation."

Author: Arthur Eubanks Date: 2023-08-22T14:34:46-07:00 New Revision: 9b6b6bbc9127d604881cdc9dcea0e7c74ef821fd URL: https://github.com/llvm/llvm-project/commit/9b6b6bbc9127d604881cdc9dcea0e7c74ef821fd DIFF:

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

erichkeane added a comment. Are there any Sema tests we can add to show that we warn/diagnose/SOMETHING on these? If someone passes a negative size, we should probably at least do the warning that it was converted/truncated. Comment at: clang/lib/AST/ExprConstant.cpp:9357

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, davide, rsmith. Herald added a project: All. shafik requested review of this revision. The implementation of `__builtin_strncmp` and other related builtins function use `getExtValue()` to evaluate the size argument.

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; aeubanks wrote: >

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

evelez7 updated this revision to Diff 552504. evelez7 added a comment. Use clang instead of clang_cc1 like other C tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158474/new/ https://reviews.llvm.org/D158474 Files:

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

erjin updated this revision to Diff 552498. erjin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158430/new/ https://reviews.llvm.org/D158430 Files: clang/include/clang/Driver/Options.td flang/test/Driver/misc-flags.f90

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9512 uint64_t TSize = Info.Ctx.getTypeSizeInChars(T).getQuantity(); +if (TSize == 0) + return false; I think we should issue a diagnostic, we don't have any indication that

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +//

[clang] f2b150b - Summary:

Author: zhijian Date: 2023-08-22T16:29:22-04:00 New Revision: f2b150b4501ff8978ce19b0727225a6817be1dc7 URL: https://github.com/llvm/llvm-project/commit/f2b150b4501ff8978ce19b0727225a6817be1dc7 DIFF: https://github.com/llvm/llvm-project/commit/f2b150b4501ff8978ce19b0727225a6817be1dc7.diff LOG:

[PATCH] D157565: [CodeGen] Add AArch64 behavior to existing MFS tests

dhoekwater marked an inline comment as done. dhoekwater added a comment. Relanded in 90ab85a1b2e72f63039fadf6669b23f52192defd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG. Please, update docs/OpenMPSupport.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157933/new/ https://reviews.llvm.org/D157933

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay added a comment. In D157933#4591627 , @ABataev wrote: > Could you also add the nesting tests for outer scope directive? Currently it > tests only for inner Added. Please take a look. CHANGES SINCE LAST ACTION

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

NoQ added a comment. In D157441#4575220 , @ziqingluo-90 wrote: >>> Extend PointerAssignmentGadget and PointerInitGadget to generate fix-its >>> for cases where the left-hand side >>> has won't fix strategy and the right-hand side has std::span

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

dexonsmith added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +//

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

MitalAshok updated this revision to Diff 552477. MitalAshok added a comment. Address comments; better implementation for elision (check after considering only initializer list constructors) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156032/new/

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

schittir abandoned this revision. schittir added a comment. In D158488#4607754 , @Manna wrote: > This has already been addressed by https://reviews.llvm.org/D157989 Thank you for letting me know. Abandoning this change. CHANGES SINCE LAST ACTION

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 created this revision. NoumanAmir657 added a reviewer: CornedBee. Herald added a project: All. NoumanAmir657 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The changes are for better diagnostic/error-messages. The error

[clang] c3c8f16 - Fixing the memory leak using split() instead of strtok

Author: Harini Chilamantula Date: 2023-08-22T15:26:34-04:00 New Revision: c3c8f16fc32cccf5239a2aedd10c6be9babf2945 URL: https://github.com/llvm/llvm-project/commit/c3c8f16fc32cccf5239a2aedd10c6be9babf2945 DIFF:

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3c8f16fc32c: Fixing the memory leak using split() instead of strtok (authored by hchilama, committed by abhina.sreeskantharajan). Repository: rG

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

bnbarham added a comment. In D148997#4561620 , @v.g.vassilev wrote: > So, in that case we should bring back the boolean flag for incremental > processing and keep the `IncrementalExtensions` LanguageOption separate. In > that case

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

HazardyKnusperkeks added a comment. In D158363#4606159 , @d0nc1h0t wrote: > In D158363#4604468 , > @HazardyKnusperkeks wrote: > >> Please upload the patch with the full context. > > I'm creating a patch via 'git

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama added a comment. Please use my Intel email Chilamantula, Harini . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llvm.org/D158254 ___ cfe-commits mailing list

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 created this revision. jyu2 added reviewers: rnk, rsmith, majnemer, cfe-commits. jyu2 added a project: clang. Herald added a project: All. jyu2 requested review of this revision. Currently, for MS, the linkage for the inheriting constructors is set to internal. However, the comdat attribute

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. In D158254#4607027 , @hchilama wrote: > Hi @abhina.sreeskantharajan , Thanks for letting me know the process and > please help me in commiting this patch. I'd like to put your name and email as the commit's

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

Manna added a comment. This has already been addressed by https://reviews.llvm.org/D157989 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158488/new/ https://reviews.llvm.org/D158488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

aaron.ballman added a comment. In D153156#4607671 , @hans wrote: > In D153156#4607655 , @aaron.ballman > wrote: > >> I agree this should be reverted from 17.x so we have more time to consider >> an appropriate

[PATCH] D158534: [clang-tidy] Disable trivially-destructible check for darwin

PiotrZSL added a comment. 626849c71e85d546a004cc91866beab610222194 didn't fix this issue already ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158534/new/

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. +

[PATCH] D158534: [clang-tidy] Disable trivially-destructible check for darwin

hiraditya created this revision. hiraditya added reviewers: PiotrZSL, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. hiraditya requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. For fat binaries

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

hans added a comment. In D153156#4607655 , @aaron.ballman wrote: > I agree this should be reverted from 17.x so we have more time to consider an > appropriate path forward. Supporting evidence that this will likely be > disruptive: >

[PATCH] D157497: feat: Migrate isArch16Bit

bulbazord requested changes to this revision. bulbazord added a comment. In D157497#4592330 , @Pivnoy wrote: > At the moment, the TargetParser architecture is extensible. This complicates > the addition of new architectures, operating systems, and so

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

aaron.ballman added a comment. In D153156#4607576 , @hans wrote: > Given the concerns raised (the PRIuS one in https://godbolt.org/z/v3boc9E6T > seems like a good example), and that the fix in D158372 > doesn't seem

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added inline comments. Comment at: clang/lib/Headers/stddef.h:1 /*=== stddef.h - Basic type definitions === * aaron.ballman wrote: > ldionne wrote: > > Making a thread out of this: > > > > > The relationship between

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64CallingConvention.td:555-557 +def CSR_Win_AArch64_Arm64EC_Thunk : CalleeSavedRegs<(add X19, X20, X21, X22, X23, X24, + X25, X26, X27, X28, FP, LR,

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. +

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

Manna added a comment. In D158522#4607628 , @tahonermann wrote: > Looks fine to me! Thanks @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

tahonermann accepted this revision. tahonermann added a comment. Looks fine to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. +

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

hans added a comment. Given the concerns raised (the PRIuS one in https://godbolt.org/z/v3boc9E6T seems like a good example), and that the fix in D158372 doesn't seem straight-forward, could this be reverted to unbreak things until a revised version is ready?

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

aaron.ballman added inline comments. Comment at: clang/lib/Headers/stddef.h:1 /*=== stddef.h - Basic type definitions === * ldionne wrote: > Making a thread out of this: > > > The relationship between clang's stddef.h and

[PATCH] D158532: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza added a comment. The delta from https://reviews.llvm.org/D155895 is in `clang/test/SemaCXX/attr-trivial-abi.cpp` where 1) a comment has been added above the non-trivial move constructor of the `Trivial` test helper and 2) test expectations have been tweaked to account for `_WIN64` and

[PATCH] D158532: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza created this revision. lukasza added a reviewer: gribozavr2. lukasza added a project: clang. Herald added a subscriber: mstorsjo. Herald added a project: All. lukasza requested review of this revision. Herald added a subscriber: cfe-commits. This is a reland of

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; ellis wrote: >

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; aeubanks wrote: >

  1   2   3   >