[PATCH] D158385: [tsan] Respect !nosanitize metadata and remove gcov special case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5624e86ae0fb: [tsan] Respect !nosanitize metadata and remove gcov special case (authored by MaskRay). Repository: rG LLVM Github Monorepo

[clang] 5624e86 - [tsan] Respect !nosanitize metadata and remove gcov special case

Author: Fangrui Song Date: 2023-08-24T22:31:11-07:00 New Revision: 5624e86ae0fb259c6069d1cc7d5eaa24402f9134 URL: https://github.com/llvm/llvm-project/commit/5624e86ae0fb259c6069d1cc7d5eaa24402f9134 DIFF: https://github.com/llvm/llvm-project/commit/5624e86ae0fb259c6069d1cc7d5eaa24402f9134.diff

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

iana updated this revision to Diff 553360. iana added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158709/new/ https://reviews.llvm.org/D158709 Files:

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 553358. sandeepkosuri added a comment. Used `CHECK-DAG` s to avoid LIT test failures on Windows system Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 Files:

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

owenpan added a comment. In D154093#4615948 , @sstwcw wrote: > In the JavaScript tests that I added, it was wrong to use `SmallString`. > Would you prefer me changing it to `string` or expanding the 6 test cases so > we don't need a variable for the

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 created this revision. danix800 added reviewers: steakhal, donat.nagy, dcoughlin. danix800 added a project: clang. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ.

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 updated this revision to Diff 553351. danix800 edited the summary of this revision. danix800 added a comment. `MPIChecker` is not strictly related to this revision. Will be moved into another revison. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158811: [X86] __builtin_cpu_supports: support x86-64{,-v2,-v3,-v4}

MaskRay created this revision. MaskRay added reviewers: FreddyYe, pengfei, RKSimon, skan, erichkeane. Herald added a subscriber: hiraditya. Herald added a reviewer: ctetreau. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. In the JavaScript tests that I added, it was wrong to use `SmallString`. Would you prefer me changing it to `string` or expanding the 6 test cases so we don't need a variable for the string? Shortly after I committed this patch, the server builds caught the problem in

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

shafik created this revision. shafik added reviewers: cor3ntin, aaron.ballman, erichkeane, rsmith. Herald added a project: All. shafik requested review of this revision. We had a couple of crashes due to invalid lambda trailing return types that were diagnosed but not treated as errors during

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 updated this revision to Diff 553335. danix800 edited the summary of this revision. danix800 added a comment. 1. `getDynamicExtent()` can return both signed/unsigned results. They are converted to signed version as `ArrayIndexType` to keep consistency. All other APIs return this

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158475/new/ https://reviews.llvm.org/D158475

[PATCH] D158804: [Clang] Fix crash in Parser::ParseDirectDeclarator by adding check that token is not an annotation token

shafik created this revision. shafik added reviewers: aaron.ballman, nridge, erichkeane. Herald added a project: All. shafik requested review of this revision. In `Parser::ParseDirectDeclarator(...)` in some cases ill-formed code can cause an annotation token to end up where it was not expected.

[PATCH] D158706: [Driver] Remove Myriad.cpp

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2958 default: return getTriple().getVendor() != llvm::Triple::Myriad; } MaskRay wrote: > brad wrote: > > You might as well remove this. > Will do! There is some Myriad

[clang] aa9d7d1 - [Driver] Remove Myriad.cpp

Author: Fangrui Song Date: 2023-08-24T18:44:45-07:00 New Revision: aa9d7d1cd0afe06f3c212af65b66f7e1421e321b URL: https://github.com/llvm/llvm-project/commit/aa9d7d1cd0afe06f3c212af65b66f7e1421e321b DIFF: https://github.com/llvm/llvm-project/commit/aa9d7d1cd0afe06f3c212af65b66f7e1421e321b.diff

[PATCH] D158706: [Driver] Remove Myriad.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. MaskRay marked an inline comment as done. Closed by commit rGaa9d7d1cd0af: [Driver] Remove Myriad.cpp (authored by MaskRay). Herald added a project: LLVM. Herald added

[PATCH] D158706: [Driver] Remove Myriad.cpp

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2958 default: return getTriple().getVendor() != llvm::Triple::Myriad; } brad wrote: > You might as well remove this. Will do!

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner created this revision. bogner added reviewers: beanz, python3kgae, bob80905, tex3d. Herald added subscribers: Anastasia, arphaman, mcrosier. Herald added a reviewer: aaron.ballman. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald

[clang] e4cb692 - [Driver] Add NaCl to ShouldAddDefaultIncludePaths()

Author: Brad Smith Date: 2023-08-24T21:09:09-04:00 New Revision: e4cb692526030a05424ee8299012ee76a7a0e3ca URL: https://github.com/llvm/llvm-project/commit/e4cb692526030a05424ee8299012ee76a7a0e3ca DIFF: https://github.com/llvm/llvm-project/commit/e4cb692526030a05424ee8299012ee76a7a0e3ca.diff

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad updated this revision to Diff 553310. brad added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files: clang/lib/Driver/ToolChains/DragonFly.cpp

[clang] e75f240 - [Driver] Cleanup last vestiges of Minix / Contiki support

Author: Brad Smith Date: 2023-08-24T20:04:40-04:00 New Revision: e75f240a0432d827c28a5d77fad26a099ceb7a72 URL: https://github.com/llvm/llvm-project/commit/e75f240a0432d827c28a5d77fad26a099ceb7a72 DIFF: https://github.com/llvm/llvm-project/commit/e75f240a0432d827c28a5d77fad26a099ceb7a72.diff

[clang] 053dd30 - Reland "[HIP] Allow std::malloc in device function"

Author: Yaxun (Sam) Liu Date: 2023-08-24T19:59:20-04:00 New Revision: 053dd30bb5d3ce5f6b57f10858ea0a6e4df7c738 URL: https://github.com/llvm/llvm-project/commit/053dd30bb5d3ce5f6b57f10858ea0a6e4df7c738 DIFF:

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. D158798 demonstrates a working Android runtimes setup with per-target runtime directories once this change is in place. It'll be nicer once D140925 lands, but it's workable even without that.

[PATCH] D158798: [RFC] Android runtimes build demonstration

smeenai added a comment. The manual `androideabi` normalization is only needed when building the runtimes, not when using them: $ for i in {21..32}; do printf '%s ' $i; bin/clang --print-file-name=libclang_rt.builtins.a -target armv7-none-linux-androideabi$i; done 21

[PATCH] D158798: [RFC] Android runtimes build demonstration

smeenai created this revision. smeenai added reviewers: danalbert, rprichard, srhines. Herald added a subscriber: danielkiss. Herald added a project: All. smeenai requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This

[PATCH] D145648: [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe94c171ddb03: [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas` (authored by yaxunl). Herald added a project: clang. Repository: rG

[clang] e94c171 - [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas`

Author: Yaxun (Sam) Liu Date: 2023-08-24T19:50:10-04:00 New Revision: e94c171ddb036e9672681d74725069352dd04d0e URL: https://github.com/llvm/llvm-project/commit/e94c171ddb036e9672681d74725069352dd04d0e DIFF:

[PATCH] D158795: Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

galenelias created this revision. galenelias added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. galenelias requested review of this revision. Fixes:

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

eandrews added a comment. aarch64 has different mangling for default functions when using target_clones. Sigh `int __attribute__((target_clones("ls64_v+fp16", "default"))) foo_ovl(int) { return 1; }` results in `@_Z7foo_ovli._Mfp16Mls64_v` and `@_Z7foo_ovlv`. Note there is no ".default" as in

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG9da61aed751e: [OpenMP] Emit offloading entries for indirect target variables (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9da61ae - [OpenMP] Emit offloading entries for indirect target variables

Author: Joseph Huber Date: 2023-08-24T18:21:13-05:00 New Revision: 9da61aed751ea6a51e7fa2e970de896d3cc27791 URL: https://github.com/llvm/llvm-project/commit/9da61aed751ea6a51e7fa2e970de896d3cc27791 DIFF: https://github.com/llvm/llvm-project/commit/9da61aed751ea6a51e7fa2e970de896d3cc27791.diff

[clang] 63f0833 - [clang] Fix missing contract flag in sqrt intrinsic

Author: Yaxun (Sam) Liu Date: 2023-08-24T19:15:17-04:00 New Revision: 63f0833ec4beb7d6bc63759ad8b336ad6dce0f93 URL: https://github.com/llvm/llvm-project/commit/63f0833ec4beb7d6bc63759ad8b336ad6dce0f93 DIFF:

[PATCH] D158135: [Clang][CodeGen] Add __builtin_bcopy

shafik added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3567 + case Builtin::BI__builtin_bcopy: { +Address Dest = EmitPointerWithAlignment(E->getArg(1)); +Address Src = EmitPointerWithAlignment(E->getArg(0)); Maybe it is better to do

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

MasterCopy8GB updated this revision to Diff 553294. MasterCopy8GB added a comment. Update documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

MaskRay added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1382 +return; +#if defined(__ANDROID__) + // ifunc resolvers don't have hwcaps in arguments on Android API lower enh wrote: > ilinpv wrote: > > MaskRay wrote: > > > I am

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai updated this revision to Diff 553291. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 Files: clang/include/clang/Driver/ToolChain.h

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai updated this revision to Diff 553290. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158475/new/ https://reviews.llvm.org/D158475 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/Driver.cpp

[PATCH] D158755: [Driver] Make "-fno-split-machine-functions" a valid flag for all archs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b27167a57c5: [Driver] Make -fno-split-machine-functions a valid flag for all archs (authored by shenhan). Repository: rG LLVM Github Monorepo

[clang] 7b27167 - [Driver] Make "-fno-split-machine-functions" a valid flag for all archs

Author: Han Shen Date: 2023-08-24T15:55:43-07:00 New Revision: 7b27167a57c5809e9936fe3c0920054009cb46f4 URL: https://github.com/llvm/llvm-project/commit/7b27167a57c5809e9936fe3c0920054009cb46f4 DIFF: https://github.com/llvm/llvm-project/commit/7b27167a57c5809e9936fe3c0920054009cb46f4.diff

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 updated this revision to Diff 553285. ziqingluo-90 marked 2 inline comments as done. ziqingluo-90 added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153059/new/ https://reviews.llvm.org/D153059 Files:

[PATCH] D158787: llvm-project/issues/42451

PiotrZSL added a comment. - Missing documentation entry about this style. - Missing release notes entry - Commit title / description should be more in line with style used in project Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/

[PATCH] D158787: llvm-project/issues/42451

MasterCopy8GB created this revision. MasterCopy8GB added a reviewer: llvm-commits. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. MasterCopy8GB requested review of this revision. Herald added a project: clang-tools-extra. Herald

[PATCH] D126586: [InstrProf] Single byte counters in coverage

ayzhao added a comment. Thanks for your work on this! FYI, I'm getting the following crash when I try to build Chrome's base_unittests with `-mllvm -enable-single-byte-coverage=true`: [195/4447] CXX obj/base/allocator/partition_allocator/allocator_core/pcscan_internal.o FAILED:

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 553274. ZijunZhao added a comment. Prevent result type from being short and fix the breaking in builtinoverflow.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

fcloutier updated this revision to Diff 553271. fcloutier added a comment. It seems that clang allows `char` specifiers to match `bool` in `scanf` today, without my change (https://godbolt.org/z/e8PrjY65h). I think that this is a mistake, but that's almost certainly up for debate and I'd like

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e2c5cda3cc7: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters… (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 0e2c5cd - [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

Author: Piotr Zegar Date: 2023-08-24T21:49:28Z New Revision: 0e2c5cda3cc713cac2cae651554fc070788760a6 URL: https://github.com/llvm/llvm-project/commit/0e2c5cda3cc713cac2cae651554fc070788760a6 DIFF: https://github.com/llvm/llvm-project/commit/0e2c5cda3cc713cac2cae651554fc070788760a6.diff LOG:

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

PiotrZSL marked an inline comment as done. PiotrZSL added a comment. I'm pushing this in current state, if you want to change something after that, fell free to do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158665/new/

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik updated this revision to Diff 553270. shafik marked 2 inline comments as done. shafik added a comment. - Add codegen test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 Files: clang/lib/AST/ExprConstant.cpp

[clang] 870f158 - Revert "[clang][modules] Use relative offsets for input files"

Author: Jan Svoboda Date: 2023-08-24T14:43:23-07:00 New Revision: 870f1583eed0f22ddfb1a1979a90198c3dc09927 URL: https://github.com/llvm/llvm-project/commit/870f1583eed0f22ddfb1a1979a90198c3dc09927 DIFF: https://github.com/llvm/llvm-project/commit/870f1583eed0f22ddfb1a1979a90198c3dc09927.diff

[clang] b6ba804 - Revert "[clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file"

Author: Jan Svoboda Date: 2023-08-24T14:43:23-07:00 New Revision: b6ba804f7775f89f230ee1e62526a2f8225c7966 URL: https://github.com/llvm/llvm-project/commit/b6ba804f7775f89f230ee1e62526a2f8225c7966 DIFF: https://github.com/llvm/llvm-project/commit/b6ba804f7775f89f230ee1e62526a2f8225c7966.diff

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158778/new/ https://reviews.llvm.org/D158778

[PATCH] D158572: [clang][modules] Use relative offsets for input files

phosek added a comment. In D158572#4615231 , @jansvoboda11 wrote: > @phosek BTW can you confirm whether these started failing with this patch or > with D158573 ? I'm trying to do a local build now to find out.

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 added a comment. @phosek BTW can you confirm whether these started failing with this patch or with D158573 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158572/new/ https://reviews.llvm.org/D158572

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 added a comment. In D158572#4615198 , @phosek wrote: > After this change, all libc++ `clang_modules_include.gen.py` tests started > failing on our Linux builders: > > ... > > You can see the full output at >

[PATCH] D158572: [clang][modules] Use relative offsets for input files

phosek added a comment. After this change, all libc++ `clang_modules_include.gen.py` tests started failing on our Linux builders: Script: -- : 'COMPILED WITH'; /b/s/w/ir/x/w/llvm_build/./bin/clang++

[PATCH] D158775: [NFC] Initialize member pointer and avoid potential null dereference

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2243 const auto *CurrentFunction = dyn_cast(D); CurrentMethod = dyn_cast(D); It seems to me that `CurrentMethod` is unconditionally assigned a value here, before it is

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay added a comment. > Make "-fno-split-machine-functions" a valid flag for all archs. Driver changes usually are named `[Driver] ...`. The popular convention is to omit the full stop at the end of the subject. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. With a test nit Comment at: clang/test/Driver/fsplit-machine-functions.c:19 +// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 |

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

tra added a comment. Also, https://github.com/llvm/llvm-project/issues/46903 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158778/new/ https://reviews.llvm.org/D158778 ___ cfe-commits mailing list

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, kerbowa, bixia, tpr, yaxunl, jvesely. Herald added a project: All. tra edited the summary of this revision. tra published this revision for review. tra added reviewers: jlebar, yaxunl. tra added a comment. Herald

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions.c:19 +// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 | FileCheck %s --check-prefix=ERR2 +// ERR2: clang: error: unsupported option

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan updated this revision to Diff 553256. shenhan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158755/new/ https://reviews.llvm.org/D158755 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

ldionne updated this revision to Diff 553255. ldionne added a comment. Only run check-clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158765/new/ https://reviews.llvm.org/D158765 Files: clang/utils/ci/buildkite-pipeline.yml

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

brendandahl added a comment. @efriedma ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156172/new/ https://reviews.llvm.org/D156172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158695: [clang] Fix missing contract flag in sqrt intrinsic

yaxunl updated this revision to Diff 553250. yaxunl added a comment. fix test for strict fp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158695/new/ https://reviews.llvm.org/D158695 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/fp-contract-fast-pragma.cpp Index:

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

hazohelet updated this revision to Diff 553246. hazohelet added a comment. Fixes `EstimateSizeFormatHandler`'s `%g` handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158562/new/ https://reviews.llvm.org/D158562 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158775: [NFC] Initialize member pointer and avoid potential null dereference

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann. Herald added a reviewer: NoQ. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D158771: [clang][tooling] Fix `name` range-selector to handle TypeLocs correctly.

li.zhe.hua accepted this revision. li.zhe.hua added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/RangeSelector.cpp:239-240 + !SpecLoc.isNull()) +return

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

hazohelet added a comment. In D158562#4614835 , @aaron.ballman wrote: > Thank you for working on this! > > Precommit CI found an issue with libc++'s tests: > https://reviews.llvm.org/harbormaster/unit/view/8606248/ -- it'd be best if > those could be

[PATCH] D158411: [clang] [MinGW] Pass LTO options to the linker

MaskRay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158411/new/ https://reviews.llvm.org/D158411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2586 #endif it = FixablesForAllVars.byVar.erase(it); } else if (Tracker.hasUnclaimedUses(it->first)) { We cannot fix reference type variable declarations

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions.c:19 +// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 | FileCheck %s --check-prefix=ERR2 +// ERR2: clang: error: unsupported option

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

iana updated this revision to Diff 553242. iana added a comment. Fixed the failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158709/new/ https://reviews.llvm.org/D158709 Files:

[PATCH] D158771: [clang][tooling] Fix `name` range-selector to handle TypeLocs correctly.

ymandel created this revision. ymandel added reviewers: sammccall, li.zhe.hua. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Previously, where `name` was applied to a template-specialization TypeLoc, it returned the entire specialization

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya added a subscriber: nridge. hiraditya added a comment. Added previously reported issues shared by @nridge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 ___ cfe-commits mailing list

[PATCH] D158411: [clang] [MinGW] Pass LTO options to the linker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa23bf1786be7: [clang] [MinGW] Pass LTO options to the linker (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] a23bf17 - [clang] [MinGW] Pass LTO options to the linker

Author: Martin Storsjö Date: 2023-08-24T23:15:26+03:00 New Revision: a23bf1786be7c0738a4cf999c2957155bb32d5af URL: https://github.com/llvm/llvm-project/commit/a23bf1786be7c0738a4cf999c2957155bb32d5af DIFF:

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

ziqingluo-90 updated this revision to Diff 553226. ziqingluo-90 marked an inline comment as done. ziqingluo-90 edited the summary of this revision. ziqingluo-90 added a comment. In our offline discussion, we realized that `p = q.data()` is not always a correct fix to `p = q` for cases where only

[PATCH] D158570: [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7cabb54f3867: [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim (authored by Blue Gaston bgast...@apple.com).

[clang] 7cabb54 - [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim

Author: Blue Gaston Date: 2023-08-24T13:11:54-07:00 New Revision: 7cabb54f3867867451368ce72928f76cf38831cb URL: https://github.com/llvm/llvm-project/commit/7cabb54f3867867451368ce72928f76cf38831cb DIFF: https://github.com/llvm/llvm-project/commit/7cabb54f3867867451368ce72928f76cf38831cb.diff

[PATCH] D158766: [AST] TypeSourceInfo for params of inherited constructor should be null

sammccall updated this revision to Diff 553234. sammccall marked 2 inline comments as done. sammccall added a comment. address review comments, also null the TSI of the constructor itself Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158766/new/

[PATCH] D158766: [AST] TypeSourceInfo for params of inherited constructor should be null

sammccall added a reviewer: aaron.ballman. sammccall marked 4 inline comments as done. sammccall added a subscriber: aaron.ballman. sammccall added a comment. +Aaron for guidance & in case I'm making things up, TypeLocs/TSI have always confused me... Comment at:

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

vvereschaka added a comment. Hi @serge-sans-paille, also on this builder: https://lab.llvm.org/buildbot/#/builders/60/builds/13587 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158558/new/ https://reviews.llvm.org/D158558

[PATCH] D158766: [AST] TypeSourceInfo for params of inherited constructor should be null

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:13895-13896 Context.getTrivialTypeSourceInfo(BaseCtor->getType(), UsingLoc); FunctionProtoTypeLoc ProtoLoc =

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

aaron.ballman added a comment. Thank you for working on this! Precommit CI found an issue with libc++'s tests: https://reviews.llvm.org/harbormaster/unit/view/8606248/ -- it'd be best if those could be addressed before landing the changes. CHANGES SINCE LAST ACTION

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/constexpr-string.cpp:681 +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wconstant-conversion" +namespace GH64876 { shafik wrote: > erichkeane wrote: > > rather than suppress

[PATCH] D158766: [AST] TypeSourceInfo for params of inherited constructor should be null

sammccall created this revision. sammccall added a reviewer: ymandel. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This matches behavior of other synthetic members like copy constructors, and

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We used to rely on the monorepo-wide premerge checks for running Clang tests, but I think it makes more sense to run the

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Phew, that completes my first pass through the review! I'm also adding @erichkeane as a reviewer now that he's off sabbatical. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9378-9381 +

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan added a comment. In D158755#4614566 , @MaskRay wrote: > Thanks for the patch. We need a test. I cleaned up > `fsplit-machine-functions.c` a bit. You can rebase and modify the `not %clang > -### -c --target=arm-unknown-linux

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan updated this revision to Diff 553219. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158755/new/ https://reviews.llvm.org/D158755 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/fsplit-machine-functions.c Index:

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

erjin updated this revision to Diff 553217. erjin added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763 Files: clang/include/clang/Driver/Options.td

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

erjin created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. erjin requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik added inline comments. Comment at: clang/test/SemaCXX/constexpr-string.cpp:681 +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wconstant-conversion" +namespace GH64876 { erichkeane wrote: > rather than suppress these, it makes sense to

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 553199. ZijunZhao added a comment. Rename the warn_overflow_builtin_can_not_be_short for precision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files:

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay added a comment. Thanks for the patch. We need a test. I cleaned up `fsplit-machine-functions.c` a bit. You can rebase and modify the `not %clang -### -c --target=arm-unknown-linux -fsplit-machine-functions -fno-split-machine-functions` RUN line in

[clang] 426c2c4 - [Driver][test] Clean up -fsplit-machine-function tests

Author: Fangrui Song Date: 2023-08-24T11:00:16-07:00 New Revision: 426c2c44b525dc52863de18d8a5c0f697f8c11e3 URL: https://github.com/llvm/llvm-project/commit/426c2c44b525dc52863de18d8a5c0f697f8c11e3 DIFF: https://github.com/llvm/llvm-project/commit/426c2c44b525dc52863de18d8a5c0f697f8c11e3.diff

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4613622 , @aaron.ballman wrote: > In D157572#4612141 , @cjdb wrote: > >> I don't dislike it, but I am a bit concerned about misuse being noisy. > > So you're concerned that a

[PATCH] D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA

argentite added inline comments. Comment at: clang/unittests/Interpreter/InteractiveCudaTest.cpp:92 + std::unique_ptr Interp = createInterpreter(); + auto Err = Interp->LoadDynamicLibrary("libcudart.so"); + if (Err) { // CUDA runtime is not installed/usable, cannot continue

  1   2   3   >