[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

aeubanks added inline comments. Comment at: clang/test/OpenMP/amdgpu_exceptions.cpp:10 + +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device -fcxx-exceptions -fexceptions %s -emit-llvm -S -verify=with -Wopenmp-target-exception -analyze +// RUN:

[clang] 8609819 - [RISCV] Add feature checks for vector crypto C intrinsics

Author: 4vtomat Date: 2023-08-30T21:03:08-07:00 New Revision: 8609819eb1c35b72897cb71006968c84db73b0e4 URL: https://github.com/llvm/llvm-project/commit/8609819eb1c35b72897cb71006968c84db73b0e4 DIFF: https://github.com/llvm/llvm-project/commit/8609819eb1c35b72897cb71006968c84db73b0e4.diff LOG:

[PATCH] D158257: [RISCV] Add feature checks for vector crypto C intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8609819eb1c3: [RISCV] Add feature checks for vector crypto C intrinsics (authored by 4vtomat). Changed prior to commit:

[PATCH] D158255: [RISCV][NFC] Update compile options for some vector crypto C intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb47721fb743: [RISCV][NFC] Update compile options for some vector crypto C intrinsics (authored by 4vtomat). Repository: rG LLVM Github Monorepo

[clang] bb47721 - [RISCV][NFC] Update compile options for some vector crypto C intrinsics

Author: 4vtomat Date: 2023-08-30T20:29:29-07:00 New Revision: bb47721fb7439b646405105c1a78eafa1e6e660c URL: https://github.com/llvm/llvm-project/commit/bb47721fb7439b646405105c1a78eafa1e6e660c DIFF: https://github.com/llvm/llvm-project/commit/bb47721fb7439b646405105c1a78eafa1e6e660c.diff LOG:

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaskRay added inline comments. Comment at: clang/lib/Basic/Sanitizers.cpp:130 +if (A->getOption().matches(clang::driver::options::OPT_mexecute_only) && +llvm::ARM::supportedExecuteOnly(Triple)) { + return true; MaskRay wrote: > I don't think we

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

beanz added a comment. Full disclosure here, I need to write some more tests for this. It should be NFC for all languages other than HLSL, but I want to spend some time making sure that the tests adequately exercise the HLSL paths (which should also be mostly NFC). Repository: rG LLVM

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

beanz created this revision. beanz added reviewers: cor3ntin, aaron.ballman, bogner. Herald added subscribers: Anastasia, ChuanqiXu, martong. Herald added a reviewer: shafik. Herald added a reviewer: NoQ. Herald added a project: All. beanz requested review of this revision. Herald added a project:

[PATCH] D159213: [AIX][ClangRepl] Disable new tests on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86337beca2e6: [AIX][ClangRepl] Disable new tests on AIX (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 86337be - [AIX][ClangRepl] Disable new tests on AIX

Author: Jake Egan Date: 2023-08-30T21:36:07-04:00 New Revision: 86337beca2e6f939127cd3e088ec80c0cf4a0a64 URL: https://github.com/llvm/llvm-project/commit/86337beca2e6f939127cd3e088ec80c0cf4a0a64 DIFF: https://github.com/llvm/llvm-project/commit/86337beca2e6f939127cd3e088ec80c0cf4a0a64.diff

[clang] 77b2fc8 - [clang-format][NFC] Reformat and fix file mode

Author: Owen Pan Date: 2023-08-30T18:35:24-07:00 New Revision: 77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec URL: https://github.com/llvm/llvm-project/commit/77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec DIFF: https://github.com/llvm/llvm-project/commit/77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec.diff

[PATCH] D159213: [AIX][ClangRepl] Disable new tests on AIX

shchenz accepted this revision. shchenz added a comment. LGTM. Thanks for fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159213/new/ https://reviews.llvm.org/D159213 ___ cfe-commits mailing list

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 554882. iana added a comment. Update Module::directlyUses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Basic/Module.cpp

[PATCH] D159235: Fix crash when struct with inheritance is initialized with InitExpr

kinu updated this revision to Diff 554868. kinu added a comment. Add assignment test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159235/new/ https://reviews.llvm.org/D159235 Files:

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.h:398-401 +/// If \p F "target-features" are incompatible with the \p TargetOpts features, +/// it is correct to drop the function. \return true if \p F is dropped +bool

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6e6abd76cd3: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect (authored by qiongsiwu1). Repository: rG LLVM

[clang] a6e6abd - [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

Author: Qiongsi Wu Date: 2023-08-30T19:20:17-04:00 New Revision: a6e6abd76cd31011f7685bda2c95ac6468df4f65 URL: https://github.com/llvm/llvm-project/commit/a6e6abd76cd31011f7685bda2c95ac6468df4f65 DIFF: https://github.com/llvm/llvm-project/commit/a6e6abd76cd31011f7685bda2c95ac6468df4f65.diff

[PATCH] D159235: Fix crash when struct with inheritance is initialized with InitExpr

kinu created this revision. Herald added a reviewer: NoQ. Herald added a project: All. kinu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fix doesn't fix the problem of non-populated fields in base classes (even if they are accessed

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:4586 +def print_supported_extensions : Flag<["-", "--"], "print-supported-extensions">, + Group, Flags<[CC1Option,

[PATCH] D159233: [clang-format][NFC] Change duplicate config files to symlinks

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 updated this revision to Diff 554842. qiongsiwu1 added a comment. Address code review. Thanks for the input @w2yehia ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159137/new/ https://reviews.llvm.org/D159137 Files:

[PATCH] D159051: [clang-format][NFC] Change EXPECT_EQ to verifyFormat or verifyNoChang

owenpan added a comment. rG14feca5d14f1 concludes the cleanup of this gigantic file WRT `EXPECT_EQ`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159051/new/

[clang] 14feca5 - [clang-format][NFC] Replace EXPECT_EQ() with verifyFormat()

Author: Owen Pan Date: 2023-08-30T14:55:26-07:00 New Revision: 14feca5d14f1b158f468f01039302da2ca396b14 URL: https://github.com/llvm/llvm-project/commit/14feca5d14f1b158f468f01039302da2ca396b14 DIFF: https://github.com/llvm/llvm-project/commit/14feca5d14f1b158f468f01039302da2ca396b14.diff

[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

kiranchandramohan added a comment. I think this requires an RFC in MLIR discourse to get some feedback from the experts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159212/new/ https://reviews.llvm.org/D159212

[clang] f41cd47 - [Driver] Enable stdlibxx-isystem test on Windows

Author: Shoaib Meenai Date: 2023-08-30T14:39:00-07:00 New Revision: f41cd477361b1891ca2702b66a8a66915258f15b URL: https://github.com/llvm/llvm-project/commit/f41cd477361b1891ca2702b66a8a66915258f15b DIFF: https://github.com/llvm/llvm-project/commit/f41cd477361b1891ca2702b66a8a66915258f15b.diff

[PATCH] D158296: [clang] Diagnose overly complex Record in __builtin_dump_struct

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:732-733 +int RDKind = RD->isClass() ? 0 : (RD->isStruct() ? 1 : 2); +S.Diag(PtrArg->getBeginLoc(), diag::err_builtin_dump_struct_too_complex) +<< RDKind << RD->getName(); +return

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 554832. iana marked an inline comment as done. iana added a comment. The nullptr_t submodule can't require c23 because it needs to be used in C++ in some cases too. Remove the `requires` from the module map and add a C23 guard to the header. Repository: rG

[PATCH] D159118: [libc] Implement the 'clock()' function on the GPU

This revision was automatically updated to reflect the committed changes. Closed by commit rG30307a7bb795: [libc] Implement the clock() function on the GPU (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D159118?vs=554797=554831#toc Repository: rG LLVM Github

[clang] 30307a7 - [libc] Implement the 'clock()' function on the GPU

Author: Joseph Huber Date: 2023-08-30T16:16:34-05:00 New Revision: 30307a7bb795cf5e5ccdcb923bd8a7401d3d4bd6 URL: https://github.com/llvm/llvm-project/commit/30307a7bb795cf5e5ccdcb923bd8a7401d3d4bd6 DIFF: https://github.com/llvm/llvm-project/commit/30307a7bb795cf5e5ccdcb923bd8a7401d3d4bd6.diff

[PATCH] D85309: [Driver] Support GNU ld on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:305 +bool tools::isLinkerGnuLd(const ToolChain , const ArgList ) { + // Only used if targetting Solaris. I suppose that this should be in a Solaris specific file to indicate

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

MaskRay added a comment. In D159054#4628278 , @probinson wrote: > In D159054#4626772 , @brad wrote: > >> Just FYI I am not in a rush to commit this. I am posting this more so as a >> means of prodding for

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

dexonsmith added inline comments. Comment at: clang/lib/Headers/__stddef_null.h:14 + * __need_NULL and rely on stddef.h to redefine NULL to the correct value again. + * Modules don't support redefining macros like that, but support that pattern + * in the non-modules case.

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

krisb updated this revision to Diff 554818. krisb added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159133/new/ https://reviews.llvm.org/D159133 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaCast.cpp

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

ast added a comment. In D133361#4629081 , @eddyz87 wrote: > Note on current propagation logic: whenever there is an expression E of type > T, where T is a struct annotated with btf_decl_tag("ctx"), all usages of E > are traversed recursively visiting

[PATCH] D159222: [clang] Consistently use isOSSolaris()

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. While looking over the Solaris GNU ld patch (D85309 ),

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

donat.nagy added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicExtent.cpp:34 +if (auto SSize = +SVB.convertToArrayIndex(*Size).getAs()) + return *SSize; danix800 wrote: > donat.nagy wrote: > > I think it's a good

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks, Soumi, looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158293/new/ https://reviews.llvm.org/D158293 ___

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:494-495 ++NumSkipped; assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?"); + assert(CurLexer && "Invalid lexer value");

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna updated this revision to Diff 554810. Manna added a comment. This patch splits all predicates and updates assert messages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158293/new/ https://reviews.llvm.org/D158293 Files: clang/lib/Lex/PPDirectives.cpp Index:

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

tahonermann added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:494-495 ++NumSkipped; assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?"); + assert(CurLexer && "Invalid lexer value"); Would you mind splitting out all of

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

w2yehia added inline comments. Comment at: clang/test/Driver/fprofile-update.c:18 +// RUN: %clang -### %s --target=powerpc-unknown-aix -fprofile-generate -fprofile-update=atomic 2>&1 | FileCheck %s --check-prefix=AIX +// RUN: %clang -### %s --target=powerpc-unknown-aix

[PATCH] D159118: [libc] Implement the 'clock()' function on the GPU

jhuber6 updated this revision to Diff 554797. jhuber6 added a comment. Move the header portion into a common utility header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159118/new/ https://reviews.llvm.org/D159118 Files:

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana marked an inline comment as done. iana added inline comments. Comment at: clang/lib/Headers/__stddef_null.h:14 + * __need_NULL and rely on stddef.h to redefine NULL to the correct value again. + * Modules don't support redefining macros like that, but support that pattern

[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

jsjodin added a comment. I'm not sure if we want to add an interface for every transform. Is there a way to have a generic solution to this, like a new trait or more general interface? It would be nice to avoid the case where a new transform will have to touch all the dialects, or a new op

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

benlangmuir added inline comments. Comment at: clang/lib/Headers/module.modulemap:156 -module _Builtin_stddef_max_align_t [system] [extern_c] { - header "__stddef_max_align_t.h" Is the assumption here that directly `@import _Builtin_stddef_max_align_t` is

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

pranavk added a comment. I agree -Wunused-condition-variable sounds like a good idea. There are still numerous instances of this warning/error showing up when doing a self-build of LLVM, let alone warnings/errors that are showing up in internal code bases who are using LLVM HEAD for compiling

[clang] 680da4b - [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

Author: Ian Anderson Date: 2023-08-30T11:41:12-07:00 New Revision: 680da4b5d7ec05a1e6656f2a7603a7b843268bab URL: https://github.com/llvm/llvm-project/commit/680da4b5d7ec05a1e6656f2a7603a7b843268bab DIFF: https://github.com/llvm/llvm-project/commit/680da4b5d7ec05a1e6656f2a7603a7b843268bab.diff

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

This revision was automatically updated to reflect the committed changes. Closed by commit rG680da4b5d7ec: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces… (authored by iana). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159213: [AIX][ClangRepl] Disable new tests on AIX

capfredf added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159213/new/ https://reviews.llvm.org/D159213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

MaskRay added a comment. In D152495#4628903 , @smeenai wrote: > In D152495#4628877 , @hans wrote: > >> In D152495#4628870 , @goncharov >> wrote: >> >>> due to this

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 554792. void added a comment. Add testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

eddyz87 added a comment. In D133361#4628951 , @ast wrote: > I agree that it's not useful outside of BPF, but it's useful outside of > 'ctx'. I think 'preserve_constant_field_offset' would be more accurate > description of the restriction. > We can

[PATCH] D153690: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

rnk added a comment. In D153690#4627938 , @hazohelet wrote: > @rnk This reproducer code should be accepted for clang to be aligned with > msvc's behavior, correct? Yes, I think so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. In D158540#4628958 , @aaron.ballman wrote: > In D158540#4628904 , @NoumanAmir657 > wrote: > >> In D158540#4628860 , >> @aaron.ballman

[clang-tools-extra] c6fa07c - [clang-tidy][NFC][DOC] Update links to HICPP standard

Author: Piotr Zegar Date: 2023-08-30T18:02:34Z New Revision: c6fa07ca966eb8902465adbe2c6c1e41a108881c URL: https://github.com/llvm/llvm-project/commit/c6fa07ca966eb8902465adbe2c6c1e41a108881c DIFF: https://github.com/llvm/llvm-project/commit/c6fa07ca966eb8902465adbe2c6c1e41a108881c.diff LOG:

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 554784. ZijunZhao marked 3 inline comments as done. ZijunZhao added a comment. Remove the short type check part. >From Aaron Ballman: > Instead, we'd want to do some data flow analysis (in the clang static > analyzer) so we know the potential range of

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hans added a comment. In D152495#4628887 , @aaron.ballman wrote: > That might not be a bad idea in this case -- perhaps > `-Wunused-condition-variable` and group it under `-Wunused-variable`? Sounds god to me conceptually. (I don't know the code, so

[PATCH] D158296: [clang] Diagnose overly complex Record in __builtin_dump_struct

aaron.ballman added a comment. The changes generally LGTM, thank you! Comment at: clang/lib/Sema/SemaChecking.cpp:732-733 +int RDKind = RD->isClass() ? 0 : (RD->isStruct() ? 1 : 2); +S.Diag(PtrArg->getBeginLoc(), diag::err_builtin_dump_struct_too_complex) +<<

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. In D158540#4628958 , @aaron.ballman wrote: > In D158540#4628904 , @NoumanAmir657 > wrote: > >> In D158540#4628860 , >> @aaron.ballman

[clang-tools-extra] 26f230f - [clang-tidy][NFC] Fix llvm-else-after-return findings

Author: Piotr Zegar Date: 2023-08-30T17:41:41Z New Revision: 26f230fe5214614b912b6e1800e1526d625181ac URL: https://github.com/llvm/llvm-project/commit/26f230fe5214614b912b6e1800e1526d625181ac DIFF: https://github.com/llvm/llvm-project/commit/26f230fe5214614b912b6e1800e1526d625181ac.diff LOG:

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

aaron.ballman added a comment. In D158540#4628904 , @NoumanAmir657 wrote: > In D158540#4628860 , @aaron.ballman > wrote: > >> In D158540#4628629 , >> @NoumanAmir657

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin marked 2 inline comments as done. yronglin added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9396 def err_incorrect_defaulted_constexpr : Error< - "defaulted definition of %sub{select_special_member_kind}0 " - "is not constexpr">; + "%sub{select_special_member_kind}0

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

ast added a comment. > I can rename these things, but tbh I don't think this functionality would be > useful anywhere outside BPF, thus such renaming would be kind-of deceptive > (and in case it would be useful, the renaming could be done at the time of > second use). I agree that it's not

[PATCH] D158296: [NFC][Clang] Add assertion to check the value of NumSubExprs/ResultIndex does not overflow

yronglin updated this revision to Diff 554770. yronglin added a comment. Addres the comments that we talked in D154784 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158296/new/ https://reviews.llvm.org/D158296

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. In D158540#4628860 , @aaron.ballman wrote: > In D158540#4628629 , @NoumanAmir657 > wrote: > >> In D158540#4628310 , >> @aaron.ballman

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

smeenai added a comment. In D152495#4628877 , @hans wrote: > In D152495#4628870 , @goncharov > wrote: > >> due to this change we have a enourmous number of new warnings, on the other >> hand -Wunused-variable

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 554769. void added a comment. Add more diagnostics. Coming next: testcases!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

aaron.ballman added a comment. In D152495#4628877 , @hans wrote: > In D152495#4628785 , @cor3ntin > wrote: > >> It is used, but only in an assert. Seems like the right fix! > > I suppose it is technically, but

[PATCH] D159016: [clang] Fix assertion failure using -MJ with -fsyntax-only

benlangmuir added inline comments. Comment at: clang/test/Driver/compilation_database_fsyntax_only.c:1 +// RUN: mkdir -p %t.workdir && cd %t.workdir +// RUN: %clang -fsyntax-only %s -MJ - 2>&1 | FileCheck %s MaskRay wrote: > The test can be added into

[clang] aca23d8 - [clang] Fix assertion failure using -MJ with -fsyntax-only

Author: Ben Langmuir Date: 2023-08-30T10:04:34-07:00 New Revision: aca23d8ac30d773c1513d1708bdda8149acc075a URL: https://github.com/llvm/llvm-project/commit/aca23d8ac30d773c1513d1708bdda8149acc075a DIFF: https://github.com/llvm/llvm-project/commit/aca23d8ac30d773c1513d1708bdda8149acc075a.diff

[PATCH] D159016: [clang] Fix assertion failure using -MJ with -fsyntax-only

This revision was automatically updated to reflect the committed changes. Closed by commit rGaca23d8ac30d: [clang] Fix assertion failure using -MJ with -fsyntax-only (authored by benlangmuir). Changed prior to commit: https://reviews.llvm.org/D159016?vs=554046=554765#toc Repository: rG LLVM

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hans added a comment. In D152495#4628785 , @cor3ntin wrote: > It is used, but only in an assert. Seems like the right fix! I suppose it is technically, but I'm not sure the fix reads like an improvement to me... I guess that's often the case with

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

goncharov added a comment. due to this change we have a enourmous number of new warnings, on the other hand -Wunused-variable is a valuable warning. I am not sure what is the policy and best practices for warnings but maybe there is a possiblity to make a transition period for enabling this

[clang] c9db799 - [RISCV] Don't add -unaligned-scalar-mem to target features by default.

Author: Craig Topper Date: 2023-08-30T09:52:16-07:00 New Revision: c9db799dda6928d52baad51802c4315a0312e69d URL: https://github.com/llvm/llvm-project/commit/c9db799dda6928d52baad51802c4315a0312e69d DIFF: https://github.com/llvm/llvm-project/commit/c9db799dda6928d52baad51802c4315a0312e69d.diff

[PATCH] D159145: [RISCV] Don't add -unaligned-scalar-mem to target features by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9db799dda69: [RISCV] Dont add -unaligned-scalar-mem to target features by default. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna updated this revision to Diff 554762. Manna marked an inline comment as done. Manna added a comment. Thanks @tahonermann for review and feedback. I have added an assert separately to tell which predicate failed if a failure occurs in future. CHANGES SINCE LAST ACTION

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

aaron.ballman added a comment. In D158540#4628629 , @NoumanAmir657 wrote: > In D158540#4628310 , @aaron.ballman > wrote: > >> In D158540#4628265 , >> @NoumanAmir657

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

nickdesaulniers added a comment. Mind adding tests for `%#X` and `%#o` as well, since you're changing the behavior of those, too? I think it would also be good to have explicit tests for `%o` and `%b` where the value being printed was and was not `0`. IIUC, we cannot diagnose those (unless a

[PATCH] D158963: [CodeGen] Function multi-versioning: don't set comdat for internal linkage resolvers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG651b2fbc1c7e: [CodeGen] Function multi-versioning: dont set comdat for internal linkage… (authored by MaskRay). Repository: rG LLVM Github

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

efriedma added a comment. Maybe split the changes to reformat the unittests into a separate patch? Otherwise, I'm happy with the current state of this patch, but probably someone more active in flang should approve. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 651b2fb - [CodeGen] Function multi-versioning: don't set comdat for internal linkage resolvers

Author: Fangrui Song Date: 2023-08-30T09:46:48-07:00 New Revision: 651b2fbc1c7ec4992d2c80b8456c5c5a72394caf URL: https://github.com/llvm/llvm-project/commit/651b2fbc1c7ec4992d2c80b8456c5c5a72394caf DIFF: https://github.com/llvm/llvm-project/commit/651b2fbc1c7ec4992d2c80b8456c5c5a72394caf.diff

[PATCH] D158963: [CodeGen] Function multi-versioning: don't set comdat for internal linkage resolvers

MaskRay updated this revision to Diff 554756. MaskRay edited the summary of this revision. MaskRay added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158963/new/ https://reviews.llvm.org/D158963 Files:

[clang] 3c9988f - [OpenMP] Allow exceptions in target regions when offloading to GPUs

Author: Anton Rydahl Date: 2023-08-30T09:36:22-07:00 New Revision: 3c9988f85d2508bdbc64c81fed7c4b9b8db54262 URL: https://github.com/llvm/llvm-project/commit/3c9988f85d2508bdbc64c81fed7c4b9b8db54262 DIFF: https://github.com/llvm/llvm-project/commit/3c9988f85d2508bdbc64c81fed7c4b9b8db54262.diff

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c9988f85d25: [OpenMP] Allow exceptions in target regions when offloading to GPUs (authored by AntonRydahl). Repository: rG LLVM Github Monorepo

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:282 } +} Remove { } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159206/new/

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez updated this revision to Diff 554753. jmmartinez marked an inline comment as done. jmmartinez added a comment. - Drop incoming builtins with incompatible target-features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159206/new/

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez marked 2 inline comments as done. jmmartinez added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2034 + } + + FuncAttr.addAttribute("target-features", llvm::join(MergedFeatures, ",")); arsenm wrote: > Really it would be less bad if the

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

cor3ntin added a comment. It is used, but only in an assert. Seems like the right fix! In D152495#4628778 , @smeenai wrote: > In D152495#4628028 , @goncharov > wrote: > >> there is a number of unused vaiables

[clang] 9ef536a - [UBSan] Disable the function and kcfi sanitizers on an execute-only target.

Author: Ying Yi Date: 2023-08-30T17:17:37+01:00 New Revision: 9ef536a12ea65a2b9e2511936327c7b621af38fb URL: https://github.com/llvm/llvm-project/commit/9ef536a12ea65a2b9e2511936327c7b621af38fb DIFF: https://github.com/llvm/llvm-project/commit/9ef536a12ea65a2b9e2511936327c7b621af38fb.diff LOG:

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

madanial added a comment. Pinging for review. I will be taking over this patch from Paul, but Paul will still be around to answer any questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

smeenai added a comment. In D152495#4628028 , @goncharov wrote: > there is a number of unused vaiables in conditional loops that are firing > now, I have submitted > https://github.com/llvm/llvm-project/commit/74f4daef0412be33002bd4e24a30cb47d0187ecf

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ef536a12ea6: [UBSan] Disable the function and kcfi sanitizers on an execute-only target. (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff updated this revision to Diff 554750. sepavloff added a comment. Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153339/new/ https://reviews.llvm.org/D153339 Files: clang/docs/LanguageExtensions.rst

[PATCH] D159213: [AIX][ClangRepl] Disable new tests on AIX

Jake-Egan created this revision. Herald added a project: All. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159213 Files:

[PATCH] D159145: [RISCV] Don't add -unaligned-scalar-mem to target features by default.

wangpc accepted this revision. wangpc added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159145/new/ https://reviews.llvm.org/D159145

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. But please wait for other opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148131/new/

[PATCH] D141714: Fix ast print of variables with attributes

erichkeane added a comment. I think we can do better naming the tablegen'ed parts, else a bunch of smaller changes. Approach seems good enough to me, though Aaron should scroll through/make a determination after you've fixed my concerns. Comment at:

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

steakhal planned changes to this revision. steakhal added a comment. In D159105#4627883 , @donat.nagy wrote: > In D159105#4627785 , @steakhal > wrote: > >> In D159105#4627724

[PATCH] D158255: [RISCV][NFC] Update compile options for some vector crypto C intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158255/new/ https://reviews.llvm.org/D158255

  1   2   >