LLVM ABI Annotations (PR #67502)

tstellar wrote: I'm working on rebasing this. https://github.com/llvm/llvm-project/pull/67502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix potential deref of end iterator (PR #70193)

@@ -65,7 +65,7 @@ class CXXFieldCollector { /// getCurFields - Pointer to array of fields added to the currently parsed /// class. - FieldDecl **getCurFields() { return &*(Fields.end() - getCurNumFields()); } shafik wrote: I think this is basically

[clang] [clang] Emit bad shift warnings (PR #70307)

@@ -11773,7 +11786,25 @@ QualType Sema::CheckShiftOperands(ExprResult , ExprResult , isScopedEnumerationType(RHSType)) { return InvalidOperands(Loc, LHS, RHS); } - DiagnoseBadShiftValues(*this, LHS, RHS, Loc, Opc, LHSType); + + BadShiftValueKind BSVKind = +

[clang] [mlir] Add config for PDL (PR #69927)

joker-eph wrote: Need to iterate a bit more on framing the problem: > MLIR is a general infrastructure and as far as possible no dialect is > intended to be special or privileged Yes, and you can use MLIR without PDL, it's not a mandatory component. I believe that the minimal examples

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/67166 >From 686eff52ac0878fa9545481eaf32b47350c68be8 Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Fri, 22 Sep 2023 08:21:21 -0500 Subject: [PATCH 1/7] [InstSimplify] Add tests for simplify `llvm.ptrmask`;

[clang] [Driver] Silence stdlib warning when linking C on *BSD / Solaris / Haiku (PR #70434)

https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/70434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Silence stdlib warning when linking C on *BSD / Solaris / Haiku (PR #70434)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70434 >From 2aa78e266b76286c38a071999274f496722a56f0 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 27 Oct 2023 05:13:59 -0400 Subject: [PATCH] [Driver] Silence stdlib warning when linking C on *BSD / Solaris /

[clang] [Driver] Silence stdlib warning when linking C on *BSD / Solaris / Haiku (PR #70434)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70434 >From ae7bf5b42a62f0c20592e07af2f9e746aaa2231c Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 27 Oct 2023 05:13:59 -0400 Subject: [PATCH] [Driver] Silence stdlib warning when linking C on *BSD / Solaris /

[clang] [Driver] Silence stdlib warning when linking C on *BSD / Solaris / Haiku (PR #70434)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70434 >From 7b884f2d1bc366d20f553b54aaca5c7dd8afe487 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 27 Oct 2023 05:13:59 -0400 Subject: [PATCH] [Driver] Silence stdlib warning when linking C on *BSD / Solaris /

[clang] a8e0acf - [Driver][NFC] Fix a typo in the function name

Author: Brad Smith Date: 2023-10-27T22:10:05-04:00 New Revision: a8e0acf660639078a7e5341dd6ec82326d3b796b URL: https://github.com/llvm/llvm-project/commit/a8e0acf660639078a7e5341dd6ec82326d3b796b DIFF: https://github.com/llvm/llvm-project/commit/a8e0acf660639078a7e5341dd6ec82326d3b796b.diff

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

@@ -96,13 +97,39 @@ bool MultilibSet::select(const Multilib::flags_list , llvm::SmallVector ) const { llvm::StringSet<> FlagSet(expandFlags(Flags)); Selected.clear(); - llvm::copy_if(Multilibs, std::back_inserter(Selected), -

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

@@ -96,13 +98,36 @@ bool MultilibSet::select(const Multilib::flags_list , llvm::SmallVector ) const { llvm::StringSet<> FlagSet(expandFlags(Flags)); Selected.clear(); - llvm::copy_if(Multilibs, std::back_inserter(Selected), -

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

@@ -0,0 +1,70 @@ +# REQUIRES: shell MaskRay wrote: If `LIT_USE_INTERNAL_SHELL=1 llvm-lit ..` passes, you can remove `# REQUIRES: shell` (dependency on an external shell) https://github.com/llvm/llvm-project/pull/69447

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

https://github.com/MaskRay approved this pull request. Looks good to me, but other reviewers likely have opinions https://github.com/llvm/llvm-project/pull/69447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clangd] Support `-specs` arguments when querying the driver. (PR #70285)

https://github.com/cjc25 ready_for_review https://github.com/llvm/llvm-project/pull/70285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support `-specs` arguments when querying the driver. (PR #70285)

https://github.com/cjc25 updated https://github.com/llvm/llvm-project/pull/70285 >From 4d975b63f802f6e766d4a2cd0b6122bd0ca1e596 Mon Sep 17 00:00:00 2001 From: Chris Carlon Date: Tue, 24 Oct 2023 22:21:59 -0400 Subject: [PATCH] [clangd] Support `-specs` arguments when querying the driver.

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -54,22 +55,67 @@ void GPUToSPIRVPass::runOnOperation() { SmallVector gpuModules; OpBuilder builder(context); + + auto getTargetEnvFromGPUModuleOp = [*this](gpu::GPUModuleOp moduleOp) { +Operation *gpuModule = moduleOp.getOperation(); +auto targetAttr =

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -54,22 +55,67 @@ void GPUToSPIRVPass::runOnOperation() { SmallVector gpuModules; OpBuilder builder(context); + + auto getTargetEnvFromGPUModuleOp = [*this](gpu::GPUModuleOp moduleOp) { +Operation *gpuModule = moduleOp.getOperation(); +auto targetAttr =

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -54,22 +55,67 @@ void GPUToSPIRVPass::runOnOperation() { SmallVector gpuModules; OpBuilder builder(context); + + auto getTargetEnvFromGPUModuleOp = [*this](gpu::GPUModuleOp moduleOp) { +Operation *gpuModule = moduleOp.getOperation(); +auto targetAttr =

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -108,6 +147,31 @@ void GPUToSPIRVPass::runOnOperation() { if (failed(applyFullConversion(gpuModule, *target, std::move(patterns return signalPassFailure(); } + + // In case of OpenCL, gpu.func in original gpu.module needs to replaced with

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -54,22 +55,67 @@ void GPUToSPIRVPass::runOnOperation() { SmallVector gpuModules; OpBuilder builder(context); + + auto getTargetEnvFromGPUModuleOp = [*this](gpu::GPUModuleOp moduleOp) { +Operation *gpuModule = moduleOp.getOperation(); +auto targetAttr =

[clang] [clang-format] Option to ignore PP directives (PR #70338)

owenca wrote: > #67911 is a pull request, not an issue, i'm not sure what you're referring to I think it was a typo. It should be #67991. https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -54,22 +55,67 @@ void GPUToSPIRVPass::runOnOperation() { SmallVector gpuModules; OpBuilder builder(context); + + auto getTargetEnvFromGPUModuleOp = [*this](gpu::GPUModuleOp moduleOp) { +Operation *gpuModule = moduleOp.getOperation(); +auto targetAttr =

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -54,22 +55,67 @@ void GPUToSPIRVPass::runOnOperation() { SmallVector gpuModules; OpBuilder builder(context); + + auto getTargetEnvFromGPUModuleOp = [*this](gpu::GPUModuleOp moduleOp) { +Operation *gpuModule = moduleOp.getOperation(); +auto targetAttr =

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -54,22 +55,67 @@ void GPUToSPIRVPass::runOnOperation() { SmallVector gpuModules; OpBuilder builder(context); + + auto getTargetEnvFromGPUModuleOp = [*this](gpu::GPUModuleOp moduleOp) { +Operation *gpuModule = moduleOp.getOperation(); +auto targetAttr =

[clang] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -54,22 +55,67 @@ void GPUToSPIRVPass::runOnOperation() { SmallVector gpuModules; OpBuilder builder(context); + + auto getTargetEnvFromGPUModuleOp = [*this](gpu::GPUModuleOp moduleOp) { +Operation *gpuModule = moduleOp.getOperation(); +auto targetAttr =

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -143,11 +145,12 @@ void GPUToSPIRVPass::runOnOperation() { if (failed(applyFullConversion(gpuModule, *target, std::move(patterns return signalPassFailure(); } + // In case of OpenCL, gpu.func in original gpu.module needs to replaced with // an empty

[clang] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -143,11 +145,12 @@ void GPUToSPIRVPass::runOnOperation() { if (failed(applyFullConversion(gpuModule, *target, std::move(patterns return signalPassFailure(); } + // In case of OpenCL, gpu.func in original gpu.module needs to replaced with // an empty

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -76,22 +76,24 @@ void GPUToSPIRVPass::runOnOperation() { // This works fine for Vulkan shader that has a dedicated runner. // But OpenCL kernel needs SPIRV module placed inside original GPU module as // OpenCL uses GPU compilation pipeline. -auto targetEnv

[clang] [clang-format] Option to ignore PP directives (PR #70338)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -76,22 +76,24 @@ void GPUToSPIRVPass::runOnOperation() { // This works fine for Vulkan shader that has a dedicated runner. // But OpenCL kernel needs SPIRV module placed inside original GPU module as // OpenCL uses GPU compilation pipeline. -auto targetEnv

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -76,22 +76,24 @@ void GPUToSPIRVPass::runOnOperation() { // This works fine for Vulkan shader that has a dedicated runner. // But OpenCL kernel needs SPIRV module placed inside original GPU module as // OpenCL uses GPU compilation pipeline. -auto targetEnv

[clang] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -76,22 +76,24 @@ void GPUToSPIRVPass::runOnOperation() { // This works fine for Vulkan shader that has a dedicated runner. // But OpenCL kernel needs SPIRV module placed inside original GPU module as // OpenCL uses GPU compilation pipeline. -auto targetEnv

[clang] [clang-format][NFC] Delete TT_LambdaArrow (PR #70519)

https://github.com/rymiel approved this pull request. Surprised this works! https://github.com/llvm/llvm-project/pull/70519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

https://github.com/silee2 updated https://github.com/llvm/llvm-project/pull/69941 >From 7ca3f97b5ee6e5cefd94afd3b090d0dba2120cea Mon Sep 17 00:00:00 2001 From: "Lee, Sang Ik" Date: Mon, 23 Oct 2023 16:25:15 + Subject: [PATCH 1/6] [MLIR] Update convert-gpu-to-spirv pass to prepare using

[clang] [clang-format] Option to ignore PP directives (PR #70338)

https://github.com/owenca requested changes to this pull request. Please refer to the [policy](https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options) for adding new options. https://github.com/llvm/llvm-project/pull/70338

[clang] [clang-format] Option to ignore PP directives (PR #70338)

@@ -4648,6 +4648,10 @@ struct FormatStyle { /// \version 11 std::vector WhitespaceSensitiveMacros; + /// Ignore formatting in preprocessor definitions. + /// \version 18 + bool IgnorePPDefinitions; rymiel wrote: (this applies to not just here, but

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

https://github.com/silee2 updated https://github.com/llvm/llvm-project/pull/69941 >From 7ca3f97b5ee6e5cefd94afd3b090d0dba2120cea Mon Sep 17 00:00:00 2001 From: "Lee, Sang Ik" Date: Mon, 23 Oct 2023 16:25:15 + Subject: [PATCH 1/5] [MLIR] Update convert-gpu-to-spirv pass to prepare using

[clang] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

https://github.com/silee2 updated https://github.com/llvm/llvm-project/pull/69941 >From 7ca3f97b5ee6e5cefd94afd3b090d0dba2120cea Mon Sep 17 00:00:00 2001 From: "Lee, Sang Ik" Date: Mon, 23 Oct 2023 16:25:15 + Subject: [PATCH 1/5] [MLIR] Update convert-gpu-to-spirv pass to prepare using

[clang] [clang-format] Option to ignore PP directives (PR #70338)

rymiel wrote: https://github.com/llvm/llvm-project/pull/67911 is a pull request, not an issue, i'm not sure what you're referring to https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

MaskRay added inline comments. Herald added subscribers: wangpc, luke, sunshaoce, arichardson. Herald added a project: All. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:40 + const llvm::opt::ArgList ) { + if

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/67166 >From 686eff52ac0878fa9545481eaf32b47350c68be8 Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Fri, 22 Sep 2023 08:21:21 -0500 Subject: [PATCH 1/8] [InstSimplify] Add tests for simplify `llvm.ptrmask`;

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 01/19] [clang-tidy]

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

antiagainst wrote: Thanks for the contribution and sorry about the delay! I'm getting around to review this pull request (already done a few others). Please wait a bit. https://github.com/llvm/llvm-project/pull/69949 ___ cfe-commits mailing list

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

antiagainst wrote: Thanks for the contribution and sorry about the delay! I'm getting around to review this pull request (already done a few others). Please wait a bit. https://github.com/llvm/llvm-project/pull/69949 ___ cfe-commits mailing list

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

jamesETsmith wrote: The strategy using `ProxyDiffTBase` is implemented in 88e271a. Initially, it caused a bunch of errors elsewhere because the compiler generated `==` and `<=>` member functions would cause checks like `std::totally_ordered_with, Proxy&>` to fail (see

[clang] [libc++] Implement ranges::iota (PR #68494)

https://github.com/jamesETsmith updated https://github.com/llvm/llvm-project/pull/68494 >From c4a3ccfbad090ad8314aa8ad53092edc8d5432bc Mon Sep 17 00:00:00 2001 From: James Smith Date: Thu, 28 Sep 2023 10:11:15 -0400 Subject: [PATCH 01/11] [libc++] Implement ranges::iota and

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

https://github.com/jamesETsmith updated https://github.com/llvm/llvm-project/pull/68494 >From c4a3ccfbad090ad8314aa8ad53092edc8d5432bc Mon Sep 17 00:00:00 2001 From: James Smith Date: Thu, 28 Sep 2023 10:11:15 -0400 Subject: [PATCH 01/11] [libc++] Implement ranges::iota and

[PATCH] D126132: [clang-format] Fix a crash on lambda trailing return type

owenpan added a comment. Herald added a reviewer: rymiel. In D126132#3546767 , @HazardyKnusperkeks wrote: > One should define what is the difference between `TT_LambdaArrow` and > `TT_TrailingReturnArrow`. But if there is a difference, then the lambda

[clang] [clang-format][NFC] Delete TT_LambdaArrow (PR #70519)

llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes It's one type of TT_TrailingReturnArrow. --- Full diff: https://github.com/llvm/llvm-project/pull/70519.diff 5 Files Affected: - (modified) clang/lib/Format/ContinuationIndenter.cpp (+5-3) - (modified)

[clang] [clang-format][NFC] Delete TT_LambdaArrow (PR #70519)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/70519 It's one type of TT_TrailingReturnArrow. >From 64d622264f2e3cd3345f741965f450daa00bac5e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 27 Oct 2023 15:33:40 -0700 Subject: [PATCH] [clang-format][NFC] Delete

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

goldsteinn wrote: > The InstCombine/ptrmask.ll test is failing in CI. Bah, forgot to rebase the instcombine ptrmask tests ontop of simplication fix. https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list

[clang] [AMDGPU] make v32i16/v32f16 legal (PR #70484)

https://github.com/changpeng closed https://github.com/llvm/llvm-project/pull/70484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70512)

https://github.com/ayermolo closed https://github.com/llvm/llvm-project/pull/70512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Bfi precision (PR #66285)

MatzeB wrote: And digging even deeper: - FWIW I noticed that I only used `clang -c` as benchmark previously, should have used `clang -c -O3` resulting in this: ``` Old-BFI: insn: 37,821,687,947 (baseline) New-BFI: insn: 38,133,312,923 +0.82% Old-BFI, no-cold: insn:

[clang] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70512)

https://github.com/ayermolo updated https://github.com/llvm/llvm-project/pull/70512 >From 1c6a604df93b833c3bb9c7d34f4f27415592dbe5 Mon Sep 17 00:00:00 2001 From: Alexander Yermolovich Date: Thu, 5 Oct 2023 12:39:02 -0700 Subject: [PATCH] [LLVM][DWARF] Add support for monolithic types in

[clang] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70512)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/70512 >From 1c6a604df93b833c3bb9c7d34f4f27415592dbe5 Mon Sep 17 00:00:00 2001 From: Alexander Yermolovich Date: Thu, 5 Oct 2023 12:39:02 -0700 Subject: [PATCH] [LLVM][DWARF] Add support for monolithic types in

[clang] [AMDGPU] make v32i16/v32f16 legal (PR #70484)

https://github.com/rampitec approved this pull request. https://github.com/llvm/llvm-project/pull/70484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

efriedma-quic wrote: I'm planning to take a closer look at this when I have more time. Sorry I haven't been more responsive here. One very brief note: in the comments in the code, you might want to distinguish between the semantic width of a bitfield (i.e. the C standard notion of a "memory

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

@@ -274,20 +274,27 @@ class DefaultIntArgument : IntArgument { } // This argument is more complex, it includes the enumerator type name, -// a list of strings to accept, and a list of enumerators to map them to. -class EnumArgument values, +// a list of possible values, and

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 01/17] [clang-tidy]

[clang] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

https://github.com/s-barannikov edited https://github.com/llvm/llvm-project/pull/68550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

@@ -886,7 +893,7 @@ def ARMInterrupt : InheritableAttr, TargetSpecificAttr { // MSP430Interrupt's, MipsInterrupt's and AnyX86Interrupt's spellings // must match. let Spellings = [GCC<"interrupt">]; - let Args = [EnumArgument<"Interrupt", "InterruptType", + let Args =

[clang] [clang] Language to String function (PR #69487)

https://github.com/ysyeda closed https://github.com/llvm/llvm-project/pull/69487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 703895b - [clang] Language to String function (#69487)

Author: Yusra Syeda Date: 2023-10-27T17:22:49-04:00 New Revision: 703895b131720682a3ca596a96a7c94fb281c0e4 URL: https://github.com/llvm/llvm-project/commit/703895b131720682a3ca596a96a7c94fb281c0e4 DIFF: https://github.com/llvm/llvm-project/commit/703895b131720682a3ca596a96a7c94fb281c0e4.diff

[clang] [clang] Language to String function (PR #69487)

https://github.com/ysyeda edited https://github.com/llvm/llvm-project/pull/69487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

efriedma-quic wrote: Also, you might want to consider marking the offset immarg, instead of trying to handle variable offsets in isel. https://github.com/llvm/llvm-project/pull/68565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

https://github.com/efriedma-quic commented: Could you briefly comment on the tradeoff of adding an argument to the intrinsic, vs. pattern-matching constant offsets to the existing intrinsic? https://github.com/llvm/llvm-project/pull/68565 ___

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

@@ -292,7 +292,42 @@ define void @ldr_with_off_16mulvl(ptr %ptr) { %vscale = call i64 @llvm.vscale.i64() %mulvl = mul i64 %vscale, 256 %base = getelementptr i8, ptr %ptr, i64 %mulvl - call void @llvm.aarch64.sme.ldr(i32 16, ptr %base) + call void

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/68565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

nikic wrote: The InstCombine/ptrmask.ll test is failing in CI. https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

https://github.com/arichardson commented: All my comments have been resolved, thank you very much! https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 01/16] [clang-tidy]

[clang] [libc++] Implement ranges::iota (PR #68494)

jamesETsmith wrote: That's much cleaner than what I was coming up with, thanks! https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 01/15] [clang-tidy]

[clang] [CGExprConstant] stop calling into ConstExprEmitter for Reference type destinations (PR #70366)

https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/70366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71659: [clang-format] Added new option to allow setting spaces before and after the operator

owenpan commandeered this revision. owenpan edited reviewers, added: Luis; removed: owenpan. Herald added a project: All. Herald added reviewers: rymiel, HazardyKnusperkeks. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review contains a change to

[clang] [CGExprConstant] stop calling into ConstExprEmitter for Reference type destinations (PR #70366)

https://github.com/nickdesaulniers updated https://github.com/llvm/llvm-project/pull/70366 >From 52e5c1083f82c045dc0af26badf159e8b1593bd1 Mon Sep 17 00:00:00 2001 From: Nick Desaulniers Date: Thu, 26 Oct 2023 11:11:29 -0700 Subject: [PATCH 1/3] [CGExprConstant] stop evaluating StringLiterals

[clang] [CGExprConstant] stop calling into ConstExprEmitter for Reference type destinations (PR #70366)

nickdesaulniers wrote: > I think I'd prefer to avoid calling into ConstExprEmitter at all for cases > involving reference binding. I think we've sort of discussed this before. > Maybe add a check to tryEmitPrivate()? (We already have a check in > tryEmitPrivateForVarInit().) Done in

[clang] [CGExprConstant] stop calling into ConstExprEmitter for Reference type destinations (PR #70366)

https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/70366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGExprConstant] stop evaluating StringLiterals for non-ConstantArrayTypes (PR #70366)

https://github.com/nickdesaulniers updated https://github.com/llvm/llvm-project/pull/70366 >From 52e5c1083f82c045dc0af26badf159e8b1593bd1 Mon Sep 17 00:00:00 2001 From: Nick Desaulniers Date: Thu, 26 Oct 2023 11:11:29 -0700 Subject: [PATCH 1/2] [CGExprConstant] stop evaluating StringLiterals

[clang] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Robustify openmp test (PR #69739)

urnathan wrote: @jdoerfert thanks for that, here's an update that focusses the check-not more precisely. https://github.com/llvm/llvm-project/pull/69739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Robustify openmp test (PR #69739)

https://github.com/urnathan updated https://github.com/llvm/llvm-project/pull/69739 >From bb391aa466577f4187af6b284ee5107090778a03 Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Fri, 20 Oct 2023 11:43:08 -0400 Subject: [PATCH 1/2] [clang] Robustify open mp test If the source path

[clang] [libc++] Implement ranges::iota (PR #68494)

philnik777 wrote: You can add a base class like this: https://godbolt.org/z/ccG7jcqee https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Change representation of CurLexerKind (PR #70381)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/70381 >From 3fe63f81fcb999681daa11b2890c82fda3aaeef5 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 26 Oct 2023 22:31:43 +0200 Subject: [PATCH] [clang] Change representation of CurLexerKind

[clang] [clang][NFC] Assert not llvm_unreachable (PR #70149)

https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/70149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGExprConstant] stop evaluating StringLiterals for non-ConstantArrayTypes (PR #70366)

efriedma-quic wrote: I think I'd prefer to avoid calling into ConstExprEmitter at all for cases involving reference binding. I think we've sort of discussed this before. Maybe add a check to tryEmitPrivate()? (We already have a check in tryEmitPrivateForVarInit().)

[clang-tools-extra] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

@@ -0,0 +1,184 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only -verify -Wall -Wextra -Wno-error=unreachable-code -Wno-unused + +#include "Inputs/std-coroutine.h" + +using std::suspend_always; +using std::suspend_never; + + +#define CORO_TYPE

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/67166 >From 24c65907e7e6792e2d5395102992ce3cdb42fb6d Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Fri, 22 Sep 2023 08:21:21 -0500 Subject: [PATCH 1/7] [InstSimplify] Add tests for simplify `llvm.ptrmask`;

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

@@ -6411,6 +6411,40 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +if (isa(Op0) || isa(Op1)) + return PoisonValue::get(Op0->getType()); + +

[clang] [clang] Change representation of CurLexerKind (PR #70381)

serge-sans-paille wrote: Agreed. Sorry I pushed --force my change out of habit :-/ https://github.com/llvm/llvm-project/pull/70381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Change representation of CurLexerKind (PR #70381)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/70381 >From 6a41a1f9a48135fe1a43b70904e105fe638189ce Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 26 Oct 2023 22:31:43 +0200 Subject: [PATCH] [clang] Change representation of CurLexerKind

[clang] [clang] Change representation of CurLexerKind (PR #70381)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/70381 >From 7711f8c85c7e106b2662d1a2505f91f0417fac5a Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 26 Oct 2023 22:31:43 +0200 Subject: [PATCH] [clang] Change representation of CurLexerKind

[clang] 5c15922 - [clang] Remove no-op ptr-to-ptr bitcasts (NFC)

Author: Youngsuk Kim Date: 2023-10-27T14:59:42-05:00 New Revision: 5c159222627e2201bee73c401be3b76f995b2336 URL: https://github.com/llvm/llvm-project/commit/5c159222627e2201bee73c401be3b76f995b2336 DIFF: https://github.com/llvm/llvm-project/commit/5c159222627e2201bee73c401be3b76f995b2336.diff

[clang] [OpenMP][AMDGPU] Do not include 'ockl' implementations in OpenMP (PR #70462)

https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/70462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5513d58 - [OpenMP][AMDGPU] Do not include 'ockl' implementations in OpenMP (#70462)

Author: Joseph Huber Date: 2023-10-27T14:56:29-05:00 New Revision: 5513d58ad5da093ac94ec511e575b1d27606b737 URL: https://github.com/llvm/llvm-project/commit/5513d58ad5da093ac94ec511e575b1d27606b737 DIFF: https://github.com/llvm/llvm-project/commit/5513d58ad5da093ac94ec511e575b1d27606b737.diff

  1   2   3   4   >