akhuang updated this revision to Diff 192846.
akhuang marked an inline comment as done.
akhuang added a comment.
Tmpfile was not being removed
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59725/new/
https://reviews.llvm.org/D59725
Files:
clang/utils/creduce-clang-crash.py
Index:
akhuang marked 2 inline comments as done.
akhuang added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:208
+print("\nTrying to preprocess the source file...")
+# use delete=False in case the tmpfile flag causes problems when copying
+with
akhuang marked 2 inline comments as done.
akhuang added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:223
+ if len(x) > 0 and x[-1].startswith('-') and not y.startswith('-'):
+x[-1] += ' ' + y
+return x
george.burgess.iv
akhuang updated this revision to Diff 192218.
akhuang marked an inline comment as done.
akhuang added a comment.
Style nits, added comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59725/new/
https://reviews.llvm.org/D59725
Files:
clang/utils/creduce-clang-crash.py
Index:
akhuang updated this revision to Diff 192230.
akhuang added a comment.
fix issue with grouping two command line args together
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59725/new/
https://reviews.llvm.org/D59725
Files:
clang/utils/creduce-clang-crash.py
Index:
akhuang marked 15 inline comments as done.
akhuang added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:137
+
+# If no message was found, use the top five stack trace functions,
+# ignoring some common functions
george.burgess.iv wrote:
akhuang updated this revision to Diff 192499.
akhuang marked 3 inline comments as done.
akhuang added a comment.
change `mkstemp` to `NamedTemporaryFile` and add `decode(utf-8)` so it works on
python3.5
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59725/new/
akhuang added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:198
+# Instead of modifying the filename in the test file, just run the command
+fd, empty_file = tempfile.mkstemp()
+if self.check_expected_output(filename=empty_file):
akhuang created this revision.
akhuang added reviewers: rnk, george.burgess.iv, arichardson.
Herald added a reviewer: serge-sans-paille.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Some more additions to the script - mainly reducing the clang args after the
creduce run
akhuang created this revision.
akhuang added a reviewer: rnk.
Herald added subscribers: cfe-commits, jfb.
Herald added a project: clang.
Emit !heapallocsite in the metadata for calls to functions marked with
__declspec(allocator). Eventually this will be emitted as S_HEAPALLOCSITE debug
info in
akhuang created this revision.
Herald added subscribers: cfe-commits, jfb.
Herald added a project: clang.
emit metadata for __declspec(allocator)
add tests for heapallocsite metadata
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D60236
Files:
clang/lib/CodeGen/CGAtomic.cpp
akhuang updated this revision to Diff 193792.
akhuang marked 3 inline comments as done.
akhuang added a comment.
-added struct case to test
-style fixes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60237/new/
https://reviews.llvm.org/D60237
Files:
clang/lib/CodeGen/CGCall.cpp
akhuang updated this revision to Diff 193751.
akhuang marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60237/new/
https://reviews.llvm.org/D60237
Files:
clang/lib/CodeGen/CGCall.cpp
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CGDebugInfo.h
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGAtomic.cpp:1691
} else {
-// Build new lvalue for temp address
+// Build new lvalue for temp address.
Address Ptr = Atomics.materializeRValue(OldRVal);
akhuang abandoned this revision.
akhuang added a comment.
test commit with incorrect diff
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60236/new/
https://reviews.llvm.org/D60236
___
cfe-commits
akhuang updated this revision to Diff 192669.
akhuang marked 3 inline comments as done.
akhuang added a comment.
Add preprocessing with clang -E only;
use `with` for opening files
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59725/new/
https://reviews.llvm.org/D59725
Files:
akhuang added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:212
+
+cmd = self.get_crash_cmd() + ['-E', '-P']
+try:
arichardson wrote:
> Some crash messages might include the line numbers, do you think it makes
> sense to fall back to
akhuang marked 8 inline comments as done.
akhuang added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:145
+ matches = re.findall(stacktrace_re, crash_output)
+ result = filter(lambda x: x and x.strip() not in filters, matches)[:5]
+ for msg in
akhuang updated this revision to Diff 192350.
akhuang marked 2 inline comments as done.
akhuang added a comment.
Herald added a subscriber: jdoerfert.
added to error message regexes and command line flags
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59725/new/
akhuang updated this revision to Diff 192145.
akhuang added a comment.
Fix some typos, pass --tidy flag to creduce
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59725/new/
https://reviews.llvm.org/D59725
Files:
clang/utils/creduce-clang-crash.py
Index:
akhuang updated this revision to Diff 192149.
akhuang added a comment.
reuploaded diff with full context
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59725/new/
https://reviews.llvm.org/D59725
Files:
clang/utils/creduce-clang-crash.py
Index: clang/utils/creduce-clang-crash.py
akhuang updated this revision to Diff 191128.
akhuang added a comment.
fix some typos
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index: clang/utils/creduce-clang-crash.py
akhuang updated this revision to Diff 191409.
akhuang added a comment.
style things
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index: clang/utils/creduce-clang-crash.py
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:106-117
+ # Check that an empty file is not interesting
+ # file_to_reduce is hardcoded into the test, so this is a roundabout
+ # way to run it on an empty
akhuang updated this revision to Diff 191192.
akhuang added a comment.
Modify interestingness test to take file as input
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index:
akhuang updated this revision to Diff 191217.
akhuang marked 2 inline comments as done.
akhuang added a comment.
Fixed typo where it was writing the abspath of the file to the interestingness
test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
akhuang updated this revision to Diff 191199.
akhuang marked an inline comment as done.
akhuang added a comment.
fixed array copy mistake
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index:
akhuang updated this revision to Diff 190285.
akhuang marked 6 inline comments as done.
akhuang added a comment.
style edits
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59118/new/
https://reviews.llvm.org/D59118
Files:
clang/utils/creduce-clang-crash.py
Index:
akhuang updated this revision to Diff 190189.
akhuang added a comment.
add interestingness test sanity check;
revive ctrl-c hack
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59118/new/
https://reviews.llvm.org/D59118
Files:
clang/utils/creduce-clang-crash.py
Index:
akhuang updated this revision to Diff 190929.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index: clang/utils/creduce-clang-crash.py
akhuang created this revision.
akhuang added reviewers: rnk, george.burgess.iv.
Herald added a reviewer: serge-sans-paille.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
-try to preprocess the file before reducing
-try to remove some command line arguments
-now requires a
akhuang updated this revision to Diff 190126.
akhuang marked 15 inline comments as done.
akhuang added a comment.
Addressed readability comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59118/new/
https://reviews.llvm.org/D59118
Files:
clang/utils/creduce-clang-crash.py
akhuang added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:43
+ # Get crash output
+ p = subprocess.Popen(build_script,
+ stdout=subprocess.PIPE,
george.burgess.iv wrote:
> nit: can replace with
akhuang created this revision.
akhuang added reviewers: rnk, george.burgess.iv.
Herald added a reviewer: serge-sans-paille.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add a script that calls C-Reduce on an input file and given the clang crash
script, which is used to
akhuang added a comment.
@arichardson Will add you next time, sorry I didn't do so on this one!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
___
cfe-commits mailing list
akhuang updated this revision to Diff 191598.
akhuang added a comment.
style nits, fixed thing in getting path to clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index:
akhuang updated this revision to Diff 194164.
akhuang marked 2 inline comments as done.
akhuang added a comment.
Fixes to test case
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60237/new/
https://reviews.llvm.org/D60237
Files:
clang/lib/CodeGen/CGCall.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL357928: [MS] Add metadata for __declspec(allocator)
(authored by akhuang, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
akhuang updated this revision to Diff 195475.
akhuang added a comment.
remove comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
akhuang updated this revision to Diff 195480.
akhuang added a comment.
Fix test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
akhuang updated this revision to Diff 195478.
akhuang added a comment.
more typos
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
akhuang created this revision.
akhuang added reviewers: hans, rnk.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, aprantl.
Herald added projects: clang, LLVM.
This emits labels around heapallocsite calls and S_HEAPALLOCSITE debug
info in codeview. Currently only changes FastISel,
akhuang added a comment.
Looks good- if we remove `not` there are a few other things that should be
removed
Comment at: clang/utils/creduce-clang-crash.py:138
if "fatal error:" in msg_re:
self.is_crash = False
break
also wouldn't
akhuang updated this revision to Diff 190164.
akhuang added a comment.
fixed diff with style edits
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59118/new/
https://reviews.llvm.org/D59118
Files:
.arcconfig
clang/utils/creduce-clang-crash.py
Index:
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385
+// Use the global scope for static members.
+DContext = getContextDescriptor(
+ cast(CGM.getContext().getTranslationUnitDecl()), TheCU);
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362166: Add enums as global variables in the IR metadata.
(authored by akhuang, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D62635?vs=202079=202312#toc
Repository:
rL LLVM
akhuang updated this revision to Diff 202027.
akhuang added a comment.
Herald added a subscriber: hiraditya.
Append class name to static data member debug info name.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62167/new/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362038: CodeView - add static data members to global
variable debug info. (authored by akhuang, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D62167?vs=202027=202063#toc
akhuang created this revision.
akhuang added a reviewer: rnk.
Herald added subscribers: llvm-commits, cfe-commits, aprantl.
Herald added projects: clang, LLVM.
Keeps track of the enums that were used by saving them as DIGlobalVariables,
since CodeView emits debug info for global constants.
akhuang updated this revision to Diff 204878.
akhuang added a comment.
- fix test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63361/new/
https://reviews.llvm.org/D63361
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
akhuang created this revision.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D63361
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CGDecl.cpp
akhuang updated this revision to Diff 204137.
akhuang added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Change to not emit DIGlobalVariable for enums when they are defined in a class,
which
matches MSVC's behavior and gets around the issue of having to
akhuang updated this revision to Diff 205385.
akhuang added a comment.
- add semicolon
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63361/new/
https://reviews.llvm.org/D63361
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
akhuang updated this revision to Diff 205382.
akhuang marked 2 inline comments as done.
akhuang added a comment.
Now creates a pointer to the return location in the function prolog, whenever
sret is being used.
Also addressed some other comments.
Repository:
rG LLVM Github Monorepo
CHANGES
akhuang added inline comments.
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1145-1149
+bool Deref = false;
+if (VI.Expr) {
+ if (!VI.Expr->extractIfOffset(ExprOffset, Deref))
continue;
+}
rnk wrote:
> I see. I thought this
akhuang added a comment.
They should all be there, but emitting the unused enums makes the binary sizes
larger. (I think around 6% increase? I forget the size difference for only
emitting used enums)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62635/new/
akhuang added a comment.
I think the main issue was keeping track of which enums are used?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62635/new/
https://reviews.llvm.org/D62635
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL363335: Use fully qualified name when printing S_CONSTANT
records (authored by akhuang, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D63012?vs=204137=204649#toc
Repository:
rL
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3946
+ // the address of the variable.
+ if (VD->isNRVOVariable())
+Expr.push_back(llvm::dwarf::DW_OP_deref);
rnk wrote:
> I think we
akhuang updated this revision to Diff 205649.
akhuang added a comment.
- Add clang and llvm tests, and windows debuginfo test
- Use GEP as returnValuePointer in inalloca case
- Add bool parameter for EmitDeclare when pointer is being used
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:908
--EI;
llvm::Value *Addr = Builder.CreateStructGEP(nullptr, &*EI, Idx);
Addr = Builder.CreateAlignedLoad(Addr, getPointerAlign(),
akhuang updated this revision to Diff 205712.
akhuang marked 2 inline comments as done.
akhuang added a comment.
Herald added a subscriber: javed.absar.
- fix alignment of pointer in inalloca case
- make existing tests stop failing by changing some and adding a check for
existing return value
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:908
--EI;
llvm::Value *Addr = Builder.CreateStructGEP(nullptr, &*EI, Idx);
Addr = Builder.CreateAlignedLoad(Addr, getPointerAlign(), "agg.result");
rnk wrote:
>
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL363952: Store a pointer to the return value in a static
alloca and let the debugger use… (authored by akhuang, committed
akhuang added a comment.
Looks good, alternatively I think we can just change `%result.ptr` into a
variable match?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63625/new/
https://reviews.llvm.org/D63625
akhuang accepted this revision.
akhuang added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63625/new/
https://reviews.llvm.org/D63625
akhuang added a comment.
> Why isn't this using FileCheck variable matching in the first place? That's
> the least fragile solution.
No reason, just something I overlooked when I wrote it-
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63625/new/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL361400: Combine two if cases because the second one is never
reached. (authored by akhuang, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
akhuang updated this revision to Diff 201004.
akhuang added a comment.
Add llvm IR test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62167/new/
https://reviews.llvm.org/D62167
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385
+// Use the global scope for static members.
+DContext = getContextDescriptor(
+ cast(CGM.getContext().getTranslationUnitDecl()), TheCU);
akhuang created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D62214
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
Index: clang/lib/CodeGen/CGDebugInfo.cpp
akhuang marked an inline comment as done.
akhuang added a subscriber: dblaikie.
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385
+// Use the global scope for static members.
+DContext = getContextDescriptor(
+
akhuang created this revision.
akhuang added a reviewer: rnk.
Herald added subscribers: llvm-commits, cfe-commits, aprantl.
Herald added projects: clang, LLVM.
Add static data members to IR debug info's list of global variables
so that they are emitted as S_CONSTANT records.
Related to
akhuang updated this revision to Diff 197651.
akhuang added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61407/new/
https://reviews.llvm.org/D61407
Files:
clang/lib/CodeGen/CGCall.cpp
clang/lib/CodeGen/CGExprScalar.cpp
akhuang created this revision.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D61407
Files:
clang/lib/CodeGen/CGCall.cpp
clang/lib/CodeGen/CGExprScalar.cpp
akhuang updated this revision to Diff 195818.
akhuang marked 2 inline comments as done.
akhuang added a comment.
- Pass void metadata as null DIType
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: llvm/test/CodeGen/X86/label-heapallocsite.ll:1
+; RUN: llc -O0 < %s | FileCheck %s
+; FIXME: Add test for llc with optimizations once it is implemented.
hans wrote:
> Does llc
akhuang updated this revision to Diff 195821.
akhuang marked 2 inline comments as done.
akhuang added a comment.
- Changed test case back to original
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
akhuang updated this revision to Diff 195877.
akhuang added a comment.
whitespace fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL358783: [MS] Emit S_HEAPALLOCSITE debug info (authored by
akhuang, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D60800?vs=195877=195909#toc
Repository:
rL LLVM
CHANGES SINCE
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966
+ QualType PointeeTy = D.getTypePtr()->getPointeeType();
+ llvm::DIType *DI = getOrCreateType(PointeeTy, getOrCreateFile(Loc));
+ CI->setMetadata("heapallocsite", DI);
hans
akhuang updated this revision to Diff 195783.
akhuang marked 4 inline comments as done.
akhuang added a comment.
Removed extraneous information from test; changed type to DIType
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
akhuang created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
akhuang abandoned this revision.
akhuang added a comment.
accidentally created a new revision
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D61455
Files:
akhuang closed this revision.
akhuang added a comment.
Committed in r359823
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61407/new/
https://reviews.llvm.org/D61407
___
cfe-commits mailing list
akhuang updated this revision to Diff 197851.
akhuang added a comment.
Change dyn_cast to isa
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61407/new/
https://reviews.llvm.org/D61407
Files:
clang/lib/CodeGen/CGCall.cpp
akhuang abandoned this revision.
akhuang added a comment.
accidentally created a new revision
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61455/new/
https://reviews.llvm.org/D61455
___
cfe-commits
akhuang updated this revision to Diff 197830.
akhuang marked an inline comment as done.
akhuang added a comment.
- Add test case for multiple casts
- Remove unrelated changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61407/new/
akhuang marked 2 inline comments as done.
akhuang added a comment.
Reverted `getCompleteTypeIndex` change, to be fixed elsewhere
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61407/new/
https://reviews.llvm.org/D61407
akhuang updated this revision to Diff 196525.
akhuang added a comment.
- Add test case and comment for undefined labels
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61083/new/
https://reviews.llvm.org/D61083
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL359149: Recommitting r358783 and r358786 [MS] Emit
S_HEAPALLOCSITE debug info with… (authored by akhuang, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61083?vs=196525=196540#toc
akhuang created this revision.
akhuang added a reviewer: rnk.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, aprantl.
Herald added projects: clang, LLVM.
This emits labels around heapallocsite calls and S_HEAPALLOCSITE debug
info in codeview. Currently only changes FastISel, so
akhuang updated this revision to Diff 196496.
akhuang added a comment.
- remove added whitespace
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61083/new/
https://reviews.llvm.org/D61083
Files:
llvm/include/llvm/CodeGen/MachineFunction.h
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: cfe/trunk/utils/creduce-clang-crash.py:185
+for msg in self.expected_output:
+ output += 'grep %s t.log || exit 1\n' % pipes.quote(msg)
+
lebedev.ri wrote:
> akhuang
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: cfe/trunk/utils/creduce-clang-crash.py:185
+for msg in self.expected_output:
+ output += 'grep %s t.log || exit 1\n' % pipes.quote(msg)
+
lebedev.ri wrote:
> >>! In
akhuang added a comment.
> Address space have backend defined semantics, and aren’t really reserved for
> front end use. I think the fact that non-0 address spaces on X86 codegen the
> same as address space 0 and could be used for something by a front end is an
> accident of how SelectionDAG
akhuang added a comment.
Pinging reviewers -- are there any other concerns on this patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64931/new/
https://reviews.llvm.org/D64931
___
cfe-commits
akhuang created this revision.
akhuang added reviewers: rnk, rsmith.
Herald added subscribers: llvm-commits, cfe-commits, erik.pilkington,
hiraditya, nhaehnle, jvesely, jholewinski.
Herald added projects: clang, LLVM.
Previously, these qualifiers were being parsed but otherwise ignored.
This
akhuang updated this revision to Diff 217940.
akhuang marked 4 inline comments as done.
akhuang added a comment.
- Test that codegen adds the correct address spaces
- Modify microsoft mangling to match microsoft mangling.
- add comment for overloading
Repository:
rG LLVM Github Monorepo
akhuang marked 2 inline comments as done.
akhuang added inline comments.
Comment at: clang/lib/AST/MicrosoftMangle.cpp:1874
+case LangAS::ptr32_sptr:
+ Extra.mangleSourceName("_ASPtr32_sptr");
+ break;
rnk wrote:
> Hm, we should actually mangle
akhuang closed this revision.
akhuang added a comment.
Commited in r370083
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64931/new/
https://reviews.llvm.org/D64931
___
cfe-commits mailing list
1 - 100 of 409 matches
Mail list logo