[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar created this revision. andwar added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements the basic parsing and semantic analysis of `#pragma omp declare variant`: * registers '#pragma

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar added a comment. I've addressed most of the comments except for those related to templates. I'd like to clarify as what is the expected behaviour there before proceeding with implementation. Comment at: include/clang/Basic/Attr.td:3220 +private: + NamedDecl

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar updated this revision to Diff 219673. andwar marked 6 inline comments as done. andwar added a comment. - Removed `declare variant` from Attr.td - Moved the 'vector-var-id' lookup from ParseOpenMP.cpp to SemaOpenMP.cpp - Parsing 'vector-var-id' as an expression - Removed the creation of the

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar marked 2 inline comments as done. andwar added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:779-783 + auto Identinfo = PP.getIdentifierInfo(VectorVariantId.Ident->getName()); + LookupResult Lookup(Actions, Identinfo, VectorVariantId.Loc, +

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

andwar added inline comments. Comment at: llvm/examples/Bye/Bye.cpp:53 +/* New PM Registration */ + +llvm::PassPluginLibraryInfo getByePluginInfo() { [nit] Empty line Comment at: llvm/examples/Bye/CMakeLists.txt:9 +else() +

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

andwar added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10923 +static SDValue LowerSVEIntrinsicIndex(SDNode *N, SelectionDAG ) { + SDLoc dl(N); + SDValue Op1 = N->getOperand(1); [nit] This should be `DL`:

[PATCH] D75160: [AArch64][SVE] Add SVE2 intrinsic for xar

andwar accepted this revision. andwar added a comment. This revision is now accepted and ready to land. LGTM, cheers for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75160/new/ https://reviews.llvm.org/D75160

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

andwar added a comment. Cheers for working on this @kmclaughlin! Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:2035 + +def int_aarch64_sve_bdep_x : AdvSIMD_2VectorArg_Intrinsic; +def int_aarch64_sve_bext_x : AdvSIMD_2VectorArg_Intrinsic; What does `_x`

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

andwar added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9998 + // GLD1* instructions perform an implicit zero-extend, which makes them // perfect candidates for combining. Could you replace `GLD1*` with `Load`? I believe

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

Andrzej added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:186 +def SVLDFF1 : MInst<"svldff1[_{2}]", "dPc", "csilUcUsUiUlhfd", [IsLoad], MemEltTyDefault, "aarch64_sve_ldff1">; +def SVLDFF1SB : MInst<"svldff1sb_{d}", "dPS", "silUsUiUl",

[PATCH] D77735: [SveEmitter] Implement builtins for gathers/scatters

andwar added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7458 +llvm_unreachable("Invalid SVETypeFlag!"); + + case SVETypeFlags::EltTyInt8: SjoerdMeijer wrote: > nit: no need for the newlines here and also below? IMHO this improves

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

andwar added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:240 + // Returns the SVETypeFlags for the given memory element type. + uint64_t encodeMemoryElementType(unsigned MT) { +return encodeFlag(MT, "MemEltTypeMask"); Shouldn't `MT` be

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

andwar added a comment. Btw, could you also add some negative tests? (e.g. out-of-range immediate) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76929/new/ https://reviews.llvm.org/D76929 ___

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

andwar added a comment. Cheers for working on this @kmclaughlin ! Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1407 case AArch64ISD::PTRUE: return "AArch64ISD::PTRUE"; + case AArch64ISD::LD1RQ: return "AArch64ISD::LD1RQ"; case

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

andwar added a comment. LGTM This patch now implements a bit more than the original commit message would suggest. Could you please update? Thanks for working on this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76617/new/ https://reviews.llvm.org/D76617

[PATCH] D77735: [SveEmitter] Implement builtins for gathers/scatters

andwar added a comment. The buildbot failures are unrelated to this patch, and locally `make check-all` worked fine. I'll submit this patch as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77735/new/ https://reviews.llvm.org/D77735

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added a comment. The suggested flag, `-fortran-fe`, feels quite powerful and I wonder whether it's required this early into the development of the Flang driver? IIUC, this flag would be used to workaround the fact that currently `flang` is a bash script and hence can't be used when

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added a comment. @richard.barton.arm @CarolineConcatto thank you both for clarification! @CarolineConcatto , if you prefer to go ahead with this approach - could you please address all the outstanding comments? I've left a few comments that I'd like addressed first, but nothing

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:71 const auto& D = C.getDriver(); - const std::string = D.getFFCGenericFortranName(); + const std::string = D.getGenericFortranFE(); const char *FortranName; [nit]

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added a comment. @CarolineConcatto thank you for the updates! - It looks like you accidentally pushed two commits in one patch :) Could you please squash and resubmit? (this should clean-up the diff). Ta! - Perhaps `CFCGenericFlangName` instead of `GenericFortranFE`? This would

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

andwar added a comment. > Have you considered adding an interface for the new PM? Please ignore that comment ^^^. I incorrectly assumed that the backend has also been ported to the new PM, but that's not the case. In particular, `llc` will only use the legacy PM anyway:

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

andwar added a comment. Thanks for the updates @kmclaughlin ! Would you mind adding a comment to clearly mark the negative tests? E.g. for `@reinterpret_reductions_1`? Maybe also a comment `why` a particular case is not optimised? You've already done that for some tests, but not all of them.

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

andwar added a comment. Cheers for the fix @sdesmalen ! Comment at: clang/include/clang/Basic/TargetBuiltins.h:187 -SVETypeFlags(uint64_t F) : Flags(F) {} -SVETypeFlags(EltType ET, bool IsUnsigned) : Flags(ET) {} +SVETypeFlags(uint64_t F) : Flags(F),

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

andwar added a comment. Cheers for working on this @kmclaughlin ! Have you considered adding an interface for the new PM? You could check this for reference: https://reviews.llvm.org/rGd6de5f12d485a85504bc99d384a85634574a27e2 (also implements a FunctionPass). Comment at:

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 289111. awarzynski marked an inline comment as done. awarzynski added a comment. Update README.md with instructions for building `flang-new` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 291068. awarzynski marked 2 inline comments as done. awarzynski added a comment. Address final comments I also took the liberty and made the following changes in CMake scripts: - replaced add_library wiht add_flang_library - replaced add_executable with

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. In D86089#2256139 , @richard.barton.arm wrote: > Another random thought that just came to me: what does the new driver do when > you invoke it with no input files or options? I could imagine a few sensible > outcomes (error:

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 290337. awarzynski marked 2 inline comments as done. awarzynski added a comment. - Adddressed comments from @richard.barton.arm - Added FC1Option to ClangFlags (and made other related changes) - Added missing code to check return codes from subcommands

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. We forgot to update the signature and definition of `OptTable::findByPrefix`: https://github.com/llvm/llvm-project/blob/257b29715bb27b7d9f6c3c40c481b6a4af0b37e5/llvm/include/llvm/Option/OptTable.h#L154-L155. That's required after updating the definition of

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 290435. awarzynski added a comment. Add missing update in lit.cfg.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089 Files: clang/include/clang/Driver/Driver.h

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski updated this revision to Diff 298407. awarzynski added a comment. Address PR comments, clang-format, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 Files:

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski commandeered this revision. awarzynski edited reviewers, added: CarolineConcatto; removed: awarzynski. awarzynski added a comment. Thank you for reviewing @SouraVX! I'm just about to submit an updated patch with the requested changes. @CarolineConcatto has recently moved to a

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. I've added more reviewers for the Clang side of this patch. I choose people who most recently changed the functions/files that this patch modifies. Any input much appreciated! For more context regarding Clang changes:

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d51d37e0628: [flang] Introduce DiagnosticConsumer classes in libflangFrontend (authored by awarzynski). Repository: rG LLVM Github Monorepo

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. LGTM, thanks for working on this! As this is a fairly large change, could you wait for one more reviewer to approve? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. @reviewers A note regarding the changes in Clang. This patch introduces a Flang option (`-test-io`), that should not be available/visible in Clang. AFAIK, there's no precedent of that, hence `options::NoClangOption` is introduced. This is discussed in more detail

[PATCH] D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`

awarzynski commandeered this revision. awarzynski edited reviewers, added: CarolineConcatto; removed: awarzynski. awarzynski added a comment. Since @CarolineConcatto has recently moved to a different project, I am assigning this to myself and will be responding to the future review comments.

[PATCH] D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`

awarzynski updated this revision to Diff 298635. awarzynski added a comment. Rebase + refector the unit test This is re-based on top of the latest version of D87989 . The unit test is update for consistency with D87989 .

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski updated this revision to Diff 299033. awarzynski added a comment. Simplify the API for creating output files The originally implemented API was overly complicated and not yet required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 299092. awarzynski marked 3 inline comments as done. awarzynski added a comment. Address PR comments, make clearer separation between option types, simplify/fix tests Based on the feedback, I've made a clearer separation between the parser and the

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 299100. awarzynski added a comment. Apply fix to unit test that got lost in the previous patch, simplify C input file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88381/new/

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInstance.h:85 + /// Return parsing to be used by Actions. + Fortran::parser::Parsing () const { return *parsing_; } + sameeranjoshi wrote: > If I am correct this seems to be an

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

andwar updated this revision to Diff 288018. andwar added a comment. - Canonicalised FLANG_BUILD_NEW_DRIVER in flang/test/CMakeLists.txt and updated the LIT config scripts accordingly - Implemented proper handling of `-emit-obj` (via diagnostics) in CompilerInvocation.cpp - Removed members from

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. @CarolineConcatto - thank you for working on this! @all, thank you for your reviews, this is much appreciated! While Carol is away, I'll try my best to address all the outstanding comments. I will also update the patch accordingly. I've identified a few small issues

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. @andwar is my Phabricator alter-ego. Apologies for the confusion - I had my Arcanist misconfigured. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski commandeered this revision. awarzynski added a reviewer: CarolineConcatto. awarzynski added a comment. @sameeranjoshi Thanks for testing out-of-tree builds. We were missing some minor changes in CMake. I have now uploaded these. Out-of-tree will require `-DCLANG_DIR` when configuring

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 288424. awarzynski added a comment. Added support for out-of-tree builds. It requires -DCLANG_DIR=/lib/cmake/clang when configuring CMake. That's on top of LLVM_DIR and MLIR_DIR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87989: [Flang][Driver] Add InputOutputTest frontend action with new -test-IO flag

awarzynski added a comment. @CarolineConcatto , thank you for this patch! It implements some really important functionality and IMO the overall structure is solid. I've left quite a few comments, but mostly nits and suggestions for more detailed comments. There's a few, but it's a relatively

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 293780. awarzynski marked 17 inline comments as done. awarzynski added a comment. Move code from Fortran to Fortran::frontend namespace, address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. Thank you for reviewing! I think that I've addressed all your comments.. Please see the updated patch. Comment at: clang/include/clang/Driver/Options.td:874 +defm color_diagnostics : OptInFFlag<"color-diagnostics", "Enable", "Disable", " colors in

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. In D87774#2287927 , @sameeranjoshi wrote: > Thanks for working on it. > Few comments inline: > > 1. For an out-of-tree build, I see `check-flang` target failing with > > /unittests/Frontend/CompilerInstanceTest.cpp:17:10:

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. @sameeranjoshi Regarding ``, please see https://reviews.llvm.org/D88219. Sadly we missed that when adding that test, sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774

[PATCH] D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

awarzynski created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. awarzynski requested review of this revision. As per the documentation, the 2nd argument in printDiagnosticMessage should be a bool that specifies whether the underlying message is a

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. @CarolineConcatto thank you again for working on this! The structure is good, but IMHO this patch could be polished a bit more. Overall: - could you make sure that this patch does not change the output from `clang -help`? - doxygen comments are consistent -

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski marked 4 inline comments as done. awarzynski added a comment. In D87774#2293283 , @sameeranjoshi wrote: > Do you know if there are any bots configured to handle out-of-tree changes? > That might be helpful to avoid configuration differences

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 294740. awarzynski marked an inline comment as done. awarzynski added a comment. Address the remaining PR comments, fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 294023. awarzynski added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 Files: clang/include/clang/Driver/Options.td

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski created this revision. Herald added subscribers: cfe-commits, dang, mgorny. Herald added a reviewer: DavidTruby. Herald added a reviewer: sscalpone. Herald added a project: clang. awarzynski requested review of this revision. Currently Flang uses TextDiagnostic, TextDiagnosticPrinter &

[PATCH] D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

awarzynski added a comment. Thanks for reviewing @sanwou01 ! No new comments, so I'll submit as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87816/new/ https://reviews.llvm.org/D87816 ___

[PATCH] D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

This revision was automatically updated to reflect the committed changes. Closed by commit rG4eae6fc95f95: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski created this revision. Herald added subscribers: cfe-commits, dexonsmith, dang. Herald added a project: clang. awarzynski requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. As discussed in [1], ClangFlags::DriverOption is

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 301066. awarzynski added a comment. Rebase on top of master + rename accessor method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88381/new/ https://reviews.llvm.org/D88381 Files:

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski updated this revision to Diff 301414. awarzynski added a comment. Remove the diagnostic - Deleted the `err_drv_invalid_Xarch_argument_unsupported` diagnostic - Removed `const` from () - otherwise I couldn't use `getCustomDiagID` (which is a non-const member function).

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c5906cffd04: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O (authored by CarolineConcatto, committed by awarzynski).

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. Thank you all for your input! Before merging I took the liberty to rename `NoClangOption` as `FlangOnlyOption`. The new name reflects better what the flag is introduced for. Also, based on responses to [1], it is unlikely that it will be used beyond flang-only

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski updated this revision to Diff 315765. awarzynski added a comment. Implement SUGGESTION 1 I haven't updated the patch description yet - I'd rather keep it as is while the actual direction for this patch is being discussed. Also, I regenerated ClangCommandLineReference.rst and

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski updated this revision to Diff 316074. awarzynski added a comment. Use `DocBrief`, as suggested by @richard.barton.arm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94169/new/ https://reviews.llvm.org/D94169 Files:

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5cdb6c56edf: [flang][driver] Add support for `-c` and `-emit-obj` (authored by awarzynski). Changed prior to commit:

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski added a comment. In D94169#2484968 , @andreil99 wrote: > I'm fine with having this text in the ClangCommandLineReference.rst only, and > removing it from `clang -help`. > > However, reverting the patch would not do, as

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski created this revision. Herald added subscribers: dang, mgorny. Herald added a reviewer: sscalpone. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92854

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

awarzynski created this revision. Herald added subscribers: usaxena95, kadircet. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This is just a small change in the Flang tool within libclangDriver. Currently it

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski updated this revision to Diff 312457. awarzynski added a comment. Address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 Files: clang/include/clang/Driver/Options.td

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski marked an inline comment as done. awarzynski added a comment. @clementval & @SouraVX - thank you for your comments! I will upload an updated version shortly. Comment at: clang/include/clang/Driver/Options.td:4329 HelpText<"Generate machine code, but discard

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 312400. awarzynski added a comment. Rebased on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D92854 Files: clang/include/clang/Driver/Options.td

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski added a comment. @dang , I would appreciate if you could take a look at the diff in Options.td - you introduced the most recent changes there: https://reviews.llvm.org/D82574. I got a bit confused with the nested `let` statements there. I couldn't find a better way of marking

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a frontend action for emitting object files. While Flang does

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

awarzynski added a comment. @FarisRehman, thank you for working on this! This looks really good and I think that it's almost ready. I did leave a few comments, but most are a matter of style and should be easy to address. Comment at:

[PATCH] D93453: [flang][driver] Add support for `-I`

awarzynski added a comment. Hi @FarisRehman ! Thank you for working on this! Could you add tests? Comment at: clang/lib/Driver/ToolChains/Flang.cpp:75 + Args.AddAllArgs(CmdArgs, options::OPT_I); + This would ideally go to a dedicated method for parsing

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 312547. awarzynski added a comment. Tidy-up include paths This was pointed out by @CarolineConcatto offline, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d246cb19db9: [flang][driver] Add support for `-fsyntax-only` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

awarzynski added a comment. In D93027#2445718 , @sameeranjoshi wrote: > Thanks for extracting it from D92854 . > I think the tests in D92854 were failing > for the same reason. > LGTM.

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 310952. awarzynski added a comment. Update according to PR comments - extracted the `-triple` related part into https://reviews.llvm.org/D93027 - made sure that `flang-new` and `flang-new -fc1` return error when semantic checks fail - fixed typos

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG764690b8a883: [clang] Remove `-triple` from the invocations of `flang-new -fc1` (authored by awarzynski). Repository: rG LLVM Github Monorepo

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski marked 4 inline comments as done. awarzynski added a comment. Thank you for your reviews! I'll submit an updated patch shortly. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:43-44 } else if (isa(JA) || isa(JA)) { -CmdArgs.push_back("-triple"); -

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 311231. awarzynski added a comment. Fine-tune the output for consistency with `flang`/`f18` This is just a minor change to make sure that: - `flang-new -fc1 -fsyntax-only`, and - `f18 -fparse-only` are as similar as possible. Repository: rG LLVM

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 311925. awarzynski added a comment. Address comment from @CarolineConcatto + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D92854 Files:

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:87 + defaultKinds, features, ci.allCookedSources()}; + semanticsContext.set_moduleDirectory("."s); + Fortran::semantics::Semantics semantics{ CarolineConcatto wrote: >

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

awarzynski added a comment. @FarisRehman , thank you for updating this! I have two high-level comments: 1. In your summary: > Change the way the driver handles end-of-line characters in macro definitions. That's a a bit misleading - which driver do you mean? You're not changing the behavior

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

awarzynski added a comment. Hi All, I've just noticed this patch and realised that it takes `DiagnosticBuilder` in the direction tangential to what we proposed in [1]. I've just restarted our efforts with regard to refactoring these APIs and feel that it would be good to coordinate any future

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

awarzynski added a comment. Hi @rjmccall , thank you for your quick reply! > It sounds like what you want is a diagnostic library that's almost completely > abstracted over the kinds of entities that can be stored in a diagnostic, > including the definition of a source location. No :) We

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5699b8ff1b6: [clang][driver] Rename DriverOption as NoXarchOption (NFC) (authored by awarzynski). Changed prior to commit:

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

awarzynski added a comment. In D84362#2365153 , @rjmccall wrote: > I may not have been clear. I'm not saying SourceLocation is a meaningful > concept in the driver. Likewise, I should be more careful with respect to how I refer to `SourceLocation` (a

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski added a comment. In D88381#2357123 , @sameeranjoshi wrote: > I would wait for a couple of more days for someone to review from community > may be from Nvidia's side if someone would verify the initial design. As there were no new reviews, I

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd28de0d7f257: [Flang][Driver] Add PrintPreprocessedInput FrontendAction (`flang-new -E`) (authored by CarolineConcatto, committed by awarzynski).

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

awarzynski added a comment. Hi @oneraynyday ! This looks very interesting - thanks for uploading! I've only quickly skimmed through. Two high level points: - Have you considered sending an RFC to cfe-dev regarding this tool? I think that it would be a great way of attracting peoples

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski added a comment. Thank you all for you comments! Please find my replies below. I've picked 4 main points raised here. 1 - In D89799#2342677 , @rnk wrote: > This seems like pretty corner case functionality. Do we really need this >

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89799/new/ https://reviews.llvm.org/D89799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include "flang/Frontend/FrontendOptions.h" +#include "flang/Parser/parsing.h" #include "clang/Basic/Diagnostic.h" sameeranjoshi wrote: > awarzynski wrote: > >

  1   2   3   4   5   6   7   >