[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 177972. axzhang added a comment. Per the suggestions of reviewers, change the check so that it uses modernize-make-smart-pointer instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files:

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang added a comment. In D55044#1329604 , @hokein wrote: > In fact, the existing `modernize-make-unique` can be configured to support > `absl::make_unique`, you'd just need to configure the check option > `MakeSmartPtrFunction` to `absl::make_unique`

[PATCH] D55044: [cfe-dev] clang-tidy check for Abseil make_unique

axzhang created this revision. axzhang added reviewers: klimek, EricWF. axzhang added a project: clang-tools-extra. Herald added a subscriber: mgorny. Add a new check for https://abseil.io/tips/126, to detect uses of constructing a std::unique_ptr with a call to new, and recommend substituting

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang marked an inline comment as done. axzhang added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:94 equalsBoundNode(PointerType), CanCallCtor)

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang marked 2 inline comments as done and an inline comment as not done. axzhang added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:94 equalsBoundNode(PointerType),

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 192394. axzhang added a comment. Add documentation about the added option for `modernize-make-unique`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 190676. axzhang added a comment. Updated diff with full context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/modernize/MakeSmartPtrCheck.cpp

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 190559. axzhang added a comment. Apologies for the extended hiatus. I have changed the implementation to an alias to modernize-make-unique, and have added an extra option to modernize-make-unique that ignores C++11 features such as list initializations, to

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 190775. axzhang added a comment. Make fixes to the `UseLegacyFunction` option, renaming to `IgnoreListInit`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang added a comment. If no more changes need to be made, is this okay to be merged in? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 194435. axzhang marked an inline comment as not done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/modernize/MakeSmartPtrCheck.cpp

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang marked an inline comment as done. axzhang added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {}

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang marked an inline comment as done. axzhang added a comment. I'm having some issues with the AbseilTidyModule options. I am storing IgnoreListInit as true for the abseil-make-unique check, but when I run the check it shows IgnoreListInit as being false. Any ideas why this is happening?

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang added a comment. Pinging for visibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang marked 3 inline comments as done. axzhang added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {}

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 195791. axzhang added a comment. Simplify tests and fix issues with Options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/abseil/AbseilTidyModule.cpp