[PATCH] D27162: Support relaxed constexpr on chrono::duration operations

AntonBikineev added a subscriber: cfe-commits. AntonBikineev updated this revision to Diff 79491. https://reviews.llvm.org/D27162 Files: include/chrono test/std/utilities/time/time.duration/time.duration.arithmetic/op_++.pass.cpp

[PATCH] D27199: [libcxx] Make std::ignore constexpr

AntonBikineev added a comment. In https://reviews.llvm.org/D27199#619278, @EricWF wrote: > @AntonBikineev Do you need somebody to commit this for you? oh, yeah, it would be great. I don't have commit privileges. https://reviews.llvm.org/D27199

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev added a comment. In https://reviews.llvm.org/D26830#619340, @EricWF wrote: > Please ping this once the Clang changes have been accepted. I'm just waiting > on those to give this the final OK. I don't have commit privileges to Clang either, so that patch is stuck. Could you

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev added a comment. @rsmith Richard, any plans to merge this or is there anything left? https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27199: [libcxx] Make std::ignore constexpr

AntonBikineev created this revision. AntonBikineev added reviewers: mclow.lists, EricWF. AntonBikineev added a subscriber: cfe-commits. This addresses DR 2773 . // 20.5.2.4, tuple creation functions: constexpr unspecified ignore; }

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev added a comment. In https://reviews.llvm.org/D26830#711870, @EricWF wrote: > @AntonBikineev when will you be able to make he requested changes? I would > like to land this ASAP. Eric, have you looked at commit 7d32d2f5a1f39d4cae9469645faa74b647698001? This functionality has

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev added a comment. In https://reviews.llvm.org/D26830#711870, @EricWF wrote: > @AntonBikineev when will you be able to make he requested changes? I would > like to land this ASAP. Will do that today https://reviews.llvm.org/D26830

[PATCH] D35661: [clang] Implement P0704: "Fixing const-qualified pointers to members"

AntonBikineev created this revision. https://reviews.llvm.org/D35661 Files: lib/Sema/SemaExprCXX.cpp test/CXX/expr/expr.mptr.oper/p7-1z.cpp Index: test/CXX/expr/expr.mptr.oper/p7-1z.cpp === ---

[PATCH] D35661: [clang] Implement P0704: "Fixing const-qualified pointers to members"

AntonBikineev added a comment. ping.. https://reviews.llvm.org/D35661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for copy/move constructor arguments

AntonBikineev created this revision. AntonBikineev added reviewers: rsmith, aaron.ballman. AntonBikineev added a project: clang. The patch addresses this bug . According to the Standard (taken from the bug description): [class.ctor] paragraph 14:

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for copy/move constructor arguments

AntonBikineev updated this revision to Diff 145332. AntonBikineev added a comment. Herald added subscribers: aheejin, sbc100. I've moved setting noalias-attribute down to IR-function creation. This is needed in the context of emitting a constructor call when the definition of the constructor is

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for copy/move constructor arguments

AntonBikineev added a comment. @efriedma copy and move constructors are particular cases where the value of a constructed object may be accessed through a glvalue not obtained from 'this' pointer (but from the first arg of a ctor). Repository: rC Clang https://reviews.llvm.org/D46441

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

AntonBikineev added a comment. @rsmith Thanks for pointing out this example. Now I see that I misunderstood the wording. Another question is that in the provided example you say that the following line template A::B x; // ok! should suppress the error of accessing private A::B. But in

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

AntonBikineev created this revision. AntonBikineev added reviewers: rsmith, lebedev.ri. This is an attempt to implement P0692 Please note a couple of things: 1. given that clang already suppresses access checks on explicit

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter

AntonBikineev added a comment. @rsmith do you have any comments or suggestions? https://reviews.llvm.org/D46441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter

AntonBikineev added a comment. @rsmith, thanks. Le'ts see if there is a need for the command-line option down the road. Repository: rL LLVM https://reviews.llvm.org/D46441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for copy/move constructor arguments

AntonBikineev marked an inline comment as done. AntonBikineev added a comment. I've submitted an issue to the Core about the case. Presumably, it will be included in the next revision (mailing deadline of which is tomorrow). Comment at: lib/CodeGen/CGCall.cpp:1893 + +

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev added a comment. Pinging for review.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65589/new/ https://reviews.llvm.org/D65589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368152: [clang] Fix mismatched args constructing AddressSpaceAttr. (authored by AntonBikineev, committed by ). Herald

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev updated this revision to Diff 212882. AntonBikineev added a comment. Roman, -ast-dump shows the correct result, because the correct address space is encoded in qualifiers and is passed to Context.getAddrSpaceQualType(...) later in this function. This is why this bug is not

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65589/new/ https://reviews.llvm.org/D65589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev created this revision. AntonBikineev added reviewers: rsmith, klimek. AntonBikineev added a project: clang. Interestingly enough, but this wasn't caught in tests. I wonder if it's possible to write a test case for it. Repository: rC Clang https://reviews.llvm.org/D65589

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211261. AntonBikineev added a comment. Thanks for the note, updated the diff with autogenerated LibASTMatcherReference.html. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev added a comment. Manuel, would you mind taking another look at the change please? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 ___ cfe-commits mailing list

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2672 + BaseName, 1) { + assert(!BaseName.empty()); + return isDirectlyDerivedFrom(hasName(BaseName)) aaron.ballman wrote: > I don't think this

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211508. AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Thanks for the comments! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Files:

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211513. AntonBikineev marked an inline comment as not done. AntonBikineev added a comment. Missed that, thanks for the point! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367010: [clang] Add isDirectlyDerivedFrom AST matcher. (authored by AntonBikineev, committed by ). Herald added a

[PATCH] D65279: [clang] Fail for empty names in is*DerivedFrom matchers.

AntonBikineev created this revision. AntonBikineev added a reviewer: aaron.ballman. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D65279 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp Index:

[PATCH] D65279: [clang] Fail for empty names in is*DerivedFrom matchers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367022: [clang] Fail for empty names in is*DerivedFrom matchers. (authored by AntonBikineev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev created this revision. AntonBikineev added a reviewer: rsmith. AntonBikineev added a project: clang. This patch adds isDirectlyDerivedFrom AST-matcher which is similar to isDerivedFrom but only matches against direct base classes. Repository: rC Clang

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211148. AntonBikineev added a comment. Manuel, I left some cases which deviated from the isDerivedFrom matcher. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Files:

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. > There is no difference in perf for GCC. Yes, but that's because gcc still optimizes the call to noinlined function. In the common scenario which this check addresses (destructor defaulted in .cpp file) gcc is not able to optimize the call. CHANGES SINCE LAST

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. > Did you see some significant perf improvements for Chromium? I don't see major improvements in browser benchmarks like Speedometer, but in the Blink garbage collector, which queues destructors to be executed later, this change proved to reduce the number of

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. BTW, this very contrived benchmark shows 5x: http://quick-bench.com/sczBi_lVndKut9jOj4UofC0HYew CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev marked an inline comment as done. AntonBikineev added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:45 + isDefaulted(), + unless(anyOf(isFirstDecl(), isVirtual(), +

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. In D69435#1729580 , @gribozavr2 wrote: > Alright then. (Although I don't know whether the redeclaration chain always > models that wording in the standard, and what that wording means when we > don't have a linear ordering

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. Roman, could you please take another look at it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev updated this revision to Diff 226773. AntonBikineev added a comment. Thanks for the suggestions! Added isTriviallyDestructible matcher to utils/Matchers.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 Files:

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. Does anybody have suggestions on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev created this revision. AntonBikineev added a reviewer: klimek. AntonBikineev added projects: clang, clang-tools-extra. Herald added subscribers: mgehre, xazax.hun, mgorny. Checks for types which can be made trivially-destructible by removing out-of-line defaulted destructor

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev updated this revision to Diff 226475. AntonBikineev marked 2 inline comments as done. AntonBikineev added a comment. Thanks for the suggestions! Addressed some of them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 Files:

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev marked 9 inline comments as done. AntonBikineev added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:22 + +bool CheckPotentiallyTriviallyDestructible(const CXXDestructorDecl *Dtor) { + if (Dtor->isFirstDecl()

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

This revision was automatically updated to reflect the committed changes. Closed by commit rGd36a03331026: [clang-tidy] New checker performance-trivially-destructible-check (authored by AntonBikineev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. Roman, thanks for reviewing and the ideas. > Can you be more specific what the question is? I meant to ping if anybody has more comments on this patch. Otherwise I would go ahead and submit it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/

[PATCH] D77477: tsan: don't instrument __attribute__((naked)) functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e1ccec8d529: tsan: dont instrument __attribute__((naked)) functions (authored by AntonBikineev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77477/new/

[PATCH] D77477: tsan: don't instrument __attribute__((naked)) functions

AntonBikineev added a comment. Thanks for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77477/new/ https://reviews.llvm.org/D77477 ___ cfe-commits mailing list

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev marked 7 inline comments as done. AntonBikineev added a comment. Thanks Richard for taking a look! Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:190 InGroup, DefaultIgnore; +def ext_cxx2b_size_t_suffix : Extension< + "'size_t' suffix for

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 334037. AntonBikineev marked 2 inline comments as done. AntonBikineev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files:

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev marked 3 inline comments as done. AntonBikineev added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:640 isFloat16 = true; continue; } rsmith wrote: > Looks like this might fix [[

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 334102. AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Address comments. Also: - always issue a new diagnostic if size_t/ssize_t is out of range; - prohibit numbers with 'z' suffix and non-10-radix to be interpreted as

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 333811. AntonBikineev added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev marked an inline comment as done. AntonBikineev added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:593-594 + // C++2b features. + if (LangOpts.CPlusPlus2b) +Builder.defineMacro("__cpp_size_t_suffix", "202011L"); if (LangOpts.Char8)

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 334422. AntonBikineev added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev closed this revision. AntonBikineev added a comment. Aaron, Richard, thanks a lot for reviewing this! Sorry, forgot to add amend the commit with 'Differential revision', closing this manually.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:593-594 + // C++2b features. + if (LangOpts.CPlusPlus2b) +Builder.defineMacro("__cpp_size_t_suffix", "202011L"); if (LangOpts.Char8) Quuxplusone wrote: >

[PATCH] D99808: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

AntonBikineev created this revision. AntonBikineev added reviewers: aaron.ballman, thakis. AntonBikineev requested review of this revision. Herald added a project: clang. This change splits '-Wtautological-unsigned-zero-compare' by reporting char-expressions-interpreted-as-unsigned under a

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 333681. AntonBikineev added a comment. Fix failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files:

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev created this revision. AntonBikineev added a reviewer: rsmith. AntonBikineev requested review of this revision. Herald added a project: clang. This adds support for C++2b z/uz suffixes for size_t literals (P0330). Repository: rG LLVM Github Monorepo

[PATCH] D99396: [clang] Support C++20's using ENUM_ID::IDENTIFIER

AntonBikineev created this revision. AntonBikineev added a reviewer: rsmith. AntonBikineev added a project: clang. AntonBikineev requested review of this revision. This change merely allows nested-name-specifiers for enums in using declarations but doesn't add support for the

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev marked an inline comment as done. AntonBikineev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:198-200 +def err_size_t_literal_too_large: Error< + "%select{signed |}0'size_t' literal is out of range of possible " +

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 334263. AntonBikineev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files:

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 334288. AntonBikineev marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 333972. AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files:

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev marked 9 inline comments as done. AntonBikineev added a comment. Thanks Aaron for taking a look! Addressed the comments. I also hope it's okay to test preprocessor in the same test (test/Lexer/size_t-literal.cpp). Comment at: clang/lib/Sema/SemaExpr.cpp:3911 +

[PATCH] D97951: [Sema] Fix diagnostics for one-byte length modifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f8e299785e8: [Sema] Fix diagnostics for one-byte length modifier (authored by AntonBikineev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97951/new/

[PATCH] D97951: [Sema] Fix diagnostics for one-byte length modifier

AntonBikineev added a comment. Thanks Aaron for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97951/new/ https://reviews.llvm.org/D97951 ___ cfe-commits mailing list

[PATCH] D97951: [Sema] Fix diagnostics for one-byte length modifier

AntonBikineev created this revision. AntonBikineev added a reviewer: jordan_rose. AntonBikineev added a project: clang. AntonBikineev requested review of this revision. In case a char-literal of type int (C/ObjectiveC) corresponds to a format specifier with the %hh length modifier, don't treat

[PATCH] D99808: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

AntonBikineev added a comment. friendly ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99808/new/ https://reviews.llvm.org/D99808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99808: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

AntonBikineev updated this revision to Diff 336612. AntonBikineev added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99808/new/ https://reviews.llvm.org/D99808 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D99808: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG69545154cc28: [Sema] Move char-expression-as-unsigned 0 into a separate diagnostic (authored by AntonBikineev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev added a comment. > Do users have some other escape hatch to tell PGO "ignore what you think you > know about this branch" so that a user who *wants* PGO to lose has some > ability to do that other than "don't use PGO"? Sounds like we need another proposal for [[always_likely]] :)

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev added a comment. > No, it sounds like we need a proposal for > `[[likely_unless_the_optimizer_decides_otherwise]]` -- the `[[likely]]` > attribute was intended for always-likely optimization decisions. Well, whatever the default behavior is chosen. > I agree that we should be

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev created this revision. AntonBikineev added a reviewer: hans. Herald added a subscriber: wenlei. Herald added a project: All. AntonBikineev requested review of this revision. Herald added a project: clang. Generally, with PGO enabled the C++20 likelyhood attributes shall be dropped

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev marked 2 inline comments as done. AntonBikineev added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 ___ cfe-commits mailing

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev updated this revision to Diff 462250. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/Profile/Inputs/cxx-never-executed-branch.proftext

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev added a comment. In D134456#3809581 , @aaron.ballman wrote: > I'm on the fence about this... the attributes were added as optimization > hints, but for somewhat interesting use cases. The obvious one of "I think > this path is

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev added a comment. Anyone wants to take a look/stamp? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 ___ cfe-commits mailing list

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b85e765000d: [PGO] Consider parent context when weighing branches with likelyhood. (authored by AntonBikineev). Changed prior to commit: https://reviews.llvm.org/D134456?vs=462250=466313#toc

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Thanks everybody! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 ___