[PATCH] D109557: Adds a BreakBeforeClosingParen option

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. In D109557#3021312 , @MyDeveloperDay wrote: > FYI, this is a very aggressive change, I highly recommend you run

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

HazardyKnusperkeks added a comment. In D110432#3021391 , @MyDeveloperDay wrote: > I agree this looks better > > F19213646: image.png Full support for that. And for the whole change. Comment at:

[PATCH] D110392: [clang-format] Left/Right alignment fixer can cause false positive replacements when they don't actually change anything

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:95 + if (Err) +llvm::errs() << "Error removing no op replacements : " + << llvm::toString(std::move(Err)) << "\n"; The message may

[PATCH] D110359: [clang-format] ensure clang-format command-line argument sets up the default left/right qualifier ordering

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Just fix what clang-format tells you to. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110359/new/ https://reviews.llvm.org/D110359

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Let's give it a first shot. When it has landed maybe I find the time to look into the attributes. ;) Comment at:

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:449 +return false; + if (Tok->is(TT_TypenameMacro)) +return false; I think this is still right, because it is a type (according to the configuration).

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:57 + + std::string NewText = " " + Qualifier + " "; + NewText += Next->TokenText; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > Does not need to be

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added a comment. Really nice! No attributes in there, do you think it would be difficult to add them? We can definitely do that in another change to move this one forward. Comment at: clang/include/clang/Format/Format.h:1863-1864 + /// \warning + ///

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

HazardyKnusperkeks added a comment. In D109951#3007425 , @guitard0g wrote: > When looking at test case suggestions, I happened upon another problem that > occurs when handling preprocessor directives. The following code is properly > formatted

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19271 +TEST_F(FormatTest, ConstructorInitializersWithPreprocessorDirective) { + FormatStyle Style = getLLVMStyle(); From the name I would expect also to check

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added a comment. In D92257#3003281 , @byronhe wrote: > Hi guys，i found `SpacesInLineCommentPrefix` does not support other encoding > such as utf8 ， > I am curious why there is a `isAlphanumeric` limit in >

[PATCH] D109557: Adds a BreakBeforeClosingParen option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Looks good, but please wait for MyDeveloperDay’s opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D109557: Adds a BreakBeforeClosingParen option

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22301 + auto Style = getLLVMStyle(); + Style.BreakBeforeClosingParen = true; + Could you also add tests for `false`, even though they are spread over the other test

[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. In D109557#2998727 , @csmulhern wrote: > In D109557#2998213 , > @HazardyKnusperkeks wrote: > >> With context he meant the diff context. >>

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

HazardyKnusperkeks added a comment. If there are no new tests, what went wrong before? Said invalid code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109752/new/ https://reviews.llvm.org/D109752 ___

[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. You state in the documentation that it is also for angle brackets and more, but there are no test cases for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. In D109557#2997899 , @csmulhern wrote: > I've added more information to my original message. Please let me know if > further context is desired. With context he meant the diff context.

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. From my point we can try that one, if there are problems we have plenty of time to revert it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks added a comment. In D108765#2972159 , @FederAndInk wrote: > And again, I don't really understand if we are allowed or not to pull in a > dependency such as pluralizer or inflect, this would be another idea My Python knowledge is

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks added inline comments. Comment at: clang/docs/tools/dump_format_style.py:23 + plurals = { +'IncludeCategory': 'IncludeCategories' + } MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > FederAndInk wrote: > > > HazardyKnusperkeks

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks added inline comments. Comment at: clang/docs/tools/dump_format_style.py:23 + plurals = { +'IncludeCategory': 'IncludeCategories' + } FederAndInk wrote: > HazardyKnusperkeks wrote: > > Could you not just check if there is a y at the end

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good and I agree with the choices. Comment at: clang/docs/tools/dump_format_style.py:23 + plurals = { +'IncludeCategory':

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. As the one who wrote that: 1. Yes that part is not auto generated, because it is not in the `format.h`. 2. I'm more in favor of removing the `std::` from the documentation. 3. It is for the YAML

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18472 + FormatStyle::PCIS_Never); + Style.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_LogicalBlock;

[PATCH] D107961: [clang-format] Distinguish K C function definition and attribute

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:17 #include "FormatToken.h" -#include "clang/Basic/TokenKinds.h" #include "llvm/ADT/STLExtras.h" owenpan wrote: > HazardyKnusperkeks wrote: > > Why is this not

[PATCH] D107961: [clang-format] Distinguish K C function definition and attribute

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:17 #include "FormatToken.h" -#include "clang/Basic/TokenKinds.h" #include "llvm/ADT/STLExtras.h" Why is this not needed anymore? Repository: rG LLVM Github

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added a comment. In D69764#2938973 , @MyDeveloperDay wrote: > With the introduction of `CVQualifierOrder` the need for > `CVQualifierAlignment:` doesn't make so much sense > > CVQualifierAlignment: Left > CVQualifierOrder: [

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added a comment. First off, I think it should be configured in a different way, to prepare the path for also formatting static, inline, etc. If this is kept there should be tests on what happens if there is const or volatile more than once in the string list, and when there

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. In D106349#2914448 , @m1cha wrote: > I don't have commit access. How does that even work? The documentation is > very scarce about this but for security reasons I'd expect there to be a very > limited set of people

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. No one objects, you can push it. Or if you don't have commit access (and don't want to, or don't want to wait for it) we can push it, then please state name and email for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

HazardyKnusperkeks added a comment. It's picked: 0e3777bb0ad94ecd1429dc96409177cdccf39bdd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106773/new/

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. And format what clang-format says. Then it looks good to me. Comment at: clang/unittests/Format/FormatTest.cpp:6250 + verifyFormat("asm volatile(\"lng\",\n" + " : : val);", +

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

HazardyKnusperkeks added a comment. In D106773#2912732 , @curdeius wrote: > This bug fix should probably be cherry-picked into 13.x branch. WDYT? Yeah, I wrote already an email about it. Or can (and should) I push it myself? Repository: rG LLVM

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75f6a795ee0f: [clang-format] Fix aligning with linebreaks #2 (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Then I am sorry that I've missed that before. But you need to change your `bool` to an `enum` and also model the current behavior, so that there is no change

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2901304 , @baramin wrote: > This is true. > .clang-format: > > Language:Cpp > AlignConsecutiveAssignments: Consecutive > BinPackArguments: false > BinPackParameters: false > ColumnLimit:

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, baramin. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3800 + FormatStyle Style = getLLVMStyle(); + Style.BreakBeforeInlineASMColon = true; verifyFormat( I already gave my go in the past, but now I have to wonder, why

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2901304 , @baramin wrote: > This is true. > .clang-format: > > Language:Cpp > AlignConsecutiveAssignments: Consecutive > BinPackArguments: false > BinPackParameters: false > ColumnLimit:

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2900803 , @baramin wrote: > You are right. > > The problem is in > > FromLegacyTimestamp(monitorFrequencyUsec), > seconds(std::uint64_t(maxSampleAge)), maxKeepSamples)); > > line indentation. It is 6

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. In D106349#2900770 , @m1cha wrote: > In D106349#2897400 , > @HazardyKnusperkeks wrote: > >> Looks good, could you also add a note in the relasenotes.rst? > > Sure > > Can I do

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. Looks good, could you also add a note in the relasenotes.rst? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 ___ cfe-commits mailing list

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. In D106349#2893672 , @MyDeveloperDay wrote: > This feels like there is some overlap with D93938: [clang-format] Fixed > AfterEnum handling Yeah that may be, but it is stale for over

[PATCH] D106112: [clang-format] Break an unwrapped line at a K C parameter decl

HazardyKnusperkeks added a comment. In D106112#2883301 , @curdeius wrote: > Looks okay, but I was wondering if we don't want to guard all K > changes behind e.g. ```Standard: Cpp78``, so as not to possibly introduce > strange bugs in newer modes. > It

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

HazardyKnusperkeks added a comment. In D69764#2876916 , @MyDeveloperDay wrote: >> So yes, I'm in favour of landing this patch (though not exactly in the >> current form, I'd prefer more future-proof options for instance, not only >> handling const) > >

[PATCH] D105943: [clang-format++] Create a new variant of the clang-format tool to allow additional code mutating behaviour such as East/West Const Fixer

HazardyKnusperkeks added a comment. This could be a way, but I will also state here that I prefer adding it to plain `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105943/new/ https://reviews.llvm.org/D105943

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

HazardyKnusperkeks added a comment. I already said I would like that in `clang-format` and would directly add that to my config. I also think that there should be no problem in having that in `clang-format`, include sorting has a bigger chance of breaking code, yeah only with poorly designed

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

HazardyKnusperkeks added a comment. In D105099#2847328 , @MyDeveloperDay wrote: > Seem similar to D90232: [clang-format] Formatting constructor initializer > lists by putting them always on different lines (update to D14484) >

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. It's a strange language :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105087/new/ https://reviews.llvm.org/D105087

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

HazardyKnusperkeks added a comment. In D104044#2842726 , @darwin wrote: > And can someone commit it for me? I don't have the right to push it yet. Or > let me know how to apply? Thank you very much.

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

HazardyKnusperkeks added a comment. In D104900#2842540 , @darwin wrote: > Sorry I haven't had a chance to look at this bug before it has closed. But I > do have a question: > > I observed that this code are formatted incorrectly by the same config: > >

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Nice. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104900/new/ https://reviews.llvm.org/D104900

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

This revision was automatically updated to reflect the committed changes. Closed by commit rGa08fa8a50819: [Clang-Format] Add ReferenceAlignment directive (authored by Seraphime Kirkovski skirkov...@vmware.com, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

HazardyKnusperkeks added a comment. In D104774#2838287 , @MyDeveloperDay wrote: > @HazardyKnusperkek Its probably my "bad" I should said "LGTM but maybe wait > for the others to comment", but I'm fundamentally ok I think with the change. > (we'll just

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2520 + /// readability to have the signature indented two levels and to use + /// ``OuterScope``. The KJ style guide requires ``OuterScope`. + /// `KJ style guide Here

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

HazardyKnusperkeks added a comment. I have basically no idea about C#, thus not much to say. I think if the old tests pass and the new are as expected it is good. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:647 + "Function(Val, (Action)(() =>

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

HazardyKnusperkeks added a comment. That was fast. I personally like it better to give others a chance to look at. ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104774/new/ https://reviews.llvm.org/D104774

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

This revision was automatically updated to reflect the committed changes. Closed by commit rG64cf5eba06bd: [clang-format] Add new LambdaBodyIndentation option (authored by vlovich, committed by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D102706?vs=347152=353753#toc

[PATCH] D102730: [clang-format] Support custom If macros

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Seems to be okay for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

HazardyKnusperkeks added a reviewer: HazardyKnusperkeks. HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Nice trick! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. In D102706#2823087 , @vlovich wrote: > I don't think I have permissions. Happy to do it if I'm given permissions > (I'm assuming the instructions are the general LLVM ones). Otherwise: > > Name: Vitali Lovich >

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks added a comment. In D104096#2820206 , @skirkovski wrote: > Ping, > > I do not have commit access, can someone submit this as time permits ? Please state the name and email for the commit, I will commit it on the weekend.

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

HazardyKnusperkeks added a comment. Just asking: Would it be different if there is `auto`, `decltype(auto)`, `decltype(a+b)`, `typename` or `template` as trailing return type? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222

[PATCH] D104242: Removes an unused variable and alters a lit test to simplify and avoid a buildbot error

HazardyKnusperkeks added a comment. Could you split this into two diffs? Or are those two changes in any way related? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104242/new/ https://reviews.llvm.org/D104242

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG673c5ba58497: [clang-format] Adds a formatter for aligning arrays of structs (authored by feg208, committed by HazardyKnusperkeks). Repository:

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

HazardyKnusperkeks added a comment. >> In D104044#2812399 , @darwin wrote: >> >>> About the issue, let me explain it. It isn't bound to the google style or >>> LLVM style either, since both of them keep the first brace at the same line >>> of the

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for the work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks added a comment. Can you also add tests with the alignment of declarations? We already have such for pointers. Comment at: clang/include/clang/Format/Format.h:2706 + /// references). + ReferenceAlignmentStyle ReferenceAlignment; + Please

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

HazardyKnusperkeks added a comment. Going the full way, to fix the number of empty lines after/before/between elements would be real nice. But even nicer would be if you can state a range. But I think all those proposed options should not be added in one go. In D104044#2812399

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D99840#2718959 , @curdeius wrote: > LGTM. I also consider it a bug. LLVM should not be affected as it uses > `AllowShortEnumsOnASingleLine: true` whereas this problem

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. Then we can push it, do you need some one to do that? If yes please post name and email. Comment at: clang/unittests/Format/FormatTest.cpp:18475 +)", +Style); } I think the pre merge lint means this line. Please fix that

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. In D102706#2787550 , @HazardyKnusperkeks wrote: > LGTM, but please wait for more responses. No one objected, so I declare it ready to commit. Do you need some one to do it? If yes please post name and email for the

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Do you need some one to commit this? If yes please state name and email, some one will chime in to commit it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103678/new/ https://reviews.llvm.org/D103678

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D101868#2810452 , @feg208 wrote: > If I can get someone to submit this on my behalf I think we can call it a day. Please post the name and email for the commit. And if no

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

HazardyKnusperkeks added a comment. I think this would be a nice addition, and in the past I would have used it. I really like the option `Pointer`. If this will be pursued I will be happy to review it. Comment at: clang/unittests/Format/FormatTest.cpp:895 +

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

HazardyKnusperkeks added a comment. In D104044#2810909 , @darwin wrote: > Sorry, I may need some help here. It shows "Context not available.", how do I > correct it? There are multiple ways:

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Remains the issue with the alignment, I would like to know @MyDeveloperDay 's opinion on that. Should the values be right aligned, or left aligned? As far as I see all alignment in clang-format is left until now.

[PATCH] D103286: [clang-format] Add PPIndentWidth option

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f605b8d0bc1: [clang-format] Add PPIndentWidth option (authored by gergap, committed by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D103286?vs=348955=349569#toc Repository:

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e333cc82e42: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations (authored by gergap, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2674 + /// \endcode + signed PPIndentWidth; + I've replaced this with `int`, because `signed` results in an exception from `dump_format_style.py`. Repository: rG

[PATCH] D103589: [Format] Fix incorrect pointer detection

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Seems reasonable. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103589/new/ https://reviews.llvm.org/D103589 ___

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:737-740 +const auto End = Contexts.rbegin() + 2; +auto Last = Contexts.rbegin(); +unsigned Depth = 0; +for (; Last != End; Last = std::next(Last)) { I

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. I've added a few comments, and I would like to hear the opinion of others regarding the left or right alignment of the elements. Comment

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14921 + verifyFormat("unsigned int *a;\n" + "int*b;\n" "unsigned int Const *c;\n" MyDeveloperDay wrote: > I seem to

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added a comment. Will do on Thursday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 ___ cfe-commits mailing list

[PATCH] D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables

HazardyKnusperkeks added a comment. Under "Related Objects" you can add the commit, so that one can navigate to it. And as action there is "Close Revision", which marks this as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88084/new/

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added a comment. Forgot about that: Please add an entry in the ReleaseNotes.rst, I can imagine there are some people out there waiting for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good to me, I would just change the wording a bit. Could you please also add a entry in the ReleaseNotes.rst? Comment at:

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thank you very much. :) Do you have commit access, or do you need someone to land it? If the latter please state name and email for the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2336 + /// \endcode + unsigned PPIndentWidth; + I prefer alphabetical sorting, I know there are some entries which aren't sorted. Repository: rG LLVM Github Monorepo

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Love it! But this will result in unexpected (one might say breaking) behaviour, if someone set `IndentWidth` to a different value than his base style and

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added a comment. Please just check `continue`, I would like to make it a separate commit, because it seems unrelated to me. Otherwise this is good. Comment at: clang/lib/Format/WhitespaceManager.cpp:369 assert(Shift >= 0); +if (Shift == 0) +

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14884 Alignment.AlignConsecutiveDeclarations = FormatStyle::ACS_None; + Alignment.PointerAlignment = FormatStyle::PAS_Right; verifyFormat("float const a = 5;\n"

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added a comment. Looks quite solid for me. Comment at: clang/lib/Format/WhitespaceManager.cpp:265 static void -AlignTokenSequence(unsigned Start, unsigned End, unsigned Column, F &, +AlignTokenSequence(const FormatStyle , unsigned Start, unsigned End, +

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. LGTM, but please wait for more responses. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102706/new/ https://reviews.llvm.org/D102706

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16478 + "{56, /* a comment */ 23, \"hello\" },\n" + "{-1, 93463, \"world\" },\n" + "{ 7, 5,\"!!\"

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:1839 +/// \endcode +BILS_AfterComma }; Maybe add a comma, so that the next addition will not need to modify this line? Repository: rG LLVM Github Monorepo

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.cpp:86 + (SplitMax > 0 && SplitMax < ColumnWidth) ? SplitMax : ColumnWidth; + ColWidth += (is(tok::comment)) ? 1 : 0; + const auto *NextColEntry = Next; Personal style,

[PATCH] D95168: [clang-format] Add InsertBraces option

HazardyKnusperkeks added a comment. Although verifyFormat is nice, I would add some EXPECT_EQ to show that the braces are really inserted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168

<    4   5   6   7   8   9   10   11   >