bruno added a comment.
Ping!
https://reviews.llvm.org/D23905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
https://reviews.llvm.org/D23852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Nice, LGTM
https://reviews.llvm.org/D24042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
bruno added a subscriber: bruno.
bruno added a comment.
Regardless of the way we decide to go with this, it would be nice if a driver
level warning is used to tell users about any non-obvious assumed behavior
when these flags are used together.
https://reviews.llvm.org/D24048
_
Author: bruno
Date: Tue Aug 30 16:25:42 2016
New Revision: 280159
URL: http://llvm.org/viewvc/llvm-project?rev=280159&view=rev
Log:
[Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.
This adds support for modules that require (no-)gnu-inline-asm
environment, such as the comp
bruno closed this revision.
bruno added a comment.
Thanks Richard. r280159
https://reviews.llvm.org/D23905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a subscriber: bruno.
bruno added a comment.
Hi Lei,
Thanks for the doc improvement!
Comment at: docs/CommandGuide/clang.rst:114
@@ -110,1 +113,3 @@
+ compiler-rt.
+
.. option:: -ansi
It might be worth mentioning what's the default behaviour in case
bruno added a comment.
Hi Chris,
Thanks for doing this.
Comment at: lib/Driver/Driver.cpp:1554
@@ -1551,1 +1553,3 @@
+Args.hasArg(options::OPT_fsanitize_EQ))
+ Diag(clang::diag::warn_drv_sanitizers_and_nodefaultlibs);
}
How hard is to fire the w
bruno added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:276
@@ +275,3 @@
+def warn_drv_sanitizers_and_nodefaultlibs : Warning<
+ "Passing -nodefaultlibs and -fsanitize has resulted in linking sanitizer
runtimes.">,
+ InGroup>;
What
bruno added inline comments.
Comment at: docs/CommandGuide/clang.rst:114
@@ -110,1 +113,3 @@
+ compiler-rt.
+
.. option:: -ansi
zlei wrote:
> bruno wrote:
> > It might be worth mentioning what's the default behaviour in case the flag
> > isn't specified?
> This
On Wed, Aug 31, 2016 at 11:00 PM, Justin Bogner wrote:
> Chris Bieneman writes:
>> beanz created this revision.
>> beanz added reviewers: bogner, zaks.anna, bruno, filcab.
>> beanz added a subscriber: cfe-commits.
>> Herald added a subscriber: emaste.
>>
>> The FreeBSD and GNUTools drivers suppor
bruno added a comment.
Ping!
In https://reviews.llvm.org/D23852#529308, @aaron.ballman wrote:
> In https://reviews.llvm.org/D23852#525291, @doug.gregor wrote:
>
> > This will work, but it's *really* unfortunate to put tentative parsing into
> > this code path because tentative parsing is far fr
bruno added a comment.
Ping!
https://reviews.llvm.org/D23852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added a reviewer: rnk.
bruno added subscribers: cfe-commits, ahatanak.
Support lax conversions on compound assignment expressions like:
typedef __attribute__((vector_size(8))) double float64x1_t;
typedef __attribute__((vector_size(16))) double float64x2_t;
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added a subscriber: cfe-commits.
Currently, driver level warnings do not show option names (e.g. warning:
complain about foo [-Woption-name]) in a diagnostic unless
-fdiagnostics-show-option is explictly specified. OTOH, the driv
Author: bruno
Date: Tue Sep 13 15:04:35 2016
New Revision: 281383
URL: http://llvm.org/viewvc/llvm-project?rev=281383&view=rev
Log:
[SemaObjC] Be more strict while parsing type arguments and protocols
Fix a crash-on-invalid.
When parsing type arguments and protocols,
parseObjCTypeArgsOrProtocolQ
bruno closed this revision.
bruno added a comment.
Thanks Doug!
Committed r281383
https://reviews.llvm.org/D23852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a subscriber: bruno.
bruno added a comment.
Hi Paul,
I'm interested in this patch. Do you have any plans to wrap it up?
https://reviews.llvm.org/D16533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
bruno added a comment.
Ping!
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Thu Mar 16 18:19:00 2017
New Revision: 298013
URL: http://llvm.org/viewvc/llvm-project?rev=298013&view=rev
Log:
[Headers] Reapply: Add #include_next for tgmath.h on Darwin
Reapply r289181 but rename the include guard to avoid
conflict with the one from Darwin.
Allow darwin to
Author: bruno
Date: Thu Mar 16 18:18:55 2017
New Revision: 298012
URL: http://llvm.org/viewvc/llvm-project?rev=298012&view=rev
Log:
[Modules] Add documentation on private frameworks
Expand a bit on private modules with some guidance on how to write
them in the context of frameworks.
rdar://probl
Author: bruno
Date: Fri Mar 17 19:26:18 2017
New Revision: 298175
URL: http://llvm.org/viewvc/llvm-project?rev=298175&view=rev
Log:
[Modules] In case of lock timeout, fallback and build module
Duncan's r298165 introduced the PCMCache mechanism, which guarantees
that locks aren't necessary anymore
Author: bruno
Date: Tue Mar 21 11:43:51 2017
New Revision: 298391
URL: http://llvm.org/viewvc/llvm-project?rev=298391&view=rev
Log:
[Modules] Find PrivateHeaders when looking into subframeworks
Fix the current parsing of subframeworks in modulemaps to lookup for
headers based on whether they are
Author: bruno
Date: Tue Mar 21 19:11:21 2017
New Revision: 298464
URL: http://llvm.org/viewvc/llvm-project?rev=298464&view=rev
Log:
[Modules] Rebuild modules on umbrella header mismatch
This restores behavior pre-r230064 since after PCMCache work (r298278)
we don't reload PCMs from disk within th
Author: bruno
Date: Tue Apr 11 23:49:00 2017
New Revision: 300027
URL: http://llvm.org/viewvc/llvm-project?rev=300027&view=rev
Log:
[Modules] Remove darwin specific code to check for SystemVersion.plist
This isn't need anymore and modules options -fbuild-session-file and
-fmodules-validate-once-p
Author: bruno
Date: Wed Apr 12 16:46:16 2017
New Revision: 300108
URL: http://llvm.org/viewvc/llvm-project?rev=300108&view=rev
Log:
[Modules] Enable local submodule visibility for ObjC/C
Remove the restriction where this is only valid with C++
rdar://problem/29055656
Differential Revision: http
Author: bruno
Date: Wed Apr 12 16:46:20 2017
New Revision: 300109
URL: http://llvm.org/viewvc/llvm-project?rev=300109&view=rev
Log:
[Driver] Add compiler option to generate a reproducer
One way to currently test the reproducers is to setup
"FORCE_CLANG_DIAGNOSTICS_CRASH=1" before invoking clang.
Hi Richard,
FTR, this caused http://bugs.llvm.org/show_bug.cgi?id=32693
Any suggestions on how to approach this?
On Fri, Feb 5, 2016 at 11:03 AM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Fri Feb 5 13:03:40 2016
> New Revision: 259901
>
> URL: http://llvm.org/viewvc/llvm-pr
Author: bruno
Date: Thu Jan 12 13:15:33 2017
New Revision: 291794
URL: http://llvm.org/viewvc/llvm-project?rev=291794&view=rev
Log:
[Modules] Fix misleading warning about missing textual header in umbrella header
When a textual header is present inside a umbrella dir but not in the
header, we get
Author: bruno
Date: Fri Jan 20 13:04:01 2017
New Revision: 292635
URL: http://llvm.org/viewvc/llvm-project?rev=292635&view=rev
Log:
[Sema] Remove dead typedef
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
http://llvm.org/viewvc/llvm-project
Author: bruno
Date: Tue Feb 7 15:54:57 2017
New Revision: 294361
URL: http://llvm.org/viewvc/llvm-project?rev=294361&view=rev
Log:
[PCH] Fix a regression when PCH is used with -fmodules
Following up on r291465 after a regression in r276159. When we use
-fmodule-name=X while building a PCH, modul
Author: bruno
Date: Tue Feb 7 15:55:02 2017
New Revision: 294362
URL: http://llvm.org/viewvc/llvm-project?rev=294362&view=rev
Log:
[ASTReader] Improve ReadASTBlock error message when module not available
Point to the PCM file that could not be found.
rdar://problem/30381981
Modified:
cfe/t
Hi Graydon,
Can you please add a testcase for this?
Thanks,
On Wed, Jun 28, 2017 at 11:36 AM, Graydon Hoare via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: graydon
> Date: Wed Jun 28 11:36:27 2017
> New Revision: 306583
>
> URL: http://llvm.org/viewvc/llvm-project?rev=306583&view
Author: bruno
Date: Fri Jun 30 17:06:27 2017
New Revision: 306917
URL: http://llvm.org/viewvc/llvm-project?rev=306917&view=rev
Log:
Change enumerator default linkage type for C
Redeclaration lookup should never find hidden enumerators in C, because
they do not have linkage (C11 6.2.2/6)
The link
Author: bruno
Date: Fri Jun 30 17:06:47 2017
New Revision: 306918
URL: http://llvm.org/viewvc/llvm-project?rev=306918&view=rev
Log:
[Modules] Implement ODR-like semantics for tag types in C/ObjC
Allow ODR for ObjC/C in the sense that we won't keep more that
one definition around (merge them). How
Awesome, thanks!
On Thu, Jul 6, 2017 at 11:49 AM, Mandeep Singh Grang via cfe-commits
wrote:
> Author: mgrang
> Date: Thu Jul 6 11:49:57 2017
> New Revision: 307296
>
> URL: http://llvm.org/viewvc/llvm-project?rev=307296&view=rev
> Log:
> [Objective-C] Fix non-determinism in clang
>
> Summary:
Author: bruno
Date: Mon Jul 17 14:52:31 2017
New Revision: 308225
URL: http://llvm.org/viewvc/llvm-project?rev=308225&view=rev
Log:
Check for _MSC_VER before defining _LIBCPP_MSVCRT
Some targets (e.g. Darwin) might have the Win32 API available, but they
do not use MSVC CRT. Assume _LIBCPP_MSVCRT
Author: bruno
Date: Wed Mar 1 13:18:42 2017
New Revision: 296656
URL: http://llvm.org/viewvc/llvm-project?rev=296656&view=rev
Log:
[PCH] Avoid VarDecl emission attempt if no owning module avaiable
This is a stopgap fix for PR31863, a regression introduced in r276159.
Consider this snippet:
str
Hi Eric,
> if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR
> @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER)
> message(WARNING "LLVM_USE_SANITIZER=${LLVM_USE_SANITIZER} is not
> supported on OS X")
>endif()
>if (LIBFILE)
> -execute_process(COMMAND ${CMAKE_CXX_
Author: bruno
Date: Mon Mar 13 23:12:29 2017
New Revision: 297703
URL: http://llvm.org/viewvc/llvm-project?rev=297703&view=rev
Log:
Fix cmake to find the compiler-rt libs on darwin
Followup for r297553, which left darwin in a broken state
http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgS
Hi Eric,
I fixed the build for darwin in r297703, let me know if you have any comments.
Thanks,
On Mon, Mar 13, 2017 at 3:04 PM, Bruno Cardoso Lopes
wrote:
> Hi Eric,
>
>> if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR
>> @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER)
>>
bruno added a comment.
Ping!
https://reviews.llvm.org/D26267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Thu Nov 17 15:41:22 2016
New Revision: 287262
URL: http://llvm.org/viewvc/llvm-project?rev=287262&view=rev
Log:
[CrashReproducer][Darwin] Suggest attaching .crash diagnostic file
In addition to the preprocessed sources file and reproducer script, also
point to the .crash diagn
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Very nice! LGTM
https://reviews.llvm.org/D25949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: bruno
Date: Thu Nov 17 16:45:31 2016
New Revision: 287275
URL: http://llvm.org/viewvc/llvm-project?rev=287275&view=rev
Log:
[Preprocessor] Support for '-dI' flag
Re-introduce r285411.
Implement the -dI as supported by GCC: Output ‘#include’ directives in addition
to the result of preproc
bruno added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:7978
+/// without causing truncation of Scalar.
+
+static bool tryGCCVectorConvertAndSpalt(Sema &S, ExprResult *Scalar,
Remove this empty line.
Comment at: lib/Sema/SemaExpr.cpp:799
bruno added a comment.
LGTM! Please add this before https://reviews.llvm.org/D26850, which should
contain a testcase on top of this!
Thanks
https://reviews.llvm.org/D25869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: bruno
Date: Wed Dec 7 17:20:30 2016
New Revision: 288994
URL: http://llvm.org/viewvc/llvm-project?rev=288994&view=rev
Log:
[Driver] Add tests for default stack protector values on Darwin
Modified:
cfe/trunk/test/Driver/stack-protector.c
Modified: cfe/trunk/test/Driver/stack-protecto
Author: bruno
Date: Wed Dec 7 18:22:06 2016
New Revision: 289005
URL: http://llvm.org/viewvc/llvm-project?rev=289005&view=rev
Log:
[Driver][Darwin] Disable default stack protector levels in freestanding mode.
Currently -fstack-protector is on by default when using -ffreestanding.
Change the defa
Author: bruno
Date: Wed Dec 7 20:13:56 2016
New Revision: 289018
URL: http://llvm.org/viewvc/llvm-project?rev=289018&view=rev
Log:
[Headers] Enable #include_next on Darwin
Allows darwin targets to provide additional definitions and
implementation specifc values for float.h
rdar://problem/219614
Author: bruno
Date: Thu Dec 8 20:22:47 2016
New Revision: 289174
URL: http://llvm.org/viewvc/llvm-project?rev=289174&view=rev
Log:
[CrashReproducer] Rewrite relative include paths
When -fmodules is on, the reproducer invocation currently leave paths
for include-like flags as is. If the path is r
Author: bruno
Date: Thu Dec 8 21:11:48 2016
New Revision: 289176
URL: http://llvm.org/viewvc/llvm-project?rev=289176&view=rev
Log:
[CrashReproducer] Provide a clean dir path for -fmodules-cache-path
The most common workflow with module reproducers involves deleting the
module cache before runnin
Author: bruno
Date: Thu Dec 8 21:30:46 2016
New Revision: 289181
URL: http://llvm.org/viewvc/llvm-project?rev=289181&view=rev
Log:
[Headers] Add #include_next for tgmath.h on Darwin
Allow darwin to provide additional definitions and implementation
specifc values for tgmath.h on Apple platforms.
Author: bruno
Date: Sat Dec 10 22:27:31 2016
New Revision: 289361
URL: http://llvm.org/viewvc/llvm-project?rev=289361&view=rev
Log:
[CrashReproducer] Setup a module collector callback for HeaderInclude
Collect missing include that cannot be fetched otherwise (e.g. when
using headermaps).
rdar://
Author: bruno
Date: Sat Dec 10 22:27:28 2016
New Revision: 289360
URL: http://llvm.org/viewvc/llvm-project?rev=289360&view=rev
Log:
[CrashReproducer] Collect headermap files
Include headermaps (.hmap files) in the .cache directory and
add VFS entries. All headermaps are known after HeaderSearch
s
Author: bruno
Date: Mon Dec 12 13:28:21 2016
New Revision: 289459
URL: http://llvm.org/viewvc/llvm-project?rev=289459&view=rev
Log:
[Frontend] Use vfs for directory iteration while searching PCHs. NFCI
Use the vfs lookup instead of real filesytem and handle the case where
-include-pch is a direct
Author: bruno
Date: Mon Dec 12 13:28:25 2016
New Revision: 289460
URL: http://llvm.org/viewvc/llvm-project?rev=289460&view=rev
Log:
[CrashReproducer] Collect PCH included via -include-pch
Collect the necessary input PCH files.
Do not try to validate the AST before copying it out because if the
c
Author: bruno
Date: Mon Dec 12 16:41:20 2016
New Revision: 289478
URL: http://llvm.org/viewvc/llvm-project?rev=289478&view=rev
Log:
[Modules] Make header inclusion order from umbrella dirs deterministic
Sort the headers by name before adding the includes in
collectModuleHeaderIncludes. This makes
Author: bruno
Date: Mon Dec 12 17:06:58 2016
New Revision: 289487
URL: http://llvm.org/viewvc/llvm-project?rev=289487&view=rev
Log:
Revert "[Headers] Add #include_next for tgmath.h on Darwin"
Reverts r289181: it's currently breaking modules using simd.h in
10.12 SDK.
This reverts commit 6e73e346
Author: bruno
Date: Mon Dec 12 17:22:30 2016
New Revision: 289494
URL: http://llvm.org/viewvc/llvm-project?rev=289494&view=rev
Log:
Revert "[Modules] Make header inclusion order from umbrella dirs deterministic"
Reverts commit r289478.
This broke
http://lab.llvm.org:8011/builders/clang-ppc64be-l
Author: bruno
Date: Mon Apr 24 16:58:13 2017
New Revision: 301261
URL: http://llvm.org/viewvc/llvm-project?rev=301261&view=rev
Log:
[Modules] Fix test to wipe out the cache before using it
This should appease bots:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental_check/35914
On Tue, Apr 25, 2017 at 6:29 AM, Aaron Ballman wrote:
> On Wed, Dec 7, 2016 at 9:13 PM, Bruno Cardoso Lopes via cfe-commits
> wrote:
>> Author: bruno
>> Date: Wed Dec 7 20:13:56 2016
>> New Revision: 289018
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev
On Tue, Apr 25, 2017 at 2:34 PM, Aaron Ballman wrote:
> On Tue, Apr 25, 2017 at 5:33 PM, Bruno Cardoso Lopes
> wrote:
>> On Tue, Apr 25, 2017 at 6:29 AM, Aaron Ballman
>> wrote:
>>> On Wed, Dec 7, 2016 at 9:13 PM, Bruno Cardoso Lopes via cfe-commits
>>>
Author: bruno
Date: Wed Apr 26 00:06:20 2017
New Revision: 301382
URL: http://llvm.org/viewvc/llvm-project?rev=301382&view=rev
Log:
[Modules][ObjC] Check definition from canonical decl on designated initializers
Use definition from canonical decl when checking for designated
initializers. This is
Author: bruno
Date: Wed Apr 26 15:13:45 2017
New Revision: 301453
URL: http://llvm.org/viewvc/llvm-project?rev=301453&view=rev
Log:
[Modules] Fix a crash-on-invalid with overloaded functions
Do not add an overload if the function doesn't have a prototype; this
can happen if, for instance, a mispl
Author: bruno
Date: Thu Apr 27 17:29:10 2017
New Revision: 301596
URL: http://llvm.org/viewvc/llvm-project?rev=301596&view=rev
Log:
[Modules] Refactor logic for incomplete umbrella warnings. NFC
Modified:
cfe/trunk/include/clang/Lex/Preprocessor.h
cfe/trunk/lib/Lex/PPLexerChange.cpp
Modi
Author: bruno
Date: Thu Apr 27 17:29:14 2017
New Revision: 301597
URL: http://llvm.org/viewvc/llvm-project?rev=301597&view=rev
Log:
[Modules] Improve diagnostics for incomplete umbrella
One of the -Wincomplete-umbrella warnings diagnoses when a header is present in
the directory but it's not pres
r 27, 2017 at 3:29 PM, Bruno Cardoso Lopes via cfe-commits
wrote:
> Author: bruno
> Date: Thu Apr 27 17:29:14 2017
> New Revision: 301597
>
> URL: http://llvm.org/viewvc/llvm-project?rev=301597&view=rev
> Log:
> [Modules] Improve diagnostics for incomplete umbrella
>
&g
On Thu, Apr 27, 2017 at 6:49 PM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Thu Apr 27 20:49:42 2017
> New Revision: 301610
>
> URL: http://llvm.org/viewvc/llvm-project?rev=301610&view=rev
> Log:
> Move functionality for handling module maps as inputs from the -emit-module
> act
Thanks!!
On Thu, Apr 27, 2017 at 9:17 PM, NAKAMURA Takumi via cfe-commits
wrote:
> Author: chapuni
> Date: Thu Apr 27 23:17:31 2017
> New Revision: 301613
>
> URL: http://llvm.org/viewvc/llvm-project?rev=301613&view=rev
> Log:
> clang/test/Index/index-module.m: Relax expressions to satisfy DOSish
Author: bruno
Date: Mon May 8 19:41:38 2017
New Revision: 302491
URL: http://llvm.org/viewvc/llvm-project?rev=302491&view=rev
Log:
[Modules] Allow umbrella frameworks to define private submodules for
subframeworks
In r298391 we fixed the umbrella framework model to work when submodules
named "P
Author: bruno
Date: Thu May 11 01:20:07 2017
New Revision: 302765
URL: http://llvm.org/viewvc/llvm-project?rev=302765&view=rev
Log:
[Sema] Improve redefinition errors pointing to the same header
Diagnostics related to redefinition errors that point to the same header
file do not provide much info
Author: bruno
Date: Thu May 11 02:06:52 2017
New Revision: 302771
URL: http://llvm.org/viewvc/llvm-project?rev=302771&view=rev
Log:
Make tests from r302765 windows friendly
and appease:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2030
Modified:
cfe/trunk/t
bruno added a comment.
Nice! Thanks
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM!
https://reviews.llvm.org/D25641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Ok, great!
LGTM
https://reviews.llvm.org/D24669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
bruno added a comment.
> The long answer is that there is a history of problems regarding the
> intrinsic files:
> http://lists.llvm.org/pipermail/cfe-dev/2016-May/048837.html
> http://lists.llvm.org/pipermail/cfe-dev/2016-September/050943.html
> Mainly compatibility issues because MSVC make
Hi,
On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith wrote:
> On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes
> wrote:
>>
>> Hi Richard,
>>
>> I have a patch on top of your suggested patch from a year ago, that
>> break the cyclic dependency we're seeing, with this (and a few changes
>> to t
bruno added a reviewer: bruno.
bruno added a comment.
Can you add a testcase for that?
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
bruno accepted this revision.
bruno added a comment.
Ok, thanks! LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> @Bruno,
>
> Can you try "-fdiagnostics-show-note-include-stack” so we know the other path
> that leads to string.h?
Attached the complete error log (this snippet won't help without full
context anyway)
--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
output.log
Description: Binary data
_
Hi Richard,
Turns out that the redefinition error was caused because libc++
modulemap lacked a module for its "string.h", and therefore it would
be textually included in more than one module, yielding the error.
With the attached patch for libc++ modulemap (extracted from parts of
a modulemap you
bruno added a comment.
Thanks for looking into this. It's a nice FixIt to have.
I don't see any dep cycle; clangFormat depends on clangToolingCore, which also
depends clangRewrite, which means there are going to be 3 new dependencies for
libSema in the end: clangToolingCore, clangRewrite and cl
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3903
+if (!Data.split('.').first.getAsInteger(10, MajorVersion)) {
+ switch (MajorVersion) {
+case 5:
clang-format the `switch`: `case`'s should be aligned with it.
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Very nice!
LGTM
https://reviews.llvm.org/D25819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: bruno
Date: Thu Oct 20 20:41:56 2016
New Revision: 284797
URL: http://llvm.org/viewvc/llvm-project?rev=284797&view=rev
Log:
[Modules] Add 'no_undeclared_includes' module map attribute
The 'no_undeclared_includes' attribute should be used in a module to
tell that only non-modular headers a
Author: bruno
Date: Thu Oct 20 20:49:14 2016
New Revision: 284798
URL: http://llvm.org/viewvc/llvm-project?rev=284798&view=rev
Log:
[Driver][Darwin] Pass -no_deduplicate to ld64
Recent versions of ld64 run a deduplicate pass, which is on by default.
Disable the pass by using -no_deduplicate in ce
Author: bruno
Date: Thu Oct 20 22:14:27 2016
New Revision: 284801
URL: http://llvm.org/viewvc/llvm-project?rev=284801&view=rev
Log:
[ModuleMap] Add more module entries to cover some non modular headers
These modules are necessary on Darwin to allow modules with
'no_undeclared_includes' (introduce
Thanks Ben!
On Fri, Oct 21, 2016 at 3:19 AM, Benjamin Kramer via cfe-commits
wrote:
> Author: d0k
> Date: Fri Oct 21 05:19:37 2016
> New Revision: 284815
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284815&view=rev
> Log:
> Remove non-existing file from modulemap.
>
> This picked up a builtin
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3937
+StringRef Data = File.get()->getBuffer();
+SmallVector Lines;
+Data.split(Lines, "\n");
This file usually has 5-6 lines, can you use 8 instead?
Comment at: lib
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3942
+ int Version;
+ if (SplitLine.first.trim() != "VERSION")
+continue;
You can check `Line.trim() != VERSION` before the `split` as to do not try to
split unnecessary lines.
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3942
+ int Version;
+ if (SplitLine.first.trim() != "VERSION")
+continue;
mgorny wrote:
> bruno wrote:
> > You can check `Line.trim() != VERSION` before the `split` as to do not
> Sure, go ahead.
I committed in r284797 and r284801 (libcxx). There's one minor issue
I've found: the changes for the builtins affecting non submodule local
visibility broke current users of plain "-fmodules" against our
frameworks in public SDKs, in 10.11 & 10.12. I've attached a patch to
work a
On Mon, Oct 24, 2016 at 4:17 PM, Richard Smith wrote:
> On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes
> wrote:
>>
>> > Sure, go ahead.
>>
>> I committed in r284797 and r284801 (libcxx). There's one minor issue
>> I've found: the changes for the builtins affecting non submodule local
>> vis
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
bruno added a comment.
This is great!
Comment at: unittests/Driver/ToolChainsTest.cpp:154
+
"BUG_REPORT_URL=\"https://bugs.debian.org/\"\n";));
+ ASSERT_EQ(DebianStretch, DetectDistro(DebianStretchSidFileSystem));
+}
Can
bruno added a comment.
Hi,
Nice, thanks for working on this!
Comment at: lib/Sema/SemaExpr.cpp:8051
+ if (!LHSVecType) {
+assert(RHSVecType && "RHSVecType is not a vector!");
if (!tryVectorConvertAndSplat(*this, (IsCompAssign ? nullptr : &LHS),
`tryV
Author: bruno
Date: Thu Oct 27 21:30:45 2016
New Revision: 285377
URL: http://llvm.org/viewvc/llvm-project?rev=285377&view=rev
Log:
[Modules] Add testcase for builtins used in umbrella headers
This used to work before r284797 + r285152, which exposed something
interesting; some users include buil
201 - 300 of 545 matches
Mail list logo
